On Tue, 16 Jan 2018 08:43:40 +0100
Arnd Bergmann <a...@arndb.de> wrote:
> The omap2 onenand driver is now available for compile-testing, which
> uncovers a warning in configurations that have a 64-bit resource_size_t:
>
> drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
> drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of
> type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long
> unsigned int}' [-Werror=format=]
> dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
> drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of
> type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long
> unsigned int}' [-Werror=format=]
>
> Changing the format string to the special %pR simplifies the code
> and lets it do the right thing in that configuration, while avoiding
> the warning.
>
Applied. I'll adjust my PR to include this fix.
Thanks,
Boris
> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
> drivers/mtd/onenand/omap2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2ce73fb6da1c..a4a2159bcfb7 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device
> *pdev)
>
> c->onenand.base = devm_ioremap_resource(dev, res);
> if (IS_ERR(c->onenand.base)) {
> - dev_err(dev, "Cannot reserve memory region at 0x%08x, size:
> 0x%x\n",
> - res->start, resource_size(res));
> + dev_err(dev, "Cannot reserve memory region %pR\n", res);
> return PTR_ERR(c->onenand.base);
> }
>
