[PATCH] regulator: qcom_spmi: Improve readability for setting up enable/mode pin control

By checking data->pin_ctrl_enable / data->pin_ctrl_hpm flags first, then use switch-case to improve readability. Signed-off-by: Axel Lin --- drivers/regulator/qcom_spmi-regulator.c | 70 - 1 file changed, 34 insertions(+), 36 deletions(-) diff --git a/drivers/reg

[PATCH] regulator: cros-ec-regulator: Add NULL test for devm_kmemdup call

Fix possible NULL pointer dereference. Signed-off-by: Axel Lin --- drivers/regulator/cros-ec-regulator.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/regulator/cros-ec-regulator.c b/drivers/regulator/cros-ec-regulator.c index 3117bbd2826b..eb3fc1db4edc 100644 --- a/drivers

[PATCH] regulator: lp8755: Get rid of lp8755_read/lp8755_write/lp8755_update_bits

Just use regmap_read/regmap_write/regmap_update_bits instead. Signed-off-by: Axel Lin --- drivers/regulator/lp8755.c | 82 ++ 1 file changed, 21 insertions(+), 61 deletions(-) diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c index

[PATCH] regulator: rt4801: Select REGMAP_I2C to fix build error

Fix build error when CONFIG_REGMAP_I2C is not set. Signed-off-by: Axel Lin --- drivers/regulator/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index ebce11cbab44..f719ed5a8c33 100644 --- a/drivers/regulator/Kconfig +++ b

Re: [PATCH] spi: mediatek: Re-license MTK SPI driver as Dual MIT/GPL

Leilk Liu 於 2021年3月3日 週三 上午10:57寫道： > > From: "leilk.liu" > > It is wanted to use MTK spi bus driver with GPL-2.0 or MIT license. > But now it is only licensed as GPL-2.0, so re-license it as dual > MIT/GPL. > > Signed-off-by: leilk.liu Acked-by: Axel Lin

[PATCH] regulator: mt6315: Fix off-by-one for .n_voltages

The valid selector is 0 ~ 0xbf, so the .n_voltages should be 0xc0. Signed-off-by: Axel Lin --- drivers/regulator/mt6315-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6315-regulator.c b/drivers/regulator/mt6315-regulator.c index fc7654624dd6

[PATCH] regulator: pf8x00: Fix typo for PF8200 chip name

Trivial typo fix. Signed-off-by: Axel Lin --- drivers/regulator/pf8x00-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pf8x00-regulator.c b/drivers/regulator/pf8x00-regulator.c index 827da25466cc..9b28bd63208d 100644 --- a/drivers/regulator

[PATCH RFC] regulator: anatop: Remove checking control_reg in [set|get]_voltage_sel

safe to remove testing if control_reg is 0. Signed-off-by: Axel Lin --- drivers/regulator/anatop-regulator.c | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c index 38

kernel BUG at kernel/kallsyms.c:222!

Hi, I got below oops while debugging a sd controller driver: [4.032026] [ cut here ] [4.036730] kernel BUG at kernel/kallsyms.c:222! [4.041501] Internal error: Oops - BUG: 0 [#1] ARM [4.046847] CPU: 0 PID: 6 Comm: kworker/u2:0 Not tainted 3.12.0-00061-g0835

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/7 Ming Lei : > Hi, > > On Thu, Nov 7, 2013 at 9:53 AM, Axel Lin wrote: >> Hi, >> I got below oops while debugging a sd controller driver: >> >> [4.032026] [ cut here ] >> [4.036730] kernel BUG at kernel/kallsyms.c:222!

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/7 Ming Lei : > On Thu, Nov 7, 2013 at 10:18 AM, Axel Lin wrote: >> 2013/11/7 Ming Lei : >>> Could you share what is the value of CONFIG_PAGE_OFFSET >>> on your noMMU platform? >> >> $ grep CONFIG_PAGE_OFFSET .config >> CONFIG_PAGE_OFFSET=0x

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/7 Ming Lei : > Hi, > > On Thu, Nov 7, 2013 at 10:47 AM, Axel Lin wrote: >> >> hi Ming, >> Seems CONFIG_PAGE_OFFSET is not configurabe in "make menuconfig". >> And I found CONFIG_PAGE_OFFSET=0xC000 for all below configs... >> $ make at

[PATCH 1/3] regulator: bcm590xx: Make the modalias matches the driver name

Signed-off-by: Axel Lin --- drivers/regulator/bcm590xx-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c index e6b2e8e..d12d6d6 100644 --- a/drivers/regulator/bcm590xx-regulator.c +++ b

[PATCH 2/3] regulator: bcm590xx: Remove **rdev from struct bcm590xx_reg

The **rdev of 'struct bcm590xx_reg' isn't used anywhere in the driver so remove it. Signed-off-by: Axel Lin --- drivers/regulator/bcm590xx-regulator.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm59

[PATCH 3/3] regulator: bcm590xx: Use array to save desc and *info

BCM590XX_NUM_REGS is known in compile time. Use array to save desc and *info makes the code simpler. Signed-off-by: Axel Lin --- drivers/regulator/bcm590xx-regulator.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/bcm590xx-regulator.c

[PATCH] mfd: bcm590xx: Fix type argument for module device table

: Axel Lin --- drivers/mfd/bcm590xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c index 926a57e..e9a33c7 100644 --- a/drivers/mfd/bcm590xx.c +++ b/drivers/mfd/bcm590xx.c @@ -68,7 +68,7 @@ static const struct of_device_id

Re: [PATCH] spi: sc18is602: Don't be that restrictive with the maximum transfer speed

2014-03-17 9:47 GMT+08:00 Guenter Roeck : > Commit 09e99bca8 (spi: sc18is602: Convert to let spi core validate > transfer speed) made the maximum transfer speed much more restrictive > than before. The transfer speed used to be adjusted to 1/4 of the chip > clock rate if a higher transfer speed was

[PATCH] regulator: pfuze100: Add terminate entry for [i2c|of]_device_id tables

'pfuze_device_id') [enabled by default] drivers/regulator/pfuze100-regulator.c:93:2: warning: excess elements in array initializer [enabled by default] drivers/regulator/pfuze100-regulator.c:93:2: warning: (near initialization for 'pfuze_dt_ids') [enabled by default] Sig

[PATCH] regulator: pfuze100: Add PFUZE200 support to Kconfig and module description

Signed-off-by: Axel Lin --- drivers/regulator/Kconfig | 6 +++--- drivers/regulator/pfuze100-regulator.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 4ddfb6c..eb36d8b 100644 --- a/drivers/regulator

[PATCH RFT] regulator: pbias: Convert to use regmap helper functions

000. 2) The is_enable implementation is wrong in some cases: e.g. for pbias_mmc_omap5: emable_mask is : BIT(27) | BIT(25) | BIT(26) However, pbias_regulator_enable() only sets BIT(26) | BIT(22) bits. So is_enable always return false in this case. Signed-off-by: Axel Lin --- Hi Balaji, I do

Re: [PATCH 3/3] regulator: bcm590xx: Use array to save desc and *info

2014-03-20 23:42 GMT+08:00 Matt Porter : > On Fri, Mar 14, 2014 at 10:00:28AM +0800, Axel Lin wrote: >> BCM590XX_NUM_REGS is known in compile time. >> Use array to save desc and *info makes the code simpler. >> >> Signed-off-by: Axel Lin > > Well, ok. It was cod

[PATCH RFT] regulator: s5m8767: Convert to use regulator_[enable|disable|is_enabled]_regmap

Since commit ca5d1b3524b4d "regulator: helpers: Modify helpers enabling multi-bit control", we can set enable_val setting for device that use multiple bits for control. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 78 +++-- 1 file c

[PATCH 2/2] regulator: s2mps11: Don't check enable_shift before setting enable ramp rate

Current code misses updating the register when enable_shift is 0. e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0. Signed-off-by: Axel Lin --- drivers/regulator/s2mps11.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/regulator

[PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Signed-off-by: Axel Lin --- drivers/regulator/s2mpa01.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator

[PATCH 1/3 v2] regulator: tps65218: Add terminate entry for of_device_id table

Fixes below build error: FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry! Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/tps65218-regulator.c b

[PATCH 2/3 v2] regulator: tps65218: Remove unnecessary regulator_unregister call

Current code uses devm_regulator_register() so the we don't need to explicitly call regulator_unregister() in .remove. And then we don't need to save rdev pointer to tps->rdev[id]. Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 18 -- 1 fil

[PATCH 1/3 v2] regulator: tps65218: Add terminate entry for of_device_id table

Fixes below build error: FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry! Signed-off-by: Axel Lin --- I'm sorry that I just found I CC wrong developers in my previous mail. So here is a resend. drivers/regulator/tps65218-regulator.c | 1

[PATCH 2/3 v2] regulator: tps65218: Remove unnecessary regulator_unregister call

Current code uses devm_regulator_register() so the we don't need to explicitly call regulator_unregister() in .remove. And then we don't need to save rdev pointer to tps->rdev[id]. Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 18 -- 1 fil

[PATCH 3/3 v2] regulator: tps65218: Add OF dependency

This is a DT-only driver, so make it depend on OF and remove of_match_ptr in the code. Signed-off-by: Axel Lin --- drivers/regulator/Kconfig | 2 +- drivers/regulator/tps65218-regulator.c | 14 ++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH] regulator: tps65217: Allow missing init_data for diagnostics

The regulator core supports this to allow the configuration to be inspected at runtime even if no software management is enabled. Signed-off-by: Axel Lin --- drivers/regulator/tps65217-regulator.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers

Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

2014-03-08 11:55 GMT+08:00 Axel Lin : > The is_enabled implementation is wrong in some cases: > e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26) > However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits. > So is_enabled callback will always return f

[PATCH] pinctrl: adi2: Statize adi_gpio_irq_domain_ops

It's only referenced in this file, make it static. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-adi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index 0cc0eec..5c44feb 100644 --- a/drivers/pi

[PATCH] pinctrl: lantiq: Fix header file include guard

Define __PINCTRL_LANTIQ_H to prevent multiple inclusion. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-lantiq.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-lantiq.h b/drivers/pinctrl/pinctrl-lantiq.h index 6d07f02..c7cfad5 100644 --- a/drivers/pinctrl

[PATCH RFC] leds: pca9685: Remove leds-pca9685 driver

This driver is replaced by pwm-pca9685 driver and there is no user uses this driver in current tree. So remove it. Signed-off-by: Axel Lin --- Hi, I found there is a modalias conflict between leds-pca9685.ko and pwm-pca9685.ko. I think this conflict will cause problem. After checking the code, I

Re: [PATCH RFC] leds: pca9685: Remove leds-pca9685 driver

2014-04-06 17:30 GMT+08:00 Steffen Trumtrar : > Hi! > > On Sun, Apr 06, 2014 at 11:19:41AM +0800, Axel Lin wrote: >> This driver is replaced by pwm-pca9685 driver and there is no user uses this >> driver in current tree. So remove it. >> >> Signed-off-by: Axel Li

ARM: nommu: Unable to allocate RAM for process text/data, errno 12

Hi, I got below error messages while starting mdev (busybox). / # free total used free shared buffers Mem: 23628 8924147040 72 -/+ buffers: 885214776 / # exec /sbin/init Starting logging: O

[PATCH RESEND] regulator: lp3971: Convert to devm_regulator_register

Both num_regulators and **rdev are no longer required after this conversion, thus remove them from struct lp3971. Signed-off-by: Axel Lin --- Hi Mark, This patch was sent on https://lkml.org/lkml/2013/11/13/34 . Although you replied applied, it still not in your tree. So here is a resend. Axel

Re: ARM: nommu: Unable to allocate RAM for process text/data, errno 12

2013/11/27 Andrew Morton : > On Tue, 26 Nov 2013 17:29:29 +0800 Axel Lin wrote: > >> Hi, >> I got below error messages while starting mdev (busybox). >> >> ... >> >> [ 108.537109] chmod: page allocation failure: order:8, mode:0xd0 > > It w

[PATCH] include/linux/kernel.h: Make might_fault to be a nop for !MMU

rch/arm/kernel/signal.c:176: undefined reference to `might_fault' arch/arm/kernel/built-in.o:arch/arm/kernel/signal.c:177: more undefined references to `might_fault' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin Cc: Michael S. Tsirkin Cc: Peter Zijlstra --- include/linux/kern

[RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator

Change the device name of the regulator function to the one chosen for MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function. Signed-off-by: Axel Lin --- Hi, I don't have the hardware to test, but I think this needs fix. We have a similar fix in commit ec8da805c43a

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/8 Rusty Russell : > Axel Lin writes: >> 2013/11/7 Ming Lei : >>> Hi, >>> >>> On Thu, Nov 7, 2013 at 10:47 AM, Axel Lin wrote: >>>> >>>> hi Ming, >>>> Seems CONFIG_PAGE_OFFSET is not configurabe in "make menu

[PATCH RESEND] irqchip: sun4i: Don't write to read-only registers

sun4i_of_init(). [1] http://dl.linux-sunxi.org/A10/A10%20User%20Manual%20-%20v1.20%20%282012-04-09%2c%20DECRYPTED%29.pdf Signed-off-by: Axel Lin Acked-by: Maxime Ripard --- Hi Thomas, This patch was sent on https://lkml.org/lkml/2013/7/6/59 with Maxime's Ack. And re-sent on https://lkml.org

Re: kernel BUG at kernel/kallsyms.c:222!

>>> Hi Ming, >>> >>> I found in arch/arm/include/asm/memory.h: >>> CONFIG_PAGE_OFFSET is not used if !CONFIG_MMU. >>> So looks like setting CONFIG_PAGE_OFFSET to other value still won't work. >> >> This seems like the simplest solution, but it may mean you still have >> crap in /proc/kallsyms. >> >

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/11 Rusty Russell : > Ming Lei writes: >> Hi Axel, >> >> On Fri, Nov 8, 2013 at 12:20 PM, Axel Lin wrote: >>> >>> >>> Hi Ming, >>> >>> I have patches on top of 3.12 to support gpl32700 SoC. >>> So you cannot fi

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/11 Ming Lei : > Hi, > > On Mon, Nov 11, 2013 at 2:43 PM, Axel Lin wrote: >> 2013/11/11 Rusty Russell : >> >> Hi Rusty, >> >> I don't have other noMMU platform to test. >> But I think this issue impacts various !CONFIG_MMU platforms: &

[PATCH 1/2] regulator: lp3971: Convert to devm_regulator_register

Both num_regulators and **rdev are no longer required after this conversion, thus remove them from struct lp3971. Signed-off-by: Axel Lin --- drivers/regulator/lp3971.c | 43 ++- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers

[PATCH 2/2] regulator: lp3972: Convert to devm_regulator_register

Both num_regulators and **rdev are no longer required after this conversion, thus remove them from struct lp3972. Signed-off-by: Axel Lin --- drivers/regulator/lp3972.c | 41 ++--- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/drivers

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/12 Ming Lei : > On Tue, Nov 12, 2013 at 3:32 AM, Russell King - ARM Linux > wrote: >> On Mon, Nov 11, 2013 at 05:15:29PM +, Jonathan Austin wrote: >>> I've tested the patch below and it solves the ARM side of things - so >>> gives you an option other than a complete revert. Happy to pu

[PATCH] Revert "regulator: da9052: Use apply_[reg|bit] with regmap based voltage_sel operations"

This reverts commit 68f7506017ba67f1334cf086ffab76606f2c5ac4. Michael reported that with this patch we loose the fix_io code path from da9052_reg_update. Thus revert it. Reported-by: Michael Grzeschik Signed-off-by: Axel Lin --- Hi Mark, I'm busy recently and not able to cook a proper f

Build error for nommu if CONFIG_DEBUG_ATOMIC_SLEEP is selected

Hi Michael, I got below build error for nommu if CONFIG_DEBUG_ATOMIC_SLEEP is selected. Also got the same build error if CONFIG_PROVE_LOCKING is selected. Seems this issue is introduced by commit 662bbcb2747c2 "mm, sched: Allow uaccess in atomic with pagefault_disable()". arch/arm/kernel/built-i

Re: Build error for nommu if CONFIG_DEBUG_ATOMIC_SLEEP is selected

2013/10/18 Michael S. Tsirkin : > On Fri, Oct 18, 2013 at 05:27:55PM +0800, Axel Lin wrote: >> Hi Michael, >> >> I got below build error for nommu if CONFIG_DEBUG_ATOMIC_SLEEP is selected. >> Also got the same build error if CONFIG_PROVE_LOCKING is selected. >> >

[PATCH] clocksource: time-efm32: Select CLKSRC_MMIO

The time-efm32 driver uses the clocksource MMIO functions. Thus it needs to select CLKSRC_MMIO in Kconfig. Signed-off-by: Axel Lin --- This fixes build error when COMPILE_TEST=y. drivers/built-in.o: In function `efm32_clocksource_init': drivers/clocksource/time-efm32.c:162: undefined refe

[PATCH] ramfs: nommu: Statize ramfs_nommu_get_unmapped_area and ramfs_nommu_mmap

Since commit 853ac43ab194f "shmem: unify regular and tiny shmem", ramfs_nommu_get_unmapped_area() and ramfs_nommu_mmap() are not directly referenced outside of file-nommu.c. Thus make them static. Signed-off-by: Axel Lin --- fs/ramfs/file-nommu.c | 10 -- include/linux/ra

[PATCH] clocksource: bcm_kona_timer: Remove unused bcm_timer_ids

bcm_timer_ids is no longer used after converting to CLOCKSOURCE_OF_DECLARE. Signed-off-by: Axel Lin --- drivers/clocksource/bcm_kona_timer.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c index 0d7d8c3

ARM: nommu: DEBUG_LOCKS_WARN_ON(!depth)

I'm testing on a nommu platform (arm7tdmi SoC). Using current Linus' tree + out-of-tree patches for this SoC. I got below hang while executing ls (busybox) after boot. / # ls [ 51.036191] [ cut here ] [ 51.042242] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3312

ARM: nommu: Boot hang after VFS: Mounted root (ext2 filesystem) on device 1:0.

Hi, I got hangup at boot after "VFS: Mounted root (ext2 filesystem) on device 1:0.". I'm using ext2 initrd as root. It seems hangup after mount root, but in the progress of mounting devtmpfs. After debug it, I found it hangs at calling page_cache_release. Note, I'm testing on an nommu platform (ar

Re: ARM: nommu: Boot hang after VFS: Mounted root (ext2 filesystem) on device 1:0.

2013/11/26 Uwe Kleine-König : > Hello, > > On Mon, Nov 25, 2013 at 11:26:00PM +0800, Axel Lin wrote: >> I got hangup at boot after "VFS: Mounted root (ext2 filesystem) on device >> 1:0.". >> I'm using ext2 initrd as root. > which mainline version are

BUG: sleeping function called from invalid context at kernel/locking/mutex.c:616

Hi, I got below messages while booting. Testing on a nommu platform with 3.13.0-rc2 + patches for this SoC. VFS: Mounted root (jffs2 filesystem) on device 31:1. devtmpfs: mounted Freeing unused kernel memory: 92K (003a4000 - 003bb000) BUG: sleeping function called from invalid context at kernel/lo

[PATCH] pinctrl: abx500: Fix header file include guard

Fix a trivial typo. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-abx500.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-abx500.h b/drivers/pinctrl/pinctrl-abx500.h index eeca8f9..8229380 100644 --- a/drivers/pinctrl/pinctrl-abx500.h +++ b

Re: kernel BUG at kernel/kallsyms.c:222!

2013/11/13 Ming Lei : > Hi Axel, > > On Wed, Nov 13, 2013 at 5:58 PM, Axel Lin wrote: >> >> Hi Ming, >> You missed "; then" in the end of if statement in your patch. >> >> So I got below error with your patch: >> scripts/link-vmlinux.sh: l

Re: [PATCH] devtmpfs: Calling delete_path() only when necessary

2013/12/4 Rob Landley : > On 11/16/2013 02:15:23 AM, Axel Lin wrote: >> >> The deleted variable is always 1 in current code. >> Initialize deleted variable to be 0, so delete_path() will be called only >> when >> necessary. >> >> Signed-off-by: Axel Lin

Re: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:616

cve+0x0/0x528) from [<83e4>] (try_to_run_init_process+0x20/0x4c) [<83c4>] (try_to_run_init_process+0x0/0x4c) from [<002c74f0>] (kernel_init+0x98/0x104) r5:002c7458 r4:003e8300 [<002c7458>] (kernel_init+0x0/0x104) from [<9070>] (ret_from_fork+0x14

[RFT][PATCH] pinctrl: msm: Fix set gpio setting

Set g->out_bit bit for gpio output high, clear g->out_bit bit for gpio output low. Signed-off-by: Axel Lin --- Hi Bjorn, I don't have the datasheet, just found current code does not make sense because current code unconditionally set BIT(g->out_bit) in msm_gpio_set. I assume sett

[PATCH] regulator: da9211: Remove unnecessary devm_regulator_unregister() calls

Current code uses devm_regulator_register(), so the resource management code will ensure that the resource is freed. Signed-off-by: Axel Lin --- drivers/regulator/da9211-regulator.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH] mfd: rdc321x: Fix off-by-one for ngpio setting

The valid gpio is GPIO0 ~ GPIO58, so ngpio should be 59. This patch also renames RDC321X_MAX_GPIO to RDC321X_NUM_GPIO because it actually means the number of available GPIOs. Signed-off-by: Axel Lin Acked-by: Linus Walleij --- drivers/mfd/rdc321x-southbridge.c | 2 +- include/linux/mfd

[RESEND][PATCH v2] regulator: Add stub for devm_regulator_get_exclusive

Also makes regulator_get_exclusive and devm_regulator_get_exclusive stub functions return error pointer. Signed-off-by: Axel Lin --- Now drivers/gpu/drm/msm/hdmi/hdmi.c is using devm_regulator_get instead of devm_regulator_get_exclusive. commit 3e87599b68e7929a84a32ab65ad17b79a3f271f6 "dr

[PATCH 1/2] regulator: fan53555: Fixup report wrong vendor message

Signed-off-by: Axel Lin --- drivers/regulator/fan53555.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index f2f5535..70b31bf 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -267,8

[PATCH 2/2] regulator: fan53555: Fix null pointer dereference

Set di->regulator before dereference it. Signed-off-by: Axel Lin --- drivers/regulator/fan53555.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 70b31bf..c82fb9e 100644 --- a/drivers/regulator/fan5355

[PATCH] regulator: qcom_rpm: Don't explicitly initialise the first field of config

Doing so generates a warning as the first field is a pointer but we use 0 to initialize it. Signed-off-by: Axel Lin --- drivers/regulator/qcom_rpm-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm

[PATCH] regulator: qcom_rpm: Fix FORCE_MODE_IS_2_BITS macro

Current code does not take the macro parameter, fix it. This is not a problem at this moment because the only user actually passes vreg to FORCE_MODE_IS_2_BITS(). Signed-off-by: Axel Lin --- drivers/regulator/qcom_rpm-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] regulator: rk808: Remove unused variables

Also remove non-informative comment. Signed-off-by: Axel Lin --- drivers/regulator/rk808-regulator.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index d91f2b6..9557428 100644 --- a

[PATCH 2/2] regulator: rk808: Fix missing of_node_put

us add missing of_node_put(reg_np). Signed-off-by: Axel Lin --- drivers/regulator/rk808-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index 9557428..07b0eb4 100644 --- a/drivers/regulator/rk808-reg

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-06 23:20 GMT+08:00 Balaji T K : > On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: >> >> This patch converts this driver to use the regmap helper functions >> provided by >> regulator core. >> >> This fixes a few issues in current implementat

[PATCH 1/3] regulator: pbias: Fix is_enabled callback implementation

with info->enable rather than info->enable_mask. Signed-off-by: Axel Lin --- drivers/regulator/pbias-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-regulator.c index ded3b35..d89a1d8 100644

[PATCH 2/3] regulator: pbias: Convert to use regmap helper functions

This patch converts this driver to use the regmap helper functions provided by regulator core. Signed-off-by: Axel Lin --- drivers/regulator/pbias-regulator.c | 74 ++--- 1 file changed, 19 insertions(+), 55 deletions(-) diff --git a/drivers/regulator/pbias

[PATCH 3/3] regulator: pbias: Convert to use regulator_[enable|is_enabled]_regmap

Since commit ca5d1b3524b4d "regulator: helpers: Modify helpers enabling multi-bit control", we can set enable_val setting for device that use multiple bits for control when using regmap enable/disable/bypass ops. Signed-off-by: Axel Lin --- Note: This patch depends on below commit whi

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-07 23:25 GMT+08:00 Balaji T K : > On Thursday 06 March 2014 06:40 PM, Axel Lin wrote: >> >> This patch converts this driver to use the regmap helper functions >> provided by >> regulator core. >> >> This fixes a few issues in current implementat

[PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

with info->enable rather than info->enable_mask. Signed-off-by: Axel Lin Acked-by: Balaji T K --- v2: Update commit log and add Balaji's Ack. drivers/regulator/pbias-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pbias-regulator.c

[PATCH v2 2/2] regulator: pbias: Convert to use regmap helper functions

This patch converts this driver to use the regmap helper functions provided by regulator core. Signed-off-by: Axel Lin Acked-by: Balaji T K --- v2: Add Balaji's Ack. drivers/regulator/pbias-regulator.c | 74 ++--- 1 file changed, 19 insertions(+), 55 dele

[PATCH] regulator: tps6586x: Remove unnecessary rdev[] array

Now we are using devm_regulator_register(), so we don't need the rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin --- drivers/regulator/tps6586x-regulator.c | 14 -- 1 file chang

[PATCH] regulator: act8865: Remove unnecessary *rdev[] from struct act8865

Now we are using devm_regulator_register(), so we don't need the *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin --- drivers/regulator/act8865-regulator.c | 13 + 1 file chang

[PATCH 1/3] regulator: max77693: Remove unnecessary **rdev from struct max77693_pmic_dev

Now we are using devm_regulator_register(), so we don't need to allocate *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin --- drivers/regulator/max77693.c | 16 +--- 1 file chang

[PATCH 2/3] regulator: max8997: Remove unnecessary **rdev from struct max8997_data

Now we are using devm_regulator_register(), so we don't need to allocate *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin --- drivers/regulator/max8997.c | 19 ++- 1 file chang

[PATCH 3/3] regulator: max8998: Remove unnecessary **rdev from struct max8998_data

Now we are using devm_regulator_register(), so we don't need to allocate *rdev[] array to store return value of devm_regulator_register. Use a *rdev variable is enough for checking return status. Signed-off-by: Axel Lin --- drivers/regulator/max8998.c | 20 ++-- 1 file ch

[PATCH] irqchip: vt8500: Switch to a simple write clear for Interrupt Status Register

/write does not make sense for an irq status register like this, since otherwise a read/modify/write can race with a device raising an interrupt and then clear the pending bit unintentionally. Signed-off-by: Axel Lin --- Hi Tony, I don't have this h/w to test, I'd appreciate if you

Re: [PATCH] irqchip: vt8500: Switch to a simple write clear for Interrupt Status Register

2014-04-28 2:34 GMT+08:00 Thomas Gleixner : > On Sun, 27 Apr 2014, Axel Lin wrote: > >> According to the datasheet, the attribute of Interrupt Status Register is >> RW0S, >> which means: >> Software can read the register. >> Software can also

[PATCH v2] irqchip: vt8500: Switch to a simple write clear for Interrupt Status Register

write clear instead. Signed-off-by: Axel Lin --- v2: Update commit log, this is a code simplification rather than bug fix. drivers/irqchip/irq-vt8500.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c index eb6e91e..

Re: [PATCH v2] irqchip: vt8500: Switch to a simple write clear for Interrupt Status Register

2014-04-28 18:08 GMT+08:00 Thomas Gleixner : > On Mon, 28 Apr 2014, Axel Lin wrote: > >> According to the datasheet, the attribute of Interrupt Status Register is >> RW0S, >> which means: >> Software can read the register. >> Software can also

[PATCH] irqchip: vt8500: Properly mask the interrupt in irq_mask()

interrupt enable bit for all interrupt trigger mode. According to the datasheet, the Interrupt Status Register is written one to clear(Write 0 has no effect). So we don't need a read-modify-write operation for clearing a bit in interrupt status register. Signed-off-by: Axel Lin --- drivers/ir

[PATCH] clk: twl6040: Convert to use devm_clk_register

Use devm_clk_register() to simplify the code by removing twl6040_clk_remove(). Signed-off-by: Axel Lin --- drivers/clk/clk-twl6040.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c index 1ada79a..9e996b4

[PATCH] clk: s2mps11: Simplify s2mps11_clk_probe unwind paths

The devm_clk_unregister() in probe error paths are not necessary as it will be automatically called when probe fails. Signed-off-by: Axel Lin --- drivers/clk/clk-s2mps11.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk

[PATCH 1/2] regulator: tps65218: Add terminate entry for of_device_id table

Fixes below build error: FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry! Also remove of_match_ptr as this is a DT-only driver. Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 15 +++ 1 file changed, 7

[PATCH 2/2] regulator: tps65218: Remove unnecessary regulator_unregister call

Current code uses devm_regulator_register() so the we don't need to explicitly call regulator_unregister() in .remove. And then we don't need to save rdev pointer to tps->rdev[id]. Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 18 -- 1 fil

[RFT][PATCH] regulator: tps65218: Convert to use regulator_set_voltage_time_sel

Use regulator_set_voltage_time_sel() instead of open-coded. Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 37 +- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator

[PATCH RFT] regulator: tps65910: Allow missing init_data for diagnostics

The regulator core supports this to allow the configuration to be inspected at runtime even if no software management is enabled. Signed-off-by: Axel Lin --- drivers/regulator/tps65910-regulator.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH RESEND] irqchip: vt8500: Properly mask the interrupt in irq_mask()

interrupt enable bit for all interrupt trigger mode. According to the datasheet, the Interrupt Status Register is written one to clear(Write 0 has no effect). So we don't need a read-modify-write operation for clearing a bit in interrupt status register. Signed-off-by: Axel Lin --- Resend and

Re: [PATCH v2 1/3] regulator: s2mps11: Fix accidental enable of buck6 ramp delay

2014-05-07 17:48 GMT+08:00 Krzysztof Kozlowski : > I forgot to CC the stable. > > Mark, if the patches are OK and if you'll apply them, could you add a CC > stable to the commit msg? Hi Krzysztof, Unless this serial misses 3.15, I think this serial does not need to CC stable. Both b96244fad953 ("

Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

2014-04-02 8:26 GMT+08:00 Axel Lin : > 2014-03-08 11:55 GMT+08:00 Axel Lin : >> The is_enabled implementation is wrong in some cases: >> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26) >> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) b

[PATCH] regulator: st-pwm: Convert to get_voltage_sel

Also remove test for selector in st_pwm_regulator_set_voltage_sel, the checking is already done in .list_voltage. Signed-off-by: Axel Lin --- drivers/regulator/st-pwm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/st-pwm.c b/drivers/regulator/st

[PATCH] regulator: aat2870: Use regulator_map_voltage_ascend

The voltages in aat2870_ldo_voltages table are in ascendant order, so use regulator_map_voltage_ascend. Signed-off-by: Axel Lin --- drivers/regulator/aat2870-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870

<    4   5   6   7   8   9   10   11   12   13   >