2013/11/12 Ming Lei <tom.leim...@gmail.com>: > On Tue, Nov 12, 2013 at 3:32 AM, Russell King - ARM Linux > <li...@arm.linux.org.uk> wrote: >> On Mon, Nov 11, 2013 at 05:15:29PM +0000, Jonathan Austin wrote: >>> I've tested the patch below and it solves the ARM side of things - so >>> gives you an option other than a complete revert. Happy to put this in to >>> RMK's patch system if you'd prefer not to have to revert and he's happy >>> with the patch. >> >> I think this is the right solution because it then means that this symbol >> has the same meaning whether on MMU or !MMU - and getting rid of these >> kinds of gratuitous variances are the only way that !MMU is going to >> become less fragile. > > The patch only fixes problem on arm, and other !MMU&&!ARM archs > should be affected too. > > Also there is no CONFIG_PAGE_OFFSET defined for some ARCHs, > such as 64bit ARCHs. > > Currently, I suggest to filter only on ARM as attachment patch if we plan > to merge Jonathan's patch, otherwise a more complicated approach has > to be figured out to do the filter(such as, define a readonly symbol in > kernel to store PAGE_OFFSET, and let scripts/kallsyms use it for > filtering).
Hi Ming, You missed "; then" in the end of if statement in your patch. So I got below error with your patch: scripts/link-vmlinux.sh: line 87: syntax error near unexpected token `fi' make: *** [vmlinuxclean] Error 2 Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
