[PATCH] regulator: tps51632: Fix writing to wrong register when enable_pwm_dvfs is set

2012-11-26 Thread Axel Lin
When tps->enable_pwm_dvfs is true, write to TPS51632_VOLTAGE_BASE_REG rather than TPS51632_VOLTAGE_SELECT_REG. Signed-off-by: Axel Lin --- drivers/regulator/tps51632-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps51632-regulator.c

[RFC/RFT][PATCH 1/4] regulator: core: Allow specific minimal selector for starting linear mapping

2012-11-26 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/core.c |6 ++ include/linux/regulator/driver.h |2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 3db1e01..273a3b1 100644 --- a/drivers/regulator/core.c +++ b/drivers

[RFC/RFT][PATCH 2/4] regulator: da9055: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-26 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/da9055-regulator.c | 55 +- 1 file changed, 8 insertions(+), 47 deletions(-) diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c index db59ce7..a4b9cb8 100644 --- a/drivers

[RFC/RFT][PATCH 3/4] regulator: palmas: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-26 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/palmas-regulator.c | 37 +- 1 file changed, 5 insertions(+), 32 deletions(-) diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 3d44592..d5b0408 100644 --- a/drivers

[RFC/RFT][PATCH 4/4] regulator: tps51632: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-26 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/tps51632-regulator.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632-regulator.c index b22c3f2..523b1e5 100644 --- a/drivers/regulator

[PATCH] mfd: tps65090: MFD_TPS65090 needs to select REGMAP_IRQ

2012-11-26 Thread Axel Lin
ed reference to `regmap_del_irq_chip' drivers/built-in.o: In function `tps65090_i2c_remove': drivers/mfd/tps65090.c:213: undefined reference to `regmap_del_irq_chip' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- drivers/mfd/Kconfig |1 + 1 file changed, 1 insertion(+) diff

[PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs

2012-11-27 Thread Axel Lin
54): multiple definition of `pcfgs' drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here make[2]: *** [drivers/pinctrl/built-in.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-e

[PATCH RESEND] regulator: tps51632: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-27 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/tps51632-regulator.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632-regulator.c index 3460364..dce5eb3 100644 --- a/drivers/regulator

[PATCH RFT] regulator: pcf50633: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-27 Thread Axel Lin
: 0.9 V 1: 1.0 V 11000 : 3.3 V 11011 : 3.6 V Signed-off-by: Axel Lin --- drivers/regulator/pcf50633-regulator.c | 176 +--- 1 file changed, 28 insertions(+), 148 deletions(-) diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers

[PATCH RFT RESEND] regulator: pcf50633: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-27 Thread Axel Lin
. 0: 0.9 V 1: 1.0 V 11000 : 3.3 V 11011 : 3.6 V Signed-off-by: Axel Lin --- Seems directly copy paste from the datasheet(pdf) adds some UTF-8 characters in the patch. Fix it and resend. Axel drivers/regulator/pcf50633-regulator.c | 176

[PATCH RESEND] pinctrl: Drop selecting PINCONF for MMP2, PXA168 and PXA910

2012-11-27 Thread Axel Lin
These drivers do not need to select PINCONF. Signed-off-by: Axel Lin --- This patch was sent on https://lkml.org/lkml/2012/11/12/12. Resend to Haojian's correct email address. drivers/pinctrl/Kconfig |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/dr

[PATCH] ARM: mmp: select PINCTRL for ARCH_MMP

2012-11-27 Thread Axel Lin
This makes PINCTRL related config options visible. Otherwise there is no way to build pinctrl drivers for MMP2, PXA168 and PXA910. Signed-off-by: Axel Lin --- This patch was sent on https://lkml.org/lkml/2012/11/12/10 Resend to Haojian's correct email address. arch/arm/Kconfig |1 + 1

[RFT][PATCH 1/2] regulator: palmas: Return raw register values as the selectors in [get|set]_voltage_sel

2012-11-28 Thread Axel Lin
ector 6. Signed-off-by: Axel Lin --- hi Graeme, I don't have this hardware, I'd appreciate if you can review and test this patch. I think it should be no behavior change with these 2 patches. Note I don't have the datasheet, the reg-value and voltage mapping is from my understanding

[RFT][PATCH 2/2] regulator: palmas: Convert palmas_ops_smps to regulator_[get|set]_voltage_sel_regmap

2012-11-28 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/palmas-regulator.c | 87 ++ 1 file changed, 26 insertions(+), 61 deletions(-) diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 76eaafb..932cc05 100644 --- a/drivers

[PATCH RFT] regulator: max1586: Implement get_voltage_sel callback

2012-11-28 Thread Axel Lin
set up value. Thus this patch caches the setting when setting new voltage. Signed-off-by: Axel Lin --- drivers/regulator/max1586.c | 44 --- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1

[PATCH RFT v2] regulator: max1586: Implement get_voltage_sel callback

2012-11-28 Thread Axel Lin
set up value. Thus this patch caches the setting when setting new voltage. Signed-off-by: Axel Lin --- v2: get_voltage_sel returns selector rather than voltage. drivers/regulator/max1586.c | 44 --- 1 file changed, 41 insertions(+), 3 deletions(-) d

[PATCH] OMAPDSS: Add terminating entry for picodlp_i2c_id table

2012-11-29 Thread Axel Lin
The i2c_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin --- drivers/video/omap2/displays/panel-picodlp.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/omap2/displays/panel-picodlp.c b/drivers/video/omap2/displays/panel-picodlp.c index e3a6c19

[PATCH] regulator: wm831x-dcdc: Ensure selected voltage falls within requested range

2012-11-29 Thread Axel Lin
Use DIV_ROUND_UP to ensure selected voltage won't less than min_uV due to integer truncation. Signed-off-by: Axel Lin --- drivers/regulator/wm831x-dcdc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-d

[PATCH] regulator: tps51632: Ensure [base|max]_voltage_uV pdata settings are valid

2012-11-30 Thread Axel Lin
If pdata->base_voltage_uV is missing or the settings of pdata->base_voltage_uV and pdata->max_voltage_uV are out of range, TPS51632_VOLT_VSEL macro returns wrong vsel. Thus add checking [base|max]_voltage_uV pdata settings in probe. Signed-off-by: Axel Lin --- drivers/regulator

[PATCH 1/2] PM / devfreq: exynos4_bus: Constify clock divider table

2013-03-20 Thread Axel Lin
These tables are never modified, make them const. Signed-off-by: Axel Lin --- drivers/devfreq/exynos4_bus.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c index 3f37f3b..45d00d1 100644 --- a

[PATCH 2/2] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1

2013-03-20 Thread Axel Lin
exynos4x12_clkdiv_dmc1 contains { G2DACP, DIVC2C, DIVC2C_ACLK }, thus set the size to 3 rather than 6. Signed-off-by: Axel Lin --- drivers/devfreq/exynos4_bus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c

[PATCH] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails

2013-03-20 Thread Axel Lin
We need to call mutex_unlock() in the error path. Signed-off-by: Axel Lin --- drivers/devfreq/exynos4_bus.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c index 1deee09..54b9615 100644 --- a/drivers/devfreq

Re: [PATCH] BUG: pinmux: release only taken pins on error

2013-03-20 Thread Axel Lin
2013/3/20 Richard Genoud : > commit e38d457de7be63e6ced1ea254aa51466deb1fef0 > pinctrl: pinmux: Release all taken pins in pinmux_enable_setting > > Introduced a bug in the release pin mechanism. > All the pins (taken or not) where released. > For instance, if a i2c function has already taken pins 5

[linux-next] Not able to fetch next-20130321

2013-03-21 Thread Axel Lin
Hi Stephen, I run "git remote update" but cannot find next-20130321 tag. It seems the latest tag is "next-20130318". https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/ Can you take a look at this issue? Thanks, Axel -- To unsubscribe from this list: send the line "unsubscribe li

[PATCH] regulator: palmas: Remove a redundant setting for warm_reset

2013-02-03 Thread Axel Lin
Current code read "ti,warm_reset" of property twice, and set pdata->reg_init[idx]->warm_reset twice. Read and set it once is enough. Signed-off-by: Axel Lin --- drivers/regulator/palmas-regulator.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/regulator/pa

[PATCH 1/3] regulator: s5m8767: Use of_get_child_count()

2013-02-05 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index 1250cef..194b5dd 100644 --- a/drivers/regulator/s5m8767.c +++ b/drivers/regulator/s5m8767.c @@ -536,9

[PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-05 Thread Axel Lin
Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and dev_info(). Use &pdev->dev rather than iodev->dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regula

[PATCH 3/3] regulator: s5m8767: Prevent possible NULL pointer dereference

2013-02-05 Thread Axel Lin
s5m8767_pmic_dt_parse_pdata dereferenes pdata, thus check pdata earlier to avoid NULL pointer dereference. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator

[PATCH 1/2] regulator: core: Optimize _regulator_do_set_voltage if voltage does not change

2013-02-05 Thread Axel Lin
Optimize _regulator_do_set_voltage() for the case selector is equal to old_selector. Since the voltage does not change, we don't need to call set_voltage_sel() and set_voltage_time_sel() in this case. Signed-off-by: Axel Lin --- drivers/regulator/core.c |9 ++--- 1 file chang

[PATCH 2/2] regulator: max8998: Let regulator core handle the case selector == old_selector

2013-02-05 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/max8998.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c index 0a8dd1c..b588f07 100644 --- a/drivers/regulator/max8998.c +++ b/drivers/regulator/max8998.c

[PATCH] mfd: max8997: Return proper error if pdata is NULL

2013-02-06 Thread Axel Lin
Return proper error instead of 0 if pdata is NULL. Signed-off-by: Axel Lin --- drivers/mfd/max8997.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c index 1471405..823f34b 100644 --- a/drivers/mfd/max8997.c +++ b/drivers

Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument at various places

2013-02-10 Thread Axel Lin
2013/2/8, Mark Brown : > On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote: > >> Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and >> dev_info(). > > It's not clear to me that this is actually an improvement, the pdev is > mo

[PATCH 1/2] regulator: s5m8767: Fix dev argument for devm_kzalloc and of_get_regulator_init_data

2013-02-12 Thread Axel Lin
Use &pdev->dev rather than iodev->dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/s5m8767.c

[PATCH 2/2] regulator: s5m8767: Prevent possible NULL pointer dereference

2013-02-12 Thread Axel Lin
s5m8767_pmic_dt_parse_pdata dereferenes pdata, thus check pdata earlier to avoid NULL pointer dereference. Signed-off-by: Axel Lin --- drivers/regulator/s5m8767.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator

[PATCH] regulator: as3711: Fix checking if no platform initialization data

2013-02-12 Thread Axel Lin
To skip registering regulator if no platform initialization data, we should check reg_data rather than ri->desc.name. Signed-off-by: Axel Lin --- drivers/regulator/as3711-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/as3711-regulator.c

[PATCH] regulator: ab8500-ext: Don't update info->is_enabled if write to register fails

2013-04-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/ab8500-ext.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c index 21b9bfb..7923e82 100644 --- a/drivers/regulator/ab8500-ext.c +++ b/drivers/regulator

[PATCH] regulator: dbx500-prcmu: Remove operating_point from struct dbx500_regulator_info

2013-04-02 Thread Axel Lin
operating_point is not used since the initial commit of db8500-prcmu driver, remove it. Signed-off-by: Axel Lin --- drivers/regulator/dbx500-prcmu.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regulator/dbx500-prcmu.h b/drivers/regulator/dbx500-prcmu.h index e763883..c8e51ac

Re: [PATCH RFT] regulator: ab8500: Fix build error

2013-04-02 Thread Axel Lin
2013/4/2 Mark Brown : > On Tue, Apr 02, 2013 at 08:39:53AM +0800, Axel Lin wrote: >> This patch removes 'delay' field which does not exist in struct >> ab8500_regulator_info. ( The 'delay' field was removed because fixed >> regulator >> does not n

[PATCH 1/4] regulator: ab8500: Remove set_voltage_time_sel and delay to fix build error

2013-04-02 Thread Axel Lin
s not need set_voltage_time_sel. All ab8540_aux3_regulator_volt_mode_ops users do not have delay settings so set_voltage_time_sel actually returns 0. Signed-off-by: Axel Lin --- drivers/regulator/ab8500.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/regulator/ab8500.c

[PATCH 2/4] regulator: ab8500: Remove voltages and voltages_len to fix build error

2013-04-02 Thread Axel Lin
Both voltages and voltages_len are not exist in struct ab8500_regulator_info. Signed-off-by: Axel Lin --- drivers/regulator/ab8500.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index abdfbd4..bdd17e6 100644

[PATCH 3/4] regulator: ab8500: Fix 'match_size' undeclared and missing semicolon

2013-04-02 Thread Axel Lin
clared identifier is reported only once for each function it appears in drivers/regulator/ab8500.c:3019:2: error: expected ';' before '}' token drivers/regulator/ab8500.c:3036:2: error: expected ';' before '}' token Signed-off-by: Axel Lin --- drivers/regulato

[PATCH 4/4] regulator: ab8500: Set match pointer and match_size for ab8505 and ab8540

2013-04-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/ab8500.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 73d84d8..d3170ae 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -3021,11 +3021,15 @@ static

Re: [PATCH 1/4] regulator: ab8500: Remove set_voltage_time_sel and delay to fix build error

2013-04-03 Thread Axel Lin
2013/4/4 Mark Brown : > On Wed, Apr 03, 2013 at 10:30:43AM +0800, Axel Lin wrote: >> The delay field is removed from struct ab8500_regulator_info in commit >> 29234928 >> "regulator: ab8500: Remove set_voltage_time_sel and delay setting". > > I've n

[PATCH] regulator: ab8500: Remove ab8500_regulator_set_voltage_time_sel

2013-04-03 Thread Axel Lin
All users of ab8500_regulator_volt_mode_ops and ab8500_regulator_volt_ops do not set info->desc.enable_time, thus set_voltage_time_sel() always returns 0. Remove it. Signed-off-by: Axel Lin --- drivers/regulator/ab8500.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/driv

[PATCH] regulator: tps65090: Fix using wrong dev argument for calling of_regulator_match

2013-01-30 Thread Axel Lin
is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin --- drivers/regulator/tps65090-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps65090-regulator.c b/drivers/regulator/tps65090-regulator.c index 868754

[PATCH 1/2] regulator: max8997: Use of_get_child_count()

2013-01-30 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/max8997.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index 7d2b1b5..c780104 100644 --- a/drivers/regulator/max8997.c +++ b/drivers/regulator/max8997.c @@ -930,9

[PATCH 2/2] regulator: mc13xxx: Use of_get_child_count()

2013-01-30 Thread Axel Lin
Signed-off-by: Axel Lin --- hi Mark, I generate this patch against for-next branch of regulator tree. So this patch is on top of commit c92f5dd2c "regulator: Add missing of_node_put()". Which means it can only be applied to topic/of branch now. If you prefer apply it to other bra

[PATCH] regmap: Export regmap_async_complete_cb

2013-02-02 Thread Axel Lin
This fixes below build error when CONFIG_REGMAP=y && CONFIG_REGMAP_SPI=m ERROR: "regmap_async_complete_cb" [drivers/base/regmap/regmap-spi.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Signed-off-by: Axel Lin --- drivers/base/regmap/regmap.

[PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-24 Thread Axel Lin
is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin --- drivers/regulator/max8907-regulator.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907-regulator.c index d1a775

[PATCH 2/3] regulator: max77686: Fix using wrong dev argument at various places

2013-01-24 Thread Axel Lin
Use &pdev->dev rather than iodev->dev for dev_err(). Use &pdev->dev rather than iodev->dev for devm_kzalloc() and of_regulator_match(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regulator/max77686.c | 15 --- 1 file changed, 8 insertions(+),

[PATCH 3/3] regulator: max8997: Fix using wrong dev argument at various places

2013-01-24 Thread Axel Lin
Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and dev_info(). Use &pdev->dev rather than iodev->dev for devm_kzalloc() and of_get_regulator_init_data(), this fixes memory leak. Signed-off-by: Axel Lin --- drivers/regula

[PATCH] regulator: tps80031: Use IS_ERR to check return value of regulator_register()

2013-01-25 Thread Axel Lin
regulator_register() does not return NULL, it returns ERR_PTR on error. Signed-off-by: Axel Lin --- drivers/regulator/tps80031-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps80031-regulator.c b/drivers/regulator/tps80031-regulator.c

[PATCH] regulator: lp8755: Use LP8755_BUCK_MAX instead of magic number

2013-01-25 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/lp8755.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c index 8b1ce0f..f0f6ea0 100644 --- a/drivers/regulator/lp8755.c +++ b/drivers/regulator/lp8755.c @@ -373,7

[PATCH] regulator: Add missing of_node_put()

2013-01-26 Thread Axel Lin
of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. Signed-off-by: Axel Lin Cc: Haojian Zhuang Cc: David Dajun Chen Cc: Gyungoh Yoo Cc: MyungJoo Ham Cc: Graeme Gregory Cc: Laxman Dewangan Cc: Shawn Guo --- Hi, I don't have

[PATCH] backlight: 88pm860x_bl: Add missing of_node_put()

2013-01-27 Thread Axel Lin
of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. Signed-off-by: Axel Lin --- drivers/video/backlight/88pm860x_bl.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight

[PATCH] regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match

2013-01-27 Thread Axel Lin
is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin --- drivers/regulator/tps6507x-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c index afdeb6

[RFT][PATCH v2] backlight: 88pm860x_bl: Add missing of_node_put()

2013-01-27 Thread Axel Lin
: Axel Lin --- v2: need to call of_node_get(pdev->dev.parent->of_node) before calling of_find_node_by_name(). drivers/video/backlight/88pm860x_bl.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860

[RFT][PATCH v2] regulator: Add missing of_node_put()

2013-01-27 Thread Axel Lin
of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. of_find_node_by_name() will call of_node_put() against from parameter, thus we also need to call of_node_get(from) before calling of_find_node_by_name(). Signed-off-by: Axel Lin Cc

[PATCH 1/2] regulator: gpio-regulator: Use of_gpio_count()

2013-01-28 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/gpio-regulator.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index bae681c..d819ba7 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers

[PATCH 2/2] regulator: gpio-regulator: Staticize of_get_gpio_regulator_config()

2013-01-28 Thread Axel Lin
of_get_gpio_regulator_config() is only used in gpio-regulator.c, make it static. Signed-off-by: Axel Lin --- drivers/regulator/gpio-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index

Re: [PATCH v3 1/4] regulator: core: support shared enable GPIO concept

2013-02-18 Thread Axel Lin
> + if (pin->request_count <= 1) { > + pin->request_count = 0; > + gpio_free(pin->gpio); > + list_del(&pin->list); > + kfree(pin); > +

Re: [PATCH v3 2/4] regulator: core: manage enable GPIO list

2013-02-18 Thread Axel Lin
> +/** > + * Balance enable_count of each GPIO and actual GPIO pin control. > + * GPIO is enabled in case of initial use. (enable_count is 0) > + * GPIO is disabled when it is not shared any more. (enable_count <= 1) I think you mean "GPIO is disabled when it is not used any more." "It is not share

Re: [PATCH v3 0/4] regulator: core: support shared enable GPIO

2013-02-18 Thread Axel Lin
n. > This patch-set enables shared enable GPIO concept and fix LP8788 LDO driver > as well. This patch serial looks good to me. You can add: Reviewed-by: Axel Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

[PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

2013-02-19 Thread Axel Lin
name' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- drivers/mfd/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 671f5b1..c346941 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -858,6 +858,7 @@ config E

Re: [PATCH] regulator: tps6586x: Having slew rate settings for other than SM0/1 is not fatal

2013-02-19 Thread Axel Lin
2013/2/20 Stephen Warren : > On 02/16/2013 04:50 AM, Axel Lin wrote: >> Ignore the setting and show "Only SM0/SM1 can set slew rate" warning is >> enough, >> then we can return 0 instead of -EINVAL in >> tps6586x_regulator_set_slew_rate(). >> >

[PATCH] regulator: tps6586x: Use dev_err rather than dev_warn for error message

2013-02-19 Thread Axel Lin
tps6586x_regulator_set_slew_rate() returns -EINVAL when having slew rate settings for other than SM0/1, thus use dev_err rather than dev_warn. Signed-off-by: Axel Lin --- drivers/regulator/tps6586x-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] regulator: palmas: Use of_property_read_bool to read "ti,warm-reset" DT property

2013-03-12 Thread Axel Lin
It does not make sense to assign return value of of_property_read_u32() to pdata->reg_init[idx]->warm_reset. Use of_property_read_bool() to read "ti,warm-reset" DT property instead which will return correct setting for pdata->reg_init[idx]->warm_reset. Signed-off-by:

[PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes

2013-03-14 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/hwmon/lineage-pem.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c index 41df29f..ebbb9f4 100644 --- a/drivers/hwmon/lineage-pem.c +++ b/drivers/hwmon/lineage-pem.c @@ -422,6 +422,7 @@ static

[PATCH] gpio: pl061: Add pl061_gpio_free()

2013-03-15 Thread Axel Lin
commit 39b70ee051 "gpio: pl061: bind pinctrl by gpio request" adds pl061_gpio_request() to request pinctrl. Thus we need to add corresponding pl061_gpio_free() to free the pin. Signed-off-by: Axel Lin --- drivers/gpio/gpio-pl061.c |8 1 file changed, 8 insertions(+) di

[PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

2013-03-15 Thread Axel Lin
The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin Acked-by: Grant Likely --- This patch was sent on https://lkml.org/lkml/2012/12/9/135 Re-generate the patch against linux-next and resend. drivers/gpio/gpio-samsung.c |1 + 1 file changed, 1 insertion

[PATCH] gpio: em: Fix checking return value of irq_alloc_descs

2012-08-28 Thread Axel Lin
irq_alloc_descs() returns negative error code on failure. Signed-off-by: Axel Lin --- drivers/gpio/gpio-em.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c index ae37181..ec48ed5 100644 --- a/drivers/gpio/gpio-em.c

[PATCH 1/2] gpio: mc9s08dz60: Fix build error if I2C=m

2012-08-28 Thread Axel Lin
0x290): undefined reference to `i2c_register_driver' drivers/built-in.o: In function `mc9s08dz60_i2c_driver_exit': clk-fixed-factor.c:(.exit.text+0x2c): undefined reference to `i2c_del_driver' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- drivers/gpio/Kconfig |2 +- 1 file changed

[PATCH 2/2] gpio: mc9s08dz60: Use devm_kzalloc API

2012-08-28 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-mc9s08dz60.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpio-mc9s08dz60.c b/drivers/gpio/gpio-mc9s08dz60.c index 2738cc4..0ab7000 100644 --- a/drivers/gpio/gpio-mc9s08dz60.c +++ b/drivers

drivers/gpio/gpio-em.c build error if CONFIG_GPIO_EM=m

2012-08-28 Thread Axel Lin
Hi Magnus, I got below build error if CONFIG_GPIO_EM=m MODPOST 33 modules ERROR: "set_irq_flags" [drivers/gpio/gpio-em.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

[PATCH] gpio: Remove broken mark for da9052 gpio driver

2012-08-28 Thread Axel Lin
The fix for MFD part is merged so remove the broken mark for da9052 gpio driver. Signed-off-by: Axel Lin --- drivers/gpio/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index ba7926f5..95778f1 100644 --- a/drivers/gpio

[PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h

2012-08-31 Thread Axel Lin
o/mbx/mbxfb.c:942:22: warning: assignment makes pointer from integer without a cast [enabled by default] drivers/video/mbx/mbxfb.c:952:21: warning: assignment makes pointer from integer without a cast [enabled by default] cc1: some warnings being treated as errors Signed-off-by: Axel Lin --- drive

[PATCH] gpio: rdc321x: Prevent removal of modules exporting active GPIOs

2012-08-31 Thread Axel Lin
This driver can be built as a module, set the missing owner field of struct gpio_chip to prevent removal of modules exporting active GPIOs. Signed-off-by: Axel Lin --- drivers/gpio/gpio-rdc321x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio

[PATCH] gpio: da9052: Convert to use devm_kzalloc API

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-da9052.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c index 56dd047..24b8c29 100644 --- a/drivers/gpio/gpio-da9052.c +++ b/drivers/gpio/gpio-da9052.c

[PATCH] gpio: tps65912: Convert to use devm_kzalloc API

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-tps65912.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c index 79e66c0..99106d1 100644 --- a/drivers/gpio/gpio-tps65912.c +++ b/drivers/gpio/gpio

[PATCH] gpio: Use DEFINE_PCI_DEVICE_TABLE macro

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-bt8xx.c |2 +- drivers/gpio/gpio-sodaville.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c index 92d555d..7d9d7cb 100644 --- a/drivers/gpio/gpio-bt8xx.c +++ b

[PATCH] gpio: adp5588: Use module_i2c_driver

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-adp5588.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index ae5d7f1..eeedad4 100644 --- a/drivers/gpio/gpio-adp5588.c +++ b/drivers/gpio/gpio-adp5588.c

[PATCH 1/2] gpio: wm831x: Convert to use devm_kzalloc API

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-wm831x.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index e56a216..b6eda35 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio

[PATCH 2/2] gpio: wm8350: Convert to use devm_kzalloc API

2012-09-01 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-wm8350.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpio-wm8350.c b/drivers/gpio/gpio-wm8350.c index a06af51..fb42938 100644 --- a/drivers/gpio/gpio-wm8350.c +++ b/drivers/gpio/gpio-wm8350

[PATCH] ARM: ux500: Fix build error due to missing include of asm/pmu.h in cpu-db8500.c

2012-09-02 Thread Axel Lin
500/cpu-db8500.o] Error 1 make: *** [arch/arm/mach-ux500] Error 2 Signed-off-by: Axel Lin --- arch/arm/mach-ux500/cpu-db8500.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm/mach-ux500/cpu-db8500.c index 8169f2c..3ce7d94 100644 --- a/arch/arm/mach-ux5

Re: [PATCH] ARM: ux500: Fix build error due to missing include of asm/pmu.h in cpu-db8500.c

2012-09-03 Thread Axel Lin
2012/9/3 Linus Walleij : > On Sun, Sep 2, 2012 at 2:25 PM, Axel Lin wrote: > >> Include asm/pmu.h to fix below build error: >> >> CC arch/arm/mach-ux500/cpu-db8500.o >> arch/arm/mach-ux500/cpu-db8500.c:118:8: error: variable >> 'db8500_pmu_plat

[PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared

2012-09-03 Thread Axel Lin
3xx/gesbc9312.o] Error 1 make: *** [arch/arm/mach-ep93xx] Error 2 Signed-off-by: Axel Lin --- This patch is against linux-next tree. Axel arch/arm/mach-ep93xx/adssphere.c |1 + arch/arm/mach-ep93xx/gesbc9312.c |1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/mach-e

[PATCH] gpio: em: Use irq_data_get_irq_chip_data() at appropriate places

2012-09-04 Thread Axel Lin
Then we can remove irq_to_priv() function. Signed-off-by: Axel Lin --- drivers/gpio/gpio-em.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c index ec48ed5..efb4c2d 100644 --- a/drivers/gpio/gpio-em.c +++ b

[PATCH] gpio: sx150x: Use irq_data_get_irq_chip_data() at appropriate places

2012-09-04 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/gpio/gpio-sx150x.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/gpio-sx150x.c b/drivers/gpio/gpio-sx150x.c index a4f7353..eb3e215 100644 --- a/drivers/gpio/gpio-sx150x.c +++ b/drivers/gpio/gpio

[PATCH] HID: hid-lcpower: Use HID_UP_LOGIVENDOR instead of hard coded 0x0ffbc0000

2012-09-04 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/hid/hid-lcpower.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c index c4fe9bd0..22bc14a 100644 --- a/drivers/hid/hid-lcpower.c +++ b/drivers/hid/hid-lcpower.c @@ -24,7 +24,7

[PATCH] HID: picolcd_fb: Use flush_delayed_work instead of flush_delayed_work_sync

2012-09-11 Thread Axel Lin
_fb.c:611:2: warning: 'flush_delayed_work_sync' is deprecated (declared at include/linux/workqueue.h:454) [-Wdeprecated-declarations] Signed-off-by: Axel Lin Cc: Tejun Heo --- drivers/hid/hid-picolcd_fb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-

[PATCH 1/2] HID: hid-sensor-hub: Clear HID_CLAIMED_INPUT bit earlier

2012-09-12 Thread Axel Lin
ing. Also adds comments for why we set hdev->claimed = HID_CLAIMED_INPUT. Signed-off-by: Axel Lin --- Hi srinivas, I don't have this hardware, I'd appreciate if you can test these patches. Axel drivers/hid/hid-sensor-hub.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[PATCH 2/2] HID: hid-sensor-hub: Fix sensor_hub_probe error handling

2012-09-12 Thread Axel Lin
Fix below issues in sensor_hub_probe error handling: 1. In the case of goto err_close, hid_hw_stop(hdev) is called twice. Fix it. 2. If fails to allocate MFD device name, we also need to free all successfully allocated names in previous iterations. Signed-off-by: Axel Lin --- drivers/hid/hid

Re: [PATCH 1/2] HID: hid-sensor-hub: Clear HID_CLAIMED_INPUT bit earlier

2012-09-13 Thread Axel Lin
2012/9/13 Axel Lin : > Clear HID_CLAIMED_INPUT bit of hdev->claimed, this prevents calling > hidinput_disconnect() in hid_disconnect(), which is called by hid_hw_stop(). > > We need to clear HID_CLAIMED_INPUT bit earlier rather than in > sensor_hub_remove() because we also cal

Re: [PATCH 1/2] HID: hid-sensor-hub: Clear HID_CLAIMED_INPUT bit earlier

2012-09-13 Thread Axel Lin
2012/9/14 Pandruvada, Srinivas : > Hi Axel, > > We don't need this anymore as when connect_mask is 0, the hid_connect will > not be called. > So we don't need hdev->claimed = HID_CLAIMED_INPUT anymore. > Okay. I'm going to resend the patch for this serial. Axel -- To unsubscribe from this list: s

[PATCH] extcon: Fix kerneldoc for extcon_set_cable_state and extcon_set_cable_state_

2012-10-02 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/extcon/extcon-class.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c index 946a318..337bbb4 100644 --- a/drivers/extcon/extcon-class.c +++ b/drivers/extcon/extcon-class.c

[PATCH] extcon: max77693: Use max77693_update_reg for rmw operations

2012-10-02 Thread Axel Lin
This simplifies the code. Signed-off-by: Axel Lin --- drivers/extcon/extcon-max77693.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index e21387e..e0ed622 100644 --- a/drivers/extcon

[PATCH] extcon: max77693: Fix max77693_muic_probe error handling

2012-10-02 Thread Axel Lin
Fix below issues: 1. If request_threaded_irq() fails, current code does not free all requested irqs. 2. Add missing extcon_dev_unregister() in error path if failed to read revision number. Signed-off-by: Axel Lin --- drivers/extcon/extcon-max77693.c | 12 ++-- 1 file changed, 6

mfd: rc5t583-irq.c build warning: array subscript is above array bounds

2012-10-25 Thread Axel Lin
hi Laxman, I got below compile warning when build this driver. CC drivers/mfd/rc5t583-irq.o drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock': drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_in

[PATCH] regulator: Fix trivial typo for TPS51632 Kconfig help text

2012-10-31 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 7b920c7..cbc685d 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -341,7 +341,7

regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case

2012-10-31 Thread Axel Lin
Hi Laxman, While reading the tps51632 driver, I found there is a dvfs_step_20mV setting in platform data. But seems current code doesn't properly handle the case when dvfs_step_20mV is true. I guess if pdata->dvfs_step_20mV is true, we need: tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV; Fix TP

  1   2   3   4   5   6   7   8   9   10   >