Return proper error instead of 0 if pdata is NULL. Signed-off-by: Axel Lin <axel....@ingics.com> --- drivers/mfd/max8997.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c index 1471405..823f34b 100644 --- a/drivers/mfd/max8997.c +++ b/drivers/mfd/max8997.c @@ -209,8 +209,10 @@ static int max8997_i2c_probe(struct i2c_client *i2c, } } - if (!pdata) + if (!pdata) { + ret = -EINVAL; goto err; + } max8997->pdata = pdata; max8997->ono = pdata->ono; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/