[PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

The type of 'chan' is u32 which contain non-negative value. So 'chan < 0' is statment is always false. Remove unnecessary comparison statement Signed-off-by: Austin Kim --- drivers/scsi/dpt_i2o.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH] net/mlx5: Declare 'rt' as corresponding enum type

e 'enum mlx5dr_action_type' to different enumeration type 'enum mlx5_reformat_ctx_type' [- Wenum-conversion] ret = mlx5dr_cmd_create_reformat_ctx(dmn->mdev, rt, data_sz, data, ~~^~ Declare 'rt' as c

Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

Hello, Maintainers... Would you please review this patch and share the feedback? Thanks, Austin Kim 2019년 9월 9일 (월) 오후 2:42, Austin Kim 님이 작성: > > The type of 'chan' is u32 which contain non-negative value. > So 'chan < 0' is statment is always false. > > R

Re: [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation

2019년 8월 29일 (목) 오후 4:56, Christoph Hellwig 님이 작성: > > On Wed, Aug 28, 2019 at 03:47:49PM +0900, Austin Kim wrote: > > If the CONFIG_BUG is enabled, BUG() is executed and then system is crashed. > > However, the bailout for mount is no longer proceeding. > > > >

[PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation

If the CONFIG_BUG is enabled, BUG is executed and then system is crashed. However, the bailout for mount is no longer proceeding. For this reason, using WARN_ON_ONCE rather than BUG can prevent this situation. Signed-off-by: Austin Kim --- fs/xfs/xfs_mount.c | 3 +-- 1 file changed, 1

Re: [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation

2019년 8월 30일 (금) 오전 9:33, Darrick J. Wong 님이 작성: > > On Fri, Aug 30, 2019 at 09:30:22AM +0900, Austin Kim wrote: > > If the CONFIG_BUG is enabled, BUG is executed and then system is crashed. > > However, the bailout for mount is no longer proceeding. > > > > For t

[PATCH] xfs: Use WARN_ON_ONCE for bailout mount-operation

If the CONFIG_BUG is enabled, BUG is executed and then system is crashed. However, the bailout for mount is no longer proceeding. Using WARN_ON_ONCE rather than BUG can prevent this situation. Signed-off-by: Austin Kim --- fs/xfs/xfs_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] mm/vmalloc: move 'area->pages' after if statement

If !area->pages statement is true where memory allocation fails, area is freed. In this case 'area->pages = pages' should not executed. So move 'area->pages = pages' after if statement. Signed-off-by: Austin Kim --- mm/vmalloc.c | 6 -- 1 file changed,

[PATCH] xfs: Initialize label array properly

In case kernel stack variable is not initialized properly, there is a risk of kernel information disclosure. So, initialize 'char label[]' array with null characters. Signed-off-by: Austin Kim --- fs/xfs/xfs_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH] drm/amdgpu: Move null pointer dereference check

Null pointer dereference check should have been checked, ahead of below routine. struct amdgpu_device *adev = hwmgr->adev; With this commit, it could avoid potential NULL dereference. Signed-off-by: Austin Kim --- drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 5 +++-- 1 f

Re: [PATCH] xfs: Initialize label array properly

2019년 8월 30일 (금) 오후 2:39, Darrick J. Wong 님이 작성: > > On Fri, Aug 30, 2019 at 02:37:07PM +0900, Austin Kim wrote: > > In case kernel stack variable is not initialized properly, > > there is a risk of kernel information disclosure. > > > > So, initialize 'char

[PATCH] xfs: Use BUG_ON rather than BUG() to remove unreachable code

Code after BUG is unreachable since system would be crashed after the call to BUG is made. So change BUG_ON instead of BUG() to remove unreachable code. --- fs/xfs/xfs_mount.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 3

[PATCH] ext4: remove unreachable statement inside __es_insert_extent()

__es_insert_extent() never returns -EINVAL after BUG is executed. So remove unreachable code. --- fs/ext4/extents_status.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index a959adc..7f97360 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ex

Re: [PATCH] mm/vmalloc: move 'area->pages' after if statement

2019년 8월 31일 (토) 오전 5:50, Andrew Morton 님이 작성: > > On Fri, 30 Aug 2019 12:57:16 +0900 Austin Kim wrote: > > > If !area->pages statement is true where memory allocation fails, > > area is freed. > > > > In this case 'area->pages = pages' should not

[PATCH] media: meson: Add NULL check after the call to kmalloc()

If the kmalloc() return NULL, the NULL pointer dereference will occur. new_ts->ts = ts; Add exception check after the call to kmalloc() is made. Signed-off-by: Austin Kim --- drivers/staging/media/meson/vdec/vdec_helpers.c | 4 1 file changed, 4 insertions(+) diff --git a/driv

[PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation

If the CONFIG_BUG is enabled, BUG() is executed and then system is crashed. However, the bailout for mount is no longer proceeding. For this reason, using WARN_ON rather than BUG() could prevent this situation. --- fs/xfs/xfs_mount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

Re: [PATCH] xfs: Use WARN_ON rather than BUG() for bailout mount-operation

Dear Mr. Darrick J. Wong Thanks for reviewing patch. BTW, I have a question for you. Do I have to update the patch again with 'a space before the brace'? Or could I just wait for the patch to be imported? It would be thankful if you give me a feedback. BR, Guillermo Austin Kim 2019년

Re: [PATCH] media: meson: Add NULL check after the call to kmalloc()

2019년 9월 4일 (수) 오후 5:45, Greg KH 님이 작성: > > On Wed, Sep 04, 2019 at 05:22:32PM +0900, Austin Kim wrote: > > If the kmalloc() return NULL, the NULL pointer dereference will occur. > > new_ts->ts = ts; > > > > Add exception check after the call to kmalloc

Re: [PATCH] media: meson: Add NULL check after the call to kmalloc()

2019년 9월 4일 (수) 오후 5:43, Rasmus Villemoes 님이 작성: > > On 04/09/2019 10.22, Austin Kim wrote: > > If the kmalloc() return NULL, the NULL pointer dereference will occur. > > new_ts->ts = ts; > > > > Add exception check after the call to kmalloc() is made.

[PATCH] x86/platform/uv: move kmalloc() NULL check routine

The result of kmalloc should have been checked ahead of below statement: pqp = (struct bau_pq_entry *)vp; Move BUG_ON(!vp) before above statement. Signed-off-by: Austin Kim --- arch/x86/platform/uv/tlb_uv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch

Re: [PATCH] btrfs: fix Wmaybe-uninitialized warning

Hello, maintainers. If you are available, please review this patch and share the feedback. Thanks, Austin Kim 2019년 9월 3일 (화) 오후 12:30, Austin Kim 님이 작성: > > gcc throws warning message as below: > > ‘clone_src_i_size’ may be used uninitialized in this function > [-Wmayb

[PATCH] ARM: module: Drop 'rel->r_offset < 0' always false statement

ent which is always false. Signed-off-by: Austin Kim --- arch/arm/kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index deef17f..0921ce7 100644 --- a/arch/arm/kernel/module.c +++ b/arch/arm/kernel/modu

[PATCH] bus: moxtet: Update proper type 'size_t' to 'ssize_t'

event this case, update proper type 'size_t' to 'ssize_t' for execptional handling. Signed-off-by: Austin Kim --- drivers/bus/moxtet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c index 1ee4570..288a9e4 1006

Re: [PATCH] net/mlx5: Declare 'rt' as corresponding enum type

It is good to hear that similar patch was submitted. Thanks for notification. Thanks, Austin Kim 2019년 9월 11일 (수) 오전 2:59, Saeed Mahameed 님이 작성: > > On Tue, 2019-09-10 at 18:27 +0900, Austin Kim wrote: > > When building kernel with clang, we can observe below warning > > messag

Re: [PATCH] ARM: module: Drop 'rel->r_offset < 0' always false statement

2019년 9월 11일 (수) 오후 6:40, Russell King - ARM Linux admin 님이 작성: > > On Wed, Sep 11, 2019 at 01:54:08PM +0900, Austin Kim wrote: > > Since rel->r_offset is declared as Elf32_Addr, > > this value is always non-negative. > > typedef struct elf32_rel { > &g

Re: [PATCH] bus: moxtet: Update proper type 'size_t' to 'ssize_t'

; > Thanks, > Marek > > On Wed, 11 Sep 2019 14:59:38 +0900 > Austin Kim wrote: > > > The simple_write_to_buffer() returns ssize_t type value, > > which is either positive or negative. > > > > However 'res' is declared as size_t(unsigned int)

[RESEND PATCH] ARM: module: Drop 'rel->r_offset < 0' statement

false. Also change %u to %d in pr_err() for rel->r_offset. Signed-off-by: Austin Kim --- arch/arm/kernel/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index deef17f34..f805bcbda 100644 --- a/arch/arm/kern

Re: [RESEND PATCH] ARM: module: Drop 'rel->r_offset < 0' statement

Hello, Maintainer(Russell King)... Would you please update the feedback for this patch? 2019년 9월 11일 (수) 오후 11:16, Austin Kim 님이 작성: > > Since rel->r_offset is declared as Elf32_Addr, > this value is always non-negative. > typedef struct elf32_rel { > Elf32_Addrr_offs

[PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

'rtstatus' local variable is not used, so remove it for clean-up. Signed-off-by: Austin Kim --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realt

Re: [Patch 02/16] media: ti-vpe: vpe: Add missing null pointer checks

2019년 10월 1일 (화) 오전 12:56, Benoit Parrot 님이 작성: > > Hi Austin, > > Thanks for the review, It's my pleasure. Hope to see this patch will arrive the destination(linux-next) safely. :)

[PATCH] net/velocity: fix -Wunused-but-set-variable warnings

‘curr_status’ set but not used [-Wunused-but-set-variable] Signed-off-by: Austin Kim --- drivers/net/ethernet/via/via-velocity.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 346e441..36d402c 100

Re: [Patch 02/16] media: ti-vpe: vpe: Add missing null pointer checks

2019년 9월 28일 (토) 오전 3:37, Benoit Parrot 님이 작성: > > A few NULL pointer checks were missing. > Add check with appropriate return code. > > Signed-off-by: Benoit Parrot > --- > drivers/media/platform/ti-vpe/vpe.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/

[PATCH] ARM: module: remove 'always false' statement

gative value. So 'always false' statement can be dropped. Signed-off-by: Austin Kim --- arch/arm/kernel/module.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index deef17f..617de32 100644 --- a/arch/arm/kernel

[PATCH] fs: cifs: mute -Wunused-const-variable message

e_ERRHRD' [-Wunused-const-variable] static const struct smb_to_posix_error mapping_table_ERRHRD[] = { ^ Signed-off-by: Austin Kim --- fs/cifs/netmisc.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c inde

[PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement

Since tmp_prio is declared as u8, the following statement is always false. tmp_prio < 0 So remove 'always false' statement. Signed-off-by: Austin Kim --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_mai

Re: [PATCH] usb: hub: Minor refactoring in usb_hub_init()

re to contain an appropriate error code. Thanks, Austin Kim

Re: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement

2019년 9월 24일 (화) 오전 11:32, Martin K. Petersen 님이 작성: > > > Austin, [...] > > So remove 'always false' statement. > > Applied to 5.4/scsi-fixes, thanks! > Good, thanks for information. > -- > Martin K. Petersen Oracle Linux Engineering

[PATCH] usb: hub: Minor refactoring in usb_hub_init()

return 0; This might make other Linux driver developers get confused because they could deduce that this is exceptional handling routine. So perform minor refactoring by adding NULL pointer dereference check routine right after the call to alloc_workqueue() is made. Signed-off-by: Austin Kim --

Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Hello, Maintainers... Would you please review above patch if you are available? Thanks, Austin Kim 2019년 9월 17일 (화) 오후 3:50, Austin Kim 님이 작성: > > 'rtstatus' local variable is not used, > so remove it for clean-up. > > Signed-off-by: Austin Kim > --- > drive

[PATCH] xfs: avoid unused to_mp() function warning

quot;)' So kernel build with clang throws below warning message: fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function] to_mp(struct kobject *kobject) Hence to_mp() might be removed safely to get rid of warning message. Signed-off-by: Austin Kim --- fs/

[PATCH] scsi: libcxgbi: remove unused function to stop warning

int_ip(struct cxgbi_sock *csk, char *buf) ^ So it had better remove csk_print_port() and csk_print_ip() to stop warning. Signed-off-by: Austin Kim --- drivers/scsi/cxgbi/libcxgbi.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/scsi/cxgbi/libcxgbi

Re: NULL ptr deref in wq_worker_sleeping on 4.19

scenario. BR, Guillermo Austin Kim 2019년 8월 7일 (수) 오후 8:48, Sebastian Andrzej Siewior 님이 작성: > > On 2019-07-19 09:53:52 [-0400], Sasha Levin wrote: > > Hi folks, > Hi, > > > We're seeing a rare panic on boot in wq_worker_sleeping() on boot in > > 4.19 kernels. I

Re: NULL ptr deref in wq_worker_sleeping on 4.19

g. CONFIG_SLUB_DEBUG=y CONFIG_SLUB_DEBUG_ON=y 2019년 8월 7일 (수) 오후 9:56, Thomas Gleixner 님이 작성: > > On Wed, 7 Aug 2019, Austin Kim wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. >

[tip: x86/platform] x86/platform/uv: Fix kmalloc() NULL check routine

The following commit has been merged into the x86/platform branch of tip: Commit-ID: 864b23f0169d5bff677e8443a7a90dfd6b090afc Gitweb: https://git.kernel.org/tip/864b23f0169d5bff677e8443a7a90dfd6b090afc Author:Austin Kim AuthorDate:Fri, 06 Sep 2019 08:29:51 +09:00