The result of kmalloc should have been checked ahead of below statement:
        pqp = (struct bau_pq_entry *)vp;

Move BUG_ON(!vp) before above statement.

Signed-off-by: Austin Kim <austindh....@gmail.com>
---
 arch/x86/platform/uv/tlb_uv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 20c389a..5f0a96bf 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
 
        plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
        vp = kmalloc_node(plsize, GFP_KERNEL, node);
-       pqp = (struct bau_pq_entry *)vp;
-       BUG_ON(!pqp);
+       BUG_ON(!vp);
 
+       pqp = (struct bau_pq_entry *)vp;
        cp = (char *)pqp + 31;
        pqp = (struct bau_pq_entry *)(((unsigned long)cp >> 5) << 5);
 
-- 
2.6.2

Reply via email to