[PATCH v2 5/5] X86/XEN: Add few lines explaining simple semantic for x86_init.paging.pagetable_init setup function

2012-08-21 Thread Attilio Rao
- Explain the purpose of the hook - Report execution constraints Signed-off-by: Attilio Rao --- arch/x86/include/asm/x86_init.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 995ea5c..7ea4186

[PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic

2012-08-21 Thread Attilio Rao
re-arranged in a way that it helps reviews, following a plan by Thomas Gleixner - The PVOPS nomenclature is not used as it is not correct - The front-end message is adjusted with feedback by Thomas Gleixner, Stefano Stabellini and Konrad Rzeszutek Wilk Attilio Rao (5): X86/XEN: Remove the

[PATCH v2 3/5] X86/XEN: Allow setup function x86_init.paging.pagetable_init to setup kernel pagetables

2012-08-21 Thread Attilio Rao
Currently, x86_init.paging.pagetable_init relies on callers to setup the kernel pagetable. In order to unify the functionality of x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done allow the new setup function to perform the operation itself. Signed-off-by: Attilio

[PATCH v2 4/5] X86/XEN: Move content of xen_pagetable_setup_done() into xen_pagetable_init() and retire now unused x86_init.paging.pagetable_setup_done

2012-08-21 Thread Attilio Rao
At this stage x86_init.paging.pagetable_setup_done is only used in the XEN case. Move its content in the x86_init.paging.pagetable_init setup function and remove the now unused x86_init.paging.pagetable_setup_done remaining infrastructure. Signed-off-by: Attilio Rao --- arch/x86/include/asm

[PATCH v2 2/5] X86/XEN: Rename pagetable_setup_start() setup functions into pagetable_init()

2012-08-21 Thread Attilio Rao
In preparation for unifying the pagetable_setup_start() and pagetable_setup_done() setup functions, rename appropriately all the infrastructure related to pagetable_setup_start(). Signed-off-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |4 ++-- arch/x86/include/asm/x86_init.h

[PATCH v2 1/5] X86/XEN: Remove the base argument from x86_init.paging.pagetable_setup_start

2012-08-21 Thread Attilio Rao
x86_init.paging.pagetable_setup_start with x86_init.paging.pagetable_setup_done. Signed-off-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |6 +++--- arch/x86/include/asm/x86_init.h |2 +- arch/x86/kernel/setup.c |2 +- arch/x86/kernel/x86_init.c

Re: [PATCH 3/5] X86/XEN: Introduce the x86_init.paging.pagetable_init PVOPS

2012-08-21 Thread Attilio Rao
On 21/08/12 16:44, Thomas Gleixner wrote: On Tue, 21 Aug 2012, Attilio Rao wrote: This new PVOPS is responsible to setup the kernel pagetables and replace entirely x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done PVOPS work. For performance the

Re: [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic

2012-08-22 Thread Attilio Rao
On 22/08/12 15:19, Thomas Gleixner wrote: On Wed, 22 Aug 2012, Konrad Rzeszutek Wilk wrote: On Tue, Aug 21, 2012 at 11:22:03PM +0200, Thomas Gleixner wrote: On Tue, 21 Aug 2012, Attilio Rao wrote: Differences with v1: - The patch serie is re-arranged in a way that it helps

[PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve

2012-08-22 Thread Attilio Rao
xen_mapping_pagetable_reserve(), change printk into pr_debug. - In xen_mapping_pagetable_reserve(), print out diagnostic only if there is an actual need to do that (or, in other words, if there are actually some pages going to switch from RO to RW). Signed-off-by: Attilio Rao Reviewed-by: Konrad

[PATCH v4 0/2] XEN/X86: Document x86_init.mapping.pagetable_reserve and enforce a better semantic

2012-08-22 Thread Attilio Rao
ing bogus reference to the word PVOPS. Attilio Rao (2): XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve XEN: Document the semantic of x86_init.mapping.pagetable_reserve arch/x86/include/asm/x86_init.h | 19 +-- arch/x86/mm/init.c |

[PATCH v4 2/2] XEN: Document the semantic of x86_init.mapping.pagetable_reserve

2012-08-22 Thread Attilio Rao
context on the implementation in order to favourably understand the semantic. Signed-off-by: Attilio Rao Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini --- arch/x86/include/asm/x86_init.h | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch

Re: [Xen-devel] [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic

2012-08-23 Thread Attilio Rao
On 22/08/12 15:47, Attilio Rao wrote: On 22/08/12 15:19, Thomas Gleixner wrote: On Wed, 22 Aug 2012, Konrad Rzeszutek Wilk wrote: On Tue, Aug 21, 2012 at 11:22:03PM +0200, Thomas Gleixner wrote: On Tue, 21 Aug 2012, Attilio Rao wrote: Differences with v1: - The

Re: [Xen-devel] [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic

2012-08-23 Thread Attilio Rao
On 23/08/12 16:15, Thomas Gleixner wrote: On Thu, 23 Aug 2012, Attilio Rao wrote: On 22/08/12 15:47, Attilio Rao wrote: but I would like to repost the patch serie skipping the referral to PVOPS in the commit logs, I will do so right now, so please wait for another patch serie

Re: [PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve

2012-08-23 Thread Attilio Rao
On 23/08/12 16:46, Thomas Gleixner wrote: On Wed, 22 Aug 2012, Attilio Rao wrote: - Allow xen_mapping_pagetable_reserve() to handle a start different from pgt_buf_start, but still bigger than it. What's the purpose of this and how is this going to be used and how is it usef

Re: [PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve

2012-08-23 Thread Attilio Rao
On 23/08/12 18:14, Thomas Gleixner wrote: On Thu, 23 Aug 2012, Attilio Rao wrote: On 23/08/12 16:46, Thomas Gleixner wrote: On Wed, 22 Aug 2012, Attilio Rao wrote: - Allow xen_mapping_pagetable_reserve() to handle a start different from pgt_buf_start, but still bigger

Re: [PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve

2012-08-24 Thread Attilio Rao
On 24/08/12 11:03, Borislav Petkov wrote: On Thu, Aug 23, 2012 at 06:13:39PM +0100, Attilio Rao wrote: You seriously think that adding a single-check, that will be certainly skipped (now), in a boot-time function is going to add any performance burden? What you are doing is actively

Re: [PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve

2012-08-24 Thread Attilio Rao
On 24/08/12 14:00, Thomas Gleixner wrote: On Fri, 24 Aug 2012, Konrad Rzeszutek Wilk wrote: His goal was to document the semantics of the call. We all want to clean up the mess of extra calls that don't make sense (remember the write_msr_safe one?) and the first step is get some of the calls

[PATCH v2 0/2] XEN/X86: Document pagetable_reserve PVOPS and enforce a better semantic

2012-08-16 Thread Attilio Rao
nce to be used later on for others PVOPS. The difference with v1 is that sh_start local variable in xen_mapping_pagetable_reserve() is renamed as begin. Also, the commit messages have been tweaked. Attilio Rao (2): XEN, X86: Improve semantic support for pagetable_reserve PVOPS Xen: Document

[PATCH v2 2/2] XEN: Document the semantic of the pagetable_reserve PVOPS

2012-08-16 Thread Attilio Rao
on the implementation in order to favourably understand the semantic. Signed-off-by: Attilio Rao Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini --- arch/x86/include/asm/x86_init.h | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch

[PATCH v2 1/2] XEN/X86: Improve semantic support for pagetable_reserve PVOPS

2012-08-16 Thread Attilio Rao
xen_mapping_pagetable_reserve(), change printk into pr_debug. - In xen_mapping_pagetable_reserve(), print out diagnostic only if there is an actual need to do that (or, in other words, if there are actually some pages going to switch from RO to RW). Signed-off-by: Attilio Rao Reviewed-by: Konrad

[PATCH 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done PVOPS and document the semantic

2012-08-20 Thread Attilio Rao
operations on it. The new PVOPS must be called only once, during boot-time setup and after the direct mapping for physical memory is available. Attilio Rao (5): XEN: Remove the base argument from x86_init.paging.pagetable_setup_done PVOPS XEN: Remove the base argument from

[PATCH 1/5] XEN: Remove the base argument from x86_init.paging.pagetable_setup_done PVOPS

2012-08-20 Thread Attilio Rao
x86_init.paging.pagetable_setup_done PVOPS does not really need to know about the base argument, thus just remove it. Signed-off-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |6 +++--- arch/x86/include/asm/x86_init.h |2 +- arch/x86/kernel/setup.c |2

[PATCH 3/5] X86/XEN: Introduce the x86_init.paging.pagetable_init PVOPS

2012-08-20 Thread Attilio Rao
-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |2 + arch/x86/include/asm/x86_init.h |2 + arch/x86/kernel/x86_init.c |1 + arch/x86/mm/init_32.c| 35 ++ arch/x86/xen/mmu.c | 12 +- 5

[PATCH 2/5] XEN: Remove the base argument from x86_init.paging.pagetable_setup_start PVOPS

2012-08-20 Thread Attilio Rao
x86_init.paging.pagetable_setup_start with x86_init.paging.pagetable_setup_done PVOPS. Signed-off-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |6 +++--- arch/x86/include/asm/x86_init.h |2 +- arch/x86/kernel/setup.c |2 +- arch/x86/kernel/x86_init.c

[PATCH 4/5] X86/XEN: Retire now unused x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done PVOPS

2012-08-20 Thread Attilio Rao
Now that x86_init.paging.pagetable_init PVOPS is implemented just retire the 2 mentioned above and replace their usage with it. Signed-off-by: Attilio Rao --- arch/x86/include/asm/pgtable_types.h |4 --- arch/x86/include/asm/x86_init.h |4 --- arch/x86/kernel/setup.c

[PATCH 5/5] X86/XEN: Add few lines explaining simple semantic for x86_init.paging.pagetable_init PVOPS

2012-08-20 Thread Attilio Rao
- Explain the purpose of the PVOPS - Report execution constraints Signed-off-by: Attilio Rao --- arch/x86/include/asm/x86_init.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 995ea5c..7ea4186

[PATCH v3 0/2] XEN/X86: Document pagetable_reserve PVOPS and enforce a better semantic

2012-08-21 Thread Attilio Rao
mat strings for panic() and pr_debug(). Also, the range printing format has been unified and PFN_PHYS() members are casted to u64 on printing, to remain consistent (which is basically what also lib/swiotlb.c does. Attilio Rao (2): XEN/X86: Improve semantic support for pagetable_reserve PVOPS

[PATCH v3 1/2] XEN/X86: Improve semantic support for pagetable_reserve PVOPS

2012-08-21 Thread Attilio Rao
xen_mapping_pagetable_reserve(), change printk into pr_debug. - In xen_mapping_pagetable_reserve(), print out diagnostic only if there is an actual need to do that (or, in other words, if there are actually some pages going to switch from RO to RW). Signed-off-by: Attilio Rao Reviewed-by: Konrad

[PATCH v3 2/2] XEN: Document the semantic of the pagetable_reserve PVOPS

2012-08-21 Thread Attilio Rao
on the implementation in order to favourably understand the semantic. Signed-off-by: Attilio Rao Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini --- arch/x86/include/asm/x86_init.h | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch

Re: [PATCH 2/5] XEN: Remove the base argument from x86_init.paging.pagetable_setup_start PVOPS

2012-08-21 Thread Attilio Rao
On 21/08/12 16:41, Thomas Gleixner wrote: On Tue, 21 Aug 2012, Attilio Rao wrote: diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c index 1019156..7999cef 100644 --- a/arch/x86/mm/init_32.c +++ b/arch/x86/mm/init_32.c @@ -445,14 +445,17 @@ static inline void permanent_kmaps_init

[tip:x86/platform] x86: Remove base argument from x86_init.paging. pagetable_setup_start

2012-09-12 Thread tip-bot for Attilio Rao
Commit-ID: 73090f8993a40a2f67fed1ab866a928c68cd3765 Gitweb: http://git.kernel.org/tip/73090f8993a40a2f67fed1ab866a928c68cd3765 Author: Attilio Rao AuthorDate: Tue, 21 Aug 2012 21:22:37 +0100 Committer: Thomas Gleixner CommitDate: Wed, 12 Sep 2012 15:33:06 +0200 x86: Remove base

[tip:x86/platform] x86: Rename pagetable_setup_start() to pagetable_init()

2012-09-12 Thread tip-bot for Attilio Rao
Commit-ID: 7737b215ad0f94d20a87d98315da9f6cadaf35c9 Gitweb: http://git.kernel.org/tip/7737b215ad0f94d20a87d98315da9f6cadaf35c9 Author: Attilio Rao AuthorDate: Tue, 21 Aug 2012 21:22:38 +0100 Committer: Thomas Gleixner CommitDate: Wed, 12 Sep 2012 15:33:06 +0200 x86: Rename

[tip:x86/platform] x86: Move paging_init() call to x86_init.paging .pagetable_init()

2012-09-12 Thread tip-bot for Attilio Rao
Commit-ID: 843b8ed2ec598aae5e3516b21957ede62a070e36 Gitweb: http://git.kernel.org/tip/843b8ed2ec598aae5e3516b21957ede62a070e36 Author: Attilio Rao AuthorDate: Tue, 21 Aug 2012 21:22:39 +0100 Committer: Thomas Gleixner CommitDate: Wed, 12 Sep 2012 15:33:06 +0200 x86: Move paging_init

[tip:x86/platform] x86: xen: Cleanup and remove x86_init.paging. pagetable_setup_done()

2012-09-12 Thread tip-bot for Attilio Rao
Commit-ID: c711288727a62f74d48032e56e51333dd104bf58 Gitweb: http://git.kernel.org/tip/c711288727a62f74d48032e56e51333dd104bf58 Author: Attilio Rao AuthorDate: Tue, 21 Aug 2012 21:22:40 +0100 Committer: Thomas Gleixner CommitDate: Wed, 12 Sep 2012 15:33:06 +0200 x86: xen: Cleanup and

[tip:x86/platform] x86: Document x86_init.paging.pagetable_init()

2012-09-12 Thread tip-bot for Attilio Rao
Commit-ID: 64282278989d5b0398dcb3ba7904cb00c621dc35 Gitweb: http://git.kernel.org/tip/64282278989d5b0398dcb3ba7904cb00c621dc35 Author: Attilio Rao AuthorDate: Tue, 21 Aug 2012 21:22:41 +0100 Committer: Thomas Gleixner CommitDate: Wed, 12 Sep 2012 15:33:07 +0200 x86: Document