Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-31 Thread Andrew Vasquez
On Tue, 08 Jan 2008, Benjamin Herrenschmidt wrote: > On Mon, 2008-01-07 at 11:42 -0800, Andrew Vasquez wrote: > > That's fine. I take it these patches will be funneled via > > gregkh/pci-2.6.git. There's some qla2xxx updates which are queued for > > post-2.6.24 co

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
7;m certainly willing to help narrow down to the specific part in > this patch... That's a rather large patch... :( Any chance you could git-bisect? Also, could you send your .config file you are using? Thanks, Andrew Vasquez -- To unsubscribe from this list: send the line "unsubscribe

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Andrew Vasquez wrote: > On Tue, 05 Feb 2008, Alan D. Brunelle wrote: > > > commit 9b73e76f3cf63379dcf45fcd4f112f5812418d0a > > Merge: 50d9a12... 23c3e29... > > Author: Linus Torvalds <[EMAIL PROTECTED]> > > Date: Fri Jan 25 17:19:

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Andrew Vasquez wrote: > > Could you load the (default 2.6.24) driver with > > ql2xextended_error_logging modules parameter set: > > > > # insmod qla2xxx ql2xextended_error_logging=1 > > > > and send the resultant kernel logs? >

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Alan D. Brunelle wrote: > > and send the resultant kernel logs? > > Here's the output to the console (if there are other logs you need, > let me know). I'll try the patch next, and sorry, hadn't realized > merges were still coming in under 2.6.24 in Linus' tree... > > QLogi

Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013-03-10 Thread Andrew Vasquez
ita wrote: > > > > This fixes the wrong position of the comment introduced by > > > > scsi-rename-random32-to-prandom_u32.patch in the -mm tree. > > > > > > > > Signed-off-by: Akinobu Mita > > > > Cc: "James E.J. Bottomley" > &

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > This patch removes dead code spotted by the Coverity checker. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +--

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > > On Tue, 19 Feb 2008, James Bottomley wrote: > > > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > > This patch removes dead

Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile

2005-07-15 Thread Andrew Vasquez
4XX) += qla2xxx.o > > > I don't know what exactly you want to achieve, but this is so horribly > wrong. Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> ---

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-26 Thread Andrew Vasquez
I approach > this problem? A similar problem was noted with RHEL4, it seems the modules.pcimap and pci.ids file were correct, but the pcitable file contained entries for all ql[ae]23xx based HBAs to load qla2300.ko. It's my understanding that this was fixed for RHEL4 U1. Which distro are

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-27 Thread Andrew Vasquez
On Wed, 27 Jul 2005, Rajat Jain wrote: > On 7/27/05, Andrew Vasquez <[EMAIL PROTECTED]> wrote: > > > > A similar problem was noted with RHEL4, it seems the modules.pcimap > > and pci.ids file were correct, but the pcitable file contained entries > > for all ql[a

Re: Fix up qla2xxx configuration bogosity

2005-07-27 Thread Andrew Vasquez
=e4ff4d7f9d85a2bc714307eb9113617182e62845 Would you also apply the attached patch which adds the appropriate FW_LOADER pre-requisite and a separate entry for ISP24xx support. Thanks to Adrian Bunk and Jesper Juhl for their efforts in fixing this quirk. Regards, Andrew Vasquez --- diff --git a/drivers/scsi/qla2xxx/Kconfig b

Re: Fix up qla2xxx configuration bogosity

2005-07-28 Thread Andrew Vasquez
On Thu, 28 Jul 2005, James Bottomley wrote: > On Wed, 2005-07-27 at 22:10 -0700, Andrew Vasquez wrote: > > Would you also apply the attached patch which adds the appropriate > > FW_LOADER pre-requisite and a separate entry for ISP24xx support. > > That's what I see rea

Re: 2.6.13-rc7 qla2xxx unaligned accesses

2005-08-24 Thread Andrew Vasquez
e_name and port_name arrays to an u64 would cause unaligned-access warnings. Generalize the conversions with consistent shifting of WWN bytes. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_attr.c | 27 +

Re: 2.6.13-rc7 qla2xxx unaligned accesses

2005-08-26 Thread Andrew Vasquez
On Thu, 25 Aug 2005, Keith Owens wrote: > On Wed, 24 Aug 2005 11:22:52 -0700, > Andrew Vasquez <[EMAIL PROTECTED]> wrote: > >On Wed, 24 Aug 2005, Keith Owens wrote: > > > >> 2.6.13-rc7 + kdb on ia64. The qla2xxx drivers are getting unaligned > >> acces

Re: [PATCH 2.6.13] Warning in the qla2xxx driver

2005-09-08 Thread Andrew Vasquez
On Thu, 01 Sep 2005, Daniel Walker wrote: > Remove possible uninitialized "sg" field warning in the qla24xx driver > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > Index: linux-2.6.13/drivers/scsi/qla2xxx/qla_iocb.c > === >

Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-07 Thread Andrew Vasquez
n several of our test rings. I hold off on some of the cleanup post-merge time... Thanks, Andrew Vasquez > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > --- > > drivers/ata/pata_cs5520.c |2 +- > drivers/i2c/busses/scx200_acb.c |2 +- > driv

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Andrew Vasquez
On Mon, 08 Oct 2007, Darrick J. Wong wrote: > If the aic94xx chip doesn't have a SAS address in the chip's flash memory, > use the request_firmware() interface to get one from userspace. This > way, there's no debate as to who or how an address gets generated--it's > totally up to the administrat

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-08 Thread Andrew Vasquez
On Mon, 08 Oct 2007, Darrick J. Wong wrote: > On Mon, Oct 08, 2007 at 03:48:32PM -0700, Andrew Vasquez wrote: > > > So how about factoring that out to a transport-level interface. How > > about something along the lines of the following patch, whereby the > > software

Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one

2007-10-09 Thread Andrew Vasquez
On Tue, 09 Oct 2007, James Smart wrote: > Why do you prefer request_firmware() vs something over sysfs ? > > Does environments like the kdump kernel also have access to data needed > by request_firmware() ? There's already much in the way of automation and infrastructure present in supporting

Re: [PATCH] drivers/scsi/: Spelling fixes

2007-12-17 Thread Andrew Vasquez
|4 ++-- > drivers/scsi/lpfc/lpfc.h |2 +- > drivers/scsi/lpfc/lpfc_mbox.c |2 +- > drivers/scsi/megaraid/megaraid_mbox.c | 10 +- > drivers/scsi/psi240i.c|2 +- > drivers/scsi/qla2xxx/qla_gs.c |2 +- qla2xxx bit

kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
Hitting a consistent BUG() with recent Linus' linux-2.6.git: [ 12.941428] [ cut here ] [ 12.944874] kernel BUG at drivers/block/cciss.c:1260! [ 12.944874] invalid opcode: [1] SMP [ 12.944874] CPU 0 [ 12.944874] Module

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > Great, thanks for confirming. It does look like a clear bug in cciss, it > just got exposed now that it uses proper end request handling. We never > need to clear ->data_len, since for blk_fs_request() it will be cleared > on init. So just setting a residua

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Luck, Tony wrote: > > > Will try this next. > > > > Should work even better since it avoids a lock and copy, but please do > > test if you have the time. > > That one works too (survived two full builds at "make -j32" on the 16-way > system). > > Thanks for the quick turnaro

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > > Here the final snippet that was logged: > > > > > > > > [ 12.724997] input: USB HID v1.01 Mouse [

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > Andrew, can you try with this applied? > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index ef50068..bd7b352 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -1257,7 +1257,7 @@ static void cciss_softirq_done(struct

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > > Here the final snippet that was logged: > > > > [ 12.724997] input: USB HID v1.01 Mouse [HP Virtual Keyboard] on > > usb-:01:04.4-1 > > [ 12.728971] usbcore: registered new interface driver usbhid > > [ 12.732866] drivers/hid/usbhid/hid-core.c

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Miller, Mike (OS Dev) wrote: > Jens wrote: > > > -Original Message- > > From: Jens Axboe [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, January 29, 2008 12:54 PM > > To: Andrew Vasquez > > Cc: Linux Kernel Mailing List; Miller,

Re: qla2xxx fail over support

2005-03-14 Thread Andrew Vasquez
ftp://ftp.qlogic.com/outgoing/linux/beta/8.x/ more specifically: ftp://ftp.qlogic.com/outgoing/linux/beta/8.x/qla2xxx-v8.00.02b10-dist.tgz Regards, Andrew Vasquez - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH] quiet non-x86 option ROM warnings

2005-02-17 Thread Andrew Vasquez
k the > > signature, and iterate all "partitions" til it finds the proper > > architecture (or none). > > The spec allows for it but has anyone actually seen a ROM with > multiple images in it? I haven't but I only work on x86. > Yes. Many SCSI and fibre-channel c

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Andrew Vasquez
PARM_DESC(ConfigRequired, > "If 1, then only configured devices passed in through the" > @@ -119,7 +118,7 @@ > "target returns a status. Default is 10 " > "iterations."); > > -int ql2xdoinitscan = 1; > +sta

Re: Direct io on block device has performance regression on 2.6.x kernel

2005-03-09 Thread Andrew Vasquez
d my interest -- since looking through a previous email it seems you are using the qla2xxx driver. Care to elaborate? Regards, Andrew Vasquez - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [3/3] 2.6.23-rc2: known regressions v2

2007-08-08 Thread Andrew Vasquez
On Wed, 08 Aug 2007, Michal Piotrowski wrote: > Here is a list of some known regressions in 2.6.23-rc2. > > Feel free to add new regressions/remove fixed etc. > http://kernelnewbies.org/known_regressions ... > SCSI > > Subject : unable to handle kernel NULL pointer dereference in > qla2

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-26 Thread Andrew Vasquez
port the speed of 266 MHz, and is it just displayed > > incorrectly, > > or doesn't Linux support the speed of 266MHz yet? > > This is a bug in the driver. The lookup table only goes to 133 MHz. > > static char *pci_bus_modes[] = { > "33", "

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-27 Thread Andrew Vasquez
On Fri, 27 Jul 2007, Andrew Patterson wrote: > On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote: > > > The 33/66/100/133 values refer to the bus-clock speed at which the > > card is operating. As is seen here (although a bit truncated -- > > separate issue,

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

2007-07-31 Thread Andrew Vasquez
> On Fri, 27 Jul 2007, Andrew Patterson wrote: > > > On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote: > > > > > The 33/66/100/133 values refer to the bus-clock speed at which the > > > card is operating. As is seen here (although a bit truncated -- &

Re: [PATCH 64] drivers/scsi/qla2xxx/qla_init.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Andrew Vasquez
scsi/qla2xxx/qla_init.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Acked-by: Andrew Vasquez <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

[PATCH] qla2xxx: allocate enough space for the full PCI descriptor.

2007-08-01 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- On Thu, 26 Jul 2007, Andrew Vasquez wrote: > On Thu, 26 Jul 2007, Andrew Patterson wrote: > > > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote: > > > Hi, >

[BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-01-22 Thread Andrew Vasquez
f code where ad->next_rq[REQ_ASYNC] is checked against NULL (in 'writes' case it is not). Anyway, any ideas or hints? Attached is the .config used. Thanks, Andrew Vasquez # # Automatically generated make config: don't edit # Linux kernel version: 2.6.19 # Fri Jan 19 16:53:1

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-26 Thread Andrew Vasquez
779892] [] qla24xx_process_response_queue+0xc1/0x1c0 > [ 75.780012] [] qla24xx_intr_handler+0x1d4/0x2b0 > [ 75.780131] [] handle_IRQ_event+0x20/0x60 Hmm Regards, Andrew Vasquez - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-27 Thread Andrew Vasquez
On Tue, 27 Feb 2007, Andre Noll wrote: > On 10:26, Andrew Vasquez wrote: > > You are loading some stale firmware that's left over on the card -- > > I'm not even sure what 4.00.70 is, as the latest release firmware is > > 4.00.27. > > That's the firmwar

Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-02-02 Thread Andrew Vasquez
On Thu, 01 Feb 2007, Andrew Morton wrote: > On Mon, 22 Jan 2007 10:35:10 -0800 Andrew Vasquez <[EMAIL PROTECTED]> wrote: > > Basically what is happening from the FC side is the initiator executes > > a simple dt test: > > > > dt of=/dev/raw/raw1 procs=8

Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-02-02 Thread Andrew Vasquez
On Fri, 02 Feb 2007, Randy Dunlap wrote: > On Fri, 2 Feb 2007 16:25:41 -0800 Andrew Morton wrote: > > > On Fri, 2 Feb 2007 12:56:30 -0800 > > Andrew Vasquez <[EMAIL PROTECTED]> wrote: > > > > > > > dt of=/dev/raw/raw1 procs=8 oncerr=abort bs

Re: [-mm patch] make qla2x00_reg_remote_port() static

2006-11-27 Thread Andrew Vasquez
now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Andrew Vasquez <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] quiet down swiotlb warnings

2007-06-01 Thread Andrew Vasquez
On Fri, 01 Jun 2007, Andi Kleen wrote: > Rik van Riel <[EMAIL PROTECTED]> writes: > > > It turns out that the qla2xxx driver sometimes fills up the iotlb > > on purpose and throttles itself when pci_map_sg() fails. In the > > case of a driver that expects and handles pci_map_sg() failures, > > w

Re: [PATCH] quiet down swiotlb warnings

2007-06-01 Thread Andrew Vasquez
On Fri, 01 Jun 2007, Andi Kleen wrote: > On Fri, Jun 01, 2007 at 03:38:57PM -0400, Rik van Riel wrote: > > Andi Kleen wrote: > > > > >An pci_map_sg failing typically leads to an IO error and we've > > >always printk'ed those. Otherwise people will wonder why they > > >get EIO. > > > > In some si

Re: [PATCH 0/2] PCI-X/PCI-Express read control interfaces

2007-05-15 Thread Andrew Vasquez
On Tue, 15 May 2007, Andrew Morton wrote: > On Tue, 15 May 2007 13:50:27 +0200 > "Peter Oruba" <[EMAIL PROTECTED]> wrote: > > > This patch set introduces a PCI-X / PCI-Express read byte count control > > interface. Instead of letting every driver to directly read/write to PCI > > config space f

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
on the mesh, but if > that is so important just choose some random value that is a valid FC > ID or use some characteristic ID that can be used to compose part of > the port WWN in order to give it at least some uniqueness. Look, there's a fine balance here that we must strike --

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: > From: Andrew Vasquez <[EMAIL PROTECTED]> > Date: Mon, 16 Apr 2007 09:37:12 -0700 > > > On Mon, 16 Apr 2007, David Miller wrote: > > > > > But even if that fails, I think the fallback code should be put back, >

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, Andrew Vasquez wrote: > On Mon, 16 Apr 2007, David Miller wrote: > > > They DON'T > > CARE, they want their systems to work and if you don't give them that > > you're not being a good driver maintainer. > > Let's push as

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: > From: Andrew Vasquez <[EMAIL PROTECTED]> > Date: Mon, 16 Apr 2007 14:10:49 -0700 > > > Ok, how about the following patch based on the one you posted which > > adds the codes to retrieve the WWPN/WWNN from firmware on SPARC, a

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: > From: Andrew Vasquez <[EMAIL PROTECTED]> > Date: Mon, 16 Apr 2007 15:25:17 -0700 > > > Fine, I'll agree that wacking-users (and > > I'll wager the outliers) with a 2x4 was a bit extreme, > > And tha

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: > From: Andrew Vasquez <[EMAIL PROTECTED]> > Date: Mon, 16 Apr 2007 16:28:51 -0700 > > > Sorry, but let's be realistic, this type of warning would have > > *NEVER* been addressed if we kept the status quo > > Wro

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: > From: Andrew Vasquez <[EMAIL PROTECTED]> > Date: Mon, 16 Apr 2007 16:47:05 -0700 > > > Dave, according to your earlier emails, the qla2xxx driver worked > > 'fine' in driver versions before commit > > 7aef45a

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread Andrew Vasquez
On Wed, 18 Apr 2007, Christoph Hellwig wrote: > I don't think a module option is a good idea at this point. The problem > is you broke some so far perfectly working setups, which is not okay. > The only first step can be printing a really big warning. After this > has been in for a while (at les

Re: Major qla2xxx regression on sparc64

2007-04-19 Thread Andrew Vasquez
re-upcalls to retrieve the wwpn/wwnn. > If it's just a time issue I can work on and push the patch, especially > since I have the means to test things here. I'll start with the final 2.6.21 -- add modify to add the *flashing* light warning and some additional bits based on ot