In the err_free_vram and err_release_fbi error paths in astfb_create(), we
attempt to free afbdev->sysram. The only jumps to these error paths occur
before we assign afbdev->sysram = sysram. Free sysram instead.
Signed-off-by: Andrew Donnellan
---
Found by Coverity Scan. Compile teste
On 20/09/16 11:56, Andrew Donnellan wrote:
In the err_free_vram and err_release_fbi error paths in astfb_create(), we
attempt to free afbdev->sysram. The only jumps to these error paths occur
before we assign afbdev->sysram = sysram. Free sysram instead.
Signed-off-by: Andrew Don
d-off-by: Andrew Donnellan
---
Checked the of_node_put() with Fred, he thinks it was probably just left
over from an earlier private version of the code and we can just get rid of
it.
---
drivers/misc/cxl/of.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/mis
On 05/08/16 08:58, York Sun wrote:
Two symbols are missing if mpc85xx_edac driver is compiled as module.
Signed-off-by: York Sun
Good catch! One comment below.
Reviewed-by: Andrew Donnellan
/*
* Reads the interrupt pin to determine if interrupt is use by card.
@@ -1585,6 +1586,7
x")
Reported-by: Madhavan Srinivasan
Signed-off-by: Akshay Adiga
Tested-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 08/08/16 13:17, Stephen Rothwell wrote:
Please do not add material destined for v4.9 to your linux-next included
branches until after v4.8-rc1 has been released.
Which has now happened :)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia
Signed-off-by: Andrew Donnellan
---
scripts/package/builddeb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 8ea9fd2..d600fd0 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -69,7 +69,7
ation of the linux-headers, linux-libc-dev and linux-firmware
packages to be disabled if the environment variables KDEB_NO_HEADERS,
KDEB_NO_LIBC_HEADERS or KDEB_NO_FIRMWARE are non-empty.
Signed-off-by: Andrew Donnellan
---
On top of d3e2773c4ede5c62d2a92dae20e3a09b1ca55b6e in kbuild#rc-
On 16/08/17 06:18, Christophe JAILLET wrote:
'rc' is known to be 0 at this point.
If 'create_context()' fails, returns -ENOMEM instead of 0 which means
success.
Signed-off-by: Christophe JAILLET
ENOMEM seems right here.
Reviewed-by: Andrew Donnellan
---
d
rship details.
If you then re-send it, it should skip this From: line and everything
should be fine.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
-accelerators
Archives: https://lists.ozlabs.org/pipermail/linux-accelerators
I haven't set up Patchwork as yet, but if people think that's a good
idea I can get that done too.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Reviewed-by: Andrew Donnellan
---
arch/powerpc/include/asm/eeh.h | 2 +-
arch/powerpc/kernel/eeh_driver.c | 2 +-
arch/powerpc/kernel/eeh_pe.c | 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index
e at andrew.donnel...@au1.ibm.com.
For general LCA questions, ask t...@lca2018.org or @linuxconfau on Twitter.
- Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 03/08/18 20:20, Parth Y Shah wrote:
Resolved <"foo* bar" should be "foo *bar"> error
Signed-off-by: Parth Y Shah
Thanks for picking this up.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Signed-off-by: Andrew Donnellan
---
RFC because I'm bad at Perl
---
scripts/checkpatch.pl | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index aca4d758112a..ae7a54287db7 100755
--- a/sc
the value of the 'copros' counter of the memory context.
===
checkpatch will return a GIT_COMMIT_ID error even though the reference
actually follows the correct format.
Fix the GIT_COMMIT_ID test so it can match against a reference that spans 3
lines.
Reported-by: Frederic Barrat
S
I've got some spare time over the
next few days and send a v2.
Thanks,
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
written! :D
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
< 0
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King
Thanks for picking this up!
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
On 20/01/18 20:52, Michael Ellerman wrote:> On my Power8 PowerVM LPAR:
Will fix...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 12/03/18 22:36, Arvind Yadav wrote:
if device_register() returned an error! Always use put_device()
to give up the reference initialized.
Signed-off-by: Arvind Yadav
This looks right, thanks for picking it up.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
On 26/9/18 9:41 pm, zhong jiang wrote:
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang
Thanks for catching this.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc
On 11/05/18 16:12, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
On 21/10/18 12:10 pm, Andrew Donnellan wrote:
The linux.conf.au Kernel Miniconf is happening once again, this time in
Christchurch on 22 Jan 2019.
*** Submissions close on 2018-12-16, 23:59 AoE, with early submissions
(before 2018-11-16, 23:59 AoE) given priority. ***
This deadline is in
On 4/10/18 3:02 pm, zhong jiang wrote:
It is not safe to dereference an object before a null test. It is
not needed and just remove them. Ftrace can be used instead.
Signed-off-by: zhong jiang
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 2 --
1 file changed, 2 deletions
-cfp.html for full details and the
submission form.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
. Alastair has also confirmed with me that truncating the pid to a u16
should be safe, so therefore:
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Use %# instead of using a literal '0x'
Signed-off-by: Alastair D'Silva
Not hugely fussed either way, but today I learned about %#...
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
No need for a return value in read_pasid as it only returns 0.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 9 ++---
1
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The 'extern' keyword adds no value here.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 54 +++
include/misc/
t pasid, __u16 tid);
+
This isn't actually exported, so if you spin a v2 do that separately
from this patch or document the change.
Otherwise
Acked-by: Andrew Donnellan
struct ocxl_context *ocxl_context_alloc(void);
int ocxl_context_init(struct ocxl_context *ct
ixing.
Acked-by: Andrew Donnellan
arch/powerpc/include/asm/pnv-ocxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/pnv-ocxl.h
b/arch/powerpc/include/asm/pnv-ocxl.h
index 208b5503f4ed..7de82647e761 100644
--- a/arch/powerpc/include/asm/pnv-ocxl.h
d for the process element
- */
-int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid);
-
/*
* Remove a Process Element from the Shared Process Area for a link
*/
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 15/3/19 3:49 pm, Andrew Donnellan wrote:
On 13/3/19 3:07 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Remove some unused exported symbols.
Signed-off-by: Alastair D'Silva
See comments on v1
Also a couple of sparse warnings at
https://openpower.xyz/job/snowpatc
he CAPI or
OpenCAPI protocol respectively - many of which will be FPGA boards
flashed with customer-designed accelerator cores for specific workloads,
some will be accelerators using ASICs or using FPGA images supplied by
vendors, some will be driven from userspace, others using the cxl/ocxl
kernel A
q_alloc);
void ocxl_link_free_irq(void *link_handle, int hw_irq)
{
- struct link *link = (struct link *) link_handle;
+ struct ocxl_link *link = (struct ocxl_link *) link_handle;
pnv_ocxl_free_xive_irq(hw_irq);
atomic_inc(&link->irq_available);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ocxl_link * rather
than void *, and update the function signature for ocxl_link_update_pe()
as well.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 27/2/19 7:04 pm, Alastair D'Silva wrote:
-Original Message-
From: Andrew Donnellan
Sent: Wednesday, 27 February 2019 6:55 PM
To: Alastair D'Silva ; 'Alastair D'Silva'
Cc: 'Greg Kurz' ; 'Frederic Barrat'
; 'Arnd Bergmann' ; '
On 29/1/21 7:25 pm, Yang Li wrote:
Fix the following coccicheck warning:
./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not
needed here
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Reviewed-by: Andrew Donnellan
Thanks!
---
drivers/misc/cxl/sysfs.c | 2 +-
1 file
xing" the changlog on that commit,
which included the full ID. Obviously, counting to 12 is a challenging
task for a slow guy like me...:)
No, no, my local tree tells me that *I* made that tag by hand and failed
to count properly... sorry for the noise!
--
Andrew Donnellan
On 22/3/21 1:33 pm, Bhaskar Chowdhury wrote:
s/filesytem/filesystem/
s/symantics/semantics/
Signed-off-by: Bhaskar Chowdhury
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/context.c b
On 26/3/21 10:53 pm, dingsen...@163.com wrote:
From: dingsenjie
Remove unneeded variable: "rc".
Signed-off-by: dingsenjie
This looks obviously correct and doesn't raise any checkpatch warnings.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs,
tching this!
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 11/3/21 4:44 am, Laurent Dufour wrote:
It is better to rely on the API provided by the MM layer instead of
directly manipulating the mm_users field.
Signed-off-by: Laurent Dufour
LGTM, thanks for picking this up
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
uot;).
Thanks for picking this up.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 30/11/20 1:45 pm, Andrew Donnellan wrote:
LCA2021 Kernel Miniconf - Online - 2021-01-23
-
LCA Kernel Miniconf submissions now open! (Ever wanted to present at
LCA, but couldn't justify flying to Australia? Well, 2021 is your chance
- we
On 25/12/20 12:24 am, Zheng Yongjun wrote:
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com
of all
levels of experience in the kernel community, covering a broad range of
topics. The focus of the miniconf will primarily be on Linux, however
non-Linux talks of sufficient interest to a primarily Linux audience
will be considered.
--
Andrew Donnellan OzLabs,
ttp://lca-kernel.ozlabs.org/2021-cfs.html
Thanks for reporting!
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 30/11/20 2:46 pm, Andrew Donnellan wrote:
On 30/11/20 2:38 pm, CRISTIAN ANDRES VARGAS GONZALEZ wrote:
> More info: https://lca-kernel.ozlabs.org/2021-cfs.html
<https://lca-kernel.ozlabs.org/2021-cfs.html>
Hi, this link no working. :c
Ugh, let me fix my TLS setup. In the mean
s).
+
If this plugin is intended primarily as a demonstration it's probably
worth mentioning this in the Kconfig description.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
I've done some basic sanity testing on powerpc with the cyclomatic
complexity plugin (with LE native + cross-compilers) and it seems to
work with the patch below.
Signed-off-by: Andrew Donnellan
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index a18a0dc..0cfed5b 100644
---
On 18/05/16 20:33, Emese Revfy wrote:
Did you test the plugins with all gcc versions (4.5-6)?
No, I tested with 4.8 and 5.2 as those are the toolchains I have on hand
- I'll try to test with the rest of 4.5 - 6.1.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel..
d in 4.5, so we don't care about <=4.4.
However if Andrew's only tested on little endian, then that select should be
guarded with an "if CPU_LITTLE_ENDIAN". And to build LE you need gcc >= 4.9.
I'm going to give BE a test too just to be sure.
--
Andrew Donnellan
;ed on the plugin
infrastructure
so that arch maintainers are aware of this?
Upon further testing it does seem we've got header issues as well as
hitting a segfault on 4.7.0. Looking into it further...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
as found in linux-next, along with the SANITIZE_ALL
typo fix, on a big-endian BML system, with gcc 5.2.1. It successfully
picked up one of the shift input issues that Daniel found, so therefore...
Tested-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.do
On 10/03/16 12:18, Ian Munsie wrote:
On a related matter, we should send a patch to remove some of the
leftover config options that were added to smooth the merging of
cxlflash in the first place (CXL_KERNEL_API, CXL_EEH).
I'm happy to do that after this series is merged.
--
Andrew Donn
where blank space is required. The device may
only be accessed by a single process at a time.
Signed-off-by: Suraj Jitindar Singh
I reviewed an earlier version of this patch internally and Suraj has
fixed a bunch of issues which I raised. I'm not hugely experienced with
this, but all t
.
Signed-off-by: Markus Elfring
Thanks for picking this up - will remember in my future patches.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia
On 17/9/19 3:42 am, Alastair D'Silva wrote:
From: Alastair D'Silva
Add OPAL calls for LPC memory alloc/release
Signed-off-by: Alastair D'Silva
This needs rebasing, but apart from that.
Acked-by: Andrew Donnellan
---
arch/powerpc/include/asm/opal-api.h| 4 +++-
++ style should be used)
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches
Signed-off-by: Nishad Kamdar
Thanks.
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 2 +-
drivers/misc/ocxl/trace.h
/2020-cfs.html **
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
Looking at 64-bit book3s: with 64K pages, this results in a THREAD_SIZE
that's too large for immediate mode arithmetic operations, which is
annoying. Hmm.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 18/10/19 5:46 pm, Christophe Leroy wrote:
Le 17/10/2019 à 09:36, Andrew Donnellan a écrit :
On 10/9/19 7:16 pm, Christophe Leroy wrote:
+#if defined(CONFIG_VMAP_STACK) && CONFIG_THREAD_SHIFT < PAGE_SHIFT
+#define THREAD_SHIFT PAGE_SHIFT
+#else
#define T
tell you what this is all about, explain how to install the
kernel, and what to do if something goes wrong.
@@ -406,3 +406,4 @@ If something goes wrong
gdb'ing a non-running kernel currently fails because ``gdb`` (wrongly)
disregards the starting offset for which the kernel is co
st I set up at linux-accelerat...@lists.ozlabs.org but we
haven't really started using...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ic on the card (CFG, TLX) won't be reset, so
-* there's no guarantee that it will be enough.
-*/
- rc = ocxl_config_read_function(dev, &fn->config);
- if (rc)
- return rc;
-
- rc = set_function_device(fn, dev);
- if (rc)
- return rc;
-
- rc = assign_function_actag(fn);
- if (rc)
- return rc;
-
- rc = set_function_pasid(fn);
- if (rc)
- return rc;
-
- rc = ocxl_link_setup(dev, 0, &fn->link);
- if (rc)
- return rc;
-
- rc = ocxl_config_set_TL(dev, fn->config.dvsec_tl_pos);
- if (rc) {
- ocxl_link_release(dev, fn->link);
- return rc;
- }
- return 0;
-}
-
-static void deconfigure_function(struct ocxl_fn *fn)
-{
- struct pci_dev *dev = to_pci_dev(fn->dev.parent);
-
- ocxl_link_release(dev, fn->link);
- pci_disable_device(dev);
-}
-
-static struct ocxl_fn *init_function(struct pci_dev *dev)
-{
- struct ocxl_fn *fn;
- int rc;
-
- fn = alloc_function(dev);
- if (!fn)
- return ERR_PTR(-ENOMEM);
-
- rc = configure_function(fn, dev);
- if (rc) {
- free_function(fn);
- return ERR_PTR(rc);
- }
-
- rc = device_register(&fn->dev);
- if (rc) {
- deconfigure_function(fn);
- put_device(&fn->dev);
- return ERR_PTR(rc);
- }
- return fn;
-}
-
-static void remove_function(struct ocxl_fn *fn)
-{
- deconfigure_function(fn);
- device_unregister(&fn->dev);
-}
-
static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int rc, afu_count = 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
_remove_copro(pe_data->mm);
- mmdrop(pe_data->mm);
+ if (pe_data->mm) {
+ mm_context_remove_copro(pe_data->mm);
+ mmdrop(pe_data->mm);
+ }
kfree_rcu(pe_data, rcu);
}
unlock:
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 28/6/19 10:30 pm, Mauro Carvalho Chehab wrote:
The content of this file is user-faced.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Andrew Donnellan
---
Documentation/{ => userspace-api}/accelerators/ocxl.rst | 2 --
Documentation/userspace-api/index.rst
other architectures, compat_ptr()
does not do anything, but using the new generic_compat_ioctl_ptrarg
helper makes it more correct in theory, and simplifies the code.
Signed-off-by: Arnd Bergmann
For cxl:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel..
ir D'Silva
nitpicks below
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/context.c | 5 +++-
drivers/misc/ocxl/file.c | 53 +++
drivers/misc/ocxl/link.c | 36 ++
drivers/misc/ocxl/ocxl_internal.h |
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
In order for a userspace AFU driver to call the Power9 specific
OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually
make that call.
Signed-off-by: Alastair D'Silva
Looks good to me
Acked-by: A
return rc;
-
- t->thread.tidr = rc;
+ t->thread.tidr = (u16)task_pid_nr(t);
mtspr(SPRN_TIDR, t->thread.tidr);
return 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ags which I
suppose imply what the correct platform is, but really they're just
feature flags?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
th the CPU features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
return -EINVAL;
if (t != current)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
f a similar name.
But I don't feel strongly about this at all, so:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
looks good to me
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
This patch adds a CPU feature bit to show whether the CPU has
the TIDR register available, enabling as_notify/wait in userspace.
Signed-off-by: Alastair D'Silva
Per my previous email:
Reviewed-by: A
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
This looks better.
Acked-by: Andrew Donnellan
---
Documentation/accelerators/ocxl.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/accele
ushed.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
cc-plugins: Add latent_entropy plugin")
Signed-off-by: Andrew Donnellan
---
scripts/Makefile.gcc-plugins | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.gcc-plugins b/scripts/Makefile.gcc-plugins
index 060d2cb..26c67b7 100644
--- a/scripts/Makefile.gc
he typo.
Fixes: 38addce8b600 ("gcc-plugins: Add latent_entropy plugin")
Signed-off-by: Andrew Donnellan
---
I think that we potentially could get rid of some of these disables, but
it's safer to leave it for now.
---
arch/powerpc/kernel/Makefile | 2 +-
1 file changed, 1 insertion
Enable support for GCC plugins on powerpc.
Add an additional version check in gcc-plugins-check to advise users to
upgrade to gcc 5.2+ on powerpc to avoid issues with header files (gcc <=
4.6) or missing copies of rs6000-cpus.def (4.8 to 5.1 on 64-bit targets).
Signed-off-by: Andrew Donnel
p till 6.2, so
yes :)
I think it's best to take this through powerpc#next with an ACK from
Kees/Emese?
That would be fine by me. Please consider the whole series:
Acked-by: Kees Cook
Thanks!
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 06/12/16 17:28, Andrew Donnellan wrote:
Enable support for GCC plugins on powerpc.
Add an additional version check in gcc-plugins-check to advise users to
upgrade to gcc 5.2+ on powerpc to avoid issues with header files (gcc <=
4.6) or missing copies of rs6000-cpus.def (4.8 to 5.1 on 64-
4.6.4/plugin/include/c-common.h
./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-family/c-common.def
Are we sure the version check in gcc-common.h:59 is correct, or is this
just a peculiarity of my particular toolchain?
I need to build another 4.5 toolchain, I'll try to do that this week.
powernv_idle_driver isn't exported, it can be made static. Found by sparse.
Signed-off-by: Andrew Donnellan
---
drivers/cpuidle/cpuidle-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-powernv.c
b/drivers/cpuidle/cpuidle-powernv.c
On 24/11/16 02:27, Geliang Tang wrote:
Drop duplicate header sched.h from native.c.
Signed-off-by: Geliang Tang
Good catch!
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 04/10/16 21:18, Andrew Donnellan wrote:
Greetings,
*
TL;DR
- LCA Kernel Miniconf, Hobart, Australia, {16,17} Jan 2017
- Submissions by 23:59, 21 November (Anywhere on Earth)
- Wanted: anything interesting to kernel hackers! Speakers from
diverse backgrounds
On 19/01/17 21:50, Greg Kurz wrote:
The kernel API does not use anything from this header file.
Signed-off-by: Greg Kurz
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
config PPC has a lot of selects under it. They're not sorted in any
particular order, leading to merge conflicts when adding items at the end.
Sort them alphabetically.
Suggested-by: Michael Ellerman
Signed-off-by: Andrew Donnellan
---
On top of linux-next 20170130
---
arch/powerpc/Kc
ur of which aren't included directly by
api.c.
But I'll take you word for it :)
I did compile test it before giving my Reviewed-by.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 27/01/17 16:52, Andrew Donnellan wrote:
basic-block.h includes tm.h, and I don't believe we can remove that. I'm
not convinced there's a way around this.
Includes via function.h, I should say.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com
ries again.
basic-block.h includes tm.h, and I don't believe we can remove that. I'm
not convinced there's a way around this.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 12/07/16 21:30, weiyj...@163.com wrote:
From: Wei Yongjun
Use for_each_compatible_node() macro instead of open coding it.
Generated by Coccinelle.
Signed-off-by: Wei Yongjun
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1
On 20/07/16 23:38, Julia Lawall wrote:
I don't think that the call should be there at all. The loop only exits
when afu_np is NULL. Furthermore, the loop should not be written as a for
loop, but rather with for_each_child_of_node.
Will send a patch to fix both issues shortly.
--
A
d-off-by: Andrew Donnellan
---
scripts/checkkconfigsymbols.py | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index df643f6..a9eba02 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/sc
cases of redirecting to a
file or piping to another script, without requiring the user to pass
--no-color.
That's a good point - I'll submit a v2 with that.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
1 - 100 of 158 matches
Mail list logo
