[PATCH v2] selftests/futex: Create test for robust list

2024-09-03 Thread André Almeida
Create a test for the robust list mechanism. Signed-off-by: André Almeida --- Changes from v1: - Change futex type from int to _Atomic(unsigned int) - Use old futex(FUTEX_WAIT) instead of the new sys_futex_wait() --- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex

Re: [PATCH RESEND] selftests/futex: Order calls in futex_requeue

2024-09-04 Thread André Almeida
2 not ok 1 futex_requeue simple returned: 0 not ok 2 futex_requeue simple returned: 0 not ok 3 futex_requeue many returned: 0 not ok 4 futex_requeue many returned: 0 Instead, replace the sleep with barriers to make the sequencing explicit. Reviewed-by: André Almeida

[RFC PATCH 00/13] Add futex2 syscalls

2021-02-15 Thread André Almeida
t;simple" futex interface, that doesn't use PI or robust. Do we want to have this complexity at futex2() and if so, should it be part of this patchset or can it be future work? Thanks, André André Almeida (13): futex2: Implement wait and wake functions futex2: Add support fo

[RFC PATCH 01/13] futex2: Implement wait and wake functions

2021-02-15 Thread André Almeida
`timo` argument As per the Y2038 work done in the kernel, new interfaces shouldn't add timeout options known to be buggy. Given that, `timo` should be a 64bit timeout at all platforms, using an absolute timeout value. Signed-off-by: André Almeida --- MAINTAINERS

[RFC PATCH 02/13] futex2: Add support for shared futexes

2021-02-15 Thread André Almeida
r name or type that matches the original data, we only need to care about the bitsize of each component and make both private and shared data fit in the same memory space. Signed-off-by: André Almeida --- fs/inode.c | 1 + include/linux/fs.h | 1

[RFC PATCH 03/13] futex2: Implement vectorized wait

2021-02-15 Thread André Almeida
it (if it’s the first awakened, if it is of the smaller index...). Signed-off-by: André Almeida --- arch/arm/tools/syscall.tbl| 1 + arch/arm64/include/asm/unistd.h | 2 +- arch/x86/entry/syscalls/syscall_32.tbl| 1 + arch/x86/entry/syscalls

[RFC PATCH 04/13] futex2: Implement requeue operation

2021-02-15 Thread André Almeida
de otherwise. Signed-off-by: André Almeida --- The original FUTEX_CMP_REQUEUE interfaces is such as follows: futex(*uaddr1, FUTEX_CMP_REQUEUE, nr_wake, nr_requeue, *uaddr2, cmpval); Given that when this interface was created they was only one type of futex (as opposed to futex2, where there is s

[RFC PATCH 08/13] selftests: futex2: Add timeout test

2021-02-15 Thread André Almeida
Adapt existing futex wait timeout file to test the same mechanism for futex2. futex2 accepts only absolute 64bit timers, but supports both monotonic and realtime clocks. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_timeout.c | 58 --- 1 file changed, 49

[RFC PATCH 06/13] docs: locking: futex2: Add documentation

2021-02-15 Thread André Almeida
Add a new documentation file specifying both userspace API and internal implementation details of futex2 syscalls. Signed-off-by: André Almeida --- Documentation/locking/futex2.rst | 198 +++ Documentation/locking/index.rst | 1 + 2 files changed, 199 insertions

[RFC PATCH 07/13] selftests: futex2: Add wake/wait test

2021-02-15 Thread André Almeida
more tests can evaluate futex2. While 32bit ABIs from glibc aren't yet able to use 64 bit sized time variables, add a temporary workaround that implements the required types and calls the appropriated syscalls, since futex2 doesn't supports 32 bit sized time. Signed-off-by: And

[RFC PATCH 05/13] futex2: Add compatibility entry point for x86_x32 ABI

2021-02-15 Thread André Almeida
New syscalls should use the same entry point for x86_64 and x86_x32 paths. Add a wrapper for x32 calls to use parse functions that assumes 32bit pointers. Signed-off-by: André Almeida --- kernel/futex2.c | 42 +++--- 1 file changed, 35 insertions(+), 7

[RFC PATCH 10/13] selftests: futex2: Add waitv test

2021-02-15 Thread André Almeida
Create a new file to test the waitv mechanism. Test both private and shared futexes. Wake the last futex in the array, and check if the return value from futex_waitv() is the right index. Signed-off-by: André Almeida --- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex

[RFC PATCH 11/13] selftests: futex2: Add requeue test

2021-02-15 Thread André Almeida
Add testing for futex_requeue(). The first test just requeue from one waiter to another one, and wake it. The second performs both wake and requeue, and we check return values to see if the operation woke/requeued the expected number of waiters. Signed-off-by: André Almeida --- .../selftests

[RFC PATCH 12/13] perf bench: Add futex2 benchmark tests

2021-02-15 Thread André Almeida
Add support at the existing futex benchmarking code base to enable futex2 calls. `perf bench` tests can be used not only as a way to measure the performance of implementation, but also as stress testing for the kernel infrastructure. Signed-off-by: André Almeida --- tools/arch/x86/include/asm

[RFC PATCH 09/13] selftests: futex2: Add wouldblock test

2021-02-15 Thread André Almeida
Adapt existing futex wait wouldblock file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_wouldblock.c | 33 --- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional

[RFC PATCH 13/13] kernel: Enable waitpid() for futex2

2021-02-15 Thread André Almeida
will trigger a harmless noop wakeup on the interface that it isn't using. Signed-off-by: André Almeida --- This commit is here for the intend to show what we need to do in order to get a full NPTL working on top of futex2. It should be merged after we talk to glibc folks on the details aroun

Re: [PATCH 00/16] media: vimc: Add support for multiplanar formats

2019-03-15 Thread André Almeida
On 3/15/19 1:43 PM, André Almeida wrote: Hello, This series implements support for multiplane pixel formats at vimc. A lot of changes were required since vimc support for singleplane was "hardcoded". The code has been adapted in order to support both formats. When was possible, the

Re: [RFC PATCH 01/13] futex2: Implement wait and wake functions

2021-02-18 Thread André Almeida
Hi Gabriel, Às 16:59 de 15/02/21, Gabriel Krisman Bertazi escreveu: André Almeida writes: +/** + * struct futexv_head - List of futexes to be waited + * @task:Task to be awaken + * @hint:Was someone on this list awakened? + * @objects: List of futexes + */ +struct futexv_head

Re: [RFC PATCH 06/13] docs: locking: futex2: Add documentation

2021-02-18 Thread André Almeida
Hi Randy, Thanks for the feedback. All suggestions/fixes were applied for next version. Às 15:34 de 16/02/21, Randy Dunlap escreveu: On 2/15/21 7:23 AM, André Almeida wrote: Add a new documentation file specifying both userspace API and internal implementation details of futex2 syscalls

Re: [RFC PATCH 01/13] futex2: Implement wait and wake functions

2021-02-18 Thread André Almeida
Hi Peter, Às 06:02 de 16/02/21, Peter Zijlstra escreveu: On Mon, Feb 15, 2021 at 12:23:52PM -0300, André Almeida wrote: +static int __futex_wait(struct futexv_head *futexv, unsigned int nr_futexes, + struct hrtimer_sleeper *timeout) +{ + int ret; + + while (1

[PATCH 2/2] Documentation: admin-guide: Update kvm/xen config option

2021-01-29 Thread André Almeida
Since commit 9bba03d4473d ("kconfig: remove 'kvmconfig' and 'xenconfig' shorthands") kvm/xen config shortcuts are not available anymore. Update the file to reflect how they should be used, with the full filename. Signed-off-by: André Almeida --- Documentat

[PATCH 1/2] docs: Make syscalls' helpers naming consistent

2021-01-29 Thread André Almeida
on to reflect this. Cc: Dominik Brodowski Fixes: 819671ff849b ("syscalls: define and explain goal to not call syscalls in the kernel") Signed-off-by: André Almeida --- Documentation/process/adding-syscalls.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Docume

Re: [RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()"

2021-03-24 Thread André Almeida
Hi Matthew, Às 17:15 de 23/03/21, Matthew Wilcox escreveu: On Tue, Mar 23, 2021 at 04:59:38PM -0300, André Almeida wrote: This reverts commit 794c43f716845e2d48ce195ed5c4179a4e05ce5f. For implementing casefolding support at tmpfs, it needs to set dentry operations at superblock level, given

Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups

2021-03-24 Thread André Almeida
Às 17:18 de 23/03/21, Gabriel Krisman Bertazi escreveu: André Almeida writes: opt = fs_parse(fc, shmem_fs_parameters, param, &result); if (opt < 0) @@ -3468,6 +3519,23 @@ static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *param)

Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups

2021-03-24 Thread André Almeida
Hi Al Viro, Às 20:19 de 23/03/21, Al Viro escreveu: On Tue, Mar 23, 2021 at 04:59:39PM -0300, André Almeida wrote: * dcache handling: For now, negative lookups are not inserted in the dcache, since they would need to be invalidated anyway, because we can't trust missing file dentries.

Re: [RFC PATCH 4/4] docs: tmpfs: Add casefold options

2021-03-24 Thread André Almeida
Hi Gabriel, Às 19:19 de 23/03/21, Gabriel Krisman Bertazi escreveu: André Almeida writes: Document mounting options to enable casefold support in tmpfs. Signed-off-by: André Almeida --- Documentation/filesystems/tmpfs.rst | 26 ++ 1 file changed, 26 insertions

Re: [RFC PATCH 4/4] docs: tmpfs: Add casefold options

2021-03-25 Thread André Almeida
Às 18:58 de 23/03/21, Randy Dunlap escreveu: Hi-- On 3/23/21 12:59 PM, André Almeida wrote: Document mounting options to enable casefold support in tmpfs. Signed-off-by: André Almeida --- Documentation/filesystems/tmpfs.rst | 26 ++ 1 file changed, 26 insertions

[RFC PATCH 0/4] mm: shmem: Add case-insensitive support for tmpfs

2021-03-23 Thread André Almeida
setup! Casefold support in tmpfs is disabled by default. Thanks, André André Almeida (4): Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()" mm: shmem: Support case-insensitive file name lookups mm: shmem: Add IOCTL support for tmpfs docs: tmpfs

[RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()"

2021-03-23 Thread André Almeida
e can access those exported function from tmpfs code. Signed-off-by: André Almeida --- fs/libfs.c | 8 +--- include/linux/fs.h | 5 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/fs/libfs.c b/fs/libfs.c index e2de5401abca..d1d06494463a 100644 --- a/fs/libfs.c +++

[RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups

2021-03-23 Thread André Almeida
uments telling the filesystem code and userspace tools to enforce the encoding. When that optional flag is set, any attempt to create a file name using an invalid UTF-8 sequence will fail and return an error to userspace. Signed-off-by: André Almeida --- include/linux/shmem_fs.h | 1 + mm/shmem.c

[RFC PATCH 4/4] docs: tmpfs: Add casefold options

2021-03-23 Thread André Almeida
Document mounting options to enable casefold support in tmpfs. Signed-off-by: André Almeida --- Documentation/filesystems/tmpfs.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/filesystems/tmpfs.rst b/Documentation/filesystems/tmpfs.rst index

[RFC PATCH 3/4] mm: shmem: Add IOCTL support for tmpfs

2021-03-23 Thread André Almeida
Implement IOCTL operations for files to set/get file flags. Implement the only supported flag by now, that is S_CASEFOLD. Signed-off-by: André Almeida --- include/linux/shmem_fs.h | 4 ++ mm/shmem.c | 84 +++- 2 files changed, 87 insertions

Re: [RFC PATCH v2 00/13] Add futex2 syscall

2021-03-04 Thread André Almeida
Hi Peter, Às 02:44 de 04/03/21, Peter Oskolkov escreveu: On Wed, Mar 3, 2021 at 5:22 PM André Almeida wrote: Hi, This patch series introduces the futex2 syscalls. * FAQ ** "And what's about FUTEX_64?" By supporting 64 bit futexes, the kernel structure for futex would

Re: [RFC PATCH v2 00/13] Add futex2 syscall

2021-03-04 Thread André Almeida
Hi Ted, Às 12:01 de 04/03/21, Theodore Ts'o escreveu: On Wed, Mar 03, 2021 at 09:42:06PM -0300, André Almeida wrote: ** Performance - For comparing futex() and futex2() performance, I used the artificial benchmarks implemented at perf (wake, wake-parallel, hash and requeue)

Re: [PATCH 1/3] fs/dcache: Add d_clear_dir_neg_dentries()

2021-03-30 Thread André Almeida
Hi Eric, Às 22:48 de 29/03/21, Eric Biggers escreveu: On Sun, Mar 28, 2021 at 11:43:54AM -0300, André Almeida wrote: For directories with negative dentries that are becoming case-insensitive dirs, we need to remove all those negative dentries, otherwise they will become dangling dentries

[RFC PATCH v2 00/13] Add futex2 syscall

2021-03-03 Thread André Almeida
ropped _carefull from linked list function calls - Fixed typos on docs patch - uAPI flags are now added as features are introduced, instead of all flags in patch 1 - Removed struct futex_single_waiter in favor of an anon struct v1: https://lore.kernel.org/lkml/20210215152404.250281-1-and

[RFC PATCH v2 01/13] futex2: Implement wait and wake functions

2021-03-03 Thread André Almeida
`timo` argument As per the Y2038 work done in the kernel, new interfaces shouldn't add timeout options known to be buggy. Given that, `timo` should be a 64bit timeout at all platforms, using an absolute timeout value. Signed-off-by: André Almeida --- MAINTAINERS

[RFC PATCH v2 03/13] futex2: Implement vectorized wait

2021-03-03 Thread André Almeida
it (if it’s the first awakened, if it is of the smaller index...). Signed-off-by: André Almeida --- arch/arm/tools/syscall.tbl| 1 + arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/asm/unistd32.h | 2 + arch/x86/entry/syscalls

[RFC PATCH v2 04/13] futex2: Implement requeue operation

2021-03-03 Thread André Almeida
de otherwise. Signed-off-by: André Almeida --- The original FUTEX_CMP_REQUEUE interfaces is such as follows: futex(*uaddr1, FUTEX_CMP_REQUEUE, nr_wake, nr_requeue, *uaddr2, cmpval); Given that when this interface was created they was only one type of futex (as opposed to futex2, where there is s

[RFC PATCH v2 06/13] docs: locking: futex2: Add documentation

2021-03-03 Thread André Almeida
Add a new documentation file specifying both userspace API and internal implementation details of futex2 syscalls. Signed-off-by: André Almeida --- Documentation/locking/futex2.rst | 198 +++ Documentation/locking/index.rst | 1 + 2 files changed, 199 insertions

[RFC PATCH v2 08/13] selftests: futex2: Add timeout test

2021-03-03 Thread André Almeida
Adapt existing futex wait timeout file to test the same mechanism for futex2. futex2 accepts only absolute 64bit timers, but supports both monotonic and realtime clocks. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_timeout.c | 58 --- 1 file changed, 49

[RFC PATCH v2 07/13] selftests: futex2: Add wake/wait test

2021-03-03 Thread André Almeida
more tests can evaluate futex2. While 32bit ABIs from glibc aren't yet able to use 64 bit sized time variables, add a temporary workaround that implements the required types and calls the appropriated syscalls, since futex2 doesn't supports 32 bit sized time. Signed-off-by: And

[RFC PATCH v2 02/13] futex2: Add support for shared futexes

2021-03-03 Thread André Almeida
r name or type that matches the original data, we only need to care about the bitsize of each component and make both private and shared data fit in the same memory space. Signed-off-by: André Almeida --- fs/inode.c | 1 + include/linux/fs.h | 1 + include/uapi/linux/fut

[RFC PATCH v2 10/13] selftests: futex2: Add waitv test

2021-03-03 Thread André Almeida
Create a new file to test the waitv mechanism. Test both private and shared futexes. Wake the last futex in the array, and check if the return value from futex_waitv() is the right index. Signed-off-by: André Almeida --- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex

[RFC PATCH v2 09/13] selftests: futex2: Add wouldblock test

2021-03-03 Thread André Almeida
Adapt existing futex wait wouldblock file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_wouldblock.c | 33 --- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional

[RFC PATCH v2 05/13] futex2: Add compatibility entry point for x86_x32 ABI

2021-03-03 Thread André Almeida
New syscalls should use the same entry point for x86_64 and x86_x32 paths. Add a wrapper for x32 calls to use parse functions that assumes 32bit pointers. Signed-off-by: André Almeida --- kernel/futex2.c | 42 +++--- 1 file changed, 35 insertions(+), 7

[RFC PATCH v2 11/13] selftests: futex2: Add requeue test

2021-03-03 Thread André Almeida
Add testing for futex_requeue(). The first test just requeue from one waiter to another one, and wake it. The second performs both wake and requeue, and we check return values to see if the operation woke/requeued the expected number of waiters. Signed-off-by: André Almeida --- .../selftests

[RFC PATCH v2 12/13] perf bench: Add futex2 benchmark tests

2021-03-03 Thread André Almeida
Add support at the existing futex benchmarking code base to enable futex2 calls. `perf bench` tests can be used not only as a way to measure the performance of implementation, but also as stress testing for the kernel infrastructure. Signed-off-by: André Almeida --- tools/arch/x86/include/asm

[RFC PATCH v2 13/13] kernel: Enable waitpid() for futex2

2021-03-03 Thread André Almeida
will trigger a harmless noop wakeup on the interface that it isn't using. Signed-off-by: André Almeida --- This commit is here for the intend to show what we need to do in order to get a full NPTL working on top of futex2. It should be merged after we talk to glibc folks on the details aroun

[PATCH 0/3] fs: Fix dangling dentries on casefold directories

2021-03-28 Thread André Almeida
210323195941.69720-1-andrealm...@collabora.com/T/#m3265579197095b792ee8b8e8b7f84a58c25c456b André Almeida (3): fs/dcache: Add d_clear_dir_neg_dentries() ext4: Prevent dangling dentries on casefold directories f2fs: Prevent dangling dentries on casefold directories fs/dcache.c| 27 +

[PATCH 1/3] fs/dcache: Add d_clear_dir_neg_dentries()

2021-03-28 Thread André Almeida
be negative. Create a function to remove all negative dentries from a directory, to be used as explained above by filesystems that support case-insensitive lookups. Signed-off-by: André Almeida --- fs/dcache.c| 27 +++ include/linux/dcache.h | 1 + 2 files

[PATCH 2/3] ext4: Prevent dangling dentries on casefold directories

2021-03-28 Thread André Almeida
t;) Signed-off-by: André Almeida --- fs/ext4/ioctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index a2cf35066f46..0eede4c93c22 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -381,6 +381,9 @@ static int ext4_ioctl_setflags(struct in

[PATCH 3/3] f2fs: Prevent dangling dentries on casefold directories

2021-03-28 Thread André Almeida
t;) Signed-off-by: André Almeida --- fs/f2fs/file.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index d26ff2ae3f5e..616b7eb43795 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1826,6 +1826,10 @@ static int f2fs_setflags_common(struct inode *

Re: [PATCH 1/3] fs/dcache: Add d_clear_dir_neg_dentries()

2021-03-28 Thread André Almeida
Às 12:07 de 28/03/21, Matthew Wilcox escreveu: On Sun, Mar 28, 2021 at 11:43:54AM -0300, André Almeida wrote: +/** + * d_clear_dir_neg_dentries - Remove negative dentries in an inode + * @dir: Directory to clear negative dentries + * + * For directories with negative dentries that are becoming

Re: [PATCH] media: vimc: Implement debayer control for mean window size

2019-09-03 Thread André Almeida
Hello Arthur and Laís, Thanks for your patch! On 9/1/19 4:40 PM, Arthur Moraes do Lago wrote: > Add mean window size parameter for debayer filter as a control in > vimc-debayer. > > vimc-debayer was patched to allow changing mean windows parameter > of the filter without needing to reload the dr

Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 6:54 PM, Minwoo Im wrote: > Hi André, > >> -/* >> +/** >> + * blk_mq_rq_from_pdu - cast a PDU to a request >> + * @pdu: the PDU (protocol unit request) to be casted > > It makes sense, but it looks like PDU stands for protocol unit request. > Could we have it "PDU(Protocol Data Unit)"

Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 7:01 PM, Bart Van Assche wrote: > On 9/30/19 12:48 PM, André Almeida wrote: >> Insert documentation for structs, enums and functions at header file. >> Format existing and new comments at struct blk_mq_ops as >> kernel-doc comments. > > Hi André, > &g

Re: [Lkcamp] [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static

2019-10-07 Thread André Almeida
Hi Helen, On 10/5/19 10:36 PM, Helen Koike wrote: > Hi Carlos, > > On 10/5/19 9:28 PM, kbuild test robot wrote: >> Fixes: 4d124d159dff ("media: vimc: get pixformat info from v4l2_format_info >> to avoid code repetition") > Usually, the Fixes flag is used for something that is already accepted in

[PATCH v3 1/1] blk-mq: fill header with kernel-doc

2019-10-21 Thread André Almeida
Insert documentation for structs, enums and functions at header file. Format existing and new comments at struct blk_mq_ops as kernel-doc comments. Signed-off-by: André Almeida --- Hello, This patch is an effort to enhance the documentation of the multiqueue API. To check if the comments are

Re: [PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-12 Thread André Almeida
Hello, On 7/10/19 4:33 AM, Hans Verkuil wrote: > On 7/10/19 12:19 AM, Helen Koike wrote: >> Hi André, >> >> Thanks for the patches. >> >> On 7/2/19 12:47 PM, André Almeida wrote: >>> Hello, >>> >>> This patch adds a V4L2 output device

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-12 Thread André Almeida
Hi Shuah, On 8/12/19 11:08 AM, Shuah Khan wrote: > On 8/9/19 9:51 PM, Helen Koike wrote: >> Hi Andre, >> >> Thanks for testing this. >> >> On 8/9/19 9:24 PM, André Almeida wrote: >>> On 8/9/19 9:17 PM, Shuah Khan wrote: >>>> Hi Andre, >>

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
Hello Shuah, Thanks for the patch, I did some comments below. On 8/9/19 6:45 PM, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity maki

Re: [PATCH 0/3] Collapse vimc into single monolithic driver

2019-08-09 Thread André Almeida
On 8/9/19 9:17 PM, Shuah Khan wrote: > Hi Andre, > > On 8/9/19 5:52 PM, André Almeida wrote: >> Hello Shuah, >> >> Thanks for the patch, I did some comments below. >> >> On 8/9/19 6:45 PM, Shuah Khan wrote: >>> vimc uses Component API to split the

Re: [PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-30 Thread André Almeida
On 7/13/19 7:03 AM, Hans Verkuil wrote: > On 7/12/19 5:38 PM, André Almeida wrote: >> Hello, >> >> On 7/10/19 4:33 AM, Hans Verkuil wrote: >>> On 7/10/19 12:19 AM, Helen Koike wrote: >>>> Hi André, >>>> >>>> Thanks for the patch

Re: [PATCH v3 1/2] media: vimc: stream: add missing function documentation

2019-06-22 Thread André Almeida
Hello Mauro, On 6/21/19 6:17 PM, Mauro Carvalho Chehab wrote: > Em Mon, 17 Jun 2019 10:32:20 -0300 > André Almeida escreveu: > >> Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making >> the vimc-stream totally documented. > I'm applying it right n

[PATCH 4/5] media: vimc.rst: Add a proper alt attribute to vimc.dot

2019-06-23 Thread André Almeida
Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst index 4628b12d417f..bece85867424 100644 --- a/Documentation/media/v4l-d

[PATCH 1/5] media: vimc: stream: remove obsolete function doc

2019-06-23 Thread André Almeida
As a more complete version of vimc_streamer_s_streamer comment was added at "media: vimc: stream: add missing function documentation" commit in .c file, remove the old documentation from .h file. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.h | 8 --

[PATCH 5/5] media: vimc.rst: add vimc-streamer source documentation

2019-06-23 Thread André Almeida
Since vimc-streamer.{c, h} are fully documented and conforming with the kernel-doc syntax, add those files to vimc.rst Signed-off-by: André Almeida Suggested-by: Mauro Carvalho Chehab --- Documentation/media/v4l-drivers/vimc.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-23 Thread André Almeida
Format the current existing comments as kernel-doc comments, to be reused at kernel documention. Add opening marks (/**) and return values. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c | 38 + 1 file changed, 24 insertions(+), 14 deletions

[PATCH 2/5] media: vimc: stream: fix style of argument description

2019-06-23 Thread André Almeida
As in "Function parameters" at doc-guide/kernel-doc.rst, "the continuation of the description should start at the same column as the previous line". Make the @producer_pixfmt comply with that. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.h | 1

Re: [PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-23 Thread André Almeida
On 6/23/19 1:40 PM, André Almeida wrote: > Format the current existing comments as kernel-doc comments, to be > reused at kernel documention. Add opening marks (/**) and return values. > > Signed-off-by: André Almeida > --- > drivers/media/platform/vimc/vi

Re: [PATCH 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-24 Thread André Almeida
On 6/24/19 6:40 AM, Mauro Carvalho Chehab wrote: > Em Sun, 23 Jun 2019 18:27:22 -0300 > André Almeida escreveu: > >> On 6/23/19 1:40 PM, André Almeida wrote: >>> - * Calls s_stream to enable stream in all entities of the pipeline. >>> + * Calls ``vimc_streamer_s

[PATCH v2 1/5] media: vimc: stream: remove obsolete function doc

2019-06-24 Thread André Almeida
As a more complete version of vimc_streamer_s_streamer comment was added at "media: vimc: stream: add missing function documentation" commit in .c file, remove the old documentation from .h file. Signed-off-by: André Almeida --- Changes in v2: none drivers/media/platform/vimc/vimc-

[PATCH v2 2/5] media: vimc: stream: fix style of argument description

2019-06-24 Thread André Almeida
As in "Function parameters" at doc-guide/kernel-doc.rst, "the continuation of the description should start at the same column as the previous line". Make the @producer_pixfmt comply with that. Signed-off-by: André Almeida --- Changes in v2: none drivers/media/platform/

[PATCH v2 5/5] media: vimc.rst: add vimc-streamer source documentation

2019-06-24 Thread André Almeida
Since vimc-streamer.{c, h} are fully documented and conforming with the kernel-doc syntax, add those files to vimc.rst Signed-off-by: André Almeida Suggested-by: Mauro Carvalho Chehab --- Changes in v2: none Documentation/media/v4l-drivers/vimc.rst | 11 +++ 1 file changed, 11

[PATCH v2 4/5] media: vimc.rst: Add a proper alt attribute to vimc.dot

2019-06-24 Thread André Almeida
Signed-off-by: André Almeida --- Changes in v2: none Documentation/media/v4l-drivers/vimc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst index 4628b12d417f..bece85867424 100644 --- a/Docu

[PATCH v2 3/5] media: vimc: stream: format comments as kernel-doc

2019-06-24 Thread André Almeida
Format the current existing comments as kernel-doc comments, to be reused at kernel documention. Add opening marks (/**) and return values. Signed-off-by: André Almeida --- Changes in v2: replace ``vimc_streamer_s_stream`` for vimc_streamer_s_stream(). drivers/media/platform/vimc/vimc

[PATCH v3 1/2] media: vimc: stream: add missing function documentation

2019-06-17 Thread André Almeida
Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making the vimc-stream totally documented. Signed-off-by: André Almeida --- Changes in v3: replace "streaming" by "stream" at vimc_streamer_thread(). Changes in v2: fix typos drivers/media/platform/vimc/

[PATCH v3 2/2] media: docs: create vimc documentation

2019-06-17 Thread André Almeida
Create vimc documentation file to explain it basics features, it's topology, how to configure it and to document vimc's subdevices. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Changes in v3: none Changes in v2: - Fix typos - Make clear what does means sc

[PATCH] media: vimc: cap: check v4l2_fill_pixfmt return value

2019-06-17 Thread André Almeida
error value if vimc_cap_try_fmt_vid_cap() has failed. Signed-off-by: André Almeida Suggested-by: Helen Koike --- Hello, This commit was suggest by Helen at "[v3,05/14] media: vimc: cap: refactor singleplanar as a subset of multiplanar" drivers/media/platform/vimc/vimc-capture.c | 5 +++

[PATCH 0/7] media: vimc: Add a V4L2 output device

2019-07-02 Thread André Almeida
0 ! videoconvert ! ximagesink 2.b qv4l2 (requires v4l-utils): Open the output device: $ qv4l2 -d2 Open the capture device: $ qv4l2 -d3 Start the streaming at both, at any order. You can change the frame content at "Test Pattern Generator" -> "Test Pattern" on the output.

[PATCH 1/7] media: vimc: Create video module

2019-07-02 Thread André Almeida
a video output device in vimc, as it will make easier for code reuse and simplicity. Signed-off-by: André Almeida --- drivers/media/platform/vimc/Makefile | 2 +- drivers/media/platform/vimc/vimc-capture.c | 341 ++--- drivers/media/platform/vimc/vimc-video.c | 264

[PATCH 2/7] media: vimc: video: Add write file operation

2019-07-02 Thread André Almeida
Add write on the list of vb2 file operations. This is required to create a V4L2 output device. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-video.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vimc/vimc-video.h b/drivers/media/platform/vimc

[PATCH 3/7] media: vimc: Create a V4L2 output device

2019-07-02 Thread André Almeida
ces in the pipeline. Add a vb2 buffer validate function. This is required to create a V4L2 output device. Signed-off-by: André Almeida --- drivers/media/platform/vimc/Makefile| 4 +- drivers/media/platform/vimc/vimc-common.h | 5 +- drivers/media/platform/vimc/vimc-debayer.c | 11 +- dri

[PATCH 4/7] media: vimc: Send null buffer through the pipeline

2019-07-02 Thread André Almeida
Send a NULL buffer through the video pipeline. If the Capture device gets a NULL buffer, it uses it default fallback frame. Make the capture device behave more like real devices when there's no frame to show. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-capture.c

[PATCH 7/7] media: vimc.rst: Add output device

2019-07-02 Thread André Almeida
Add information about the output device. Remove wrong information about what the capture exposes. Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.rst | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/media/v4l-drivers/vimc.rst

[PATCH 6/7] media: vimc.dot: Update default topology diagram

2019-07-02 Thread André Almeida
Update the default topology diagram to reflect the current state of the driver. Signed-off-by: André Almeida --- Documentation/media/v4l-drivers/vimc.dot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/media/v4l-drivers/vimc.dot b/Documentation/media/v4l

[PATCH 5/7] media: vimc: core: Add output device on the pipeline

2019-07-02 Thread André Almeida
Add the output video device on the hardcoded pipeline. Change the link to it be enabled by default. Signed-off-by: André Almeida --- drivers/media/platform/vimc/vimc-core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vimc/vimc-core.c b

Re: [PATCH v7 02/14] media: doc: add document for rkisp1 meta buffer format

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:08 PM, Helen Koike wrote: > From: Jacob Chen > > This commit add document for rkisp1 meta buffer format > > Signed-off-by: Jacob Chen > Acked-by: Hans Verkuil > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > - s/correspond/corresponding

Re: [PATCH v7 10/14] dt-bindings: Document the Rockchip ISP1 bindings

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip ISP1 > > Signed-off-by: Jacob Chen > Reviewed-by: Rob Herring > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > - update document with new design

Re: [PATCH v7 11/14] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip MIPI D-PHY RX > > Signed-off-by: Jacob Chen > Reviewed-by: Rob Herring > [update for upstream] > Signed-off-by: Helen Koike > > --- > > Changes in v7: > - updated doc with new d

Re: [PATCH v7 08/14] media: rkisp1: add capture device driver

2019-07-04 Thread André Almeida
Hello Helen, On 7/3/19 4:09 PM, Helen Koike wrote: > From: Jacob Chen > > This is the capture device interface driver that provides the v4l2 > user interface. Frames can be received from ISP1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed

Re: [PATCH 2/2] Revert "media: vimc: propagate pixel format in the stream"

2019-07-09 Thread André Almeida
uot;Revert...", not sure if this is relevant. I've applied this changes at media-master and `test-media vimc` (from v4l-utils) got 0 errors and 0 warnings. I've also tested with qv4l2, and the streaming went as expected for all capture devices. Tested-by:  André Almeida

Re: [PATCH 5/8] media: vimc: stream: cleanup frame field from struct vimc_stream

2019-03-07 Thread André Almeida
and with v4l2-compliance --streaming=5 -d /dev/videoX and no regressions where found. On 3/6/19 7:42 PM, Helen Koike wrote: There is no need to have the frame field in the vimc_stream struct. Signed-off-by: Helen Koike Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-strea

Re: [PATCH 7/8] media: vimc: stream: init/terminate the first entity

2019-03-07 Thread André Almeida
=5 -d /dev/videoX and no regressions where found. Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-streamer.c | 25 - 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc

Re: [PATCH 8/8] media: vimc: propagate pixel format in the stream

2019-03-07 Thread André Almeida
ideoX and no regressions where found. Tested-by: André Almeida --- drivers/media/platform/vimc/vimc-capture.c | 76 +++-- drivers/media/platform/vimc/vimc-common.c | 307 drivers/media/platform/vimc/vimc-common.h | 13 + drivers/media/platform/vimc/vimc-deba

[PATCH 0/4] futex: Minor code improvements

2020-05-27 Thread André Almeida
Hello, This series aims to make some small code improvements that I found in futex.c, removing some lines and trying to make the code easier to read and understand. All commits tested with futex tests from kselftest. André Almeida (4): futex: Remove put_futex_key() futex: Remove needless

[PATCH 1/4] futex: Remove put_futex_key()

2020-05-27 Thread André Almeida
Since 4b39f99c ("futex: Remove {get,drop}_futex_key_refs()"), function put_futex_key() is empty. Remove all references for this function and redundant labels. Signed-off-by: André Almeida --- kernel/futex.c | 61 ++ 1 file changed, 12

[PATCH 3/4] futex: Remove unused or redundant includes

2020-05-27 Thread André Almeida
ed includes. Signed-off-by: André Almeida --- To test this code, I compiled with different configurations (x86_64, i386, with x32 ABI supported enabled/disabled), and ran futex selftests. --- kernel/futex.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/kernel/futex.c b/

[PATCH 4/4] futex: Consistently use fshared as boolean

2020-05-27 Thread André Almeida
Since fshared is meant to true/false values, declare it as bool. If the code ever reaches the code beneath again label, we are sure that the futex is shared, so we can use the true value instead of the variable. Signed-off-by: André Almeida --- kernel/futex.c | 9 + 1 file changed, 5

  1   2   >