LDO12 on exynos7 supply power to VDDQ_UFS20_RESET,
in case this regulator is OFF, UFS host controller
can not send command to UFS device. To keep this supply
ON, set regulator-always-on property for this ldo.
Signed-off-by: Alim Akhtar
---
arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1
LDO12 on exynos7 supply power to VDDQ_UFS20_RESET,
in case this regulator is OFF, UFS host controller
can not send command to UFS device. To keep this supply
ON, set regulator-always-on property for this ldo.
Signed-off-by: Alim Akhtar
---
arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1
node on exynos7-espresso")
Signed-off-by: Alim Akhtar
---
-
arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index 790f12ca8981..bb8695003
es. change it to be u8.
>
> Signed-off-by: Bean Huo
> ---
Reviewed-by: Alim Akhtar
Booted and tested on exynos7 board, tested basic read/write, so
Tested-by: Alim Akhtar
Thanks,
> drivers/scsi/ufs/ufshcd.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Hi Krzysztof,
> -Original Message-
> From: Krzysztof Kozlowski
> Sent: 05 July 2020 23:53
> To: Alim Akhtar
> Cc: devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> samsung-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> robh...@ker
@vger.kernel.org
> Cc: Bartlomiej Zolnierkiewicz ; Sylwester
Nawrocki
> ; Alim Akhtar ; Chanwoo
> Choi ; Pankaj Dubey
>
> Subject: [PATCH v3] ARM: dts: exynos: Remove DMA controller bus node name
> to fix dtschema warnings
>
> There is no need to keep DMA controller nodes und
Hi Vinod
Gentle Reminder !!
On Fri, Jul 3, 2020 at 11:02 PM Alim Akhtar wrote:
>
> This patch introduces Samsung UFS PHY driver. This driver
> supports to deal with phy calibration and power control
> according to UFS host driver's behavior.
>
> [Robot: -Wmissing-pro
Hi Rob
Can you please take this via your tree?
On Thu, Jun 25, 2020 at 6:20 AM Alim Akhtar wrote:
>
> This patch adds DT bindings for Samsung ufs hci
>
> Reviewed-by: Rob Herring
> Signed-off-by: Alim Akhtar
> ---
>
> Hi Rob
> This is just a rebase on your's dt
ngwon Jeon
Signed-off-by: Alim Akhtar
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Tested-by: Paweł Chmiel
---
- Changes V12 -> V13
* Addressed more review comments from Vinod [1]
[1] https://lkml.org/lkml/2020/7/13/99
- Changes V11 -> V12
* Fixed kernel test robot warnings
- Changes
This patch documents Samsung UFS PHY device tree bindings
Reviewed-by: Rob Herring
Signed-off-by: Alim Akhtar
Tested-by: Paweł Chmiel
---
.../bindings/phy/samsung,ufs-phy.yaml | 75 +++
1 file changed, 75 insertions(+)
create mode 100644 Documentation/devicetree
y@mediatek.com; c...@codeaurora.org;
> tomas.wink...@intel.com; ALIM AKHTAR
> Cc: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; Sang-yoon Oh
> ; Sung-Jun Park
> ; yongmyung lee
> ; Jinyoung CHOI ;
> Adel Choi ; BoRam Shin
>
> Subject: RE: [PATCH v6 0/5] sc
[=y] && SCSI [=y] &&
SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
Fix it by removing PHY_SAMSUNG_UFS dependency.
Reported-by: Randy Dunlap
Signed-off-by: Alim Akhtar
Acked-by: Randy Dunlap
---
* Changes since v1
- rebased on 5.10-scsi-queue
- Added Randy's Acke
Hi Randy and Martin,
> -Original Message-
> From: Martin K. Petersen
> Sent: 10 September 2020 07:58
> To: Randy Dunlap
> Cc: Alim Akhtar ; 'Stephen Rothwell'
> ; 'Linux Next Mailing List' n...@vger.kernel.org>; 'Linux Kernel Maili
> -Original Message-
> From: Avri Altman
> Sent: 30 June 2020 12:09
> To: daejun7.p...@samsung.com; Bean Huo ;
> j...@linux.ibm.com; martin.peter...@oracle.com; asuto...@codeaurora.org;
> stanley@mediatek.com; c...@codeaurora.org; bvanass...@acm.org;
> tomas.wi
cd_rsp_ptr->qr.opcode == UPIU_QUERY_OPCODE_READ_DESC) {
> + if (hba->dev_cmd.query.descriptor &&
> + lrbp->ucd_rsp_ptr->qr.opcode == UPIU_QUERY_OPCODE_READ_DESC) {
> u8 *descp = (u8 *)lrbp->ucd_rsp_ptr +
> GENERAL_
On Wed, Jun 17, 2020 at 12:27 PM Avri Altman wrote:
>
> >
> > Hi, Bean
> > >
> > > On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote:
> > > > +void ufsf_scan_features(struct ufs_hba *hba)
> > > > +{
> > > > + int ret;
> > > > +
> > > > + init_waitqueue_head(&hba->ufsf.sdev_wait);
>
On Wed, Jun 17, 2020 at 2:19 PM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in a dev_warn message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Thanks Colin,
Reviewed-by: Alim Akhtar
> drivers/scsi/ufs/ufs-exynos.c | 2 +-
> 1 file
Hi Bean,
On Wed, Jun 17, 2020 at 3:12 PM Bean Huo wrote:
>
> > > HPB1.0 isn't part of ufs3.1, but published only later.
> > > Allowing earlier versions will required to quirk the descriptor
> > > sizes.
> > > I see Bean's point here, but I vote for adding it in a single
> > > quirk, when the time
ba"
> isn't NULL and the check can just be removed.
>
> Signed-off-by: Dan Carpenter
> ---
Please add Fixes: tag
With that
Acked-by: Alim Akhtar
Thanks!
> drivers/scsi/ufs/ufs-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Hi Dan,
> -Original Message-
> From: Dan Carpenter
> On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote:
> > Hi Dan
> >
> > > -Original Message-
> > > The "head" pointer can't be NULL because it points to an address
Hi Kishon,
> -Original Message-
> From: Alim Akhtar
> Sent: 11 June 2020 20:49
> To: 'Kishon Vijay Abraham I' ; 'Martin K. Petersen'
> > >>
> > >> Applied [1,2,3,4,5,9] to 5.9/scsi-queue. The series won't show up
> > >
ned reference to
`ufshcd_pltfrm_runtime_idle'
Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos
SoCs")
Reported-by: kernel test robot
Signed-off-by: Alim Akhtar
---
drivers/scsi/ufs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
ger.kernel.org; linux-kernel@vger.kernel.org;
> alim.akh...@samsung.com; Tamseel Shams
> Subject: [PATCH] serial: samsung: fix spelling mistake
>
> There is a spelling mistake in a comment. Fix it.
>
> Signed-off-by: Tamseel Shams
> ---
Reviewed-by: Alim Akhtar
> driv
HI Manivannan
On Thu, Jun 4, 2020 at 12:08 PM Manivannan Sadhasivam
wrote:
>
> UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> adding it to the list of supported versions.
>
> I don't have the exact information of the additional registers supported
> in version 3.0. Henc
Hi Jose
On Thu, Apr 30, 2020 at 1:44 PM Jose Abreu wrote:
>
> From: Bean Huo (beanhuo)
> Date: Apr/29/2020, 13:59:08 (UTC+00:00)
> > > Probably. I think we can leave them or change the dev_err to a dev_warn.
> > > This way we have logs in case someone is using a non-supported version.
> > >
> >
+ seunguk.shin (who is one of the original author of the HPB, in case he has
some more improvement inputs)
Hi Bean,
I second Avri input on splitting this patch series into logical smaller
patches, that will helps reviewers.
Also if you can add support to build HPB as kernel module that will be u
Patch: 2/2 was not applying cleanly on 4.12-rc1. Sorry if I am missing
any dependent patches.
Anyway with a minor conflict fix for 4.12-rc1, I am able to test this
series on exynos7 espresso board.
Looks good to me.
Feel free to add
Reviewed-by: Alim Akhtar
As this works on exynos7, tested SD/eMMC
Hi Bart,
Thanks for your review.
On 08/28/2017 09:15 PM, Bart Van Assche wrote:
> On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote:
>> This entire file uses UFS_BIT macro for bits definition, expect for few
>> places. This patch convert those defines to use UFS_BIT macro to be
This entire file uses UFS_BIT macro for bits definition, expect for few
places. This patch convert those defines to use UFS_BIT macro to be aligned
with reset of the file.
Signed-off-by: Alim Akhtar
---
drivers/scsi/ufs/ufshci.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Hi,
Ping!!!
Should I drop this patch and send another one which removes UFS_BIT() macro?
On Tue, Aug 29, 2017 at 4:35 PM, Alim Akhtar wrote:
> Hi Bart,
> Thanks for your review.
>
> On 08/28/2017 09:15 PM, Bart Van Assche wrote:
>> On Mon, 2017-08-28 at 17:49 +0530, Alim Akht
Since we have coverted all the user of UFS_BIT() macro
with the actual bit position, let remove unused UFS_BIT()macro.
Signed-off-by: Alim Akhtar
---
drivers/scsi/ufs/ufshci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index 5a60a8f
Assche
Signed-off-by: Alim Akhtar
---
This patch is only complied tested, appreciate testing on actual h/w.
Please see https://lkml.org/lkml/2017/8/28/786 discussion.
drivers/scsi/ufs/ufshcd.h | 14 +-
drivers/scsi/ufs/ufshci.h | 69 ---
2
Use actaul bit position instead of UFS_BIT() macro. This
patch also changes bit-17 to meaningful #define.
This change is as per discussion here [1]
[1] -> https://lkml.org/lkml/2017/8/28/786
Signed-off-by: Alim Akhtar
Cc: Subhash Jadavani
---
This patch is only complied tested, appreci
Hi Martin,
On 09/26/2017 01:01 AM, Martin K. Petersen wrote:
>
> Alim,
>
>> Should I drop this patch and send another one which removes UFS_BIT()
>> macro?
>
> I fail to see the point of UFS_BIT(). So yes.
>
> Please make sure to CC: Subhash on ufs changes.
>
Thanks for looking into this patc
Hi Bart,
On 10/02/2017 10:11 PM, Bart Van Assche wrote:
> On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote:
>> Currently UFS HCI uses UFS_BIT() macro to get various bit
>> position for the hardware registers status bits. Which makes
>> code longer instead of shorter
Since we have converted all the user of UFS_BIT() macro
with the actual bit position, let remove unused UFS_BIT()macro.
Signed-off-by: Alim Akhtar
---
drivers/scsi/ufs/ufshci.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index
Assche
Signed-off-by: Alim Akhtar
---
* Changes since V1:
- addressed review comments from Bart.
drivers/scsi/ufs/ufshcd.h | 14 +-
drivers/scsi/ufs/ufshci.h | 66 +--
2 files changed, 42 insertions(+), 38 deletions(-)
diff --git a/drivers/scsi
HOST_ERROR_INDICATOR and DEVICE_ERROR_INDICATOR are not used
anywhere. Also as per JESD223C specification, bit[7:4] are reserved.
Lets remove these #defines.
Signed-off-by: Alim Akhtar
---
drivers/scsi/ufs/ufshci.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshci.h b
Use actual bit position instead of UFS_BIT() macro. This
patch also changes bit-17 to meaningful #define.
This change is as per discussion here [1]
[1] -> https://lkml.org/lkml/2017/8/28/786
Signed-off-by: Alim Akhtar
Cc: Subhash Jadavani
---
drivers/scsi/ufs/ufs-qcom.c | 4 ++--
drivers/s
Skip check for online cpu mask when setting irq affinity of per cpu timer
during early startup of not yet online cpu.
Signed-off-by: Shaik Ameer Basha
Signed-off-by: Aswani Reddy
Signed-off-by: Alim Akhtar
---
drivers/irqchip/irq-gic-v3.c | 7 ++-
1 file changed, 6 insertions(+), 1
On 08/08/2017 02:52 PM, Marc Zyngier wrote:
On 08/08/17 10:04, Alim Akhtar wrote:
Skip check for online cpu mask when setting irq affinity of per cpu timer
during early startup of not yet online cpu.
Signed-off-by: Shaik Ameer Basha
Signed-off-by: Aswani Reddy
Signed-off-by: Alim Akhtar
exynos7 board, things looks fine (have not done a
extensive testing though).
With the _Typo_ fixed as pointed by you, feel free to add
Tested-by: Alim Akhtar
On another note, please cc me if case you want to check/verify something
on exynos7 platform. I almost missed this patch.
Thanks
to be edge rising or level high.
> Platform declares support for both. Choose level high everywhere.
>
> Reported-by: Marek Szyprowski
> Reported-by: Geert Uytterhoeven
> Reported-by: Alban Browaeys
> Cc: Marc Zyngier
> Signed-off-by: Krzysztof Kozlowski
> ---
Revie
sted on:
> 1. Exynos4412: Odroid U3,
> 2. Exynos5410: Odroid XU,
> 3. Exynos5422: Odroid XU3.
>
Tested on Exynos5800 based peach-pi board, so fpr patch 06/10
Tested-by: Alim Akhtar
> Other platforms not tested so testing would be highly appreciated.
>
> Best regards,
> Krzy
401 - 444 of 444 matches
Mail list logo
