Re: [PATCH v3 0/6] Driver for Si476x series of chips

2013-02-11 Thread Alexey Klimov
Hello Andrey, Mauro, Hans, On Tue, Oct 23, 2012 at 6:44 PM, Andrey Smirnov wrote: > This is a third version of the patchset originaly posted here: > https://lkml.org/lkml/2012/9/13/590 > > Second version of the patch was posted here: > https://lkml.org/lkml/2012/10/5/598 > > To save everyone's ti

Re: [PATCH v3 5/6] Add a V4L2 driver for SI476X MFD

2012-11-16 Thread Alexey Klimov
Hello Andrey, On Tue, Oct 23, 2012 at 10:44 PM, Andrey Smirnov wrote: > This commit adds a driver that exposes all the radio related > functionality of the Si476x series of chips via the V4L2 subsystem. > > Signed-off-by: Andrey Smirnov > --- > drivers/media/radio/Kconfig| 17 + > dri

Re: [ 73/77] [hid] usb hid quirks for Masterkit MA901 usb radio

2013-03-04 Thread Alexey Klimov
Hi Greg, On Fri, Mar 1, 2013 at 11:44 PM, Greg Kroah-Hartman wrote: > 3.8-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Alexey Klimov > > commit 0322bd3980b3ebf7dde8474e22614cb443d6479a upstream. > > Don'

Re: [PATCH] elevator: remove second argument in elevator_init()

2016-09-26 Thread Alexey Klimov
On Thu, Mar 31, 2016 at 1:34 AM, Jens Axboe wrote: > On 03/30/2016 05:31 PM, Alexey Klimov wrote: >> >> Hi all, >> >> On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer wrote: >>> >>> Alexey Klimov writes: >>> >>>> Last user of elevat

[PATCH] USB: serial: fix memleak on error path in usb-serial

2016-08-07 Thread Alexey Klimov
udriver struct allocated by kzalloc() will not be freed if usb_register() and next calls fail. This patch fixes this by adding one more step with kfree(udriver) in error path. Cc: Alan Stern Signed-off-by: Alexey Klimov --- drivers/usb/serial/usb-serial.c | 4 +++- 1 file changed, 3 insertions

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-05-30 Thread Alexey Klimov
On Thu, May 25, 2017 at 6:43 PM, Alexey Klimov wrote: > Hi Jassi, > > sorry for delay again. > > On Tue, Apr 11, 2017 at 06:30:08PM +0530, Jassi Brar wrote: > > On 11 April 2017 at 18:04, Alexey Klimov wrote: > > > On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi

Re: [PATCH net-next 6/8] net: thunderx: Rework interrupt handler

2015-08-28 Thread Alexey Klimov
Hi Aleksey, let me add few minor points below. On Fri, Aug 28, 2015 at 5:59 PM, Aleksey Makarov wrote: > From: Sunil Goutham > > Rework interrupt handler to avoid checking IRQ affinity of > CQ interrupts. Now separate handlers are registered for each IRQ > including RBDR. Also register interrup

Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF

2015-08-28 Thread Alexey Klimov
On Fri, Aug 28, 2015 at 5:59 PM, Aleksey Makarov wrote: > From: Sunil Goutham > > This patch adds support for handling multiple qsets assigned to a > single VF. There by increasing no of queues from earlier 8 to max > no of CPUs in the system i.e 48 queues on a single node and 96 on > dual node s

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-08-28 Thread Alexey Klimov
Hi Ma Jun, On Wed, Aug 19, 2015 at 5:55 AM, MaJun wrote: > From: Ma Jun > > Mbigen means Message Based Interrupt Generator(MBIGEN). > > Its a kind of interrupt controller that collects > > the interrupts from external devices and generate msi interrupt. > > Mbigen is applied to reduce the number

[PATCH RESEND 1/1] Revert "spi/doc: spi_master_put must be followed up by kfree"

2015-09-05 Thread Alexey Klimov
(and delayed) crashes elsewhere in the kernel, often in the networking stack. This reverts commit eb4af0f5349235df2e4a5057a72fc8962d00308a. Link to patch and concerns: https://lkml.org/lkml/2012/9/3/269 or http://lkml.iu.edu/hypermail/linux/kernel/1209.0/00790.html Alexey Klimov: This revert

[PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree"

2015-09-05 Thread Alexey Klimov
ctly in patch (sorry for possible inconvenience). Also marked it as RESEND since it's resend of original patch from 2012 year. Best regards, Alexey Klimov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree"

2015-09-05 Thread Alexey Klimov
On Sun, Sep 6, 2015 at 3:06 AM, Mark Brown wrote: > On Sun, Sep 06, 2015 at 01:47:21AM +0300, Alexey Klimov wrote: > >> During review of new SPI drivers I tried to understand connection >> between comment "calling spi_master_put() and kfree() to prevent a >> memory le

Re: [PATCH] ARM: rockchip: add reboot notifier

2015-09-08 Thread Alexey Klimov
of_machine_is_compatible("rockchip,rk3188")) { > + flag_reg = RK3188_PMU_SYS_REG0; > + return 0; > + } > + > + return -ENODEV; [..] > + > +static int __init rockchip_reboot_init(void) > +{ > + int ret = 0; > + > +

[RFC PATCH] clocksource: exynos_mct: use container_of() instead of this_cpu_ptr()

2015-09-03 Thread Alexey Klimov
] ; 0xc0 4ac: ebdbbl 420 4b0: e3a0mov r0, #0 4b4: e8bd8010pop {r4, pc} Also, for me size of exynos_mct.o decreased from 84588 bytes to 83956. Signed-off-by: Alexey Klimov --- drivers/clocksource/exynos_mct.c | 12 1 file changed

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-03 Thread Alexey Klimov
Hi Ma Jun, On Tue, Sep 1, 2015 at 4:45 AM, majun (F) wrote: > Hi Alexey: > > 在 2015/8/29 11:13, Alexey Klimov 写道: [..] >>> +*/ >>> +static u32 calc_irq_index(struct mbigen_device *dev, u32 nid, u32 offset) >>> +{ >>> + struct mbigen_node *mgn

[RFC PATCH 1/3] clocksource: mtk_timer: add pr_fmt define

2015-09-03 Thread Alexey Klimov
It's a bit uncler what subsystem/driver emits some messages to dmesg in function mtk_init_timer(). Use pr_fmt to auto-prefix the messages appropriately. Signed-off-by: Alexey Klimov --- drivers/clocksource/mtk_timer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocks

[RFC PATCH 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init()

2015-09-03 Thread Alexey Klimov
Add error path to clear evt struct allocated by kzalloc() in the beginning of function mtk_timer_init(). Signed-off-by: Alexey Klimov --- drivers/clocksource/mtk_timer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource

[RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init

2015-09-03 Thread Alexey Klimov
These messages are actually errors and not warnings. Use pr_err() macro for them and add missing \n. Signed-off-by: Alexey Klimov --- drivers/clocksource/mtk_timer.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/mtk_timer.c b/drivers

Re: [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-09-03 Thread Alexey Klimov
ioremap_resource(nfc->dev, res); > + if (IS_ERR(nfc->regs)) > + return PTR_ERR(nfc->regs); > + > + nfc->clk = devm_clk_get(&pdev->dev, NULL); > + if (IS_ERR(nfc->clk)) > + return PTR_ERR(nfc->clk); > + > +

[PATCH v2 1/3] clocksource: mtk_timer: add pr_fmt define

2015-10-18 Thread Alexey Klimov
It's a bit unclear what subsystem/driver emits some messages to dmesg in function mtk_init_timer(). Use pr_fmt to auto-prefix the messages appropriately. Acked-by: Matthias Brugger Signed-off-by: Alexey Klimov --- drivers/clocksource/mtk_timer.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v2 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init()

2015-10-18 Thread Alexey Klimov
Add error path to clear evt struct allocated by kzalloc() in the beginning of function mtk_timer_init(). Acked-by: Matthias Brugger Signed-off-by: Alexey Klimov --- drivers/clocksource/mtk_timer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource

[PATCH v2 2/3] clocksource: mtk_timer: fix pr_warn() messages in mtk_timer_init

2015-10-18 Thread Alexey Klimov
1) Change pr_warn()s to pr_err()s. These messages are actually errors and not warnings. 2) Add missing \n. 3) Error message for kzalloc() failure is removed per suggestion by Joe Perches. There is generic stack_dump() for allocation issues. Signed-off-by: Alexey Klimov --- drivers/clocksource

[PATCH v3 1/3] clocksource: mtk_timer: add pr_fmt define

2015-10-25 Thread Alexey Klimov
It's a bit unclear what subsystem/driver emits some messages to dmesg in function mtk_init_timer(). Use pr_fmt to auto-prefix the messages appropriately. Acked-by: Matthias Brugger Signed-off-by: Alexey Klimov --- Changes in v3: -- none Changes in v2: -- added acked-by from Mat

[PATCH v3 3/3] clocksource: mtk_timer: fix memleak in mtk_timer_init()

2015-10-25 Thread Alexey Klimov
Add error path to clear evt struct allocated by kzalloc() in the beginning of function mtk_timer_init(). Acked-by: Matthias Brugger Signed-off-by: Alexey Klimov --- Changes in v3: -- none Changes in v2: -- added acked-by from Matthias drivers/clocksource/mtk_timer.c | 4 +++- 1 file

[PATCH v3 2/3] clocksource: mtk_timer: fix pr_warn() messages in mtk_timer_init

2015-10-25 Thread Alexey Klimov
1) Change pr_warn()s to pr_err()s. These messages are actually errors and not warnings. 2) Add missing \n. 3) Error message for kzalloc() failure is removed per suggestion by Joe Perches. There is generic stack_dump() for allocation issues. Signed-off-by: Alexey Klimov --- Changes in v3

Re: [PATCH v5 06/20] firmware: arm_scmi: add initial support for performance protocol

2018-01-12 Thread Alexey Klimov
> + ret = scmi_one_xfer_init(handle, cmd, SCMI_PROTOCOL_PERF, > +sizeof(*notify), 0, &t); > + if (ret) > + return ret; > + > + notify = t->tx.buf; > + notify->domain = cpu_to_le32(domain); > + notify->notify_enable = cpu_to_le32(enable & BIT(0)); > + > + ret = scmi_do_xfer(handle, t); > + > + scmi_one_xfer_put(handle, t); > + return ret; > +} > + > +static int scmi_perf_limits_notify_enable(const struct scmi_handle *handle, > + u32 domain, bool enable) > +{ > + return __scmi_perf_notify_enable(handle, PERF_NOTIFY_LIMITS, > +domain, enable); > +} > + > +static int scmi_perf_level_notify_enable(const struct scmi_handle *handle, > +u32 domain, bool enable) > +{ > + return __scmi_perf_notify_enable(handle, PERF_NOTIFY_LEVEL, > +domain, enable); > +} > + Do you have any support to correctly handle notifications without errors/warnings? It looks like this two functions are accessible to some user through perf_ops. But are you sure that notifications will be correctly handled by transport, mailbox framework and scmi protocol? The reason I ask is that it looks like it's better to return -EOPNOTSUPP or -ENODEV, maybe -EINVAL here. When you add notifications support you can allow these operations when it's safe to do it. [..] Best regards, Alexey Klimov

Re: [PATCH v5 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

2018-01-04 Thread Alexey Klimov
Hi Sudeep, thank you for working on this. On Tue, Jan 2, 2018 at 2:42 PM, Sudeep Holla wrote: [...] > diff --git a/drivers/firmware/arm_scmi/driver.c > b/drivers/firmware/arm_scmi/driver.c > new file mode 100644 > index ..58d8f88893e6 > --- /dev/null > +++ b/drivers/firmware/arm_s

Re: [PATCH v5 20/20] cpufreq: scmi: add support for fast frequency switching

2018-01-04 Thread Alexey Klimov
Hi Sudeep, On Tue, Jan 2, 2018 at 2:42 PM, Sudeep Holla wrote: > The cpufreq core provides option for drivers to implement fast_switch > callback which is invoked for frequency switching from interrupt context. > > This patch adds support for fast_switch callback in SCMI cpufreq driver > by makin

Re: [PATCH 06/41] clocksource: exynos_mct: Migrate to new 'set-state' interface

2015-06-18 Thread Alexey Klimov
se i can take a look and try to prepare patch. > evt->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT; > evt->rating = 450; > > @@ -482,7 +477,7 @@ static int exynos4_local_timer_setup(struct > clock_event_device *evt) > > static void exyn

Re: [RESEND PATCH 0/6] This series adds SMP support for the MediaTek MT6580.

2015-06-18 Thread Alexey Klimov
On Thu, Jun 18, 2015 at 9:01 PM, Scott Shu wrote: > This patchset adds support SMP on MediaTek MT6580 Cortex-A7 qual core SoC. quad? > This is based on v4.1-rc1 and following patch series: > (1) Yingjoe Chen's "Add SMP bringup support for mt65xx socs" [1] > (2) Mars Cheng's "Add mt6580 basic chi

[PATCH v2] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-02-11 Thread Alexey Klimov
uevent can be avoided if we will ensure that cpuset_hotplug_work has run to completion using cpuset_wait_for_hotplug() after onlining the cpu in cpu_device_up() and in cpuhp_smt_enable(). Co-analyzed-by: Joshua Baker Signed-off-by: Alexey Klimov --- Previous patches and discussion

Re: [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-02-11 Thread Alexey Klimov
On Fri, Feb 5, 2021 at 11:22 AM Qais Yousef wrote: > > On 02/04/21 10:46, Peter Zijlstra wrote: > > On Thu, Feb 04, 2021 at 01:01:57AM +0000, Alexey Klimov wrote: > > > @@ -1281,6 +1282,11 @@ static int cpu_up(unsigned int cpu, enum > > > cpuhp_state target)

Re: [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-02-11 Thread Alexey Klimov
On Fri, Feb 5, 2021 at 12:41 AM Daniel Jordan wrote: > > Peter Zijlstra writes: [...] > >> > One concequence of this is that you'll now get a bunch of notifications > >> > across things like suspend/hybernate. > >> > >> The patch doesn't change the number of kobject_uevent()s. The > >> userspac

[PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-02-03 Thread Alexey Klimov
of line uevent can be avoided if we will ensure that cpuset_hotplug_work has run to completion using cpuset_wait_for_hotplug() after onlining the cpu in cpu_up() and in cpuhp_smt_enable(). Co-analyzed-by: Joshua Baker Signed-off-by: Alexey Klimov --- Previous RFC patch and discussion is here: h

Re: [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-02-04 Thread Alexey Klimov
On Thu, Feb 4, 2021 at 9:46 AM Peter Zijlstra wrote: > > On Thu, Feb 04, 2021 at 01:01:57AM +, Alexey Klimov wrote: > > @@ -1281,6 +1282,11 @@ static int cpu_up(unsigned int cpu, enum cpuhp_state > > target) > > err = _cpu_up(cpu, 0, target); > > out:

Re: [RFC][PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu online

2021-01-19 Thread Alexey Klimov
On Fri, Jan 15, 2021 at 6:54 AM Daniel Jordan wrote: > > Daniel Jordan writes: > > Peter Zijlstra writes: > >>> The nature of this bug is also described here (with different > >>> consequences): > >>> https://lore.kernel.org/lkml/20200211141554.24181-1-qais.you...@arm.com/ > >> > >> Yeah, pesky

Re: [PATCH v2] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-03-15 Thread Alexey Klimov
On Fri, Feb 12, 2021 at 7:42 PM Daniel Jordan wrote: > > Alexey Klimov writes: > > int cpu_device_up(struct device *dev) > > Yeah, definitely better to do the wait here. > > > int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval) > > { > > - int cpu

[PATCH v3] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-03-16 Thread Alexey Klimov
of line uevent can be avoided if we will ensure that cpuset_hotplug_work has run to completion using cpuset_wait_for_hotplug() after onlining the cpu in cpu_device_up() and in cpuhp_smt_enable(). Cc: Daniel Jordan Reviewed-by: Qais Yousef Co-analyzed-by: Joshua Baker Signed-off-by: Alexey Klimov

Re: [PATCH v3] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-04-14 Thread Alexey Klimov
On Sun, Apr 4, 2021 at 3:32 AM Alexey Klimov wrote: > > On Sat, Mar 27, 2021 at 9:01 PM Thomas Gleixner wrote: [...] Now, the patch: >> Subject: cpu/hotplug: Cure the cpusets trainwreck >> From: Thomas Gleixner >> Date: Sat, 27 Mar 2021 15:57:29 +0100 >> >>

Re: [PATCH v3] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining

2021-04-03 Thread Alexey Klimov
On Sat, Mar 27, 2021 at 9:01 PM Thomas Gleixner wrote: Lovely that you eventually found time to take a look at this since first RFC patch was sent. > Alexey, > > On Wed, Mar 17 2021 at 00:36, Alexey Klimov wrote: > > When a CPU offlined and onlined via device_offline() an

[RFC][PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu online

2020-12-03 Thread Alexey Klimov
_for_hotplug() after onlining the cpu in cpu_up(). Unfortunately, the execution time of echo 1 > /sys/devices/system/cpu/cpuX/online roughly doubled with this change (on my test machine). Co-analyzed-by: Joshua Baker Signed-off-by: Alexey Klimov --- The commit "cpuset: Make cpuset hotplu

Re: [PATCH 5/6] update reference, kerneltrap.org no longer works

2014-06-09 Thread Alexey Klimov
On Mon, Jun 9, 2014 at 7:55 PM, Pranith Kumar wrote: > kerneltrap.org no longer works, update to a working reference > > Signed-off-by: Pranith Kumar Acked-by: Alexey Klimov Thanks! -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v3 1/5] mm: kasan: introduce generic kasan_populate_zero_shadow()

2015-07-22 Thread Alexey Klimov
Hi Andrey, Could you please check minor comments below? On Wed, Jul 22, 2015 at 1:30 PM, Andrey Ryabinin wrote: > Introduce generic kasan_populate_zero_shadow(start, end). > This function maps kasan_zero_page to the [start, end] addresses. > > In follow on patches it will be used for ARMv8 (and

Re: [PATCH v3 0/5] KASAN for arm64

2015-07-22 Thread Alexey Klimov
++ > 21 files changed, 440 insertions(+), 13 deletions(-) > create mode 100644 arch/arm64/include/asm/kasan.h > create mode 100644 arch/arm64/mm/kasan_init.c > create mode 100644 mm/kasan/kasan_init.c Could you please check license header in all new files? By

Re: [PATCH 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-23 Thread Alexey Klimov
us IRQ - was a channel > requested?\n"); > + > + return ret; > +} With such usage of ret variable can it happen that handling of last but one channel/instance will set ret to IRQ_WAKE_THREAD and at the same time handling of last channel/instance will set ret to IRQ_HANDLED durin

Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-28 Thread Alexey Klimov
Hi Doug, On Tue, Jul 28, 2015 at 6:24 PM, Doug Anderson wrote: > Alexey, > > On Mon, Jul 27, 2015 at 2:28 PM, Alexey Klimov wrote: >> Hi all, >> >> year(s) ago it was discovered that MCT timer and ARM architectured >> timer >> are the same hardware with

Re: [PATCH] lib: Make _find_next_bit helper function inline

2015-07-29 Thread Alexey Klimov
ly interesting if __always_inline makes things better for aarch64 and worse for x86_64. It will be nice if someone will check it on x86_64 too. Best regards, Alexey Klimov. > Also, if _find_next_bit() benefits from this then _find_next_bit_le() > will presumably also benefit. > > -

[RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-27 Thread Alexey Klimov
xtension there. I hope you are not getting bored reading to me. Current code is a little bit draft so comments and ideas are welcome. Best regards, Alexey Klimov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org M

Re: [RFC PATCH 0/3] clocksource: exynos_mct: allow mct to use 64-bit counter from coprocessor

2015-07-28 Thread Alexey Klimov
On Tue, Jul 28, 2015 at 4:02 PM, Mark Rutland wrote: > On Mon, Jul 27, 2015 at 10:28:27PM +0100, Alexey Klimov wrote: >> Hi all, >> >> year(s) ago it was discovered that MCT timer and ARM architectured >> timer >> are the same hardware with different interface

Re: [PATCH 2/5] net: add Hisilicon Network Subsystem hnae framework support

2015-08-17 Thread Alexey Klimov
Hi Kenneth, just small minor question. On Fri, Aug 14, 2015 at 1:30 PM, Kenneth Lee wrote: > HNAE (Hisilicon Network Acceleration Engine) is a framework to provide a > unified ring buffer interface for Hisilicon Network Acceleration Engines. > > With the interface, upper layer can work as ethern

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-09 Thread Alexey Klimov
m PCCT\n"); > return -EINVAL; > } Looks like after first call to acpi_table_parse_entries() you may have negative number in count. And then you add counted number of type 2 subtables to count variable. I am not aware how pedantic this all should be but you may have more than MAX_PCC_SUBSPACES subspaces or don't probe any subspaces at all with such approach. Or other side effects. Best regards, Alexey Klimov

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-10 Thread Alexey Klimov
On Mon, May 09, 2016 at 10:38:24AM -0700, Hoan Tran wrote: > Hi Alexey, > > On Mon, May 9, 2016 at 2:43 AM, Alexey Klimov wrote: > > Hi Hoan, > > > > On Fri, May 06, 2016 at 11:38:34AM -0700, Hoan Tran wrote: > >> From: hotran > >> > >> ACP

Re: [PATCH v9] mm: kasan: Initial memory quarantine implementation

2016-05-16 Thread Alexey Klimov
Hi Alexander, On Wed, May 11, 2016 at 6:18 PM, Alexander Potapenko wrote: > Quarantine isolates freed objects in a separate queue. The objects are > returned to the allocator later, which helps to detect use-after-free > errors. > > Freed objects are first added to per-cpu quarantine queues. > Wh

Re: [PATCH v5 0/1] ARM64: ACPI: Update documentation for latest specification version

2016-05-16 Thread Alexey Klimov
tation up to date with > > ACPI 6.1 for arm64. > > > > Changes for v5: > >-- Miscellaneous typos and corrections (Lorenzo Pieralisi) > >-- Add linux-acpi@ ML to the distribution list (Alexey Klimov) > >-- Corrections to CPPC information (Alexey Klimov) &g

[PATCH 1/1] mm: kmemleak: remove unneeded initialization of object to NULL

2015-09-09 Thread Alexey Klimov
Few lines below object is reinitialized by lookup_object() so we don't need to init it by NULL in the beginning of find_and_get_object(). Signed-off-by: Alexey Klimov --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-09 Thread Alexey Klimov
Hi Ramakrishna, On Sun, Sep 6, 2015 at 8:23 PM, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging parameters. > > Signed-off-by: R

[PATCH 1/3] clocksource: em_sti: remove unneeded memset()s

2015-09-09 Thread Alexey Klimov
Memory for cs and ced fields in struct em_sti_priv is allocated by devm_kzalloc() in the beginning of em_sti_probe() so they don't need to be zeroed one more time in em_sti_register_clocksource() and in em_sti_register_clockevent(). Signed-off-by: Alexey Klimov --- drivers/clocksource/em_

[PATCH 3/3] clocksource: h8300_*: remove unneeded memset()s

2015-09-09 Thread Alexey Klimov
Memory for timer16_priv, timer8_priv and tpu_priv structs is allocated by devm_kzalloc() in corresponding probe functions of drivers. No need to zero it one more time. Signed-off-by: Alexey Klimov --- drivers/clocksource/h8300_timer16.c | 1 - drivers/clocksource/h8300_timer8.c | 1 - drivers

[PATCH 2/3] clocksource: sh_cmt: remove unneeded memset() in sh_cmt_setup()

2015-09-09 Thread Alexey Klimov
Memory for cmt struct is allocated by kzalloc() in sh_cmt_setup. Signed-off-by: Alexey Klimov --- drivers/clocksource/sh_cmt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c index ba73a6e..103c493 100644 --- a/drivers/clocksource

[PATCH] mm/zswap: remove unneeded initialization to NULL in zswap_entry_find_get

2015-09-09 Thread Alexey Klimov
On the next line entry variable will be re-initialized so no need to init it with NULL. Signed-off-by: Alexey Klimov --- mm/zswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index 48a1d08..4f2f965 100644 --- a/mm/zswap.c +++ b/mm/zswap.c

[PATCH] syscall/mlockall: reorganize return values and remove goto-out label

2015-09-09 Thread Alexey Klimov
ing by few asm lines. Object file size descreased from 220592 bytes to 220528 bytes for me (for aarch64). Signed-off-by: Alexey Klimov --- mm/mlock.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/mlock.c b/mm/mlock.c index 25936680..7e6ad9c 100644 --- a/mm/mlock.

Re: [PATCH v2 1/3] lib: find_*_bit reimplementation

2015-02-05 Thread Alexey Klimov
ernel to use generic find_bit and friends functions implementation on ARMv7 and boot-tested your patch on odroid-xu3 (ARMv7 SoC). Boots and works fine. So if you need my tested-by here it is: Tested-by: Alexey Klimov -- Best regards, Klimov Alexey From 8e17e77e7b20874fea6ac38c5d3102ed56e014c7 Mo

Re: [PATCH v4] ARM64: ACPI: Update documentation for latest specification version

2016-04-21 Thread Alexey Klimov
Hi Al, I hope you don't mind if I put few minor questions here. On Mon, Apr 18, 2016 at 8:32 PM, Al Stone wrote: > The ACPI 6.1 specification was recently released at the end of January > 2016, but the arm64 kernel documentation for the use of ACPI was written > for the 5.1 version of the spec.

Re: [PATCH v2] Force cppc_cpufreq to report values in KHz to fix user space reporting

2016-04-21 Thread Alexey Klimov
On Tue, Apr 19, 2016 at 1:11 AM, Al Stone wrote: > > When CPPC is being used by ACPI on arm64, user space tools such as > cpupower report CPU frequency values from sysfs that are incorrect. > > What the driver was doing was reporting the values given by ACPI tables > in whatever scale was used

[PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-09 Thread Alexey Klimov
This patch creates new driver that supports StreamLabs usb watchdog device. This device plugs into 9-pin usb header and connects to reset pin and reset button on common PC. USB commands used to communicate with device were reverse engineered using usbmon. Signed-off-by: Alexey Klimov

Re: [PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-15 Thread Alexey Klimov
Hi Oliver, On Thu, Mar 10, 2016 at 9:23 AM, Oliver Neukum wrote: > On Thu, 2016-03-10 at 02:29 +0000, Alexey Klimov wrote: >> This patch creates new driver that supports StreamLabs usb watchdog >> device. This device plugs into 9-pin usb header and connects to >> reset pi

Re: [PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-15 Thread Alexey Klimov
Hi Guenter, On Tue, Mar 15, 2016 at 2:24 AM, Guenter Roeck wrote: > Hi Alexey, > > > On 03/14/2016 06:02 PM, Alexey Klimov wrote: >> >> Hi Guenter, >> >> On Thu, Mar 10, 2016 at 3:54 AM, Guenter Roeck wrote: >>> >>> On 03/09/2016 06:29 PM,

[PATCH v2] watchdog: add driver for StreamLabs USB watchdog device

2016-04-17 Thread Alexey Klimov
This patch creates new driver that supports StreamLabs usb watchdog device. This device plugs into 9-pin usb header and connects to reset pin and reset button on common PC. USB commands used to communicate with device were reverse engineered using usbmon. Signed-off-by: Alexey Klimov

Re: [PATCH] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-04-19 Thread Alexey Klimov
Hi Hoan, On Tue, Apr 5, 2016 at 11:14 PM, hotran wrote: > ACPI 6.1 has a HW-Reduced Communication Subspace Type 2 intended for > use on HW-Reduce ACPI Platform, which requires read-modify-write sequence > to acknowledge doorbell interrupt. This patch provides the implementation > for the Communic

Re: [PATCH] elevator: remove second argument in elevator_init()

2016-03-30 Thread Alexey Klimov
Hi all, On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer wrote: > Alexey Klimov writes: > >> Last user of elevator_init() with non-NULL name as second argument >> that supposed to be s390 dasd driver has gone few releases ago. >> Drivers rely on elevator_change(), eleva

Re: [PATCH] phy: ralink-usb: add driver for Mediatek/Ralink

2015-11-05 Thread Alexey Klimov
Hi John, On Wed, Nov 4, 2015 at 10:54 AM, John Crispin wrote: > Add a driver to setup the USB phy on Mediatek/Ralink SoCs. > The driver is trivial and only sets the power and host/device mode. > > Signed-off-by: John Crispin > --- > .../devicetree/bindings/phy/ralink-usb-phy.txt | 17 ++ >

Re: [PATCH v2 3/4] spi: mediatek: Add spi bus for Mediatek MT8173

2015-06-30 Thread Alexey Klimov
Hi Leilk, could you please few minor comments below? On Mon, Jun 29, 2015 at 4:04 PM, Leilk Liu wrote: > This patch adds basic spi bus for MT8173. > > Signed-off-by: Leilk Liu > Signed-off-by: Eddie Huang > --- > drivers/spi/Kconfig | 9 + > drivers/spi/Makefile | 1 + > drivers

Re: [PATCH v5 2/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-07-01 Thread Alexey Klimov
cpu); > + > + ret = PTR_ERR(proc_reg); > + goto out_free_resources; > + } > + > + /* Both presence and absence of sram regulator are valid cases. */ > + sram_reg = regulator_get_exclusive(cpu_dev, "sram")

[PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range()

2015-11-09 Thread Alexey Klimov
Before usage page pointer initialized by NULL is reinitialized by follow_page_mask(). Drop useless init of page pointer in the beginning of loop. Signed-off-by: Alexey Klimov --- mm/mlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mlock.c b/mm/mlock.c index 339d9e0

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

2016-07-14 Thread Alexey Klimov
-- Kconfig for cppc_cpufreq now depends on DMI, instead of selecting >it, in order to make sure DMI is set up properly (Rafael Wysocki) > > Changes for v3: > -- Added clarifying commentary re short-term vs long-term fix (Alexey >Klimov) > -- Added range c

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

2016-07-14 Thread Alexey Klimov
On Thu, Jul 14, 2016 at 10:15:39AM -0600, Al Stone wrote: > On 07/14/2016 04:03 AM, Alexey Klimov wrote: > > Hi Al, > > > > On Tue, Jul 12, 2016 at 11:16:11AM -0600, Al Stone wrote: > >> When CPPC is being used by ACPI on arm64, user space tools such as > >&g

[PATCH RESEND] elevator: remove second argument in elevator_init()

2016-10-10 Thread Alexey Klimov
passing of second name argument and its usage. While we're at it fix following if-check after removed lines. We know that elevator_type e is initialized by NULL and need to check only chosen_elevator. Signed-off-by: Alexey Klimov Reviewed-by: Jeff Moyer --- block/blk-core.c | 2 +-

[PATCH] mailbox: check ->last_tx_done for NULL in case of timer-based polling

2017-03-21 Thread Alexey Klimov
rst message will be transmitted. This patch adds check for this method and logging of error on registration of mailbox controller if it requested timer-based polling. Signed-off-by: Alexey Klimov --- drivers/mailbox/mailbox.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mail

Re: [PATCH] mailbox: always wait in mbox_send_message for blocking tx mode

2017-03-20 Thread Alexey Klimov
so in blocking Tx mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") > Cc: Jassi Brar > Reported-by: Alexey Klimov > Signed-off-by: Sudeep Holla > --- > drivers/mailbox/mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH v3] watchdog: add driver for StreamLabs USB watchdog device

2017-02-17 Thread Alexey Klimov
This patch creates new driver that supports StreamLabs usb watchdog device. This device plugs into 9-pin usb header and connects to reset pin and reset button on common PC. USB commands used to communicate with device were reverse engineered using usbmon. Signed-off-by: Alexey Klimov

Re: [PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-14 Thread Alexey Klimov
Hi Guenter, On Thu, Mar 10, 2016 at 3:54 AM, Guenter Roeck wrote: > On 03/09/2016 06:29 PM, Alexey Klimov wrote: >> >> This patch creates new driver that supports StreamLabs usb watchdog >> device. This device plugs into 9-pin usb header and connects to >> reset pin an

Re: [PATCH 01/10] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-08-23 Thread Alexey Klimov
Hi Alim, On Fri, Aug 21, 2015 at 12:27 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > This patch introduces Exynos UFS PHY driver. This driver > supports to deal with phy calibration and power control > according to UFS host driver's behavior. > > Signed-off-by: Seungwon Jeon > Signed-off-by:

Re: [PATCH] lib: Make _find_next_bit helper function inline

2015-08-23 Thread Alexey Klimov
2 > 1428516848 16330 > 1158313669 13207 > 1306315455 14989 > 1266114955 14500 > 1206814166 13790 > > On 7/29/2015 6:30 AM, Alexey Klimov wrote: >> >> I will re-check on another machine. It's really interesting if >> __always

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

2016-02-01 Thread Alexey Klimov
(adding Rafael and linux-acpi) On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule wrote: > + Jassi (Linaro addr) > > On 15 January 2016 at 13:20, Ashwin Chaugule > wrote: >> Jassi, >> >> On 10 December 2015 at 13:19, Ashwin Chaugule >> wrote: >>>

[PATCH RESEND] mailbox: pcc: fix channel calculation in get_pcc_channel()

2016-02-02 Thread Alexey Klimov
make it: pcc_chan = (struct mbox_chan *) ((unsigned long) pcc_mbox_channels + (id * sizeof(*pcc_chan))); but let's go with array approach here and use id as index. Tested on Juno board. Acked-by: Sudeep Holla Acked-by: Ashwin Chaugule Signed-off-by: A

[PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

2015-12-10 Thread Alexey Klimov
make it: pcc_chan = (struct mbox_chan *) ((unsigned long) pcc_mbox_channels + (id * sizeof(*pcc_chan))); but let's go with array approach here and use id as index. Tested on Juno board. Acked-by: Sudeep Holla Signed-off-by: Alexey Klimov --- drivers/ma

[PATCH] firmware: arm_scpi: reinit completion instead of full init_completion()

2017-03-29 Thread Alexey Klimov
bit of cpu time. Signed-off-by: Alexey Klimov --- drivers/firmware/arm_scpi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 9ad0b19..f6cfc31 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmw

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

2017-04-03 Thread Alexey Klimov
ally, send_pcc_cmd() shouldn't care a lot about software entity that uses it (CPPC, RASF, MPST, etc) and passing some CPU number to this function you bind it to CPPC interfaces while it shouldn't depend on it. Maybe you can pass subspace it here instead. BTW, is it possible to make separate mailbox PCC client and move it out from CPPC code? [...] Best regards, Alexey Klimov.

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

2017-04-04 Thread Alexey Klimov
On Tue, 4 Apr 2017 16:21:20 +0530 George Cherian wrote: > > Hi Alexey, > > On 04/03/2017 11:07 PM, Alexey Klimov wrote: > > (adding Prashanth to c/c) > > > > Hi George, > > > > On Fri, Mar 31, 2017 at 06:24:02AM +, George Cherian wrote: > >&

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-06 Thread Alexey Klimov
POLL > > 2. We have client drivers already doing something similar. I wanted >to fix/move those along with this fix. Or at-least see the feasibiliy > > > Reported-by: Alexey Klimov > > Signed-off-by: Jassi Brar > > --- > > drivers/mailbox/mailbox.c | 1

[PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-06 Thread Alexey Klimov
er acked a message by using ->last_tx_done(), after acknowledge from controller timer callback will trigger mailbox tx state machine. Signed-off-by: Alexey Klimov --- Hi Jassi and Sudeep, could you please take a look at this? The only thing that I don't know how to fix here is that if

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-04-11 Thread Alexey Klimov
On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi Brar wrote: > On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov wrote: > > When mailbox controller provides two or more channels and > > they are actively used by mailbox client(s) it's very easy > > to trigger the

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-11 Thread Alexey Klimov
On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: > On 6 April 2017 at 22:28, Alexey Klimov wrote: > > Hi Jassi/Sudeep, > > > > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep Holla wrote: > >> > >> > >> On 29/03/17 18:43, Jassi Brar wro

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

2017-04-11 Thread Alexey Klimov
t; caller without waiting in mbox_send_message even when it's blocking Tx. > > This patch fixes the issue by waiting for the completion always if Tx > is in blocking mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") > Cc: Jassi Brar >

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-05-25 Thread Alexey Klimov
Hi Jassi, Sorry for delay -- this is not my main activity so please be patient. On Sun, Apr 23, 2017 at 03:33:39PM +0530, Jassi Brar wrote: > On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: > >> On 6 A

Re: [PATCH RFC] mailbox: move controller timer to per-channel timers

2017-05-25 Thread Alexey Klimov
Hi Jassi, sorry for delay again. On Tue, Apr 11, 2017 at 06:30:08PM +0530, Jassi Brar wrote: > On 11 April 2017 at 18:04, Alexey Klimov wrote: > > On Fri, Apr 07, 2017 at 08:39:35PM +0530, Jassi Brar wrote: > >> On Thu, Apr 6, 2017 at 11:01 PM, Alexey Klimov > >>

[PATCH 2/3] rtc: sun6i: fix memleaks and add error-path in sun6i_rtc_clk_init()

2017-07-12 Thread Alexey Klimov
The memory allocated for rtc and clk_data will never be freed in sun6i_rtc_clk_init() in case of error and return. This patch adds required error path with memory freeing. Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") Cc: Maxime Ripard Cc: Rob Herring Signed-off-

[PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm()

2017-07-12 Thread Alexey Klimov
Signed-off-by: Alexey Klimov --- drivers/rtc/rtc-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c index 77bc4d3..1886b85 100644 --- a/drivers/rtc/rtc-sun6i.c +++ b/drivers/rtc/rtc-sun6i.c @@ -362,7 +362,7 @@ static int

[PATCH 1/3] rtc: sun6i: Remove double init of spinlock in sun6i_rtc_clk_init()

2017-07-12 Thread Alexey Klimov
Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") Cc: Maxime Ripard Cc: Rob Herring Signed-off-by: Alexey Klimov --- drivers/rtc/rtc-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c ind

Re: [PATCH v5 00/20][RESEND] firmware: ARM System Control and Management Interface(SCMI) support

2018-02-14 Thread Alexey Klimov
On Mon, Feb 12, 2018 at 6:45 PM, Sudeep Holla wrote: > Hi all, > > ARM System Control and Management Interface(SCMI) is more flexible and > easily extensible than any of the existing interfaces. Many vendors were > involved in the making of this formal specification and is now published[1]. > > Th

  1   2   >