On Mon, Feb 2, 2015 at 3:45 PM, Yury Norov <yury.no...@gmail.com> wrote: > Alexey, > > Yes, ARM has it's own implementation for subj. If you're interested in > testing > my patch on your odroid, try this. (Sorry, I have to attach the patch due to > restrictions on mail agent at office).
Hi Yury, (please don't drop people from cc; restored mail list cc; re-attach patch for testing) As advised please include email [PATCH 0/3] with descriptions and maybe insert your patch-for-testing there that makes ARM arch to use generic find_*_bit functions instead of platform ones. I turn kernel to use generic find_bit and friends functions implementation on ARMv7 and boot-tested your patch on odroid-xu3 (ARMv7 SoC). Boots and works fine. So if you need my tested-by here it is: Tested-by: Alexey Klimov <klimov.li...@gmail.com> -- Best regards, Klimov Alexey
From 8e17e77e7b20874fea6ac38c5d3102ed56e014c7 Mon Sep 17 00:00:00 2001 From: Yury Norov <y.no...@samsung.com> Date: Mon, 2 Feb 2015 15:11:07 +0300 Subject: [PATCH] arm: lib: disable platform implementation of 'find_*_bit' Alexey, ARM has it's own implementation for subj. If you're interested in testing my patch on your odroid, try this. Best regards, Yury Norov. --- arch/arm/include/asm/bitops.h | 19 ------------------- arch/arm/kernel/armksyms.c | 11 ----------- arch/arm/lib/Makefile | 2 +- include/asm-generic/bitops/le.h | 1 + 4 files changed, 2 insertions(+), 31 deletions(-) diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h index 5638099..e0611d1 100644 --- a/arch/arm/include/asm/bitops.h +++ b/arch/arm/include/asm/bitops.h @@ -192,25 +192,6 @@ extern int _find_next_bit_be(const unsigned long *p, int size, int offset); #define test_and_clear_bit(nr,p) ATOMIC_BITOP(test_and_clear_bit,nr,p) #define test_and_change_bit(nr,p) ATOMIC_BITOP(test_and_change_bit,nr,p) -#ifndef __ARMEB__ -/* - * These are the little endian, atomic definitions. - */ -#define find_first_zero_bit(p,sz) _find_first_zero_bit_le(p,sz) -#define find_next_zero_bit(p,sz,off) _find_next_zero_bit_le(p,sz,off) -#define find_first_bit(p,sz) _find_first_bit_le(p,sz) -#define find_next_bit(p,sz,off) _find_next_bit_le(p,sz,off) - -#else -/* - * These are the big endian, atomic definitions. - */ -#define find_first_zero_bit(p,sz) _find_first_zero_bit_be(p,sz) -#define find_next_zero_bit(p,sz,off) _find_next_zero_bit_be(p,sz,off) -#define find_first_bit(p,sz) _find_first_bit_be(p,sz) -#define find_next_bit(p,sz,off) _find_next_bit_be(p,sz,off) - -#endif #if __LINUX_ARM_ARCH__ < 5 diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c index a88671c..22e8748 100644 --- a/arch/arm/kernel/armksyms.c +++ b/arch/arm/kernel/armksyms.c @@ -146,17 +146,6 @@ EXPORT_SYMBOL(_clear_bit); EXPORT_SYMBOL(_test_and_clear_bit); EXPORT_SYMBOL(_change_bit); EXPORT_SYMBOL(_test_and_change_bit); -EXPORT_SYMBOL(_find_first_zero_bit_le); -EXPORT_SYMBOL(_find_next_zero_bit_le); -EXPORT_SYMBOL(_find_first_bit_le); -EXPORT_SYMBOL(_find_next_bit_le); - -#ifdef __ARMEB__ -EXPORT_SYMBOL(_find_first_zero_bit_be); -EXPORT_SYMBOL(_find_next_zero_bit_be); -EXPORT_SYMBOL(_find_first_bit_be); -EXPORT_SYMBOL(_find_next_bit_be); -#endif #ifdef CONFIG_FUNCTION_TRACER #ifdef CONFIG_OLD_MCOUNT diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile index 0573faa..de369aa 100644 --- a/arch/arm/lib/Makefile +++ b/arch/arm/lib/Makefile @@ -6,7 +6,7 @@ lib-y := backtrace.o changebit.o csumipv6.o csumpartial.o \ csumpartialcopy.o csumpartialcopyuser.o clearbit.o \ - delay.o delay-loop.o findbit.o memchr.o memcpy.o \ + delay.o delay-loop.o memchr.o memcpy.o \ memmove.o memset.o memzero.o setbit.o \ strchr.o strrchr.o \ testchangebit.o testclearbit.o testsetbit.o \ diff --git a/include/asm-generic/bitops/le.h b/include/asm-generic/bitops/le.h index 6173154..9a8798f 100644 --- a/include/asm-generic/bitops/le.h +++ b/include/asm-generic/bitops/le.h @@ -2,6 +2,7 @@ #define _ASM_GENERIC_BITOPS_LE_H_ #include <asm/types.h> +#include <asm-generic/bitops/find.h> #include <asm/byteorder.h> #if defined(__LITTLE_ENDIAN) -- 1.9.1
