On Tue, Nov 26, 2013 at 10:09:49AM +0100, Alexander Gordeev wrote:
> Patches 3,4 - fixes for PowerPC pSeries platform
[...]
> PCI/MSI/pSeries: Fix wrong error code reporting
> PCI/MSI/pSeries: Make quota traversing and requesting race-safe
Hi Bjorn,
The two unreviewed PowerPC p
16:36 EST -0.484913 seconds
Performance counter stats for 'system wide':
374 L1-dcache-load-misses
0.485939068 seconds time elapsed
The patchset is against Arnaldo's repo, in "perf/core" branch.
The
Signed-off-by: Alexander Gordeev
---
arch/x86/kernel/cpu/perf_event.h |5 ++
arch/x86/kernel/cpu/perf_event_intel.c | 72 +++
2 files changed, 67 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event.h b/arch/x86/kernel/cpu
Signed-off-by: Alexander Gordeev
---
tools/perf/builtin-stat.c |9 +
tools/perf/util/evlist.c | 38 ++
tools/perf/util/evlist.h |3 +++
tools/perf/util/evsel.c|8
tools/perf/util/evsel.h|3
Signed-off-by: Alexander Gordeev
---
arch/x86/kernel/cpu/perf_event.c | 55 +++-
arch/x86/kernel/cpu/perf_event.h | 10 ++
arch/x86/kernel/cpu/perf_event_amd.c |2 +
arch/x86/kernel/cpu/perf_event_intel.c |4 ++
arch/x86/kernel/cpu
Signed-off-by: Alexander Gordeev
---
include/linux/irq.h | 10 +
include/linux/irqdesc.h |4 +
include/linux/perf_event.h | 24 +++
include/uapi/linux/perf_event.h | 15 ++-
kernel/events/Makefile |2 +-
kernel/events/core.c| 176
might be larger than the returned value, but the
driver may not use the extra vectors it did not request.
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
Device drivers can use this interface to obtain maximum number
of MSI interrupts the device supports and use that number i.e.
in a following call to pci_enable_msi_block() interface.
Signed-off-by: Alexander Gordeev
Reviewed-by: Tejun Heo
---
Documentation/PCI/MSI-HOWTO.txt | 15
pci_enable_msi_block_auto() has been introduced
recently and its only user is AHCI driver, which is also
updated by this change.
Signed-off-by: Alexander Gordeev
Acked-by: Tejun Heo
---
Documentation/PCI/MSI-HOWTO.txt | 39 ---
drivers/ata/ahci.c | 56
drivers are expected to have more clearer
and straight code.
The tree could be found in "pci-next-msi-v5" branch in repo:
https://github.com/a-gordeev/linux.git
Alexander Gordeev (4):
PCI/MSI: Factor out pci_msi_vec_count() interface
PCI/MSI: Get rid of pci_enable_msi_block_
this change.
Signed-off-by: Alexander Gordeev
Reviewed-by: Tejun Heo
---
Documentation/PCI/MSI-HOWTO.txt | 13 +
drivers/pci/msi.c | 18 +-
drivers/pci/pcie/portdrv_core.c |7 ---
include/linux/pci.h |6 +++---
4 files changed
e fallback logic behind
the implementation.
As result, device drivers are expected to have more clearer
and straight code.
Signed-off-by: Alexander Gordeev
Suggested-by: Ben Hutchings
Reviewed-by: Tejun Heo
---
Documentation/PCI/MSI-HOWTO.txt | 261 ---
d
Reviewed-by: Tomas Henzl
Christoph, this patch was declined by James few times.
I think it needs his approval as well.
James?
Thanks!
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Tue, Aug 19, 2014 at 09:32:04AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Thu, Jul 31, 2014 at 03:53:33PM +0200, Alexander Gordeev wrote:
> Michael, Ben,
>
> Any feedback?
Michael, Ben?
> Thanks!
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
: Tadeusz Struk
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: qat-li...@intel.com
Cc: linux-cry...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Alexander Gordeev
---
drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
been
reviewed for several months.
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Plea
Signed-off-by: Alexander Gordeev
Cc: Jens Axboe
---
block/blk-mq-tag.c | 4 +---
block/blk-mq-tag.h | 17 -
2 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index c1b9242..4953b64 100644
--- a/block/blk-mq-tag.c
+++ b/block
Fair share of tags is number of tags diveded on number
of users. Not sure why it is different.
Signed-off-by: Alexander Gordeev
Cc: Jens Axboe
---
block/blk-mq-tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index d1eb579
Signed-off-by: Alexander Gordeev
Cc: Jens Axboe
---
block/blk-mq-tag.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 4953b64..d1eb579 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -60,8 +60,7 @@ static inline
Hi Jens,
These are few changes to blk-mq/blk-mq-tag, nothing really serious.
Cc: Jens Axboe
Alexander Gordeev (3):
blk-mq: Cleanup blk_mq_tag_busy() and blk_mq_tag_idle()
blk-mq: Eliminate superfluous check of BLK_MQ_S_TAG_ACTIVE flag
blk-mq: Fix formula to calculate fair share of tags
On Mon, Aug 18, 2014 at 08:01:51AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
: Alexander Gordeev
---
arch/powerpc/include/asm/machdep.h | 2 --
arch/powerpc/kernel/msi.c | 12 +-
arch/powerpc/platforms/cell/axon_msi.c | 9
arch/powerpc/platforms/powernv/pci.c | 19 ---
arch/powerpc/platforms/pseries/msi.c | 42
Moving MSI checks from arch_msi_check_device() function to
arch_setup_msi_irqs() function makes code more compact and
allows removing unnecessary hook arch_msi_check_device()
from generic MSI code.
Cc: Thomas Gleixner
Cc: Jason Cooper
Cc: linux-...@vger.kernel.org
Signed-off-by: Alexander
-...@vger.kernel.org
Signed-off-by: Alexander Gordeev
---
drivers/pci/msi.c | 49 +
include/linux/msi.h | 3 ---
2 files changed, 13 insertions(+), 39 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 5a40516..6c2cc41 100644
--- a
- patch 3: msi_check_device() renamed to pci_msi_supported(). This is
the very same patch I sent earlier;
Thanks!
Cc: Thomas Gleixner
Cc: Jason Cooper
Cc: Michael Ellerman
Cc: linuxppc-...@lists.ozlabs.org
Cc: linux-...@vger.kernel.org
Alexander Gordeev (3):
i would not cause trouble for anyone.
> Oh, I forgot -- if you'd rather take the first one through the PPC
> tree, you can do that and I can merge the second one later. Let me
> know if you want to do that.
Nah, your treee is just fine.
Thanks!
> Bjorn
--
Regards,
Alexander
On Mon, Jul 28, 2014 at 11:29:51PM +, Jayamohan Kallickal wrote:
>
>
> -Original Message-
> From: Alexander Gordeev [mailto:agord...@redhat.com]
> Sent: Saturday, July 26, 2014 1:09 AM
> To: linux-kernel@vger.kernel.org; Jayamohan Kallickal
> Subject: Re: [
On Wed, Jul 16, 2014 at 08:05:08PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Wed, Jul 16, 2014 at 08:05:10PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Sat, Jul 26, 2014 at 09:16:47AM +0100, Alexander Gordeev wrote:
> On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote:
> > Currently the driver falls back to INTx mode when MSI-X
> > initialization failed. This is a suboptimal behaviour
> > for chips that a
On Sat, Jul 26, 2014 at 09:22:27AM +0100, Alexander Gordeev wrote:
> On Wed, Jul 16, 2014 at 08:05:16PM +0200, Alexander Gordeev wrote:
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these t
On Mon, Jul 28, 2014 at 11:26:13AM +0530, Kashyap Desai wrote:
> > -Original Message-
> > From: Alexander Gordeev [mailto:agord...@redhat.com]
> > Sent: Saturday, July 26, 2014 1:54 PM
> > To: linux-kernel@vger.kernel.org; Neela Syam Kolli
> > Subject: Re: [P
On Wed, Jul 16, 2014 at 08:05:18PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Wed, Jul 16, 2014 at 08:05:20PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
On Tue, Jul 29, 2014 at 07:24:03AM -0700, Christoph Hellwig wrote:
> On Tue, Jul 29, 2014 at 04:15:45PM +0200, Alexander Gordeev wrote:
> > Hmm.. 18/23 applies with a minor fuzz against
> > git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17
>
> Okay, it was ju
On Mon, Jul 28, 2014 at 11:47:19AM +, Vikas Chaudhary wrote:
>
> Acked-By: Vikas Chaudhary
Christoph,
This patch seems ready..
> On 26/07/14 2:11 pm, "Alexander Gordeev" wrote:
>
> >On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote:
> >&
On Wed, Jul 16, 2014 at 08:05:25PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi
-off-by: Alexander Gordeev
---
drivers/pci/msi.c | 49 +
include/linux/msi.h | 3 ---
2 files changed, 13 insertions(+), 39 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 5a40516..6c2cc41 100644
--- a/drivers/pci/msi.c
+++ b
On Mon, Aug 11, 2014 at 02:33:25PM +, bharat.bhus...@freescale.com wrote:
>
>
> > -Original Message-
> > From: linux-pci-ow...@vger.kernel.org
> > [mailto:linux-pci-ow...@vger.kernel.org]
> > On Behalf Of Alexander Gordeev
> > Sent: Monday, A
On Fri, Jul 18, 2014 at 12:20:56PM +0200, Alexander Gordeev wrote:
> The performance test is not decent, though. I used "fio" random
> read against a "null_blk" device sitting on top of "percpu_tags",
> which is not exactly how "percpu_ida" is
; ? and that it has picked up the pci mods ?
James,
I lost the context and not sure what PCI modifications you are referring :(
I will send a patch that combines your version shortly.
Thanks!
> -- james s
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list:
.
Signed-off-by: Alexander Gordeev
Cc: James Smart
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/lpfc/lpfc_init.c | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi
On Mon, Aug 11, 2014 at 11:02:56AM +, Anil Gurumurthy wrote:
> Acked-by: Anil Gurumurthy
Many thanks, Anil!
If your Ack apply to this patch only or to all three
'bfa' patches in this series?
Thanks!
> -Original Message-
> From: Alexander Gordeev [mailto:
On Wed, Aug 13, 2014 at 11:04:54AM -0500, scame...@beardog.cce.hp.com wrote:
> On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote:
> > Currently the driver falls back to INTx mode when MSI-X
> > initialization failed. This is a suboptimal behaviour
> > for ch
Signed-off-by: Alexander Gordeev
Cc: Anil Ravindranath
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/pmcraid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 6f3275d..6e575ed 100644
--- a/drivers/scsi
.
Signed-off-by: Alexander Gordeev
Acked-by: "Stephen M. Cameron"
Cc: iss_storage...@hp.com
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/hpsa.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/scs
Currently the driver fails to analize MSI-X re-enablement
status on resuming and always assumes the success. This
update checks the MSI-X initialization result and fails
to resume if MSI-Xs re-enablement failed.
Signed-off-by: Alexander Gordeev
Acked-by: Kashyap Desai
Cc: Neela Syam Kolli
Cc
.
Signed-off-by: Alexander Gordeev
Reviewed-by: Tomas Henzl
Cc: Nagalakshmi Nandigama
Cc: Sreekanth Reddy
Cc: supp...@lsi.com
Cc: dl-mptfusionli...@lsi.com
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 6 +++---
1 file changed, 3 insertions
Currently the driver falls back to INTx mode when MSI-X
initialization failed. This is a suboptimal behaviour
for chips that also support MSI. This update changes that
behaviour and falls back to MSI mode in case MSI-X mode
initialization failed.
Signed-off-by: Alexander Gordeev
Acked-by
.
Signed-off-by: Alexander Gordeev
Cc: James Smart
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/lpfc/lpfc_init.c | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi
kernel.org
Cc: linux-...@vger.kernel.org
Alexander Gordeev (13):
hpsa: Fallback to MSI rather than to INTx if MSI-X failed
hpsa: Use pci_enable_msix_range() instead of pci_enable_msix()
megaraid: Fail resume if MSI-X re-initialization failed
megaraid: Use pci_enable_msix_range() instea
.
Signed-off-by: Alexander Gordeev
Acked-by: Kashyap Desai
Cc: Neela Syam Kolli
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/megaraid/megaraid_sas_base.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/megaraid
message code 0x00c6 preserved, although it is reported
after successful call to pci_enable_msix_range(), not before
possibly unsuccessful call to pci_enable_msix(). Consumers
of the error code should not notice the difference.
Signed-off-by: Alexander Gordeev
Acked-by: Chad Dupuis
Cc: qla2xxx
.
Signed-off-by: Alexander Gordeev
Reviewed-by: Tomas Henzl
Cc: Nagalakshmi Nandigama
Cc: Sreekanth Reddy
Cc: supp...@lsi.com
Cc: dl-mptfusionli...@lsi.com
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
1 file changed, 2 insertions
There is no need to call pci_disable_msix() in case
the previous call to pci_enable_msix() failed
Signed-off-by: Alexander Gordeev
Cc: Naresh Kumar Inna
Cc: Arvind Bhushan
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/csiostor/csio_isr.c | 4 +---
1 file
.
Signed-off-by: Alexander Gordeev
Cc: Naresh Kumar Inna
Cc: Arvind Bhushan
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/csiostor/csio_hw.h | 2 +-
drivers/scsi/csiostor/csio_isr.c | 22 +-
2 files changed, 10 insertions(+), 14 deletions(-)
diff
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.
Signed-off-by: Alexander Gordeev
Cc: Jayamohan Kallickal
.
Signed-off-by: Alexander Gordeev
Cc: Anil Ravindranath
Cc: linux-s...@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
drivers/scsi/pmcraid.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 6e575ed..bcb64eb
On Wed, Oct 29, 2014 at 08:46:15AM -0700, Paul E. McKenney wrote:
> On Wed, Oct 29, 2014 at 03:16:23PM +0000, Alexander Gordeev wrote:
> > On Wed, Oct 29, 2014 at 07:34:39AM -0700, Paul E. McKenney wrote:
> > > On Wed, Oct 29, 2014 at 01:45:19PM +, Alexander Gordeev wrote:
&
u_check_callbacks(int cpu, int user)
> > {
> > RCU_TRACE(check_cpu_stalls());
> > - if (user || rcu_is_cpu_rrupt_from_idle())
> > + if (user)
> > rcu_sched_qs();
> > else if (!in_softirq())
> > rcu_bh_qs();
>
>
I did build one with the patch I posted. Or you mean something else here?
> Thanx, Paul
>
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bod
On Thu, Oct 30, 2014 at 08:45:59PM -0700, Paul E. McKenney wrote:
> On Thu, Oct 30, 2014 at 09:54:34PM +0000, Alexander Gordeev wrote:
> > On Thu, Oct 30, 2014 at 01:43:18PM -0700, Paul E. McKenney wrote:
> > > > > Have you done any testing of this change?
> > > &g
because
rcu_sched_qs() invokes rcu_qsctr_help().
In the described scenario rcu_sched_qs() and raise_softirq(RCU_SOFTIRQ)
get called twice in steps 3 and 4. This redundancy could be eliminated
by removing rcu_is_cpu_rrupt_from_idle() function.
Signed-off-by: Alexander Gordeev
Cc: Paul E.
rcu_is_cpu_rrupt_from_idle() is redundant.
Signed-off-by: Alexander Gordeev
Cc: Paul E. McKenney
---
kernel/rcu/tiny.c | 12 +---
kernel/rcu/tree.c | 14 +-
2 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c
index c0623fc
On Wed, Oct 29, 2014 at 05:47:29AM -0700, Paul E. McKenney wrote:
> On Wed, Oct 29, 2014 at 12:07:07PM +0100, Alexander Gordeev wrote:
> > Function rcu_is_cpu_rrupt_from_idle() is called from scheduling-
> > clock interrupt handler to check if the current CPU was interrupted
> &g
On Wed, Oct 29, 2014 at 07:34:39AM -0700, Paul E. McKenney wrote:
> On Wed, Oct 29, 2014 at 01:45:19PM +0000, Alexander Gordeev wrote:
> > On Wed, Oct 29, 2014 at 05:47:29AM -0700, Paul E. McKenney wrote:
> > > On Wed, Oct 29, 2014 at 12:07:07PM +0100, Alexander Gordeev wrote
t twice?
I *did* consider moving the threaded handler code to the softirq part.
I just wanted to get updates in stages: to address hardware interrupts
latency first and possibly threaded hander next. Getting done these two
together would be too big change for me ;)
> --
> tejun
--
Regards,
Ale
; proposed changes. Do you have a refreshed version or is the current
> version good for inclusion?
No, this one would not apply. I can send updated version on top of
v5 I posted earlier. Should I?
> tejun
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list:
verage waittime decreased two times.
Both before and after the change the transfer time is the same,
while 'perf record -e cycles:k ...' shows 1%-4% CPU time spent
in ahci_single_irq_intr() routine before the update and not even
sampled/shown ahci_single_irq_intr() after the update.
Signed-off-
There is no need to acquire ata_host::lock spinlock from
hardware context single IRQ interrupt handler since the
handler does not access host data that could be altered
by concurrent processors.
Signed-off-by: Alexander Gordeev
Cc: linux-...@vger.kernel.org
---
drivers/ata/libahci.c | 4
1
On Wed, Sep 24, 2014 at 10:39:13AM -0400, Tejun Heo wrote:
> Hello, Alexander.
>
> On Wed, Sep 24, 2014 at 03:08:44PM +0100, Alexander Gordeev wrote:
> > > Hmmm, how would the whole system benefit from it if there's only
> > > single device? Each individual serv
On Wed, Oct 01, 2014 at 04:31:14PM +0100, Alexander Gordeev wrote:
> I am attaching excerpts from some new perf tests I have done (this
Attaching :)
--
Regards,
Alexander Gordeev
agord...@redhat.com
0.04% dd [kernel.kallsyms] [k] ata_std_qc_defer
0.04% dd [kernel.kallsyms]
On Fri, Oct 03, 2014 at 09:25:22PM +0800, Fengguang Wu wrote:
> Hi Alexander,
>
> FYI, we noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/msi
> commit 4ab2ee7c77875669230a797a3ed2228990f82545 ("PCI/MSI: Rename
> pci_msi_check_device() to pci_msi
ng is fixed in gcc and kernel drops
support of older versions, the dummy item may be removed from
the array.
Cc: "Paul E. McKenney"
Suggested-by: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletio
rrent access patterns are just optimal?
Thanks!
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
On Mon, Aug 17, 2015 at 08:28:16AM -0700, Paul E. McKenney wrote:
> On Mon, Aug 17, 2015 at 11:39:34AM +0100, Alexander Gordeev wrote:
> > Hi Paul,
> >
> > Currently RCU tree distributes CPUs to leafs based on consequent CPU
> > IDs. That means CPUs from remote caches
*** BLURB HERE ***
Alexander Gordeev (2):
sched/core: Get rid of 'cpu' argument in wq_worker_sleeping()
sched/core: Get rid of 'cpu' variable in __schedule()
kernel/sched/core.c | 7 ++-
kernel/workqueue.c | 4 ++--
kernel/workqueue_internal.h | 2 +-
'cpu' variable is only used to acquire the current runqueue.
By using this_rq() instead, we can get rid of that variable.
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Signed-off-by: Alexander Gordeev
---
kernel/sched/core.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
di
Given that wq_worker_sleeping() could only be called for a
CPU it is running on, we do not need passing a CPU ID as an
argument.
Cc: Oleg Nesterov
Cc: Peter Zijlstra
Signed-off-by: Alexander Gordeev
---
kernel/sched/core.c | 2 +-
kernel/workqueue.c | 4 ++--
kernel
There are no users of pci_enable_msix() function left. Obsolete
it in favor of pci_enable_msix_range() and pci_enable_msix_exact()
functions.
Signed-off-by: Alexander Gordeev
Cc: linux-...@vger.kernel.org
---
Documentation/PCI/PCIEBUS-HOWTO.txt | 15 +++---
Documentation/PCI/pci.txt
;= MAX_RCU_LVLS; i++)
> > + for (i = 0; i < rcu_num_lvls; i++)
> > rcu_num_nodes += num_rcu_lvl[i];
> > - rcu_num_nodes -= nr_cpu_ids;
So nr_cpu_ids is added rcu_num_nodes in the cycle and subtracted from
rcu_num_nodes afterwards.
The new version of code does not neigher
evice_id *ent)
>*/
> n_ports = max(ahci_nr_ports(hpriv->cap), fls(hpriv->port_map));
>
> - ahci_init_interrupts(pdev, n_ports, hpriv);
> + irq = ahci_init_interrupts(pdev, n_ports, hpriv);
> + if (irq < 0)
> + return irq;
>
Hello,
This is an attempt to make RCU tree initialization bit more
clear and optimize memory footprint of data associated with
the tree.
Cc: "Paul E. McKenney"
Alexander Gordeev (9):
rcu: Panic if RCU tree can not accommodate all CPUs
rcu: Remove superfluous local v
levels.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 21 -
kernel/rcu/tree.h | 12
2 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index ccea2c7..c085d2c 100644
--- a/
This update makes arithmetic to calculate number of RCU nodes
more straight and easy to read.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.h| 17 -
kernel/rcu/tree_plugin.h | 4 ++--
2 files changed, 6 insertions(+), 15 deletion
enney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 12 ++--
kernel/rcu/tree.h | 1 -
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index eb8b8d7..6856096 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@
parameter update) one might
assume a new value could overflow the value of RCU_NUM_LVLS.
However, that is not the case, since leaf-level fanout is only
permitted to increase, resulting in rcu_num_lvls possibly to
decrease.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/
Members rcu_state::levelcnt[] and rcu_state::levelspread[]
are only used at init. There is no reason to keep them
afterwards.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 29 -
kernel/rcu/tree.h | 2 --
2 files c
Current code suggests that introducing the extra level to
rcu_capacity[] array makes some of the arithmetic easier.
Well, in fact it appears rather confusing and unnecessary.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 16 +++-
1 file
whole
num_rcu_lvl[].
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index fb89630..f9ef1e0 100644
--- a/kernel/rcu/tree.c
++
run-
time then it indicates a serios problem elsewhere and should
be handled with a panic.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tr
Local variable 'n' mimics 'nr_cpu_ids' while the both are
used within one function. There is no reason for 'n' to
exist whatsoever.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 14 +++---
1 file changed, 7 ins
On Sat, Mar 07, 2015 at 09:42:34AM -0800, Paul E. McKenney wrote:
> On Sat, Mar 07, 2015 at 06:03:36PM +0100, Alexander Gordeev wrote:
> > Currently a condition when RCU tree is unable to accommodate
> > the configured number of CPUs is not permitted and causes
> > a fall
sorts of changes, I usually also do some user-level testing.
--
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
Current code suggests that introducing the extra level to
rcu_capacity[] array makes some of the arithmetic easier.
Well, in fact it appears rather confusing and unnecessary.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 16 +++-
1 file
enney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.c | 12 ++--
kernel/rcu/tree.h | 1 -
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 98e36c3..dbcec66 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@
: "Paul E. McKenney"
Alexander Gordeev (10):
rcu: Panic if RCU tree can not accommodate all CPUs
rcu: Remove superfluous local variable in rcu_init_geometry()
rcu: Cleanup rcu_init_geometry() code and arithmetics
rcu: Simplify rcu_init_geometry() capacity arithmetics
rcu: Limit
This update makes arithmetic to calculate number of RCU nodes
more straight and easy to read.
Cc: "Paul E. McKenney"
Signed-off-by: Alexander Gordeev
---
kernel/rcu/tree.h| 17 -
kernel/rcu/tree_plugin.h | 4 ++--
2 files changed, 6 insertions(+), 15 deletion
901 - 1000 of 1156 matches
Mail list logo
