On 11/22/2012 01:49 PM, Joe Perches wrote:
> __printf is useful to verify format and arguments.
>
> Signed-off-by: Joe Perches
Looks good. I can take this into the ceph tree. Thanks.
Reviewed-by: Alex Elder
> ---
> fs/ceph/super.c |2 +-
> include/l
nd re-acquired
within the function.
Signed-off-by: Alex Elder
---
drivers/block/nbd.c |1 +
1 file changed, 1 insertion(+)
Index: b/drivers/block/nbd.c
===
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -551,6 +551,7 @@ static
On 08/23/2013 04:24 PM, Greg Kroah-Hartman wrote:
> The bus_attrs field of struct bus_type is going away soon, dev_groups
> should be used instead. This converts the RBD bus code to use the
> correct field.
>
> Cc: Yehuda Sadeh
> Cc: Sage Weil
> Cc: Alex Elder
Looks rea
t.
Signed-off-by: Alex Elder
---
drivers/clk/clk.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 54a191c..ea8ff15 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1628,7 +1628,7 @@ int __clk_init(struct device *dev, struc
en
as a valid pointer.
Signed-off-by: Alex Elder
---
drivers/clk/clk.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 54a191c..727ae7b 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -272,7 +272,8 @@ static int clk_deb
en
as a valid pointer.
Signed-off-by: Alex Elder
---
drivers/clk/clk.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 2cf2ea6..77fcd06 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -272,7 +272,8 @@ static int clk_deb
On 11/11/2012 02:49 PM, Cyril Roelandt wrote:
> dput() was not called in the error path.
>
> Signed-off-by: Cyril Roelandt
This looks good, thanks a lot. I'll apply it.
Reviewed-by: Alex Elder
> ---
> fs/ceph/export.c |4 +++-
> 1 file changed, 3 insertions(+),
On 05/29/2013 01:22 AM, Dan Carpenter wrote:
> I introduced a new temporary variable "info" instead of
> "m->m_info[mds]". Also I reversed the if condition and pulled
> everything in one indent level.
Looks good. I will apply this for you.
Reviewed-by: Alex
On 07/15/2013 02:07 PM, Linus Torvalds wrote:
> But when people who know better send me crap, I'll curse at them.
>
> I suspect you'll notice me cursing *way* more at top developers than
> random people on the list. I expect more from them, and conversely
> I'll be a lot more upset when they do so
ggestions, and
if you choose not to fix the byte order bugs, please let me know.
Reviewed-by: Alex Elder
> [13439.295457] ceph: mds0 reconnect start
> [13439.300572] BUG: sleeping function called from invalid context at
> include/linux/highmem.h:58
> [13439.309243] in_atomic(): 1, irqs
On 05/15/2013 11:38 AM, Jim Schutt wrote:
>
> Signed-off-by: Jim Schutt
Looks good.
Reviewed-by: Alex Elder
> ---
> fs/ceph/locks.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ceph/locks.c b/fs/ceph/locks.c
> index 202dd3d..f
On 05/15/2013 11:38 AM, Jim Schutt wrote:
> In his review, Alex Elder mentioned that he hadn't checked that
> num_fcntl_locks
> and num_flock_locks were properly decoded on the server side, from a le32
> over-the-wire type to a cpu type. I checked, and AFAICS it is done; those
ut I admit I didn't take as close
a look at it this time.
I appreciate your updating the series to include the things
I mentioned.
I'll commit these for you, and I'll get confirmation on the
byte order thing as well.
Reviewed-by: Alex Elder
> [13439.295457] ceph: mds0 reco
ceph-client tree.
Thanks a lot.
Reviewed-by: Alex Elder
> Signed-off-by: Laurent Barbe
> ---
> drivers/block/rbd.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index f556f8a..1963025 100644
> --- a/driver
ure why I didn't use that to
begin with.
I'll pull this into the ceph tree. Thanks a lot.
Reviewed-by: Alex Elder
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/block/rbd.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/d
On 04/10/2013 02:30 PM, Alex Elder wrote:
> On 04/10/2013 11:06 AM, Laurent Barbe wrote:
>> If rbd disk is open and rbd resize is done, new size is not visible by
>> filesystem.
>> Like is done in virtio-blk and dm driver, revalidate_disk() permits to
>> update the bd_
n rbd_dev_refresh(). But I just haven't
really thought it through yet.
-Alex
>
> 2013/4/11 Alex Elder
>
>> On 04/10/2013 02:30 PM, Alex Elder wrote:
>>> On 04/10/2013 11:06 AM, Laurent Barbe wrote:
>>>> If rbd di
n't do any harm.
Signed-off-by: Alex Elder
---
lib/parser.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Index: b/lib/parser.c
===
--- a/lib/parser.c
+++ b/lib/parser.c
@@ -122,13 +122,14 @@ int match_token
en is non-zero? I.e.:
else if (len)
snprintf(str, len, "doesn't exist");
With your permission I'll make this change and will commit
this for you. OK?
> Signed-off-by: Cong Ding
Reviewed-by: Alex Elder
> ---
> net/ceph/osdmap.c | 27 ++
On 01/23/2013 11:41 AM, Cong Ding wrote:
> On Wed, Jan 23, 2013 at 10:48:07AM -0600, Alex Elder wrote:
>> On 01/22/2013 01:20 PM, Cong Ding wrote:
>>> The variable "str" is used as both the source and destination in function
>>> snprintf(), which is undefine
esponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Probably not needed in practice, but safer nevertheless.
Reviewed-by: Alex Elder
> ---
> drivers/clk/bcm/clk-kona-setup.c | 5 +++--
> 1 file c
ing during the v4.13-rc1 merge window.
Re-enable this functionality by setting the needed config options
in the arm64 "defconfig" file.
Signed-off-by: Alex Elder
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/configs/defconfig
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver
support any more. Remove the code, and remove the config option
from the arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Reviewed-by: Amit Kucheria
Acked-by: Bjorn Andersson
Acked-by:
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more. Remove the code, and remove the config option from the
arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Reviewed-by: Amit Kucheria
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
ate series.
-Alex
v2: Added Reviewed-by: Amit Kucheria
Alex Elder (3):
arm64: defconfig: remove CONFIG_USB_EHCI_MSM
arm64: defconfig: remove CONFIG_USB_MSM_OTG
arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY
arch/arm64/configs/defconfig | 3 ---
1 file changed, 3
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove
the code, and remove the config option from the arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Reviewed-by: Amit Kucheria
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
arch/arm
files that control whether the deleted
code gets built
Alex Elder (3):
usb: host: remove ehci-msm.c
usb: phy: remove phy-msm-usb.c
usb: phy: remove phy-qcom-8x16-usb.c
drivers/usb/host/Kconfig| 12 -
drivers/usb/host/Makefile |1 -
drivers/usb/host/ehci-msm.c
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/host/Kconfig| 12 --
drivers/usb/host/Makefile | 1 -
drivers/usb/host/ehci-m
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver
support any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/phy/Kconfig | 14 --
drivers/usb/ph
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/phy/Kconfig | 15 -
drivers/usb/phy/Makefile |1
On 11/02/2017 04:15 AM, Arnd Bergmann wrote:
> On Tue, Oct 31, 2017 at 1:58 PM, Alex Elder wrote:
>> This series deletes three config options related to USB on Qualcomm
>> SoCs from the arm64 "defconfig". The code enabled by the options is
>> no longer needed
On 10/25/2017 02:02 AM, Andy Gross wrote:
> On Tue, Oct 24, 2017 at 05:20:20PM -0700, Stephen Boyd wrote:
>> On 10/20, Alex Elder wrote:
>>> This series deletes three config options related to USB on Qualcomm
>>> SoCs from the arm64 "defconfig", along with the
This series deletes three config options related to USB on Qualcomm
SoCs from the arm64 "defconfig". The code enabled by the options is
no longer needed by any Qualcomm hardware.
-Alex
Alex Elder (3):
arm64: defconfig: remove CONFIG_US
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more. Remove the code, and remove the config option from the
arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
arch/arm64/configs/defconfi
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver
support any more. Remove the code, and remove the config option
from the arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
arch/arm64/configs
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove
the code, and remove the config option from the arm64 defconfig.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
arch/arm64/configs/defconfig | 1 -
1 file
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver
support any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/phy/Makefile| 1 -
drivers/usb/phy/phy-qcom-
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/host/Makefile | 1 -
drivers/usb/host/ehci-m
This series deletes some Qualcomm USB code is no longer needed by
any Qualcomm hardware.
-Alex
Alex Elder (3):
usb: host: remove ehci-msm.c
usb: phy: remove phy-msm-usb.c
usb: phy: remove phy-qcom-8x16-usb.c
drivers/usb/host/Makefile
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
drivers/usb/phy/Makefile |1 -
drivers/usb/phy/phy-msm-us
On 10/26/2017 12:10 AM, Manu Gautam wrote:
> Hi,
I'll re-send with the kconfig updates pointed out by you and
Felipe Balbi. Sorry about that.
-Alex
>
> On 10/26/2017 3:31 AM, Alex Elder wrote:
>> No Qualcomm SoC requires the "
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
v2: Update the Kconfig file so it no longer offers to build this code,
as su
ernel.)
-Alex
Alex Elder (3):
usb: host: remove ehci-msm.c
usb: phy: remove phy-msm-usb.c
usb: phy: remove phy-qcom-8x16-usb.c
drivers/usb/host/Makefile |1 -
drivers/usb/host/ehci-msm.c | 265 -
drivers/usb/phy/Makefile|2 -
drivers/usb/ph
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver
support any more, so remove the code.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
v2: Update the Kconfig file so it no longer offers to build this co
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.
Suggested-by: Stephen Boyd
Signed-off-by: Alex Elder
Acked-by: Bjorn Andersson
Acked-by: Andy Gross
---
v2: Update the Kconfig file so it no longer offers to build this code,
as suggested by Manu Gautam.
d
On 11/02/2017 07:02 PM, Jack Pham wrote:
> Hi Alex,
>
> On Tue, Oct 31, 2017 at 08:11:30AM -0500, Alex Elder wrote:
>> No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support
>> any more, so remove the code.
>>
>> Suggested-by: Stephen Boyd
ed [-Werror=unused-label]
>
> This removes the unused label to avoid the warning.
>
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann
Looks good.
Reviewed-by: Alex Elder
> ---
> drivers/soc/qcom/rmtfs_mem.c | 2 --
&g
t that's probably not a big deal.
Reviewed-by: Alex Elder
> ---
> v2:
> Updated the patch title and description.
>
> drivers/staging/greybus/camera.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c
There's no sense in scanning the partition table again if we know
the global partition has already been discovered. Check for a
non-null global_partition pointer in qcom_smem_set_global_partition()
immediately.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 10 +-
1
mistakenly treated the last entry in
the table as if it were the global entry found.
Fix the function to return immediately if no global entry is found
in the table.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a
It's OK if the space for a newly-allocated uncached entry actually
touches the free cached space boundary. It's only a problem if it
would cross it.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/q
end of
qcom_smem_alloc_private(). This avoids some long lines, and
reduces the distraction of handling this unexpected problem.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/qcom/smem.c b
This series contains mostly bug fixes to the Qualcomm shared memory
("smem") code. Although the bugs are real, they have most likely
never been observed.
-Alex
Alex Elder (6):
soc: qcom: smem: fix first cache entry calculation
soc: qcom: sm
space, preceding the last allocated cache
entry. Change both functions' return type to be pointer to void
to reflect this.
Meanwhile, phdr_to_first_cached_entry() really *does* point to a
private entry structure, so change its return type to reflect
this fact.
Signed-off-by: Alex Elder
---
driver
lates the start address using the wrong structure size.
Fix this by computing the first item's entry structure address by
subtracting the size of a private entry structure rather than a
partition header structure.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 3 ++-
1 file
Was there something wrong with this patch? I sent it a long time
ago but it still applies cleanly. I can re-send if you like.
-Alex
On 04/27/2018 09:03 AM, Alex Elder wrote:
> Add a prompt to the "tristate" attribute in the Kconfig fi
On 09/28/2018 07:26 AM, Niklas Cassel wrote:
> On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
>> Was there something wrong with this patch? I sent it a long time
>> ago but it still applies cleanly. I can re-send if you like.
>
> Hello Alex,
>
> This pat
On 09/28/2018 12:21 PM, Bjorn Andersson wrote:
>> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS. I could
>> change that to select it instead but I still think this entry
>> should be changed.
I was thinking one of two changes:
- Add the prompt string (which I suggested)
- Don't add the p
On 12/4/18 1:24 PM, Stephen Boyd wrote:
> Quoting David Dai (2018-12-03 19:50:13)
>> Add IPA clock support by extending the current clk rpmh driver to support
>> clocks that are managed by a different type of RPMh resource known as
>> Bus Clock Manager(BCM).
>
> Yes, but why? Does the IPA driver n
nd what got committed is actually what I sent... Hmmm. I bet
quilt did a fuzzy refresh and I neglected to verify the result was correct.
Or more likely, I just did something stupid.
In any case, this looks good.
Reviewed-by: Alex Elder
>
> Fixes: 11d2e7edac6a ("soc: qcom:
Add verification in qcom_smem_partition_header() that the
offset_free_uncached field in a partition's header structure does
not exceed the partition's size.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletion
Change the logic in the loop that finds that global host entry in
the partition table not require the host0 and host1 local variables.
The next patch will remove them.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
).
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 6931602d9a9e..49f228e9d2d3 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -847,15 +847,9
Add verification in qcom_smem_partition_header() that the host ids
found in a partition's header structure match those in its partition
table entry.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 36 +++-
1 file changed, 15 insertions(+), 21 dele
Add verification in qcom_smem_partition_header() that the size in a
partition's header structure matches the size in its partition table
entry.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/dr
be u16
- Fix error messages reporting host ids to use the right format
specifier
- Shorten the error messages as well, to fit on one line
- Add a compile-time check to ensure the local host value passed
to qcom_smem_enumerate_partitions() is in range
Signed-off-by: Alex Elder
---
verifies the header has the right
magic number.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 45 -
1 file changed, 31 insertions(+), 14 deletions(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 49f228e9d2d3..516a17d340af
n for the global partition skips over these invalid entries.
This allows a later check for zero size or offset once the global
entry is found to be eliminated.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
Combine the code that checks whether a partition table entry is
associated with the local host with the assignment of the remote
host id value.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/qcom
them. Change the check
so the partition header must have SMEM_GLOBAL_HOST for *both* its
host fields.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 5d3ed510e54b
Hold off initializing anything for the array entry representing a
memory region in qcom_smem_map_memory() until we know we've
successfully mapped it.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/driver
below. Each of these
changes has been tested and verified to function with available
hardware.
-Alex
Alex Elder (12):
soc: qcom: smem: rename variable in qcom_smem_get_global()
soc: qcom: smem: initialize region struct only when successful
soc: qcom
Rename the variable "area" to be "region" in qcom_smem_get_global(),
so its name better matches its type.
Signed-off-by: Alex Elder
---
drivers/soc/qcom/smem.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/s
On 05/29/2018 06:53 AM, Alex Elder wrote:
> On 05/29/2018 04:12 AM, Arnaud Pouliquen wrote:
>> Hello Alex
>>
>>
>> We have the same needs (prepare unprepare steps) on our platform. We
>> tested you core patches and they answers to our need.
>
> I'm v
From: Bjorn Andersson
Some subdevices, such as glink ssr only care about the stop operation,
so make the operations optional to reduce client code.
Signed-off-by: Bjorn Andersson
Acked-by: Alex Elder
Tested-by: Fabien Dessenne
---
drivers/remoteproc/remoteproc_core.c | 20
both the modem remoteproc
and the application subsystem and requires an intricate lockstep
process when bringing the modem up and down.
[el...@linaro.org: minor description and comment edits]
Signed-off-by: Bjorn Andersson
Acked-by: Alex Elder
Tested-by: Fabien Dessenne
---
drivers/remoteproc
Rename functions used when subdevices are started and stopped to
reflect the new naming scheme.
Signed-off-by: Alex Elder
Tested-by: Fabien Dessenne
---
drivers/remoteproc/qcom_common.c | 16
drivers/remoteproc/remoteproc_core.c | 8
2 files changed, 12
out.
[el...@linaro.org: added comment about assigning function pointers]
Signed-off-by: Bjorn Andersson
Acked-by: Alex Elder
Tested-by: Fabien Dessenne
---
drivers/remoteproc/qcom_common.c | 18 ++
drivers/remoteproc/qcom_sysmon.c | 5 -
drivers/remoteproc
function pointers have been
renamed ("probe" is now "start" and "remove" is now "stop"), and
they are now optional. Callback functions may now also be assigned
for two new events (prior to start and after stop).
-Al
From: Bjorn Andersson
"start" and "stop" are more suitable names for how these two operations
are used, and they fit better with the upcoming introduction of two
additional operations in the struct.
[el...@linaro.org: minor comment edits]
Signed-off-by: Bjorn Andersson
quot;start" and "remove" is now "stop"), and
they are now optional. Callback functions may now also be assigned
for two new events (prior to start and after stop).
-Alex
v2: Adjusted signoff sections of patches as requested by Bjor
From: Bjorn Andersson
Some subdevices, such as glink ssr only care about the stop operation,
so make the operations optional to reduce client code.
Tested-by: Fabien Dessenne
Signed-off-by: Bjorn Andersson
Signed-off-by Alex Elder
---
drivers/remoteproc/remoteproc_core.c | 20
o.org: minor comment edits]
Signed-off-by Alex Elder
---
drivers/remoteproc/remoteproc_core.c | 30 ++--
include/linux/remoteproc.h | 14 ++---
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
Rename functions used when subdevices are started and stopped to
reflect the new naming scheme.
Tested-by: Fabien Dessenne
Signed-off-by Alex Elder
---
drivers/remoteproc/qcom_common.c | 16
drivers/remoteproc/remoteproc_core.c | 8
2 files changed, 12 insertions
both the modem remoteproc
and the application subsystem and requires an intricate lockstep
process when bringing the modem up and down.
Tested-by: Fabien Dessenne
Signed-off-by: Bjorn Andersson
[el...@linaro.org: minor description and comment edits]
Signed-off-by Alex Elder
---
drivers
out.
Tested-by: Fabien Dessenne
Signed-off-by: Bjorn Andersson
[el...@linaro.org: added comment about assigning function pointers]
Signed-off-by Alex Elder
---
drivers/remoteproc/qcom_common.c | 18 ++
drivers/remoteproc/qcom_sysmon.c | 5 -
drivers/remoteproc
used by the current code.
Currently only three IPA interrupts are used: one to trigger a
resume when in a suspended state; and two that allow the embedded
microcontroller to signal events.
Signed-off-by: Alex Elder
---
drivers/net/ipa/ipa_interrupts.c | 307
the first type, rather than initializing each of the types whose
limits are specified.
Fix this bug.
Fixes: 4a0d7579d466e ("net: ipa: avoid going past end of resource group array")
Signed-off-by: Alex Elder
---
drivers/net/ipa/ipa_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
On 1/31/21 11:28 AM, Kumar Kartikeya Dwivedi wrote:
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the w
On 2/12/21 4:50 PM, Manikantan Ravichandran wrote:
checkpatch warning fix for string split across lines
Signed-off-by: Manikantan Ravichandran
I think what you're doing here *looks* reasonable. But
the GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF symbol is
a (string) numeric value that is associa
On 2/16/21 9:48 AM, Kumar Kartikeya Dwivedi wrote:
On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote:
This is a good change. But while you're at it, I would
appreciate if you would convert a few spots to use
sizeof(dest) rather than a fixed constant. I will
point them out below
On 12/23/2014 11:44 PM, Joe Perches wrote:
> On Wed, 2014-12-24 at 14:38 +0900, Masahiro Yamada wrote:
>> ARRAY_AND_SIZE is a useful macro. Its definition is already
>> duplicated in some headers. Move it to include/linux/kernel.h.
>
> I think it's not a good/useful macro and
> would prefer the
On 01/28/2015 02:11 PM, Ard Biesheuvel wrote:
> Actually, if clang is guaranteed to emit the correct register name
> inside the inline asm for register asm variables used in input or
> output constraints, I think it makes sense to #define __asmeq as a nop
> if __clang__ is defined. (Note that __asm
On 01/28/2015 01:17 PM, Ard Biesheuvel wrote:
> On 28 January 2015 at 17:20, Ard Biesheuvel wrote:
>> On 28 January 2015 at 17:08, Alex Elder wrote:
>>> On 01/28/2015 10:17 AM, Ard Biesheuvel wrote:
>>>> On 28 January 2015 at 14:11, Alex Elder wrote:
>>>&g
On 01/28/2015 10:17 AM, Ard Biesheuvel wrote:
> On 28 January 2015 at 14:11, Alex Elder wrote:
>> On 01/28/2015 05:15 AM, Ard Biesheuvel wrote:
>>> On 28 January 2015 at 05:18, Behan Webster
>>> wrote:
>>>> From: Alex Elder
>>>>
>>>&g
On 01/28/2015 05:15 AM, Ard Biesheuvel wrote:
> On 28 January 2015 at 05:18, Behan Webster wrote:
>> From: Alex Elder
>>
>> My GCC-based build environment likes to call register r12 by the
>> name "ip" in inline asm. Behan Webster informed me that his Cl
On 03/20/2015 06:14 AM, Javi Merino wrote:
> We have grown a number of different implementations of
> DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to
> kernel.h so that it can be reused.
>
> Cc: Daniel Vetter
> Cc: Jani Nikula
> Cc: David Airlie
> Cc: Darrick J. Wong
> Cc: G
On 03/20/2015 06:14 AM, Javi Merino wrote:
> Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal
> implementation and use the kernel one.
>
> Cc: Antti Palosaari
> Cc: Mauro Carvalho Chehab
> Signed-off-by: Javi Merino
> ---
> I've only compile-tested it, I don't have the ha
On 03/20/2015 12:27 PM, Javi Merino wrote:
> On Fri, Mar 20, 2015 at 01:51:36PM +0000, Alex Elder wrote:
>> On 03/20/2015 06:14 AM, Javi Merino wrote:
>>> Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal
>>> implementation and use the kernel one.
>
> Reported-by: Alex Elder
> Cc: Viresh Kumar
> Signed-off-by: Greg Kroah-Hartman
Looks good.
Reviewed-by: Alex Elder
>
> ---
> fs/debugfs/inode.c |3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@
1 - 100 of 1348 matches
Mail list logo
