mple test program ("printf ("%d", fork());"), that this patch has
the intended effect of running the child first.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1
.
The program and the output are FTPable from
ftp://ftp.yggdrasil.com/private/adam/linux/zerovars/. Files with no
all-zero .data variables are not included in the listing. If you maintain
any code in the kernel, you might want to look at the output to see
how your code stacks up.
Adam J. Richter
rs/ will be useful
to individual maintainers and in identifying the largest arrays of
zeroes that can fix fixed in a few lines.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630
>> = Adam J. Richter <[EMAIL PROTECTED]>
> = Horst von Brand <[EMAIL PROTECTED]>
>> I suppose that running the child first also has a minor
>> advantage for clone() in that it should make programs that spawn lots
>> of threads to do little bits o
st in at least half of the tries. Evidently,
current->counter must be zero to make the currently running process
give up the CPU immediately, which is the important thing (so that the
parent does not touch its virtual memory for a while).
Adam J. Richter __ __ 4880 Stevens
cate" programmers on this,
could you provide and example or some specifics, especially on why
this should not even be a compiler option? Surely that will save
you some iterations in this discussion.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECT
ram
just as easily.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The R
"John Fremlin" <[EMAIL PROTECTED]> writes:
> "Adam J. Richter" <[EMAIL PROTECTED]> writes:
>> Guess why you're seeing this email. That's right. Linux-2.4.3's
>> fork() does not run the child first.
>[...] If an app wa
"John Fremlin" <[EMAIL PROTECTED]> writes:
>"Adam J. Richter" <[EMAIL PROTECTED]> writes:
>> "John Fremlin" <[EMAIL PROTECTED]> writes:
>> > "Adam J. Richter" <[EMAIL PROTECTED]> writes:
>The parent is not all
nt", although I wonder
if anything else points to the current task or if that might
screw up any interrupts that occur during that process.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+
>>> = Rik van Riel <[EMAIL PROTECTED]>
>> = Adam J. Richter <[EMAIL PROTECTED]>
> = Michael O'Reilly <[EMAIL PROTECTED]>
>> Rik van Riel <[EMAIL PROTECTED]> writes, regarding the idea
>> of having do_fork() give all of the parent'
The "ld" program in binutils-2.10.1.0.7 and in
binutils-2.10.91.0.2 now requires "--oformat" instead of "-oformat".
This breaks linux-2.4.2-pre3/arch/i386/boot/Makefile. I have attached
the fix below. I am running a kernel built with this updated
devices as well. I tested this patch by looking
through my QX3 microscope under XawTV, which did not work without this
change.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630
hat was definitely going to use floating point), but I
think a simpler approach would be to assign a different magic number
argument setpersonality() for programs that expect to be initialized
with floating point precision control set to 2.
Adam J. Richter __ __ 4880 Steven
changes.
So far, I can tell you that reverting the linux/mm subdirectory to
its 2.4.0-prerelease contents had no effect. I will let you know
if I diagnose or fix the problem, as I think you may be experiencing
the same problem.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite
sh blocks marked with BH_Protected
(I think that is just ramdisk blocks), but that would waste memory,
because we really can release blocks from things like truncating
or unlinking files.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ /
hardware, and this minor addition to i386_ksyms.c
was the only change that I had to make to get a clean build. Hooray!
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630
>From: "David L. Parsley" <[EMAIL PROTECTED]>
>Linus Torvalds wrote:
>> On Sat, 6 Jan 2001, Adam J. Richter wrote:
>> >
>> > This sounds like a bug that I posted a fix for a long time ago.
>> > cramfs calls bforget on the superbloc
prefered name, so here is a patch
fixing include/asm-i386/xor.h.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408
rs to be only USB driver that
was missed: drivers/usb/serial/mct_u232.c. This patch fixes the problem.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a
, gets a compilation error. The following patch fix the problem
by stretching an earlier "#ifdef __KERNEL__...#endif" area to cover
the acpi_get_rsdp_ptr declaration.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ /
linux-kernel. If I am right or if you have a better
patch, can you please send it to Linus? Thank you.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a
linux-kernel. If I am right or if you have a better
patch, can you please send it to Linus? Thank you.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a
correct.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
that I have written in this email probably only translate into
20 lines of code.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of
uld use it. I am very interested in feeback
on this question.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 40
Jeff Garzik wrote:
>"Adam J. Richter" wrote:
>> If a programmer errs in favor of __devinit, the result is
>> extra memory consumption under CONFIG_HOTPLUG. If a programmer
>> errs in favor of __init, the result is a crash during hot p
>> ug insertio
lugging. So, CONFIG_HOTPLUG
be CONFIG_PCI_HOTPLUG, or at least should be thought of that way,
regardless of whether CONFIG_USB_HOTPLUG is added.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-103
a} defines in include/linux/init.h
| that would be controlled by a new CONFIG_USB_HOTPLUG option, as in
| the patches that I posted for this to linux-usb-devel.
Until there is __usbdev{init,exit}{,data}, the incorrect
__devinitdata qualifiers should be removed from the USB device
drivers
Jeff Garzik wrote:
>"Adam J. Richter" wrote:
>> You were right: the
>> __devinitdata being used in the USB drivers will probably crash the
>> kernel if CONFIG_HOTPLUG is not defined and the USB code attempts to
>> recover from an error by faking disconnect/rec
handle feeding these patches to Linus if
they look good, or do you want me to?
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of
I think the definition of ISAPNP_DEVICE in
linux-2.4.0-test11-pre5/include/linux/isapnp.h is unnecessarily complex.
Here is a proposed patch.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California
not yet of practical use.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For
ed as:
SMC1211TX EZCard 10/100 or Accton MPX5030 (RealTek RTL8139)
Comments?
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United Stat
y four PCI sound drivers right
now, I would like to be able to fix the whole category.
Also, do you know if there is someone shepherding the drivers/scsi
patches? That is a more important category for automated loading, since
it may be needed in booting.
Adam
r busses, since these
facilities are completely independent, and there are reasons for
wanting to compile in one facility compiled in and not the others,
and it would make drivers self-document which hotplug facility
is the reason why something should be marked as __dev{init,exit}{,da
e of only seven drivers remaining
in the drivers/net (excluding subdirectories) that used the old PCI
probing interface.
This patch is against 2.4.0-test11-pre5, and includes Dave's
changes to make it compile.
Adam J. Richter __ __ 4880 S
y.)
That was automatic PCI ID recognition will work.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631
test12-pre1, and
(b) or (b)+(c) in test12-pre2; however, I do not feel strongly about it.
Anyhow, I am sure any feedback would be appreciated.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-
en feasible so as to support "hot" docking stations
(regardless of whether the core PCI Linux code supports this yet),
pluggable bridges, and possible future versions of the device, since
any device with the same core logic is allowed to have the same PCI
device ID and vendor ID.
I forgot to mention that I have tested the updated maestro.c
patch that I just submitted by loading the module on a
notebook computer, playing some sound, and unloading it.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED
initializers is still kept relatively
small, so a change to pci_device_id that would require changing the
initializers would involve changing only a relatively small number
of drivers, as opposed to potentially all ~150 PCI drivers.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd
ty value in the case of class_mask. depmod deliberately
includes a format comment at the start of modules.pcimap so that the
structure can be changed in the future.
However, thanks for your feedback. I will take it into
consideration.
Adam J. Richter __ __ 4880 Ste
three entries, although I think that may be going to far, as I would
really like to keep the number of files that initialize the pci_device_id
arrays this way low so that changing struct pci_device_id remains feasible.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
>"Adam J. Richter" wrote:
>> Just to avoid duplication of effort, I am posting this preliminary
>> patch which adds PCI MODULE_DEVICE_TABLE declarations to the three PCI
>> drivers in linux-2.4.0-test11/drivers/block. In response to input from
>>
eo 4
drivers/mtd 1
drivers/net/tokenring 1
drivers/pcmcia 1
drivers/sbus/char 1
drivers/telephony 1
drivers/video 7
As you can see, we are converging on complete MODULE_DEVICE_TABLE
coverage for all PCI drivers.
--
Adam J. Richter __ _
>Keith Owens wrote:
>>
>> [Adam J. Richter]
>> > +static struct pci_device_id atp870u_pci_tbl[] __initdata = {
>> > +{vendor: 0x1191, device: 0x8002, subvendor: PCI_ANY_ID, subdevice: PCI_ANY_ID},
>> > +{vendor: 0x1191, device: 0x8010, subvendor: PCI
, needs to reference all of these values
in a single .c file (because all of those disparate .c files are currently
linked into a single module).
Anyhow, it is a harmless patch. Will you please apply it?
Please let me know if you have any questions. Thank you.
ow if
there are other device ID's besides 0x9128 and 0x9135 that
imsttfb.c is interested in, or is it OK to write the
pci_device_id table to just specify those two rather than all
PCI video cards made by IMS?
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL
the vendor_id / device_id
pairs, and, if you want, ports the driver to the new hotplug PCI
interface, which might be useful, considering that I see ieee1394
CardBus cards everywhere.
Any feedback would be appreciated. Thanks in advance.
Adam J. Richter __ __ 4880 Stev
these
new tables use named initializers (by the way, I did not invent that
practice for pci_device_id tables; I think it originated in usb/usb-ohci.c
by David Brownell). Again, the complete patch covering all of the
MODULE_DEVICE_TABLE changes is FTPable from
ftp://ftp.yggdrasil.com/pub/
;fs-".
Of course these changes will add string length checking.
Comments? Are the "fs-" and "if-" prefixes OK? (There
are currently no real modules that have names beginning with those
strings.)
Adam J. Richter __ __ 4880 Stevens Creek
the driver code.
Any comments are welcome.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631
Keith Owens <[EMAIL PROTECTED]> wrote:
>"Adam J. Richter" <[EMAIL PROTECTED]> wrote:
>> Note that this is not a "final" version. I plan to go
>>through all of the changes and bracket all of these new tables
>>with #ifdef MODULE...#endif
schewski that explains my reasons for sticking with
#ifndef MODULE...#endif rather than creating a new kernel facility
for something that, by the way, should become completely unused in
the next couple of months after 2.4.0 is released and the device
drivers are converted to the new PCI and isapnp
Adam Fritzler's port.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For
#x27;s ac4 release). The patch is FTPable from:
ftp://ftp.yggdrasil.com/pub/dist/device_control/kernel/pci_id_tables-2.4.0-test11-ac4.patch4.gz
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 951
>From: Jeff Garzik <[EMAIL PROTECTED]>
>"Adam J. Richter" wrote:
>> I hope this patch will be applied both to the development
>> version of the driver and, ideally, to Alan's tree, and really ideally,
>> propagated to Linus with the rest o
Is there some reason why gcc does not put static data that
is explicitly initialized to zero in .bss? If not, then fixing
gcc would provide more space savings than these patches, and
improve more software than just the Linux kernel.
Adam J. Richter __ __ 4880
.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us.&
Keith Owens <[EMAIL PROTECTED]> wrote:
>"Adam J. Richter" <[EMAIL PROTECTED]> wrote:
>> In reading include/linux/init.h, I was surprised to discover
>>that __init{,data} expands to nothing when compiling a module.
>>I was wondering if anyone is cont
er" to do this and other space optimizations
by modifying objdump. However, I do think that such an improvement
to gcc would be at least a bit useful to the larger user base than
just those people who use binutils-based systems.
Adam J. Richter __ __ 4880 Stevens Creek Blvd,
case, as of yesterday, Dave had said that he was not going to
apply the new style PCI changes at this point, but had integrated
the MODULE_DEVICE_TABLE changes. So, Dave: you should look at
the points that Jeff raised, even if you are not integrating
the rest of my new style PCI patch.
Adam
would be interested in
at least trying to build from your .config file.
Memo to Transmeta management: buy Linus a PictureBook. :-)
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-66
ew
release of the Linux driver. (This is a really small benefit; the
kernel crashes that you want to change my existing patches to produce
is the big issue.)
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, Californi
ll provoke a slew of driver bugs as the over one hundred remaining
PCI drivers are converted to the new PCI interface and some authors
overlook the need to change the MODULE_DEVICE_TABLE storage class.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECT
all succeed, if I understand correctly).
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "
for the lack of PCI IRQ
initialization below. The only change was to delete the first
"if" statement. The rest of the diff lines are just the resulting
intentation and bracketing change.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED]
o change things back.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software
Gábor Lénárt writes:
>On Tue, Dec 05, 2000 at 02:18:59AM -0800, Adam J. Richter wrote:
>> Recently, I have had occasion to build a system on a floppy
>> for a 4MB machine that we use as a router. In the past, the kernels
>
>I've played with this too. You can'
Apparently, in linux 2.4.0-test12-pre5,
address_space_operations->writepage went from having two parameters
to just one. fs/udf/inode.c apparently was overlooked in the patch.
Here is the one line change.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Su
68k/machdep.h).
Linus, could you please apply this patch? Thanks in advance.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States
gt;
>Am I out of luck using ramfs as /? If it's easy to fix, how do I fix it?
We do that right now with cramfs. You might want to examine
ftp://ftp.yggdrasil.com/pub/dist/booting/make-ramdisk-0.19.tar.gz.
Adam J. Richter __ __ 4880 Stevens Creek Blv
longer has any
"#ifdef MODULE" code in it. It just has one module-centric
SMP-safe initialization scheme.
I would appreciate it if people would try this patch
and make sure that it works for them.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite
trim your response list.
Any help in answering these questions will make it a lot
more likely that I will be able to generate a higher quality a patch
sooner to fix this problem.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ /
submit the usb/printer.c device table support patch to
linux-usb-devel momentarily.)
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of A
ver mind.
If it is not some obvious oversight, I guess I will try installing
ALSA and comparing the drivers.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i
nts of struct tq_struct before this.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Fr
.
The following patch brackets the (unused) offending declarations
in #ifdef __KERNEL__...#endif.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i
In linux-2.4.0-test13pre3 (or maybe pre1 or pre2),
mm_struct->segments became mm_struct->context.segmnets. This change
adjusts linux-2.4.0-test13pre3/arch/i386/math-emu/fpu_system.h accordingly
so that i386 math emulation will compile again.
--
Adam J. R
probably be the case
with most Linux distributions initially installed on ia64 hardware).
If need be, I would be willing to at least write a quick and
dirty #ifdef-based version of this proposed change.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL
thinking arch/i386/kernel/acpi.c should just go away, yes?
>
> Its purpose is probably better served by an ifdef, like you mentioned.
[...]
> > From: Adam J. Richter [mailto:[EMAIL PROTECTED]]
> >
> > Although the stock linux-2.4.0-test13pre3 does not allow
> >
got a 1GHz
CPU. So, more instructions per time slice seems to be a relevant
factor.
Anyhow, I know this is a very slippery bug and it may
be months before it is tracked down either here or elsewhere, but
I thought it would be helpful to at least document it for the
linux-kernel a
peded
from doing so by this change.
Anyhow, I thought I should post this suggestion to see if
anyone has any objections, better ideas, improvements or comments.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ /
el readers to sound the alarm
if I botched the patch.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631
It looks like 2.4.0-test13-pre6 contains a partially applied
patch in net/atm/lec.c. It adds references to the symbols
prepare_etherdev and publish_netdev, which are not defined anywhere.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED
_data
I will explore this more tomorrow, but I have been exploring
this problem on and off for three days, so I thought I ought to
mention it on linux-kernel.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San
f the
delays really need to be this long.
Anyhow, I think we should try to resolve the __bad_udelay
problems somehow by, say, linux-2.4.0-prerelease79. :-)
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ /
this change
should be regarded as a stylistic cleanup even if we are not forced
to make the change.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l
takes advantage of the new style
Makefile rules to achieve this end. I think it basically is the
correct approach, although I have not yet tested compilation into
the kernel.
Any testing and feedback would be appreciated.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd
ith respect to this issue, but
if there is not some information that I have missed about this issue,
then I sure hope that the drm maintainers will see the light or, if not,
that Linus overrules the drm maintainers if necessary and integrates a
patch like the one I posted and just deletes those co
use 386's have
already obscelesced from those applications, and still would have, even
with FP emulation in assembly.
It's not my call to make, and I think we will follow the stock
kernels' drivers/char/drm even if it continues this weirdness, but I
certainly
: acpi_ns_execute_control_method
would not would return without releasing the
ACPI_MTX_NAMESPACE mutex if acpi_ns_get_attached_obect
returned NULL.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED
acquired will not necessarily be enough for
me to be able to generate a patch. Anyhow, I imagine that this
lock is being held by some code that can block. We'll see.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / S
alloc_area_pages
alloc_area_pmd
pte_alloc ...which assumes (here incorrectly) that
mm->page_table_lock is held, and sometimes releases
and reacquires mm->page_table_lock.
I will attempt to analyze this further tomorr
eems to have suffered no negative side effects. I am
not confident in exactly where I chose to put the spin_lock and
spin_unlock calls, so I would recommend a careful examination of
this patch before integrating.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMA
Marcelo Tosatti <[EMAIL PROTECTED]> writes:
>There is no need to hold mm->page_table_lock for vmalloced memory.
I don't know if it makes a difference, but I should clarify
that mm == &init_mm throughout this code, not ¤t->mm.
Adam J. Richter __ _
, it would provide a much less disruptive
migration path for adoption across firewalls that drop these packets.
Far more sites could then safely activate this feature without limiting
the hosts that they can reach.
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite
md_setup() is compiled only when md.c
is not a module. Here is the patch.
--
Adam J. Richter __ __ 4880 Stevens Creek Blvd, Suite 104
[EMAIL PROTECTED] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
_granularity) -1) & ~mask" will always
fail on x86+gcc if bit_granularity == 32, because the value of 1<<32
on x86 + gcc-2.95.2 is 1, not 0. The value of 1<= bitsizeof(result), so we should not do this anyhow.
Anyhow, here is a patch that should fix
1 - 100 of 137 matches
Mail list logo
