Attempting to print an object pointed to by a bad (usually ERR_PTR) pointer
is a not so surprising error. Our code handles them inconsistently:
* two places print (null) if ptr
---
lib/vsprintf.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/vsprintf.c b/
On Tue, Mar 06, 2018 at 09:22:17PM +0300, Alexey Dobriyan wrote:
> > +#define BAD_PTR_STRING(x) (!(x) ? "(null)" : IS_ERR(x) ? "(err)" :
> > "(invalid)")
>
> This is getting ridiculous.
>
> Instead of simply printing a pointer as %08lx or %016llx, not only glibc
> (null) stupidity is propagated
On Wed, Mar 07, 2018 at 03:17:19PM +0200, Andy Shevchenko wrote:
> On Tue, 2018-03-06 at 19:11 +0100, Adam Borowski wrote:
>
> Thanks for the patch, my comments below.
(Review snipped.)
It looks pretty obvious that it'd take a lot less of your time to roll new
patch[es] from scrat
On 26 March 2018 10:57, Greg Kroah-Hartman wrote:
> On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote:
> > This commit adds generic ABI information regarding power_supply
> > properties. This is an initial attempt to try and align the usage
> > of these propertie
ndled.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c | 152 ---
1 file changed, 143 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 18ab36f..148db99 100644
--- a/driver
This commit adds generic ABI information regarding power_supply
properties. This is an initial attempt to try and align the usage
of these properties between drivers. As part of this commit,
common Battery and USB related properties have been listed.
Signed-off-by: Adam Thomson
pply class'
Signed-off-by: Adam Thomson
---
drivers/usb/typec/Kconfig | 1 +
drivers/usb/typec/fusb302/Kconfig | 2 +-
drivers/usb/typec/fusb302/fusb302.c | 63 +-
drivers/usb/typec/tcpm.c| 242 +++-
4 files changed, 245 in
nected types (e.g. USB), as discussed
with Heikki.
Changes in v2:
- Use USB_PD and usb_pd prefixes for macros and inline functions in headers.
- Negotiate spec revision of PD headers during initial contract agreement.
- New headers now use SPDX tags for referencing correct license.
NOTE: Cod
This commit adds code to handle requesting of PPS APDOs. Switching
between standard PDOs and APDOs, and re-requesting an APDO to
modify operating voltage/current will be triggered by an
external call into TCPM.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c
e 'usb_type' enum contains all of the USB variant types
that exist for the 'type' enum at this time, and in addition has
SDP and PPS types. The mirroring is intentional so as to not impact
existing usage of the 'type' property.
Signed-off-by: Adam Thomson
Acked-by: Heikki
It's too easy to build the initrd with wrong options during testing, after
which it may silently work anyway.
Signed-off-by: Adam Borowski
---
lib/decompress.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/decompress.c b/lib/decompress.c
index ab3fc90
On Wed, Mar 21, 2018 at 06:29:41PM -0700, Nick Terrell wrote:
> This patch set adds support for a ZSTD-compressed kernel and ramdisk
> images in the kernel boot process. It only integrates the support with
> x86, though the first patch is generic to all architectures.
I'm running this patch set si
On 22 March 2018 03:53, Guenter Roeck wrote:
> > +static void tcpm_pd_ext_msg_request(struct tcpm_port *port,
> > + const struct pd_message *msg)
> > +{
> > + enum pd_ext_msg_type type = pd_header_type_le(msg->header);
> > + unsigned int data_size = pd_ext_header_
On 22 March 2018 04:03, Guenter Roeck wrote:
> > static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo,
> > @@ -1308,6 +1347,26 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port
> *port, const u32 *pdo,
> > pdo_min_voltage(pdo[i - 1]))
On 22 March 2018 04:08, Guenter Roeck wrote:
> > +static ssize_t power_supply_show_usb_type(struct device *dev,
> > + enum power_supply_usb_type
> *usb_types,
> > + ssize_t num_usb_types,
> > +
On 22 March 2018 04:09, Guenter Roeck wrote:
> > +static int tcpm_psy_set_prop(struct power_supply *psy,
> > +enum power_supply_property psp,
> > +const union power_supply_propval *val)
> > +{
> > + struct tcpm_port *port = power_supply_get_drvdata
On Thu, Mar 22, 2018 at 12:09:45PM +0100, René Rebe wrote:
> Should this currently just work without any arch change on e.g.
> ppc64, sparc64 et al.? I could do a test build and boot if that is
> of any value, ...
Initrd: no reason it wouldn't work, although for anything related to the
boot proces
ndled.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c | 143 ---
1 file changed, 134 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index c859cba..fffe97d 100644
--- a/driver
e 'usb_type' enum contains all of the USB variant types
that exist for the 'type' enum at this time, and in addition has
SDP and PPS types. The mirroring is intentional so as to not impact
existing usage of the 'type' property.
Signed-off-by: Adam Thomson
b_pd prefixes for macros and inline functions in headers.
- Negotiate spec revision of PD headers during initial contract agreement.
- New headers now use SPDX tags for referencing correct license.
NOTE: Code changes based on usb-next (027bd6cafd9a1e3a109b5e5682c85ac84e804a8d)
Adam Thomson (6)
pply class'
Signed-off-by: Adam Thomson
---
drivers/usb/typec/Kconfig | 1 +
drivers/usb/typec/fusb302/Kconfig | 2 +-
drivers/usb/typec/fusb302/fusb302.c | 63 +-
drivers/usb/typec/tcpm.c| 242 +++-
4 files changed, 245 in
it updates the registration code to add some basic
checks on the desc pointer validity, name, and presence of
properties.
Signed-off-by: Adam Thomson
---
drivers/power/supply/power_supply_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/power/supply/power_supply_core.c
b/dri
This commit adds code to handle requesting of PPS APDOs. Switching
between standard PDOs and APDOs, and re-requesting an APDO to
modify operating voltage/current will be triggered by an
external call into TCPM.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c
This commit adds generic ABI information regarding power_supply
properties. This is an initial attempt to try and align the usage
of these properties between drivers. As part of this commit,
common Battery and USB related properties have been listed.
Signed-off-by: Adam Thomson
it updates the registration code to add some basic
checks on the desc pointer validity, name, and presence of
properties.
Signed-off-by: Adam Thomson
---
drivers/power/supply/power_supply_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/power/supply/power_supply_core.c
b/dri
e 'usb_type' enum contains all of the USB variant types
that exist for the 'type' enum at this time, and in addition has
SDP and PPS types. The mirroring is intentional so as to not impact
existing usage of the 'type' property.
Signed-off-by: Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching
between standard PDOs and APDOs, and re-requesting an APDO to
modify operating voltage/current will be triggered by an
external call into TCPM.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c
pply class'
Signed-off-by: Adam Thomson
---
drivers/usb/typec/Kconfig | 1 +
drivers/usb/typec/fusb302/Kconfig | 2 +-
drivers/usb/typec/fusb302/fusb302.c | 63 +-
drivers/usb/typec/tcpm.c| 245 +++-
4 files changed, 248 in
ndled.
Signed-off-by: Adam Thomson
Acked-by: Heikki Krogerus
---
drivers/usb/typec/tcpm.c | 143 ---
1 file changed, 134 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 57a7d1a..7025a16 100644
--- a/driver
This commit adds generic ABI information regarding power_supply
properties. This is an initial attempt to try and align the usage
of these properties between drivers. As part of this commit,
common Battery and USB related properties have been listed.
Signed-off-by: Adam Thomson
as discussed
with Heikki.
Changes in v2:
- Use USB_PD and usb_pd prefixes for macros and inline functions in headers.
- Negotiate spec revision of PD headers during initial contract agreement.
- New headers now use SPDX tags for referencing correct license.
NOTE: Code changes based on usb
On 09 March 2018 04:58, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA usage and replace it
> with fixed-length arrays.
>
> It seems that the length of array 'buf' will not exceed
> DA9150_QIF_SHORT_SIZE bytes (2 bytes). But a fixed length
> of DA9150_QIF_BYTE_SIZE byte
is used.
Signed-off-by: Adam Thomson
---
Documentation/devicetree/bindings/sound/da7219.txt | 6 +
include/sound/da7219.h | 2 +
sound/soc/codecs/da7219.c | 129 +++--
sound/soc/codecs/da7219.h
On 13 March 2018 06:09, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/codecs/da7219.o: In function `.da7219_remove':
> da7219.c:(.text+0xcbc): undefined reference to `.clkdev_drop'
>
> C
defined for those platforms, in
headers and source but the functions are not linked in.
This patch resolves this issue, so clkdev_drop is only used if
CONFIG_COMMON_CLK is defined.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
On Fri, Sep 28, 2018 at 11:31:32AM +0200, www.Advocati.org wrote:
> CONTRIBUTORS CAN NOT JUST RESCIND THE LICENSE
> THEY GRANTED UNDER GPLv2. IT IS *COPYLEFTED*
> A letter from 17.09.2018 by @observerofaffairs
> titled 'GPL version 2 is a bare license. Recind. (Regarding (future)
> Code of Conduct
On 21 November 2018 15:35, Enric Balletbo i Serra wrote:
> We have a problem with USBPD chargers which under certain conditions
> can result in system overheating if the voltage provided by the USBPD
> port is too high. While the preferred means to control this would be
> through devicetree or
evel
> knowledge or user input.
>
> Signed-off-by: Enric Balletbo i Serra
> Reviewed-by: Guenter Roeck
Acked-by: Adam Thomson
> ---
>
> Changes in v2:
> - Document the new property in ABI/testing/sysfs-class-power.
> - Add the Reviewed-by Guenter Roeck ta
On Sun, Nov 11, 2018 at 12:46:35PM +0100, Florian Weimer wrote:
> A lot of multi-threaded applications assume that most high-level
> functionality remains usable even after fork in a multi-threaded
> process.
How would this be even possible? Currently fork kills all threads
(save for the caller).
On 04 December 2018 18:36, Akshu Agrawal wrote:
> Failed i2c transaction can lead to failure in reg read or write.
> Need to have error check for each read write operation.
>
I'm not really clear what this gains you. If I2C is broken this won't solve
anything, and you have far deeper problems. Se
On 05 December 2018 04:27, Akshu Agrawal wrote:
> On 12/5/2018 2:46 AM, Adam Thomson wrote:
> > On 04 December 2018 18:36, Akshu Agrawal wrote:
> >
> >> Failed i2c transaction can lead to failure in reg read or write.
> >> Need to have error check for each read
org
> Signed-off-by: Rob Herring
For da9052 regulator driver:
Acked-by: Adam Thomson
> ---
> drivers/regulator/88pm8607.c | 2 +-
> drivers/regulator/da9052-regulator.c | 2 +-
> drivers/regulator/max8997-regulator.c | 2 +-
> drivers/regulator
From: Nick Terrell
Add support for extracting ZSTD-compressed kernel images, as well as
ZSTD-compressed ramdisk images in the kernel boot process.
When neither `fill' nor `flush' are used, the decompression function
requires a constant amount of memory (192 KB is sufficient). When either
is used
It was really obsolete, and some entries contradicted each other.
Let's not recommend ZSTD for kernel compression yet as it's available
only on x86, and some distros might not have the tool installed.
Proposing ZSTD for initrd is safer but let's test it first.
Signed-off-by
b at 0xc060
Loading Device Tree to c7e57000, end c7e5ef80 ... OK
Starting kernel ...
Uncompressing Linux... done, booting the kernel.
(and hang)
If you have some suggestions, I am try them as I get time.
adam
>
> Changes:
>
> v10 changes (also see individual patches for details):
> - Re
On Sun, Jun 17, 2018 at 03:07:02PM -0400, Nicolas Pitre wrote:
> The vt code translates UTF-8 strings into glyph index values and stores
> those glyph values directly in the screen buffer. Because there can only
> be at most 512 glyphs, it is impossible to represent most unicode
> characters, in wh
On Tue, Jun 19, 2018 at 09:52:13AM -0400, Dave Mielke wrote:
> [quoted lines by Adam Borowski on 2018/06/19 at 15:09 +0200]
>
> >You're thinking small. That 256 possible values for Braille are easily
> >encodable within the 512-glyph space (256 char + stolen fg brightn
Note that the LZ4 signature is different than that of modern LZ4 as we
use the "legacy" format which suffers from some downsides like inability
to disable compression.
Signed-off-by: Adam Borowski
---
The first time this was sent I managed to screw up both the subject and
scissors lin
There are no keys connected to the keypad pins on any of the
logicpd torpedo SOM's.
This eliminates some splat about malformed keypad properies
Signed-off-by: Adam Ford
diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
index 7d2302e
From: Adam Manzanares
Aio per command iopriority support introduces a second interface between
userland and the kernel capable of passing iopriority. The aio interface also
needs the ability to verify that the submitting context has sufficient
priviledges to submit IOPRIO_RT commands. This patch
From: Adam Manzanares
In order to avoid kiocb bloat for per command iopriority support, rw_hint
is converted from enum to a u16. Added a guard around ki_hint assigment.
Signed-off-by: Adam Manzanares
---
include/linux/fs.h | 15 +--
1 file changed, 13 insertions(+), 2 deletions
From: Adam Manzanares
This is the per-I/O equivalent of the ioprio_set system call.
See the following link for performance implications on a SATA HDD:
https://lkml.org/lkml/2016/12/6/495
First patch factors ioprio_check_cap function out of ioprio_set system call to
also be used by the aio
From: Adam Manzanares
This is the per-I/O equivalent of the ioprio_set system call.
When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the
newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field.
When a bio is created for an aio request by the block dev
On 5/17/18 7:41 PM, Jens Axboe wrote:
> On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote:
>> From: Adam Manzanares
>>
>> This is the per-I/O equivalent of the ioprio_set system call.
>> See the following link for performance implications on a SATA HDD:
>> ht
On 5/18/18 8:14 AM, Jens Axboe wrote:
> On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote:
>> From: Adam Manzanares
>>
>> This is the per-I/O equivalent of the ioprio_set system call.
>>
>> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set t
On 5/18/18 9:05 AM, Christoph Hellwig wrote:
>> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */
>
> I don't think this comment is very useful.
>
>> +static inline u16 ki_hint_valid(enum rw_hint hint)
>
> I'd call this ki_hint_validate.
>
>> +{
>> +if (hint > MAX_K
On 5/18/18 9:06 AM, Christoph Hellwig wrote:
> Looks fine, although I'd split it into a aio and block_dev patch.
>
> Also please wire this up for the fs/iomap.c direct I/O code, it should
> be essentially the same sniplet as in the block_dev.c code.
>
Will do.
Hi!
On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote:
> I'm announcing the release of the 4.18.1 kernel.
I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities':
(.text+0x43b2): undefined reference to `l1tf_vm
On Thu, Aug 16, 2018 at 05:11:21PM +0200, Greg KH wrote:
> On Thu, Aug 16, 2018 at 03:59:58PM +0200, Sven Joachim wrote:
> > On 2018-08-16 15:05 +0200, Adam Borowski wrote:
> > > I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
> > >
> >
On Fri, Aug 17, 2018 at 09:54:03AM -0700, Andi Kleen wrote:
> On Fri, Aug 17, 2018 at 06:15:45PM +0200, René Rebe wrote:
> > Hey,
> >
> > is there any mainline future for this zstd support?
> > Currently my most favourite compressor for this, and for what it’s worth
> > zstd/initrd now even tested
On Fri, Aug 17, 2018 at 12:22:44PM -0700, Andi Kleen wrote:
> On Fri, Aug 17, 2018 at 07:57:46PM +0200, Adam Borowski wrote:
> > > The "favourite compressor" seems to roughly change every year, so if
> > > we keep adding new ones things will get more and more
On Sun, Aug 19, 2018 at 04:21:57PM -0700, Linus Torvalds wrote:
> On Sun, Aug 19, 2018 at 3:13 PM Stephen Rothwell
> wrote:
> >
> > Today's linux-next build (powerpc ppc64_defconfig) produced these
> > warnings:
> >
> > fs/cifs/cifssmb.c:605:3: warning: 'strncpy' writing 16 bytes into a region
>
On 12 December 2018 02:47, Kyle Tso wrote:
> On Mon, Dec 10, 2018 at 7:36 PM Adam Thomson
> wrote:
> >
> > On 10 December 2018 09:01, Adam Thomson wrote:
> >
> > > On 06 December 2018 03:02, Kyle Tso wrote:
> > >
> > > > Current ma
On Thu, Dec 13, 2018 at 10:37:31AM +0100, Sven Hartrumpf wrote:
> Will the proposed patch ("only") remove the possibility to build x32 kernels
> or will it make impossible to compile and run any x32 binaries?
There's no such thing as x32 kernels. It's an ABI atop amd64 kernels; the
kernel is alwa
operty, similar to input current limit, to
> re-configure
> the maximum voltage from the external supply at runtime based on system-level
> knowledge or user input.
>
> Signed-off-by: Enric Balletbo i Serra
> Reviewed-by: Guenter Roeck
Acked-by: Adam Thomson
> ---
&g
On 17 December 2018 02:48, Kyle Tso wrote:
> Current matching rules ensure that the voltage range of selected Source
> Capability is entirely within the range defined in one of the Sink
> Capabilities. This
> is reasonable but not practical because Sink may not support wide range of
> voltage whe
On 17 December 2018 12:45, Kyle Tso wrote:
> On Mon, Dec 17, 2018 at 8:23 PM Adam Thomson
> wrote:
> >
> > On 17 December 2018 02:48, Kyle Tso wrote:
> >
> > > Current matching rules ensure that the voltage range of selected
> > > Source Capability is e
um operational voltage times the
>maximum current defined in the selected Source PDO d. Select the Source PDO
> with the highest maximum power
>
> Signed-off-by: Kyle Tso
Acked-by: Adam Thomson
>
> ---
> Changelog since v1:
> - updated the commit message as sugges
On 06 December 2018 03:02, Kyle Tso wrote:
> Current matching rules ensure that the voltage range of selected Source
> Capability is entirely within the range defined in one of the Sink
> Capabilities. This
> is reasonable but not practical because Sink may not support wide range of
> voltage whe
On 10 December 2018 09:01, Adam Thomson wrote:
> On 06 December 2018 03:02, Kyle Tso wrote:
>
> > Current matching rules ensure that the voltage range of selected
> > Source Capability is entirely within the range defined in one of the
> > Sink Capabilities. This is reas
On Thu, Dec 20, 2018 at 7:18 PM Sebastian Reichel wrote:
>
> From: Sebastian Reichel
>
> Add a node for the UART part of WiLink chip.
>
> Cc: Adam Ford
> Signed-off-by: Sebastian Reichel
> ---
> This is compile tested only!
I have tried this a few times, unfo
d, I'd like to hold off on applying these changes.
Also, there are references to this driver inside pdata-quirks that
need to be removed as well once the loading and timeout issues have
been resolved.
adam
>
> Signed-off-by: Sebastian Reichel
> ---
> drivers/misc/Kconfig
On Fri, Dec 21, 2018 at 9:00 PM Sebastian Reichel wrote:
>
> Hi,
>
> On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote:
> > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote:
> > >
> > > From: Sebastian Reichel
> > >
> > &g
r boards
other than the Logic PD Torpedo kit. Do you have any wl1283 boards to
test? I'd like to see this BT timeout stuff resolved before we dump
the ti-st kim stuff, otherwise, I'll forever be porting drivers. :-(
adam
> try using fmtools.git and fmscan works just fine. No luck yet w
On 05 January 2019 02:03, Pierre-Louis Bossart wrote:
> Reported by Sparse:
> da7219.c:841:57: warning: dubious: x & !y
>
> Cc: Adam Thomson
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Adam Thomson
> ---
> sound/soc/codecs/da7219.c | 2 +-
> 1 fil
in assignment (different base
> types)
> da7219-aad.c:157:37:expected unsigned short [unsigned] [usertype]
> tonegen_freq_hptest
> da7219-aad.c:157:37:got restricted __le16 [usertype]
>
> Cc: Adam Thomson
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Adam Thomso
the
default pinmux. I am wondering if it should use pins_100mhz. We have
an eMMC part that we want to operate at this point and it seems like
it missing. If so, I can submit a patch.
It also seems like that SDR12, SDR25 use the default. I assume this is OK.
adam
On Sat, Oct 27, 2018 at 11:13:17AM -0700, Linus Torvalds wrote:
> Ok, so this is a much smaller issue than the i2c one that cause boot
> problems, but it's annoying.
>
> We do *not* enable new random drivers by default. And we most
> *definitely* don't do it when they are odd-ball ones that most p
On Wed, Oct 24, 2018 at 9:17 AM Adam Ford wrote:
>
> On Wed, Oct 24, 2018 at 9:08 AM jacopo mondi wrote:
> >
> > Hi Adam,
> >
> > On Wed, Oct 24, 2018 at 08:53:41AM -0500, Adam Ford wrote:
> > > On Tue, Oct 23, 2018 at 6:03 PM jacopo mondi wrote:
> >
0x480 field:none]"
gst-launch-1.0 -v v4l2src num-buffers=1 device=/dev/video0 ! jpegenc
! filesink location=test.jpg
[ 72.799015] ipu1_ic_prpenc: EOF timeout
[ 73.838985] ipu1_ic_prpenc: wait last EOF timeout
When I try to jump directly to 4.19-RC8, I get errors regarding mem
On Wed, Oct 17, 2018 at 3:01 AM jacopo mondi wrote:
>
> Hi Adam, Seve,
>
> On Tue, Oct 16, 2018 at 05:13:24PM -0700, Steve Longerbeam wrote:
> > Hi Adam,
> >
> >
> > On 10/16/18 12:46 PM, Adam Ford wrote:
> > >On Thu, Sep 20, 2018 at 9:58
On Sun, Sep 16, 2018 at 12:22:43PM -0700, Linus Torvalds wrote:
> This is my reality. I am not an emotionally empathetic kind of person
> and that probably doesn't come as a big surprise to anybody. Least of
> all me. The fact that I then misread people and don't realize (for
> years) how badly
On Tue, Jul 17, 2018 at 09:02:40PM -0400, Nicolas Pitre wrote:
> The nr argument is typically small: most often nr == 1. However this
> could be abused with a very large explicit scroll in a resized screen.
> Make the code scroll lines one at a time in all cases to avoid the VLA.
> Anything smarter
Hi!
Based on Nicolas' nice work (in tty-next), let's avoid corrupting characters
that have been copy+pasted via mouse selection. The uniscr array holds
their original identity even if they got mangled by glyph conversion.
The glyph conversion lossily turns similar-looking characters into a
represe
Those above U+10 get replaced with U+FFFD.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/selection.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index 34e7110f310d..69ca337d3220 100644
for most users.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/selection.c | 11 +++
drivers/tty/vt/vt.c| 10 ++
include/linux/selection.h | 1 +
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
ind
All the helper function saved us was a cast.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/selection.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index 90ea1cc52b7a..34e7110f310d 100644
--- a
Hi!
Here's a patchset with two entangled improvements:
* it'd be good to get rid of blinking where possible. Even CGA (thus VGA)
allows disabling it, rendering such characters with a bright background
instead.
* due to my error, 256-color mode uses a much darker palette for conversion,
resu
Hasn't been ever used within historic (ie, git) times.
Signed-off-by: Adam Borowski
---
include/linux/console_struct.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h
index 2c8d3239899b..fea64f2692a0 1
other consoles: newport looks like it shows bright bg, sti can't do
either, mda appears to blink, etc -- but confirmation would be needed.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/vt.c | 1 +
drivers/video/fbdev/core/fbcon.c | 1 +
include/linux/console_struct.h | 1 +
, thus
there are some differences, among others:
* values very close to black go to 0 (black) rather than 8 (dark grey)
* grayscale ramp is more even
A comparison of the old vs new vs FreeBSD's teken is at:
https://github.com/kilobyte/colorkernel
Signed-off-by: Adam Borowski
---
drivers/tty/vt
into only 16
values, but recently 24-bit codes turned from an oddity to something
widespread, thus it's better to handle 256 vs 24-bit consistently.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/vt.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/vt
dark and better for bright inputs.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/vt.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index c777f4c91df0..7fcb0ff2dccf 100644
--- a/drivers/tty
Let's keep \e[5m setting this bit, it's a nice way to convey the
information, and it preserves old behaviour. Some other terminals
that can't or don't want to blink do so as well.
Signed-off-by: Adam Borowski
---
drivers/tty/vt/vt.c | 2 ++
1 file changed, 2 insertions(+)
During rework somehow msm8976 num_clk got removed, restore it.
Fixes: d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out interconnect bus clocks")
Signed-off-by: Adam Skladowski
---
drivers/clk/qcom/clk-smd-rpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/clk-s
-bindings patch for Adreno, also separate now
Adam Skladowski (4):
arm64: dts: qcom: msm8976: Add IOMMU nodes
arm64: dts: qcom: msm8976: Add MDSS nodes
arm64: dts: qcom: msm8976: Add Adreno GPU
arm64: dts: qcom: msm8976: Add WCNSS node
arch/arm64/boot/dts/qcom/msm8976.dtsi | 524
Add the nodes describing the apps and gpu iommu and its context banks
that are found on msm8976 SoCs.
Signed-off-by: Adam Skladowski
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 81 +++
1 file changed, 81 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi
Add MDSS nodes to support displays on MSM8976 SoC.
Signed-off-by: Adam Skladowski
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 274 +-
1 file changed, 270 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi
b/arch/arm64/boot/dts/qcom/msm8976
Add Adreno GPU node.
Signed-off-by: Adam Skladowski
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 65 +++
1 file changed, 65 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi
b/arch/arm64/boot/dts/qcom/msm8976.dtsi
index 6be310079f5b..77670fce9b8f 100644
Add node describing wireless connectivity subsystem.
Signed-off-by: Adam Skladowski
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 104 ++
1 file changed, 104 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi
b/arch/arm64/boot/dts/qcom/msm8976.dtsi
index
501 - 600 of 2101 matches
Mail list logo
