Re: [PATCH RFC] sched: Add a per-thread core scheduling interface(Internet mail)

> On May 21, 2020, at 6:26 AM, Joel Fernandes (Google) > wrote: > > Add a per-thread core scheduling interface which allows a thread to tag > itself and enable core scheduling. Based on discussion at OSPM with > maintainers, we propose a prctl(2) interface accepting values of 0 or 1. > 1 - en

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

Hi, > On Aug 10, 2020, at 9:24 PM, Dietmar Eggemann > wrote: > > On 06/08/2020 17:52, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Aug 6, 2020, at 9:29 PM, Dietmar Eggemann >>> wrote: >>> >>> On 03/08/2020 13:26, benbjiang(蒋彪) wrote: &g

Re: [PATCH RFC v2] sched/fair: simplify the work when reweighting entity(Internet mail)

Hi, > On Aug 11, 2020, at 5:50 PM, Dietmar Eggemann > wrote: > > On 06/08/2020 18:14, Jiang Biao wrote: >> From: Jiang Biao >> >> If a se is on_rq when reweighting entity, all we need should be >> updating the load of cfs_rq, other dequeue/enqueue work could be >> redundant, such as, >> * nr_

Re: [PATCH] sched/fair: Optimize dequeue_task_fair()(Internet mail)

Hi, > On Aug 12, 2020, at 12:55 AM, Dietmar Eggemann > wrote: > > On 11/08/2020 10:43, Jiang Biao wrote: >> Similar optimization as what has been done in commit, >> 7d148be69e3a(sched/fair: Optimize enqueue_task_fair()) >> >> dequeue_task_fair jumps to dequeue_throttle label when cfs_rq_of(se)

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

Hi, > On Aug 11, 2020, at 11:54 PM, Dietmar Eggemann > wrote: > > On 11/08/2020 02:41, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Aug 10, 2020, at 9:24 PM, Dietmar Eggemann >>> wrote: >>> >>> On 06/08/2020 17:52, benbjiang(蒋彪) wrot

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 3, 2020, at 4:16 PM, Dietmar Eggemann wrote: > > On 01/08/2020 04:32, Jiang Biao wrote: >> From: Jiang Biao >> >> No need to preempt when there are only one runable CFS task with >> other IDLE tasks on runqueue. The only one CFS task would always >> be picked in that case. >> >> Sig

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 19, 2020, at 10:55 PM, Vincent Guittot > wrote: > > On Wed, 19 Aug 2020 at 16:27, benbjiang(蒋彪) wrote: >> >> >> >>> On Aug 19, 2020, at 7:55 PM, Dietmar Eggemann >>> wrote: >>> >>> On 19/08/2020 13:05, Vincent

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 20, 2020, at 3:35 PM, Vincent Guittot > wrote: > > On Thu, 20 Aug 2020 at 02:13, benbjiang(蒋彪) wrote: >> >> >> >>> On Aug 19, 2020, at 10:55 PM, Vincent Guittot >>> wrote: >>> >>> On Wed, 19 Aug 2020 at 16:27, b

Re: [PATCH RFC] sched/fair: simplfy the work when reweighting entity

> On Aug 6, 2020, at 12:21 AM, Dietmar Eggemann > wrote: > > On 04/08/2020 09:12, Jiang Biao wrote: >> If a se is on_rq when reweighting entity, all we need should be >> updating the load of cfs_rq, other dequeue/enqueue works could be >> redundant, such as, >> * account_numa_dequeue/account_n

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

Hi, > On Aug 6, 2020, at 9:29 PM, Dietmar Eggemann wrote: > > On 03/08/2020 13:26, benbjiang(蒋彪) wrote: >> >> >>> On Aug 3, 2020, at 4:16 PM, Dietmar Eggemann >>> wrote: >>> >>> On 01/08/2020 04:32, Jiang Biao wrote: >>>>

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 19, 2020, at 6:46 PM, Dietmar Eggemann > wrote: > > On 17/08/2020 14:05, benbjiang(蒋彪) wrote: >> >> >>> On Aug 17, 2020, at 4:57 PM, Dietmar Eggemann >>> wrote: >>> >>> On 14/08/2020 01:55, benbjiang(蒋彪) wrote: >&g

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 19, 2020, at 7:55 PM, Dietmar Eggemann > wrote: > > On 19/08/2020 13:05, Vincent Guittot wrote: >> On Wed, 19 Aug 2020 at 12:46, Dietmar Eggemann >> wrote: >>> >>> On 17/08/2020 14:05, benbjiang(蒋彪) wrote: >>>> >

Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail)

> 在 2019年4月23日，下午4:06，Paul E. McKenney 写道： > > On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote: >> rdp is initialized but never used in synchronize_rcu_expedited(), >> just remove it. >> >> Signed-off-by: Jiang Biao > > I queued and pushed both patches for testing and review, good

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

> On Aug 17, 2020, at 4:57 PM, Dietmar Eggemann > wrote: > > On 14/08/2020 01:55, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Aug 13, 2020, at 2:39 AM, Dietmar Eggemann >>> wrote: >>> >>> On 12/08/2020 05:19, benbjiang(蒋彪) wrote

Re: [RFC PATCH 00/16] Core scheduling v6(Internet mail)

Hi, > On Aug 5, 2020, at 11:57 AM, Li, Aubrey wrote: > > On 2020/8/4 0:53, Joel Fernandes wrote: >> Hi Aubrey, >> >> On Mon, Aug 3, 2020 at 4:23 AM Li, Aubrey wrote: >>> >>> On 2020/7/1 5:32, Vineeth Remanan Pillai wrote: Sixth iteration of the Core-Scheduling feature. Core sc

Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)

Hi, > On Aug 13, 2020, at 2:39 AM, Dietmar Eggemann > wrote: > > On 12/08/2020 05:19, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Aug 11, 2020, at 11:54 PM, Dietmar Eggemann >>> wrote: >>> >>> On 11/08/2020 02:41, benbjiang(蒋彪) wrot

Re: [RFC PATCH 00/16] Core scheduling v6(Internet mail)

> On Aug 13, 2020, at 12:28 PM, Li, Aubrey wrote: > > On 2020/8/13 7:08, Joel Fernandes wrote: >> On Wed, Aug 12, 2020 at 10:01:24AM +0800, Li, Aubrey wrote: >>> Hi Joel, >>> >>> On 2020/8/10 0:44, Joel Fernandes wrote: Hi Aubrey, Apologies for replying late as I was still look

Re: [RFC PATCH 00/16] Core scheduling v6(Internet mail)

> On Aug 14, 2020, at 9:36 AM, Li, Aubrey wrote: > > On 2020/8/14 8:26, benbjiang(蒋彪) wrote: >> >> >>> On Aug 13, 2020, at 12:28 PM, Li, Aubrey wrote: >>> >>> On 2020/8/13 7:08, Joel Fernandes wrote: >>>> On Wed, Aug 1

Re: [RFC PATCH 00/16] Core scheduling v6(Internet mail)

Hi, > On Aug 14, 2020, at 1:18 PM, Li, Aubrey wrote: > > On 2020/8/14 12:04, benbjiang(蒋彪) wrote: >> >> >>> On Aug 14, 2020, at 9:36 AM, Li, Aubrey wrote: >>> >>> On 2020/8/14 8:26, benbjiang(蒋彪) wrote: >>>> >&g

Re: [RFC PATCH 07/16] sched/fair: Fix forced idle sibling starvation corner case(Internet mail)

Hi, > On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: vpillai > > If there is only one long running local task and the sibling is > forced idle, it might not get a chance to run until a schedule > event happens on any cpu in the core. > > So we check for this condition

Re: [RFC PATCH 05/16] sched: Basic tracking of matching tasks(Internet mail)

Hi, perter > On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: Peter Zijlstra > > Introduce task_struct::core_cookie as an opaque identifier for core > scheduling. When enabled; core scheduling will only allow matching > task to be on the core; where idle matches everythin

Re: [RFC PATCH 10/16] sched: Trivial forced-newidle balancer(Internet mail)

Hi, > On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: Peter Zijlstra > > When a sibling is forced-idle to match the core-cookie; search for > matching tasks to fill the core. > > rcu_read_unlock() can incur an infrequent deadlock in > sched_core_balance(). Fix this by u

Re: [RFC PATCH 10/16] sched: Trivial forced-newidle balancer(Internet mail)

> On Jul 20, 2020, at 4:03 PM, Li, Aubrey wrote: > > On 2020/7/20 15:23, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Jul 20, 2020, at 2:06 PM, Li, Aubrey >> <mailto:aubrey...@linux.intel.com>> wrote: >>> >>> On 2020/7/20 12:06, benbj

Re: [RFC PATCH 10/16] sched: Trivial forced-newidle balancer(Internet mail)

> On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: Peter Zijlstra > > When a sibling is forced-idle to match the core-cookie; search for > matching tasks to fill the core. > > rcu_read_unlock() can incur an infrequent deadlock in > sched_core_balance(). Fix this by usi

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 24, 2020, at 7:43 AM, Aubrey Li wrote: > > On Thu, Jul 23, 2020 at 4:28 PM benbjiang(蒋彪) wrote: >> >> Hi, >> >>> On Jul 23, 2020, at 4:06 PM, Li, Aubrey wrote: >>> >>> On 2020/7/23 15:47, benbjiang(蒋彪) wrote: >>>&

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 24, 2020, at 10:05 AM, Li, Aubrey wrote: > > On 2020/7/24 9:26, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Jul 24, 2020, at 7:43 AM, Aubrey Li wrote: >>> >>> On Thu, Jul 23, 2020 at 4:28 PM benbjiang(蒋彪) wrote: >>>>

Re: [RFC PATCH 09/16] sched/fair: core wide cfs task priority comparison(Internet mail)

> On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: Aaron Lu > > This patch provides a vruntime based way to compare two cfs task's > priority, be it on the same cpu or different threads of the same core. > > When the two tasks are on the same CPU, we just need to find

Re: [RFC PATCH 07/16] sched/fair: Fix forced idle sibling starvation corner case(Internet mail)

> On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: vpillai > > If there is only one long running local task and the sibling is > forced idle, it might not get a chance to run until a schedule > event happens on any cpu in the core. > > So we check for this condition d

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, Aubrey, > On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai > wrote: > > From: Aubrey Li > > - Don't migrate if there is a cookie mismatch > Load balance tries to move task from busiest CPU to the > destination CPU. When core scheduling is enabled, if the > task's cookie does

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 22, 2020, at 8:13 PM, Li, Aubrey wrote: > > On 2020/7/22 16:54, benbjiang(蒋彪) wrote: >> Hi, Aubrey, >> >>> On Jul 1, 2020, at 5:32 AM, Vineeth Remanan Pillai >>> wrote: >>> >>> From: Aubrey Li >>> >>>

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 23, 2020, at 9:57 AM, Li, Aubrey wrote: > > On 2020/7/22 22:32, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Jul 22, 2020, at 8:13 PM, Li, Aubrey wrote: >>> >>> On 2020/7/22 16:54, benbjiang(蒋彪) wrote: >>>> Hi, Aubrey, &g

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 23, 2020, at 11:35 AM, Li, Aubrey wrote: > > On 2020/7/23 10:42, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Jul 23, 2020, at 9:57 AM, Li, Aubrey wrote: >>> >>> On 2020/7/22 22:32, benbjiang(蒋彪) wrote: >>>> Hi, >>>>

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 23, 2020, at 1:39 PM, Li, Aubrey wrote: > > On 2020/7/23 12:23, benbjiang(蒋彪) wrote: >> Hi, >>> On Jul 23, 2020, at 11:35 AM, Li, Aubrey wrote: >>> >>> On 2020/7/23 10:42, benbjiang(蒋彪) wrote: >>>> Hi, >>>> >

Re: [RFC PATCH 11/16] sched: migration changes for core scheduling(Internet mail)

Hi, > On Jul 23, 2020, at 4:06 PM, Li, Aubrey wrote: > > On 2020/7/23 15:47, benbjiang(蒋彪) wrote: >> Hi, >> >>> On Jul 23, 2020, at 1:39 PM, Li, Aubrey wrote: >>> >>> On 2020/7/23 12:23, benbjiang(蒋彪) wrote: >>>> Hi,