On Tuesday 22 November 2016 02:19 PM, Ravi Bangoria wrote:
> Hi Anton,
>
> On Tuesday 22 November 2016 02:10 PM, Ravi Bangoria wrote:
>> perf report (with TUI) exits with error when it finds a sample of zero
>> length symbol(i.e. addr == sym->start == sym->end).
with NOTIFY_STOP. Similarly, do_break
also returns without notifying to xmon.
Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
find any perf_event associated with matched watchpoint.
Signed-off-by: Ravi Bangoria
---
arch/powerpc/kernel/hw_breakpoint.c | 4 +++-
1 file chang
Thanks Michael,
On Tuesday 22 November 2016 05:03 PM, Michael Ellerman wrote:
> Ravi Bangoria writes:
>
>> Xmon data-breakpoint feature is broken.
>>
>> Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
>> be called by do_break via notifier c
On Wednesday 14 December 2016 01:06 PM, Ingo Molnar wrote:
> * Alexis Berlemont wrote:
>
>> Hi Masami,
>>
>> Many thanks for your mail.
>>
>> Here is another patch set which tries to fix the points you mentioned:
>>
>> * Skip the arguments containing a constant ($123);
>> * Review the code in c
On Tuesday 24 January 2017 01:52 PM, Ingo Molnar wrote:
> * Ravi Bangoria wrote:
>
>>
>> On Wednesday 14 December 2016 01:06 PM, Ingo Molnar wrote:
>>> * Alexis Berlemont wrote:
>>>
>>>> Hi Masami,
>>>>
>>>> Many thanks f
Hi Alexis,
On Wednesday 14 December 2016 05:37 AM, Alexis Berlemont wrote:
> An sdt probe can be associated with arguments but they were not passed
> to the user probe tracing interface (uprobe_events); this patch adapts
> the sdt argument descriptors according to the uprobe input format.
>
> As t
On Wednesday 14 December 2016 01:06 PM, Ingo Molnar wrote:
> * Alexis Berlemont wrote:
>
>> Hi Masami,
>>
>> Many thanks for your mail.
>>
>> Here is another patch set which tries to fix the points you mentioned:
>>
>> * Skip the arguments containing a constant ($123);
>> * Review the code in c
erf report -i perf.data.powerpc --vmlinux vmlinux.powerpc
Naveen N. Rao (2):
perf annotate: generalize handling of ret instructions
perf annotate: add powerpc support
Ravi Bangoria (4):
perf: Remove unused hist_entry__annotate function
perf annotate: Define macro for arch names
perf annotate: Enab
hist_entry__annotate looks part of API but I don't find any caller
of this function. Removing it.
Signed-off-by: Ravi Bangoria
---
tools/perf/util/annotate.c | 5 -
tools/perf/util/annotate.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf
Define macro for each arch name and use them instead of using arch
name as string.
Signed-off-by: Ravi Bangoria
---
tools/perf/arch/common.c | 36 ++--
tools/perf/arch/common.h | 10 ++
tools/perf/util/unwind-libunwind.c | 5 +++--
3
From: "Naveen N. Rao"
Introduce helper to detect ret instructions and use the same in the tui.
A helper is needed since some architectures such as powerpc have more
than one return instruction.
Signed-off-by: Naveen N. Rao
---
tools/perf/ui/browsers/annotate.c | 20 +---
tools/
From: "Naveen N. Rao"
Powerpc has long list of branch instructions and hardcoding them in table
appears to be error-prone. So, add new function to find instruction
instead of creating table.
Signed-off-by: Naveen N. Rao
Signed-off-by: Ravi Bangoria
---
tools/perf/util/annot
:
$ perf report -i perf.data.powerpc --vmlinux vmlinux.powerpc
Signed-off-by: Ravi Bangoria
---
tools/perf/arch/common.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
index 7da6ac7..93afa60 100644
--- a/tools/perf/arch
on. Please suggest best way to do it.
Signed-off-by: Ravi Bangoria
---
tools/perf/builtin-top.c | 2 +-
tools/perf/ui/browsers/annotate.c | 5 +-
tools/perf/ui/gtk/annotate.c | 6 +-
tools/perf/util/annotate.c| 116 +-
tools/perf/util/
Define macro for each normalized arch name and use them instead
of using arch name as string
Signed-off-by: Ravi Bangoria
---
Changes in v4:
- Moved position of patch
tools/perf/arch/common.c | 36 ++--
tools/perf/arch/common.h | 11
few location. Corrected it.
- Moved position of v3 last patch that define macro for each arch name
v3 link: https://lkml.org/lkml/2016/6/30/99
Naveen N. Rao (1):
perf annotate: add powerpc support
Ravi Bangoria (2):
perf: Define macro for normalized arch names
perf annotate: Enable
every time, first check if list already contain object for that
instruction.
Signed-off-by: Naveen N. Rao
Signed-off-by: Ravi Bangoria
---
Chnages in v4:
- Added support for branch instructions that includes 'ctr'
tools/perf/util/annotate.c | 155 +
annotation work properly, all architecture
instruction tables need to be included in the perf binary. And while
annotating, look for instruction table where perf.data was recorded.
Signed-off-by: Ravi Bangoria
---
Changes in v4:
- __maybe_unused was misplaced at few location. Corrected it
Hi Michael,
On Wednesday 06 July 2016 03:38 PM, Michael Ellerman wrote:
Ravi Bangoria writes:
On Thursday 30 June 2016 11:51 AM, Michael Ellerman wrote:
On Thu, 2016-06-30 at 11:44 +0530, Ravi Bangoria wrote:
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index
On Wednesday 13 July 2016 01:09 PM, Michael Ellerman wrote:
Arnaldo Carvalho de Melo writes:
Em Tue, Jul 12, 2016 at 07:51:46AM +0530, Ravi Bangoria escreveu:
Hi Arnaldo,
On Friday 08 July 2016 02:01 PM, Michael Ellerman wrote:
Ravi Bangoria writes:
On Wednesday 06 July 2016 03:38 PM
Arnaldo, Michael,
I've tested this patchset on ppc64 BE and LE both. Please review this.
-Ravi
On Friday 08 July 2016 10:10 AM, Ravi Bangoria wrote:
Perf can currently only support code navigation (branches and calls) in
annotate when run on the same architecture where perf.data was rec
Thanks Michael for your suggestion.
On Thursday 30 June 2016 11:51 AM, Michael Ellerman wrote:
On Thu, 2016-06-30 at 11:44 +0530, Ravi Bangoria wrote:
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 36a5825..b87eac7 100644
--- a/tools/perf/util/annotate.c
+++ b/tools
Hi Balbir,
On Friday 01 July 2016 06:18 PM, Balbir Singh wrote:
On Fri, 2016-07-01 at 14:13 +0530, Ravi Bangoria wrote:
Thanks Michael for your suggestion.
On Thursday 30 June 2016 11:51 AM, Michael Ellerman wrote:
On Thu, 2016-06-30 at 11:44 +0530, Ravi Bangoria wrote:
diff --git a
Hi Michael,
On Friday 01 July 2016 02:13 PM, Ravi Bangoria wrote:
Thanks Michael for your suggestion.
On Thursday 30 June 2016 11:51 AM, Michael Ellerman wrote:
On Thu, 2016-06-30 at 11:44 +0530, Ravi Bangoria wrote:
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index
Hi Arnaldo,
Sorry for little late replies, I was off last week.
Please find my comments.
On Wednesday 05 October 2016 04:49 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:51PM +0530, Ravi Bangoria escreveu:
>> Change current data structures and function to enable c
On Wednesday 05 October 2016 04:57 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:53PM +0530, Ravi Bangoria escreveu:
>> For jump instructions that does not include target address as direct
>> operand, use raw value for that. This is needed for certain power
On Wednesday 05 October 2016 04:58 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:54PM +0530, Ravi Bangoria escreveu:
>> Current perf is not able to parse jump instruction when second operand
>> contains target address. Arch like powerpc has such instructions.
On Wednesday 05 October 2016 05:01 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:55PM +0530, Ravi Bangoria escreveu:
>> If jump target is outside of function range, perf is not handling it
>> correctly. Especially when target address is lesser than function s
On Wednesday 05 October 2016 05:04 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 21, 2016 at 09:17:56PM +0530, Ravi Bangoria escreveu:
>> From: Kim Phillips
>>
>> For ARM we remove the list that contains non-arm insns, and
>> instead add more maintainable bra
Move arch specific stuff from util/annotate.c to their respective
files in util/annotate directory.
No functionality changes.
Signed-off-by: Ravi Bangoria
---
tools/perf/util/Build | 1 +
tools/perf/util/annotate.c | 259 +++--
tools/perf
On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote:
> On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote:
>> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu:
>>> Move arch specific stuff from util/annotate.c to their respective
>>> files
These encodings will be used in subsequent patch that test
emulate_step for load/store instructions.
Signed-off-by: Ravi Bangoria
---
arch/powerpc/include/asm/ppc-opcode.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/ppc-opcode.h
b/arch/powerpc/include
emulation support for all types of (Normal, Floating Point,
Vector and Vector Scalar) load/store instructions.
- Introduce selftest to test emulate_step for load/store instructions.
Ravi Bangoria (3):
powerpc: Emulation support for load/store instructions on LE
powerpc: Add encoding for couple
: PASS
[0.764349] emulate_step smoke test: stvx : PASS
[0.764575] emulate_step smoke test: lxvd2x : PASS
[0.764788] emulate_step smoke test: stxvd2x: PASS
[0.764997] emulate_step smoke test: complete.
Signed-off-by: Ravi Bangoria
---
arch
emulate_step() uses a number of underlying kernel functions that were
initially not enabled for LE. This has been rectified since. So, fix
emulate_step() for LE for the corresponding instructions.
Reported-by: Anton Blanchard
Signed-off-by: Ravi Bangoria
---
arch/powerpc/lib/sstep.c | 20
Hi Arnaldo,
Can you please review 2nd and 3rd patch.
-Ravi
On Monday 05 December 2016 09:26 PM, Ravi Bangoria wrote:
> For jump instructions that does not include target address as direct
> operand, show the original disassembled line for them. This is needed
> for certain pow
Hi,
Sorry, I replied little late. I see you already included patch in perf/core.
I've tested this patch on powerpc with perf.data and vmlinux shared by Kim.
Looks good to me.
You can add my Tested-by.
-Ravi.
On Wednesday 30 November 2016 08:53 PM, Kim Phillips wrote:
> This is a regex convert
Hi Arnaldo,
Can you please pick this up if it looks good?
-Ravi
On Tuesday 22 November 2016 02:10 PM, Ravi Bangoria wrote:
> perf report (with TUI) exits with error when it finds a sample of zero
> length symbol(i.e. addr == sym->start == sym->end). Actually these are
> valid
Thanks Masami for detailed review.
Please see my comments below.
On Friday 17 March 2017 02:35 PM, Masami Hiramatsu wrote:
> Hi Ravi,
>
> (I avoided to review parser part since it may go to yacc in next version)
>
> On Tue, 14 Mar 2017 20:36:54 +0530
> Ravi Bangoria
On Saturday 18 March 2017 04:44 AM, Masami Hiramatsu wrote:
> The title of this patch seems not correct.
Oops. Sorry about that. Actual title is:
"perf/sdt: Remove stale warning"
Thanks for reporting,
Ravi
> On Tue, 14 Mar 2017 20:36:58 +0530
> Ravi Bangoria wrote:
&g
Thanks Masami for detailed review.
Please see my comments below.
On Saturday 18 March 2017 04:43 AM, Masami Hiramatsu wrote:
> On Tue, 14 Mar 2017 20:36:55 +0530
> Ravi Bangoria wrote:
>
>> }
>> }
>>
>> -del_perf_probe_e
On Wednesday 08 March 2017 02:07 PM, Masami Hiramatsu wrote:
> On Wed, 8 Mar 2017 12:29:07 +0530
> Ravi Bangoria wrote:
>
>> '*ntevs' contains number of elements present in 'tevs' array. If
>> there are no elements in array, 'tevs2' can be dir
s
CPU2 2,69,72,403 cycles
CPU1 2,02,08,327 instructions # 0.34 insn per cycle
CPU2 73,17,123 instructions # 0.12 insn per cycle
1.000989132 seconds time elapsed
Signed-off-by: Ravi Bangoria
---
tools/perf/Documentation/perf-stat.txt | 3 +--
1 file changed, 1 inser
Hi Jin / Arnaldo,
I see a build failure with this patch:
On Friday 17 March 2017 03:12 AM, Jin Yao wrote:
> It would be useful for perf to support a mode to query the
> inline stack for a given callgraph address. This would simplify
> finding the right code in code that does a lot of inlining.
>
Commit 40218daea1db ("perf list: Show SDT and pre-cached events") added
sdt support in perf list, but it missed to update documentation.
Show sdt option in man perf-list.
Signed-off-by: Ravi Bangoria
---
tools/perf/Documentation/perf-list.txt | 4 +++-
1 file changed, 3 insert
SDT marker argument is in N@OP format. N is the size of argument and
OP is the actual assembly operand. OP is arch dependent component and
hence it's parsing logic also should be placed under tools/perf/arch/.
Signed-off-by: Ravi Bangoria
---
tools/perf/arch/x86/util/perf_regs.c
dma_bdrv_io: 8@%rbx 8@%rbp -8@%r14 1@%al
/usr/bin/postgres
buffer__read__done: ... -1@-bash -1@%al
buffer__read__start: ... -1@%al
Signed-off-by: Ravi Bangoria
---
tools/perf/arch/x86/util/perf_regs.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/perf/arch/x86/util
SDT marker argument is in N@OP format. Here OP is arch dependent
component. Add powerpc logic to parse OP and convert it to uprobe
compatible format.
Signed-off-by: Ravi Bangoria
---
tools/perf/arch/powerpc/util/perf_regs.c | 111 +++
1 file changed, 111 insertions
t argument parser.[1]
v1: https://lkml.org/lkml/2017/2/2/145
I've prepared this patchset on top of acme/perf/core.
[1] https://lkml.org/lkml/2017/3/21/427
Ravi Bangoria (3):
perf/sdt/x86: Add renaming logic for (missing) 8 bit registers
perf/sdt/x86: Move OP parser to tools/perf/arch/x86
On Wednesday 15 March 2017 06:46 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 15, 2017 at 01:03:31PM +0100, Jiri Olsa escreveu:
>> On Tue, Mar 14, 2017 at 08:36:54PM +0530, Ravi Bangoria wrote:
>>> +++ b/tools/perf/builtin-record.c
>>> +static int record__parse
Hi Masami,
On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote:
> On Tue, 14 Mar 2017 20:36:51 +0530
> Ravi Bangoria wrote:
>
>> Changes in v5:
>> - Patch 2/7 is new. New option introduced in this patch helps to pass
>> custome data from builtin-*.c to li
I don't see any user of this function. This function was being copied
to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
print logic into cmd_probe()"). Since then it has became stale.
Signed-off-by: Ravi Bangoria
---
tools/perf/util/probe-event.c | 18 --
Fixes: 42bba263eb58 ("perf probe: Allow wildcard for cached events")
Signed-off-by: Ravi Bangoria
---
tools/perf/util/probe-event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 28fb62c..4f9d6ee
Thanks Masami for the review,
On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote:
> On Wed, 8 Mar 2017 12:29:08 +0530
> Ravi Bangoria wrote:
>
>> I don't see any user of this function. This function was being copied
>> to tools/perf/builtin-probe.c by commit
e-event.c.
- Couple of other changes as Masami has suggested in v4 review.
Note: Patchset is prepared on top of acme/perf/core.
v4 link: https://lkml.org/lkml/2017/3/6/565
[1] https://lkml.org/lkml/2017/2/7/59
[2] https://lkml.org/lkml/2016/5/3/810
Hemant Kumar (1):
perf/sdt: Di
Factor out the SDT event name checking routine as is_sdt_event().
Signed-off-by: Ravi Bangoria
---
tools/perf/util/parse-events.h | 20
tools/perf/util/probe-event.c | 9 +
2 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/parse
Perf was showing warning if user tries to record sdt event without
creating a probepoint. Now we are allowing direct record on sdt
events, remove this stale warning/hint.
Signed-off-by: Ravi Bangoria
---
tools/lib/api/fs/tracing_path.c | 17 -
1 file changed, 4 insertions(+), 13
:*
Warning: Recording on 2 occurrences of sdt_libpthread:*
$ sudo ./perf evlist
sdt_libpthread:mutex_release_3
sdt_libpthread:mutex_release_1
Signed-off-by: Ravi Bangoria
---
tools/perf/util/probe-event.c | 186 --
tools/perf/util/probe-event.h | 4
only them.
Hint: Please use 'perf probe -d sdt_libpthread:*' to allow record on all
events.
$ sudo ./perf evlist
sdt_libpthread:mutex_release_3
sdt_libpthread:mutex_release_2
sdt_libpthread:mutex_release_1
sdt_libpthread:mutex_release
Signed-off-by: Ravi Bangoria
4/libpthread-2.24.so:0xb126
$ sudo ./perf record -a -e sdt_libpthread:mutex_release
Matching event(s) from uprobe_events:
sdt_libpthread:mutex_release 0xb126@/usr/lib64/libpthread-2.24.so
Use 'perf probe -d ' to delete event(s).
Signed-off-by: Ravi Bangoria
---
pthread:mutex_entry_1
Error: sdt_libpthread:mutex_entry_1 not found in the cache
invalid or unsupported event: 'sdt_libpthread:mutex_entry_1'
Signed-off-by: Hemant Kumar
Signed-off-by: Ravi Bangoria
---
tools/perf/builtin-record.c| 27 ++-
tools/perf/util/parse-events.
Add an option macro that is the same as OPT_CALLBACK_OPTARG except
that the argument is not optional.
Signed-off-by: Ravi Bangoria
---
tools/lib/subcmd/parse-options.h | 4
1 file changed, 4 insertions(+)
diff --git a/tools/lib/subcmd/parse-options.h b/tools/lib/subcmd/parse-options.h
On Tuesday 07 February 2017 08:25 AM, Masami Hiramatsu wrote:
> On Thu, 2 Feb 2017 16:41:38 +0530
> Ravi Bangoria wrote:
>
>> The v5 patchset for sdt marker argument support for x86 [1] has
>> couple of issues. For example, it still has x86 specific code
>> in gen
Perf was showing warning if user tries to record sdt event without
creating a probepoint. Now we are allowing direct record on sdt
events, remove this stale warning/hint.
Signed-off-by: Ravi Bangoria
---
tools/lib/api/fs/tracing_path.c | 17 -
1 file changed, 4 insertions(+), 13
:*
Warning: Recording on 2 occurrences of sdt_libpthread:*
$ sudo ./perf evlist
sdt_libpthread:mutex_release_3
sdt_libpthread:mutex_release_1
Signed-off-by: Ravi Bangoria
---
tools/perf/util/probe-event.c | 58 +-
tools/perf/util/probe-event.h | 5 ++
tools/perf/util/probe
d:mutex_entry_1
Error: sdt_libpthread:mutex_entry_1 not found in the cache
invalid or unsupported event: 'sdt_libpthread:mutex_entry_1'
Signed-off-by: Hemant Kumar
Signed-off-by: Ravi Bangoria
---
tools/perf/builtin-record.c| 24
tools/perf/perf.h |
4/libpthread-2.24.so:0xb126
$ sudo ./perf record -a -e sdt_libpthread:mutex_release
Matching event(s) from uprobe_events:
sdt_libpthread:mutex_release 0xb126@/usr/lib64/libpthread-2.24.so
Use 'perf probe -d ' to delete event(s).
Signed-off-by: Ravi Bangoria
---
//lkml.org/lkml/2017/2/24/27
[1] https://lkml.org/lkml/2017/2/7/59
[2] https://lkml.org/lkml/2016/5/3/810
Hemant Kumar (1):
perf/sdt: Directly record SDT events with 'perf record'
Ravi Bangoria (6):
perf/sdt: Introduce util func is_sdt_event()
perf/sdt: Allow recording of existing
User may ask for multiple events in the same record command like,
perf record -a -e sdt_1:* -e sdt_2:*
If sdt_1:* events are already added to uprobe_events and sdt_2:*
event parsing fails, clean sdt_1:* events from uprobe_events.
Signed-off-by: Ravi Bangoria
---
tools/perf/builtin-record.c
Factor out the SDT event name checking routine as is_sdt_event().
Signed-off-by: Ravi Bangoria
---
tools/perf/util/parse-events.h | 12
tools/perf/util/probe-event.c | 9 +
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/parse-events.h b
only them.
Hint: Please use 'perf probe -d sdt_libpthread:*' to allow record on all
events.
$ sudo ./perf evlist
sdt_libpthread:mutex_release_3
sdt_libpthread:mutex_release_2
sdt_libpthread:mutex_release_1
sdt_libpthread:mutex_release
Signed-off-by: Ravi Bangoria
On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote:
> Hi Ravi,
>
>> emulate_step() uses a number of underlying kernel functions that were
>> initially not enabled for LE. This has been rectified since. So, fix
>> emulate_step() for LE for the corresponding instructions.
> Thanks. Should
On Thursday 03 November 2016 03:18 PM, Michael Ellerman wrote:
> Ravi Bangoria writes:
>
>> On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote:
>>> Hi Ravi,
>>>
>>>> emulate_step() uses a number of underlying kernel functions that were
>&g
On Friday 04 November 2016 07:37 AM, Andrew Donnellan wrote:
> On 03/11/16 21:27, Ravi Bangoria wrote:
>> Yes, kernel-space hw-breakpoint feature is broken on LE without this.
>
> Is there any actual user-visible feature that depends on this, or is this
> solely for debuggi
On Sunday 06 November 2016 01:01 AM, Anton Blanchard wrote:
> Hi,
>
>> kprobe, uprobe, hw-breakpoint and xmon are the only user of
>> emulate_step.
>>
>> Kprobe / uprobe single-steps instruction if they can't emulate it, so
>> there is no problem with them. As I mention, hw-breakpoint is broken.
Thank you Brendan for reviewing,
On Wednesday 01 March 2017 10:34 AM, Brendan Gregg wrote:
> On Tue, Feb 28, 2017 at 2:31 PM, Brendan Gregg
> wrote:
>> G'Day Ravi,
>>
> [...]
>> Now retrying perf:
>>
>> # ./perf record -e sdt_node:http__server__request -a
>> ^C[ perf record: Woken up 1 times to w
Thanks Arnaldo,
I'm working on this but it's taking bit longer time. Will post out a patch
within
few days.
Ravi
On Monday 20 February 2017 07:41 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 20, 2017 at 04:31:50PM +0530, Ravi Bangoria escreveu:
>> Thanks Ingo,
>>
Hi Taeung,
On Wednesday 22 February 2017 03:38 PM, Taeung Song wrote:
> + INIT_LIST_HEAD(¬es->src->code);
> +
> + while (!feof(file)) {
> + int nr;
> + char *c, *parsed_line;
> + struct source_code *code;
> +
> + if (getline(&line, &len, file
No Functionality changes.
Signed-off-by: Ravi Bangoria
---
tools/perf/util/probe-event.c | 9 +
tools/perf/util/util.c| 12
tools/perf/util/util.h| 2 ++
3 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools
-d sdt_libpthread:mutex_entry*' to allow
record on all events.
But no such warning for 'sdt_libpthread:mutex_entry_1'.
$ perf record -a -e sdt_libpthread:mutex_entry_1
Matching event(s) from uprobe_events:
sdt_libpthread:mutex_entry_1 0xbcbb@/usr/lib64/l
t were
written to uprobe_events file for this session. After finishing the
record session, it removes the events from the uprobe_events file
using the maintained name list.
Signed-off-by: Hemant Kumar
Signed-off-by: Ravi Bangoria
---
tools/lib/api/fs/tracing_path.c | 17 +-
tools/perf/builtin-p
$ perf evlist
sdt_libpthread:mutex_entry
sdt_libpthread:mutex_entry_1
Note:
- This is no way a proper patch. Sending this RFC to get thoughts on the
idea.
- This is Hemant's patch[3] rebased to acme/perf/core, with few changes
to disable 'perf probe' on SD
patch of v1 into one patch, as suggested by Naveen
v1 link:
https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg110671.html
Ravi Bangoria (2):
powerpc: Emulation support for load/store instructions on LE
powerpc: emulate_step tests for load/store instructions
arch/powerpc/include
emulate_step() uses a number of underlying kernel functions that were
initially not enabled for LE. This has been rectified since. So, fix
emulate_step() for LE for the corresponding instructions.
Reported-by: Anton Blanchard
Signed-off-by: Ravi Bangoria
---
arch/powerpc/lib/sstep.c | 20
: PASS
[0.764349] emulate_step smoke test: stvx : PASS
[0.764575] emulate_step smoke test: lxvd2x : PASS
[0.764788] emulate_step smoke test: stxvd2x: PASS
[0.764997] emulate_step smoke test: complete.
Signed-off-by: Ravi Bangoria
---
arch
Hi Michael,
Can you please pull this patch.
Thanks,
Ravi
On Tuesday 22 November 2016 02:55 PM, Ravi Bangoria wrote:
> Xmon data-breakpoint feature is broken.
>
> Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
> be called by do_break via notifier chains m
: PASS
[0.764349] emulate_step smoke test: stvx : PASS
[0.764575] emulate_step smoke test: lxvd2x : PASS
[0.764788] emulate_step smoke test: stxvd2x: PASS
[0.764997] emulate_step smoke test: complete.
Signed-off-by: Ravi Bangoria
---
arch
emulate_step() uses a number of underlying kernel functions that were
initially not enabled for LE. This has been rectified since. So, fix
emulate_step() for LE for the corresponding instructions.
Reported-by: Anton Blanchard
Signed-off-by: Ravi Bangoria
---
arch/powerpc/lib/sstep.c | 20
On Tuesday 14 February 2017 02:17 PM, Naveen N. Rao wrote:
> On 2017/02/14 01:32PM, Ravi Bangoria wrote:
>> emulate_step() uses a number of underlying kernel functions that were
>> initially not enabled for LE. This has been rectified since. So, fix
>> emulate_step() for LE
/next. No functionality changes.
v2 link:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1332638.html
Ravi Bangoria (2):
powerpc: Emulation support for load/store instructions on LE
powerpc: emulate_step tests for load/store instructions
arch/powerpc/include/asm/ppc-opcode.h
Thanks Michael,
On Tuesday 14 February 2017 03:50 PM, Michael Ellerman wrote:
> Ravi Bangoria writes:
>
>> emulate_step() uses a number of underlying kernel functions that were
>> initially not enabled for LE. This has been rectified since.
> When exactly? ie. which commi
On Tuesday 14 February 2017 04:16 PM, Michael Ellerman wrote:
> Ravi Bangoria writes:
>
>> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
>> index 0e649d7..ddc879d 100644
>> --- a/arch/powerpc/lib/Makefile
>> +++ b/arch/powerpc/lib/Mak
() for selftest
- Makefile changes
v3 link:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1332686.html
Ravi Bangoria (2):
powerpc: Emulation support for load/store instructions on LE
powerpc: emulate_step tests for load/store instructions
arch/powerpc/include/asm/ppc
: PASS
[0.764349] emulate_step smoke test: stvx : PASS
[0.764575] emulate_step smoke test: lxvd2x : PASS
[0.764788] emulate_step smoke test: stxvd2x: PASS
[0.764997] emulate_step smoke test: complete.
Signed-off-by: Ravi Bangoria
---
arch
emulate_step() uses a number of underlying kernel functions that were
initially not enabled for LE. This has been rectified since. So, fix
emulate_step() for LE for the corresponding instructions.
Reported-by: Anton Blanchard
Signed-off-by: Ravi Bangoria
---
arch/powerpc/lib/sstep.c | 20
On Monday 20 February 2017 12:38 PM, Ingo Molnar wrote:
> * Ravi Bangoria wrote:
>
>> All events from 'perf list', except SDT events, can be directly recorded
>> with 'perf record'. But, the flow is little different for SDT events.
>> Probe point f
Thanks Ingo,
On Monday 20 February 2017 02:12 PM, Ingo Molnar wrote:
> * Ravi Bangoria wrote:
>
>> What should be the behavior of the tool? Should it record only one
>> 'sdt_libpthread:mutex_entry' which exists in uprobe_events? Or it
>> should record all the
Looks like I've older address of Masami(masami.hiramatsu...@hitachi.com) in my
database.
Adding To: mhira...@kernel.org
-Ravi
On Friday 24 February 2017 01:13 PM, Ravi Bangoria wrote:
> All events from 'perf list', except SDT events, can be directly recorded
> with &#
Thanks Masami for the review.
Please find my replies to your comments.
On Tuesday 28 February 2017 11:15 AM, Masami Hiramatsu wrote:
> On Fri, 24 Feb 2017 13:13:25 +0530
> Ravi Bangoria wrote:
>
>> After invoking 'perf record', behind the scenes, it checks whether
>
Thanks Masami for the review.
On Tuesday 07 February 2017 08:41 AM, Masami Hiramatsu wrote:
> On Thu, 2 Feb 2017 16:41:41 +0530
> Ravi Bangoria wrote:
>
>> SDT marker argument is in N@OP format. N is the size of argument and
>> OP is the actual assembly operand. OP is arc
401 - 500 of 837 matches
Mail list logo
