Hi Masami, On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote: > On Tue, 14 Mar 2017 20:36:51 +0530 > Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com> wrote: > >> Changes in v5: >> - Patch 2/7 is new. New option introduced in this patch helps to pass >> custome data from builtin-*.c to libperf. >> >> - All direct callbacks from libelf to builtin-record.c is removed. >>
Minor correction.. s/libelf/libperf/ >> - Merged 2nd and 4th patch of v4 into patch 2 of v5. s/patch 2 of v5/patch 3 of v5/ >> >> - Moved all functions from util/probe-file.c to util/probe-event.c >> which operates on perf_probe_event. >> >> - Made free_sdt_list() static as it's only used inside util/probe-event.c. >> >> - Couple of other changes as Masami has suggested in v4 review. > Hi Ravi, > Could you also describe which patches are updated? It seems 1/7 is not > modified, correct? Let me list a patch-wise brief changelog. patch 1/7:- Introduced dummy version of is_sdt_event() which always return false if !HAVE_LIBELF_SUPPORT. patch 2/7: - is new. A new option introduced in this patch helps to passcustom data from builtin-*.c to libperf. patch 3/7: - Removed direct calls from libperf to builtin-record.c which was used to prepare record.sdt_event_list. Instead pass list to libperf and let libperf manage it. - Introduce new wrapper func record__parse_events_option() that can differentiate between sdt and other events while parsing them in perf record. - Moved all functions from util/probe-file.c to util/probe-event.c which operates on perf_probe_event. - Merged 2nd and 4th patch of v4 into this patch. - Made free_sdt_list() static as it's only used inside util/probe-event.c. patch 4/7:- Removed direct calls from libperf to builtin-record.c which was used to prepare record.sdt_event_list. Instead pass list to libperf and let libperf manage it. - Moved all functions from util/probe-file.c to util/probe-event.c which operates on perf_probe_event. patch 5/7: No changes patch 6/7: No changes patch 7/7: No changes Let me know if you need more details. Thanks, Ravi