Re: [Regression] wifi problems since tg3 started throwing rcu stall warnings

2024-11-08 Thread Paul E. McKenney
On Fri, Nov 08, 2024 at 02:46:16PM +0100, Frederic Weisbecker wrote: > Le Fri, Nov 08, 2024 at 12:29:40AM +0800, Mingcong Bai a écrit : > > Hi Frederic, > > > > > > > > > Sorry for the lag, I still don't understand how this specific commit > > > can produce this issue. Can you please retry with

[PATCH] mac802154: add a check for slave data list before delete

2024-11-08 Thread Lizhi Xu
syzkaller reported a corrupted list in ieee802154_if_remove. [1] Remove an IEEE 802.15.4 network interface after unregister an IEEE 802.15.4 hardware device from the system. CPU0CPU1 genl_family_rcv_msg_doit

Re: [PATCH] static_call: Handle module init failure correctly in static_call_del_module()

2024-11-08 Thread Daniel Gomez
; CONFIG_MODULE_UNLOAD is not built in. >> >> That's exactly the other extreme case I fear for. >> >>> So the only thing we can do then is a big fat warning telling >>> set_memory_ro() on ro_after_init memory has failed ? >> >> I suspect this is more

LKFT CI: improving Networking selftests results when validating stable kernels

2024-11-08 Thread Matthieu Baerts
Hello LKFT maintainers, CI operators, First, I would like to say thank you to the people behind the LKFT project for validating stable kernels (and more), and including some Network selftests in their tests suites. A lot of improvements around the networking kselftests have been done this year. A

[PATCH bpf-next/net 0/5] bpf: Add mptcp_subflow bpf_iter support

2024-11-08 Thread Matthieu Baerts (NGI0)
| 129 - tools/testing/selftests/bpf/progs/mptcp_bpf.h | 10 ++ .../testing/selftests/bpf/progs/mptcp_bpf_iters.c | 64 ++ 5 files changed, 308 insertions(+), 7 deletions(-) --- base-commit: 141b4d6a8049cecdc8124f87e044b83a9e80730d change-id: 20241108-bpf-next-net-mptcp-bpf_ite

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Willem de Bruijn
Joe Damato wrote: > On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > > Joe Damato wrote: > > > Add an epoll busy poll test using netdevsim. > > > > > > This test is comprised of: > > > - busy_poller (via busy_poller.c) > > > - busy_poll_test.sh which loads netdevsim, sets up

Re: [PATCH RFC v3 4/4] module: refactor ro_after_init failure path

2024-11-08 Thread Luis Chamberlain
On Fri, Nov 08, 2024 at 05:12:16PM +0100, Daniel Gomez via B4 Relay wrote: > From: Daniel Gomez > > When ro_after_init fails, we need to unload the module. > > Rename the goto tag to fail_ro_after_init to make it more clear and try > to check for dependencies, stop the module and call the exit f

Re: [PATCH 2/3] libbpf: Remove powerpc prefix from syscall function names

2024-11-08 Thread Andrii Nakryiko
On Sun, Nov 3, 2024 at 9:00 PM Saket Kumar Bhaskar wrote: > > Since commit 94746890202cf ("powerpc: Don't add __powerpc_ prefix to > syscall entry points") drops _powerpc prefix to syscall entry points, > even though powerpc now supports syscall wrapper, so /proc/kallsyms > have symbols for syscal

Re: [PATCH net-next v11 05/23] ovpn: keep carrier always on

2024-11-08 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn interface will keep carrier always on and let the user decide when an interface should be considered disconnected. This way, even if an ovpn interface is not connected to any peer, it can still retain all IPs and routes and thus prevent any d

[PATCH net-next v9 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Joe Damato
Add an epoll busy poll test using netdevsim. This test is comprised of: - busy_poller (via busy_poller.c) - busy_poll_test.sh which loads netdevsim, sets up network namespaces, and runs busy_poller to receive data and socat to send data. The selftest tests two different scenarios: - bus

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Joe Damato
On Fri, Nov 08, 2024 at 12:47:16PM -0500, Willem de Bruijn wrote: > Joe Damato wrote: > > On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > > > Joe Damato wrote: [...] > > > > > > Nice test. > > > > > > Busy polling does not affect data integrity. Is the goal of this test > >

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Joe Damato
On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > Joe Damato wrote: [...] > > diff --git a/tools/testing/selftests/net/busy_poller.c > > b/tools/testing/selftests/net/busy_poller.c > > new file mode 100644 > > index ..8d8aa9e5939a > > --- /dev/null > > +++ b/tools/t

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Joe Damato
On Fri, Nov 08, 2024 at 12:47:16PM -0500, Willem de Bruijn wrote: > Joe Damato wrote: > > On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > > > Joe Damato wrote: > > > > Add an epoll busy poll test using netdevsim. > > > > > > > > This test is comprised of: > > > > - busy_polle

Re: [PATCH] kselftest/arm64: Fix build with stricter assemblers

2024-11-08 Thread Catalin Marinas
On Fri, Nov 08, 2024 at 03:27:58PM +, Catalin Marinas wrote: > On Fri, Nov 08, 2024 at 03:20:46PM +, Mark Brown wrote: > > While some assemblers (including the LLVM assembler I mostly use) will > > happily accept SMSTART as an instruction by default others, specifically > > gas, require tha

Re: [PATCH] kselftest/arm64: Fix build with stricter assemblers

2024-11-08 Thread Mark Brown
On Fri, Nov 08, 2024 at 03:29:37PM +, Catalin Marinas wrote: > On Fri, Nov 08, 2024 at 03:27:58PM +, Catalin Marinas wrote: > > > - smstart > > > + smstart_za > > And is smstop ok for assemblers? I think I got the error first on > > smstop with my toolchain. > Ah, we already have a macro

Re: [PATCH] static_call: Handle module init failure correctly in static_call_del_module()

2024-11-08 Thread Luis Chamberlain
+ Other new module maintainers On Fri, Nov 08, 2024 at 09:12:03AM +0100, Christophe Leroy wrote: > Hi Luis, > > Le 24/09/2024 à 09:22, Mike Rapoport a écrit : > > On Thu, Sep 19, 2024 at 02:53:34AM -0700, Luis Chamberlain wrote: > > > On Fri, Sep 06, 2024 at 04:24:56PM -0700, Luis Chamberlain wro

[PATCH bpf-next/net 5/5] selftests/bpf: Add mptcp_subflow bpf_iter subtest

2024-11-08 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds a "cgroup/getsockopt" program "iters_subflow" to test the newly added mptcp_subflow bpf_iter. Export mptcp_subflow helpers bpf_iter_mptcp_subflow_new/_next/_destroy, bpf_mptcp_sock_acquire/_release and other helpers into bpf_experimental.h. Use bpf_mptcp_sock_

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Joe Damato
On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > Joe Damato wrote: > > Add an epoll busy poll test using netdevsim. > > > > This test is comprised of: > > - busy_poller (via busy_poller.c) > > - busy_poll_test.sh which loads netdevsim, sets up network namespaces, > > and

[PATCH] kselftest/arm64: Fix build with stricter assemblers

2024-11-08 Thread Mark Brown
- smstart + smstart_za ret endfunction --- base-commit: 95ad089d464da2a4cd4511fb077f25994104c8f1 change-id: 20241108-arm64-selftest-asm-error-d78570e50b3b Best regards, -- Mark Brown

Re: [PATCH] kselftest/arm64: Fix build with stricter assemblers

2024-11-08 Thread Catalin Marinas
On Fri, Nov 08, 2024 at 03:20:46PM +, Mark Brown wrote: > While some assemblers (including the LLVM assembler I mostly use) will > happily accept SMSTART as an instruction by default others, specifically > gas, require that any architecture extensions be explicitly enabled. > The assembler SME

[PATCH RFC v3 1/4] module: remove module_deallocate() unused param

2024-11-08 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez The module_deallocate() function no longer requires the struct load_info parameter as of commit 48fd11880b5ef04270be8a87d9a9a9ee2fdae338 ("module: Fix performance regression on modules with large symbol tables"). This commit removes the now-unused parameter. No functional chan

[PATCH RFC v3 0/4] module: refactor ro_after_init failure path

2024-11-08 Thread Daniel Gomez via B4 Relay
module: avoid double ref drop on ro_after_init failure module: update state and release reference under lock module: refactor ro_after_init failure path kernel/module/main.c | 22 ++---- 1 file changed, 14 insertions(+), 8 deletions(-) --- base-commit: c39901c21cda246f967a4d1dc79ae349488fc4de change-id: 20241108-modules-ro_after_init-0f16f0b4daa2 Best regards, -- Daniel Gomez

[PATCH RFC v3 2/4] module: avoid double ref drop on ro_after_init failure

2024-11-08 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Ensure the module reference is only dropped once in case we fail at MOD_RO_AFTER_INIT case. Signed-off-by: Daniel Gomez --- kernel/module/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index e0b2a8d9

[PATCH RFC v3 4/4] module: refactor ro_after_init failure path

2024-11-08 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez When ro_after_init fails, we need to unload the module. Rename the goto tag to fail_ro_after_init to make it more clear and try to check for dependencies, stop the module and call the exit function. This allows to unload the module if ro_after_init fails. This fixes the follo

[PATCH RFC v3 3/4] module: update state and release reference under lock

2024-11-08 Thread Daniel Gomez via B4 Relay
From: Daniel Gomez Ensure the module state change and reference drop operations are performed within module_mutex to prevent potential race conditions in the failure path. Signed-off-by: Daniel Gomez --- kernel/module/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [RFC] module: Strict per-modname namespaces

2024-11-08 Thread Peter Zijlstra
On Fri, Nov 08, 2024 at 04:28:58PM +0100, H. Peter Anvin wrote: > >@@ -1700,11 +1715,7 @@ static void check_exports(struct module *mod) > > s->crc_valid = exp->crc_valid; > > s->crc = exp->crc; > > > >-basename = strrchr(mod->name, '/'); > >-if (base

Re: [PATCH] static_call: Handle module init failure correctly in static_call_del_module()

2024-11-08 Thread Daniel Gomez
On Fri Nov 8, 2024 at 4:49 PM CET, Luis Chamberlain wrote: > + Other new module maintainers > > On Fri, Nov 08, 2024 at 09:12:03AM +0100, Christophe Leroy wrote: >> Hi Luis, >> >> Le 24/09/2024 à 09:22, Mike Rapoport a écrit : >> > On Thu, Sep 19, 2024 at 02:53:34AM -0700, Luis Chamberlain wrote:

Re: [RFC] module: Strict per-modname namespaces

2024-11-08 Thread H. Peter Anvin
On November 6, 2024 8:02:40 PM GMT+01:00, Peter Zijlstra wrote: >Hi, > >I've been wanting $topic for a while, and having just stumbled into the >whole namespace thing by accident, I figured I'd give it a go, most if >the hard parts seem to have already been done. > >It reserves and disallows impo

[PATCH bpf-next/net 3/5] bpf: Acquire and release mptcp socket

2024-11-08 Thread Matthieu Baerts (NGI0)
From: Geliang Tang The KF_TRUSTED_ARGS flag is used for bpf_iter_mptcp_subflow_new, it indicates that the all pointer arguments are valid. It's necessary to add a KF_ACQUIRE helper to get valid "msk". This patch adds bpf_mptcp_sock_acquire() and bpf_mptcp_sock_release() helpers for this. Increas

[PATCH bpf-next/net 2/5] bpf: Add mptcp_subflow bpf_iter

2024-11-08 Thread Matthieu Baerts (NGI0)
From: Geliang Tang It's necessary to traverse all subflows on the conn_list of an MPTCP socket and then call kfunc to modify the fields of each subflow. In kernel space, mptcp_for_each_subflow() helper is used for this: mptcp_for_each_subflow(msk, subflow) kfunc(subflow);

[PATCH bpf-next/net 4/5] selftests/bpf: More endpoints for endpoint_init

2024-11-08 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch changes ADDR_2 from "10.0.1.2" to "10.0.2.1", and adds two more IPv4 test addresses ADDR_3 - ADDR_4, four IPv6 addresses ADDR6_1 - ADDR6_4. Add a new helper address_init() to initialize all these addresses. Add a new parameter "endpoints" for endpoint_init() to cont

[PATCH bpf-next/net 1/5] bpf: Register mptcp common kfunc set

2024-11-08 Thread Matthieu Baerts (NGI0)
From: Geliang Tang MPTCP helper mptcp_sk() is used to convert struct sock to mptcp_sock. Helpers mptcp_subflow_ctx() and mptcp_subflow_tcp_sock() are used to convert between struct mptcp_subflow_context and sock. They all will be used in MPTCP BPF programs too. This patch defines corresponding w

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-08 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-generated files: - include/uapi/linux/ovpn.h - d

[PATCH] selftests: netfilter: Fix the bug of missing return values

2024-11-08 Thread guanjing
Fixed the bug of some functions were missing return values. Fixes: eff3c558bb7e ("netfilter: ctnetlink: support filtering by zone") Signed-off-by: Guan Jing --- .../testing/selftests/net/netfilter/conntrack_dump_flush.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/sel

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-08 Thread Johan Hovold
On Thu, Nov 07, 2024 at 05:19:19PM +0100, Johan Hovold wrote: > On Tue, Nov 05, 2024 at 10:26:40AM -0800, Chris Lew wrote: > > On 11/4/2024 9:08 PM, Johan Hovold wrote: > > > I naively tried adding a sleep after registering the endpoint, but that > > > is at least not sufficient to trigger the NUL

Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

2024-11-08 Thread Donet Tom
On 11/1/24 19:45, Muhammad Usama Anjum wrote: The test should be skipped if initial conditions aren't fulfilled in the start instead of failing and outputting non-compliant TAP logs. This kind of failure pollutes the results. The initial conditions are: - The test should only execute if /tmp fi

Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

2024-11-08 Thread Donet Tom
On 11/8/24 16:05, Donet Tom wrote: On 11/1/24 19:45, Muhammad Usama Anjum wrote: The test should be skipped if initial conditions aren't fulfilled in the start instead of failing and outputting non-compliant TAP logs. This kind of failure pollutes the results. The initial conditions are: - Th

Re: [RFC] module: Strict per-modname namespaces

2024-11-08 Thread Geert Uytterhoeven
On Thu, Nov 7, 2024 at 6:39 AM Christoph Hellwig wrote: > On Wed, Nov 06, 2024 at 08:02:40PM +0100, Peter Zijlstra wrote: > > It reserves and disallows imports on any "MODULE_${name}" namespace, > > while it implicitly adds the same namespace to every module. > > Ah nice. This is pretty similar t

Re: [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-11-08 Thread Dragos Tatulea
On 07.11.24 22:50, Michael S. Tsirkin wrote: > On Wed, Sep 04, 2024 at 10:11:14AM -0500, Carlos Bilbao wrote: >> From: Carlos Bilbao >> >> Initialize the speed and duplex fields in virtio_net_config to UNKNOWN. >> This is needed because mlx5_vdpa vDPA devices currently do not support the >> VIR

Re: [PATCH] dax: Allow block size > PAGE_SIZE

2024-11-08 Thread Jan Kara
On Fri 08-11-24 01:09:54, Asahi Lina wrote: > On 11/7/24 7:01 PM, Jan Kara wrote: > > On Wed 06-11-24 11:59:44, Dan Williams wrote: > >> Jan Kara wrote: > >> [..] > This WARN still feels like the wrong thing, though. Right now it is the > only thing in DAX code complaining on a page size/

Re: [Regression] wifi problems since tg3 started throwing rcu stall warnings

2024-11-08 Thread Frederic Weisbecker
Le Fri, Nov 08, 2024 at 12:29:40AM +0800, Mingcong Bai a écrit : > Hi Frederic, > > > > > Sorry for the lag, I still don't understand how this specific commit > > can produce this issue. Can you please retry with and without this > > commit > > reverted? > > Just tested v6.12-rc6 with and witho

Re: [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-11-08 Thread Michael S. Tsirkin
On Fri, Nov 08, 2024 at 10:31:58AM +0100, Dragos Tatulea wrote: > > > On 07.11.24 22:50, Michael S. Tsirkin wrote: > > On Wed, Sep 04, 2024 at 10:11:14AM -0500, Carlos Bilbao wrote: > >> From: Carlos Bilbao > >> > >> Initialize the speed and duplex fields in virtio_net_config to UNKNOWN. > >> Th

Re: [PATCH] virtio-fs: Query rootmode during mount

2024-11-08 Thread Miklos Szeredi
On Thu, 7 Nov 2024 at 18:59, Hanna Czenczek wrote: > > Regardless, something smells here: fuse_mount_remove() is only called > > if sb->s_root is set (both plain fuse and virtiofs). The top level > > fuse_mount is added to fc->mounts in fuse_conn_init(), way before > > sb->s_root is set... > > >

Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start

2024-11-08 Thread Muhammad Usama Anjum
On 11/8/24 3:49 PM, Donet Tom wrote: > I think below changes are required. > > iff --git a/tools/testing/selftests/mm/hugetlb_dio.c > b/tools/testing/selftests/mm/hugetlb_dio.c > index 60001c142ce9..4b52106b8124 100644 > --- a/tools/testing/selftests/mm/hugetlb_dio.c > +++ b/tools/testing/selfte

Re: [PATCH RESEND v13 02/12] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

2024-11-08 Thread Linus Walleij
On Mon, Nov 4, 2024 at 5:59 PM Duje Mihanović via B4 Relay wrote: > From: Duje Mihanović > > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > separate pinctrl driver later. > > Reviewed-by: Rob Herring > Acked-by: Linus Walleij > Signed-off-by: Duje Mihanović This patch

Re: [PATCH RESEND v13 03/12] pinctrl: single: add marvell,pxa1908-padconf compatible

2024-11-08 Thread Linus Walleij
On Mon, Nov 4, 2024 at 5:59 PM Duje Mihanović via B4 Relay wrote: > From: Duje Mihanović > > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > separate pinctrl driver later. > > Acked-by: Linus Walleij > Signed-off-by: Duje Mihanović Patch applied for v6.13. Yours, Linus

Re: [PATCH v6 2/5] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process

2024-11-08 Thread Lorenzo Stoakes
On Wed, Oct 30, 2024 at 04:37:37PM +, Lorenzo Stoakes wrote: > On Mon, Oct 28, 2024 at 04:06:07PM +, Lorenzo Stoakes wrote: > > I guess I'll try to adapt that and respin a v7 when I get a chance. > > Hm looking at this draft patch, it seems like a total rework of pidfd's > across the board

Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test

2024-11-08 Thread Willem de Bruijn
Joe Damato wrote: > Add an epoll busy poll test using netdevsim. > > This test is comprised of: > - busy_poller (via busy_poller.c) > - busy_poll_test.sh which loads netdevsim, sets up network namespaces, > and runs busy_poller to receive data and socat to send data. > > The selftest test

[PATCH net-next] net: netconsole: selftests: Check if netdevsim is available

2024-11-08 Thread Breno Leitao
{NSIM_DEV_SYS_NEW} does not exist. Check if CONFIG_NETDEVSIM is enabled" >&2 + exit "${ksft_skip}" + fi + if [ ! -d "${NETCONS_CONFIGFS}" ]; then echo "SKIP: directory ${NETCONS_CONFIGFS} does not exist. Check if N

Re: [PATCH net-next v11 03/23] ovpn: add basic netlink support

2024-11-08 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-generated files: - include/uapi/linux/ovpn.h - d

Re: [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN

2024-11-08 Thread Carlos Bilbao
Hello, On 11/8/24 5:51 AM, Michael S. Tsirkin wrote: > On Fri, Nov 08, 2024 at 10:31:58AM +0100, Dragos Tatulea wrote: >> >> On 07.11.24 22:50, Michael S. Tsirkin wrote: >>> On Wed, Sep 04, 2024 at 10:11:14AM -0500, Carlos Bilbao wrote: From: Carlos Bilbao Initialize the speed and

Re: [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines

2024-11-08 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: Add basic infrastructure for handling ovpn interfaces. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 115 -- drivers/net/ovpn/main.h | 7 +++ drivers/net/ovpn/ovpnstruct.h |