On Fri, Nov 08, 2024 at 03:20:46PM +0000, Mark Brown wrote:
> While some assemblers (including the LLVM assembler I mostly use) will
> happily accept SMSTART as an instruction by default others, specifically
> gas, require that any architecture extensions be explicitly enabled.
> The assembler SME test programs use manually encoded helpers for the new
> instructions but no SMSTART helper is defined, only SM and ZA specific
> variants. Unfortunately the irritators that were just added use plain
> SMSTART so on stricter assemblers these fail to build:
>
> za-test.S:160: Error: selected processor does not support `smstart'
>
> Switch to using SMSTART ZA via the manually encoded smstart_za macro we
> already have defined.
>
> Fixes: d65f27d240bb ("kselftest/arm64: Implement irritators for ZA and ZT")
> Signed-off-by: Mark Brown <broo...@kernel.org>
> ---
> tools/testing/selftests/arm64/fp/za-test.S | 2 +-
> tools/testing/selftests/arm64/fp/zt-test.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/arm64/fp/za-test.S
> b/tools/testing/selftests/arm64/fp/za-test.S
> index
> 95fdc1c1f228221bc812087a528e4b7c99767bba..9c33e13e9dc4a6f084649fe7d0fb838d9171e3aa
> 100644
> --- a/tools/testing/selftests/arm64/fp/za-test.S
> +++ b/tools/testing/selftests/arm64/fp/za-test.S
> @@ -157,7 +157,7 @@ function irritator_handler
>
> // This will reset ZA to all bits 0
> smstop
> - smstart
> + smstart_za
And is smstop ok for assemblers? I think I got the error first on
smstop with my toolchain.
--
Catalin
