Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16]

2021-04-14 Thread Andy Shevchenko
On Wed, Apr 14, 2021 at 08:56:50PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 14, 2021 at 08:47:48PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 14, 2021 at 07:33:38PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Apr 14, 2021 at 08:12:46PM +0300, Alexander Shishkin wrote: ... > > Nothing,

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-14 Thread Jesper Dangaard Brouer
On Wed, 14 Apr 2021 12:50:52 +0100 Matthew Wilcox wrote: > > That said, I think we need to have a quicker fix for the immediate > > issue with 64-bit bit dma_addr on 32-bit arch and the misalignment hole > > it leaves[3] in struct page. In[3] you mention ppc32, does it only > > happens on certai

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-14 Thread Andy Shevchenko
On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > wrote: > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang > > > wrote: > > > > On 2021/4/13 20:26, Geert

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Namhyung Kim
On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu: > > > Hello, > > > > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > > >

Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16]

2021-04-14 Thread Alexander Shishkin
Greg Kroah-Hartman writes: >> Using raw buffer APIs against uuid_t / guid_t. > > So you want to do that, or you do not want to do that? Totally > confused, My understanding is that: 1) generate_random_uuid() use is allegedly bad even though it's in their header, 2) poking directly at the byte a

Re: [PATCH v2] perf beauty: Fix fsconfig generator

2021-04-14 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 14, 2021 at 04:08:12PM -0300, Arnaldo Carvalho de Melo escreveu: > [root@6db6d5ad9661 perf]# tools/perf/trace/beauty/fsconfig.sh > static const char *fsconfig_cmds[] = { > [0] = "SET_FLAG", > [1] = "SET_STRING", > [2] = "SET_BINARY", > [3] = "SET_PATH", > [

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-14 Thread Yu Zhao
On Wed, Apr 14, 2021 at 9:59 AM Rik van Riel wrote: > > On Wed, 2021-04-14 at 08:51 -0700, Andi Kleen wrote: > > >2) It will not scan PTE tables under non-leaf PMD entries that > > > do not > > > have the accessed bit set, when > > > CONFIG_HAVE_ARCH_PARENT_PMD_YOUNG=y. > > > > Thi

Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16]

2021-04-14 Thread Andy Shevchenko
On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote: > Greg Kroah-Hartman writes: > > >> Using raw buffer APIs against uuid_t / guid_t. > > > > So you want to do that, or you do not want to do that? Totally > > confused, > > My understanding is that: > 1) generate_random_uuid() u

[PATCH v7 01/10] coresight: syscfg: Initial coresight system configuration

2021-04-14 Thread Mike Leach
Creates an system management API to allow complex configurations and features to be programmed into a CoreSight infrastructure. A feature is defined as a programming set for a device or class of devices. A configuration is a set of features across the system that are enabled for a trace session.

[PATCH v7 00/10] CoreSight configuration management; ETM strobing

2021-04-14 Thread Mike Leach
This patchset introduces initial concepts in CoreSight system configuration management support. to allow more detailed and complex programming to be applied to CoreSight systems during trace capture. Configurations consist of 2 elements:- 1) Features - programming combinations for devices, applied

[PATCH v7 02/10] coresight: syscfg: Add registration and feature loading for cs devices

2021-04-14 Thread Mike Leach
API for individual devices to register with the syscfg management system is added. Devices register with matching information, and any features or configurations that match will be loaded into the device. The feature and configuration loading is extended so that on load these are loaded into any

[PATCH v7 04/10] coresight: etm-perf: update to handle configuration selection

2021-04-14 Thread Mike Leach
Loaded coresight configurations are registered in the cs_etm\events sub directory. This extends the etm-perf code to handle these registrations, and the cs_syscfg driver to perform the registration on load. Signed-off-by: Mike Leach Reviewed-by: Mathieu Poirier --- .../hwtracing/coresight/cores

[PATCH v7 03/10] coresight: config: Add configuration and feature generic functions

2021-04-14 Thread Mike Leach
Adds a set of generic support functions that allow devices to set and save features values on the device, and enable and disable configurations. Additional functions for other common operations including feature reset. Signed-off-by: Mike Leach Reviewed-by: Mathieu Poirier --- drivers/hwtracin

[PATCH v7 07/10] coresight: etm4x: Add complex configuration handlers to etmv4

2021-04-14 Thread Mike Leach
Adds in handlers to allow the ETMv4 to use the complex configuration support. Features and configurations can be loaded and selected in the device. Signed-off-by: Mike Leach Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/Makefile | 3 +- .../hwtracing/coresight/coresigh

[PATCH v7 05/10] coresight: syscfg: Add API to activate and enable configurations

2021-04-14 Thread Mike Leach
Configurations are first activated, then when any coresight device is enabled, the active configurations are checked and any matching one is enabled. This patch provides the activation / enable API. Signed-off-by: Mike Leach Reviewed-by: Mathieu Poirier --- .../hwtracing/coresight/coresight-co

[PATCH v7 06/10] coresight: etm-perf: Update to activate selected configuration

2021-04-14 Thread Mike Leach
Add calls to activate the selected configuration as perf starts and stops the tracing session. Signed-off-by: Mike Leach Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm-perf.c | 14 +- drivers/hwtracing/coresight/coresight-et

[PATCH v7 09/10] coresight: syscfg: Add initial configfs support

2021-04-14 Thread Mike Leach
Adds configfs subsystem and attributes to the configuration manager to enable the listing of loaded configurations and features. The default values of feature parameters can be accessed and altered from these attributes to affect all installed devices using the feature. Signed-off-by: Mike Leach

[PATCH v7 08/10] coresight: config: Add preloaded configurations

2021-04-14 Thread Mike Leach
Preload set of configurations. This patch creates a small set of preloaded configurations and features that are available immediately after coresight has been initialised. The current set provides a strobing feature for ETMv4, that creates a periodic sampling of trace by switching trace generatio

[PATCH v7 10/10] Documentation: coresight: Add documentation for CoreSight config

2021-04-14 Thread Mike Leach
Adds documentation for the CoreSight System configuration manager. Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Signed-off-by: Mike Leach Reviewed-by: Mathieu Poirier --- .../trace/coresight/coresight-config.rst | 244 ++ Documentation/trace/coresight/coresight.rst

Re: [PATCH 05/13] Rust: Compiler builtins crate

2021-04-14 Thread Linus Torvalds
On Wed, Apr 14, 2021 at 11:46 AM wrote: > > We also need a helpers C source file to contain some forwarders > to C macros and inlined functions. For the moment, we only need it > to call the `BUG()` macro, but we will be adding more later. Not being a Rust person, I can only guess based on random

Re: [PATCH v8 0/4] libperf userspace counter access

2021-04-14 Thread Jiri Olsa
On Wed, Apr 14, 2021 at 10:54:08AM -0500, Rob Herring wrote: > I'm resending just the libperf userspace counter access without the Arm > bits so hopefully it can be picked up for 5.13. The Arm bits seem to be > a never ending review filled with long periods of silence. :( > > Prior versions are

Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API

2021-04-14 Thread Uwe Kleine-König
On Wed, Apr 14, 2021 at 02:09:14PM +0200, Clemens Gruber wrote: > Hi Uwe, > > On Tue, Apr 13, 2021 at 09:38:18PM +0200, Uwe Kleine-König wrote: > > Hello Clemens, > > > > On Tue, Apr 13, 2021 at 02:11:38PM +0200, Clemens Gruber wrote: > > > On Mon, Apr 12, 2021 at 10:10:19PM +0200, Uwe Kleine-Kön

Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI

2021-04-14 Thread Geert Uytterhoeven
Hi Andy, On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko wrote: > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > > wrote: > > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Apr 14, 2

Re: [PATCH] arm64: alternatives: Move length validation in alternative_{insn,endif}

2021-04-14 Thread Nick Desaulniers
On Tue, Apr 13, 2021 at 5:09 PM Nathan Chancellor wrote: > > After commit 2decad92f473 ("arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is > set atomically"), LLVM's integrated assembler fails to build entry.S: > > :5:7: error: expected assembly-time absolute expression > .org . - (664b-663b) + (662b-661

[RFC] scripts: kernel-doc: improve parsing for kernel-doc comments syntax

2021-04-14 Thread Aditya Srivastava
Currently kernel-doc does not identify some cases of probable kernel doc comments, for e.g. pointer used as declaration type for identifier, space separated identifier, etc. Some example of these cases in files can be: i)" * journal_t * jbd2_journal_init_dev() - creates and initialises a journal

[PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-14 Thread Randy Dunlap
Currently when using "W=1" with UML builds, there are over 700 warnings like so: CC arch/um/drivers/stderr_console.o cc1: warning: ./arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs] but arch/um/ does not have include/uapi/ at all, so don't include arch/um/include/u

[Outreachy patch] [PATCH v3 1/2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Fabio M. De Francesco
Removed useless led_blink_hdl() prototype and definition. In wlancmds[] the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This change has not unwanted side effects because the code in rtw_cmd.c checks if the function pointer is valid before using it. Reported-by: Julia Lawall

[Outreachy kernel] [PATCH v3 0/2] Remove led_blink_hdl and other related symbols

2021-04-14 Thread Fabio M. De Francesco
Removed useless led_blink_hdl() prototype and definition. Removed struct LedBlink_param. Removed LedBlink entries in rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is not anymore needed. Removed extra blank lines in the two mentioned arrays and changend the numbers set in comm

[Outreachy kernel] [PATCH v3 2/2] staging: rtl8723bs: Remove everything related with LedBlink

2021-04-14 Thread Fabio M. De Francesco
Removed struct LedBlink_param. Removed LedBlink entries in rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is not anymore needed. Removed extra blank lines in the two mentioned arrays and changend the numbers set in comments for having them in line with the shift. Reported-by:

Re: [PATCH 07/13] Rust: Kernel crate

2021-04-14 Thread Linus Torvalds
On Wed, Apr 14, 2021 at 11:47 AM wrote: > > +#[alloc_error_handler] > +fn oom(_layout: Layout) -> ! { > +panic!("Out of memory!"); > +} > + > +#[no_mangle] > +pub fn __rust_alloc_error_handler(_size: usize, _align: usize) -> ! { > +panic!("Out of memory!"); > +} Again, excuse my lack of i

Re: Proposal of improvement for DMA - direct passing of hugepages to the SG list

2021-04-14 Thread Tom Rix
On 4/14/21 4:58 AM, w...@ise.pw.edu.pl wrote: Hi, I'm working both on DMA engines implementations in FPGA and their Linux drivers. Now I need to create an engine that takes the hugepages-backed buffer allocated by the user-space application and passes it to the device. My current solution: h

Re: [PATCH 09/13] Samples: Rust examples

2021-04-14 Thread Linus Torvalds
On Wed, Apr 14, 2021 at 11:47 AM wrote: > > From: Miguel Ojeda > > A set of Rust modules that showcase how Rust modules look like > and how to use the abstracted kernel features. Honestly, I'd like to see a real example. This is fine for testing, but I'd like to see something a bit more real, an

Re: [PATCH 05/13] Rust: Compiler builtins crate

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 9:19 PM Linus Torvalds wrote: > > Not being a Rust person, I can only guess based on random pattern > matching, but this _looks_ like these "panicking intrinsics" panic at > run-time (by calling BUG()). Your pattern matching works well :) > Is there some way these things

Re: [PATCH net-next 1/7] net: korina: Fix MDIO functions

2021-04-14 Thread Andrew Lunn
> +static int korina_mdio_wait(struct korina_private *lp) > +{ > + int timeout = 1000; > + > + while ((readl(&lp->eth_regs->miimind) & 1) && timeout-- > 0) > + udelay(1); > + > + if (timeout <= 0) > + return -1; > + > + return 0; Using readl_poll_timeout_ato

Re: [PATCH net-next 2/7] net: korina: Use devres functions

2021-04-14 Thread Andrew Lunn
> + if (!p) { > printk(KERN_ERR DRV_NAME ": cannot remap registers\n"); > - rc = -ENXIO; > - goto probe_err_out; > + return -ENOMEM; > } Hi Thomas Another possible cleanup would be replacing printk(KERN_ERR with dev_err(), or netdev_err(

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-14 Thread Jesper Dangaard Brouer
On Sat, 10 Apr 2021 21:27:31 +0300 Ilias Apalodimas wrote: > On Sat, Apr 10, 2021 at 10:42:30AM -0700, Shakeel Butt wrote: > > > On Sat, Apr 10, 2021 at 9:16 AM Ilias Apalodimas > > wrote: > > > > > > Hi Matthew > > > > > > On Sat, Apr 10, 2021 at 04:48:24PM +0100, Matthew Wilcox wrote: > >

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-14 Thread Rik van Riel
On Wed, 2021-04-14 at 13:14 -0600, Yu Zhao wrote: > On Wed, Apr 14, 2021 at 9:59 AM Rik van Riel > wrote: > > On Wed, 2021-04-14 at 08:51 -0700, Andi Kleen wrote: > > > >2) It will not scan PTE tables under non-leaf PMD entries > > > > that > > > > do not > > > > have the accessed bit se

Re: [PATCH 09/13] Samples: Rust examples

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 9:34 PM Linus Torvalds wrote: > > Honestly, I'd like to see a real example. This is fine for testing, > but I'd like to see something a bit more real, and a bit less special > than the Android "binder" WIP that comes a few patches later. > > Would there be some kind of real

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-14 Thread Yu Zhao
On Wed, Apr 14, 2021 at 8:43 AM Jens Axboe wrote: > > On 4/13/21 5:14 PM, Dave Chinner wrote: > > On Tue, Apr 13, 2021 at 10:13:24AM -0600, Jens Axboe wrote: > >> On 4/13/21 1:51 AM, SeongJae Park wrote: > >>> From: SeongJae Park > >>> > >>> Hello, > >>> > >>> > >>> Very interesting work, thank y

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Linus Torvalds
On Wed, Apr 14, 2021 at 11:46 AM wrote: > > Some of you have noticed the past few weeks and months that > a serious attempt to bring a second language to the kernel was > being forged. We are finally here, with an RFC that adds support > for Rust to the Linux kernel. So I replied with my reaction

Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API

2021-04-14 Thread Clemens Gruber
On Wed, Apr 14, 2021 at 09:21:31PM +0200, Uwe Kleine-König wrote: > On Wed, Apr 14, 2021 at 02:09:14PM +0200, Clemens Gruber wrote: > > Hi Uwe, > > > > On Tue, Apr 13, 2021 at 09:38:18PM +0200, Uwe Kleine-König wrote: > > > Hello Clemens, > > > > > > On Tue, Apr 13, 2021 at 02:11:38PM +0200, Clem

Re: [PATCH 01/13] kallsyms: Support "big" kernel symbols (2-byte lengths)

2021-04-14 Thread Matthew Wilcox
On Wed, Apr 14, 2021 at 08:45:52PM +0200, oj...@kernel.org wrote: > Increasing to 255 is not enough in some cases, and therefore > we need to introduce 2-byte lengths to the symbol table. We call > these "big" symbols. > > In order to avoid increasing all lengths to 2 bytes (since most > of them o

Re: [PATCH v10 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER

2021-04-14 Thread Bjorn Helgaas
On Sat, Apr 10, 2021 at 01:22:18AM +0900, Kunihiko Hayashi wrote: > This patch adds misc interrupt handler to detect and invoke PME/AER event. > > In UniPhier PCIe controller, PME/AER signals are assigned to the same > signal as MSI by the internal logic. These signals should be detected by > the

[PATCH] coresight: etm-perf: Fix define build issue when built as module

2021-04-14 Thread Mike Leach
CONFIG_CORESIGHT_SOURCE_ETM4X is undefined when built as module, CONFIG_CORESIGHT_SOURCE_ETM4X_MODULE is defined instead. Therefore code in format_attr_contextid_show() not correctly complied when coresight built as module. Use IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM4X) to correct this. Fixes: 88

[PATCH next v2] mfd: Add Renesas Synchronization Management Unit (SMU) support

2021-04-14 Thread min.li.xe
From: Min Li Add support for ClockMatrix(TM) and 82P33xxx families of timing and synchronization devices. The access interface can be either SPI or I2C. Currently, it will create 2 types of MFD devices, which are to be used by the corresponding rsmu character device driver and the PTP hardware cl

Re: [PATCH 09/13] Samples: Rust examples

2021-04-14 Thread Matthew Wilcox
On Wed, Apr 14, 2021 at 09:42:26PM +0200, Miguel Ojeda wrote: > On Wed, Apr 14, 2021 at 9:34 PM Linus Torvalds > wrote: > > > > Honestly, I'd like to see a real example. This is fine for testing, > > but I'd like to see something a bit more real, and a bit less special > > than the Android "binder

Re: [PATCH 07/13] Rust: Kernel crate

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 9:31 PM Linus Torvalds wrote: > > Again, excuse my lack of internal Rust knowledge, but when do these > end up being an issue? > > If the Rust compiler ends up doing hidden allocations, and they then > cause panics, then one of the main *points* of Rustification is > entire

[PATCH v1 3/7] iio: magnetometer: st_magn: Provide default platform data

2021-04-14 Thread Andy Shevchenko
Provide default platform data for magnetometer in case it supports DRDY. One case is LSM9DS0 IMU, on which it is the case. Since accelerometer is using INT1, default magnetometer to INT2. While at it, update description of the drdy_int_pin field. Signed-off-by: Andy Shevchenko --- drivers/iio/

[PATCH v1 2/7] iio: gyro: st_gyro: Move platform data from header to C file

2021-04-14 Thread Andy Shevchenko
Platform data is solely used by one file. Don't share it with others. While at it, drop unneeded anymore __maybe_unused and fix kernel doc to avoid warning: st_gyro_core.c:366: error: Cannot parse struct or union! by converting to a simple comment. It is described at the declaration. Signed-o

[PATCH v1 1/7] iio: accel: st_accel: Move platform data from header to C file

2021-04-14 Thread Andy Shevchenko
Platform data is solely used by one file. Don't share it with others. While at it, drop unneeded anymore __maybe_unused and fix kernel doc to avoid warning: st_accel_core.c:1079: error: Cannot parse struct or union! by converting to a simple comment. It is described at the declaration. Signed

[PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers

2021-04-14 Thread Andy Shevchenko
In case we would initialize two IIO devices from one physical device, we shouldn't have a clash on regulators. That's why move st_sensors_power_enable() call from core to bus drivers. Signed-off-by: Andy Shevchenko --- drivers/iio/accel/st_accel_core.c | 21 + drivers/i

[PATCH v1 5/7] iio: st_sensors: Make accel, gyro, magn and pressure probe shared

2021-04-14 Thread Andy Shevchenko
Some IMUs may utilize existing library code for STMicro accelerometer, gyroscope, magnetometer and pressure. Let's share them via st_sensors.h. Signed-off-by: Andy Shevchenko --- drivers/iio/accel/st_accel.h | 4 drivers/iio/gyro/st_gyro.h| 4 drivers/iio/magneto

[PATCH v1 7/7] dt-bindings: iio: st,st-sensors: Add LSM9DS0 compatible string

2021-04-14 Thread Andy Shevchenko
Enumerate LSM9DS0 (accelerometer and magnetometer parts) via 'st,lsm9ds0-imu' compatible string. Signed-off-by: Andy Shevchenko --- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.y

[PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support

2021-04-14 Thread Andy Shevchenko
We can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support. The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible. In order to amend the

[PATCH] libperf: xyarray: Add bounds checks to xyarray__entry()

2021-04-14 Thread Rob Herring
xyarray__entry() is missing any bounds checking yet often the x and y parameters come from external callers. Add bounds checks and an unchecked __xyarray__entry(). Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyu

Re: [PATCH 01/13] kallsyms: Support "big" kernel symbols (2-byte lengths)

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 9:45 PM Matthew Wilcox wrote: > > How about doing something a bit more utf-8-like? > > len = data[0]; > if (len == 0) > error > else if (len < 128) > return len; > else if (len < 192) > return 1

Re: [PATCH net-next v4 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Apr 2021 08:16:17 +0800 you wrote: > From: Tan Tee Min > > The Synopsis MAC controller supports auxiliary snapshot feature that > allows user to store a snapshot of the system time based on an external > event.

Re: [PATCH net-next v2 0/3] net: phy: marvell-88x2222: a couple of improvements

2021-04-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 23:54:49 +0300 you wrote: > First, there are some SFP modules that only uses RX_LOS for link > indication. Add check that link is operational before actual read of > line-side status. > > Second, it is

Re: [PATCH][next] iommu/vt-d: Fix out-bounds-warning in intel_svm_page_response()

2021-04-14 Thread Gustavo A. R. Silva
Hi Balou, On 4/14/21 00:24, Lu Baolu wrote: > Hi Gustavo, > > On 4/14/21 3:54 AM, Gustavo A. R. Silva wrote: >> Replace call to memcpy() with just a couple of simple assignments in >> order to fix the following out-of-bounds warning: >> >> drivers/iommu/intel/svm.c:1198:4: warning: 'memcpy' offse

Re: [RFC/RFT PATCH 1/3] memblock: update initialization of reserved pages

2021-04-14 Thread Mike Rapoport
On Wed, Apr 14, 2021 at 05:12:11PM +0200, David Hildenbrand wrote: > On 07.04.21 19:26, Mike Rapoport wrote: > > From: Mike Rapoport > > > > The struct pages representing a reserved memory region are initialized > > using reserve_bootmem_range() function. This function is called for each > > rese

Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Sakari Ailus
On Wed, Apr 14, 2021 at 03:55:42PM -0300, ascordeiro wrote: > Em qua, 2021-04-14 às 21:33 +0300, Sakari Ailus escreveu: > > Hi Aline, > > > > Thanks for the patch. > > > > On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro > > wrote: > > > Format multi-line comments according to the

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-14 Thread Yu Zhao
On Wed, Apr 14, 2021 at 1:42 PM Rik van Riel wrote: > > On Wed, 2021-04-14 at 13:14 -0600, Yu Zhao wrote: > > On Wed, Apr 14, 2021 at 9:59 AM Rik van Riel > > wrote: > > > On Wed, 2021-04-14 at 08:51 -0700, Andi Kleen wrote: > > > > >2) It will not scan PTE tables under non-leaf PMD entries >

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-14 Thread Shakeel Butt
On Wed, Apr 14, 2021 at 12:42 PM Jesper Dangaard Brouer wrote: > [...] > > > > > > Can this page_pool be used for TCP RX zerocopy? If yes then PageType > > > can not be used. > > > > Yes it can, since it's going to be used as your default allocator for > > payloads, which might end up on an SKB. >

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Matthew Wilcox
On Wed, Apr 14, 2021 at 08:45:51PM +0200, oj...@kernel.org wrote: > - Manish Goregaokar implemented the fallible `Box`, `Arc`, and `Rc` > allocator APIs in Rust's `alloc` standard library for us. There's a philosophical point to be discussed here which you're skating right over! Should rust

Re: [RFC/RFT PATCH 1/3] memblock: update initialization of reserved pages

2021-04-14 Thread Mike Rapoport
On Wed, Apr 14, 2021 at 05:27:53PM +0200, Ard Biesheuvel wrote: > On Wed, 14 Apr 2021 at 17:14, David Hildenbrand wrote: > > > > On 07.04.21 19:26, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > The struct pages representing a reserved memory region are initialized > > > using reserve

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-14 Thread Enrico Granata
First and foremost thanks for the feedback on the code. I will send out an up-to-date patch with those comments addressed ASAP As for the broader issue, I am definitely happy to incorporate any feedback and work to improve the spec, but looking at embedded storage devices both eMMC and UFS seem to

[PATCH v2][next] iommu/vt-d: Fix out-bounds-warning in intel_svm_page_response()

2021-04-14 Thread Gustavo A. R. Silva
Replace a couple of calls to memcpy() with simple assignments in order to fix the following out-of-bounds warning: drivers/iommu/intel/svm.c:1198:4: warning: 'memcpy' offset [25, 32] from the object at 'desc' is out of the bounds of referenced subobject 'qw2' with type 'long long unsigned int' a

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Arjun Roy
On Wed, Apr 14, 2021 at 10:35 AM Eric Dumazet wrote: > > On Wed, Apr 14, 2021 at 7:15 PM Arjun Roy wrote: > > > > On Wed, Apr 14, 2021 at 9:10 AM Eric Dumazet wrote: > > > > > > On Wed, Apr 14, 2021 at 6:08 PM David Laight > > > wrote: > > > > > > > > From: Eric Dumazet > > > > > Sent: 14 Apri

Re: [PATCH 1/1] s390/pci: expose a PCI device's UID as its index

2021-04-14 Thread Bjorn Helgaas
On Mon, Apr 12, 2021 at 03:59:05PM +0200, Niklas Schnelle wrote: > On s390 each PCI device has a user-defined ID (UID) exposed under > /sys/bus/pci/devices//uid. This ID was designed to serve as the PCI > device's primary index and to match the device within Linux to the > device configured in the

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Nick Terrell
On Wed, Apr 14, 2021 at 12:04 PM Eric Biggers wrote: > > On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote: > > On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote: > > > > > > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote: > > > > Hi all, > > > > > > > > I would really

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 9:45 PM Linus Torvalds wrote: > > With the main point of Rust being safety, there is no way I will ever > accept "panic dynamically" (whether due to out-of-memory or due to > anything else - I also reacted to the "floating point use causes > dynamic panics") as a feature in

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Linus Torvalds
On Wed, Apr 14, 2021 at 1:10 PM Matthew Wilcox wrote: > > There's a philosophical point to be discussed here which you're skating > right over! Should rust-in-the-linux-kernel provide the same memory > allocation APIs as the rust-standard-library, or should it provide a Rusty > API to the standar

Re: [PATCH] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros

2021-04-14 Thread Bjorn Helgaas
On Tue, Apr 13, 2021 at 10:39:16AM +0200, Pali Rohár wrote: > On Monday 12 April 2021 14:27:40 Bjorn Helgaas wrote: > > On Mon, Apr 12, 2021 at 02:46:02PM +0200, Pali Rohár wrote: > > > Define new PCI_EXP_DEVCTL_PAYLOAD_* macros in linux/pci_regs.h header file > > > for Max Payload Size. Macros are

Re: [PATCH] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros

2021-04-14 Thread Pali Rohár
On Wednesday 14 April 2021 15:23:09 Bjorn Helgaas wrote: > On Tue, Apr 13, 2021 at 10:39:16AM +0200, Pali Rohár wrote: > > On Monday 12 April 2021 14:27:40 Bjorn Helgaas wrote: > > > On Mon, Apr 12, 2021 at 02:46:02PM +0200, Pali Rohár wrote: > > > > Define new PCI_EXP_DEVCTL_PAYLOAD_* macros in li

Re: [RFC/RFT PATCH 1/3] memblock: update initialization of reserved pages

2021-04-14 Thread Mike Rapoport
On Wed, Apr 14, 2021 at 05:52:57PM +0200, David Hildenbrand wrote: > On 14.04.21 17:27, Ard Biesheuvel wrote: > > On Wed, 14 Apr 2021 at 17:14, David Hildenbrand wrote: > > > > > > On 07.04.21 19:26, Mike Rapoport wrote: > > > > From: Mike Rapoport > > > > > > > > The struct pages representing

Re: [PATCH] libperf: xyarray: Add bounds checks to xyarray__entry()

2021-04-14 Thread Namhyung Kim
On Thu, Apr 15, 2021 at 4:58 AM Rob Herring wrote: > > xyarray__entry() is missing any bounds checking yet often the x and y > parameters come from external callers. Add bounds checks and an > unchecked __xyarray__entry(). > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Eric Dumazet
On Wed, Apr 14, 2021 at 10:15 PM Arjun Roy wrote: > > On Wed, Apr 14, 2021 at 10:35 AM Eric Dumazet wrote: > > > > On Wed, Apr 14, 2021 at 7:15 PM Arjun Roy wrote: > > > > > > On Wed, Apr 14, 2021 at 9:10 AM Eric Dumazet wrote: > > > > > > > > On Wed, Apr 14, 2021 at 6:08 PM David Laight > >

Please reply to me

2021-04-14 Thread vanevans001
How are you? I'm Vanina C. I picked interest in you and I would like to know more about you and establish relationship with you. i will wait for your response. thank you.

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

2021-04-14 Thread Doug Anderson
Hi, On Tue, Apr 13, 2021 at 3:59 AM wrote: > > >> >>> + required-opps = > >> >>> <&rpmhpd_opp_low_svs>; > >> >>> + opp-peak-kBps = <120 > >> >>> 76000>; > >> >>> + opp-avg-kBps =

Re: [PATCH -next] PCI: Use DEFINE_SPINLOCK() for spinlock

2021-04-14 Thread Bjorn Helgaas
On Tue, Apr 06, 2021 at 08:06:37PM +0800, Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Applied to pci/hotplug for v5.13

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Miguel Ojeda
On Wed, Apr 14, 2021 at 10:10 PM Matthew Wilcox wrote: > > On Wed, Apr 14, 2021 at 08:45:51PM +0200, oj...@kernel.org wrote: > > - Manish Goregaokar implemented the fallible `Box`, `Arc`, and `Rc` > > allocator APIs in Rust's `alloc` standard library for us. > > There's a philosophical point

Re: [RFC/RFT PATCH 2/3] arm64: decouple check whether pfn is normal memory from pfn_valid()

2021-04-14 Thread Mike Rapoport
On Wed, Apr 14, 2021 at 05:58:26PM +0200, David Hildenbrand wrote: > On 08.04.21 07:14, Anshuman Khandual wrote: > > > > On 4/7/21 10:56 PM, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > The intended semantics of pfn_valid() is to verify whether there is a > > > struct page for the

[PATCH 1/3] spi: s3c64xx: simplify getting of_device_id match data

2021-04-14 Thread Krzysztof Kozlowski
Use of_device_get_match_data() to make the code slightly smaller and to remove the of_device_id table forward declaration. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/d

[PATCH 2/3] spi: s3c64xx: correct kerneldoc of s3c64xx_spi_port_config

2021-04-14 Thread Krzysztof Kozlowski
Correct the name of s3c64xx_spi_port_config structure in kerneldoc: drivers/spi/spi-s3c64xx.c:154: warning: expecting prototype for struct s3c64xx_spi_info. Prototype was for struct s3c64xx_spi_port_config instead Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 2 +- 1

[PATCH 3/3] spi: s3c64xx: constify driver/match data

2021-04-14 Thread Krzysztof Kozlowski
The match data (struct s3c64xx_spi_port_config) stored in of_device_id and platform_device_id tables is not modified by the driver and can be handled entirely in a const-way to increase the code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 21 ++---

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-14 Thread Arjun Roy
On Wed, Apr 14, 2021 at 1:25 PM Eric Dumazet wrote: > > On Wed, Apr 14, 2021 at 10:15 PM Arjun Roy wrote: > > > > On Wed, Apr 14, 2021 at 10:35 AM Eric Dumazet wrote: > > > > > > On Wed, Apr 14, 2021 at 7:15 PM Arjun Roy wrote: > > > > > > > > On Wed, Apr 14, 2021 at 9:10 AM Eric Dumazet > >

Re: [PATCH net-next 1/7] net: korina: Fix MDIO functions

2021-04-14 Thread Thomas Bogendoerfer
On Wed, Apr 14, 2021 at 09:36:04PM +0200, Andrew Lunn wrote: > > +static int korina_mdio_wait(struct korina_private *lp) > > +{ > > + int timeout = 1000; > > + > > + while ((readl(&lp->eth_regs->miimind) & 1) && timeout-- > 0) > > + udelay(1); > > + > > + if (timeout <= 0) > > +

Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>

2021-04-14 Thread Dario Binacchi
Hi Tero, > Il 12/04/2021 09:41 Tero Kristo ha scritto: > > > On 11/04/2021 22:30, Dario Binacchi wrote: > > > >> Il 09/04/2021 12:32 Tero Kristo ha scritto: > >> > >> > >> On 08/04/2021 23:24, Dario Binacchi wrote: > >>> > Il 07/04/2021 15:21 Tero Kristo ha scritto: > >

[PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Aline Santana Cordeiro
Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- Changes since v1: - Stantardize all the multi-line and single-line comments drivers/staging/media/atomisp/pci/atomisp_cmd.c | 377 +++- 1 file ch

Re: [PATCH 00/13] [RFC] Rust support

2021-04-14 Thread Josh Triplett
On Wed, Apr 14, 2021 at 01:21:52PM -0700, Linus Torvalds wrote: > On Wed, Apr 14, 2021 at 1:10 PM Matthew Wilcox wrote: > > > > There's a philosophical point to be discussed here which you're skating > > right over! Should rust-in-the-linux-kernel provide the same memory > > allocation APIs as th

Re: [RFC][PATCH] locking: Generic ticket-lock

2021-04-14 Thread Stafford Horne
On Wed, Apr 14, 2021 at 12:16:38PM +0200, Peter Zijlstra wrote: > On Wed, Apr 14, 2021 at 11:05:24AM +0200, Peter Zijlstra wrote: > > > That made me look at the qspinlock code, and queued_spin_*lock() uses > > atomic_try_cmpxchg_acquire(), which means any arch that uses qspinlock > > and has RCpc

Re: [PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-14 Thread Eric Dumazet
On Wed, Apr 14, 2021 at 10:09 PM Shakeel Butt wrote: > > I will let TCP RX zerocopy experts respond to this but from my high > level code inspection, I didn't see page->private usage. Indeed, we do not use page->private, since we do not own the page(s).

Re: [PATCH] libperf: xyarray: Add bounds checks to xyarray__entry()

2021-04-14 Thread Rob Herring
On Wed, Apr 14, 2021 at 3:25 PM Namhyung Kim wrote: > > On Thu, Apr 15, 2021 at 4:58 AM Rob Herring wrote: > > > > xyarray__entry() is missing any bounds checking yet often the x and y > > parameters come from external callers. Add bounds checks and an > > unchecked __xyarray__entry(). > > > > Cc

Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Sakari Ailus
On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro wrote: > Format all comments according to the coding-style. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro Thanks! Acked-by: Sakari Ailus -- Sakari Ailus

[PATCH] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line

2021-04-14 Thread Aline Santana Cordeiro
Change line break to avoid an open parenthesis at the end of the line. It consequently removed spaces at the start of the subsequent line. Both issues detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_cmd.h | 10 +- 1 file chan

Re: [Outreachy kernel] [PATCH v3 2/2] staging: rtl8723bs: Remove everything related with LedBlink

2021-04-14 Thread Julia Lawall
On Wed, 14 Apr 2021, Fabio M. De Francesco wrote: > Removed struct LedBlink_param. Removed LedBlink entries in > rtw_cmd_callback[] and in wlancmds[]. Everything related to LedBlink is > not anymore needed. Removed extra blank lines in the two mentioned > arrays and changend the numbers set in

Re: [Outreachy patch] [PATCH v3 1/2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Julia Lawall
On Wed, 14 Apr 2021, Fabio M. De Francesco wrote: > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This > change has not unwanted side effects because the code in rtw_cmd.c checks > if the function

[PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-14 Thread Kuogee Hsieh
Link status is different from display connected status in the case of something like an Apple dongle where the type-c plug can be connected, and therefore the link is connected, but no sink is connected until an HDMI cable is plugged into the dongle. The sink_count of DPCD of dongle will increase t

[PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-14 Thread Kuogee Hsieh
Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add dp_display_start_audio() Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_audio.c | 1 + drive

Re: [RFC][PATCH] locking: Generic ticket-lock

2021-04-14 Thread Stafford Horne
On Wed, Apr 14, 2021 at 02:45:43PM +0200, Peter Zijlstra wrote: > On Wed, Apr 14, 2021 at 12:16:38PM +0200, Peter Zijlstra wrote: > > On Wed, Apr 14, 2021 at 11:05:24AM +0200, Peter Zijlstra wrote: > > > > > That made me look at the qspinlock code, and queued_spin_*lock() uses > > > atomic_try_cmp

<    5   6   7   8   9   10   11   12   13   14   >