On Wed, Apr 14, 2021 at 08:56:50PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 14, 2021 at 08:47:48PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 14, 2021 at 07:33:38PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Apr 14, 2021 at 08:12:46PM +0300, Alexander Shishkin wrote:
... > > Nothing, just will require additional export_uuid() / import_uuid() call. > > Isn't that the "correct way" here? I agree that it is better, yes. > > > > - generate_random_uuid(pn->uuid.b); > > > > > > Ok, that's not good, but that looks to be a flaw in the > > > generate_random_uuid() api, not this driver implementation. > > > > > > I don't understand why this change is needed? > > > > Using raw buffer APIs against uuid_t / guid_t. > > So you want to do that, or you do not want to do that? Totally > confused, It is matter of consistency, so two possibilities here: - use types _and_ APIs for raw buffer (this patch) - use types _and_ APIs for uuid_t (suggested in this discussion) Currently it uses uuid_t type _and_ raw buffer APIs — inconsistency. -- With Best Regards, Andy Shevchenko
