[PATCH 4.4 23/33] net/qlcnic: Fix a use after free in qlcnic_83xx_get_minidump_template

2021-03-29 Thread Greg Kroah-Hartman
From: Lv Yunlong [ Upstream commit db74623a3850db99cb9692fda9e836a56b74198d ] In qlcnic_83xx_get_minidump_template, fw_dump->tmpl_hdr was freed by vfree(). But unfortunately, it is used when extended is true. Fixes: 7061b2bdd620e ("qlogic: Deletion of unnecessary checks before two function cal

[PATCH 4.4 24/33] can: c_can_pci: c_can_pci_remove(): fix use-after-free

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 0429d6d89f97ebff4f17f13f5b5069c66bde8138 ] There is a UAF in c_can_pci_remove(). dev is released by free_c_can_dev() and is used by pci_iounmap(pdev, priv->base) later. To fix this issue, save the mmio address before releasing dev. Fixes: 5b92da0443c2 ("c_can_

Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support

2021-03-29 Thread Alexandre TORGUE
Hi Dillon On 3/12/21 7:24 AM, dillon.min...@gmail.com wrote: From: dillon min This patch adds STM32H750 pinctrl and GPIO support since stm32h750 has the same pin alternate functions with stm32h743, so just reuse the stm32h743's pinctrl driver Signed-off-by: dillon min --- v2: - add compatibl

[PATCH 4.4 03/33] atm: eni: dont release is never initialized

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 4deb550bc3b698a1f03d0332cde3df154d1b6c1e ] label err_eni_release is reachable when eni_start() fail. In eni_start() it calls dev->phy->start() in the last step, if start() fail we don't need to call phy->stop(), if start() is never called, we neither need to ca

[PATCH 4.4 25/33] can: c_can: move runtime PM enable/disable to c_can_platform

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 6e2fe01dd6f98da6cae8b07cd5cfa67abc70d97d ] Currently doing modprobe c_can_pci will make the kernel complain: Unbalanced pm_runtime_enable! this is caused by pm_runtime_enable() called before pm is initialized. This fix is similar to 227619c3ff7c, move th

[PATCH 4.4 26/33] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning

2021-03-29 Thread Greg Kroah-Hartman
From: Torin Cooper-Bennun [ Upstream commit c0e399f3baf42279f48991554240af8c457535d1 ] Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg(), with netdev output included. Removing this warning also improves driver performance under heavy load, where m_can_do_rx_poll() may be

[PATCH 4.4 04/33] atm: lanai: dont run lanai_dev_close if not open

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit a2bd45834e83d6c5a04d397bde13d744a4812dfc ] lanai_dev_open() can fail. When it fail, lanai->base is unmapped and the pci device is disabled. The caller, lanai_init_one(), then tries to run atm_dev_deregister(). This will subsequently call lanai_dev_close() and u

[PATCH 4.4 05/33] net: tehuti: fix error return code in bdx_probe()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ] When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David

[PATCH 4.4 06/33] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count

2021-03-29 Thread Greg Kroah-Hartman
From: Denis Efremov [ Upstream commit 155b23e6e53475ca3b8c2a946299b4d4dd6a5a1e ] RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row in niu_xmac_interrupt(). Remove the second addition. Signed-off-by: Denis Efremov Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drive

[PATCH 4.4 07/33] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

2021-03-29 Thread Greg Kroah-Hartman
From: Timo Rothenpieler [ Upstream commit a0590473c5e6c4ef17c3132ad08fbad170f72d55 ] This follows what was done in 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13. With the default being m, it's impossible to build the module into the kernel. Signed-off-by: Timo Rothenpieler Signed-off-by: Anna Schum

[PATCH 4.4 00/33] 4.4.264-rc1 review

2021-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.264 release. There are 33 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 31 Mar 2021 07:55:56 +. Anything rec

[PATCH 4.4 09/33] atm: uPD98402: fix incorrect allocation

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 3153724fc084d8ef640c611f269ddfb576d1dcb1 ] dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock (i.e dev->phy_data->lock) will result in a null-ptr-dereference. I believe th

[PATCH 4.4 08/33] NFS: Correct size calculation for create reply length

2021-03-29 Thread Greg Kroah-Hartman
From: Frank Sorenson [ Upstream commit ad3dbe35c833c2d4d0bbf3f04c785d32f931e7c9 ] CREATE requests return a post_op_fh3, rather than nfs_fh3. The post_op_fh3 includes an extra word to indicate 'handle_follows'. Without that additional word, create fails when full 64-byte filehandles are in use.

[PATCH 4.4 28/33] net: cdc-phonet: fix data-interface release on probe failure

2021-03-29 Thread Greg Kroah-Hartman
From: Johan Hovold [ Upstream commit c79a707072fe3fea0e3c92edee6ca85c1e53c29f ] Set the disconnected flag before releasing the data interface in case netdev registration fails to avoid having the disconnect callback try to deregister the never registered netdev (and trigger a WARN_ON()). Fixes:

[PATCH 4.4 29/33] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server

2021-03-29 Thread Greg Kroah-Hartman
From: Potnuri Bharat Teja [ Upstream commit 3408be145a5d6418ff955fe5badde652be90e700 ] Not setting the ipv6 bit while destroying ipv6 listening servers may result in potential fatal adapter errors due to lookup engine memory hash errors. Therefore always set ipv6 field while destroying ipv6 list

[PATCH 4.4 31/33] can: dev: Move device back to init netns on owning netns delete

2021-03-29 Thread Greg Kroah-Hartman
From: Martin Willi commit 3a5ca857079ea022e0b1b17fc154f7ad7dbc150f upstream. When a non-initial netns is destroyed, the usual policy is to delete all virtual network interfaces contained, but move physical interfaces back to the initial netns. This keeps the physical interface visible on the sys

[PATCH 4.4 30/33] perf auxtrace: Fix auxtrace queue conflict

2021-03-29 Thread Greg Kroah-Hartman
From: Adrian Hunter [ Upstream commit b410ed2a8572d41c68bd9208555610e4b07d0703 ] The only requirement of an auxtrace queue is that the buffers are in time order. That is achieved by making separate queues for separate perf buffer or AUX area buffer mmaps. That generally means a separate queue

[PATCH 4.4 33/33] mac80211: fix double free in ibss_leave

2021-03-29 Thread Greg Kroah-Hartman
From: Markus Theil commit 3bd801b14e0c5d29eeddc7336558beb3344efaa3 upstream. Clear beacon ie pointer and ie length after free in order to prevent double free. == BUG: KASAN: double-free or invalid-free \ in ieee80211_ibss_leave+0x8

[PATCH 4.4 32/33] net: sched: validate stab values

2021-03-29 Thread Greg Kroah-Hartman
From: Eric Dumazet commit e323d865b36134e8c5c82c834df89109a5c60dab upstream. iproute2 package is well behaved, but malicious user space can provide illegal shift values and trigger UBSAN reports. Add stab parameter to red_check_params() to validate user input. syzbot reported: UBSAN: shift-ou

[PATCH 4.9 01/53] net: fec: ptp: avoid register access when ipg clock is disabled

2021-03-29 Thread Greg Kroah-Hartman
From: Heiko Thiery [ Upstream commit 6a4d7234ae9a3bb31181f348ade9bbdb55aeb5c5 ] When accessing the timecounter register on an i.MX8MQ the kernel hangs. This is only the case when the interface is down. This can be reproduced by reading with 'phc_ctrl eth0 get'. Like described in the change in 9

[PATCH 4.9 10/53] net: wan: fix error return code of uhdlc_init()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 62765d39553cfd1ad340124fe1e280450e8c89e2 ] When priv->rx_skbuff or priv->tx_skbuff is NULL, no error return code of uhdlc_init() is assigned. To fix this bug, ret is assigned with -ENOMEM in these cases. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Sign

[PATCH 4.4 27/33] mac80211: fix rate mask reset

2021-03-29 Thread Greg Kroah-Hartman
From: Johannes Berg [ Upstream commit 1944015fe9c1d9fa5e9eb7ffbbb5ef8954d6753b ] Coverity reported the strange "if (~...)" condition that's always true. It suggested that ! was intended instead of ~, but upon further analysis I'm convinced that what really was intended was a comparison to 0xff/0

RE: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes

2021-03-29 Thread Arnaud POULIQUEN
Hi, > -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > Jaroslav Kysela ; Takashi Iwa

[PATCH 4.9 17/53] x86/tlb: Flush global mappings when KAISER is disabled

2021-03-29 Thread Greg Kroah-Hartman
From: Borislav Petkov Jim Mattson reported that Debian 9 guests using a 4.9-stable kernel are exploding during alternatives patching: kernel BUG at /build/linux-dqnRSc/linux-4.9.228/arch/x86/kernel/alternative.c:709! invalid opcode: [#1] SMP Modules linked in: CPU: 1 PID: 1 Comm: s

[PATCH 4.9 19/53] squashfs: fix xattr id and id lookup sanity checks

2021-03-29 Thread Greg Kroah-Hartman
From: Phillip Lougher commit 8b44ca2b634527151af07447a8090a5f3a043321 upstream. The checks for maximum metadata block size is missing SQUASHFS_BLOCK_OFFSET (the two byte length count). Link: https://lkml.kernel.org/r/2069685113.2081245.1614583677...@webmail.123-reg.co.uk Fixes: f37aa4c7366e23f

[PATCH 4.9 15/53] ia64: fix ia64_syscall_get_set_arguments() for break-based syscalls

2021-03-29 Thread Greg Kroah-Hartman
From: Sergei Trofimovich [ Upstream commit 0ceb1ace4a2778e34a5414e5349712ae4dc41d85 ] In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not work for syscalls called via glibc's syscall() wrapper. ia64 has two ways to call syscalls from userspace: via `

[PATCH 4.9 02/53] powerpc/4xx: Fix build errors from mfdcr()

2021-03-29 Thread Greg Kroah-Hartman
From: Michael Ellerman [ Upstream commit eead089311f4d935ab5d1d8fbb0c42ad44699ada ] lkp reported a build error in fsp2.o: CC arch/powerpc/platforms/44x/fsp2.o {standard input}:577: Error: unsupported relocation against base Which comes from: pr_err("GESR0: 0x%08x\n", mfdcr(base + P

[PATCH 4.9 11/53] atm: uPD98402: fix incorrect allocation

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 3153724fc084d8ef640c611f269ddfb576d1dcb1 ] dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock (i.e dev->phy_data->lock) will result in a null-ptr-dereference. I believe th

[PATCH 4.9 18/53] squashfs: fix inode lookup sanity checks

2021-03-29 Thread Greg Kroah-Hartman
From: Sean Nyekjaer commit c1b2028315c6b15e8d6725e0d5884b15887d3daa upstream. When mouting a squashfs image created without inode compression it fails with: "unable to read inode lookup table" It turns out that the BLOCK_OFFSET is missing when checking the SQUASHFS_METADATA_SIZE agaist the actu

[PATCH 4.9 16/53] ia64: fix ptrace(PTRACE_SYSCALL_INFO_EXIT) sign

2021-03-29 Thread Greg Kroah-Hartman
From: Sergei Trofimovich [ Upstream commit 61bf318eac2c13356f7bd1c6a05421ef504ccc8a ] In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error

[PATCH 4.9 12/53] atm: idt77252: fix null-ptr-dereference

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 4416e98594dc04590ebc498fc4e530009535c511 ] this one is similar to the phy_data allocation fix in uPD98402, the driver allocate the idt77105_priv and store to dev_data but later dereference using dev->dev_data, which will cause null-ptr-dereference. fix this is

[PATCH 4.9 14/53] nfs: we dont support removing system.nfs4_acl

2021-03-29 Thread Greg Kroah-Hartman
From: J. Bruce Fields [ Upstream commit 4f8be1f53bf615102d103c0509ffa9596f65b718 ] The NFSv4 protocol doesn't have any notion of reomoving an attribute, so removexattr(path,"system.nfs4_acl") doesn't make sense. There's no documented return value. Arguably it could be EOPNOTSUPP but I'm a litt

[PATCH 4.9 13/53] u64_stats,lockdep: Fix u64_stats_init() vs lockdep

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra [ Upstream commit d5b0e0677bfd5efd17c5bbb00156931f0d41cb85 ] Jakub reported that: static struct net_device *rtl8139_init_board(struct pci_dev *pdev) { ... u64_stats_init(&tp->rx_stats.syncp); u64_stats_init(&tp->tx_stats.syncp);

[PATCH 4.9 03/53] atm: eni: dont release is never initialized

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 4deb550bc3b698a1f03d0332cde3df154d1b6c1e ] label err_eni_release is reachable when eni_start() fail. In eni_start() it calls dev->phy->start() in the last step, if start() fail we don't need to call phy->stop(), if start() is never called, we neither need to ca

RE: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check

2021-03-29 Thread Arnaud POULIQUEN
> -Original Message- > From: Pierre-Louis Bossart > Sent: vendredi 26 mars 2021 22:59 > To: alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart ; Arnaud POULIQUEN > ; Liam Girdwood ; > Jaroslav Kysela ; Takashi Iwai

[PATCH 4.9 05/53] ixgbe: Fix memleak in ixgbe_configure_clsu32

2021-03-29 Thread Greg Kroah-Hartman
From: Dinghao Liu [ Upstream commit 7a766381634da19fc837619b0a34590498d9d29a ] When ixgbe_fdir_write_perfect_filter_82599() fails, input allocated by kzalloc() has not been freed, which leads to memleak. Signed-off-by: Dinghao Liu Reviewed-by: Paul Menzel Tested-by: Tony Brelinski Signed-off

[PATCH 4.9 04/53] atm: lanai: dont run lanai_dev_close if not open

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit a2bd45834e83d6c5a04d397bde13d744a4812dfc ] lanai_dev_open() can fail. When it fail, lanai->base is unmapped and the pci device is disabled. The caller, lanai_init_one(), then tries to run atm_dev_deregister(). This will subsequently call lanai_dev_close() and u

[PATCH 4.9 06/53] net: tehuti: fix error return code in bdx_probe()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ] When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David

[PATCH 4.9 08/53] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

2021-03-29 Thread Greg Kroah-Hartman
From: Timo Rothenpieler [ Upstream commit a0590473c5e6c4ef17c3132ad08fbad170f72d55 ] This follows what was done in 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13. With the default being m, it's impossible to build the module into the kernel. Signed-off-by: Timo Rothenpieler Signed-off-by: Anna Schum

[PATCH 4.9 07/53] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count

2021-03-29 Thread Greg Kroah-Hartman
From: Denis Efremov [ Upstream commit 155b23e6e53475ca3b8c2a946299b4d4dd6a5a1e ] RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row in niu_xmac_interrupt(). Remove the second addition. Signed-off-by: Denis Efremov Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drive

[PATCH 4.9 00/53] 4.9.264-rc1 review

2021-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.264 release. There are 53 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 31 Mar 2021 07:55:56 +. Anything rec

[PATCH 4.9 09/53] NFS: Correct size calculation for create reply length

2021-03-29 Thread Greg Kroah-Hartman
From: Frank Sorenson [ Upstream commit ad3dbe35c833c2d4d0bbf3f04c785d32f931e7c9 ] CREATE requests return a post_op_fh3, rather than nfs_fh3. The post_op_fh3 includes an extra word to indicate 'handle_follows'. Without that additional word, create fails when full 64-byte filehandles are in use.

[PATCH 4.9 31/53] net: cdc-phonet: fix data-interface release on probe failure

2021-03-29 Thread Greg Kroah-Hartman
From: Johan Hovold [ Upstream commit c79a707072fe3fea0e3c92edee6ca85c1e53c29f ] Set the disconnected flag before releasing the data interface in case netdev registration fails to avoid having the disconnect callback try to deregister the never registered netdev (and trigger a WARN_ON()). Fixes:

[PATCH 4.9 21/53] bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD

2021-03-29 Thread Greg Kroah-Hartman
From: Grygorii Strashko [ Upstream commit 7d7275b3e866cf8092bd12553ec53ba26864f7bb ] The main purpose of l3 IRQs is to catch OCP bus access errors and identify corresponding code places by showing call stack, so it's important to handle L3 interconnect errors as fast as possible. On RT these IRQ

[PATCH 4.9 30/53] mac80211: fix rate mask reset

2021-03-29 Thread Greg Kroah-Hartman
From: Johannes Berg [ Upstream commit 1944015fe9c1d9fa5e9eb7ffbbb5ef8954d6753b ] Coverity reported the strange "if (~...)" condition that's always true. It suggested that ! was intended instead of ~, but upon further analysis I'm convinced that what really was intended was a comparison to 0xff/0

[PATCH 4.9 32/53] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server

2021-03-29 Thread Greg Kroah-Hartman
From: Potnuri Bharat Teja [ Upstream commit 3408be145a5d6418ff955fe5badde652be90e700 ] Not setting the ipv6 bit while destroying ipv6 listening servers may result in potential fatal adapter errors due to lookup engine memory hash errors. Therefore always set ipv6 field while destroying ipv6 list

[PATCH 4.9 33/53] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-03-29 Thread Greg Kroah-Hartman
From: Rafael J. Wysocki [ Upstream commit c1013ff7a5472db637c56bb6237f8343398c03a7 ] The upfront allocation of new_bus_id is done to avoid allocating memory under acpi_device_lock, but it doesn't really help, because (1) it leads to many unnecessary memory allocations for _ADR devices, (2) kstrd

[PATCH 4.9 34/53] ACPI: scan: Use unique number for instance_no

2021-03-29 Thread Greg Kroah-Hartman
From: Andy Shevchenko [ Upstream commit eb50aaf960e3bedfef79063411ffd670da94b84b ] The decrementation of acpi_device_bus_id->instance_no in acpi_device_del() is incorrect, because it may cause a duplicate instance number to be allocated next time a device with the same acpi_device_bus_id is adde

[PATCH 4.9 35/53] perf auxtrace: Fix auxtrace queue conflict

2021-03-29 Thread Greg Kroah-Hartman
From: Adrian Hunter [ Upstream commit b410ed2a8572d41c68bd9208555610e4b07d0703 ] The only requirement of an auxtrace queue is that the buffers are in time order. That is achieved by making separate queues for separate perf buffer or AUX area buffer mmaps. That generally means a separate queue

[PATCH 4.9 38/53] futex,rt_mutex: Introduce rt_mutex_init_waiter()

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit 50809358dd7199aa7ce232f6877dd09ec30ef374 upstream. Since there's already two copies of this code, introduce a helper now before adding a third one. Signed-off-by: Peter Zijlstra (Intel) Cc: juri.le...@arm.com Cc: bige...@linutronix.de Cc: xlp...@redhat.com Cc: rost.

[PATCH 4.9 37/53] futex: Use smp_store_release() in mark_wake_futex()

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit 1b367ece0d7e696cab1c8501bab282cc6a538b3f upstream. Since the futex_q can dissapear the instruction after assigning NULL, this really should be a RELEASE barrier. That stops loads from hitting dead memory too. Signed-off-by: Peter Zijlstra (Intel) Cc: juri.le...@arm.

[PATCH 4.9 39/53] futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit cfafcd117da0216520568c195cb2f6cd1980c4bb upstream. By changing futex_lock_pi() to use rt_mutex_*_proxy_lock() all wait_list modifications are done under both hb->lock and wait_lock. This closes the obvious interleave pattern between futex_lock_pi() and futex_unlock_p

[PATCH 4.9 36/53] idr: add ida_is_empty

2021-03-29 Thread Greg Kroah-Hartman
From: Matthew Wilcox [ Upstream commit 99c494077e2d4282a17120a772eecc00ec3004cc ] Two of the USB Gadgets were poking around in the internals of struct ida in order to determine if it is empty. Add the appropriate abstraction. Link: http://lkml.kernel.org/r/1480369871-5271-63-git-send-email-ma

[PATCH 4.9 22/53] macvlan: macvlan_count_rx() needs to be aware of preemption

2021-03-29 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit dd4fa1dae9f4847cc1fd78ca468ad69e16e5db3e ] macvlan_count_rx() can be called from process context, it is thus necessary to disable preemption before calling u64_stats_update_begin() syzbot was able to spot this on 32bit arch: WARNING: CPU: 1 PID: 4632 at inc

[PATCH 4.9 40/53] futex: Drop hb->lock before enqueueing on the rtmutex

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit 56222b212e8edb1cf51f5dd73ff645809b082b40 upstream. When PREEMPT_RT_FULL does the spinlock -> rt_mutex substitution the PI chain code will (falsely) report a deadlock and BUG. The problem is that it hold hb->lock (now an rt_mutex) while doing task_blocks_on_rt_mutex o

[PATCH 4.9 42/53] futex,rt_mutex: Fix rt_mutex_cleanup_proxy_lock()

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit 04dc1b2fff4e96cb4142227fbdc63c8871ad4ed9 upstream. Markus reported that the glibc/nptl/tst-robustpi8 test was failing after commit: cfafcd117da0 ("futex: Rework futex_lock_pi() to use rt_mutex_*_proxy_lock()") The following trace shows the problem: ld-linux-x86-

[PATCH 4.9 44/53] futex: Fix (possible) missed wakeup

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra commit b061c38bef43406df8e73c5be06cbfacad5ee6ad upstream. We must not rely on wake_q_add() to delay the wakeup; in particular commit: 1d0dcb3ad9d3 ("futex: Implement lockless wakeups") moved wake_q_add() before smp_store_release(&q->lock_ptr, NULL), which could result in

[PATCH 4.9 43/53] futex: Handle early deadlock return correctly

2021-03-29 Thread Greg Kroah-Hartman
From: Thomas Gleixner commit 1a1fb985f2e2b85ec0d3dc2e519ee48389ec2434 upstream. commit 56222b212e8e ("futex: Drop hb->lock before enqueueing on the rtmutex") changed the locking rules in the futex code so that the hash bucket lock is not longer held while the waiter is enqueued into the rtmutex

[PATCH 4.9 41/53] futex: Avoid freeing an active timer

2021-03-29 Thread Greg Kroah-Hartman
From: Thomas Gleixner commit 97181f9bd57405b879403763284537e27d46963d upstream. Alexander reported a hrtimer debug_object splat: ODEBUG: free active (active state 0) object type: hrtimer hint: hrtimer_wakeup (kernel/time/hrtimer.c:1423) debug_object_free (lib/debugobjects.c:603) destroy

[PATCH 4.9 45/53] locking/futex: Allow low-level atomic operations to return -EAGAIN

2021-03-29 Thread Greg Kroah-Hartman
From: Will Deacon commit 6b4f4bc9cb22875f97023984a625386f0c7cc1c0 upstream. Some futex() operations, including FUTEX_WAKE_OP, require the kernel to perform an atomic read-modify-write of the futex word via the userspace mapping. These operations are implemented by each architecture in arch_futex

[PATCH 4.9 46/53] arm64: futex: Bound number of LDXR/STXR loops in FUTEX_WAKE_OP

2021-03-29 Thread Greg Kroah-Hartman
From: Will Deacon commit 03110a5cb2161690ae5ac04994d47ed0cd6cef75 upstream. Our futex implementation makes use of LDXR/STXR loops to perform atomic updates to user memory from atomic context. This can lead to latency problems if we end up spinning around the LL/SC sequence at the expense of doin

[PATCH 4.9 47/53] futex: Prevent robust futex exit race

2021-03-29 Thread Greg Kroah-Hartman
From: Yang Tao commit ca16d5bee59807bf04deaab0a8eccecd5061528c upstream. Robust futexes utilize the robust_list mechanism to allow the kernel to release futexes which are held when a task exits. The exit can be voluntary or caused by a signal or fault. This prevents that waiters block forever.

[PATCH 4.9 48/53] futex: Fix incorrect should_fail_futex() handling

2021-03-29 Thread Greg Kroah-Hartman
From: Mateusz Nosek commit 921c7ebd1337d1a46783d7e15a850e12aed2eaa0 upstream. If should_futex_fail() returns true in futex_wake_pi(), then the 'ret' variable is set to -EFAULT and then immediately overwritten. So the failure injection is non-functional. Fix it by actually leaving the function a

[PATCH 4.9 49/53] futex: Handle transient "ownerless" rtmutex state correctly

2021-03-29 Thread Greg Kroah-Hartman
From: Mike Galbraith commit 9f5d1c336a10c0d24e83e40b4c1b9539f7dba627 upstream. Gratian managed to trigger the BUG_ON(!newowner) in fixup_pi_state_owner(). This is one possible chain of events leading to this: Task Prio Operation T1 120lock(F) T2 120lock(F) -> blocks

[PATCH 4.9 23/53] net: dsa: bcm_sf2: Qualify phydev->dev_flags based on port

2021-03-29 Thread Greg Kroah-Hartman
From: Florian Fainelli [ Upstream commit 47142ed6c34d544ae9f0463e58d482289cbe0d46 ] Similar to commit 92696286f3bb37ba50e4bd8d1beb24afb759a799 ("net: bcmgenet: Set phydev->dev_flags only for internal PHYs") we need to qualify the phydev->dev_flags based on whether the port is connected to an int

[PATCH 4.9 51/53] net: sched: validate stab values

2021-03-29 Thread Greg Kroah-Hartman
From: Eric Dumazet commit e323d865b36134e8c5c82c834df89109a5c60dab upstream. iproute2 package is well behaved, but malicious user space can provide illegal shift values and trigger UBSAN reports. Add stab parameter to red_check_params() to validate user input. syzbot reported: UBSAN: shift-ou

[PATCH 4.9 52/53] net: qrtr: fix a kernel-infoleak in qrtr_recvmsg()

2021-03-29 Thread Greg Kroah-Hartman
From: Eric Dumazet commit 50535249f624d0072cd885bcdce4e4b6fb770160 upstream. struct sockaddr_qrtr has a 2-byte hole, and qrtr_recvmsg() currently does not clear it before copying kernel data to user space. It might be too late to name the hole since sockaddr_qrtr structure is uapi. BUG: KMSAN:

[PATCH 4.9 50/53] can: dev: Move device back to init netns on owning netns delete

2021-03-29 Thread Greg Kroah-Hartman
From: Martin Willi commit 3a5ca857079ea022e0b1b17fc154f7ad7dbc150f upstream. When a non-initial netns is destroyed, the usual policy is to delete all virtual network interfaces contained, but move physical interfaces back to the initial netns. This keeps the physical interface visible on the sys

[PATCH 4.9 24/53] e1000e: add rtnl_lock() to e1000_reset_task

2021-03-29 Thread Greg Kroah-Hartman
From: Vitaly Lifshits [ Upstream commit 21f857f0321d0d0ea9b1a758bd55dc63d1cb2437 ] A possible race condition was found in e1000_reset_task, after discovering a similar issue in igb driver via commit 024a8168b749 ("igb: reinit_locked() should be called with rtnl_lock"). Added rtnl_lock() and rtn

[PATCH 4.9 53/53] mac80211: fix double free in ibss_leave

2021-03-29 Thread Greg Kroah-Hartman
From: Markus Theil commit 3bd801b14e0c5d29eeddc7336558beb3344efaa3 upstream. Clear beacon ie pointer and ie length after free in order to prevent double free. == BUG: KASAN: double-free or invalid-free \ in ieee80211_ibss_leave+0x8

[PATCH 4.9 28/53] can: c_can: move runtime PM enable/disable to c_can_platform

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 6e2fe01dd6f98da6cae8b07cd5cfa67abc70d97d ] Currently doing modprobe c_can_pci will make the kernel complain: Unbalanced pm_runtime_enable! this is caused by pm_runtime_enable() called before pm is initialized. This fix is similar to 227619c3ff7c, move th

[PATCH 4.9 27/53] can: c_can_pci: c_can_pci_remove(): fix use-after-free

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 0429d6d89f97ebff4f17f13f5b5069c66bde8138 ] There is a UAF in c_can_pci_remove(). dev is released by free_c_can_dev() and is used by pci_iounmap(pdev, priv->base) later. To fix this issue, save the mmio address before releasing dev. Fixes: 5b92da0443c2 ("c_can_

[PATCH 4.9 25/53] e1000e: Fix error handling in e1000_set_d0_lplu_state_82571

2021-03-29 Thread Greg Kroah-Hartman
From: Dinghao Liu [ Upstream commit b52912b8293f2c496f42583e65599aee606a0c18 ] There is one e1e_wphy() call in e1000_set_d0_lplu_state_82571 that we have caught its return value but lack further handling. Check and terminate the execution flow just like other e1e_wphy() in this function. Fixes:

[PATCH 4.9 26/53] net/qlcnic: Fix a use after free in qlcnic_83xx_get_minidump_template

2021-03-29 Thread Greg Kroah-Hartman
From: Lv Yunlong [ Upstream commit db74623a3850db99cb9692fda9e836a56b74198d ] In qlcnic_83xx_get_minidump_template, fw_dump->tmpl_hdr was freed by vfree(). But unfortunately, it is used when extended is true. Fixes: 7061b2bdd620e ("qlogic: Deletion of unnecessary checks before two function cal

[PATCH 4.9 20/53] arm64: dts: ls1043a: mark crypto engine dma coherent

2021-03-29 Thread Greg Kroah-Hartman
From: Horia Geantă commit 4fb3a074755b7737c4081cffe0ccfa08c2f2d29d upstream. Crypto engine (CAAM) on LS1043A platform is configured HW-coherent, mark accordingly the DT node. Lack of "dma-coherent" property for an IP that is configured HW-coherent can lead to problems, similar to what has been

[PATCH 4.14 12/59] net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 143c253f42bad20357e7e4432087aca747c43384 ] When hns_assemble_skb() returns NULL to skb, no error return code of hns_nic_clear_all_rx_fetch() is assigned. To fix this bug, ret is assigned with -ENOMEM in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju

[PATCH 4.14 13/59] net: wan: fix error return code of uhdlc_init()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 62765d39553cfd1ad340124fe1e280450e8c89e2 ] When priv->rx_skbuff or priv->tx_skbuff is NULL, no error return code of uhdlc_init() is assigned. To fix this bug, ret is assigned with -ENOMEM in these cases. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Sign

[PATCH 4.14 01/59] net: fec: ptp: avoid register access when ipg clock is disabled

2021-03-29 Thread Greg Kroah-Hartman
From: Heiko Thiery [ Upstream commit 6a4d7234ae9a3bb31181f348ade9bbdb55aeb5c5 ] When accessing the timecounter register on an i.MX8MQ the kernel hangs. This is only the case when the interface is down. This can be reproduced by reading with 'phc_ctrl eth0 get'. Like described in the change in 9

[PATCH 4.14 16/59] sparc64: Fix opcode filtering in handling of no fault loads

2021-03-29 Thread Greg Kroah-Hartman
From: Rob Gardner [ Upstream commit e5e8b80d352ec999d2bba3ea584f541c83f4ca3f ] is_no_fault_exception() has two bugs which were discovered via random opcode testing with stress-ng. Both are caused by improper filtering of opcodes. The first bug can be triggered by a floating point store with a n

[PATCH 4.14 14/59] atm: uPD98402: fix incorrect allocation

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 3153724fc084d8ef640c611f269ddfb576d1dcb1 ] dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock (i.e dev->phy_data->lock) will result in a null-ptr-dereference. I believe th

[PATCH 4.14 15/59] atm: idt77252: fix null-ptr-dereference

2021-03-29 Thread Greg Kroah-Hartman
From: Tong Zhang [ Upstream commit 4416e98594dc04590ebc498fc4e530009535c511 ] this one is similar to the phy_data allocation fix in uPD98402, the driver allocate the idt77105_priv and store to dev_data but later dereference using dev->dev_data, which will cause null-ptr-dereference. fix this is

[PATCH 4.14 10/59] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

2021-03-29 Thread Greg Kroah-Hartman
From: Timo Rothenpieler [ Upstream commit a0590473c5e6c4ef17c3132ad08fbad170f72d55 ] This follows what was done in 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13. With the default being m, it's impossible to build the module into the kernel. Signed-off-by: Timo Rothenpieler Signed-off-by: Anna Schum

[PATCH 4.14 11/59] NFS: Correct size calculation for create reply length

2021-03-29 Thread Greg Kroah-Hartman
From: Frank Sorenson [ Upstream commit ad3dbe35c833c2d4d0bbf3f04c785d32f931e7c9 ] CREATE requests return a post_op_fh3, rather than nfs_fh3. The post_op_fh3 includes an extra word to indicate 'handle_follows'. Without that additional word, create fails when full 64-byte filehandles are in use.

[PATCH 4.9 29/53] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning

2021-03-29 Thread Greg Kroah-Hartman
From: Torin Cooper-Bennun [ Upstream commit c0e399f3baf42279f48991554240af8c457535d1 ] Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg(), with netdev output included. Removing this warning also improves driver performance under heavy load, where m_can_do_rx_poll() may be

[PATCH 4.14 17/59] u64_stats,lockdep: Fix u64_stats_init() vs lockdep

2021-03-29 Thread Greg Kroah-Hartman
From: Peter Zijlstra [ Upstream commit d5b0e0677bfd5efd17c5bbb00156931f0d41cb85 ] Jakub reported that: static struct net_device *rtl8139_init_board(struct pci_dev *pdev) { ... u64_stats_init(&tp->rx_stats.syncp); u64_stats_init(&tp->tx_stats.syncp);

[PATCH 4.14 18/59] drm/radeon: fix AGP dependency

2021-03-29 Thread Greg Kroah-Hartman
From: Christian König [ Upstream commit cba2afb65cb05c3d197d17323fee4e3c9edef9cd ] When AGP is compiled as module radeon must be compiled as module as well. Signed-off-by: Christian König Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/K

[PATCH 4.14 02/59] powerpc/4xx: Fix build errors from mfdcr()

2021-03-29 Thread Greg Kroah-Hartman
From: Michael Ellerman [ Upstream commit eead089311f4d935ab5d1d8fbb0c42ad44699ada ] lkp reported a build error in fsp2.o: CC arch/powerpc/platforms/44x/fsp2.o {standard input}:577: Error: unsupported relocation against base Which comes from: pr_err("GESR0: 0x%08x\n", mfdcr(base + P

[PATCH 4.14 19/59] nfs: we dont support removing system.nfs4_acl

2021-03-29 Thread Greg Kroah-Hartman
From: J. Bruce Fields [ Upstream commit 4f8be1f53bf615102d103c0509ffa9596f65b718 ] The NFSv4 protocol doesn't have any notion of reomoving an attribute, so removexattr(path,"system.nfs4_acl") doesn't make sense. There's no documented return value. Arguably it could be EOPNOTSUPP but I'm a litt

[PATCH 4.14 22/59] squashfs: fix inode lookup sanity checks

2021-03-29 Thread Greg Kroah-Hartman
From: Sean Nyekjaer commit c1b2028315c6b15e8d6725e0d5884b15887d3daa upstream. When mouting a squashfs image created without inode compression it fails with: "unable to read inode lookup table" It turns out that the BLOCK_OFFSET is missing when checking the SQUASHFS_METADATA_SIZE agaist the actu

[PATCH 4.14 21/59] ia64: fix ptrace(PTRACE_SYSCALL_INFO_EXIT) sign

2021-03-29 Thread Greg Kroah-Hartman
From: Sergei Trofimovich [ Upstream commit 61bf318eac2c13356f7bd1c6a05421ef504ccc8a ] In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error

[PATCH 4.14 20/59] ia64: fix ia64_syscall_get_set_arguments() for break-based syscalls

2021-03-29 Thread Greg Kroah-Hartman
From: Sergei Trofimovich [ Upstream commit 0ceb1ace4a2778e34a5414e5349712ae4dc41d85 ] In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not work for syscalls called via glibc's syscall() wrapper. ia64 has two ways to call syscalls from userspace: via `

[PATCH 4.14 24/59] arm64: dts: ls1046a: mark crypto engine dma coherent

2021-03-29 Thread Greg Kroah-Hartman
From: Horia Geantă commit 9c3a16f88385e671b63a0de7b82b85e604a80f42 upstream. Crypto engine (CAAM) on LS1046A platform is configured HW-coherent, mark accordingly the DT node. As reported by Greg and Sascha, and explained by Robin, lack of "dma-coherent" property for an IP that is configured HW-

[PATCH 4.14 23/59] squashfs: fix xattr id and id lookup sanity checks

2021-03-29 Thread Greg Kroah-Hartman
From: Phillip Lougher commit 8b44ca2b634527151af07447a8090a5f3a043321 upstream. The checks for maximum metadata block size is missing SQUASHFS_BLOCK_OFFSET (the two byte length count). Link: https://lkml.kernel.org/r/2069685113.2081245.1614583677...@webmail.123-reg.co.uk Fixes: f37aa4c7366e23f

[PATCH 4.14 25/59] arm64: dts: ls1012a: mark crypto engine dma coherent

2021-03-29 Thread Greg Kroah-Hartman
From: Horia Geantă commit ba8da03fa7dff59d9400250aebd38f94cde3cb0f upstream. Crypto engine (CAAM) on LS1012A platform is configured HW-coherent, mark accordingly the DT node. Lack of "dma-coherent" property for an IP that is configured HW-coherent can lead to problems, similar to what has been

[PATCH 4.14 26/59] arm64: dts: ls1043a: mark crypto engine dma coherent

2021-03-29 Thread Greg Kroah-Hartman
From: Horia Geantă commit 4fb3a074755b7737c4081cffe0ccfa08c2f2d29d upstream. Crypto engine (CAAM) on LS1043A platform is configured HW-coherent, mark accordingly the DT node. Lack of "dma-coherent" property for an IP that is configured HW-coherent can lead to problems, similar to what has been

[PATCH 4.14 27/59] ARM: dts: at91-sama5d27_som1: fix phy address to 7

2021-03-29 Thread Greg Kroah-Hartman
From: Claudiu Beznea commit 221c3a09ddf70a0a51715e6c2878d8305e95c558 upstream. Fix the phy address to 7 for Ethernet PHY on SAMA5D27 SOM1. No connection established if phy address 0 is used. The board uses the 24 pins version of the KSZ8081RNA part, KSZ8081RNA pin 16 REFCLK as PHYAD bit [2] has

[PATCH 4.14 08/59] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count

2021-03-29 Thread Greg Kroah-Hartman
From: Denis Efremov [ Upstream commit 155b23e6e53475ca3b8c2a946299b4d4dd6a5a1e ] RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row in niu_xmac_interrupt(). Remove the second addition. Signed-off-by: Denis Efremov Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drive

[PATCH 4.14 29/59] bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD

2021-03-29 Thread Greg Kroah-Hartman
From: Grygorii Strashko [ Upstream commit 7d7275b3e866cf8092bd12553ec53ba26864f7bb ] The main purpose of l3 IRQs is to catch OCP bus access errors and identify corresponding code places by showing call stack, so it's important to handle L3 interconnect errors as fast as possible. On RT these IRQ

[PATCH 4.14 05/59] Revert "r8152: adjust the settings about MAC clock speed down for RTL8153"

2021-03-29 Thread Greg Kroah-Hartman
From: Hayes Wang [ Upstream commit 4b5dc1a94d4f92b5845e98bd9ae344b26d933aad ] This reverts commit 134f98bcf1b898fb9d6f2b91bc85dd2e5478b4b8. The r8153_mac_clk_spd() is used for RTL8153A only, because the register table of RTL8153B is different from RTL8153A. However, this function would be calle

[PATCH 4.14 07/59] net: tehuti: fix error return code in bdx_probe()

2021-03-29 Thread Greg Kroah-Hartman
From: Jia-Ju Bai [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ] When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David

<    1   2   3   4   5   6   7   8   9   10   >