[PATCH] iwlwifi: mvm: Fix an error handling path in 'ebu_dma_start()'

If the 'cmd_ver' check fails, we must release some memory as already done in all the other error handling paths of this function. Fixes: 9e3c39361a30 ("iwlwifi: mvm: support new KEK KCK api") Signed-off-by: Christophe JAILLET --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 6 -- 1 file cha

Re: [PATCH v3 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

> On Jan 23, 2021, at 5:13 PM, David Ahern wrote: > > On 1/23/21 1:00 PM, Jakub Kicinski wrote: >> On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote: >>> On 1/22/21 9:02 PM, Maciej Żenczykowski wrote: Why can't we get rid of the special case for 0 and simply make 1024 the default

Re: [PATCH] iwlwifi: mvm: Fix an error handling path in 'ebu_dma_start()'

Le 24/01/2021 à 08:56, Christophe JAILLET a écrit : If the 'cmd_ver' check fails, we must release some memory as already done in all the other error handling paths of this function. Fixes: 9e3c39361a30 ("iwlwifi: mvm: support new KEK KCK api") Signed-off-by: Christophe JAILLET --- drivers/net

[PATCH v2] iwlwifi: mvm: Fix an error handling path in 'iwl_mvm_wowlan_config_key_params()'

If the 'cmd_ver' check fails, we must release some memory as already done in all the other error handling paths of this function. Fixes: 9e3c39361a30 ("iwlwifi: mvm: support new KEK KCK api") Signed-off-by: Christophe JAILLET --- v1->v2: Fix the subject --- drivers/net/wireless/intel/iwlwifi/mvm

Re: [PATCH] sound/pci/hda: boolean values to a bool variable

On Mon, 18 Jan 2021 09:27:49 +0100, Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > ./sound/pci/hda/patch_conexant.c:570:2-20: WARNING: > Assignment of 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Applied, thanks. Takashi

Re: Infinite recursion in device_reorder_to_tail() due to circular device links

On Sat, Jan 23, 2021 at 03:37:30PM -0800, Hugh Dickins wrote: > On Tue, 12 Jan 2021, Greg Kroah-Hartman wrote: > > On Tue, Jan 12, 2021 at 03:32:04PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Jan 11, 2021 at 7:46 PM Stephan Gerhold > > > wrote: > > > > > > > > Hi, > > > > > > > > since 5.11-r

Re: [PATCH] printk: fix buffer overflow potential for print_text()

Hi Sven, Thanks for the outstanding analysis! On 2021-01-23, Sven Schnelle wrote: >> 1401 if (buf_size > 0) >> 1402 text[len] = 0; > > I don't think i have really understood how all the printk magic works, > but using r->text_buf[len] seems to be the correct place to put

Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: > In this scenario, there is no case where va_page is NULL, and > the error has been checked. The if condition statement here is > redundant, so remove the condition detection. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kernel

[PATCH v10 00/12] huge vmalloc mappings

Fixed a couple of bugs that Ding noticed in review and testing. Thanks, Nick Since v9: - Fixed intermediate build breakage on x86-32 !PAE [thanks Ding] - Fixed small page fallback case vm_struct double-free [thanks Ding] Since v8: - Fixed nommu compile. - Added Kconfig option help text - Added V

[PATCH v10 01/12] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings

vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. Whether or not a vmap is huge depends on the architecture details, alignments, boot options, etc., which the caller can not be expected to know. Therefore HUGE_VMAP is a regression for vmalloc_to_page. This change teaches vmallo

[PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup

This changes the awkward approach where architectures provide init functions to determine which levels they can provide large mappings for, to one where the arch is queried for each call. This removes code and indirection, and allows constant-folding of dead code for unsupported levels. This also

[PATCH v10 03/12] mm/vmalloc: rename vmap_*_range vmap_pages_*_range

The vmalloc mapper operates on a struct page * array rather than a linear physical address, re-name it to make this distinction clear. Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c

[PATCH v10 06/12] powerpc: inline huge vmap supported functions

This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: linuxppc-...@lists.ozlabs.org Acked-by: Michael Ellerman Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/vmalloc.h | 19 ---

[PATCH v10 04/12] mm/ioremap: rename ioremap_*_range to vmap_*_range

This will be used as a generic kernel virtual mapping function, so re-name it in preparation. Signed-off-by: Nicholas Piggin --- mm/ioremap.c | 64 +++- 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/mm/ioremap.c b/mm/ioremap.c ind

[PATCH v10 02/12] mm: apply_to_pte_range warn and fail if a large pte is encountered

apply_to_pte_range might mistake a large pte for bad, or treat it as a page table, resulting in a crash or corruption. Add a test to warn and return error if large entries are found. Signed-off-by: Nicholas Piggin --- mm/memory.c | 66 +++-- 1 file

[PATCH v10 09/12] mm: Move vmap_range from mm/ioremap.c to mm/vmalloc.c

This is a generic kernel virtual memory mapper, not specific to ioremap. Signed-off-by: Nicholas Piggin --- include/linux/vmalloc.h | 3 + mm/ioremap.c| 197 mm/vmalloc.c| 196 +++ 3 files chan

[PATCH v10 08/12] x86: inline huge vmap supported functions

This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: "H. Peter Anvin" Signed-off-by: Nicholas Piggin --- arch/x86/include/asm/vmallo

[PATCH v10 10/12] mm/vmalloc: add vmap_range_noflush variant

As a side-effect, the order of flush_cache_vmap() and arch_sync_kernel_mappings() calls are switched, but that now matches the other callers in this file. Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/mm/vmal

[PATCH v10 11/12] mm/vmalloc: Hugepage vmalloc mappings

Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC enables support on architectures that define HAVE_ARCH_HUGE_VMAP and supports PMD sized vmap mappings. vmalloc will attempt to allocate PMD-sized pages if allocating PMD size or larger, and fall back to small pages if that wa

[PATCH v10 07/12] arm64: inline huge vmap supported functions

This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Acked-by: Catalin Marinas Signed-off-by: Nicholas Piggin --- arch/arm64/include/asm

[PATCH v10 12/12] powerpc/64s/radix: Enable huge vmalloc mappings

Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Nicholas Piggin --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ arch/powerpc/Kconfig| 1 + arch/powerpc/kernel/module.c| 13 +++-- 3 files changed, 14 insertions(+), 2 deletions(

Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

Hi, thank you for your patch. Le sam. 23 janv. 2021 à 23:01, Qiujun Huang a écrit : We should compile this driver only if we opened PHY_INGENIC_USB. 'opened' -> 'enable'. Signed-off-by: Qiujun Huang You will need to add a Fixes: tag and Cc linux-stable, since the problem is already in

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

On Sat, Jan 23, 2021 at 12:14:39PM -0800, Jakub Kicinski wrote: > On Sat, 23 Jan 2021 18:03:48 +0200 Ido Schimmel wrote: > > [DEVLINK_ATTR_STATS_RX_DROPPED] > > nit: maybe discarded? dropped sounds like may have been due to an > overflow or something Well, it's an existing attribute which is

Re: [PATCH v2] tracing: precise log info for kretprobe addr err

Hi Jianlin, On Sat, 23 Jan 2021 14:21:48 + Jianlin Lv wrote: > Regarding the UPROBES, I read the code of trace_uprobe_create() and found a > place for improvement. > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 3cf7128e1ad3..8c81f04d7755 100644 > --- a/

[PATCH v3 0/4] Fixes to bridge/panel and ingenic-drm

Hi, Here are three independent fixes. The first one addresses a use-after-free in bridge/panel.c; the second one addresses a use-after-free in the ingenic-drm driver; finally, the third one makes the ingenic-drm driver work again on older Ingenic SoCs. Changes from v2: - patch [1/4] added a FIXME

[PATCH v3 1/4] drm: bridge/panel: Cleanup connector on bridge detach

If we don't call drm_connector_cleanup() manually in panel_bridge_detach(), the connector will be cleaned up with the other DRM objects in the call to drm_mode_config_cleanup(). However, since our drm_connector is devm-allocated, by the time drm_mode_config_cleanup() will be called, our connector w

Re: [PATCH] driver core: Fix a reource leak in 'fw_devlink_create_devlink()'

On Sat, Jan 23, 2021 at 10:32 PM Christophe JAILLET wrote: > > In 'fw_devlink_create_devlink()', all exit paths, successful or not, > release the reference taken on 'sup_dev'. > All but this one. > > Use the existing error handling case to call the missing 'put_device()'. > > Fixes: f9aa460672c9c

[PATCH v3 2/4] drm/simple_kms_helper: Add macro drmm_plain_simple_encoder_alloc()

This performs the same operation as drmm_simple_encoder_alloc(), but only allocates and returns a struct drm_encoder instance. Signed-off-by: Paul Cercueil --- include/drm/drm_simple_kms_helper.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/drm/drm_simple_kms_he

[PATCH v3 3/4] drm/ingenic: Register devm action to cleanup encoders

Since the encoders have been devm-allocated, they will be freed way before drm_mode_config_cleanup() is called. To avoid use-after-free conditions, we then must ensure that drm_encoder_cleanup() is called before the encoders are freed. v2: Use the new __drmm_simple_encoder_alloc() function v3: Us

[PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

Even though the JZ4740 did not have the OSD mode, it had (according to the documentation) two DMA channels, but there is absolutely no information about how to select the second DMA channel. Make the ingenic-drm driver work in non-OSD mode by using the foreground0 plane (which is bound to the DMA0

Re: [PATCH] printk: fix buffer overflow potential for print_text()

John Ogness writes: > Hi Sven, > > Thanks for the outstanding analysis! > > On 2021-01-23, Sven Schnelle wrote: >>> 1401if (buf_size > 0) >>> 1402text[len] = 0; >> >> I don't think i have really understood how all the printk magic works, >> but using r->te

Re: [RE-RESEND PATCH 1/4] usb: musb: Fix runtime PM race in musb_queue_resume_work

Hi Sergei, Le sam. 23 janv. 2021 à 19:41, Sergei Shtylyov a écrit : On 1/23/21 5:24 PM, Paul Cercueil wrote: musb_queue_resume_work() would call the provided callback if the runtime PM status was 'active'. Otherwise, it would enqueue the request if the hardware was still suspended (mus

[PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card

From: Tony Lindgren We can have multiple connections on a single McBSP instance configured with audio graph card when using TDM (Time Division Multiplexing). Let's allow that by configuring dais dynamically. See Documentation/devicetree/bindings/sound/audio-graph-card.txt and Documentation/devic

drivers/interconnect/qcom/icc-rpmh.c:132:28: sparse: sparse: incorrect type in assignment (different base types)

date: 5 months ago config: arm64-randconfig-s031-20210124 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install

UBSAN: shift-out-of-bounds in load_balance

Hello, syzbot found the following issue on: HEAD commit:bc085f8f Add linux-next specific files for 20210121 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=10b71a2cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=1224bbf217b0bec8 dashboard

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

Hi Paul, we observed the same issue on the jz4730 (which is almost identical to the jz4740 wrt. LCDC) and our solution [1] was simpler. It leaves the hwdesc f0 and f1 as they are and just takes f1 for really programming the first DMA descriptor if there is no OSD. We have tested on jz4730 and jz4

undefined reference to `cpu_sa110_suspend_size'

date: 8 months ago config: arm-randconfig-r035-20210124 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

Hi Nikolaus, Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a écrit : Hi Paul, we observed the same issue on the jz4730 (which is almost identical to the jz4740 wrt. LCDC) and our solution [1] was simpler. It leaves the hwdesc f0 and f1 as they are and just takes f1 for really programm

[PATCH v2] PHY: Ingenic: Fixes: compile phy-ingenic-usb only if it was enabled

We should compile this driver only if we enable PHY_INGENIC_USB. Signed-off-by: Qiujun Huang --- v2: Add a Fixes:tag and Cc linux-stable --- drivers/phy/ingenic/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefil

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

Hi Paul, > Am 24.01.2021 um 10:43 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a > écrit : >> Hi Paul, >> we observed the same issue on the jz4730 (which is almost identical >> to the jz4740 wrt. LCDC) and our solution [1] was simpler. >> It

linux-next: Signed-off-by missing for commit in the gfs2 tree

Hi all, Commit d2097641ed78 ("gfs2: Fix invalid block size message") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpeiVw2fSrXm.pgp Description: OpenPGP digital signature

Re: [PATCH v2] PHY: Ingenic: Fixes: compile phy-ingenic-usb only if it was enabled

On Sun, Jan 24, 2021 at 05:42:49PM +0800, Qiujun Huang wrote: > We should compile this driver only if we enable PHY_INGENIC_USB. > > Signed-off-by: Qiujun Huang > --- > v2: > Add a Fixes:tag and Cc linux-stable I don't see a Fixes: tag here :( This is not the correct way to submit patches for

[PATCH] trace: Fix race in trace_open and buffer resize call

Below race can come, if trace_open and resize of cpu buffer is running parallely on different cpus CPUXCPUY ring_buffer_resize atomic_read(&buffer->resize_disabled) tracing_open tracing_reset_onl

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

On 1/24/2021 8:51 AM, Steven Rostedt wrote: On Sat, 23 Jan 2021 22:03:27 +0530 Gaurav Kohli wrote: Sure I will do, I have never posted on backport branches. Let me check and post it. Basically you take your original patch that was in mainline (as the subject and commit message), and mak

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

On Sun, Jan 24, 2021 at 03:27:25PM +0530, Gaurav Kohli wrote: > > > On 1/24/2021 8:51 AM, Steven Rostedt wrote: > > On Sat, 23 Jan 2021 22:03:27 +0530 > > Gaurav Kohli wrote: > > > > > > > Sure I will do, I have never posted on backport branches. Let me check > > > and post it. > > > > > > >

Re: [PATCH] trace: Fix race in trace_open and buffer resize call

On Sun, Jan 24, 2021 at 03:26:33PM +0530, Gaurav Kohli wrote: > Below race can come, if trace_open and resize of You forgot to cc: stable, and put the git id that this patch is upstream...

Re: [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling

On Sat, Jan 23, 2021 at 07:26:24PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 09:47:01 +0100 Lukas Wunner wrote: > > sch_handle_egress() returns either the skb or NULL to signal to its > > caller __dev_queue_xmit() whether a packet should continue to be > > processed. > > > > The skb is al

drivers/remoteproc/ti_k3_r5_remoteproc.c:377:28: sparse: sparse: incorrect type in argument 1 (different address spaces)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e1ae4b0be15891faf46d390e9f3dc9bd71a8cae1 commit: 34f2653686fecc9bd5a4ee16724768c72953fb57 remoteproc: k3-r5: Initialize TCM memories for ECC date: 3 months ago config: arm64-randconfig-s031-20210124

[GIT PULL] x86/urgent for v5.11-rc5

Hi Linus, please pull the collection of x86 urgent fixes for 5.11 accumulated so far. Thx. --- The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linu

[GIT PULL] timers/urgent for v5.11-rc5

Hi Linus, please pull two urgent fixes to the timers machinery, for v5.11. Thx. --- The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH net v5] net: lapb: Add locking to the lapb module

On Sat, Jan 23, 2021 at 8:45 PM Jakub Kicinski wrote: > > > > @@ -178,11 +182,23 @@ int lapb_unregister(struct net_device *dev) > > > goto out; > > > lapb_put(lapb); > > > > > > + /* Wait for other refs to "lapb" to drop */ > > > + while (refcount_read(&lapb->refcnt) > 2) > > >

[PATCH] ACPICA: Common: Fix a typo

This module is 'cmfsize', not 'cfsize'. Fix it. Signed-off-by: Christophe JAILLET --- tools/power/acpi/common/cmfsize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/power/acpi/common/cmfsize.c b/tools/power/acpi/common/cmfsize.c index 9ea2c0aeb86c..185b8c588e1d 1006

Re: [PATCH v10 01/12] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings

On Sun, Jan 24, 2021 at 06:22:19PM +1000, Nicholas Piggin wrote: > vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. > Whether or not a vmap is huge depends on the architecture details, > alignments, boot options, etc., which the caller can not be expected > to know. Therefore H

Re: [PATCH v10 02/12] mm: apply_to_pte_range warn and fail if a large pte is encountered

On Sun, Jan 24, 2021 at 06:22:20PM +1000, Nicholas Piggin wrote: > apply_to_pte_range might mistake a large pte for bad, or treat it as a > page table, resulting in a crash or corruption. Add a test to warn and > return error if large entries are found. Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v10 03/12] mm/vmalloc: rename vmap_*_range vmap_pages_*_range

On Sun, Jan 24, 2021 at 06:22:21PM +1000, Nicholas Piggin wrote: > The vmalloc mapper operates on a struct page * array rather than a > linear physical address, re-name it to make this distinction clear. > > Signed-off-by: Nicholas Piggin Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v10 04/12] mm/ioremap: rename ioremap_*_range to vmap_*_range

On Sun, Jan 24, 2021 at 06:22:22PM +1000, Nicholas Piggin wrote: > This will be used as a generic kernel virtual mapping function, so > re-name it in preparation. The new name looks ok, but shouldn't it also move to vmalloc.c with the more generic name and purpose?

Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup

> diff --git a/arch/arm64/include/asm/vmalloc.h > b/arch/arm64/include/asm/vmalloc.h > index 2ca708ab9b20..597b40405319 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -1,4 +1,12 @@ > #ifndef _ASM_ARM64_VMALLOC_H > #define _ASM_ARM64_VMALLOC_H > >

kernel/sched/core.c:6854:20: warning: unused function 'balance_hotplug_wait'

months ago config: mips-randconfig-r025-20210124 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bd3a387ee76f58caa0d7901f3f84e9bb3d006f27) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

RE: [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface

Hi Greg, Thank you for the review. > -Original Message- > From: Greg KH > Sent: Wednesday, January 20, 2021 11:30 PM > To: mgr...@linux.intel.com > Cc: markgr...@kernel.org; a...@arndb.de; b...@suse.de; > damien.lem...@wdc.com; dragan.cve...@xilinx.com; cor...@lwn.net; > leonard.cres...@

[PATCH v2 RFC net-next 01/18] doc: marvell: add cm3-mem device tree bindings description

From: Stefan Chulski Signed-off-by: Stefan Chulski --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt index b783976..f9f8cc6

[PATCH v2 RFC net-next 02/18] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree

From: Konstantin Porotchkin CM3 SRAM address space would be used for Flow Control configuration. Signed-off-by: Stefan Chulski --- arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch

[PATCH v2 RFC net-next 04/18] net: mvpp2: add PPv23 version definition

From: Stefan Chulski This patch add PPv23 version definition. PPv23 is new packet processor in CP115. Everything that supported by PPv22, also supported by PPv23. No functional changes in this stage. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 +++

[PATCH v2 RFC net-next 09/18] net: mvpp2: add FCA RXQ non occupied descriptor threshold

From: Stefan Chulski RXQ non occupied descriptor threshold would be used by Flow Control Firmware feature to move to the XOFF mode. RXQ non occupied threshold would change interrupt cause that polled by CM3 Firmware. Actual non occupied interrupt masked and won't trigger interrupt. Signed-off-by

[PATCH v2 RFC net-next 18/18] net: mvpp2: add TX FC firmware check

From: Stefan Chulski Patch check that TX FC firmware is running in CM3. If not, global TX FC would be disabled. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 41 2 files changed,

RE: [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

Hi Greg, Thank you for the review. > -Original Message- > From: Greg KH > Sent: Wednesday, January 20, 2021 11:28 PM > To: mgr...@linux.intel.com > Cc: markgr...@kernel.org; a...@arndb.de; b...@suse.de; > damien.lem...@wdc.com; dragan.cve...@xilinx.com; cor...@lwn.net; > leonard.cres...@

[PATCH v2 RFC net-next 17/18] net: mvpp2: limit minimum ring size to 1024 descriptors

From: Stefan Chulski To support Flow Control ring size should be at least 1024 descriptors. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/eth

[watchdog v2] watchdog: mei_wdt: request stop on unregister

From: Alexander Usyskin The MEI bus has a special behavior on suspend it destroys all the attached devices, this is due to the fact that also firmware context is not persistent across power flows. If watchdog on MEI bus is ticking before suspending the firmware times out and reports that the OS

[PATCH v2 RFC net-next 16/18] net: mvpp2: set 802.3x GoP Flow Control mode

From: Stefan Chulski This patch fix GMAC TX flow control autoneg. Flow control autoneg wrongly were disabled with enabled TX flow control. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v2 RFC net-next 15/18] net: mvpp2: add PPv23 RX FIFO flow control

From: Stefan Chulski New FIFO flow control feature were added in PPv23. PPv2 FIFO polled by HW and trigger pause frame if FIFO fill level is below threshold. FIFO HW flow control enabled with CM3 RXQ&BM flow control with ethtool. Current FIFO thresholds is: 9KB for port with maximum speed 10Gb/s

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

On Wed, Jan 20, 2021 at 8:45 PM Alexei Starovoitov wrote: > > On Tue, Jan 12, 2021 at 12:55 PM Yuri Benditovich > wrote: > > > > On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich > > wrote: > > > > > > On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich > > > wrote: > > > > > > > > This program ty

[PATCH v2 RFC net-next 14/18] net: mvpp2: add BM protection underrun feature support

From: Stefan Chulski Feature double size of BPPI by decreasing number of pools from 16 to 8. Increasing of BPPI size protect BM drop from BPPI underrun. Underrun could occurred due to stress on DDR and as result slow buffer transition from BPPE to BPPI. New BPPI threshold recommended by spec is:

[PATCH v2 RFC net-next 13/18] net: mvpp2: add ethtool flow control configuration support

From: Stefan Chulski This patch add ethtool flow control configuration support. Tx flow control retrieved correctly by ethtool get function. FW per port ethtool configuration capability added. Patch also takes care about mtu change procedure, if PPv2 switch BM pools during mtu change. Signed-o

[PATCH v2 RFC net-next 11/18] net: mvpp2: enable global flow control

From: Stefan Chulski This patch enables global flow control in FW and in the phylink validate mask. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 3 +++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 20 +++- 2 files changed, 22 inserti

[PATCH v2 RFC net-next 10/18] net: mvpp2: add spinlock for FW FCA configuration path

From: Stefan Chulski Spinlock added to MSS shared memory configuration space. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/etherne

[PATCH v2 RFC net-next 12/18] net: mvpp2: add RXQ flow control configurations

From: Stefan Chulski This patch add RXQ flow control configurations. Patch do not enable flow control itself, flow control disabled by default. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 40 ++- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 111

Re: [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

On Sun, Jan 24, 2021 at 11:48:29AM +, Thokala, Srikanth wrote: > > > +{ > > > + struct pci_epf_bar *epf_bar; > > > + bool bar_fixed_64bit; > > > + int ret, i; > > > + > > > + for (i = BAR_0; i <= BAR_5; i++) { > > > + epf_bar = &epf->bar[i]; > > > + bar_fixed_64bit = !!(epc_feat

[PATCH v2 RFC net-next 07/18] net: mvpp2: increase RXQ size to 1024 descriptors

From: Stefan Chulski RXQ size increased to support Firmware Flow Control. Minimum depletion thresholds to support FC is 1024 buffers. Default set to 1024 descriptors and maximum size to 2048. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 4 ++-- 1 file changed,

[PATCH v2 RFC net-next 05/18] net: mvpp2: always compare hw-version vs MVPP21

From: Stefan Chulski Currently we have PP2v1 and PP2v2 hw-versions, with some different handlers depending upon condition hw_version = MVPP21/MVPP22. In a future there will be also PP2v3. Let's use now the generic "if equal/notEqual MVPP21" for all cases instead of "if MVPP22". This patch does n

[PATCH v2 RFC net-next 06/18] net: mvpp2: increase BM pool size to 2048 buffers

From: Stefan Chulski BM pool size increased to support Firmware Flow Control. Minimum depletion thresholds to support FC is 1024 buffers. BM pool size increased to 2048 to have some 1024 buffers space between depletion thresholds and BM pool size. Jumbo frames require a 9888B buffer, so memory r

[PATCH v2 RFC net-next 08/18] net: mvpp2: add FCA periodic timer configurations

From: Stefan Chulski Flow Control periodic timer would be used if port in XOFF to transmit periodic XOFF frames. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45 2 files cha

[GIT PULL] sched/urgent for v5.11-rc5

Hi Linus, please pull the sched/urgent fixes for v5.11. Thx. --- The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tags

kernel/kcov.c:180:8: error: implicit declaration of function 'kaslr_offset'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e1ae4b0be15891faf46d390e9f3dc9bd71a8cae1 commit: a307a4ce9ecd2e23c71318201330d9d648b3f818 MIPS: Loongson64: Add KASLR support date: 8 weeks ago config: mips-randconfig-r004-20210124 (attached as .config

[PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map

From: Stefan Chulski This patch adds CM3 memory map and CM3 read/write callbacks. No functionality changes. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 ++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 74 +++- 2 files changed, 78

kernel BUG in split_huge_page_to_list

Hello, syzbot found the following issue on: HEAD commit:647060f3 Add linux-next specific files for 20210120 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16f0353f50 kernel config: https://syzkaller.appspot.com/x/.config?x=8f8a72b7e5067002 dashboard

[PATCH v2 RFC net-next 00/18] net: mvpp2: Add TX Flow Control support

From: Stefan Chulski Armada hardware has a pause generation mechanism in GOP (MAC). The GOP generate flow control frames based on an indication programmed in Ports Control 0 Register. There is a bit per port. However assertion of the PortX Pause bits in the ports control 0 register only sends a

Re: [PATCH v10 04/12] mm/ioremap: rename ioremap_*_range to vmap_*_range

Excerpts from Christoph Hellwig's message of January 24, 2021 9:36 pm: > On Sun, Jan 24, 2021 at 06:22:22PM +1000, Nicholas Piggin wrote: >> This will be used as a generic kernel virtual mapping function, so >> re-name it in preparation. > > The new name looks ok, but shouldn't it also move to vma

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-5 tag

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.11: The following changes since commit 41131a5e54ae7ba5a2bb8d7b30d1818b3f5b13d2: powerpc/vdso: Fix clock_gettime_fallback for vdso32 (2021-01-14 15:56:44 +1100) are available in the git repos

[GIT PULL] objtool/urgent for v5.11-rc5

Hi Linus, please pull three urgent objtool fixes resulting from recent toolchain changes. Thx. --- The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/

Re: [PATCH v2 RFC net-next 08/18] net: mvpp2: add FCA periodic timer configurations

On Sun, Jan 24, 2021 at 01:43:57PM +0200, stef...@marvell.com wrote: > +/* Set Flow Control timer x140 faster than pause quanta to ensure that link > + * partner won't send taffic if port in XOFF mode. Can you explain more why 140 times faster is desirable here? Why 140 times and not, say, 10 time

Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup

Excerpts from Christoph Hellwig's message of January 24, 2021 9:40 pm: >> diff --git a/arch/arm64/include/asm/vmalloc.h >> b/arch/arm64/include/asm/vmalloc.h >> index 2ca708ab9b20..597b40405319 100644 >> --- a/arch/arm64/include/asm/vmalloc.h >> +++ b/arch/arm64/include/asm/vmalloc.h >> @@ -1,4 +1

Re: [PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map

On Sun, Jan 24, 2021 at 01:43:52PM +0200, stef...@marvell.com wrote: > +static int mvpp2_get_sram(struct platform_device *pdev, > + struct mvpp2 *priv) > +{ > + struct device_node *dn = pdev->dev.of_node; > + static bool defer_once; > + struct resource *res; > + >

[GIT PULL] irq/urgent for v5.11-rc5

Hi Linus, please pull the pile of urgent irq{,chip} fixes for v5.11. Thx. --- The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/

kernel/bpf/verifier.c:11937:5: warning: stack frame size of 1056 bytes in function 'bpf_check'

-r005-20210124 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bd3a387ee76f58caa0d7901f3f84e9bb3d006f27) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod

Re: [PATCH v2 RFC net-next 13/18] net: mvpp2: add ethtool flow control configuration support

On Sun, Jan 24, 2021 at 01:44:02PM +0200, stef...@marvell.com wrote: > @@ -6407,6 +6490,29 @@ static void mvpp2_mac_link_up(struct phylink_config > *config, >val); > } > > + if (tx_pause && port->priv->global_tx_fc) { > + port->tx_fc = true; > +

RE: [EXT] Re: [PATCH v2 RFC net-next 13/18] net: mvpp2: add ethtool flow control configuration support

> > -- > On Sun, Jan 24, 2021 at 01:44:02PM +0200, stef...@marvell.com wrote: > > @@ -6407,6 +6490,29 @@ static void mvpp2_mac_link_up(struct > phylink_config *config, > > val); > > } > > > > + if (t

[PATCH v10 1/2] mm: Optional full ASLR for mmap(), vdso, stack and heap

Writing a new value of 3 to /proc/sys/kernel/randomize_va_space enables full randomization of memory mappings. With 2, the base of the VMA used for such mappings is random, but the mappings are created in predictable places within the VMA and in sequential order. With 3, new VMAs are created to ful

[PATCH v10 2/2] mm/mremap: optionally randomize mremap(..., MREMAP_MAYMOVE)

New sysctl kernel.randomize_mremap, when set, can be used to force mremap(..., MREMAP_MAYMOVE) to always move the mappings even if not necessary. In addition to improved address space layout randomization, this can expose bugs where the caller is not actually expecting a moved mapping, even though

Re: [PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map

On Sun, Jan 24, 2021 at 01:43:52PM +0200, stef...@marvell.com wrote: > + priv->sram_pool = of_gen_pool_get(dn, "cm3-mem", 0); > + if (!priv->sram_pool) { > + if (!defer_once) { > + defer_once = true; > +

[GIT PULL] misc fixes for v5.11-rc5

Hi Linus, Here are some fixes for v5.11-rc5 that should hopefully be fairly uncontroversial. I've had them sitting around for a bit but only got around sending them now after concluding the idmapped mounts stuff. Sorry for the delay. /* Summary */ - Jann reported sparse complaints because of a mi

[GIT PULL] USB driver fixes for 5.11-rc5

The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.11-rc5 for you to fetch changes up to ef02684c4e67d8c35ac83

  1   2   3   4   5   >