Hi Greg,
Thank you for the review.
> -----Original Message-----
> From: Greg KH <gre...@linuxfoundation.org>
> Sent: Wednesday, January 20, 2021 11:30 PM
> To: mgr...@linux.intel.com
> Cc: markgr...@kernel.org; a...@arndb.de; b...@suse.de;
> damien.lem...@wdc.com; dragan.cve...@xilinx.com; cor...@lwn.net;
> leonard.cres...@nxp.com; palmerdabb...@google.com;
> paul.walms...@sifive.com; peng....@nxp.com; robh...@kernel.org;
> shawn...@kernel.org; jassisinghb...@gmail.com; linux-
> ker...@vger.kernel.org; Thokala, Srikanth <srikanth.thok...@intel.com>
> Subject: Re: [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface
>
> On Fri, Jan 08, 2021 at 01:25:41PM -0800, mgr...@linux.intel.com wrote:
> > From: Srikanth Thokala <srikanth.thok...@intel.com>
> >
> > Provide interface for XLink layer to interact with XLink PCIe transport
> > layer on both local host and remote host.
> >
> > Cc: Arnd Bergmann <a...@arndb.de>
> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > Reviewed-by: Mark Gross <mgr...@linux.intel.com>
> > Signed-off-by: Srikanth Thokala <srikanth.thok...@intel.com>
> > ---
> > drivers/misc/xlink-pcie/common/interface.c | 109 +++++++++++++++++++
> > drivers/misc/xlink-pcie/local_host/Makefile | 1 +
> > drivers/misc/xlink-pcie/remote_host/Makefile | 1 +
> > 3 files changed, 111 insertions(+)
> > create mode 100644 drivers/misc/xlink-pcie/common/interface.c
> >
> > diff --git a/drivers/misc/xlink-pcie/common/interface.c
> b/drivers/misc/xlink-pcie/common/interface.c
> > new file mode 100644
> > index 000000000000..56c1d9ed9d8f
> > --- /dev/null
> > +++ b/drivers/misc/xlink-pcie/common/interface.c
> > @@ -0,0 +1,109 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> >
> +/************************************************************************
> *****
> > + *
> > + * Intel Keem Bay XLink PCIe Driver
> > + *
> > + * Copyright (C) 2020 Intel Corporation
> > + *
> > +
> **************************************************************************
> **/
>
> Do you really need the ******* mess? :)
It is not required; I will clean up.
>
> > +
> > +#include <linux/xlink_drv_inf.h>
> > +
> > +#include "core.h"
> > +#include "xpcie.h"
> > +
> > +/* Define xpcie driver interface API */
> > +int xlink_pcie_get_device_list(u32 *sw_device_id_list, u32
> *num_devices)
> > +{
> > + if (!sw_device_id_list || !num_devices)
> > + return -EINVAL;
> > +
> > + *num_devices = intel_xpcie_get_device_num(sw_device_id_list);
> > +
> > + return 0;
> > +}
> > +EXPORT_SYMBOL(xlink_pcie_get_device_list);
>
> EXPORT_SYMBOL_GPL() for all of these perhaps? I have to ask...
I agree with Mark, will make the change to use EXPORT_SYMBOL_GPL().
Thanks!
Srikanth
>
> thanks,
>
> greg k-h
