Re: [PATCH] leds: Use DEVICE_ATTR_{RW, RO, WO} macros

2020-12-13 Thread Lukas Bulwahn
On Sat, Dec 12, 2020 at 8:56 PM Dwaipayan Ray wrote: > > Instead of open coding DEVICE_ATTR() defines, use the > DEVICE_ATTR_RW(), DEVICE_ATTR_WO(), and DEVICE_ATTR_RO() > macros intead. typo: s/intead/instead/ No need to use the word "instead" twice in one sentence, though, we got it :) > > Th

Re: [PATCH] leds: Use DEVICE_ATTR_{RW, RO, WO} macros

2020-12-13 Thread Dwaipayan Ray
On Sun, Dec 13, 2020 at 1:31 PM Lukas Bulwahn wrote: > > On Sat, Dec 12, 2020 at 8:56 PM Dwaipayan Ray wrote: > > > > Instead of open coding DEVICE_ATTR() defines, use the > > DEVICE_ATTR_RW(), DEVICE_ATTR_WO(), and DEVICE_ATTR_RO() > > macros intead. > > typo: s/intead/instead/ > > No need to us

Re: kernelci/staging-next bisection: sleep.login on rk3288-rock2-square #2286-staging

2020-12-13 Thread Mike Rapoport
Hi Guillaume, On Fri, Dec 11, 2020 at 09:53:46PM +, Guillaume Tucker wrote: > Hi Mike, > > Please see the bisection report below about a boot failure on > rk3288 with next-20201210. > > Reports aren't automatically sent to the public while we're > trialing new bisection features on kernelci.

Re: [PATCH v2 5/5] clk: qcom: gcc: Add clock driver for SM8350

2020-12-13 Thread Taniya Das
On 12/11/2020 12:40 PM, Stephen Boyd wrote: Quoting Vinod Koul (2020-12-10 21:43:49) On 10-12-20, 12:43, Stephen Boyd wrote: +static struct clk_branch gcc_camera_ahb_clk = { + .halt_reg = 0x26004, + .halt_check = BRANCH_HALT_DELAY, + .hwcg_reg = 0x26004, + .hwcg_bit =

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-13 Thread Neftin, Sasha
On 12/10/2020 07:28, Neftin, Sasha wrote: On 12/10/2020 04:24, Alexander Duyck wrote: On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: On 1

Re: [PATCH 07/13] ia64: make SPARSEMEM default and disable DISCONTIGMEM

2020-12-13 Thread Mike Rapoport
On Sat, Dec 12, 2020 at 08:01:44AM -0800, Guenter Roeck wrote: > On Tue, Oct 27, 2020 at 01:29:49PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > SPARSEMEM memory model suitable for systems with large holes in their > > phyiscal memory layout. With SPARSEMEM_VMEMMAP enabled it provi

Re: [PATCH] leds: Use DEVICE_ATTR_{RW, RO, WO} macros

2020-12-13 Thread Joe Perches
On Sun, 2020-12-13 at 13:48 +0530, Dwaipayan Ray wrote: > On Sun, Dec 13, 2020 at 1:31 PM Lukas Bulwahn wrote: [] > > Will you also add a checkpatch rule to identify other DEVICE_ATTR(...) > > that can be adjusted to the refined macros, so that checkpatch informs > > other submitters as well? > >

Re: [PATCH v3 0/3] Support wakeup methods of Atmel maXTouch controllers

2020-12-13 Thread Dmitry Osipenko
13.12.2020 07:41, Dmitry Torokhov пишет: > Thank you for the logs. I am confused where these calls to put the > controller into deep sleep are coming from. Does something constantly > open and close input device? Input devices are re-opened multiple times during Linux distro boot-up, a regular Ubu

[tip: timers/core] ntp: Fix prototype in the !CONFIG_GENERIC_CMOS_UPDATE case

2020-12-13 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the timers/core branch of tip: Commit-ID: 3cabca87b329cbcbdf295be0094adbd72c7b1f67 Gitweb: https://git.kernel.org/tip/3cabca87b329cbcbdf295be0094adbd72c7b1f67 Author:Ingo Molnar AuthorDate:Sat, 12 Dec 2020 18:29:20 +01:00 Committer

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-13 Thread Yonatan Linik
On Sat, Dec 12, 2020 at 11:51 PM Jakub Kicinski wrote: > > On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote: > > On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > > > > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > > > proc_fs was used, in af_packet, without a surrou

Re: [PATCH v3 5/9] spi: spi-mem: Allow masters to transfer dummy cycles directly by hardware

2020-12-13 Thread Boris Brezillon
On Sat, 12 Dec 2020 09:28:50 -0800 Sowjanya Komatineni wrote: > On 12/12/20 2:57 AM, Boris Brezillon wrote: > > On Fri, 11 Dec 2020 13:15:59 -0800 > > Sowjanya Komatineni wrote: > > > >> This patch adds a flag SPI_MASTER_USES_HW_DUMMY_CYCLES for the controllers > >> that support transfer of du

[PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

2020-12-13 Thread Bongsu Jeon
From: Bongsu Jeon add the code to release the nfc firmware when the firmware image size is wrong. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c

[PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep

2020-12-13 Thread Bongsu Jeon
From: Bongsu Jeon remove the delay for nfc sleep because nfc doesn't need the sleep delay. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/phy_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_common.c i

linux-next: Signed-off-by missing for commit in the cifs tree

2020-12-13 Thread Stephen Rothwell
Hi all, Commit 3aa4e616197b ("cifs: Register generic netlink family") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpeEQB7GcsLr.pgp Description: OpenPGP digital signature

Re: [PATCH v3 6/9] spi: tegra210-quad: Add support for hardware dummy cycles

2020-12-13 Thread Boris Brezillon
On Fri, 11 Dec 2020 13:16:00 -0800 Sowjanya Komatineni wrote: > Tegra Quad SPI controller hardware supports sending dummy cycles > after address bytes. > > This patch adds this support. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/spi/spi-tegra210-quad.c | 22 +-

Re: [PATCH v3] driver core: platform: don't oops in platform_shutdown() on unbound devices

2020-12-13 Thread Uwe Kleine-König
On Sun, Dec 13, 2020 at 02:55:33AM +0300, Dmitry Baryshkov wrote: > On shutdown the driver core calls the bus' shutdown callback also for > unbound devices. A driver's shutdown callback however is only called for > devices bound to this driver. Commit 9c30921fe799 ("driver core: > platform: use bus

Re: [PATCH] thermal/core: Make 'forced_passive' as obsolete candidate

2020-12-13 Thread Daniel Lezcano
On 13/12/2020 02:11, Matthew Garrett wrote: > On Sun, Dec 13, 2020 at 12:39:26AM +0100, Daniel Lezcano wrote: >> On 12/12/2020 21:08, Matthew Garrett wrote: >>> Anything that provides a trip point that has no active notifications and >>> doesn't provide any information that tells the kernel to poll

UBSAN: shift-out-of-bounds in strset_parse_request

2020-12-13 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a9e26cb5 Add linux-next specific files for 20201208 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1752cf1750 kernel config: https://syzkaller.appspot.com/x/.config?x=e259434a8eaf0206 dashboard

Re: [patch 20/30] net/mlx4: Replace irq_to_desc() abuse

2020-12-13 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

Re: [PATCH v3 1/2] usb: dwc3: drd: Avoid error when extcon is missing

2020-12-13 Thread Andy Shevchenko
On Sun, Dec 13, 2020 at 5:22 AM Sam Protsenko wrote: > > If "port" node is missing in PHY controller node, dwc3_get_extcon() > isn't able to find extcon device. This is perfectly fine in case when devices > "usb-role-switch" or OTG is used, but next misleading error message is > printed in that

Re: [PATCH v3 2/2] usb: dwc3: drd: Improve dwc3_get_extcon() style

2020-12-13 Thread Andy Shevchenko
On Sun, Dec 13, 2020 at 5:27 AM Sam Protsenko wrote: > > Commit c73b41955ee4 ("usb: dwc3: drd: Avoid error when extcon is The previous change ("... (because we don't know the actual commit id) > missing") changed the code flow in dwc3_get_extcon() function, leading > to unnecessary if-branch. T

Re: [PATCH v3 5/9] spi: spi-mem: Allow masters to transfer dummy cycles directly by hardware

2020-12-13 Thread Boris Brezillon
On Sun, 13 Dec 2020 10:54:26 +0100 Boris Brezillon wrote: > On Sat, 12 Dec 2020 09:28:50 -0800 > Sowjanya Komatineni wrote: > > > On 12/12/20 2:57 AM, Boris Brezillon wrote: > > > On Fri, 11 Dec 2020 13:15:59 -0800 > > > Sowjanya Komatineni wrote: > > > > > >> This patch adds a flag SPI_

Re: [patch 21/30] net/mlx4: Use effective interrupt affinity

2020-12-13 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

2020-12-13 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation

Re: [patch 23/30] net/mlx5: Use effective interrupt affinity

2020-12-13 Thread Tariq Toukan
On 12/10/2020 9:25 PM, Thomas Gleixner wrote: Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even

Re: KASAN: use-after-free Read in disk_part_iter_next

2020-12-13 Thread Ming Lei
On Fri, Dec 11, 2020 at 01:03:11PM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:15ac8fdb Add linux-next specific files for 20201207 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15d8ad3750 > kernel config

[PATCH] net: mscc: ocelot: Fix a resource leak in the error handling path of the probe function

2020-12-13 Thread Christophe JAILLET
In case of error after calling 'ocelot_init()', it must be undone by a corresponding 'ocelot_deinit()' call, as already done in the remove function. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mscc/ocelot_vsc7514

Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres

2020-12-13 Thread Jonathan Cameron
On Fri, 11 Dec 2020 12:15:15 + Anand Ashok Dumbre wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Monday 30 November 2020 8:21 PM > > To: Bartosz Golaszewski > > Cc: Lars-Peter Clausen ; Peter Meerwald-Stadler > > ; Michal Simek ; linux- > > i...@vger.kernel.org;

Re: [PATCH -next] iio: chemical: pms7003: convert comma to semicolon

2020-12-13 Thread Jonathan Cameron
On Fri, 11 Dec 2020 16:57:00 +0800 Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Applied to the togreg branch of iio.git and pushed out as testing because of other things in that tree. Thanks, Jonathan > --- > drivers/i

[no subject]

2020-12-13 Thread george mike
Hallo Mein Name ist George Mike. Ich bin von Beruf Rechtsanwalt. Ich möchte Ihnen anbieten der nächste Verwandte meines Klienten. Sie erben die Summe von (8,5 Millionen US-Dollar) Dollar, die mein Kunde vor seinem Tod auf der Bank gelassen hat. Mein Kunde ist ein Staatsbürger Ihres Landes, der mi

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Guenter Roeck
On 12/12/20 9:04 PM, Miguel Ojeda wrote: > On Sat, Dec 12, 2020 at 5:18 PM Guenter Roeck wrote: >> >> This patch results in: >> >> arch/sh/kernel/cpu/sh4a/smp-shx3.c: In function 'shx3_prepare_cpus': >> arch/sh/kernel/cpu/sh4a/smp-shx3.c:76:3: error: ignoring return value of >> 'request_irq' decl

Re: [PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Nikolay Aleksandrov
On 13/12/2020 04:40, Vladimir Oltean wrote: > Currently the bridge emits atomic switchdev notifications for > dynamically learnt FDB entries. Monitoring these notifications works > wonders for switchdev drivers that want to keep their hardware FDB in > sync with the bridge's FDB. > > For example s

[PATCH rdma-rc 0/5] Fixes to v5.10

2020-12-13 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is another series with various fixes that can easily go to -next too. Thanks Leon Romanovsky (1): RDMA/cma: Don't overwrite sgid_attr after device is released Maor Gottlieb (2): RDMA/mlx5: Fix MR cache memory leak RDMA/ucma: Fix memory leak of connection r

Re: [PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Nikolay Aleksandrov
On 13/12/2020 15:22, Nikolay Aleksandrov wrote: > On 13/12/2020 04:40, Vladimir Oltean wrote: >> Currently the bridge emits atomic switchdev notifications for >> dynamically learnt FDB entries. Monitoring these notifications works >> wonders for switchdev drivers that want to keep their hardware FD

[PATCH v2 03/11] perf c2c: Add dimensions for load miss

2020-12-13 Thread Leo Yan
Add dimensions for load miss and its percentage calculation, which is to be displayed in the single cache line output. Signed-off-by: Leo Yan --- tools/perf/builtin-c2c.c | 107 +++ 1 file changed, 107 insertions(+) diff --git a/tools/perf/builtin-c2c.c b/too

[PATCH v2 04/11] perf c2c: Rename for shared cache line stats

2020-12-13 Thread Leo Yan
For shared cache line statistics, it relies on HITM. We can use more general naming rather than only binding to HITM, so replace "hitm_stats" with "shared_clines_stats" in structure perf_c2c, and rename function resort_hitm_cb() to resort_shared_cl_cb(). Signed-off-by: Leo Yan --- tools/perf/bu

[PATCH v2 00/11] perf c2c: Sort cacheline with all loads

2020-12-13 Thread Leo Yan
This patch set is to sort cache line for all load operations which hit any cache levels. For single cache line view, it shows the load references for loads with cache hits and with cache misses respectively. This series is a following for the old patch set "perf c2c: Sort cacheline with LLC load"

[PATCH v2 01/11] perf c2c: Add dimensions for total load hit

2020-12-13 Thread Leo Yan
Arm SPE trace data doesn't support HITM, but we still want to explore "perf c2c" tool to analyze cache false sharing. If without HITM tag, the tool cannot give out accurate result for cache false sharing, a candidate solution is to sort the total load operations and connect with the threads info,

[PATCH v2 05/11] perf c2c: Refactor hist entry validation

2020-12-13 Thread Leo Yan
This patch has no any functionality changes but refactors hist entry validation for cache line resorting. It renames function "valid_hitm_or_store()" to "is_valid_hist_entry()", changes return type from integer type to bool type. In the function, it uses switch-case instead of ternary operators,

[PATCH v2 02/11] perf c2c: Add dimensions for load hit

2020-12-13 Thread Leo Yan
Add dimensions for load hit and its percentage calculation, which is to be displayed in the single cache line output. Signed-off-by: Leo Yan --- tools/perf/builtin-c2c.c | 71 1 file changed, 71 insertions(+) diff --git a/tools/perf/builtin-c2c.c b/tools

[PATCH v2 06/11] perf c2c: Refactor display filter macro

2020-12-13 Thread Leo Yan
When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm), macro FILTER_HITM is to filter out the cache line entries if its overhead is less than 1%. This patch is to refactor macro FILTER_HITM. It uses more gernal name FILTER_DISPLAY to replace the old name; and refines its parameter, r

[PATCH v2 10/11] perf c2c: Sort on all cache hit for load operations

2020-12-13 Thread Leo Yan
Except the existed three display options 'tot', 'rmt', 'lcl', this patch adds option 'all' so can sort on the all cache hit for load operation. This new introduced option can be a choice for profiling cache false sharing if the memory event doesn't contain HITM tags. For displaying with option 'al

[PATCH v2 07/11] perf c2c: Refactor node display macro

2020-12-13 Thread Leo Yan
The macro DISPLAY_HITM() is used to calculate HITM percentage introduced by every node and it's shown for the node info. This patch refactors the macro, it is renamed it as DISPLAY_METRICS(). And the parameters is changed for passing the metric's statistic value and the sum value, this is flexsibl

[PATCH v2 08/11] perf c2c: Refactor node header

2020-12-13 Thread Leo Yan
The node header array contains 3 items, each item is used for one of the 3 flavors for node accessing info. To extend sorting on all load references and not always stick to HITMs, the second header string "Node{cpus %hitms %stores}" should be adjusted (e.g. it's changed as "Node{cpus %loads %store

[PATCH v2 11/11] perf c2c: Update documentation for display option 'all'

2020-12-13 Thread Leo Yan
Since the new display option 'all' is introduced, this patch is to update the documentation to reflect it. Signed-off-by: Leo Yan --- tools/perf/Documentation/perf-c2c.txt | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tools/perf/Documentation/perf-c2c

[PATCH v2 09/11] perf c2c: Add local variables for output metrics

2020-12-13 Thread Leo Yan
For different display types, it might use different metrics for outputting and sorting. So this patch adds several local variables: "cl_output": pointer for outputting single cache line metrics; "output_str": pointer for outputting cache line metrics; "sort_str": pointer to the sorting metr

Re: [PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Vladimir Oltean
Hi Nik, On Sun, Dec 13, 2020 at 03:22:16PM +0200, Nikolay Aleksandrov wrote: > Hi Vladimir, > Thank you for the good explanation, it really helps a lot to understand the > issue. > Even though it's deceptively simple, that call adds another lock/unlock for > everyone > when moving or learning (d

Re: [PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Vladimir Oltean
On Sun, Dec 13, 2020 at 03:36:13PM +0200, Nikolay Aleksandrov wrote: > Nevermind the whole comment. :) I was looking at the wrong code and got > confused. > > All is well (thanks to Ido). > > Acked-by: Nikolay Aleksandrov Ok, thanks. By the way, which wrong code were you looking at?

Re: [PATCH v2 net-next 1/6] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Nikolay Aleksandrov
On 13/12/2020 15:55, Vladimir Oltean wrote: > Hi Nik, > > On Sun, Dec 13, 2020 at 03:22:16PM +0200, Nikolay Aleksandrov wrote: >> Hi Vladimir, >> Thank you for the good explanation, it really helps a lot to understand the >> issue. >> Even though it's deceptively simple, that call adds another lo

[tip: irq/core] s390/irq: Use the correct irq stats accessor

2020-12-13 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the irq/core branch of tip: Commit-ID: 5684f2a950727020ebaece04fe89e00d04e3b479 Gitweb: https://git.kernel.org/tip/5684f2a950727020ebaece04fe89e00d04e3b479 Author:Thomas Gleixner AuthorDate:Sun, 13 Dec 2020 14:08:51 +01:00 Committe

[tip: irq/core] genirq: Reexport irq_to_desc() for PPC KVM

2020-12-13 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the irq/core branch of tip: Commit-ID: 3bda84519c6c2d57e7378417ac116f61d50abae1 Gitweb: https://git.kernel.org/tip/3bda84519c6c2d57e7378417ac116f61d50abae1 Author:Thomas Gleixner AuthorDate:Sun, 13 Dec 2020 14:33:57 +01:00 Committe

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-13 Thread Sasha Levin
On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: Hi Sasha, On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: From: "Andrea Parri (Microsoft)" [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] FYI, we found that this commit introduced a regression and poste

[tip: irq/core] pinctrl: nomadik: Fix the fallout of the irqdesc change

2020-12-13 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the irq/core branch of tip: Commit-ID: d11e2d4fc53d68c1f94b294b97838b78fac5763f Gitweb: https://git.kernel.org/tip/d11e2d4fc53d68c1f94b294b97838b78fac5763f Author:Thomas Gleixner AuthorDate:Sun, 13 Dec 2020 13:49:30 +01:00 Committe

[PATCH v3 net-next 0/7] Offload software learnt bridge addresses to DSA

2020-12-13 Thread Vladimir Oltean
This series tries to make DSA behave a bit more sanely when bridged with "foreign" (non-DSA) interfaces and source address learning is not supported on the hardware CPU port (which would make things work more seamlessly without software intervention). When a station A connected to a DSA switch port

[PATCH v3 net-next 1/7] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Vladimir Oltean
Currently the bridge emits atomic switchdev notifications for dynamically learnt FDB entries. Monitoring these notifications works wonders for switchdev drivers that want to keep their hardware FDB in sync with the bridge's FDB. For example station A wants to talk to station B in the diagram below

[PATCH v3 net-next 7/7] net: dsa: ocelot: request DSA to fix up lack of address learning on CPU port

2020-12-13 Thread Vladimir Oltean
Given the following setup: ip link add br0 type bridge ip link set eno0 master br0 ip link set swp0 master br0 ip link set swp1 master br0 ip link set swp2 master br0 ip link set swp3 master br0 Currently, packets received on a DSA slave interface (such as swp0) which should be routed by the soft

[PATCH v3 net-next 5/7] net: dsa: exit early in dsa_slave_switchdev_event if we can't program the FDB

2020-12-13 Thread Vladimir Oltean
Right now, the following would happen for a switch driver that does not implement .port_fdb_add or .port_fdb_del. dsa_slave_switchdev_event returns NOTIFY_OK and schedules: -> dsa_slave_switchdev_event_work -> dsa_port_fdb_add -> dsa_port_notify(DSA_NOTIFIER_FDB_ADD) -> dsa_switc

[PATCH v3 net-next 6/7] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-12-13 Thread Vladimir Oltean
Some DSA switches (and not only) cannot learn source MAC addresses from packets injected from the CPU. They only perform hardware address learning from inbound traffic. This can be problematic when we have a bridge spanning some DSA switch ports and some non-DSA ports (which we'll call "foreign in

[PATCH v3 net-next 2/7] net: dsa: be louder when a non-legacy FDB operation fails

2020-12-13 Thread Vladimir Oltean
The dev_close() call was added in commit c9eb3e0f8701 ("net: dsa: Add support for learning FDB through notification") "to indicate inconsistent situation" when we could not delete an FDB entry from the port. bridge fdb del d8:58:d7:00:ca:6d dev swp0 self master It is a bit drastic and at the same

Re: [PATCH AUTOSEL 5.9 28/39] intel_idle: Fix intel_idle() vs tracing

2020-12-13 Thread Sasha Levin
On Thu, Dec 03, 2020 at 06:10:35PM +0100, Peter Zijlstra wrote: On Thu, Dec 03, 2020 at 08:28:22AM -0500, Sasha Levin wrote: From: Peter Zijlstra [ Upstream commit 6e1d2bc675bd57640f5658a4a657ae488db4c204 ] cpuidle->enter() callbacks should not call into tracing because RCU has already been d

Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing

2020-12-13 Thread Sasha Levin
On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: > From: Peter Zijlstra > > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] > > We call arch_c

[PATCH v3 net-next 4/7] net: dsa: move switchdev event implementation under the same switch/case statement

2020-12-13 Thread Vladimir Oltean
We'll need to start listening to SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE events even for interfaces where dsa_slave_dev_check returns false, so we need that check inside the switch-case statement for SWITCHDEV_FDB_*. This movement also avoids a useless allocation / free of switchdev_work on the untreate

[PATCH v3 net-next 3/7] net: dsa: don't use switchdev_notifier_fdb_info in dsa_switchdev_event_work

2020-12-13 Thread Vladimir Oltean
Currently DSA doesn't add FDB entries on the CPU port, because it only does so through switchdev, which is associated with a net_device, and there are none of those for the CPU port. But actually FDB addresses on the CPU port have some use cases of their own, if the switchdev operations are initia

Re: [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels

2020-12-13 Thread Jonathan Cameron
On Mon, 7 Dec 2020 17:18:18 +0800 "Ye, Xiang" wrote: > Hi Jonathan > > Thanks for review and comments. > > On Sat, Dec 05, 2020 at 04:05:40PM +, Jonathan Cameron wrote: > > On Thu, 3 Dec 2020 11:53:52 +0800 > > Ye Xiang wrote: > > > > > Add channel description for hinge sensor, includi

Re: [PATCH] iio: adc: ti_am335x_adc: remove omitted iio_kfifo_free()

2020-12-13 Thread Jonathan Cameron
On Thu, 3 Dec 2020 09:26:50 +0200 Alexandru Ardelean wrote: > When the conversion was done to use devm_iio_kfifo_allocate(), a call to > iio_kfifo_free() was omitted (to be removed). > This change removes it. > > Fixes: 3c5308058899 ("iio: adc: ti_am335x_adc: alloc kfifo & IRQ via devm_ > funct

Re: [PATCH 1/3] iio: dummy: convert all simple allocation devm_ variants

2020-12-13 Thread Jonathan Cameron
On Mon, 7 Dec 2020 09:22:28 +0200 Alexandru Ardelean wrote: > On Sat, Dec 5, 2020 at 8:46 PM Jonathan Cameron wrote: > > > > On Thu, 3 Dec 2020 11:50:03 +0200 > > Alexandru Ardelean wrote: > > > > > Since a main requirement for an IIO device is to have a parent device > > > object, it makes s

Re: [PATCH v2] proc: Allow pid_revalidate() during LOOKUP_RCU

2020-12-13 Thread Eric W. Biederman
Matthew Wilcox writes: > On Thu, Dec 03, 2020 at 04:02:12PM -0800, Stephen Brennan wrote: >> -void pid_update_inode(struct task_struct *task, struct inode *inode) >> +static int do_pid_update_inode(struct task_struct *task, struct inode >> *inode, >> + unsigned int flag

Re: [PATCH v2 2/2] iio: dac: ad5766: add driver support for AD5766

2020-12-13 Thread Jonathan Cameron
On Tue, 8 Dec 2020 13:30:06 + "Pop, Cristian" wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Saturday, December 5, 2020 8:01 PM > > To: Pop, Cristian > > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > > devicet...@vger.kernel.org; robh...@kernel.o

Re: [PATCH v2] proc: Allow pid_revalidate() during LOOKUP_RCU

2020-12-13 Thread Eric W. Biederman
Stephen Brennan writes: > The pid_revalidate() function requires dropping from RCU into REF lookup > mode. When many threads are resolving paths within /proc in parallel, > this can result in heavy spinlock contention as each thread tries to > grab a reference to the /proc dentry lock (and drop i

Re: [PATCH v2] iio: core: register chardev only if needed

2020-12-13 Thread Jonathan Cameron
On Wed, 9 Dec 2020 17:55:22 +0200 Alexandru Ardelean wrote: > On Wed, Dec 9, 2020 at 5:53 PM Andy Shevchenko > wrote: > > > > On Wed, Dec 9, 2020 at 5:45 PM Alexandru Ardelean > > wrote: > > > On Wed, Dec 9, 2020 at 5:37 PM Andy Shevchenko > > > wrote: > > > > On Thu, Dec 3, 2020 at 11:55

Re: [PATCH v3 2/3] Documentation/ABI/testing: Add documentation for AD5766 new ABI

2020-12-13 Thread Jonathan Cameron
On Tue, 8 Dec 2020 15:19:56 +0200 Cristian Pop wrote: > New interface is proposed for dither functionality. This future allows > composing an external signals to the selected output channel. > The dither signal can be turned on/off, scaled, inverted, or it can be > selected from different source

Re: [PATCH v3 1/3] dt-bindings: iio: dac: AD5766 yaml documentation

2020-12-13 Thread Jonathan Cameron
On Tue, 8 Dec 2020 15:19:55 +0200 Cristian Pop wrote: > This adds device tree bindings for the AD5766 DAC. > > Signed-off-by: Cristian Pop > --- > Changes in v3: > - Fix errors > .../bindings/iio/dac/adi,ad5766.yaml | 58 +++ > 1 file changed, 58 insertions(+) >

memory leak in xskq_create

2020-12-13 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a68a0262 mm/madvise: remove racy mm ownership check git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=165b941350 kernel config: https://syzkaller.appspot.com/x/.config?x=4305fa9ea70c7a9f dashboard li

Re: [PATCH v2 1/2] bitmap: Modify bitmap_set_value() to check bitmap length

2020-12-13 Thread Andy Shevchenko
On Sun, Dec 13, 2020 at 4:24 PM Syed Nayyar Waris wrote: > > Add explicit check to see if the value being written into the bitmap > does not fall outside the bitmap. > The situation that it is falling outside would never be possible in the > code because the boundaries are required to be correct b

Re: [PATCH v3 net-next 1/7] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Ido Schimmel
On Sun, Dec 13, 2020 at 04:07:04PM +0200, Vladimir Oltean wrote: > Currently the bridge emits atomic switchdev notifications for > dynamically learnt FDB entries. Monitoring these notifications works > wonders for switchdev drivers that want to keep their hardware FDB in > sync with the bridge's FD

Re: [PATCH v3 3/3] iio: dac: ad5766: add driver support for AD5766

2020-12-13 Thread Jonathan Cameron
On Tue, 8 Dec 2020 15:19:57 +0200 Cristian Pop wrote: > The AD5766/AD5767 are 16-channel, 16-bit/12-bit, voltage output dense DACs > Digital-to-Analog converters. > > This change adds support for these DACs. > > Link: > https://www.analog.com/media/en/technical-documentation/data-sheets/ad5766

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Miguel Ojeda
On Sun, Dec 13, 2020 at 1:55 PM Guenter Roeck wrote: > > Witz komm raus, Du bist umzingelt. Please, explain this reference. :-) > The key here is "if nobody complains". I would argue that it is _your_ > responsibility to do those builds, and not the reponsibility of others > to do it for you. T

Re: [PATCH 0/2] hv_balloon: hide ballooned out memory in stats

2020-12-13 Thread Wei Liu
On Wed, Dec 09, 2020 at 01:17:18PM +, Wei Liu wrote: > On Wed, Dec 02, 2020 at 05:12:43PM +0100, Vitaly Kuznetsov wrote: > > It was noticed that 'free' information on a Hyper-V guest reports ballooned > > out memory in 'total' and this contradicts what other ballooning drivers > > (e.g. virtio

Re: [PATCH v3 net-next 1/7] net: bridge: notify switchdev of disappearance of old FDB entry upon migration

2020-12-13 Thread Vladimir Oltean
Hi Ido, On Sun, Dec 13, 2020 at 04:55:43PM +0200, Ido Schimmel wrote: > > As far as the switchdev driver is concerned, all that it needs to ensure > > is that traffic between Station A and Station B is not forever broken. > > If it does nothing, then the stale rule to send frames for Station B > >

[PATCH 0/2] Fix the incorrect memmap init defer handling

2020-12-13 Thread Baoquan He
VMware reported the performance regression during memmap_init() invocation. And they bisected to commit 73a6e474cb376 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") causing it. After investigation, it's caused by incorrect memmap init defer handling in memmap_init_zo

[PATCH 2/2] mm: rename memmap_init() and memmap_init_zone()

2020-12-13 Thread Baoquan He
The current memmap_init_zone() only handles memory region inside one zone. Actually memmap_init() does the memmap init of one zone. So rename both of them accordingly. And also rename the function parameter 'range_start_pfn' and local variable 'range_end_pfn' to zone_start_pfn/zone_end_pfn. Signe

[PATCH 1/2] mm: memmap defer init dosn't work as expected

2020-12-13 Thread Baoquan He
VMware observed a performance regression during memmap init on their platform, and bisected to commit 73a6e474cb376 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") to cause it. Before the commit: [0.033176] Normal zone: 1445888 pages used for memmap [0.033176] No

[PATCH] staging: spmi: hisi-spmi-controller: Fix some error handling paths

2020-12-13 Thread Christophe JAILLET
IN the probe function, if an error occurs after calling 'spmi_controller_alloc()', it must be undone by a corresponding 'spmi_controller_put() call. In the remove function, use 'spmi_controller_put(ctrl)' instead of 'kfree(ctrl)'. While a it fix an error message (s/spmi_add_controller/spmi_contro

Re: Performance regressions in "boot_time" tests in Linux 5.8 Kernel

2020-12-13 Thread b...@redhat.com
On 12/11/20 at 04:16pm, Rahul Gopakumar wrote: > Hi Baoquan, > > We re-evaluated your last patch and it seems to be fixing the > initial performance bug reported. During our previous testing, > we did not apply the patch rightly hence it was reporting > some issues. > > Here is the dmesg log con

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Greg KH
On Sun, Dec 13, 2020 at 03:58:20PM +0100, Miguel Ojeda wrote: > > The key here is "if nobody complains". I would argue that it is _your_ > > responsibility to do those builds, and not the reponsibility of others > > to do it for you. > > Testing allmodconfig for a popular architecture, agreed, it

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Miguel Ojeda
On Sun, Dec 13, 2020 at 4:16 PM Greg KH wrote: > > Because if you get a report of something breaking for your change, you > need to work to resolve it, not argue about it. Otherwise it needs to > be dropped/reverted. Nobody has argued that. In fact, I explicitly said the opposite: "So I think we

[PATCH] staging: mt7621-dma: Fix a resource leak in an error handling path

2020-12-13 Thread Christophe JAILLET
If an error occurs after calling 'mtk_hsdma_init()', it must be undone by a corresponding call to 'mtk_hsdma_uninit()' as already done in the remove function. Fixes: 0853c7a53eb3 ("staging: mt7621-dma: ralink: add rt2880 dma engine") Signed-off-by: Christophe JAILLET --- drivers/staging/mt7621-d

[PATCH v9 00/11] Free some vmemmap pages of HugeTLB page

2020-12-13 Thread Muchun Song
Hi all, This patch series will free some vmemmap pages(struct page structures) associated with each hugetlbpage when preallocated to save memory. In order to reduce the difficulty of the first version of code review. >From this version, we disable PMD/huge page mapping of vmemmap if this feature

[PATCH v9 01/11] mm/memory_hotplug: Factor out bootmem core functions to bootmem_info.c

2020-12-13 Thread Muchun Song
Move bootmem info registration common API to individual bootmem_info.c. And we will use {get,put}_page_bootmem() to initialize the page for the vmemmap pages or free the vmemmap pages to buddy in the later patch. So move them out of CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code movement without a

[PATCH v9 10/11] mm/hugetlb: Gather discrete indexes of tail page

2020-12-13 Thread Muchun Song
For HugeTLB page, there are more metadata to save in the struct page. But the head struct page cannot meet our needs, so we have to abuse other tail struct page to store the metadata. In order to avoid conflicts caused by subsequent use of more tail struct pages, we can gather these discrete indexe

[PATCH v9 05/11] mm/hugetlb: Allocate the vmemmap pages associated with each HugeTLB page

2020-12-13 Thread Muchun Song
When we free a HugeTLB page to the buddy allocator, we should allocate the vmemmap pages associated with it. We can do that in the __free_hugepage() before freeing it to buddy. Signed-off-by: Muchun Song --- include/linux/mm.h | 1 + mm/hugetlb.c | 2 ++ mm/hugetlb_vmemmap.c | 11 +++

[PATCH v9 07/11] mm/hugetlb: Flush work when dissolving hugetlb page

2020-12-13 Thread Muchun Song
We should flush work when dissolving a hugetlb page to make sure that the hugetlb page is freed to the buddy. Signed-off-by: Muchun Song --- mm/hugetlb.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 29de425f879a..b0847b2

[PATCH v9 04/11] mm/hugetlb: Defer freeing of HugeTLB pages

2020-12-13 Thread Muchun Song
In the subsequent patch, we will allocate the vmemmap pages when free HugeTLB pages. But update_and_free_page() is called from a non-task context(and hold hugetlb_lock), so we can defer the actual freeing in a workqueue to prevent use GFP_ATOMIC to allocate the vmemmap pages. Signed-off-by: Muchun

[PATCH v9 09/11] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate

2020-12-13 Thread Muchun Song
All the infrastructure is ready, so we introduce nr_free_vmemmap_pages field in the hstate to indicate how many vmemmap pages associated with a HugeTLB page that we can free to buddy allocator. And initialize it in the hugetlb_vmemmap_init(). This patch is actual enablement of the feature. Signed-

[PATCH v9 11/11] mm/hugetlb: Optimize the code with the help of the compiler

2020-12-13 Thread Muchun Song
We cannot optimize if a "struct page" crosses page boundaries. If it is true, we can optimize the code with the help of a compiler. When free_vmemmap_pages_per_hpage() returns zero, most functions are optimized by the compiler. Signed-off-by: Muchun Song --- include/linux/hugetlb.h | 3 ++- mm/h

[PATCH v9 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page

2020-12-13 Thread Muchun Song
Every HugeTLB has more than one struct page structure. We __know__ that we only use the first 4(HUGETLB_CGROUP_MIN_ORDER) struct page structures to store metadata associated with each HugeTLB. There are a lot of struct page structures associated with each HugeTLB page. For tail pages, the value of

[PATCH v9 08/11] mm/hugetlb: Add a kernel parameter hugetlb_free_vmemmap

2020-12-13 Thread Muchun Song
Add a kernel parameter hugetlb_free_vmemmap to disable the feature of freeing unused vmemmap pages associated with each hugetlb page on boot. Signed-off-by: Muchun Song --- Documentation/admin-guide/kernel-parameters.txt | 9 + Documentation/admin-guide/mm/hugetlbpage.rst| 3 +++ a

[PATCH v9 06/11] mm/hugetlb: Set the PageHWPoison to the raw error page

2020-12-13 Thread Muchun Song
Because we reuse the first tail vmemmap page frame and remap it with read-only, we cannot set the PageHWPosion on a tail page. So we can use the head[4].private to record the real error page index and set the raw error page PageHWPoison later. Signed-off-by: Muchun Song --- mm/hugetlb.c | 48 +++

[PATCH v9 02/11] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

2020-12-13 Thread Muchun Song
The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure whether to enable the feature of freeing unused vmemmap associated with HugeTLB pages. And this is just for dependency check. Now only support x86-64. Because this config depends on HAVE_BOOTMEM_INFO_NODE. And the function of the

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-13 Thread Matthias Urlichs
Miguel Ojeda wrote: I think we can fix them as they come. If your change to a function breaks its callers, it's your job to fix the callers proactively instead of waiting for "as they come" bug reports. (Assuming, of course, that you know about the breakage. Which you do when you tell us tha

  1   2   3   4   5   >