Add dimensions for load miss and its percentage calculation, which is to
be displayed in the single cache line output.

Signed-off-by: Leo Yan <leo....@linaro.org>
---
 tools/perf/builtin-c2c.c | 107 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 107 insertions(+)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 00014e3d81fa..27745340c14a 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -624,6 +624,10 @@ tot_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
         (stats)->rmt_hitm +            \
         (stats)->rmt_hit)
 
+#define TOT_LD_MISS(stats)             \
+       ((stats)->lcl_dram +            \
+        (stats)->rmt_dram)
+
 static int tot_ld_hit_entry(struct perf_hpp_fmt *fmt,
                            struct perf_hpp *hpp,
                            struct hist_entry *he)
@@ -656,6 +660,38 @@ static int64_t tot_ld_hit_cmp(struct perf_hpp_fmt *fmt 
__maybe_unused,
        return tot_hit_left - tot_hit_right;
 }
 
+static int tot_ld_miss_entry(struct perf_hpp_fmt *fmt,
+                            struct perf_hpp *hpp,
+                            struct hist_entry *he)
+{
+       struct c2c_hist_entry *c2c_he;
+       int width = c2c_width(fmt, hpp, he->hists);
+       unsigned int tot_miss;
+
+       c2c_he = container_of(he, struct c2c_hist_entry, he);
+       tot_miss = TOT_LD_MISS(&c2c_he->stats);
+
+       return scnprintf(hpp->buf, hpp->size, "%*u", width, tot_miss);
+}
+
+static int64_t tot_ld_miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
+                              struct hist_entry *left,
+                              struct hist_entry *right)
+{
+       struct c2c_hist_entry *c2c_left;
+       struct c2c_hist_entry *c2c_right;
+       uint64_t tot_miss_left;
+       uint64_t tot_miss_right;
+
+       c2c_left  = container_of(left, struct c2c_hist_entry, he);
+       c2c_right = container_of(right, struct c2c_hist_entry, he);
+
+       tot_miss_left  = TOT_LD_MISS(&c2c_left->stats);
+       tot_miss_right = TOT_LD_MISS(&c2c_right->stats);
+
+       return tot_miss_left - tot_miss_right;
+}
+
 #define STAT_FN_ENTRY(__f)                                     \
 static int                                                     \
 __f ## _entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,  \
@@ -1104,6 +1140,58 @@ percent_ld_hit_cmp(struct perf_hpp_fmt *fmt 
__maybe_unused,
        return per_left - per_right;
 }
 
+static double percent_ld_miss(struct c2c_hist_entry *c2c_he)
+{
+       struct c2c_hists *hists;
+       int tot, st;
+
+       hists = container_of(c2c_he->he.hists, struct c2c_hists, hists);
+
+       st  = TOT_LD_MISS(&c2c_he->stats);
+       tot = TOT_LD_MISS(&hists->stats);
+
+       return percent(st, tot);
+}
+
+static int
+percent_ld_miss_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
+                     struct hist_entry *he)
+{
+       struct c2c_hist_entry *c2c_he;
+       int width = c2c_width(fmt, hpp, he->hists);
+       char buf[10];
+       double per;
+
+       c2c_he = container_of(he, struct c2c_hist_entry, he);
+       per = percent_ld_miss(c2c_he);
+       return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per));
+}
+
+static int
+percent_ld_miss_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
+                     struct hist_entry *he)
+{
+       return percent_color(fmt, hpp, he, percent_ld_miss);
+}
+
+static int64_t
+percent_ld_miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
+                   struct hist_entry *left, struct hist_entry *right)
+{
+       struct c2c_hist_entry *c2c_left;
+       struct c2c_hist_entry *c2c_right;
+       double per_left;
+       double per_right;
+
+       c2c_left  = container_of(left, struct c2c_hist_entry, he);
+       c2c_right = container_of(right, struct c2c_hist_entry, he);
+
+       per_left  = percent_ld_miss(c2c_left);
+       per_right = percent_ld_miss(c2c_right);
+
+       return per_left - per_right;
+}
+
 static int
 percent_stores_l1hit_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
                           struct hist_entry *he)
@@ -1477,6 +1565,14 @@ static struct c2c_dimension dim_cl_tot_ld_hit = {
        .width          = 7,
 };
 
+static struct c2c_dimension dim_cl_tot_ld_miss = {
+       .header         = HEADER_SPAN_LOW("Miss"),
+       .name           = "cl_tot_ld_miss",
+       .cmp            = tot_ld_miss_cmp,
+       .entry          = tot_ld_miss_entry,
+       .width          = 7,
+};
+
 static struct c2c_dimension dim_cl_lcl_hitm = {
        .header         = HEADER_SPAN_LOW("Lcl"),
        .name           = "cl_lcl_hitm",
@@ -1639,6 +1735,15 @@ static struct c2c_dimension dim_percent_ld_hit = {
        .width          = 7,
 };
 
+static struct c2c_dimension dim_percent_ld_miss = {
+       .header         = HEADER_SPAN_LOW("Miss"),
+       .name           = "percent_ld_miss",
+       .cmp            = percent_ld_miss_cmp,
+       .entry          = percent_ld_miss_entry,
+       .color          = percent_ld_miss_color,
+       .width          = 7,
+};
+
 static struct c2c_dimension dim_percent_stores_l1hit = {
        .header         = HEADER_SPAN("-- Store Refs --", "L1 Hit", 1),
        .name           = "percent_stores_l1hit",
@@ -1785,6 +1890,7 @@ static struct c2c_dimension *dimensions[] = {
        &dim_cl_lcl_hitm,
        &dim_cl_rmt_hitm,
        &dim_cl_tot_ld_hit,
+       &dim_cl_tot_ld_miss,
        &dim_tot_stores,
        &dim_stores_l1hit,
        &dim_stores_l1miss,
@@ -1802,6 +1908,7 @@ static struct c2c_dimension *dimensions[] = {
        &dim_percent_rmt_hitm,
        &dim_percent_lcl_hitm,
        &dim_percent_ld_hit,
+       &dim_percent_ld_miss,
        &dim_percent_tot_ld_hit,
        &dim_percent_stores_l1hit,
        &dim_percent_stores_l1miss,
-- 
2.17.1

Reply via email to