Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-10-31 Thread Johan Jonker
Hi Yifeng, Some comments, have a look if it's usefull. On 10/28/20 10:53 AM, Yifeng Zhao wrote: > This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308, > RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using > 8-bit NAND interface on the ARM based RK3308 pla

Re: [Outreachy kernel] [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-31 Thread Julia Lawall
On Sat, 31 Oct 2020, Joe Perches wrote: > On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote: > > On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote: > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote: > > > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:

RE: [PATCH 4/6] perf: Optimize get_recursion_context()

2020-10-31 Thread David Laight
From: Peter Zijlstra > Sent: 30 October 2020 23:02 > > On Fri, Oct 30, 2020 at 04:22:48PM -0400, Steven Rostedt wrote: > > As this is something that ftrace recursion also does, perhaps we should > > move this into interrupt.h so that anyone that needs a counter can get > > it quickly, and not keep

[PATCH v4] watchdog: qcom_wdt: set WDOG_HW_RUNNING bit when appropriate

2020-10-31 Thread Robert Marko
If the watchdog hardware is enabled/running during boot, e.g. due to a boot loader configuring it, we must tell the watchdog framework about this fact so that it can ping the watchdog until userspace opens the device and takes over control. Do so using the WDOG_HW_RUNNING flag that exists for exac

Re: [PATCH v7 1/6] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-10-31 Thread Krzysztof Kozlowski
On Fri, Oct 30, 2020 at 01:51:44PM +0100, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > interconnects, #interconnect-cells, samsung,data-clock-ratio. > These properties allow to specify the SoC interconnect structure which > then allows the int

Re: [PATCH v2] watchdog: qcom_wdt: set WDOG_HW_RUNNING bit when appropriate

2020-10-31 Thread Robert Marko
On Fri, Oct 30, 2020 at 6:21 AM wrote: > > On 2020-10-28 17:16, Robert Marko wrote: > > If the watchdog hardware is enabled/running during boot, e.g. > > due to a boot loader configuring it, we must tell the > > watchdog framework about this fact so that it can ping the > > watchdog until userspac

Re: [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-10-31 Thread Alexandru Ardelean
On Sat, Oct 24, 2020 at 1:43 AM Andrew Lunn wrote: > > On Thu, Oct 22, 2020 at 10:45:50AM +0300, Alexandru Ardelean wrote: > > When the PHY powers up, the diagnostics clock isn't enabled (bit 2 in > > register PHY_CTRL_1 (0x0012)). > > Also, the PHY is not in standby mode, so bit 13 in PHY_CTRL_3

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-10-31 Thread Krzysztof Kozlowski
On Fri, Oct 30, 2020 at 01:51:45PM +0100, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a tree) and

[gustavoars-linux:for-linus/kspp-fam0] BUILD SUCCESS a38283da05d321fa1fce38ea3cf41c9f1dbd1f21

2020-10-31 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-linus/kspp-fam0 branch HEAD: a38283da05d321fa1fce38ea3cf41c9f1dbd1f21 printk: ringbuffer: Replace zero-length array with flexible-array member elapsed time: 724m configs tested: 114 configs skipped: 2 The

My Greetings

2020-10-31 Thread Mrs. Maya Oliver
My Dear My Name is Mrs. Maya Oliver, from Norway. I know that this message will be a surprise to you. Firstly, I am married to Mr. Patrick Oliver, A gold merchant who owns a small gold Mine in Burkina Faso; He died of Cardiovascular Disease in mid-March 2011. During his life time he deposited the

[PATCH V2] arm64: dts: imx8mm-beacon-som: Fix whitespace issue

2020-10-31 Thread Adam Ford
The pinmux subnodes are indented too much. This patch does nothing more than remove an extra tab. There are no functional changes. Signed-off-by: Adam Ford --- V2: Rebase on Shawn's branch diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8m

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-10-31 Thread Yuehaibing
On 2020/10/31 15:19, Sam Ravnborg wrote: > Hi YueHaibing > > Thanks for the fix. Appreciated but please update as per comments below. > > On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >> gpiod_to_irq() return negative value in case of error, >> the existing code handle negative erro

Re: [PATCH v7 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-10-31 Thread Krzysztof Kozlowski
On Fri, Oct 30, 2020 at 01:51:46PM +0100, Sylwester Nawrocki wrote: > This patch adds registration of a child platform device for the exynos > interconnect driver. It is assumed that the interconnect provider will > only be needed when #interconnect-cells property is present in the bus > DT node, h

Re: INFO: task can't die in nbd_ioctl

2020-10-31 Thread syzbot
syzbot has bisected this issue to: commit e9e006f5fcf2bab59149cb38a48a4817c1b538b4 Author: Mike Christie Date: Sun Aug 4 19:10:06 2019 + nbd: fix max number of supported devs bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=154dc19250 start commit: 4e78c578 Add linux

Re: [PATCH v7 6/6] drm: exynos: mixer: Add interconnect support

2020-10-31 Thread Krzysztof Kozlowski
On Fri, Oct 30, 2020 at 01:51:49PM +0100, Sylwester Nawrocki wrote: > This patch adds interconnect support to exynos-mixer. The mixer works > the same as before when CONFIG_INTERCONNECT is 'n'. > > For proper operation of the video mixer block we need to ensure the > interconnect busses like DMC o

Re: [PATCH v7 6/6] drm: exynos: mixer: Add interconnect support

2020-10-31 Thread Krzysztof Kozlowski
On Fri, Oct 30, 2020 at 01:51:49PM +0100, Sylwester Nawrocki wrote: > This patch adds interconnect support to exynos-mixer. The mixer works > the same as before when CONFIG_INTERCONNECT is 'n'. > > For proper operation of the video mixer block we need to ensure the > interconnect busses like DMC o

Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-31 Thread Alex Elder
On 10/30/20 7:23 PM, Jakub Kicinski wrote: > On Thu, 29 Oct 2020 11:50:52 -0500 Alex Elder wrote: >> On 10/29/20 11:11 AM, Jakub Kicinski wrote: >>> On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote: This series fixes several bugs. They are minor, in that the code currently works on

From the kindness of our heart!! You have been selected to receive (£1,000,000.00 British Pound)

2020-10-31 Thread Patrick and Frances Connolly
Dear Beneficiary, You have been selected to receive (£1,000,000.00 British Pound) as charity donation/grant from Patrick and Frances Connolly. Therefore, you are required to contact her through email for more details patrickcon2...@gmail.com -- This email has been checked for viruses

Greetings My Dear,

2020-10-31 Thread Mrs Franisca carlsen
Greetings My Dear, I sent this mail praying it will found you in a good condition of health, since I myself are in a very critical health condition in which I sleep every night without knowing if I may be alive to see the next day. I am Mrs. Francisca Carlsen from Denmark wife of late Mr Joh

[for-linus][PATCH 0/3] tracing/ftrace: trace_printk buffer fix and ftrace recursion fixes

2020-10-31 Thread Steven Rostedt
The indexing of the different context buffers had an off by one error. The recursion protection for ftrace callbacks had two bugs. One that would make NMIs always appear to be recursing The other is trasitions between interrupt context could also cause false positives and miss tracing those fun

[for-linus][PATCH 1/3] tracing: Fix out of bounds write in get_trace_buf

2020-10-31 Thread Steven Rostedt
From: Qiujun Huang The nesting count of trace_printk allows for 4 levels of nesting. The nesting counter starts at zero and is incremented before being used to retrieve the current context's buffer. But the index to the buffer uses the nesting counter after it was incremented, and not its origina

[for-linus][PATCH 3/3] ftrace: Handle tracing when switching between context

2020-10-31 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" When an interrupt or NMI comes in and switches the context, there's a delay from when the preempt_count() shows the update. As the preempt_count() is used to detect recursion having each context have its own bit get set when tracing starts, and if that bit is alrea

[for-linus][PATCH 2/3] ftrace: Fix recursion check for NMI test

2020-10-31 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The code that checks recursion will work to only do the recursion check once if there's nested checks. The top one will do the check, the other nested checks will see recursion was already checked and return zero for its "bit". On the return side, nothing will be d

RE: [PATCH 4/6] perf: Optimize get_recursion_context()

2020-10-31 Thread David Laight
From: David Laight > Sent: 31 October 2020 12:12 > ... > The gcc 7.5.0 I have handy probably generates the best code for: > > unsigned char q_2(unsigned int pc) > { > unsigned char rctx = 0; > > rctx += !!(pc & (NMI_MASK)); > rctx += !!(pc & (NMI_MASK | HARDIRQ_MASK)); >

[PATCH V2 1/5] arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter

2020-10-31 Thread Adam Ford
The driver exists for the Enhanced Asynchronous Sample Rate Converter (EASRC) Controller, but there isn't a device tree entry for it. On the vendor kernel, they put this on a spba-bus for SDMA support. Add the the node for the spba-bus with the easrc node inside. Signed-off-by: Adam Ford --- V2

[PATCH V2 0/5] Enable Audio functions on i.MX8M Nano

2020-10-31 Thread Adam Ford
The i.MX8M Nano uses similar blocks of audio IP as the iMX8M Mini This series adds those functions. V2: Mostly corrects some minor typos and rebased on Shawn Guo's branch imx/dt64. The added cover letter with stats was per request to show what's changed at a high level. Adam Ford (5): arm64:

[PATCH V2 2/5] arm64: defconfig: Enable ASRC and EASRC

2020-10-31 Thread Adam Ford
The i.MX8M Nano supports the EASRC driver, and it requires ASRC. Enable both of them as modules. Signed-off-by: Adam Ford --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 844d8817e6f4..270d326

[PATCH V2 3/5] arm64: dts: imx8mn: Add SAI nodes

2020-10-31 Thread Adam Ford
The i.MX8M Nano has several SAI nodes available to it. Enable them. Signed-off-by: Adam Ford --- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 72 +++ 1 file changed, 72 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8m

[PATCH V2 5/5] arm64: dts: imx8mn: Add node for SPDIF

2020-10-31 Thread Adam Ford
The i.MX8M Nano can support SPDIF which is compatible to the IP used on the i.MX35. Add the node. Signed-off-by: Adam Ford --- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 24 +++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch

[PATCH V2 4/5] arm64: dts: imx8mn: Add support for micfil

2020-10-31 Thread Adam Ford
The i.MX8M Nano has supports the MICFIL digital interface. It's a 16-bit audio signal from a PDM microphone bitstream. The driver is already in the kernel, but the node is missing. Add the micfil node. Signed-off-by: Adam Ford --- V2: Rebase and use generic term audio-controller instead of micf

Re: Linux 4.19.154

2020-10-31 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -2127,11 +2127,10 @@ static void handle_bad_sector(struct bio *bio, > sector_t maxsector) > { > char b[BDEVNAME_SIZE]; > > - printk(KERN_INFO "attempt to access beyond end of device\n"); > - prin

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-31 Thread Arnd Bergmann
On Fri, Oct 30, 2020 at 11:46 PM Linus Torvalds wrote: > > On Fri, Oct 30, 2020 at 3:26 PM Thomas Gleixner wrote: > > > > While at it I might have a look at that debug request from Willy in the > > other end of this thread. Any comment on that? > > > > https://lore.kernel.org/r/87k0v7mrrd@na

[PATCH] iio: magnetometer: bmc150: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/iio/magnetometer/bmc150_magn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c index fc6840f

[PATCH] iio: pressure: bmp280: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/iio/pressure/bmp280-regmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/pressure/bmp280-regmap.c b/drivers/iio/pressure/bmp280-regmap.c index 08c00ac32

Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-10-31 Thread Johan Jonker
Hi Yifeng, In some functions you deselect the chips. The MTD frame work has a functions for that and also keeps track of its select status, so I think that you shouldn't poke with that yourself and should therefore remove the deselections from your driver. /** * nand_deselect_target() - Deselect

[PATCH] RDMA/mlx5: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/infiniband/hw/mlx5/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 600e056798c0..6aad0f39c50c 10

[PATCH] memstick: mspro_block: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/memstick/core/mspro_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index cd6b8d4f2335..af

Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds

2020-10-31 Thread Alexander Dahl
Hei hei, On Tue, Oct 27, 2020 at 11:58:10AM +0100, Ahmad Fatoum wrote: > Hello, > > On 10/27/20 11:05 AM, Alexander Dahl wrote: > > Hello Ahmad, > > > > thanks for your feedback, comments below. > > > > >>> - led-rgb { > >>> + led-controller-2 { > >> > >> Is a single RGB LED really a controlle

Re: Linux 4.19.154

2020-10-31 Thread Tetsuo Handa
On 2020/10/31 22:14, Jari Ruusu wrote: > Greg Kroah-Hartman wrote: >> --- a/block/blk-core.c >> +++ b/block/blk-core.c >> @@ -2127,11 +2127,10 @@ static void handle_bad_sector(struct bio *bio, >> sector_t maxsector) >> { >> char b[BDEVNAME_SIZE]; >> >> - printk(KERN_INFO "attempt to

Re: [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS

2020-10-31 Thread Paolo Bonzini
On 25/10/20 19:53, Peter Xu wrote: > kvm_msr_ignored_check() could trigger a null pointer reference if > ignore_msrs=Y > and report_ignore_msrs=Y when try to fetch an invalid feature msr using the > global KVM_GET_MSRS. Degrade the error report to not rely on vcpu since that > information (index,

Re: [PATCH v4] watchdog: qcom_wdt: set WDOG_HW_RUNNING bit when appropriate

2020-10-31 Thread Guenter Roeck
On 10/31/20 5:11 AM, Robert Marko wrote: > If the watchdog hardware is enabled/running during boot, e.g. > due to a boot loader configuring it, we must tell the > watchdog framework about this fact so that it can ping the > watchdog until userspace opens the device and takes over > control. > > Do

[PATCH] pci: mediatek: fix warning in msi.h

2020-10-31 Thread Frank Wunderlich
From: Frank Wunderlich 5.10 shows these warnings on bootup while enabling pcie at least on bananapi-r2: [6.161730] WARNING: CPU: 2 PID: 73 at include/linux/msi.h:213 pci_msi_setup_ msi_irqs.constprop.0+0x78/0x80 [6.724607] WARNING: CPU: 2 PID: 73 at include/linux/msi.h:219 free_msi_

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 10:31:31 + > On Saturday, 31 October 2020, 2:12, Willem de Bruijn > wrote: > > Hi Willem, > >> On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: >> >>> Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a sup

[PATCH] memstick: jmb38x_ms: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/memstick/host/jmb38x_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index e83c3ada9389..f9a93b05

Re: [PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-31 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 8:49 PM Xie He wrote: > > 1. > Change the skb->len check from "<= 4" to "< 4". > At first we only need to ensure a 4-byte header is present. We indeed > normally need the 5th byte, too, but it'd be more logical and cleaner > to check its existence when we actually need it.

[PATCH] memstick: tifm: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/memstick/host/tifm_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index 786e46798da2..57145374f6ac 10

Re: [PATCH v2] KVM: VMX: eVMCS: make evmcs_sanitize_exec_ctrls() work again

2020-10-31 Thread Paolo Bonzini
On 14/10/20 16:33, Vitaly Kuznetsov wrote: > It was noticed that evmcs_sanitize_exec_ctrls() is not being executed > nowadays despite the code checking 'enable_evmcs' static key looking > correct. Turns out, static key magic doesn't work in '__init' section > (and it is unclear when things changed)

[PATCH] mfd: tps65010: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/mfd/tps65010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 7e7dbee58ca9..4a21ea3fafae 100644 --- a/drivers/mfd/tps6

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

2020-10-31 Thread Guenter Roeck
On 10/31/20 2:45 AM, Salvatore Bonaccorso wrote: > Hi Greg, > > On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: >> Retry. >> >> On Wed, Oct 28, 2020 at 10:10:35AM -0700, Guenter Roeck wrote: >>> On Tue, Oct 27, 2020 at 02:50:58PM +0100, Greg Kroah-Hartman wrote: This is the sta

[PATCH] misc: mic: cosm: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/misc/mic/cosm/cosm_scif_server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/cosm/cosm_scif_server.c b/drivers/misc/mic/cosm/cosm_scif_server.c index 7

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-31 Thread Andrew Lunn
> Sure, I just wanted to add the comment before others simply copy and > paste this (pseudo) code. And in patch 9 (aquantia) and 18 (realtek) > it is used as is. And IIRC at least the Aquantia PHY doesn't mask > the interrupt status. And that is were we are going to have issues with this patch set

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 8:50 PM Xie He wrote: > > When the fr_rx function drops a received frame (because the protocol type > is not supported, or because the PVC virtual device that corresponds to > the DLCI number and the protocol type doesn't exist), the function frees > the skb and returns. >

[PATCH v2] fix for potential NULL pointer dereference with bare lan743x

2020-10-31 Thread Sergej Bauer
Signed-off-by: Sergej Bauer --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index dcde496da7fb..ad38fc9e1468 1

Re: [PATCH v2 1/2] net: phy: adin: disable diag clock & disable standby mode in config_aneg

2020-10-31 Thread Andrew Lunn
> So, then re-send for this or just this patch ping? > Naturally, this is for net-next. > I don't mind doing either way. Please resend, with all the acked-by, reviewed-by added, now that net-next is open. Andrew

Re: [PATCH v5 13/15] resource: Move devmem revoke code to resource framework

2020-10-31 Thread Daniel Vetter
On Sat, Oct 31, 2020 at 7:36 AM John Hubbard wrote: > > On 10/30/20 3:08 AM, Daniel Vetter wrote: > > We want all iomem mmaps to consistently revoke ptes when the kernel > > takes over and CONFIG_IO_STRICT_DEVMEM is enabled. This includes the > > pci bar mmaps available through procfs and sysfs, w

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-31 Thread Daniel Vetter
On Sat, Oct 31, 2020 at 3:55 AM John Hubbard wrote: > > On 10/30/20 3:08 AM, Daniel Vetter wrote: > > This is used by media/videbuf2 for persistent dma mappings, not just > > for a single dma operation and then freed again, so needs > > FOLL_LONGTERM. > > > > Unfortunately current pup_locked doesn

Re: [PATCH 0/1] x86/speculation: Allow IBPB to be conditionally enabled on CPUs with always-on STIBP

2020-10-31 Thread Tom Lendacky
On 10/29/20 1:51 AM, Anand K Mistry wrote: When attempting to do some performance testing of IBPB on and AMD platform, I noticed the IBPB instruction was never being issued, even though it was conditionally on and various seccomp protected processes were force enabling it. Turns out, on those AMD

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-31 Thread Ioana Ciornei
On Sat, Oct 31, 2020 at 03:32:15PM +0100, Andrew Lunn wrote: > > Sure, I just wanted to add the comment before others simply copy and > > paste this (pseudo) code. And in patch 9 (aquantia) and 18 (realtek) > > it is used as is. And IIRC at least the Aquantia PHY doesn't mask > > the interrupt stat

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

2020-10-31 Thread Jens Axboe
On 10/31/20 4:41 AM, Sebastian Andrzej Siewior wrote: > On 2020-10-29 14:07:59 [-0700], Sagi Grimberg wrote: >>> in which context? >> >> Not sure what is the question. > > The question is in which context do you complete your requests. My guess > by now is "usually softirq/NAPI and context in rare

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

2020-10-31 Thread Jens Axboe
On 10/31/20 9:00 AM, Jens Axboe wrote: > On 10/31/20 4:41 AM, Sebastian Andrzej Siewior wrote: >> On 2020-10-29 14:07:59 [-0700], Sagi Grimberg wrote: in which context? >>> >>> Not sure what is the question. >> >> The question is in which context do you complete your requests. My guess >> by n

Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends

2020-10-31 Thread Christophe Leroy
There are also some users on 10+ year old 32-bit netbooks or business laptops, both x86 and Apple G4. The longest-lived 32-bit embedded systems with large memory (other than Arm) are probably NXP QorIQ P20xx/P40xx used in military VME bus systems, and low-end embedded systems based on Vortex86.

Re: [PATCH 1/1] x86/speculation: Allow IBPB to be conditionally enabled on CPUs with always-on STIBP

2020-10-31 Thread Tom Lendacky
On 10/29/20 1:51 AM, Anand K Mistry wrote: On AMD CPUs which have the feature X86_FEATURE_AMD_STIBP_ALWAYS_ON, STIBP is set to on and 'spectre_v2_user_stibp == SPECTRE_V2_USER_STRICT_PREFERRED'. At the same time, IBPB can be set to conditional. However, this leads to the case where it's impossibl

[PATCH v2 1/6] media: vidtv: extract the initial CRC value to into a #define

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The same constant (0x) is used in three different functions. Extract it into a #define to avoid repetition. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) dif

[PATCH v2 2/6] media: vidtv: psi: add a Network Information Table (NIT)

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Add a Network Information Table (NIT) as specified in ETSI EN 300 468. This table conveys information relating to the physical organization of the multiplexes carried via a given network and the characteristics of the network itself. It is conveyed in the output of vi

[PATCH v2 0/6] media: vidtv: Add support for more MPEG PSI tables

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement support for more MPEG PSI tables (i.e. NIT & EIT). While we're at it, fix a few minor mistakes in the PSI generator. I initially sent this without a cover letter and as WIP but I have now tidied it up and it's spotless. I tested the driver on a kernel with K

[PATCH v2 5/6] media: vidtv: Move s302m specific fields into encoder context

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida A few fields used only by the tone generator in the s302m encoder are stored in struct vidtv_encoder. Move them into struct vidtv_s302m_ctx instead. While we are at it: fix a checkpatch warning for long lines. Signed-off-by: Daniel W. S. Almeida --- .../media/test-dr

[PATCH v2 4/6] media: vidtv: psi: extract descriptor chaining code into a helper

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The code to append a descriptor to the end of a chain is repeated throughout the psi generator code. Extract it into its own helper function to avoid cluttering. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 49 ++-

[PATCH v2 6/6] media: vidtv: psi: fix missing assignments in while loops

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Some variables were only assigned once but were used in while loops as if they had been updated at every iteration. Fix this. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 22 +--- 1 file changed, 10 insertions

[PATCH v2 3/6] media: vidtv: psi: Implement an Event Information Table (EIT)

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement an Event Information Table (EIT) as per EN 300 468 5.2.4. The EIT provides information in chronological order regarding the events contained within each service. For now only present event information is supported. Signed-off-by: Daniel W. S. Almeida ---

[PATCH net-next] net: ipa: avoid a bogus warning

2020-10-31 Thread Alex Elder
The previous commit added support for IPA having up to six source and destination resources. But currently nothing uses more than four. (Five of each are used in a newer version of the hardware.) I find that in one of my build environments the compiler complains about newly-added code in two spo

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Xie He
On Sat, Oct 31, 2020 at 7:33 AM Willem de Bruijn wrote: > > > - rx_error: > > +rx_error: > > frad->stats.rx_errors++; /* Mark error */ > > +rx_drop: > > dev_kfree_skb_any(skb); > > return NET_RX_DROP; > > I meant that I don't think errors should be double counted in rx_erro

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Willem de Bruijn
On Sat, Oct 31, 2020 at 6:31 AM Alexander Lobakin wrote: > > On Saturday, 31 October 2020, 2:12, Willem de Bruijn > wrote: > > Hi Willem, > > > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: > > > > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a sup

[PATCH] mic: vop: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/misc/mic/vop/vop_vringh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c index 7014ffe88632..3ef8c63e

[PATCH] misc: ti-st: st_core: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/misc/ti-st/st_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index f4ddd1e67015..5a0a5fc3d3ab 100644 ---

Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork

2020-10-31 Thread Peter Xu
On Fri, Oct 30, 2020 at 08:51:21PM -0300, Jason Gunthorpe wrote: > > Another pure question: I'm just curious how you find all the statically > > definied mm_structs, and to make sure all of them are covered (just in case > > un-initialized seqcount could fail strangely). > > I searched for all MMA

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Willem de Bruijn
> >> I think it is fine to reenable this again, now that UDP sockets will > >> segment unexpected UDP GSO packets that may have looped. We previously > >> added general software support in commit 83aa025f535f ("udp: add gso > >> support to virtual devices"). Then reduced its scope to egress only in

[PATCH] mmc: davinci: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/mmc/host/davinci_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 90cd179625fc..2a757c88f9d2 10064

Re: [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS

2020-10-31 Thread Peter Xu
On Sat, Oct 31, 2020 at 03:06:59PM +0100, Paolo Bonzini wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index ce856e0ece84..5993fbd6d2c5 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -259,8 +259,8 @@ static int kvm_msr_ignored_check(struct kvm_vcpu *vcp

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 14:17:03 + > From: Alexander Lobakin > Date: Sat, 31 Oct 2020 10:31:31 + > >> On Saturday, 31 October 2020, 2:12, Willem de Bruijn >> wrote: >> >> Hi Willem, >> >>> On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: >>

[PATCH] net: dsa: mt7530: remove unneeded semicolon

2020-10-31 Thread trix
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/net/dsa/mt7530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index de7692b763d8..771f58f50d61 100644 --- a/drivers/ne

Re: [PATCH 1/2] KVM: selftests: Add get featured msrs test case

2020-10-31 Thread Peter Xu
On Mon, Oct 26, 2020 at 09:58:54AM +0100, Vitaly Kuznetsov wrote: > Peter Xu writes: > > > Try to fetch any supported featured msr. Currently it won't fail, so at > > least > > we can check against valid ones (which should be >0). > > > > This reproduces [1] too by trying to fetch one invalid m

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Mike Rapoport
On Sat, Oct 31, 2020 at 12:21:24PM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 12:04, Russell King - ARM Linux admin > wrote: > > > > On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > > > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > > > wrote: > > > > >

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Willem de Bruijn Date: Sat, 31 Oct 2020 11:26:24 -0400 I think it is fine to reenable this again, now that UDP sockets will segment unexpected UDP GSO packets that may have looped. We previously added general software support in commit 83aa025f535f ("udp: add gso support

Re: [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-31 Thread Xie He
On Sat, Oct 31, 2020 at 8:18 AM Xie He wrote: > > > Especially without that, I'm not sure this and the follow-on patch add > > much value. Minor code cleanups complicate backports of fixes. > > To me this is necessary, because I feel hard to do any development on > un-cleaned-up code. I really don

Re: WARNING in xfrm_alloc_compat

2020-10-31 Thread syzbot
syzbot has bisected this issue to: commit 5f3eea6b7e8f58cf5c8a9d4b9679dc19e9e67ba3 Author: Dmitry Safonov Date: Mon Sep 21 14:36:53 2020 + xfrm/compat: Attach xfrm dumps to 64=>32 bit translator bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=102aadf450 start commit:

Re: For review: seccomp_user_notif(2) manual page [v2]

2020-10-31 Thread Michael Kerrisk (man-pages)
Hello Sargun, Thanks for your reply. On 10/30/20 9:27 PM, Sargun Dhillon wrote: > On Thu, Oct 29, 2020 at 09:37:21PM +0100, Michael Kerrisk (man-pages) > wrote: [...] >>> I think I commented in another thread somewhere that the >>> supervisor is not notified if the syscall is preempted. Therefo

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Max Filippov
On Sat, Oct 31, 2020 at 2:43 AM Mike Rapoport wrote: > Please let me know how do you prefer to take it upstream. > If needed this can go via memblock tree. Going through the memblock tree sounds right to me. -- Thanks. -- Max

[PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-10-31 Thread Tabot Kevin
This patch fixes the following: - Uses __func__ macro to print function names. - Got rid of unnecessary braces around single line if statements. - End of block comments on a seperate line. - A spelling mistake of the word "on". Signed-off-by: Tabot Kevin --- drivers/staging/media/atomisp/i2c/ato

Re: KASAN: use-after-free Read in decode_session6

2020-10-31 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:68bb4665 Merge branch 'l2-multicast-forwarding-for-ocelot-.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1219346c50 kernel config: https://syzkaller.appspot.com/x/.config?x=eac680a

[RFC PATCH 0/4] Secure Launch early PCR extend support

2020-10-31 Thread Daniel P. Smith
This RFC is a break out of the prerequisite TPM functionality for the larger Secure Launch capability. This TPM/PCR subset is in a separate smaller patch set being sent as an RFC to get early feedback before the whole Secure Launch patch set is resubmitted. This patch RFC, if accepted, will be part

[RFC PATCH 1/4] tpm: Move TPM TIS definitions out of TIS core header

2020-10-31 Thread Daniel P. Smith
Move definitions from drivers/char/tpm/tpm_tis_core.h to new file drivers/char/tpm/tpm_tis_defs.h. This allows tpm_tis_defs.h to be included in the Secure Launch early PCR extend module. The rest of tpm_tis_core.h cannot be included in the compressed kernel environment. Signed-off-by: Daniel P. Sm

[RFC PATCH 3/4] tpm: Conditionally use static buffer in TPM buffer management

2020-10-31 Thread Daniel P. Smith
Memory management calls cannot be made in the compressed kernel environment to dynamically allocate TPM buffer space. For the Secure Launch early PCR extend code, use a static buffer instead. Signed-off-by: Daniel P. Smith Signed-off-by: Ross Philipson --- include/linux/tpm_buffer.h | 12 ++

[RFC PATCH 2/4] tpm: Move core definitions and buffer management out of main TPM header

2020-10-31 Thread Daniel P. Smith
Move core definitions from include/linux/tpm.h to new file include/linux/tpm_core.h. Move buffer management code from include/linux/tpm.h to new file include/linux/tpm_buffer.h. This allows tpm_tis_defs.h to be included in the Secure Launch early PCR extend module. The rest of tpm.h cannot be incl

[RFC PATCH 4/4] x86: Add early PCR extend support for Secure Launch

2020-10-31 Thread Daniel P. Smith
Access to PCR extend functionality is needed early in the compressed kernel so that Secure Launch can measure items into the DRTM PCRs before these items are used. The items include the boot parameters and associated information, the kernel command line, any external initrd and the OS-MLE TXT heap

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Jakub Kicinski
On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > The usual way of getting rid of old code is to move it to staging/ > > for a few releases then delete it, like Arnd just did with wimax. > > Oh. OK. But I see "include/linux/if_frad.h" is included in > "net/socket.c", and there's still some co

Re: [PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-31 Thread Xie He
On Fri, Oct 30, 2020 at 5:49 PM Xie He wrote: > > Add an fh->ea2 check to the initial checks in fr_rx. fh->ea2 == 1 means > the second address byte is the final address byte. We only support the > case where the address length is 2 bytes. If the address length is not > 2 bytes, the control field a

Re: [PATCH 5.9 00/74] 5.9.3-rc1 review

2020-10-31 Thread Jeffrin Jose T
On Sat, 2020-10-31 at 12:35 +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.9.3 release. > There are 74 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, > please > let me know. > >

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Mike Rapoport
On Sat, Oct 31, 2020 at 09:37:09AM -0700, Max Filippov wrote: > On Sat, Oct 31, 2020 at 2:43 AM Mike Rapoport wrote: > > Please let me know how do you prefer to take it upstream. > > If needed this can go via memblock tree. > > Going through the memblock tree sounds right to me. Can I treat this

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-31 Thread Xie He
On Sat, Oct 31, 2020 at 9:51 AM Jakub Kicinski wrote: > > > > The usual way of getting rid of old code is to move it to staging/ > > > for a few releases then delete it, like Arnd just did with wimax. > > > > Oh. OK. But I see "include/linux/if_frad.h" is included in > > "net/socket.c", and there'

Re: possible deadlock in do_fcntl

2020-10-31 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:4e78c578 Add linux-next specific files for 20201030 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17c275a250 kernel config: https://syzkaller.appspot.com/x/.config?x=83318758268dc3

<    1   2   3   4   5   6   >