Re: [PATCH v3] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-24 Thread Fabio Estevam
Hi Sven, On Wed, Jun 24, 2020 at 12:23 PM Sven Van Asbroeck wrote: > + /* > +* On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to > +* be the PTP clock source, instead of having to be routed through > +* pads. > +* Board designs which route t

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:39:48AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > > > > Aren't there dependencies on earlier patches in the series? > > > Not to my knowledge. Patch "[2

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 10:19:16AM -0700, Linus Torvalds wrote: > On Wed, Jun 24, 2020 at 9:29 AM Christoph Hellwig wrote: > > > > Add two new file operations that are identical to ->read and ->write > > except that they can also safely take kernel pointers using the uptr_t > > type. > > Honestly

[PATCH] Bluetooth: btusb: Reset port on cmd timeout

2020-06-24 Thread Abhishek Pandit-Subedi
QCA_ROME doesn't have support for the reset gpio but sometimes gets into a state where it is unresponsive to commands. When this happens, reset the port to attempt to revive the chip. Signed-off-by: Abhishek Pandit-Subedi --- On Chromebooks with this chipset, we encountered cmd_timeout after runn

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 18:09, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >> >> >> On 24.06.20 16:43, Christoph Hellwig wrote: >>> On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: Does anyone have an idea why "umh: fix processe

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 17:50:57) > On Wed, Jun 24, 2020 at 03:37:32PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 15:25:44) > > > On Wed, Jun 24, 2020 at 03:21:49PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 15:16:04) > > > > > On Wed,

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 06:56:44PM +0100, Matthew Wilcox wrote: > /* don't even try if the size is too large */ > + error = -ENOMEM; > if (count > KMALLOC_MAX_SIZE) > - return -ENOMEM; > + goto out; > + kbuf = kzalloc(count, GFP_KERNEL); > + if (!kbuf

Re: [PATCH] xen: introduce xen_vring_use_dma

2020-06-24 Thread Stefano Stabellini
On Wed, 24 Jun 2020, Michael S. Tsirkin wrote: > On Wed, Jun 24, 2020 at 05:17:32PM +0800, Peng Fan wrote: > > Export xen_swiotlb for all platforms using xen swiotlb > > > > Use xen_swiotlb to determine when vring should use dma APIs to map the > > ring: when xen_swiotlb is enabled the dma API is

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > Wait, so *some* of the series should go together but not other bits? > > But you want them split up for some reason? > Yes, this will almost certainly be the case,

Re: [PATCH] Bluetooth: btusb: Reset port on cmd timeout

2020-06-24 Thread Marcel Holtmann
Hi Abhishek, > QCA_ROME doesn't have support for the reset gpio but sometimes gets into > a state where it is unresponsive to commands. When this happens, reset > the port to attempt to revive the chip. > > Signed-off-by: Abhishek Pandit-Subedi > --- > On Chromebooks with this chipset, we encoun

Re: [PATCH v2 2/2] cpufreq: intel_pstate: Allow raw energy performance preference value

2020-06-24 Thread srinivas pandruvada
Hi Doug, On Wed, 2020-06-24 at 08:37 -0700, Doug Smythies wrote: > Hi Srinivas, > > I have immediate need for this. I have been using a tool > I wrote myself for this which I can now retire. > (it wasn't very good anyway). > Yours remembers for each governor, and is way better. > Thanks. > I wil

Re: [PATCH v2 05/21] KVM: x86/mmu: Try to avoid crashing KVM if a MMU memory cache is empty

2020-06-24 Thread Ben Gardon
On Mon, Jun 22, 2020 at 1:09 PM Sean Christopherson wrote: > > Attempt to allocate a new object instead of crashing KVM (and likely the > kernel) if a memory cache is unexpectedly empty. Use GFP_ATOMIC for the > allocation as the caches are used while holding mmu_lock. The immediate > BUG_ON() m

Re: [PATCH v2 14/21] KVM: Move x86's version of struct kvm_mmu_memory_cache to common code

2020-06-24 Thread Ben Gardon
On Mon, Jun 22, 2020 at 1:09 PM Sean Christopherson wrote: > > Move x86's 'struct kvm_mmu_memory_cache' to common code in anticipation > of moving the entire x86 implementation code to common KVM and reusing > it for arm64 and MIPS. Add a new architecture specific asm/kvm_types.h > to control the

Re: [RESEND PATCH 2/3] nouveau: fix mixed normal and device private page migration

2020-06-24 Thread Ralph Campbell
On 6/24/20 12:23 AM, Christoph Hellwig wrote: On Mon, Jun 22, 2020 at 04:38:53PM -0700, Ralph Campbell wrote: The OpenCL function clEnqueueSVMMigrateMem(), without any flags, will migrate memory in the given address range to device private memory. The source pages might already have been migra

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2020 at 10:55 AM Christoph Hellwig wrote: > > I don't care at all. Based on our previous chat I assumed you > wanted something like this. We might still need the uptr_t for > setsockopt, though. No. What I mean was *not* something like uptr_t. Just keep the existing "set_fs()"

[PATCH v2] Bluetooth: btusb: Reset port on cmd timeout

2020-06-24 Thread Abhishek Pandit-Subedi
QCA_ROME sometimes gets into a state where it is unresponsive to commands. Since it doesn't have support for a reset gpio, reset the usb port when this occurs instead. Signed-off-by: Abhishek Pandit-Subedi --- On Chromebooks with this chipset, we encountered cmd_timeout after running suspend stre

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-24 Thread Russell King - ARM Linux admin
On Wed, Jun 24, 2020 at 05:57:19PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Jun 23, 2020 at 06:27:06PM +0200, Bartosz Golaszewski wrote: > > wt., 23 cze 2020 o 11:56 Russell King - ARM Linux admin > > napisał(a): > > > > > > On Tue, Jun 23, 2020 at 11:46:15AM +0200, Bartosz Golaszews

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > > > Wait, so *some* of the series should go together but not other bits? > > > But you want them spli

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 11:11:50AM -0700, Linus Torvalds wrote: > What I mean was *not* something like uptr_t. > > Just keep the existing "set_fs()". It's not harmful if it's only used > occasionally. We should rename it once it's rare enough, though. > > Then, make the following changes: > > -

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 19:58, Christian Borntraeger wrote: > > > On 24.06.20 18:09, Luis Chamberlain wrote: >> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: >>> >>> >>> On 24.06.20 16:43, Christoph Hellwig wrote: On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraege

Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus

2020-06-24 Thread Lee Jones
On Thu, 25 Jun 2020, Masahiro Yamada wrote: > On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > > > support-card@1,1f0: $nodename:0: 'support-card@1,1f0' does not

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2020 at 11:11 AM Linus Torvalds wrote: > > So in *those* cases, we'd basically just do "oh, ok, we are supposed > to use a kernel pointer" based on the setfs value. The important part here si that we don't need to change any interfaces, because we don't add that whole "carry the b

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > > I'm not really reading any of this stuff for the series as a whole, as > > far as I could tell I'd reviewed all my bits and was hoping whatever > > random platform s

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread kernel test robot
Hi Nicolas, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on tip/perf/core kees/for-next/pstore linus/master v5.8-rc2 next-20200624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH] sysctl: Call sysctl_head_finish on error

2020-06-24 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" This error path returned directly instead of calling sysctl_head_finish(). Fixes: ef9d965bc8b6 ("sysctl: reject gigantic reads/write to sysctl files") Signed-off-by: Matthew Wilcox (Oracle) --- fs/proc/proc_sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2020 at 11:14 AM Christoph Hellwig wrote: > > So we'd need new user copy functions for just those cases No. We'd open-code them. They'd look at "oh, I'm supposed to use a kernel pointer" and just use those. IOW, basically IN THE CODE that cares (and the whole argument is that thi

Re: [PATCH] sysctl: Call sysctl_head_finish on error

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 07:17:07PM +0100, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This error path returned directly instead of calling sysctl_head_finish(). Looks good. But if you touch this anyway we also need to add the extra byte to count for the write case (see the memdu

Re: [PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu'

2020-06-24 Thread Dennis Dalessandro
On 6/22/2020 8:52 PM, Nathan Chancellor wrote: Clang warns: drivers/infiniband/hw/hfi1/qp.c:198:9: warning: implicit conversion from enumeration type 'enum opa_mtu' to different enumeration type 'enum ib_mtu' [-Wenum-conversion] mtu = OPA_MTU_8192; ~ ^~~

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 19:16, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 06:40:48PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > > > > > On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Biesheuvel wrote: > > > > On Wed, 24 Jun 2020 at 17:45, Kees Cook wr

Re: [PATCH v3] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-24 Thread Sven Van Asbroeck
Hi Fabio, On Wed, Jun 24, 2020 at 1:55 PM Fabio Estevam wrote: > > We could avoid checking for if (!IS_ERR(gpr)) two times in a row if > the following patch is applied before yours: > https://pastebin.com/raw/Ftkq2VVp > > What do you think? I think this is a good idea. I was never fully comforta

[PATCH] Bluetooth: btusb: BTUSB_WAKEUP_DISABLE prevents wake

2020-06-24 Thread Abhishek Pandit-Subedi
When the BTUSB_WAKEUP_DISABLE flag is set, always return true for prevent wake. This tells the suspend notifier not to prepare the controller for reconnections during suspend. Signed-off-by: Abhishek Pandit-Subedi --- Realtek chipsets currently lose their firmware when suspending (except in autos

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 11:20:26AM -0700, Linus Torvalds wrote: > On Wed, Jun 24, 2020 at 11:14 AM Christoph Hellwig wrote: > > > > So we'd need new user copy functions for just those cases > > No. We'd open-code them. They'd look at "oh, I'm supposed to use a > kernel pointer" and just use those

Re: [PATCH v2] Bluetooth: btusb: Reset port on cmd timeout

2020-06-24 Thread Marcel Holtmann
Hi Abhishek, > QCA_ROME sometimes gets into a state where it is unresponsive to > commands. Since it doesn't have support for a reset gpio, reset the usb > port when this occurs instead. > > Signed-off-by: Abhishek Pandit-Subedi > --- > On Chromebooks with this chipset, we encountered cmd_timeou

Re: [RFC PATCH linux-next] refperf: __srcu_struct_srcu_refctl_scale can be static

2020-06-24 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 01:47:09AM +0800, kernel test robot wrote: > > Signed-off-by: kernel test robot This gets me the following from gcc version 7.5.0: kernel/rcu/refscale.c:162:1: error: duplicate ‘static’ static DEFINE_STATIC_SRCU(srcu_refctl_scale); ^~ Is the concern the __srcu_str

Re: [PATCH] Bluetooth: btusb: BTUSB_WAKEUP_DISABLE prevents wake

2020-06-24 Thread Marcel Holtmann
Hi Abhishek, > When the BTUSB_WAKEUP_DISABLE flag is set, always return true for > prevent wake. This tells the suspend notifier not to prepare the > controller for reconnections during suspend. > > Signed-off-by: Abhishek Pandit-Subedi > --- > Realtek chipsets currently lose their firmware when

Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq

2020-06-24 Thread Doug Anderson
Hi, On Wed, Jun 24, 2020 at 10:55 AM Joel Fernandes wrote: > > On Wed, Jun 24, 2020 at 1:52 PM Qais Yousef wrote: > > > > On 06/24/20 13:35, Joel Fernandes wrote: > > > > [...] > > > > > > Doing the in-kernel opt-out via API should be fine, I think. But this > > > > will > > > > need to be disc

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 08:24:37PM +0200, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 11:20:26AM -0700, Linus Torvalds wrote: > > On Wed, Jun 24, 2020 at 11:14 AM Christoph Hellwig wrote: > > > > > > So we'd need new user copy functions for just those cases > > > > No. We'd open-code them.

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 07:29:44PM +0100, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 08:24:37PM +0200, Christoph Hellwig wrote: > > On Wed, Jun 24, 2020 at 11:20:26AM -0700, Linus Torvalds wrote: > > > On Wed, Jun 24, 2020 at 11:14 AM Christoph Hellwig wrote: > > > > > > > > So we'd need new

Re: [RFC PATCH v2] sched_pair_cpu: Introduce scheduler task pairing system call

2020-06-24 Thread Mathieu Desnoyers
- On Jun 24, 2020, at 8:11 AM, Peter Zijlstra pet...@infradead.org wrote: > On Fri, Jun 19, 2020 at 04:25:16PM -0400, Mathieu Desnoyers wrote: > >> @@ -660,6 +685,13 @@ struct task_struct { >> #ifdef CONFIG_THREAD_INFO_IN_TASK >> /* Current CPU: */ >> unsigned int

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:09, Christian Borntraeger wrote: > > > On 24.06.20 19:58, Christian Borntraeger wrote: >> >> >> On 24.06.20 18:09, Luis Chamberlain wrote: >>> On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: On 24.06.20 16:43, Christoph Hellwig wrote: >

[PATCH] Bluetooth: Don't restart scanning if paused

2020-06-24 Thread Abhishek Pandit-Subedi
When restarting LE scanning, check if it's currently paused before enabling passive scanning. Signed-off-by: Abhishek Pandit-Subedi --- When running suspend stress tests on Chromebooks, we discovered instances where the Chromebook didn't enter the deepest idle states (i.e. S0ix). After some debug

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 07:59:05PM +0200, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 06:56:44PM +0100, Matthew Wilcox wrote: > > /* don't even try if the size is too large */ > > + error = -ENOMEM; > > if (count > KMALLOC_MAX_SIZE) > > - return -ENOMEM; > > + g

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 20:32, Christian Borntraeger wrote: [...]> > So the translations look correct. But your change is actually a sematic change > if(ret) will only trigger if there is an error > if (KWIFEXITED(ret)) will always trigger when the process ends. So we will > always overwrite -ECHILD > and

Re: [PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 08:37:43PM +0200, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 07:59:05PM +0200, Christoph Hellwig wrote: > > On Wed, Jun 24, 2020 at 06:56:44PM +0100, Matthew Wilcox wrote: > > > /* don't even try if the size is too large */ > > > + error = -ENOMEM; > > > if (coun

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Jason Gunthorpe
On Wed, Jun 24, 2020 at 06:58:49PM +0100, Chris Wilson wrote: > > I'm still a little unclear on what you are trying to fix - pinned > > pages are definitely not freed, do you have some case where pages > > which are pinned are being cleaned out from the MM despite being > > pinned? Sounds a bit str

Re: [PATCH 01/26] mm: Do page fault accounting in handle_mm_fault

2020-06-24 Thread Gerald Schaefer
On Fri, 19 Jun 2020 12:05:13 -0400 Peter Xu wrote: [...] > @@ -4393,6 +4425,38 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *vma, > unsigned long address, > mem_cgroup_oom_synchronize(false); > } > > + if (ret & VM_FAULT_RETRY) > + return ret;

Re: [PATCH 18/26] mm/s390: Use general page fault accounting

2020-06-24 Thread Gerald Schaefer
On Fri, 19 Jun 2020 12:13:35 -0400 Peter Xu wrote: > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. > > CC: Heiko Carstens > CC: Vasily Gorbik > CC: Christian Bornt

[PATCH] ACPI: DPTF: Add battery participant for TigerLake

2020-06-24 Thread Srinivas Pandruvada
Added ACPI ID for battery participant for TigerLake. Signed-off-by: Srinivas Pandruvada --- drivers/acpi/dptf/dptf_power.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/dptf/dptf_power.c b/drivers/acpi/dptf/dptf_power.c index 5fab7e350db8..92b996a564d0 100644 --- a/drivers/acp

Re: [PATCH v2 1/2] PCI/ERR: Fix fatal error recovery for non-hotplug capable devices

2020-06-24 Thread Jay Vosburgh
Jay Vosburgh wrote: >sathyanarayanan.kuppusw...@linux.intel.com wrote: > >From: Kuppuswamy Sathyanarayanan >> >>Fatal (DPC) error recovery is currently broken for non-hotplug >>capable devices. With current implementation, after successful >>fatal error recovery, non-hotplug capable device state

[RFC PATCH 0/3 v3] futex/sched: introduce FUTEX_SWAP operation

2020-06-24 Thread Peter Oskolkov
From: Peter Oskolkov This is an RFC! As Paul Turner presented at LPC in 2013 ... - pdf: http://pdxplumbers.osuosl.org/2013/ocw//system/presentations/1653/original/LPC%20-%20User%20Threading.pdf - video: https://www.youtube.com/watch?v=KXuZi9aeGTw ... Google has developed an M:N userspace threa

Re: [PATCH] mm: filemap: clear idle flag for writes

2020-06-24 Thread Andrew Morton
On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get cl

[RFC PATCH 2/3 v3] futex/sched: add wake_up_process_prefer_current_cpu, use in FUTEX_SWAP

2020-06-24 Thread Peter Oskolkov
From: Peter Oskolkov This is an RFC! v2: fix undefined symbol error ifndef CONFIG_SMP, as Reported-by: kernel test robot As described in the previous patch in this patchset ("futex: introduce FUTEX_SWAP operation"), it is often beneficial to wake a task and run it on the same CPU where the cur

[RFC PATCH 3/3] selftests/futex: add futex_swap selftest

2020-06-24 Thread Peter Oskolkov
From: Peter Oskolkov This is the final RFC patch in FUTEX_SWAP patchset. It adds a test/benchmark to validate behavior and compare performance of a new FUTEX_SWAP futex operation. Detailed API design and behavior considerations are provided in the commit messages of the previous two patches. Si

[RFC PATCH 1/3 v3] futex: introduce FUTEX_SWAP operation

2020-06-24 Thread Peter Oskolkov
From: Peter Oskolkov This is an RFC! As Paul Turner presented at LPC in 2013 ... - pdf: http://pdxplumbers.osuosl.org/2013/ocw//system/presentations/1653/original/LPC%20-%20User%20Threading.pdf - video: https://www.youtube.com/watch?v=KXuZi9aeGTw ... Google has developed an M:N userspace threa

LKMM patches for next merge window

2020-06-24 Thread Paul E. McKenney
Hello! Here is the list of LKMM patches I am considering for the next merge window and the status of each. Any I am missing or any that need to wait or be modified? Thanx, Paul --

Re: [PATCH V2 0/2] nvme: Add support for ACPI StorageD3Enable property

2020-06-24 Thread David E. Box
Friendly reminder. Thanks. David On Fri, 2020-06-12 at 13:48 -0700, David E. Box wrote: > This patch set implements a solution for a BIOS hack used on some > currently > shipping Intel systems to address issues with power management policy > decisions concerning PCIe NVMe drives. Some newer Intel

Re: [PATCH v2] mm/page_alloc: fix documentation error and remove magic numbers

2020-06-24 Thread Andrew Morton
On Wed, 24 Jun 2020 18:01:31 +0100 Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 12:49:43PM -0400, Joel Savitz wrote: > > When I increased the upper bound of the min_free_kbytes value in > > ee8eb9a5fe863, I forgot to tweak the above comment to reflect > > the new value. This patch fixes that m

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 20:23, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 19:16, Dave Martin wrote: > > > > On Wed, Jun 24, 2020 at 06:40:48PM +0200, Ard Biesheuvel wrote: > > > On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > > > > > > > On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Bi

Re: [PATCH] jffs2: fix UAF problem

2020-06-24 Thread Joakim Tjernlund
Nice find, I just came across a deadlock wrt GC and rmdir, hopefully this is he fix. This needs to go to stable too, sooner rather than later. Jocke On Fri, 2020-06-19 at 17:06 +0800, Zhe Li wrote: > > The log of UAF problem is listed below. > BUG: KASAN: use-after-free in jffs2_rmdir+0xa4/0x1

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Mathieu Desnoyers
- On Jun 24, 2020, at 10:20 AM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > >> diff --git a/manual/threads.texi b/manual/threads.texi >> index bb7a42c655..d5069d5581 100644 >> --- a/manual/threads.texi >> +++ b/manual/threads.texi > >> +@deftypevar {struct rseq} __rseq_

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Robin Murphy
On 2020-06-24 17:50, Russell King - ARM Linux admin wrote: On Wed, Jun 24, 2020 at 09:06:28AM -0700, Florian Fainelli wrote: On 6/24/2020 6:48 AM, Bartosz Golaszewski wrote: I didn't expect to open such a can of worms... This has evolved into several new concepts being proposed vs my use-case

Re: [PATCH kcsan 0/10] KCSAN updates for v5.9

2020-06-24 Thread Paul E. McKenney
On Mon, Jun 22, 2020 at 05:43:10PM -0700, Paul E. McKenney wrote: > Hello! > > This series provides KCSAN updates: And three more, so that GCC can join Clang in the KCSAN fun. > 1.Annotate a data race in vm_area_dup(), courtesy of Qian Cai. > > 2.x86/mm/pat: Mark an intentional data rac

[PATCH kcsan 2/3] kcsan: Simplify compiler flags

2020-06-24 Thread paulmck
From: Marco Elver Simplify the set of compiler flags for the runtime by removing cc-option from -fno-stack-protector, because all supported compilers support it. This saves us one compiler invocation during build. Signed-off-by: Marco Elver Signed-off-by: Paul E. McKenney --- kernel/kcsan/Mak

[PATCH kcsan 3/3] kcsan: Disable branch tracing in core runtime

2020-06-24 Thread paulmck
From: Marco Elver Disable branch tracing in core KCSAN runtime if branches are being traced (TRACE_BRANCH_PROFILING). This it to avoid its performance impact, but also avoid recursion in case KCSAN is enabled for the branch tracing runtime. The latter had already been a problem for KASAN: https:

[PATCH kcsan 1/3] kcsan: Re-add GCC as a supported compiler

2020-06-24 Thread paulmck
From: Marco Elver GCC version 11 recently implemented all requirements to correctly support KCSAN: 1. Correct no_sanitize-attribute inlining behaviour: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=4089df8ef4a63126b0774c39b6638845244c20d2 2. --param=tsan-distinguish-volatile https://gcc

Re: [PATCH V2 0/2] nvme: Add support for ACPI StorageD3Enable property

2020-06-24 Thread Dan Williams
On Wed, Jun 24, 2020 at 11:55 AM David E. Box wrote: > > Friendly reminder. Thanks. Are you looking for this to be merged by ACPI with an NVMe ack, or merged by NVMe with an ACPI ack? It sometimes helps to be explicit to break the log jam. > > David > > On Fri, 2020-06-12 at 13:48 -0700, David E

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Florian Weimer
* Mathieu Desnoyers: >> I'm still worried that __rseq_static_assert and __rseq_alignof will show >> up in the UAPI with textually different definitions. (This does not >> apply to __rseq_tls_model_ie.) > > What makes this worry not apply to __rseq_tls_model_ie ? It's not needed by the kernel hea

[PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-24 Thread Chris Wilson
A general rule of thumb is that shrinkers should be fast and effective. They are called from direct reclaim at the most incovenient of times when the caller is waiting for a page. If we attempt to reclaim a page being pinned for active dma [pin_user_pages()], we will incur far greater latency than

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Mathieu Desnoyers
- On Jun 24, 2020, at 3:11 PM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > >>> I'm still worried that __rseq_static_assert and __rseq_alignof will show >>> up in the UAPI with textually different definitions. (This does not >>> apply to __rseq_tls_model_ie.) >> >> What

Re: [PATCH v3 00/15] HWPOISON: soft offline rework

2020-06-24 Thread Andrew Morton
On Wed, 24 Jun 2020 15:01:22 + nao.horigu...@gmail.com wrote: > I rebased soft-offline rework patchset [1][2] onto the latest mmotm. The > rebasing required some non-trivial changes to adjust, but mainly that was > straightforward. I confirmed that the reported problem doesn't reproduce on >

Re: [PATCH] mm: filemap: clear idle flag for writes

2020-06-24 Thread Yang Shi
On 6/24/20 11:53 AM, Andrew Morton wrote: On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: only do access activations on reads"), mark_page_accessed() is called for reads only. But the idle flag is cleared by mark_page_

Re: [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-24 Thread Jason Gunthorpe
On Wed, Jun 24, 2020 at 08:14:17PM +0100, Chris Wilson wrote: > A general rule of thumb is that shrinkers should be fast and effective. > They are called from direct reclaim at the most incovenient of times when > the caller is waiting for a page. If we attempt to reclaim a page being > pinned for

[PATCH] firewire: nosy: Fix the amount of memory deallocated by some 'pci_free_consistent' calls

2020-06-24 Thread Christophe JAILLET
'lynx->pci_device' is allocated with a size of RCV_BUFFER_SIZE. This is to say (16 * 1024). Pass the same size when it is freed. Fixes: 286468210d83 ("firewire: new driver: nosy - IEEE 1394 traffic sniffer") Signed-off-by: Christophe JAILLET --- drivers/firewire/nosy.c | 4 ++-- 1 file changed,

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Florian Weimer
* Mathieu Desnoyers: >> I think we should keep things simple on the glibc side for now and do >> this changes to the kernel headers first. > > Just to be sure I understand what you mean by "keep things simple", do you > recommend removing the following lines completely for now from sys/rseq.h ? >

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Mathieu Desnoyers
- On Jun 24, 2020, at 3:24 PM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > >>> I think we should keep things simple on the glibc side for now and do >>> this changes to the kernel headers first. >> >> Just to be sure I understand what you mean by "keep things simple", do

Re: [Patch v3 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2020-06-24 Thread Andrew Morton
On Tue, 23 Jun 2020 15:23:29 -0400 Nitesh Narayan Lal wrote: > From: Alex Belits > > The current implementation of cpumask_local_spread() does not respect the > isolated CPUs, i.e., even if a CPU has been isolated for Real-Time task, > it will return it to the caller for pinning of its IRQ thre

Re: tools/bpf: build failed with defconfig(x86_64) on v5.6 and v5.7

2020-06-24 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 11:46 PM Li Xinhai wrote: > > - information of machine > Linux localhost.localdomain 4.18.0-193.6.3.el8_2.x86_64 #1 SMP Wed Jun 10 > 11:09:32 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux > > - configurations > make defconfig > make kvmconfig > > - failed logs on v5.6 > ``` >

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread kernel test robot
Hi Nicolas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on tip/perf/core kees/for-next/pstore linus/master v5.8-rc2 next-20200624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH V2 0/2] nvme: Add support for ACPI StorageD3Enable property

2020-06-24 Thread David E. Box
On Wed, 2020-06-24 at 12:10 -0700, Dan Williams wrote: > On Wed, Jun 24, 2020 at 11:55 AM David E. Box > wrote: > > Friendly reminder. Thanks. > > Are you looking for this to be merged by ACPI with an NVMe ack, or > merged by NVMe with an ACPI ack? It sometimes helps to be explicit to > break the

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Andrzej Hajda
On 24.06.2020 17:16, Robin Murphy wrote: > On 2020-06-24 16:04, Mark Brown wrote: >> On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote: >> >>> And yeah, anyone who pipes up suggesting that places where an >>> ERR_PTR value >>> could be passed to probe_err() could simply refactor IS_ER

Re: [PATCH] Bluetooth: Don't restart scanning if paused

2020-06-24 Thread Marcel Holtmann
Hi Abhishek, > When restarting LE scanning, check if it's currently paused before > enabling passive scanning. > > Signed-off-by: Abhishek Pandit-Subedi > --- > When running suspend stress tests on Chromebooks, we discovered > instances where the Chromebook didn't enter the deepest idle states >

Re: process '/usr/bin/rsync' started with executable stack

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 07:51:48PM +0300, Dan Carpenter wrote: > In Debian testing the initrd triggers the warning. > > [ 34.529809] process '/usr/bin/fstype' started with executable stack Where does fstype come from there? I am going to guess it is either busybox or linked against klibc? klib

Re: [PATCH v4] coccinelle: misc: add array_size_dup script to detect missed overflow checks

2020-06-24 Thread Julia Lawall
On Tue, 23 Jun 2020, Denis Efremov wrote: > Detect an opencoded expression that is used before or after > array_size()/array3_size()/struct_size() to compute the same size. > > Signed-off-by: Denis Efremov Applied, thanks. julia > --- > Changes in v2: > - python rules moved next to SmPL pa

Re: [PATCH v2 1/2] arm/build: Warn on orphan section placement

2020-06-24 Thread Kees Cook
On Tue, Jun 23, 2020 at 05:03:46PM -0700, Nick Desaulniers wrote: > On Mon, Jun 22, 2020 at 1:49 PM Kees Cook wrote: > > [...] > > @@ -37,6 +38,13 @@ > > *(.idmap.text) \ > > __idmap_text_end = .;

[rcu:rcu/next 35/35] kernel/rcu/tree.c:251:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next head: 347acb93a34a6e4f312f8b9ec1afdb86d27858d2 commit: 347acb93a34a6e4f312f8b9ec1afdb86d27858d2 [35/35] rcu: Fixup noinstr warnings config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GC

Re: [PATCH rdma-next 0/4] Bag of fixes and refactoring in MAD layer

2020-06-24 Thread Jason Gunthorpe
On Sun, Jun 21, 2020 at 01:47:34PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is combination of fixes and refactoring in MAD layer. Because > everything here is "old", I'm sending it to rdma-next and not "wasting" > our time in attempt to separate fix patches from ref

Re: [PATCH 0/3] iopoll fixes

2020-06-24 Thread Jens Axboe
On 6/24/20 11:03 AM, Pavel Begunkov wrote: > On 24/06/2020 19:50, Pavel Begunkov wrote: >> Did more comprehensive iopoll testing and found some more problems. >> >> [1] is from the previous series. Actually, v2 for this one, addressing >> the double-reissue bug found by Jens. It maybe not as effici

Re: [PATCH] mm: filemap: clear idle flag for writes

2020-06-24 Thread Shakeel Butt
On Wed, Jun 24, 2020 at 10:43 AM Yang Shi wrote: > > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get cle

Re: [PATCH 1/3] mm: set page fault address for update_mmu_cache_pmd

2020-06-24 Thread Andrew Morton
On Wed, 24 Jun 2020 17:26:30 +0800 Bibo Mao wrote: > update_mmu_cache_pmd is used to update tlb for the pmd entry by > software. On MIPS system, the tlb entry indexed by page fault > address maybe exists already, only that tlb entry may be small > page, also it may be huge page. Before updating p

Re: [RFC PATCH v2] sched_pair_cpu: Introduce scheduler task pairing system call

2020-06-24 Thread Peter Zijlstra
On Wed, Jun 24, 2020 at 02:31:33PM -0400, Mathieu Desnoyers wrote: > >> + set_tsk_need_resched(current); > > > > that's set_bit(), which is an atomic operation. But it also isn't > > sufficient, at the very least it needs set_preempt_need_resched(). Also > > see resched_curr(); > > Indeed, set

Re: [PATCH] mm: filemap: clear idle flag for writes

2020-06-24 Thread Shakeel Butt
On Wed, Jun 24, 2020 at 12:18 PM Yang Shi wrote: > > > > On 6/24/20 11:53 AM, Andrew Morton wrote: > > On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi > > wrote: > > > >> Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > >> only do access activations on reads"), mark_page_access

drivers/video/fbdev/tdfxfb.c:1120:27: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 6 days ago config: s390-randconfig-s032-20200624 (attached

amdgpu: *ERROR* Waiting for fences timed out!

2020-06-24 Thread Ilkka Prusi
Hi, I got this error in kernel log from desktop freeze, it still responded to SysRq and system could be killed but desktop was unusable. I assume this might explain some problems I have seen on this computer before. I assume that preceding segfault has no meaning here but included it anyway.

[PATCH v2 00/17] arm/arm64: Turning IPIs into normal interrupts

2020-06-24 Thread Marc Zyngier
For as long as SMP ARM has existed, IPIs have been handled as something special. The arch code and the interrupt controller exchange a couple of hooks (one to generate an IPI, another to handle it). Although this is perfectly manageable, it prevents the use of features that we could use if IPIs we

[PATCH v2 05/17] irqchip/gic-v3: Describe the SGI range

2020-06-24 Thread Marc Zyngier
As we are about to start making use of SGIs in a more conventional way, let's describe it is the GICv3 list of interrupt types. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq

[PATCH v2 01/17] genirq: Add fasteoi IPI flow

2020-06-24 Thread Marc Zyngier
For irqchips using the fasteoi flow, IPIs are a bit special. They need to be EOI'd early (before calling the handler), as funny things may happen in the handler (they do not necessarily behave like a normal interrupt). Signed-off-by: Marc Zyngier --- include/linux/irq.h | 1 + kernel/irq/chip.c

[PATCH v2 08/17] irqchip/gic: Refactor SMP configuration

2020-06-24 Thread Marc Zyngier
As we are about to change quite a lot of the SMP support code, let's start by moving it around so that it minimizes the amount of #ifdefery. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic.c | 76 --- 1 file changed, 40 insertions(+), 36 deletions(-)

[PATCH v2 07/17] irqchip/gic: Atomically update affinity

2020-06-24 Thread Marc Zyngier
The GIC driver uses a RMW sequence to update the affinity, and relies on the gic_lock_irqsave/gic_unlock_irqrestore sequences to update it atomically. But these sequences only expend into anything meaningful if the BL_SWITCHER option is selected, which almost never happens. It also turns out that

[PATCH v2 02/17] genirq: Allow interrupts to be excluded from /proc/interrupts

2020-06-24 Thread Marc Zyngier
A number of architectures implement IPI statistics directly, duplicating the core kstat_irqs accounting. As we move IPIs to being actual IRQs, we would end-up with a confusing display in /proc/interrupts (where the IPIs would appear twice). In order to solve this, allow interrupts to be flagged as

[PATCH v2 09/17] irqchip/gic: Configure SGIs as standard interrupts

2020-06-24 Thread Marc Zyngier
Change the way we deal with GIC SGIs by turning them into proper IRQs, and calling into the arch code to register the interrupt range instead of a callback. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic.c | 101 +++--- 1 file changed, 62 insertions(+), 3

<    1   2   3   4   5   6   7   8   9   10   >