Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-24 Thread Dan Carpenter
On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote: > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service) > > int32_t vchi_service_open(struct vchiq_instance *instance, > struct service_creation *setup, > - struct vchi_service_handle **handl

Re: [RESEND PATCH v5 4/5] drm/bridge/sii8620: fix resource acquisition error handling

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 03:43:10PM +0200, Andrzej Hajda wrote: > > On 24.06.2020 15:25, Mark Brown wrote: > > If we silently ignore all deferred probe errors we make it hard for > > anyone who is experiencing issues with deferred probe to figure out what > > they're missing. We should at least b

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 13:39:10) > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 13:10:53) > > > On Wed, Jun 24, 2020 at 09:02:47AM +0100, Chris Wilson wrote: > > > > When direct reclaim enters the shrinker and tries to reclaim pa

Re: [PATCH 12/22] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > Replace constant array sizes with a macro constant to clarify the source > of array sizes, provide a place to document any constraints on the size, > and to simplify array sizing in userspace if constructing structs > from their composite fields

Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-24 Thread Nicolas Saenz Julienne
On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote: > On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote: > > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service) > > > > int32_t vchi_service_open(struct vchiq_instance *instance, > > struct ser

Re: [PATCH 4.14 038/190] KVM: x86: only do L1TF workaround on affected processors

2020-06-24 Thread Sasha Levin
On Wed, Jun 24, 2020 at 12:00:59PM +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: On Fri, 2020-06-19 at 16:31 +0200, Greg Kroah-Hartman wrote: From: Paolo Bonzini [ Upstream commit d43e2675e96fc6ae1a633b6a69d296394448cc32 ] KVM stores the gfn in MMIO SPTEs as a caching optimization. The

[PATCH][next] drm: amdgpu: fix premature goto because of missing braces

2020-06-24 Thread Colin King
From: Colin Ian King Currently the goto statement is skipping over a lot of setup code because it is outside of an if-block and should be inside it. Fix this by adding missing if statement braces. Addresses-Coverity: ("Structurally dead code") Fixes: fd151ca5396d ("drm amdgpu: SI UVD v3_1") Sign

Re: [PATCH v5] hwmon: add Corsair Commander Pro driver

2020-06-24 Thread Guenter Roeck
On 6/24/20 5:47 AM, Marius Zachmann wrote: > As requested I have squashed the 3 commits into one. > Sorry for the confusion. > > This is v5 of a driver for the Corsair Commander Pro. > It provides sysfs attributes for: > - Reading fan speed > - Reading temp sensors > - Reading voltage values > - W

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Jason Gunthorpe
On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: > > > Quoting Jason Gunthorpe (2020-06-24 13:10:53) > > > > On Wed, Jun 24, 2020 at 09:02:47AM +0100, Chris Wilson wrote: >

Re: Looping more in detach_tasks() when RT and CFS tasks are present

2020-06-24 Thread Pavan Kondeti
Hi Vincent, On Wed, Jun 24, 2020 at 02:39:25PM +0200, Vincent Guittot wrote: > Hi Pavan, > > On Wed, 24 Jun 2020 at 13:42, Pavan Kondeti wrote: > > > > Hi Vincent/Peter, > > > > in load_balance(), we derive env->loop_max based on rq->nr_running. > > When the busiest rq has both RT and CFS tasks,

Re: [PATCH][next] libbpf: fix spelling mistake "kallasyms" -> "kallsyms"

2020-06-24 Thread Daniel Borkmann
On 6/23/20 10:42 AM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a pr_warn message. Fix it. Signed-off-by: Colin Ian King Applied, thanks!

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > > > Rename priv to gcdev to improve readability. > > > > The name "priv" indicates that the object is pointed to by > > file->private_data, not what the object is actually is

Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

2020-06-24 Thread Florian Weimer
* Mathieu Desnoyers: > diff --git a/manual/threads.texi b/manual/threads.texi > index bb7a42c655..d5069d5581 100644 > --- a/manual/threads.texi > +++ b/manual/threads.texi > +@deftypevar {struct rseq} __rseq_abi > +@standards{Linux, sys/rseq.h} > +@Theglibc{} implements a @code{__rseq_abi} TLS sy

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: > On 23/06/2020 18:48, Catalin Marinas wrote: > > On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: > > > These patches add support to KVM to enable MTE within a guest. It is > > > based on Catalin's v4 MTE user space series[

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Bartosz Golaszewski
śr., 24 cze 2020 o 16:19 Kent Gibson napisał(a): > > On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > > > > > Rename priv to gcdev to improve readability. > > > > > > The name "priv" indicates that the object is pointed

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 15:16:04) > On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 13:10:53) > > > > > On Wed,

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Robin Murphy
On 2020-06-24 13:55, Andy Shevchenko wrote: On Wed, Jun 24, 2020 at 3:37 PM Robin Murphy wrote: On 2020-06-24 12:41, Andrzej Hajda wrote: Many resource acquisition functions return error value encapsulated in pointer instead of integer value. To simplify coding we can use macro which will acce

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Jason Gunthorpe
On Wed, Jun 24, 2020 at 03:21:49PM +0100, Chris Wilson wrote: > Quoting Jason Gunthorpe (2020-06-24 15:16:04) > > On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > > > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > > > On Wed, Jun 24, 2020 at 01:21:03PM +0100, Chris Wilson wrote: >

Re: [PATCH] mm/page_alloc: fix documentation error and remove magic numbers

2020-06-24 Thread Rafael Aquini
On Wed, Jun 24, 2020 at 03:09:58PM +0100, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 10:07:27AM -0400, Rafael Aquini wrote: > > On Wed, Jun 24, 2020 at 12:12:55PM +0100, Matthew Wilcox wrote: > > > On Tue, Jun 23, 2020 at 11:27:12PM -0400, Joel Savitz wrote: > > > > In addition, this patch rep

Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()

2020-06-24 Thread Markus Elfring
>> Are you going to compare the published patches any further? … >> Which patch variant will be integrated finally? > > Just picked up Yu Kuai's patch. Is it interesting anyhow that you committed a change description which contained a typo (on 2020-06-23 20:11:30 +0800)? https://git.kernel.org/pub

Re: [PATCH v8 04/13] perf stat: factor out body of event handling loop for system wide

2020-06-24 Thread Alexey Budankov
On 23.06.2020 17:56, Jiri Olsa wrote: > On Wed, Jun 17, 2020 at 11:37:43AM +0300, Alexey Budankov wrote: >> >> Introduce process_timeout() and process_interval() functions that >> factor out body of event handling loop for attach and system wide >> monitoring use cases. >> >> Signed-off-by: Alexe

Re: [PATCH] mm/page_alloc: fix documentation error and remove magic numbers

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 10:26:26AM -0400, Rafael Aquini wrote: > Joel's approach, however, makes sense if you consider it's generally a > good practice to get rid of the unnamed magic numbers anti-pattern. But I don't. I care about how easy it is to understand the code, not conforming to some bu

drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:62:6: error: implicit declaration of function 'cpu_has_feature'; did you mean

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 commit: 16a9dea110a67d62401ffeac4828cabdedec7548 amdgpu: Enable initial DCN support on POWER date: 6 months ago config: powerpc-randconfig-r031-20200624 (attached

Re: [PATCH][next] drm: amdgpu: fix premature goto because of missing braces

2020-06-24 Thread Nirmoy
Acked-by: Nirmoy Das Thanks, Nirmoy On 6/24/20 4:14 PM, Colin King wrote: From: Colin Ian King Currently the goto statement is skipping over a lot of setup code because it is outside of an if-block and should be inside it. Fix this by adding missing if statement braces. Addresses-Coverity

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Andy Shevchenko
On Tue, Jun 23, 2020 at 7:04 AM Kent Gibson wrote: > > Add a new version of the uAPI to address existing 32/64bit alignment I think using - would be nice, like 32/64-bit (or at least space like 32/64 bit) as a common practice. > issues, add support for debounce and event sequence numbers, and pr

Re: [PATCH v33 02/21] x86/cpufeatures: x86/msr: Add Intel SGX Launch Control hardware bits

2020-06-24 Thread Sean Christopherson
On Wed, Jun 24, 2020 at 03:04:34PM +0200, Borislav Petkov wrote: > On Thu, Jun 18, 2020 at 01:08:24AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add X86_FEATURE_SGX_LC, which informs whether or not the CPU supports SGX > > Launch Control. > > > > Add MSR_IA32_SGXLEPUBKEY

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > Add a new version of the uAPI to address existing 32/64bit alignment > issues, add support for debounce and event sequence numbers, and provide > some future proofing by adding padding reserved for future use. > > The alignment issue relates to

Re: [PATCH 1/2] mm/mmu_notifier: Mark up direct reclaim paths with MAYFAIL

2020-06-24 Thread Chris Wilson
Quoting Jason Gunthorpe (2020-06-24 15:25:44) > On Wed, Jun 24, 2020 at 03:21:49PM +0100, Chris Wilson wrote: > > Quoting Jason Gunthorpe (2020-06-24 15:16:04) > > > On Wed, Jun 24, 2020 at 03:12:42PM +0100, Chris Wilson wrote: > > > > Quoting Jason Gunthorpe (2020-06-24 13:39:10) > > > > > On Wed,

[PATCH] intel_idle: Eliminate redundant static variable

2020-06-24 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The value of the lapic_timer_always_reliable static variable in the intel_idle driver reflects the boot_cpu_has(X86_FEATURE_ARAT) value and so it also reflects the static_cpu_has(X86_FEATURE_ARAT) value. Hence, the lapic_timer_always_reliable check in intel_idle() is redu

Re: [PATCH v4 17/18] nitro_enclaves: Add overview documentation

2020-06-24 Thread Paraschiv, Andra-Irina
On 23/06/2020 11:59, Stefan Hajnoczi wrote: On Mon, Jun 22, 2020 at 11:03:28PM +0300, Andra Paraschiv wrote: +The kernel bzImage, the kernel command line, the ramdisk(s) are part of the +Enclave Image Format (EIF); plus an EIF header including metadata such as magic +number, eif version, imag

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote: > On 24.06.2020 15:53, Luis Chamberlain wrote: > > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about t

Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests

2020-06-24 Thread Alexander Gordeev
On Wed, Jun 24, 2020 at 01:48:08PM +0200, Gerald Schaefer wrote: > On Wed, 24 Jun 2020 13:05:39 +0200 > Alexander Gordeev wrote: > > > On Wed, Jun 24, 2020 at 08:43:10AM +0530, Anshuman Khandual wrote: > > > > [...] > > > > > Hello Gerald/Christophe/Vineet, > > > > > > It would be really great

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: > Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC is > used" breaks the > linux-bridge on s390? Are we even sure this is s390 specific and doesn't happen on other architectures with the same bridge se

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Andrzej Hajda
On 24.06.2020 14:14, Rafael J. Wysocki wrote: > On Wed, Jun 24, 2020 at 1:41 PM Andrzej Hajda wrote: >> Many resource acquisition functions return error value encapsulated in >> pointer instead of integer value. To simplify coding we can use macro >> which will accept both types of error. >> Wit

Re: [PATCH v2 12/12] arm64: dts: qcom: Add support for Sony Xperia Z5 (SoMC Sumire-RoW)

2020-06-24 Thread Konrad Dybcio
>This does worry me... Yeah, sadly the only way to get SMP on every msm8916/39 and *some* 92/94 mobile devices is to use something along this: [1] But for now, 1 core is enough. We will worry when more peripherals are brought up. [1] https://github.com/msm8916-mainline/linux/commit/1b12cb1f8e71

Re: [PATCH RESEND] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 5:40 AM Dariusz Marcinkiewicz wrote: > > Hello. > > I realized that I sent the previous answer using HTML, and as a > consequence it was blocked from mailing lists. Sending it again > (apologies for double posting). > > On Mon, Jun 22, 2020 at 12:23 PM Hans Verkuil > wrot

Re: [PATCH v2 3/5] arm64: vdso: Don't use gcc plugins for building vgettimeofday.c

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 03:33:28PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm64/kernel/vdso/vgettimeofday.c > to avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov It looks like Will has taken this already, but: Acked-by: Kees Cook -- Kees Coo

Re: [PATCH 10/22] gpiolib: cdev: fix minor race in GET_LINEINFO_WATCH

2020-06-24 Thread Andy Shevchenko
On Tue, Jun 23, 2020 at 7:03 AM Kent Gibson wrote: > > Merge separate usage of test_bit/set_bit into test_and_set_bit to remove > the possibility of a race between the test and set. > > Similarly test_bit and clear_bit. > > In the existing code it is possible for two threads to race past the > tes

Re: [PATCH] media: s5p-g2d: Fix a memory leak in an error handling path in 'g2d_probe()'

2020-06-24 Thread Hans Verkuil
On 26/04/2020 22:06, Christophe JAILLET wrote: > Memory allocated with 'v4l2_m2m_init()' must be freed by a corresponding > call to 'v4l2_m2m_release()' > > Fixes: 5ce60d790a24 ("[media] s5p-g2d: Add DT based discovery support") > Signed-off-by: Christophe JAILLET > --- > drivers/media/platform/

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Andrzej Hajda
On 24.06.2020 14:30, Greg Kroah-Hartman wrote: > On Wed, Jun 24, 2020 at 01:41:25PM +0200, Andrzej Hajda wrote: >> Many resource acquisition functions return error value encapsulated in >> pointer instead of integer value. To simplify coding we can use macro >> which will accept both types of err

Re: [PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 03:33:26PM +0300, Alexander Popov wrote: > There is no need to try instrumenting functions in kernel/stackleak.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov > Acked-by: Kees Cook Thanks!

Re: [PATCH] bcache: journel: use for_each_clear_bit() to simplify the code

2020-06-24 Thread Coly Li
On 2020/6/24 14:52, Xu Wang wrote: > Using for_each_clear_bit() to simplify the code. > > Signed-off-by: Xu Wang It looks good to me, I will add it in my testing patches. Thanks. Coly Li > --- > drivers/md/bcache/journal.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff

Re: [PATCH] gpio: add GPO driver for PCA9570

2020-06-24 Thread Andy Shevchenko
On Wed, Jun 24, 2020 at 4:46 PM Michael Walle wrote: > Am 2020-06-24 15:33, schrieb Andy Shevchenko: > > On Tue, Jun 23, 2020 at 3:48 PM Michael Walle wrote: > >> Am 2020-06-23 14:22, schrieb Sungbo Eo: > >> > On 2020-06-23 17:31, Michael Walle wrote: > >> >> Am 2020-06-23 08:05, schrieb Sungbo E

Re: [PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to > avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov Applied to for-next/gcc-plugins. -- Kees Cook

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > Add 'verbose' plugin parameter for stackleak gcc plugin. > It can be used for printing additional info about the kernel code > instrumentation. > > For using it add the following to scripts/Makefile.gcc-plugins: > gcc-plugin-cfla

[PATCH][next] drm/amdgpu: ensure 0 is returned for success in jpeg_v2_5_wait_for_idle

2020-06-24 Thread Colin King
From: Colin Ian King In the cases where adev->jpeg.num_jpeg_inst is zero or the condition adev->jpeg.harvest_config & (1 << i) is always non-zero the variable ret is never set to an error condition and the function returns an uninitialized value in ret. Since the only exit condition at the end i

Re: [PATCH] media: rcar-vin: Move media_device_register to async completion

2020-06-24 Thread Niklas Söderlund
Hi Hans, On 2020-06-24 15:31:01 +0200, Hans Verkuil wrote: > On 17/06/2020 17:28, Niklas Söderlund wrote: > > Hi Michael, > > > > On 2020-06-17 17:15:37 +0200, Michael Rodin wrote: > >> Hi Niklas and Steve, > >> > >> On Wed, Jun 17, 2020 at 12:56:46PM +0200, Niklas Söderlund wrote: > >>> Hi Micha

Re: [PATCH v8 12/13] perf record: implement control commands handling

2020-06-24 Thread Alexey Budankov
On 24.06.2020 17:00, Alexey Budankov wrote: > > On 23.06.2020 17:54, Jiri Olsa wrote: >> On Wed, Jun 17, 2020 at 11:43:58AM +0300, Alexey Budankov wrote: >>> >>> Implement handling of 'enable' and 'disable' control commands >>> coming from control file descriptor. >>> >>> Signed-off-by: Alexey B

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Rafael J. Wysocki
On Wed, Jun 24, 2020 at 4:44 PM Andrzej Hajda wrote: > > > On 24.06.2020 14:14, Rafael J. Wysocki wrote: > > On Wed, Jun 24, 2020 at 1:41 PM Andrzej Hajda wrote: > >> Many resource acquisition functions return error value encapsulated in > >> pointer instead of integer value. To simplify coding w

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Steven Price
On 24/06/2020 15:21, Catalin Marinas wrote: On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: On 23/06/2020 18:48, Catalin Marinas wrote: On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: These patches add support to KVM to enable MTE within a guest. It is based on Cata

Re: [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-24 Thread Rafael J. Wysocki
On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz wrote: > > Inspecting input device's 'users' member should be done under device's > mutex, so add appropriate invocations. > > Signed-off-by: Andrzej Pietrasiewicz This looks like a fix that might be applied independently of the other patches

Re: [RESEND PATCH v5 1/5] driver core: add probe_err log helper

2020-06-24 Thread Robin Murphy
On 2020-06-24 15:02, Mark Brown wrote: > On Wed, Jun 24, 2020 at 04:45:28PM +0300, Andy Shevchenko wrote: >> On Wed, Jun 24, 2020 at 4:27 PM Mark Brown wrote: > >>> As I said down the thread that's not a great pattern since it means that >>> probe deferral errors never get displayed and users hav

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/23/20 7:46 PM, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: >> On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: >>> The read-ahead shouldn't block, so allow it to be done even if >>> IOCB_NOWAIT is set in the kiocb. >> >> Doesn't think break

[PATCH v3 2/8] arm64: dts: qcom: msm8994: Add SCM node

2020-06-24 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi index 9ae848442d0b..bf5aa7308b63 100644 --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi +++ b

[PATCH v3 3/8] arm64: dts: qcom: msm8992: Add a label to rpm-requests

2020-06-24 Thread Konrad Dybcio
This enables the node to be referenced directly from other DTs. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi index 2021795c

[PATCH v3 01/15] mm,hwpoison: cleanup unused PageHuge() check

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi Drop the PageHuge check, which is dead code since memory_failure() forks into memory_failure_hugetlb() for hugetlb pages. memory_failure() and memory_failure_hugetlb() shares some functions like hwpoison_user_mappings() and identify_page_state(), so they should properly han

[PATCH v3 1/8] firmware: qcom_scm: Add msm8994 compatible

2020-06-24 Thread Konrad Dybcio
This change adds a compatible for msm8994, which requires no additional clocks for scm to probe correctly. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + drivers/firmware/qcom_scm.c | 1 + 2 files changed, 2 insertions(

[PATCH v3 0/8] MSM8994 peripheral enablement, DTS updates

2020-06-24 Thread Konrad Dybcio
changes since v2: - drop applied patches - add msm8994 SCM compat and binding - declare regulators in device DTs - make APCS a mailbox Konrad Dybcio (8): firmware: qcom_scm: Add msm8994 compatible arm64: dts: qcom: msm8994: Add SCM node arm64: dts: qcom: msm8992: Add a label to rpm-requests

[PATCH v3 4/8] arm64: dts: qcom: msm8992: Remove regulators from SoC DTSI

2020-06-24 Thread Konrad Dybcio
This is now considered obsolete practice. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8992.dtsi | 46 --- 1 file changed, 46 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi index 8e5a3ae79997..d41b

[PATCH v3 08/15] mm,hwpoison: remove MF_COUNT_INCREASED

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi Now there's no user of MF_COUNT_INCREASED, so we can safely remove it from all calling points. Signed-off-by: Naoya Horiguchi Signed-off-by: Oscar Salvador --- include/linux/mm.h | 7 +++ mm/memory-failure.c | 14 +++--- 2 files changed, 6 insertions(+), 15

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/23/20 10:38 PM, Dave Chinner wrote: > On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: >> The read-ahead shouldn't block, so allow it to be done even if >> IOCB_NOWAIT is set in the kiocb. >> >> Acked-by: Johannes Weiner >> Signed-off-by: Jens Axboe > > BTW, Jens, in case nobody

[PATCH v3 06/15] mm,hwpoison: Un-export get_hwpoison_page and make it static

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador Since get_hwpoison_page is only used in memory-failure code now, let us un-export it and make it private to that code. Signed-off-by: Oscar Salvador Signed-off-by: Naoya Horiguchi --- include/linux/mm.h | 1 - mm/memory-failure.c | 3 +-- 2 files changed, 1 insertion(+),

[PATCH v3 03/15] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi The call to get_user_pages_fast is only to get the pointer to a struct page of a given address, pinning it is memory-poisoning handler's job, so drop the refcount grabbed by get_user_pages_fast(). Note that the target page is still pinned after this put_page() because the c

[PATCH v3 04/15] mm,madvise: Refactor madvise_inject_error

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador Make a proper if-else condition for {hard,soft}-offline. Signed-off-by: Oscar Salvador Signed-off-by: Naoya Horiguchi --- mm/madvise.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git v5.8-rc1-mmots-2020-06-20-21-44/mm/madvise.c v5.8-rc

[PATCH v3 7/8] arm64: dts: qcom: Move msm8994-smd-rpm contents to lg-bullhead.

2020-06-24 Thread Konrad Dybcio
This was the only device using that dtsi, so no point keeping it separate AND with a confusing name (bullhead is based on msm8992 and the file contains regulator values for that specific board). Signed-off-by: Konrad Dybcio --- .../dts/qcom/msm8992-bullhead-rev-101.dts | 225 ++-

[PATCH v3 02/15] mm, hwpoison: remove recalculating hpage

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi hpage is never used after try_to_split_thp_page() in memory_failure(), so we don't have to update hpage. So let's not recalculate/use hpage. Suggested-by: "Aneesh Kumar K.V" Signed-off-by: Naoya Horiguchi --- mm/memory-failure.c | 6 +- 1 file changed, 1 insertion(+

[PATCH v3 11/15] mm,hwpoison: Rework soft offline for free pages

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador When trying to soft-offline a free page, we need to first take it off the buddy allocator. Once we know is out of reach, we can safely flag it as poisoned. take_page_off_buddy will be used to take a page meant to be poisoned off the buddy allocator. take_page_off_buddy calls

[PATCH v3 09/15] mm,hwpoison: remove flag argument from soft offline functions

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi The argument @flag no longer affects the behavior of soft_offline_page() and its variants, so let's remove them. Signed-off-by: Naoya Horiguchi Signed-off-by: Oscar Salvador --- drivers/base/memory.c | 2 +- include/linux/mm.h| 2 +- mm/madvise.c | 2 +-

[PATCH v3 05/15] mm,hwpoison-inject: don't pin for hwpoison_filter

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi Another memory error injection interface debugfs:hwpoison/corrupt-pfn also takes bogus refcount for hwpoison_filter(). It's justified because this does a coarse filter, expecting that memory_failure() redoes the check for sure. Signed-off-by: Naoya Horiguchi Signed-off-by:

[PATCH v3 10/15] mm,hwpoison: Unify THP handling for hard and soft offline

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador Place the THP's page handling in a helper and use it from both hard and soft-offline machinery, so we get rid of some duplicated code. Signed-off-by: Oscar Salvador Signed-off-by: Naoya Horiguchi --- mm/memory-failure.c | 48 +

[PATCH v3 12/15] mm,hwpoison: Rework soft offline for in-use pages

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador This patch changes the way we set and handle in-use poisoned pages. Until now, poisoned pages were released to the buddy allocator, trusting that the checks that take place prior to hand the page would act as a safe net and would skip that page. This has proved to be wrong,

[PATCH v3 13/15] mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_page

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador Merging soft_offline_huge_page and __soft_offline_page let us get rid of quite some duplicated code, and makes the code much easier to follow. Now, __soft_offline_page will handle both normal and hugetlb pages. Note that move put_page() block to the beginning of page_handle

[PATCH v3 14/15] mm,hwpoison: Return 0 if the page is already poisoned in soft-offline

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador Currently, there is an inconsistency when calling soft-offline from different paths on a page that is already poisoned. 1) madvise: madvise_inject_error skips any poisoned page and continues the loop. If that was the only page to madvise, it returns

[PATCH v3 8/8] arm64: dts: qcom: Add support for Sony Xperia Z5 (SoMC Sumire-RoW)

2020-06-24 Thread Konrad Dybcio
Add device tree support for the Sony Xperia Z5 smartphone. It's based on Sony Kitakami platform (msm8994) and hence a Kitakami-common DTSI has been created so as to reduce clutter when remaining devices are added. The board currently supports * Serial * SDHCI * I2C * Regulator configuration * psto

[PATCH v3 07/15] mm,hwpoison: Kill put_hwpoison_page

2020-06-24 Thread nao . horiguchi
From: Oscar Salvador After commit 4e41a30c6d50 ("mm: hwpoison: adjust for new thp refcounting"), put_hwpoison_page got reduced to a put_page. Let us just use put_page instead. Signed-off-by: Oscar Salvador Signed-off-by: Naoya Horiguchi --- include/linux/mm.h | 1 - mm/memory-failure.c | 30

[PATCH v3 5/8] mailbox: qcom: Add msm8994 apcs compatible

2020-06-24 Thread Konrad Dybcio
MSM8994 has an APCS block similar to 8916, but with a different clock driver due to the former one having 2 clusters. Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 + 2 fil

[PATCH v3 6/8] arm64: dts: qcom: msm8994: Add support for SMD RPM

2020-06-24 Thread Konrad Dybcio
Add support for SMD RPM, including pm8994 and pmi8994 regulators. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 43 +++ 1 file changed, 43 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi

[PATCH v3 00/15] HWPOISON: soft offline rework

2020-06-24 Thread nao . horiguchi
I rebased soft-offline rework patchset [1][2] onto the latest mmotm. The rebasing required some non-trivial changes to adjust, but mainly that was straightforward. I confirmed that the reported problem doesn't reproduce on compaction after soft offline. For more precise description of the proble

[PATCH v3 15/15] mm,hwpoison: introduce MF_MSG_UNSPLIT_THP

2020-06-24 Thread nao . horiguchi
From: Naoya Horiguchi memory_failure() is supposed to call action_result() when it handles a memory error event, but there's one missing case. So let's add it. I find that include/ras/ras_event.h has some other MF_MSG_* undefined, so this patch also adds them. Signed-off-by: Naoya Horiguchi --

Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Konrad Dybcio
Interesting, the downstream DTS only mentions the 0x010AD one.. Are you sure you're not looking at 636/660? Regards Konrad

Re: [PATCH v2 04/12] arm64: dts: qcom: msm8994: Add support for SMD RPM

2020-06-24 Thread Konrad Dybcio
> Can you please extend qcom-apcs-ipc-mailbox and its binding to add > MSM8994 and use mboxes = <&apcs 0>; here instead? I have in fact converted it into a mailbox and sent in the v3, but unfortunately it looks like the SMD RPM driver hasn't been updated for "mboxes =", so I stuck with the "qcom,i

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote: > And yeah, anyone who pipes up suggesting that places where an ERR_PTR value > could be passed to probe_err() could simply refactor IS_ERR() checks with > more uses of the god-awful PTR_ERR_OR_ZERO() obfuscator gets a long stare of > d

[PATCH 0/8] Fix a bunch of W=1 warnings in Backlight

2020-06-24 Thread Lee Jones
Attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (8): backlight: lms501kf03: Remove unused const variables backlight: lcd: Add missing kerneldoc entry for 'struct device parent' backlight: ili922x: Add missing kerneld

[PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' drivers/video/backlight/backlight.c:354: warning: Function parameter or

[PATCH 8/8] backlight: qcom-wled: Remove unused configs for LED3 and LED4

2020-06-24 Thread Lee Jones
Fixes W=1 warnings: drivers/video/backlight/qcom-wled.c:1294:34: warning: ‘wled4_string_cfg’ defined but not used [-Wunused-const-variable=] 1294 | static const struct wled_var_cfg wled4_string_cfg = { | ^~~~ drivers/video/backlight/qcom-wled.c:1290:34: warning: ‘wled3_string_cfg’

[PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Software Engineering Signed-off-by: Lee Jo

[PATCH 2/8] backlight: lcd: Add missing kerneldoc entry for 'struct device parent'

2020-06-24 Thread Lee Jones
This has been missing since the conversion to 'struct device' in 2007. Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Jamey Hicks Cc: Andrew Zabolotny Signed-off-by: Lee Jones --- drivers/video/backlight/lcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/lcd.c b/drivers

[PATCH 1/8] backlight: lms501kf03: Remove unused const variables

2020-06-24 Thread Lee Jones
W=1 kernel build reports: drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’ defined but not used [-Wunused-const-variable=] 96 | static const unsigned char seq_sleep_in[] = { | ^~~~ drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined but not use

[PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG' drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not d

[PATCH 7/8] backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0

2020-06-24 Thread Lee Jones
unsigned ints 'sources' and 'bank' cannot be less than LM3630A_SINK_0 (0) and LM3630A_BANK_0 (0) respecitively, so change the logic to only check for thier two possible valid values. Fixes W=1 warnings: drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_led_sources’: drivers/video

[PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax

2020-06-24 Thread Lee Jones
Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/video/backlight/ili922x.c:127: warning: cannot understand function prototype: 'int ili922x_id = 1; ' drivers/video/backlight/ili922x.c:136: warning: cannot understand function prototype: 'struct

[PATCH v2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-24 Thread Sven Van Asbroeck
On imx6, the ethernet reference clock (clk_enet_ref) can be generated by either the imx6, or an external source (e.g. an oscillator or the PHY). When generated by the imx6, the clock source (from ANATOP) must be routed to the input of clk_enet_ref via two pads on the SoC, typically via a dedicated

[PATCH 07/10] mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue

2020-06-24 Thread Lee Jones
Smatch reports: drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20:unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20:unsigned long * This is due to mixed types being compared in a min(

[PATCH 02/10] mfd: twl4030-irq: Fix cast to restricted __le32 warning

2020-06-24 Thread Lee Jones
Silences Sparse warning(s): drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restrict

[PATCH 08/10] mfd: tc3589x: Remove invalid use of kerneldoc syntax

2020-06-24 Thread Lee Jones
Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35890' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35892' not described in enum 'tc3589x_ver

[PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg_{un}lock args

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock' drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not descri

[PATCH 06/10] mfd: ab3100-core: Fix incompatible types in comparison expression warning

2020-06-24 Thread Lee Jones
Smatch reports: drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab3100-core.c:501:20:unsigned int * drivers/mfd/ab3100-core.c:501:20:unsigned long * drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types

[PATCH 01/10] mfd: twl4030-irq: Fix incorrect type in assignment warning

2020-06-24 Thread Lee Jones
Silences Sparse warning: drivers/mfd/twl4030-irq.c:485:26: warning: incorrect type in assignment (different base types) drivers/mfd/twl4030-irq.c:485:26:expected unsigned int [usertype] word drivers/mfd/twl4030-irq.c:485:26:got restricted __le32 [usertype] Cc: Cc: Tony Lindgren Cc:

[PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning

2020-06-24 Thread Lee Jones
Sparse reports: drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static? ... due to a missing header file. Cc: Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones --- drivers/mfd/sprd-sc27xx-spi.c |

[PATCH 04/10] mfd: altera-sysmgr: Fix physical address storing hacks

2020-06-24 Thread Lee Jones
Sparse reports: drivers/mfd/altera-sysmgr.c:150:30: warning: incorrect type in assignment (different address spaces) drivers/mfd/altera-sysmgr.c:150:30:expected unsigned int [usertype] *base drivers/mfd/altera-sysmgr.c:150:30:got void [noderef] * drivers/mfd/altera-sysmgr.c:156:26: w

  1   2   3   4   5   6   7   8   9   10   >