Re: [RFC PATCH 01/10] DT bindings in plain text format

2020-06-22 Thread Lee Jones
On Sun, 21 Jun 2020, Jonathan Neuschäfer wrote: > For reference, here are the devicetree bindings in plaintext format. > (Not for merge.) This would be better placed inside the relevant patch(es), rather than in a separate non-mergeable extra/superfluous patch. > Signed-off-by: Jonathan Neuschäf

Re: [PATCH 7/7] arm64: dts: mt8183: Add krane-sku176 board

2020-06-22 Thread Matthias Brugger
On 19/06/2020 12:27, Enric Balletbo i Serra wrote: > Also known as the Lenovo IdeaPad Duet Chromebook. > > There are different krane boards with shared resources, hence a > mt8183-kukui-krane.dtsi was created for easily introduce future new > boards. The same happens with the baseboard codename

Re: [PATCH v13 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-06-22 Thread Xin Ji
On Sun, Jun 21, 2020 at 10:09:25AM +0200, Sam Ravnborg wrote: > Hi Xin. > > > On Tue, Jun 09, 2020 at 03:19:50PM +0800, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > > > Signed-of

arch/mips/sgi-ip27/ip27-init.c:123:2: error: implicit declaration of function 'register_smp_ops'

2020-06-22 Thread kernel test robot
code date: 8 months ago config: mips-randconfig-r021-20200622 (attached as .config) compiler: mips64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [PATCH] dt-bindings: backlight: Convert common backlight bindings to DT schema

2020-06-22 Thread Daniel Thompson
On Fri, Jun 19, 2020 at 11:53:41PM +0200, Sam Ravnborg wrote: > Good to have these converted. A few comments in the following. One > comment is for the backlight people as you copied the original text. ... and I've sliced out everything except that in this reply. > On Thu, Jun 18, 2020 at 04:44:1

[PATCH stable-4.19.y] Revert "dpaa_eth: fix usage as DSA master, try 3"

2020-06-22 Thread Vladimir Oltean
From: Vladimir Oltean This reverts commit b145710b69388aa4034d32b4a937f18f66b5538e. The patch is not wrong, but the Fixes: tag is. It should have been: Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") which means that it's fixing a commit which was introduced in: git describe --tag

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-22 Thread Eugenio Perez Martin
On Mon, Jun 22, 2020 at 11:07 AM Jason Wang wrote: > > > On 2020/6/20 上午2:07, Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > wrote: > >> On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > >> wrote: > >>> On Thu, Jun 11, 2020 at 07:34:19AM -0400, Mic

Re: [PATCH v3 1/2] media: tpg: Add function to return colors' order of test image

2020-06-22 Thread Hans Verkuil
On 18/06/2020 21:05, Kaaira Gupta wrote: > Currently there is no method to know the correct order of the colors for > a test image generated by tpg. Write a function that returns a string of > colors' order given a tpg. It returns a NULL pointer in case of test > patterns which do not have a well d

Re: [PATCH v2 3/6] spi: dw: Add Microchip Sparx5 support

2020-06-22 Thread Lars Povlsen
Mark Brown writes: On Fri, Jun 19, 2020 at 01:31:18PM +0200, Lars Povlsen wrote: >> +/* >> + * The Designware SPI controller (referred to as master in the >> + * documentation) automatically deasserts chip select when the tx fifo >> + * is empty. The chip selects then needs to be driven by a CS

Re: [PATCH v3] driver core: platform: expose numa_node to users in sysfs

2020-06-22 Thread John Garry
On 19/06/2020 04:00, Barry Song wrote: Some platform devices like ARM SMMU are memory-mapped and populated by ACPI/IORT. In this case, NUMA topology of those platform devices are exported by firmware as well. Software might care about the numa_node of those devices in order to achieve NUMA loc

Re: [PATCH v7 01/13] tools/libperf: introduce notion of static polled file descriptors

2020-06-22 Thread Alexey Budankov
On 22.06.2020 13:21, Jiri Olsa wrote: > On Mon, Jun 22, 2020 at 12:47:19PM +0300, Alexey Budankov wrote: > > SNIP > fdarray__del(array, fdkey); >>> >>> I think there's solution without having filterable type, >>> I'm not sure why you think this is needed >>> >>> I'm

[PATCH] mm/zswap: careful error path implementation in comp_prepare

2020-06-22 Thread Barry Song
Free the allocated memory and resource while an error occurs. Cc: Herbert Xu Cc: David S. Miller" Cc: Seth Jennings Cc: Dan Streetman Cc: Vitaly Wool Cc: Andrew Morton Signed-off-by: Barry Song --- -v1: an incremental patch againest linux-next to fix the issue pointed out by Vitaly

Congratulation!

2020-06-22 Thread Mr. Ban Ki Moon
Congratulation! Your Email Address was selected as a winner of £2000,000.00 on Euro-Mega DRAW

Re: [RFC PATCH 04/10] mfd: Add base driver for Netronix embedded controller

2020-06-22 Thread Lee Jones
On Sun, 21 Jun 2020, Jonathan Neuschäfer wrote: Description of the device here please. > Third-party hardware documentation is available at '\n' > https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-controller Indent this with a couple of spaces. > The EC supports interrupts, b

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/22/20 12:25 PM, Kurt Van Dijck wrote: > I got my board up with a 5.7, despite device-tree problems completely > unrelated to CAN. \o/ > It seems to work well with a fully-loaded CAN bus (cangen -g0 ...). > So that is a real improvement. Can I add your Tested-by? > I will need to add the li

Re: [PATCH v3 2/2] media: vimc: Add a control to display info on test image

2020-06-22 Thread Hans Verkuil
On 18/06/2020 21:05, Kaaira Gupta wrote: > Add a control in VIMC to display information such as the correct oder of odor -> order > colors for a given test pattern, brightness, hue, saturation, contrast > and, width and height at sensor over test image; and display that > information. and, width

Re: selftests: kvm: Test results on x86_64

2020-06-22 Thread Vitaly Kuznetsov
Naresh Kamboju writes: > FYI, > Linaro test farm selftests kvm test cases results. > * kvm_mmio_warning_test — SKIP > * kvm_svm_vmcall_test — SKIP > * kvm_clear_dirty_log_test — PASS > * kvm_cr4_cpuid_sync_test — PASS > * kvm_debug_regs — PASS > * kvm_demand_paging_test — PASS > * k

Re: [PATCH v1 02/11] soc: mediatek: cmdq: add assign function

2020-06-22 Thread Matthias Brugger
On 21/06/2020 16:18, Dennis YC Hsieh wrote: > Add assign function in cmdq helper which assign constant value into > internal register by index. > > Signed-off-by: Dennis YC Hsieh Applied to v5.8-next/soc Thanks > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 24 +++

[PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer

2020-06-22 Thread Krzysztof Kozlowski
During device removal, the driver should unregister the SPI controller and stop the hardware. Otherwise the dspi_transfer_one_message() could wait on completion infinitely. Additionally, calling spi_unregister_controller() first in device removal reverse-matches the probe function, where SPI cont

[PATCH v4 3/4] spi: spi-fsl-dspi: Fix external abort on interrupt in resume or exit paths

2020-06-22 Thread Krzysztof Kozlowski
If shared interrupt comes late, during probe error path or device remove (could be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler dspi_interrupt() will access registers with the clock being disabled. This leads to external abort on non-linefetch on Toradex Colibri VF50 module (with Vybri

[PATCH v4 4/4] spi: spi-fsl-dspi: Initialize completion before possible interrupt

2020-06-22 Thread Krzysztof Kozlowski
The interrupt handler calls completion and is IRQ requested before the completion is initialized. Logically it should be the other way. Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. None Changes since v1: 1. Rework the commit msg. --- drivers/spi/spi-fsl-dspi.c | 4 ++-- 1 file

[PATCH v4 2/4] spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer

2020-06-22 Thread Krzysztof Kozlowski
During shutdown, the driver should unregister the SPI controller and stop the hardware. Otherwise the dspi_transfer_one_message() could wait on completion infinitely. Additionally, calling spi_unregister_controller() first in device shutdown reverse-matches the probe function, where SPI controlle

drivers/iommu/mtk_iommu.c:438:29: warning: comparison is always false due to limited range of data type

2020-06-22 Thread kernel test robot
months ago config: i386-randconfig-r012-20200622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce (this is a W=1 build): git checkout e93a1695d7fb551376b1c1220a267d032b6ad159 # save the attached .config to linux build tree make W=1 ARCH=i386 If you

Re: linux-next build error (9)

2020-06-22 Thread Marco Elver
On Mon, 22 Jun 2020 at 11:49, Peter Zijlstra wrote: > > On Mon, Jun 22, 2020 at 02:37:12AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:27f11fea Add linux-next specific files for 20200622 > > git

Re: [PATCH v1 03/11] soc: mediatek: cmdq: add write_s function

2020-06-22 Thread Matthias Brugger
On 21/06/2020 16:18, Dennis YC Hsieh wrote: > add write_s function in cmdq helper functions which > writes value contains in internal register to address > with large dma access support. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 19 +++

Re: [PATCH 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Jonathan Cameron
On Mon, 22 Jun 2020 11:24:23 +0100 "Song Bao Hua (Barry Song)" wrote: > > -Original Message- > > From: Jonathan Cameron > > Sent: Monday, June 22, 2020 9:59 PM > > To: Song Bao Hua (Barry Song) > > Cc: herb...@gondor.apana.org.au; da...@davemloft.net; Seth Jennings > > ; Linuxarm ; > > l

[PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-22 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from amd ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling t

[PATCH v3] nbd: Fix memory leak in nbd_add_socket

2020-06-22 Thread Zheng Bin
When adding first socket to nbd, if nsock's allocation failed, the data structure member "config->socks" was reallocated, but the data structure member "config->num_connections" was not updated. A memory leak will occur then because the function "nbd_config_put" will free "config->socks" only when

Re: [PATCH v1 08/11] soc: mediatek: cmdq: export finalize function

2020-06-22 Thread Matthias Brugger
On 21/06/2020 16:18, Dennis YC Hsieh wrote: > Export finalize function to client which helps append eoc and jump > command to pkt. Let client decide call finalize or not. > > Signed-off-by: Dennis YC Hsieh > Reviewed-by: CK Hu > Acked-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_d

[PATCH net 0/9] net: qed/qede: various stability fixes

2020-06-22 Thread Alexander Lobakin
This set addresses several near-critical issues that were observed and reproduced on different test and production configurations. Alexander Lobakin (9): net: qed: fix left elements count calculation net: qed: fix async event callbacks unregistering net: qede: stop adding events on an alread

Re: [PATCH 1/3] mfd: ds1374: Introduce Dallas/Maxim DS1374 MFD core driver

2020-06-22 Thread Lee Jones
On Mon, 22 Jun 2020, Johnson CH Chen (陳昭勳) wrote: > Dallas/Maxim DS1374 is a counter designed to continuously count > time in seconds. It provides an I2C interface to the host to > access RTC clock or Alarm/Watchdog timer. > > Add MFD Core driver, supporting the I2C communication to RTC and > Wat

[PATCH net 9/9] net: qed: fix "maybe uninitialized" warning

2020-06-22 Thread Alexander Lobakin
Variable 'abs_ppfid' in qed_dev.c:qed_llh_add_mac_filter() always gets printed, but is initialized only under 'ref_cnt == 1' condition. This results in: In file included from ./include/linux/kernel.h:15:0, from ./include/asm-generic/bug.h:19, from ./arch/x86/inclu

[PATCH net 5/9] net: qed: fix excessive QM ILT lines consumption

2020-06-22 Thread Alexander Lobakin
This is likely a copy'n'paste mistake. The amount of ILT lines to reserve for a single VF was being multiplied by the total VFs count. This led to a huge redundancy in reservation and potential lines drainouts. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-off

[PATCH v2 2/3] amd8111e: Convert to generic power management

2020-06-22 Thread Vaibhav Gupta
Drivers should not save device registers and/or change the power state of the device. As per the generic PM approach, these are handled by PCI core. The driver should support dev_pm_ops callbacks and bind them to pci_driver. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/net/eth

arch/mips/sgi-ip27/ip27-hubio.c:30:15: warning: no previous prototype for 'hub_pio_map'

2020-06-22 Thread kernel test robot
stuff date: 6 months ago config: mips-randconfig-r021-20200622 (attached as .config) compiler: mips64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

[PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-22 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from amd ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling t

[PATCH v2 1/3] pcnet32: Convert to generic power management

2020-06-22 Thread Vaibhav Gupta
Remove legacy PM callbacks and use generic operations. With legacy code, drivers were responsible for handling PCI PM operations like pci_save_state(). In generic code, all these are handled by PCI core. The generic suspend() and resume() are called at the same point the legacy ones were called. T

[PATCH v2 3/3] amd-xgbe: Convert to generic power management

2020-06-22 Thread Vaibhav Gupta
Use dev_pm_ops structure to call generic suspend() and resume() callbacks. Drivers should avoid saving device register and/or change power states using PCI helper functions. With the generic approach, all these are handled by PCI core. Compile-tested only. Signed-off-by: Vaibhav Gupta --- driv

Re: [PATCH v4 2/4] spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer

2020-06-22 Thread Vladimir Oltean
On Mon, 22 Jun 2020 at 14:08, Krzysztof Kozlowski wrote: > > During shutdown, the driver should unregister the SPI controller > and stop the hardware. Otherwise the dspi_transfer_one_message() could > wait on completion infinitely. > > Additionally, calling spi_unregister_controller() first in de

Re: [PATCH v4 3/4] spi: spi-fsl-dspi: Fix external abort on interrupt in resume or exit paths

2020-06-22 Thread Vladimir Oltean
On Mon, 22 Jun 2020 at 14:07, Krzysztof Kozlowski wrote: > > If shared interrupt comes late, during probe error path or device remove > (could be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler > dspi_interrupt() will access registers with the clock being disabled. > This leads to extern

Re: [v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks

2020-06-22 Thread Markus Elfring
> > +coccilib.report.print_report(p1[0], > > +f"WARNING: array_size is used down the code (line {p2[0].line}) to compute > > the same size") > > I get python failures for all of these messages. This is interesting, isn't it? > I know nothing about python. You probably know more also about this

Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)

2020-06-22 Thread Ondřej Jirman
Hello Sam, On Mon, Jun 22, 2020 at 10:08:02AM +0200, Sam Ravnborg wrote: > On Sun, Jun 21, 2020 at 12:30:10AM +0200, Ondřej Jirman wrote: > > On Sat, Jun 20, 2020 at 11:25:29PM +0200, Sam Ravnborg wrote: > > > Hi Ondrej et al. ... > > > Would it not be better to have one st7703 driver that suipp

Re: [PATCH v1 10/11] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-06-22 Thread Matthias Brugger
On 21/06/2020 16:18, Dennis YC Hsieh wrote: > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. > > Signed-off-by: Dennis YC Hsieh > Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c |2 +- > drivers/soc/mediatek/mtk-cmdq-hel

Re: [PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer

2020-06-22 Thread Vladimir Oltean
On Mon, 22 Jun 2020 at 14:06, Krzysztof Kozlowski wrote: > > During device removal, the driver should unregister the SPI controller > and stop the hardware. Otherwise the dspi_transfer_one_message() could > wait on completion infinitely. > > Additionally, calling spi_unregister_controller() first

Re: [PATCH v1 11/11] soc: mediatek: cmdq: add set event function

2020-06-22 Thread Matthias Brugger
On 21/06/2020 16:18, Dennis YC Hsieh wrote: > Add set event function in cmdq helper functions to set specific event. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 15 +++ > include/linux/mailbox/mtk-cmdq-mailbox.h |1 + > include/linux

Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property

2020-06-22 Thread Mark Brown
On Sun, Jun 21, 2020 at 07:33:52PM -0400, Sasha Levin wrote: > On Thu, Jun 18, 2020 at 03:39:30PM +0100, Mark Brown wrote: > > On Thu, Jun 18, 2020 at 10:30:46AM -0400, Sasha Levin wrote: > > > On Thu, Jun 18, 2020 at 12:00:23PM +0100, Mark Brown wrote: > > > > This is a new feature not a bugfix.

Re: [v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks

2020-06-22 Thread Julia Lawall
> I suggest to take another look at information from the section > “2.4.3. Formatted string literals”. > https://docs.python.org/3/reference/lexical_analysis.html#f-strings > > This software documentation provides the information “New in version 3.6”. > Will such a detail trigger any more software

RE: [PATCH v3] driver core: platform: expose numa_node to users in sysfs

2020-06-22 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: John Garry > Sent: Monday, June 22, 2020 10:49 PM > To: Song Bao Hua (Barry Song) ; > gre...@linuxfoundation.org; raf...@kernel.org > Cc: Robin Murphy ; linux-kernel@vger.kernel.org; > Zengtao (B) ; Linuxarm > Subject: Re: [PATCH v3] driver core: platform: expo

[PATCH net 4/9] net: qed: fix NVMe login fails over VFs

2020-06-22 Thread Alexander Lobakin
25ms sleep cycles in waiting for PF response are excessive and may lead to different timeout failures. Start to wait with short udelays, and in most cases polling will end here. If the time was not sufficient, switch to msleeps. usleep_range() may go far beyond 100us depending on platform and tick

[PATCH net 6/9] net: qede: fix PTP initialization on recovery

2020-06-22 Thread Alexander Lobakin
Currently PTP cyclecounter and timecounter are initialized only on the first probing and are cleaned up during removal. This means that PTP becomes non-functional after device recovery. Fix this by unconditional PTP initialization on probing and clearing Tx pending bit on exiting. Fixes: ccc67ef50

Re: [PATCH 0/3] Use MFD for Dallas/Maxim DS1374 driver series

2020-06-22 Thread Alexandre Belloni
Hi, On 22/06/2020 10:03:25+, Johnson CH Chen (陳昭勳) wrote: > Hello all, > > This patch set uses MFD structure for DS1374 so that RTC and Watchdog > functions can be separately. Therefore, we can add more Watchdog > subfunctions here. > > A DS1374 MFD core driver supports the I2C communicatio

[PATCH net 8/9] net: qed: reset ILT block sizes before recomputing to fix crashes

2020-06-22 Thread Alexander Lobakin
Sizes of all ILT blocks must be reset before ILT recomputing when disabling clients, or memory allocation may exceed ILT shadow array and provoke system crashes. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kaldero

Re: [PATCH v5 6/6] arm64: dts: add dts nodes for MT6779

2020-06-22 Thread Matthias Brugger
On 16/06/2020 15:34, Hanks Chen wrote: > On Wed, 2020-03-25 at 17:39 +0100, Matthias Brugger wrote: >> >> On 25/03/2020 10:31, Hanks Chen wrote: >>> this adds initial MT6779 dts settings fo board support, >> >> "for board support" >> >>> including cpu, gic, timer, ccf, pinctrl, uart...etc. >> >>

[PATCH net 7/9] net: qede: fix use-after-free on recovery and AER handling

2020-06-22 Thread Alexander Lobakin
Set edev->cdev pointer to NULL after calling remove() callback to avoid using of already freed object. Fixes: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qede/qede_mai

[PATCH net 3/9] net: qede: stop adding events on an already destroyed workqueue

2020-06-22 Thread Alexander Lobakin
Set rdma_wq pointer to NULL after destroying the workqueue and check for it when adding new events to fix crashes on driver unload. Fixes: cee9fbd8e2e9 ("qede: Add qedr framework") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon --- drivers/net/ethe

[PATCH net 2/9] net: qed: fix async event callbacks unregistering

2020-06-22 Thread Alexander Lobakin
qed_spq_unregister_async_cb() should be called before qed_rdma_info_free() to avoid crash-spawning uses-after-free. Instead of calling it from each subsystem exit code, do it in one place on PF down. Fixes: 291d57f67d24 ("qed: Fix rdma_info structure allocation") Signed-off-by: Alexander Lobakin

[PATCH net 1/9] net: qed: fix left elements count calculation

2020-06-22 Thread Alexander Lobakin
qed_chain_get_element_left{,_u32} returned 0 when the difference between producer and consumer page count was equal to the total page count. Fix this by conditional expanding of producer value (vs unconditional). This allowed to eliminate normalizaton against total page count, which was the cause o

Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump

2020-06-22 Thread Oleg Nesterov
On 06/19, Eric W. Biederman wrote: > > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -369,7 +369,6 @@ static int zap_threads(struct task_struct *tsk, struct > mm_struct *mm, > spin_lock_irq(&tsk->sighand->siglock); > if (!signal_group_exit(tsk->signal)) { > mm->core_stat

Re: [PATCH v6 7/7] arm64: dts: add dts nodes for MT6779

2020-06-22 Thread Matthias Brugger
On 18/06/2020 13:33, Hanks Chen wrote: > this adds initial MT6779 dts settings for board support, > including cpu, gic, timer, ccf, pinctrl, uart, sysirq...etc. > > Signed-off-by: Hanks Chen > --- > arch/arm64/boot/dts/mediatek/Makefile |1 + > arch/arm64/boot/dts/mediatek/mt6779-ev

Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand

2020-06-22 Thread Oleg Nesterov
On 06/22, Dominique Martinet wrote: > > What about the possibility of sighand being null that the function does > check, is that impossible for current as well? It is only possible if "current" has already exited and passed exit_notify(), iow if it is already a zombie and can be (auto)reaped. Ole

Writing to a const pointer: is this supposed to happen?

2020-06-22 Thread Kars Mulder
In the file drivers/usb/core/quirks.c, I noticed a couple of odd things about the function "quirks_param_set", and I'd like to check whether those are ok according to the kernel programming practices. Here are the relevant lines from the function (several lines omitted): static int quir

Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand

2020-06-22 Thread Christian Brauner
On Mon, Jun 22, 2020 at 12:24:01PM +0200, Dominique Martinet wrote: > Christian Brauner wrote on Mon, Jun 22, 2020: > > On Mon, Jun 22, 2020 at 08:25:28AM +0200, Oleg Nesterov wrote: > >> current->sighand is stable and can't go away. Unless "current" is exiting > >> and > >> has already passed exi

Re: [PATCH] soundwire: bus: clock_stop: don't deal with UNATTACHED Slave devices

2020-06-22 Thread Vinod Koul
On 31-05-20, 23:18, Bard Liao wrote: > We don't need to do anything for the slave if it is unattached during > clock stop prepare and exit sequences. Applied, thanks -- ~Vinod

Re: Good idea to rename files in include/uapi/ ?

2020-06-22 Thread Jan Engelhardt
On Monday 2020-06-15 01:34, Alexander A. Klimov wrote: >> >> A header file rename is no problem. We even have dummy headers > Hmm.. if I understand all of you correctly, David, Stefano, Pablo and Al say > like no, not a good idea, but only you, Jan, say like should be no problem. > > Jan, do you

[PATCH RESEND v2] dt-bindings: pinctrl: Convert ingenic,pinctrl.txt to YAML

2020-06-22 Thread Paul Cercueil
Convert the ingenic,pinctrl.txt doc file to ingenic,pinctrl.yaml. In the process, some compatible strings now require a fallback, as the corresponding SoCs are pin-compatible with their fallback variant. Signed-off-by: Paul Cercueil --- Notes: v2: - Use 'pinctrl' instead of 'pin-controller'

Re: [PATCH] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag

2020-06-22 Thread Maulik Shah
Hi, Thanks for the review Stephen. On 6/22/2020 2:33 PM, Stephen Boyd wrote: Quoting Maulik Shah (2020-06-21 23:53:25) rpmh-rsc driver is fairly core to system and should not be removable once its probed. However it allows to unbind driver from sysfs using below command which results into a cr

[GIT PULL] regmap fixes for v5.8-rc2

2020-06-22 Thread broonie
The following changes since commit 93b929922dba3a42b0439ef13144c6032b7733c8: Merge series "regmap: provide simple bitops and use them in a driver" from Bartosz Golaszewski Bartosz Golaszewski : (2020-05-29 14:00:44 +0100) are available in the Git repository at: https://git.kernel.org/pub/

Re: [PATCH 2/2] Add Intel LGM soc DMA support.

2020-06-22 Thread Dan Carpenter
Hi Amireddy, url: https://github.com/0day-ci/linux/commits/Amireddy-Mallikarjuna-reddy/Add-Intel-LGM-soc-DMA-support/20200610-202116 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-randconfig-m021-20200621 (attached as .config) compiler: gcc-9 (Debi

[GIT PULL] regulator fixes for v5.8-rc2

2020-06-22 Thread broonie
The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git tags/regulator-fix-v5.8-rc2 for you to fetch changes up to 1b

RE: [PATCH v2] dmabuf: use spinlock to access dmabuf->name

2020-06-22 Thread Ruhl, Michael J
>-Original Message- >From: charante=codeaurora@mg.codeaurora.org > On Behalf Of Charan Teja >Kalla >Sent: Monday, June 22, 2020 5:26 AM >To: Ruhl, Michael J ; Sumit Semwal >; david.lai...@aculab.com; open list:DMA >BUFFER SHARING FRAMEWORK ; DRI mailing >list >Cc: Linaro MM SIG ; LKML

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/18/20 2:06 PM, Manivannan Sadhasivam wrote: >> https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 >> > > Tested this version on my board with MCP2518FD and it works fine. I'm okay > with > moving forward with your version and would like to contribute. Please let

[PATCH] fix annotation of io{read,write}{16,32}be()

2020-06-22 Thread Luc Van Oostenryck
These accessors must be used to read/write a big-endian bus. The value returned or written is native-endian. However, these accessors are defined using be{16,32}_to_cpu() or cpu_to_be{16,32}() to make the endian conversion but these expect a __be{16,32} when none is present. Keeping them would nee

[PATCH v1 4/5] tulip: tulip_core: use generic power management

2020-06-22 Thread Vaibhav Gupta
With the support of generic PM callbacks, drivers no longer need to use legacy .suspend() and .resume() in which they had to maintain PCI states changes and device's power state themselves. Earlier, .suspend() and .resume() were invoking pci_disable_device() and pci_enable_device() respectively to

[PATCH v1 0/5] ethernet: dec: tulip: use generic power management

2020-06-22 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks and invocation of PCI helper functions, from tulip ethernet drivers. With legacy PM, drivers themselves are responsible for handling the device's power states. And

[PATCH v1 2/5] tulip: windbond-840: use generic power management

2020-06-22 Thread Vaibhav Gupta
With stable support of generic PM callbacks, drivers no longer need to use legacy .suspend() and .resume() in which they had to maintain PCI states changes and device's power state themselves. Earlier, .resume() was invoking pci_enable_device(). Drivers should not call PCI legacy helper functions,

[PATCH v1 1/5] tulip: dmfe: use generic power management

2020-06-22 Thread Vaibhav Gupta
With legacy PM hooks, it was the responsibility of a driver to manage PCI states and also the device's power state. The generic approach is to let the PCI core handle the work. The legacy suspend() and resume() were making use of pci_read/write_config_dword() to enable/disable wol. Driver editing

[PATCH v1 3/5] tulip: de2104x: use generic power management

2020-06-22 Thread Vaibhav Gupta
With the support of generic PM callbacks, drivers no longer need to use legacy .suspend() and .resume() in which they had to maintain PCI states changes and device's power state themselves. Earlier, .suspend() and .resume() were invoking pci_disable_device() and pci_enable_device() respectively to

[PATCH v1 5/5] tulip: uli526x: use generic power management

2020-06-22 Thread Vaibhav Gupta
With the support of generic PM callbacks, drivers no longer need to use legacy .suspend() and .resume() in which they had to maintain PCI states changes and device's power state themselves. Legacy PM involves usage of PCI helper functions like pci_enable_wake() which is no longer recommended. Com

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-22 Thread Jason Gunthorpe
On Fri, Jun 19, 2020 at 04:31:47PM -0400, Jerome Glisse wrote: > Not doable as page refcount can change for things unrelated to GUP, with > John changes we can identify GUP and we could potentialy copy GUPed page > instead of COW but this can potentialy slow down fork() and i am not sure > how acce

[PATCH v2] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-22 Thread Dariusz Marcinkiewicz
Do not fail probing when device_init_wakeup fails. device_init_wakeup fails when the device is already enabled as wakeup device. Hence, the driver fails to probe the device if: - The device has already been enabled for wakeup (by e.g. sysfs) - The driver has been unloaded and is being loaded again

[PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options

2020-06-22 Thread Geliang Tang
In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop it. Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 spec") Signed-off-by: Geliang Tang --- net/mptcp/options.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mptcp/options.c b/net

Re: [PATCH 1/7] x86/entry: Fix #UD vs WARN more

2020-06-22 Thread Peter Zijlstra
On Thu, Jun 18, 2020 at 11:18:23PM +0200, Peter Zijlstra wrote: > > So maybe also do an untraced cond_local_irq_enable()? After all, if > > we’re trying to report a bug from IRQs on, it should be okay to have > > IRQs on while reporting it. It might even work better than having IRQs > > off. > >

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/18/20 10:55 AM, Manivannan Sadhasivam wrote: > So how should we proceed from here? It is okay for me to work on adding some > features and also fixing the issues you've reported so far. But I want to > reach > a consensus before moving forward. > > If you think that it makes sense to go with

[PATCH] dt-bindings: reset: Convert UniPhier reset to json-schema

2020-06-22 Thread Masahiro Yamada
Convert the UniPhier reset controller binding to DT schema format. I excluded the glue resets because their bindings are too different. Signed-off-by: Masahiro Yamada --- .../reset/socionext,uniphier-reset.yaml | 112 .../bindings/reset/uniphier-reset.txt | 121 +-

Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options

2020-06-22 Thread Matthieu Baerts
Hi Geliang, On 22/06/2020 13:45, Geliang Tang wrote: In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop Please next time try to have max 72 chars per line in your commit message ;) it. Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 sp

Re: [RESEND v2 4/4] arm64: dts: mt6359: add PMIC MT6359 related nodes

2020-06-22 Thread Wen Su
Hi Matthias, On Mon, 2020-06-22 at 12:12 +0200, Matthias Brugger wrote: > > On 22/06/2020 08:40, Wen Su wrote: > > From: "Wen Su" > > > > add PMIC MT6359 related nodes which is for MT6779 platform > > > > Signed-off-by: Wen Su > > --- > > arch/arm64/boot/dts/mediatek/mt6359.dtsi | 306 > > +

Re: [RFC PATCH] media: venus: Fix NULL pointer dereference in core selection

2020-06-22 Thread Stanimir Varbanov
Hi Doug, Thanks for the fix and sorry for the late reply. On 6/2/20 6:39 AM, Doug Anderson wrote: > Hi, > > On Mon, Jun 1, 2020 at 3:03 PM Douglas Anderson wrote: >> >> The newly-introduced function min_loaded_core() iterates over all of >> the venus instances an tries to figure out how much lo

Re: Strange problem with SCTP+IPv6

2020-06-22 Thread Xin Long
On Sun, Jun 21, 2020 at 11:56 PM Corey Minyard wrote: > > I've stumbled upon a strange problem with SCTP and IPv6. If I create an > sctp listening socket on :: and set the IPV6_V6ONLY socket option on it, > then I make a connection to it using ::1, the connection will drop after > 2.5 seconds wit

Re: [PATCH v2 0/6] soundwire: intel: transition to 3 steps initialization

2020-06-22 Thread Vinod Koul
On 01-06-20, 02:20, Bard Liao wrote: > This series is to split the original "soundwire: intel: transition to 3 > steps initialization" patch into different patches for better review. > It also address comments from Vinod. Applied all, thanks -- ~Vinod

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-22 Thread Joerg Roedel
On Mon, Jun 01, 2020 at 12:41:04PM -0500, Bjorn Helgaas wrote: > I found this [1] from Paul Menzel, which was a slowdown caused by > quirk_usb_early_handoff(). I think the real problem is individual > quirks that take a long time. > > The PCI_FIXUP_IOMMU things we're talking about should be fast,

Re: [v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks

2020-06-22 Thread Markus Elfring
>> I suggest to take another look at information from the section >> “2.4.3. Formatted string literals”. >> https://docs.python.org/3/reference/lexical_analysis.html#f-strings >> >> This software documentation provides the information “New in version 3.6”. >> Will such a detail trigger any more sof

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-22 Thread Joerg Roedel
On Thu, Jun 04, 2020 at 09:33:07PM +0800, Zhangfei Gao wrote: > +++ b/drivers/iommu/iommu.c > @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct > fwnode_handle *iommu_fwnode, >     fwspec->iommu_fwnode = iommu_fwnode; >     fwspec->ops = ops; >     dev_iommu_fwspec

Re: [PATCH -next] arch/x86: Return value from notify_die should to be checked.

2020-06-22 Thread Bo YU
On Mon, Jun 22, 2020 at 5:46 PM Peter Zijlstra wrote: > > On Mon, Jun 22, 2020 at 11:17:51AM +0200, Boris Petkov wrote: > > On June 22, 2020 10:52:23 AM GMT+02:00, Alexandre Chartre > > wrote: > > > So the appropriate change to make Coverity happy > > > > Or we can stop "fixing" the kernel in or

Re: [PATCH] soundwire: qcom: Constify static structs

2020-06-22 Thread Vinod Koul
On 10-06-20, 01:00, Rikard Falkeborn wrote: > qcom_swrm_port_ops and qcom_swrm_ops are not modified and can be made > const to allow the compiler to put them in read-only memory. > > Before: >textdata bss dec hex filename > 182663056 256 21578544a drivers/soundw

Re: DMA Engine: Transfer From Userspace

2020-06-22 Thread Thomas Ruf
> On 22 June 2020 at 06:47 Vinod Koul wrote: > > On 21-06-20, 22:36, Federico Vaga wrote: > > On Sun, Jun 21, 2020 at 12:54:57PM +0530, Vinod Koul wrote: > > > On 19-06-20, 16:31, Dave Jiang wrote: > > > > > > > > > > > > On 6/19/2020 3:47 PM, Federico Vaga wrote: > > > > > Hello, > > > > > > >

[PATCH] dt-bindings: ASoC: Convert UniPhier AIO audio system to json-schema

2020-06-22 Thread Masahiro Yamada
Convert the UniPhier AIO audio system binding to DT schema format. Signed-off-by: Masahiro Yamada --- .../sound/socionext,uniphier-aio.yaml | 73 +++ .../bindings/sound/uniphier,aio.txt | 45 2 files changed, 73 insertions(+), 45 deletions(-) crea

Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand

2020-06-22 Thread Oleg Nesterov
On 06/22, Christian Brauner wrote: > > On Mon, Jun 22, 2020 at 12:24:01PM +0200, Dominique Martinet wrote: > > Christian Brauner wrote on Mon, Jun 22, 2020: > > > On Mon, Jun 22, 2020 at 08:25:28AM +0200, Oleg Nesterov wrote: > > >> current->sighand is stable and can't go away. Unless "current" is

[PATCH] dt-bindings: ASoC: Convert UniPhier EVEA codec to json-schema

2020-06-22 Thread Masahiro Yamada
Convert the UniPhier EVEA sound codec binding to DT schema format. Signed-off-by: Masahiro Yamada --- .../sound/socionext,uniphier-evea.yaml| 62 +++ .../bindings/sound/uniphier,evea.txt | 26 2 files changed, 62 insertions(+), 26 deletions(-) create m

[PATCH v1] [media] saa7134: use generic power management

2020-06-22 Thread Vaibhav Gupta
With the support of generic PM callbacks, drivers no longer need to use legacy .suspend() and .resume() in which they had to maintain PCI states changes and device's power state themselves. The required operations are done by PCI core. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drive

Re: Good idea to rename files in include/uapi/ ?

2020-06-22 Thread Pablo Neira Ayuso
On Mon, Jun 22, 2020 at 01:37:09PM +0200, Jan Engelhardt wrote: > > On Monday 2020-06-15 01:34, Alexander A. Klimov wrote: > >> > >> A header file rename is no problem. We even have dummy headers > > Hmm.. if I understand all of you correctly, David, Stefano, Pablo and Al say > > like no, not a g

  1   2   3   4   5   6   7   8   9   10   >