Re: [PATCH] dt-bindings: input: Convert imx keypad to json-schema

2020-06-15 Thread Rob Herring
On Thu, Jun 04, 2020 at 02:43:21PM +0800, Anson Huang wrote: > Convert the i.MX KEYPAD binding to DT schema format using json-schema > > Signed-off-by: Anson Huang > --- > .../devicetree/bindings/input/imx-keypad.txt | 53 - > .../devicetree/bindings/input/imx-keypad.yaml

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Robin Murphy
On 2020-06-15 18:04, Florian Fainelli wrote: On 6/15/2020 10:00 AM, Mark Brown wrote: On Mon, Jun 15, 2020 at 09:34:58AM -0700, Florian Fainelli wrote: OK, so this has been dropped for spi/for-next right? How do we move from there? Well, I actually have it queued up for applying so unless

[PATCH v3] media: tpg: Add function to return colors' order of test image

2020-06-15 Thread Kaaira Gupta
Currently there is no method to know the correct order of the colors for a test image generated by tpg. Write a function that returns a string of colors' order given a tpg. It returns a NULL pointer in case of test patterns which do not have a well defined colors' order. Hence add a NULL check for

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Casey Schaufler
On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: > On 6/15/20 4:57 AM, Stephen Smalley wrote: > > Hi Stephen, > > Thanks for reviewing the patches. > >>> +void security_state_change(char *lsm_name, void *state, int state_len) >>> +{ >>> +   ima_lsm_state(lsm_name, state, state_len); >>> +}

Re: [PATCH v6 5/5] cpufreq: qcom: Disable fast switch when scaling DDR/L3

2020-06-15 Thread Matthias Kaehlcke
On Sat, Jun 06, 2020 at 03:03:32AM +0530, Sibi Sankar wrote: > Disable fast switch when the opp-tables required for scaling DDR/L3 > are populated. > > Signed-off-by: Sibi Sankar not sure a separate patch is needed for this, but anyway: Reviewed-by: Matthias Kaehlcke

Re: [PATCH net-next v6 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-06-15 Thread Rob Herring
On Thu, 04 Jun 2020 06:14:09 -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83869.yaml | 16 +++- > 1 file changed, 15 in

RE: RFC - kernel selftest result documentation (KTAP)

2020-06-15 Thread Bird, Tim
> -Original Message- > From: David Gow > > On Thu, Jun 11, 2020 at 2:11 AM Bird, Tim wrote: > > > > Some months ago I started work on a document to formalize how > > kselftest implements the TAP specification. However, I didn't finish > > that work. Maybe it's time to do so now. > > >

[PATCH][RFC] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-15 Thread Chen Yu
Suspend to idle was found to not work on Goldmont CPU recently. And the issue was triggered due to: 1. On Goldmont the CPU in idle can only be woken up via IPIs, not POLL mode: Commit 08e237fa56a1 ("x86/cpu: Add workaround for MONITOR instruction erratum on Goldmont based CPUs") 2. When t

Re: [PATCH net-next v6 1/4] dt-bindings: net: Add tx and rx internal delays

2020-06-15 Thread Rob Herring
On Thu, Jun 04, 2020 at 06:14:07AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the >

Re: [PATCH 4/4] arm64: dts: qcom: sm8150: Add Coresight support

2020-06-15 Thread Mathieu Poirier
On Tue, Jun 09, 2020 at 07:00:31PM +0530, Sai Prakash Ranjan wrote: > Add coresight components found on Qualcomm SM8150 SoC. > > Signed-off-by: Sai Prakash Ranjan > --- > > Depends on following coresight driver and SM8150 SMMU support: > - > https://git.linaro.org/kernel/coresight.git/commit/?

Re: [PATCH 2/2] mtd: rawnand: brcmnand: Ecc error handling on EDU transfers

2020-06-15 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Mon, 15 Jun 2020 11:11:00 -0400: > On Mon, Jun 15, 2020 at 3:19 AM Miquel Raynal > wrote: > > > > Hi Kamal, > > > > Kamal Dasu wrote on Fri, 12 Jun 2020 12:34:22 > > -0400: > > > > > On Fri, Jun 12, 2020 at 3:07 AM Miquel Raynal > > > wrote: > > > > > > > >

Re: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection

2020-06-15 Thread Miquel Raynal
On Mon, 2020-06-15 at 09:17:40 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > Instead of trying to parse CFE version string, which is customized by some > vendors, let's just check that "CFE1" was passed on argument 3. > > Signed-off-by: Álvaro Fernández Rojas > Signed-off-by: Jonas

Re: [PATCH v7 01/13] tools/libperf: introduce notion of static polled file descriptors

2020-06-15 Thread Alexey Budankov
On 09.06.2020 17:56, Jiri Olsa wrote: > On Mon, Jun 08, 2020 at 08:18:20PM +0300, Alexey Budankov wrote: > > SNIP > > > another idea is to forbid filter to screw the array > and return only remaining number, like below > > jirka > > > --- > diff --git a/tools/lib/api/fd/array.c b/tools/l

Re: [PATCH v2] mtd: set master partition panic write flag

2020-06-15 Thread Miquel Raynal
On Mon, 2020-06-15 at 15:51:34 UTC, Kamal Dasu wrote: > Check and set master panic write flag so that low level drivers > can use it to take required action to ensure oops data gets written > to assigned mtdoops device partition. > > Fixes: 9f897bfdd89f ("mtd: Add flag to indicate panic_write") >

Re: [PATCH] nandsim: Fix return code testing of ns_find_operation()

2020-06-15 Thread Miquel Raynal
On Mon, 2020-06-15 at 11:34:04 UTC, Richard Weinberger wrote: > ns_find_operation() returns 0 on success. > > Fixes: 052a7a5374bc ("mtd: rawnand: nandsim: Clean error handling") > Signed-off-by: Richard Weinberger Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixe

Re: [PATCH 2/2] cpufreq: Specify default governor on command line

2020-06-15 Thread Quentin Perret
On Monday 15 Jun 2020 at 17:55:54 (+0100), Quentin Perret wrote: > static int cpufreq_init_governor(struct cpufreq_policy *policy) > { > int ret; > @@ -2701,6 +2721,8 @@ int cpufreq_register_driver(struct cpufreq_driver > *driver_data) > > if (driver_data->setpolicy) >

RE: hv_hypercall_pg page permissios

2020-06-15 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Monday, June 15, 2020 1:35 AM > Dexuan Cui writes: > > >> From: linux-hyperv-ow...@vger.kernel.org > >> On Behalf Of Andy Lutomirski > >> Sent: Tuesday, April 7, 2020 2:01 PM > >> > On Apr 7, 2020, at 12:38 AM, Christoph Hellwig wrote: > >> > > >> > On Tue, Ap

Re: [PATCH v2] dt-bindings: usb: ti,keystone-dwc3.yaml: Improve schema

2020-06-15 Thread Rob Herring
On Fri, Jun 05, 2020 at 10:52:15AM +0300, Roger Quadros wrote: > There were some review comments after the patch was integrated. > Address those. > > Fixes: 1883a934e156 ("dt-bindings: usb: convert keystone-usb.txt to YAML") > Signed-off-by: Roger Quadros > --- > > Changelog: > v2 > - don't use

Re: net/sched/sch_fq.c:966:12: warning: stack frame size of 1400 bytes in function 'fq_dump'

2020-06-15 Thread Nick Desaulniers
On Mon, Jun 15, 2020 at 9:17 AM 'Eric Dumazet' via Clang Built Linux wrote: > > On Sun, Jun 14, 2020 at 11:26 PM kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 96144c58abe7ff767e754b5b80995f7b8846d49b > > commit:

Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-15 Thread Rob Herring
On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > This patch documents the qca8k's SGMII related properties that allow > configuration of the SGMII port. > > Signed-off-by: Jonathan McDowell > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 > 1 file changed

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Mimi Zohar
(Cc'ing John) On Mon, 2020-06-15 at 10:33 -0700, Casey Schaufler wrote: > On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: > > On 6/15/20 4:57 AM, Stephen Smalley wrote: > > > > Hi Stephen, > > > > Thanks for reviewing the patches. > > > >>> +void security_state_change(char *lsm_name, void *st

RE: RFC - kernel selftest result documentation (KTAP)

2020-06-15 Thread Bird, Tim
> -Original Message- > From: Kees Cook > Sent: Sunday, June 14, 2020 12:18 PM > To: David Gow > Cc: Vitor Massaru Iha ; KUnit Development > ; Shuah Khan > ; open list:KERNEL SELFTEST FRAMEWORK > ; Linux Kernel Mailing List > ; Brendan Higgins ; > linux-kernel-ment...@lists.linuxfound

Re: [PATCH 18/22] docs: trace: ring-buffer-design.txt: convert to ReST format

2020-06-15 Thread Joe Perches
On Mon, 2020-06-15 at 08:50 +0200, Mauro Carvalho Chehab wrote: > - Just like some media documents, this file is dual licensed > with GPL and GFDL. As right now the GFDL SPDX definition is > bogus (as it doesn't tell anything about invariant parts), > let's not use SPDX here. Let's use, inste

Re: [PATCH v4 03/12] dt-bindings: PCI: Add bindings for more Brcmstb chips

2020-06-15 Thread Rob Herring
On Fri, Jun 05, 2020 at 05:26:43PM -0400, Jim Quinlan wrote: > From: Jim Quinlan > > - Add compatible strings for three more Broadcom STB chips: 7278, 7216, > 7211 (STB version of RPi4). > - add new property 'brcm,scb-sizes' > - add new property 'resets' > - add new property 'reset-names' for 7

Re: [PATCH v4 1/2] hugetlb: use f_mode & FMODE_HUGETLBFS to identify hugetlbfs files

2020-06-15 Thread Mike Kravetz
On 6/15/20 1:24 AM, Miklos Szeredi wrote: > On Sat, Jun 13, 2020 at 8:53 AM Amir Goldstein wrote: > >>> I also looked at normal filesystem lower and hugetlbfs upper. Yes, >>> overlayfs >>> allows this. This is somewhat 'interesting' as write() is not supported in >>> hugetlbfs. Writing to fil

Re: [PATCHv2 1/6] dt-bindings: power: supply: gpio-charger: convert to yaml

2020-06-15 Thread Rob Herring
On Sat, 06 Jun 2020 00:43:58 +0200, Sebastian Reichel wrote: > Convert the gpio-charger bindings from text format to > new YAML based representation. > > Signed-off-by: Sebastian Reichel > --- > .../bindings/power/supply/gpio-charger.txt| 31 -- > .../bindings/power/supply/gpio-charg

Re: [PATCHv2 2/6] power: supply: gpio-charger: Make gpios optional

2020-06-15 Thread Rob Herring
On Sat, 06 Jun 2020 00:43:59 +0200, Sebastian Reichel wrote: > While strongly recommended, not all devices have a gpio to > detect if the charger is connected. This moves the 'gpios' > from required to optional section. > > This also modifies error handling for the GPIO a bit: We > no longer fallb

[PATCH] x86/alternatives: Add pr_fmt() to debug macros

2020-06-15 Thread Borislav Petkov
From: Borislav Petkov ... in order to have debug output prefixed with the pr_fmt text "SMP alternatives:" which allows easy grepping: $ dmesg | grep "SMP alternatives" [0.167783] SMP alternatives: alt table 8272c780, -> 8272fd6e [0.168620] SMP alternatives: feat: 3

Re: net/sched/sch_fq.c:966:12: warning: stack frame size of 1400 bytes in function 'fq_dump'

2020-06-15 Thread Eric Dumazet
On Mon, Jun 15, 2020 at 10:44 AM Nick Desaulniers wrote: > > On Mon, Jun 15, 2020 at 9:17 AM 'Eric Dumazet' via Clang Built Linux > wrote: > > > > On Sun, Jun 14, 2020 at 11:26 PM kernel test robot wrote: > > > > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g

[PATCH v2] mm: remove redundant check non_swap_entry()

2020-06-15 Thread Ralph Campbell
In zap_pte_range(), the check for non_swap_entry() and is_device_private_entry() is unnecessary since the latter is sufficient to determine if the page is a device private page. Remove the test for non_swap_entry() to simplify the code and for clarity. Signed-off-by: Ralph Campbell Reviewed-by: J

Re: [PATCH v3] f2fs: use kfree() instead of kvfree() to free superblock data

2020-06-15 Thread Jaegeuk Kim
On 06/09, Eric Biggers wrote: > On Wed, Jun 10, 2020 at 01:14:46AM +0300, Denis Efremov wrote: > > Use kfree() instead of kvfree() to free super in read_raw_super_block() > > because the memory is allocated with kzalloc() in the function. > > Use kfree() instead of kvfree() to free sbi, raw_super i

Re: [PATCHv2 3/6] power: supply: gpio-charger: add charge-current-limit feature

2020-06-15 Thread Rob Herring
On Sat, Jun 06, 2020 at 12:44:00AM +0200, Sebastian Reichel wrote: > Add new charge-current-limit feature to gpio-charger. > > Signed-off-by: Sebastian Reichel > --- > .../bindings/power/supply/gpio-charger.yaml | 31 > drivers/power/supply/gpio-charger.c | 140

Re: net/sched/sch_fq.c:966:12: warning: stack frame size of 1400 bytes in function 'fq_dump'

2020-06-15 Thread Eric Dumazet
On Mon, Jun 15, 2020 at 10:54 AM Eric Dumazet wrote: > > On Mon, Jun 15, 2020 at 10:44 AM Nick Desaulniers > wrote: > > > > On Mon, Jun 15, 2020 at 9:17 AM 'Eric Dumazet' via Clang Built Linux > > wrote: > > > > > > On Sun, Jun 14, 2020 at 11:26 PM kernel test robot wrote: > > > > > > > > tree:

Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible

2020-06-15 Thread Rob Herring
On Sat, 06 Jun 2020 16:25:04 +0530, Sivaprakash Murugesan wrote: > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan > --- > [V7] > * Addressed minor review comment from Rob > .../devicetree/bindings/cl

Re: [GIT PULL] SafeSetID LSM changes for v5.8

2020-06-15 Thread James Morris
On Mon, 15 Jun 2020, Micah Morton wrote: > On Sun, Jun 14, 2020 at 10:21 PM James Morris wrote: > > > > On Sun, 14 Jun 2020, Micah Morton wrote: > > > > > This patch was sent to the security mailing list and there were no > > > objections. > > > > Standard practice for new or modified LSM hooks

Re: [RFC v2] hwmon: add Corsair Commander Pro driver

2020-06-15 Thread Guenter Roeck
On 6/15/20 7:54 AM, Marius Zachmann wrote: [ ... ] >>> + memset(ccp->buffer, 0x00, OUT_BUFFER_SIZE); >>> + ccp->buffer[0] = CTL_SET_FAN_FPWM; >>> + ccp->buffer[1] = channel; >>> + ccp->buffer[2] = val; >> >> As it turns out (unless I am missing something), all commands have >> one, two, or

Re: [PATCH v2 5/5] drm/tegra: plane: Support 180° rotation

2020-06-15 Thread Dmitry Osipenko
15.06.2020 19:57, Ville Syrjälä пишет: > On Sun, Jun 14, 2020 at 11:01:21PM +0300, Dmitry Osipenko wrote: >> Combining horizontal and vertical reflections gives us 180 degrees of >> rotation. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/tegra/dc.c | 13 - >> 1 file c

Re: net/sched/sch_fq.c:966:12: warning: stack frame size of 1400 bytes in function 'fq_dump'

2020-06-15 Thread Nick Desaulniers
On Mon, Jun 15, 2020 at 10:59 AM 'Eric Dumazet' via Clang Built Linux wrote: > > On Mon, Jun 15, 2020 at 10:54 AM Eric Dumazet wrote: > > > > On Mon, Jun 15, 2020 at 10:44 AM Nick Desaulniers > > wrote: > > > > > > On Mon, Jun 15, 2020 at 9:17 AM 'Eric Dumazet' via Clang Built Linux > > > wrote

[tip:x86/microcode] BUILD SUCCESS c8a59a4d8e3c9e609fa915e39c3628c6dd08aeea

2020-06-15 Thread kernel test robot
allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a006-20200615 i386 randconfig-a002-20200615 i386 randconfig

Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 05:35:58AM +, Reshetova, Elena wrote: > > On Mon, Jun 15, 2020 at 10:10:08AM +0800, Xiaoming Ni wrote: > > > On 2020/6/13 2:34, Kees Cook wrote: > > > > This series was never applied[1], and was recently pointed out as > > > > missing[2]. If someone has a tree for this,

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-15 Thread Dan Carpenter
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 23c7500eea7d..c08bc7eb20bd 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1707,17 +1707,17 @@ void *krealloc(const void *p, size_t new_size, gfp_t > flags) > EXP

[PATCH] security: fix the key_permission LSM hook function type

2020-06-15 Thread Sami Tolvanen
Commit 8c0637e950d6 ("keys: Make the KEY_NEED_* perms an enum rather than a mask") changed the type of the key_permission callback functions, but didn't change the type of the hook, which trips indirect call checking with Control-Flow Integrity (CFI). This change fixes the issue by changing the hoo

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Fenghua Yu
On Mon, Jun 15, 2020 at 06:03:57PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 08:48:54AM -0700, Fenghua Yu wrote: > > Hi, Peter, > > On Mon, Jun 15, 2020 at 09:56:49AM +0200, Peter Zijlstra wrote: > > > On Fri, Jun 12, 2020 at 05:41:33PM -0700, Fenghua Yu wrote: > > > > +/* > > > > + *

Re: [RFC PATCH 1/3] Documentation/x86: Add documentation for /proc/cpuinfo feature flags

2020-06-15 Thread Borislav Petkov
On Wed, Jun 10, 2020 at 01:06:59PM -0700, Kyung Min Park wrote: > Add documentation for /proc/cpuinfo feature flags enumeration. > Document how and when x86 feature flags are used. Also discuss what > their presence or absence mean for the kernel, users, and applications. > > Suggested-by: Dave Ha

Re: [PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-15 Thread Jonathan McDowell
On Mon, Jun 15, 2020 at 11:45:16AM -0600, Rob Herring wrote: > On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > > This patch documents the qca8k's SGMII related properties that allow > > configuration of the SGMII port. > > > > Signed-off-by: Jonathan McDowell > > --- > > Doc

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Raj, Ashok
On Mon, Jun 15, 2020 at 06:03:57PM +0200, Peter Zijlstra wrote: > > I don't get why you need a rdmsr here, or why not having one would > require a TIF flag. Is that because this MSR is XSAVE/XRSTOR managed? > > > > > +*/ > > > > + rdmsrl(MSR_IA32_PASID, pasid_msr); > > > > + i

Re: [PATCH] security: fix the key_permission LSM hook function type

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 11:12:32AM -0700, Sami Tolvanen wrote: > Commit 8c0637e950d6 ("keys: Make the KEY_NEED_* perms an enum rather than > a mask") changed the type of the key_permission callback functions, but > didn't change the type of the hook, which trips indirect call checking with > Contro

Re: [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote: > Detect an opencoded expression that is used before or after > array_size()/array3_size()/struct_size() to compute the same size. > > Cc: Kees Cook > Signed-off-by: Denis Efremov Oh, very cool! How much does this find currently? -

Re: [PATCH] security: fix the key_permission LSM hook function type

2020-06-15 Thread Nick Desaulniers
On Mon, Jun 15, 2020 at 11:21 AM Kees Cook wrote: > > On Mon, Jun 15, 2020 at 11:12:32AM -0700, Sami Tolvanen wrote: > > Commit 8c0637e950d6 ("keys: Make the KEY_NEED_* perms an enum rather than > > a mask") changed the type of the key_permission callback functions, but > > didn't change the type

Re: [PATCH 29/29] docs: fs: proc.rst: convert a new chapter to ReST

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 08:47:08AM +0200, Mauro Carvalho Chehab wrote: > A new chapter was added to proc.rst. Adjust the markups > to avoid this warning: > > Documentation/filesystems/proc.rst:2194: WARNING: Inconsistent literal > block quoting. > > And to properly mark the code-blocks the

[PATCH] PCI: qcom: Disable power management for uPD720201 USB3 controller

2020-06-15 Thread Georgi Djakov
The uPD720201 USB3 host controller (connected to PCIe) on the Dragonboard 845c is often failing during suspend and resume. The following messages are seen over the console: PM: suspend entry (s2idle) Filesystems sync: 0.000 seconds Freezing user space processes ... (elapsed 0.001 seconds) do

Re: [PATCH 28/29] docs: fs: proc.rst: fix a warning due to a merge conflict

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 08:47:07AM +0200, Mauro Carvalho Chehab wrote: > Changeset 424037b77519 ("mm: smaps: Report arm64 guarded pages in smaps") > added a new parameter to a table. This causes Sphinx warnings, > because there's now an extra "-" at the wrong place: > > /devel/v4l/docs/Docum

Re: [PATCH v5 1/4] KEYS: trusted: Add generic trusted keys framework

2020-06-15 Thread Jarkko Sakkinen
On Tue, Jun 02, 2020 at 07:48:22PM +0530, Sumit Garg wrote: > diff --git a/security/keys/Kconfig b/security/keys/Kconfig > index 47c0415..22632c6 100644 > --- a/security/keys/Kconfig > +++ b/security/keys/Kconfig > @@ -72,17 +72,26 @@ config BIG_KEYS > > config TRUSTED_KEYS > tristate "TRU

Re: [RFC PATCH] seccomp: Add extensibility mechanism to read notifications

2020-06-15 Thread Kees Cook
On Sat, Jun 13, 2020 at 12:26:09AM -0700, Sargun Dhillon wrote: > This introduces an extensibility mechanism to receive seccomp > notifications. It uses read(2), as opposed to using an ioctl. The listener > must be first configured to write the notification via the > SECCOMP_IOCTL_NOTIF_CONFIG ioct

Re: [RFC] perf/core: allow ftrace for functions in kernel/event/core.c

2020-06-15 Thread Song Liu
Hi Steven, > On Jun 5, 2020, at 3:02 PM, Steven Rostedt wrote: > > On Fri, 5 Jun 2020 21:58:48 + > Song Liu wrote: > >> >> How does this work in your tests? > > I started it, but got distracted by other work. It did not crash with > the little testing I did do. I wanted to also look at

RE: [RFC PATCH 1/3] Documentation/x86: Add documentation for /proc/cpuinfo feature flags

2020-06-15 Thread Luck, Tony
> In general, this should say something along the lines that /proc/cpuinfo > shows features which the kernel supports. > > "For a full list of CPUID flags which the CPU supports, use > tools/arch/x86/tools/cpuid/cpuid" > > :-) Dave Hansen had suggested (offline) that we add a cpuid tool to the ker

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 11:12:59AM -0700, Fenghua Yu wrote: > > I don't get why you need a rdmsr here, or why not having one would > > require a TIF flag. Is that because this MSR is XSAVE/XRSTOR managed? > > My concern is TIF flags are precious (only 3 slots available). Defining > a new TIF flag

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 11:19:21AM -0700, Raj, Ashok wrote: > On Mon, Jun 15, 2020 at 06:03:57PM +0200, Peter Zijlstra wrote: > > > > I don't get why you need a rdmsr here, or why not having one would > > require a TIF flag. Is that because this MSR is XSAVE/XRSTOR managed? > > > > > > > + *

Re: [PATCH v2] fs: Do not check if there is a fsnotify watcher on pseudo inodes

2020-06-15 Thread Amir Goldstein
On Mon, Jun 15, 2020 at 8:25 PM Mel Gorman wrote: > > On Mon, Jun 15, 2020 at 07:26:38PM +0300, Amir Goldstein wrote: > > On Mon, Jun 15, 2020 at 3:14 PM Mel Gorman > > wrote: > > > > > > Changelog since v1 > > > o Updated changelog > > > > Slipped to commit message > > > > It's habit, it's the

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > This merge window has been quite the trainwreck, hasn't it? :-/ Keeps life interesting I suppose..

Re: [RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-15 Thread Matt Helsley
On Fri, Jun 12, 2020 at 04:30:35PM +0200, Peter Zijlstra wrote: > With there being multiple ways to change the ELF data, let's more > concisely track modification. > > Signed-off-by: Peter Zijlstra (Intel) Would it make sense to set the relocation section's "changed" flag in addition to the elf

Re: [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks

2020-06-15 Thread Denis Efremov
On 6/15/20 9:23 PM, Kees Cook wrote: > On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote: >> Detect an opencoded expression that is used before or after >> array_size()/array3_size()/struct_size() to compute the same size. >> >> Cc: Kees Cook >> Signed-off-by: Denis Efremov > > Oh

Re: [RFC PATCH 1/3] Documentation/x86: Add documentation for /proc/cpuinfo feature flags

2020-06-15 Thread Dave Hansen
On 6/15/20 11:31 AM, Luck, Tony wrote: >> In general, this should say something along the lines that /proc/cpuinfo >> shows features which the kernel supports. >> >> "For a full list of CPUID flags which the CPU supports, use >> tools/arch/x86/tools/cpuid/cpuid" >> >> :-) > Dave Hansen had suggeste

Re: [PATCH] lib: kunit_test_overflow: add KUnit test of check_*_overflow functions

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 01:30:42PM -0300, Vitor Massaru Iha wrote: > On Fri, 2020-06-12 at 15:36 -0700, Kees Cook wrote: > > Why drop the __initconst? > > I removed __initconst because of these warnings below, as it is used > for the kernel during the module initialization, and I do not use the >

Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length

2020-06-15 Thread Jason Gunthorpe
On Thu, Jun 04, 2020 at 03:39:02PM +0100, Colin King wrote: > From: Colin Ian King > > The assignment to resp.response_length is never read since it is being > updated again on the next statement. The assignment is redundant so > removed it. > > Addresses-Coverity: ("Unused value") > Signed-off-

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-15 Thread Waiman Long
On 6/15/20 2:07 PM, Dan Carpenter wrote: On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: diff --git a/mm/slab_common.c b/mm/slab_common.c index 23c7500eea7d..c08bc7eb20bd 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1707,17 +1707,17 @@ void *krealloc(const void *p, size_

Re: [RFC PATCH 1/3] Documentation/x86: Add documentation for /proc/cpuinfo feature flags

2020-06-15 Thread gre...@linuxfoundation.org
On Mon, Jun 15, 2020 at 06:31:50PM +, Luck, Tony wrote: > > In general, this should say something along the lines that /proc/cpuinfo > > shows features which the kernel supports. > > > > "For a full list of CPUID flags which the CPU supports, use > > tools/arch/x86/tools/cpuid/cpuid" > > > > :-

[PATCH] x86/mce: Add Skylake quirk for patrol scrub reported errors

2020-06-15 Thread Tony Luck
From: Youquan Song Skylake has a mode where the system administrator can use a BIOS setup option to request that the memory controller report uncorrected errors found by the patrol scrubber as corrected. This results in them being signalled using CMCI, which is less disruptive than a machine che

Re: [PATCH][RFC] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-15 Thread Peter Zijlstra
On Tue, Jun 16, 2020 at 01:36:11AM +0800, Chen Yu wrote: > Suspend to idle was found to not work on Goldmont CPU recently. > And the issue was triggered due to: > > 1. On Goldmont the CPU in idle can only be woken up via IPIs, >not POLL mode: >Commit 08e237fa56a1 ("x86/cpu: Add workaround

[PATCH] kcov: Unconditionally add -fno-stack-protector to compiler options

2020-06-15 Thread Marco Elver
Unconditionally add -fno-stack-protector to KCOV's compiler options, as all supported compilers support the option. This saves a compiler invocation to determine if the option is supported. Because Clang does not support -fno-conserve-stack, and -fno-stack-protector was wrapped in the same cc-opti

Re: RFC - kernel selftest result documentation (KTAP)

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 05:45:28PM +, Bird, Tim wrote: > Personally, as a human I find the space prefix a bit easier to read. > However, I think that in "normal" kernel log output it is unusual for > a line to be prefixed with a hash (#), so this might be easier to > both visually distinguish a

Re: [RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 11:34:48AM -0700, Matt Helsley wrote: > On Fri, Jun 12, 2020 at 04:30:35PM +0200, Peter Zijlstra wrote: > > With there being multiple ways to change the ELF data, let's more > > concisely track modification. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Would it make

Re: net/sched/sch_fq.c:966:12: warning: stack frame size of 1400 bytes in function 'fq_dump'

2020-06-15 Thread Eric Dumazet
On Mon, Jun 15, 2020 at 11:07 AM Nick Desaulniers wrote: > > On Mon, Jun 15, 2020 at 10:59 AM 'Eric Dumazet' via Clang Built Linux > wrote: > > > > On Mon, Jun 15, 2020 at 10:54 AM Eric Dumazet wrote: > > > > > > On Mon, Jun 15, 2020 at 10:44 AM Nick Desaulniers > > > wrote: > > > > > > > > On

Re: [PATCH 2/6] exec: simplify the compat syscall handling

2020-06-15 Thread Arnd Bergmann
On Mon, Jun 15, 2020 at 4:48 PM Brian Gerst wrote: > On Mon, Jun 15, 2020 at 10:13 AM Christoph Hellwig wrote: > > On Mon, Jun 15, 2020 at 03:31:35PM +0200, Arnd Bergmann wrote: > > > > I'd rather keep it in common code as that allows all the low-level > > exec stuff to be marked static, and avo

Re: [PATCH] security: fix the key_permission LSM hook function type

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 11:23:44AM -0700, Nick Desaulniers wrote: > On Mon, Jun 15, 2020 at 11:21 AM Kees Cook wrote: > > > > On Mon, Jun 15, 2020 at 11:12:32AM -0700, Sami Tolvanen wrote: > > > Commit 8c0637e950d6 ("keys: Make the KEY_NEED_* perms an enum rather than > > > a mask") changed the ty

Linux 5.8-rc1 BUG unable to handle page fault (snd_pcm)

2020-06-15 Thread Shuah Khan
I am seeing the following problem on my system. I haven't started debug yet. Is this a known issue? [9.791309] BUG: unable to handle page fault for address: b1e78165d000 [9.791328] #PF: supervisor write access in kernel mode [9.791330] #PF: error_code(0x000b) - reserved bit viol

RE: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-06-15 Thread Brown, Aaron F
> From: Chen Yu > Sent: Thursday, May 21, 2020 10:59 AM > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; Kok, Auke-jan H > ; Jeff Garzik > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Brown, Len ; Rafael J. Wysocki > ; Shevchenko, A

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Fenghua Yu
Hi, Peter, On Mon, Jun 15, 2020 at 08:31:16PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 11:12:59AM -0700, Fenghua Yu wrote: > > > I don't get why you need a rdmsr here, or why not having one would > > > require a TIF flag. Is that because this MSR is XSAVE/XRSTOR managed? > > > > My

Re: [PATCH 00/17] spelling.txt: /decriptors/descriptors/

2020-06-15 Thread Jason Gunthorpe
On Tue, Jun 09, 2020 at 01:45:53PM +0100, Kieran Bingham wrote: > I wouldn't normally go through spelling fixes, but I caught sight of > this typo twice, and then foolishly grepped the tree for it, and saw how > pervasive it was. > > so here I am ... fixing a typo globally... but with an addition

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-15 Thread Paul E. McKenney
On Mon, Jun 15, 2020 at 08:33:25PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 10:14:04AM -0700, Paul E. McKenney wrote: > > > This merge window has been quite the trainwreck, hasn't it? :-/ > > Keeps life interesting I suppose.. ;-) ;-) ;-)

[PATCH] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-06-15 Thread David Christensen
The driver function tg3_io_error_detected() calls napi_disable twice, without an intervening napi_enable, when the number of EEH errors exceeds eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. The function is called once with the PCI state pci_channel_io_frozen and then c

Re: [PATCH] kcov: Unconditionally add -fno-stack-protector to compiler options

2020-06-15 Thread Andrey Konovalov
On Mon, Jun 15, 2020 at 8:43 PM Marco Elver wrote: > > Unconditionally add -fno-stack-protector to KCOV's compiler options, as > all supported compilers support the option. This saves a compiler > invocation to determine if the option is supported. > > Because Clang does not support -fno-conserve-

Re: [Cocci] [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks

2020-06-15 Thread Gustavo A. R. Silva
On 6/15/20 13:35, Denis Efremov wrote: > > > On 6/15/20 9:23 PM, Kees Cook wrote: >> On Mon, Jun 15, 2020 at 01:20:45PM +0300, Denis Efremov wrote: >>> Detect an opencoded expression that is used before or after >>> array_size()/array3_size()/struct_size() to compute the same size. >>> >>> Cc:

Re: [RFT][PATCH 2/3] ACPICA: Remove unused memory mappings on interpreter exit

2020-06-15 Thread Dan Williams
On Sat, Jun 13, 2020 at 12:29 PM Rafael J. Wysocki wrote: [,,] > > While I agree that this is still somewhat suboptimal, improving this > > would require more changes in the OSL code. > > After writing the above I started to think about the extra changes needed > to improve that and I realized tha

Re: [PATCH 0/5] Improvements to spi-bcm-qspi

2020-06-15 Thread Kamal Dasu
Mark, This block is used on multiple Broadcom SoCs and would like to get comments from all who deal with iProc and have touched this file as well. Please copy : Florian Fainelli Rayagonda Kokatanur and bcm-kernel-feedback-l...@broadcom.com (maintainer:BROADCOM SPI DRIVER) Kamal On Mon, Jun 15,

Re: [PATCH] staging: gasket: core: Fix a coding style issue in gasket_core.c

2020-06-15 Thread Joe Perches
On Sun, 2020-06-14 at 21:51 +0800, Zhixu Zhao wrote: > Fix a coding alignment issue found by checkpatch.pl. Another option would be to use a temporary for gasket_dev->bar_data[bar_num] Something like: --- drivers/staging/gasket/gasket_core.c | 29 ++--- 1 file changed, 14

RE: RFC - kernel selftest result documentation (KTAP)

2020-06-15 Thread Bird, Tim
Kees, Thanks for the great feedback. See comments inline below. > -Original Message- > From: Kees Cook > > On Wed, Jun 10, 2020 at 06:11:06PM +, Bird, Tim wrote: > > The kernel test result format consists of 5 major elements, > > 4 of which are line-based: > > * the output version

Re: [PATCH v2 12/12] x86/traps: Fix up invalid PASID

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 11:55:29AM -0700, Fenghua Yu wrote: > Or do you suggest to add a random new flag in struct thread_info instead > of a TIF flag? Why thread_info? What's wrong with something simple like the below. It takes a bit from the 'strictly current' flags word. diff --git a/include

Re: [gup] 17839856fd: stress-ng.vm-splice.ops_per_sec 2158.6% improvement

2020-06-15 Thread Linus Torvalds
On Mon, Jun 15, 2020 at 12:33 AM Jann Horn wrote: > > So in summary I guess the test was just really slow up until now > because it was hitting a slowpath that you wouldn't hit during normal > usage? At least for vmsplice(), writing uninitialized pages doesn't > really make a whole lot of sense...

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Robin Murphy
On 2020-06-08 12:41, Lukas Wunner wrote: On Mon, Jun 08, 2020 at 12:11:11PM +0100, Robin Murphy wrote: And all in code that has at least one obvious inefficiency left on the table either way. Care to submit a patch to overcome that inefficiency? I'll have a quick go, but without any way to m

Re: [PATCH 0/6] sched: TTWU, IPI, and assorted stuff

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 10:21:49AM -0700, Paul E. McKenney wrote: > On Mon, Jun 15, 2020 at 06:40:48PM +0200, Peter Zijlstra wrote: > > Thanks! I've got 16*TREE03 running since this morning, so far so nothing :/ > > (FWIW that's 16/9 times overcommit, idle time fluctuates around 10%). > > My larg

Re: [PATCH 1/4] proc/bootconfig: Fix to use correct quotes for value

2020-06-15 Thread Steven Rostedt
On Sat, 13 Jun 2020 00:23:18 +0900 Masami Hiramatsu wrote: > Fix /proc/bootconfig to show the correctly choose the > double or single quotes according to the value. > > If a bootconfig value includes a double quote character, > we must use single-quotes to quote that value. > > Fixes: c1a3c3601

Re: [PATCH v6 0/2] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2020-06-15 Thread Bhupesh Sharma
Hello Catalin, Will, On Tue, Jun 2, 2020 at 10:54 AM Bhupesh Sharma wrote: > > Hello, > > On Thu, May 14, 2020 at 12:22 AM Bhupesh Sharma wrote: > > > > Apologies for the delayed update. Its been quite some time since I > > posted the last version (v5), but I have been really caught up in some >

Re: [PATCH 3/4] tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig

2020-06-15 Thread Steven Rostedt
On Sat, 13 Jun 2020 00:23:35 +0900 Masami Hiramatsu wrote: > Fix bootconfig to return 0 if succeeded to show the bootconfig > in initrd. Without this fix, "bootconfig INITRD" command > returns !0 even if the command succeeded to show the bootconfig. > > Fixes: 950313ebf79c ("tools: bootconfig: A

Re: [PATCH] printk: Make linux/printk.h self-contained

2020-06-15 Thread Steven Rostedt
On Mon, 15 Jun 2020 21:40:38 +1000 Herbert Xu wrote: > Thanks for investigating. I now realise that this was sent against > my first patch which did have this problem, which was fixed in my > second patch. Sorry for the false alarm. Which is why it is recommended that new patches start their o

[PATCH] trace/events/block.h: drop kernel-doc for dropped function parameter

2020-06-15 Thread Randy Dunlap
remove the error argument to the block_bio_complete tracepoint") Signed-off-by: Randy Dunlap Cc: Christoph Hellwig Cc: Jens Axboe --- include/trace/events/block.h |1 - 1 file changed, 1 deletion(-) --- linux-next-20200615.orig/include/trace/events/block.h +++ linux-next-2020061

Re: [PATCH 1/4] proc/bootconfig: Fix to use correct quotes for value

2020-06-15 Thread Joe Perches
On Mon, 2020-06-15 at 15:11 -0400, Steven Rostedt wrote: > On Sat, 13 Jun 2020 00:23:18 +0900 > Masami Hiramatsu wrote: [] > > diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c [] > > @@ -27,6 +27,7 @@ static int __init copy_xbc_key_value_list(char *dst, > > size_t size) > > { > > str

[PATCH] tty/serial: fix serial_core.c kernel-doc warnings

2020-06-15 Thread Randy Dunlap
by: Randy Dunlap Cc: Lukas Wunner Cc: Heiko Stuebner Cc: Greg Kroah-Hartman Cc: linux-ser...@vger.kernel.org --- drivers/tty/serial/serial_core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-next-20200615.orig/drivers/tty/serial/serial_core.c +++ linux-next-2020061

Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support

2020-06-15 Thread Mark Brown
On Mon, Jun 15, 2020 at 06:31:58PM +0100, Robin Murphy wrote: > Now that I've been inclined to go and look up the documentation, are we sure > this so-very-contentious check is even correct? From my reading of things > we're checking whether the RXR interrupt function is *enabled*, which still > s

[tip: x86/cleanups] x86/cpufeatures: Mark two free bits in word 3

2020-06-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: fbd5969d1ff2598143d6a6fbc9491a9e40ab9b82 Gitweb: https://git.kernel.org/tip/fbd5969d1ff2598143d6a6fbc9491a9e40ab9b82 Author:Borislav Petkov AuthorDate:Thu, 04 Jun 2020 12:38:39 +02:00 Comm

<    5   6   7   8   9   10   11   12   13   14   >