Re: [PATCH] mwifiex: Add support for NL80211_ATTR_MAX_AP_ASSOC_STA

2020-05-29 Thread Kalle Valo
Pali Rohár wrote: > SD8997 firmware sends TLV_TYPE_MAX_CONN with struct hw_spec_max_conn to > inform kernel about maximum number of p2p connections and stations in AP > mode. > > During initialization of SD8997 wifi chip kernel prints warning: > > mwifiex_sdio mmc0:0001:1: Unknown GET_HW_SPEC

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Patrick Williams
Hi Guenter, Thanks for the initial look at this. One question for you below... On Fri, May 29, 2020 at 10:30:16AM -0700, Guenter Roeck wrote: > On 5/29/20 5:46 AM, Manikandan Elumalai wrote: > > + /* Enable TEMP1 by default */ > > + config |= ADM1278_TEMP1_EN; > > +

Re: [PATCH for-next 1/1] null_blk: force complete for timeout request

2020-05-29 Thread Jens Axboe
On 5/29/20 11:31 AM, Dongli Zhang wrote: > The commit 7b11eab041da ("blk-mq: blk-mq: provide forced completion > method") exports new API to force a request to complete without error > injection. > > There should be no error injection when completing a request by timeout > handler. > > Otherwise,

Re: [PATCH v8 3/8] PM / EM: update callback structure and add device pointer

2020-05-29 Thread Daniel Lezcano
On 27/05/2020 11:58, Lukasz Luba wrote: > The Energy Model framework is going to support devices other that CPUs. In > order to make this happen change the callback function and add pointer to > a device as an argument. > > Update the related users to use new function and new callback from the > E

Re: [PATCH 2/2] soc: samsung: Add simple voltage coupler for Exynos5800

2020-05-29 Thread Krzysztof Kozlowski
On Fri, May 29, 2020 at 02:49:40PM +0200, Marek Szyprowski wrote: > Add custom voltage regulator coupler for Exynos5800 SoCs, which require > coupling between "vdd_arm" and "vdd_int" regulators. This coupler ensures > that coupled regulators voltage balancing is done only when clients for > each re

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: > --- a/drivers/spi/spi-bcm2835.c > +++ b/drivers/spi/spi-bcm2835.c > @@ -379,6 +379,10 @@ static irqreturn_t bcm2835_spi_interrupt(int irq, void > *dev_id) > if (bs->tx_len && cs & BCM2835_SPI_CS_DONE) > b

Re: [PATCH v6 00/16] spi: dw: Add generic DW DMA controller support

2020-05-29 Thread Andy Shevchenko
On Fri, May 29, 2020 at 08:26:42PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 06:18:32PM +0100, Mark Brown wrote: > > On Fri, 29 May 2020 16:11:49 +0300, Serge Semin wrote: > > > Baikal-T1 SoC provides a DW DMA controller to perform low-speed > > > peripherals > > > Mem-to-Dev and Dev-to-

Re: [PATCH 06/30] KVM: SVM: always update CR3 in VMCB

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: svm_load_mmu_pgd is delaying the write of GUEST_CR3 to prepare_vmcs02 Did you mean to say enter_svm_guest_mode here ? as an optimization, but this is only correct before the nested vmentry. If userspace is modifying CR3 with KVM_SET_SREGS after the VM

Re: [PATCH net-next v2] hinic: add set_channels ethtool_ops support

2020-05-29 Thread Jakub Kicinski
On Thu, 28 May 2020 18:36:33 + Luo bin wrote: > add support to change TX/RX queue number with ethtool -L > > Signed-off-by: Luo bin Luo bin, your patches continue to come with Date: header being in the past. Also suspiciously no time zone offset. Can you address this? > +static int hinic_se

Re: Question: livepatch failed for new fork() task stack unreliable

2020-05-29 Thread Josh Poimboeuf
On Fri, May 29, 2020 at 06:10:59PM +0800, Wang ShaoBo wrote: > Stack unreliable error is reported by stack_trace_save_tsk_reliable() when > trying > to insmod a hot patch for module modification, this results in frequent > failures > sometimes. We found this 'unreliable' stack is from task just f

Re: [PATCH v2 03/14] dt-bindings: PCI: Add bindings for more Brcmstb chips

2020-05-29 Thread Rob Herring
On Tue, May 26, 2020 at 03:12:42PM -0400, Jim Quinlan wrote: > From: Jim Quinlan > > - Add compatible strings for three more Broadcom STB chips: 7278, 7216, > 7211 (STB version of RPi4). > - add new property 'brcm,scb-sizes' > - add new property 'resets' > - add new property 'reset-names' > - a

Re: [fixup v2] kunit: use --build_dir=.kunit as default

2020-05-29 Thread Vitor Massaru Iha
On Thu, May 28, 2020 at 2:28 PM Shuah Khan wrote: > > On 5/26/20 6:34 PM, Vitor Massaru Iha wrote: > > To make KUnit easier to use, and to avoid overwriting object and > > .config files, the default KUnit build directory is set to .kunit > > > > Fixed up minor merge conflicts - Shuah Khan > > > >

[RESEND] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-29 Thread John Paul Adrian Glaubitz
Hi! This is my attempt of implementing a 64-bit get_user() for SH to address the build problem when CONFIG_INFINIBAND_USER_ACCESS is enabled. I have carefully looked at the existing implementations of __get_user_asm(), __put_user_asm() and the 64-bit __put_user_u64() to come up with the 64-bit

[PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-29 Thread John Paul Adrian Glaubitz
Trying to build the kernel with CONFIG_INFINIBAND_USER_ACCESS enabled fails ERROR: "__get_user_unknown" [drivers/infiniband/core/ib_uverbs.ko] undefined! with on SH since the kernel misses a 64-bit implementation of get_user(). Implement the missing 64-bit get_user() as __get_user_u64(), m

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:43 AM, Lukas Wunner wrote: > On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: >> --- a/drivers/spi/spi-bcm2835.c >> +++ b/drivers/spi/spi-bcm2835.c >> @@ -379,6 +379,10 @@ static irqreturn_t bcm2835_spi_interrupt(int irq, void >> *dev_id) >> if (bs->tx_len

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Lukas Wunner
On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: > Make sure we clear the FIFOs, stop the block, disable the clock and > release the DMA channel. To what end? Why is this change necessary? Sorry but this seems like an awfully terse commit message. Thanks, Lukas > > Signed-of

Re: [PATCH 7/8] ARM: OMAP2: Switch to use DEVICE_ATTR_RO()

2020-05-29 Thread Tony Lindgren
* Sudeep Holla [200523 17:10]: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. Acked-by: Tony Lindgren

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Mark Brown
On Fri, May 29, 2020 at 07:43:58PM +0200, Lukas Wunner wrote: > This definitely looks wrong. The check whether the interrupt is enabled > should be moved *before* the conditional calls to bcm2835_rd_fifo_blind() > and bcm2835_wr_fifo_blind(), i.e. to the top of the function. Hrm, right - I'll dr

Re: [PATCH v6 00/16] spi: dw: Add generic DW DMA controller support

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 08:43:12PM +0300, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 08:26:42PM +0300, Serge Semin wrote: > > On Fri, May 29, 2020 at 06:18:32PM +0100, Mark Brown wrote: > > > On Fri, 29 May 2020 16:11:49 +0300, Serge Semin wrote: > > > > Baikal-T1 SoC provides a DW DMA contro

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:47 AM, Lukas Wunner wrote: > On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: >> Make sure we clear the FIFOs, stop the block, disable the clock and >> release the DMA channel. > > To what end? Why is this change necessary? Sorry but this seems like > an awfully te

Re: [PATCH v2 00/14] PCI: brcmstb: enable PCIe for STB chips

2020-05-29 Thread Rob Herring
On Tue, May 26, 2020 at 03:12:39PM -0400, Jim Quinlan wrote: > v2: > Commit: "device core: Add ability to handle multiple dma offsets" > o Added helper func attach_dma_pfn_offset_map() in address.c (Chistoph) > o Helpers funcs added to __phys_to_dma() & __dma_to_phys() (Christoph) > o Added w

Re: [PATCH 1/2] dt-bindings: ASoC: renesas,rsnd: Add r8a7742 support

2020-05-29 Thread Rob Herring
On Tue, 26 May 2020 22:01:43 +0100, Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Ro

Re: [PATCH v2 09/14] device core: Add ability to handle multiple dma offsets

2020-05-29 Thread Jim Quinlan
On Fri, May 29, 2020 at 1:35 PM Rob Herring wrote: > > On Wed, May 27, 2020 at 9:43 AM Jim Quinlan > wrote: > > > > Hi Nicolas, > > > > On Wed, May 27, 2020 at 11:00 AM Nicolas Saenz Julienne > > wrote: > > > > > > Hi Jim, > > > one thing comes to mind, there is a small test suite in > > > dri

[no subject]

2020-05-29 Thread Chris Rankin
Linux https://j.mp/2XC439z Chris Rankin

Re: [GIT PULL] sh: remove sh5 support

2020-05-29 Thread Rich Felker
On Fri, May 29, 2020 at 07:30:59AM -0700, Christoph Hellwig wrote: > On Thu, May 28, 2020 at 12:14:16PM -0400, Rich Felker wrote: > > It is in active use. Please do not act on such a request. I would be > > much quicker to ack things that actually need ack if I weren't CC'd on > > hundreds of rando

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: > On 5/29/20 10:43 AM, Lukas Wunner wrote: > > On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: > >> --- a/drivers/spi/spi-bcm2835.c > >> +++ b/drivers/spi/spi-bcm2835.c > >> @@ -379,6 +379,10 @@ static irqretu

Re: [PATCH v3 1/4] dt-bindings: clk: Add Baikal-T1 CCU PLLs binding

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 01:20:53 +0300, Serge Semin wrote: > Baikal-T1 Clocks Control Unit is responsible for transformation of a > signal coming from an external oscillator into clocks of various > frequencies to propagate them then to the corresponding clocks > consumers (either individual IP-blocks

Re: linux-next: Tree for May 14 (objtool 2/2)

2020-05-29 Thread Josh Poimboeuf
On Thu, May 28, 2020 at 11:06:32PM -0700, Kees Cook wrote: > On Thu, May 28, 2020 at 10:44:04AM -0500, Josh Poimboeuf wrote: > > On Thu, May 14, 2020 at 09:04:36AM -0700, Randy Dunlap wrote: > > > On 5/14/20 4:07 AM, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Changes since 20200512: >

[RFC PATCH linux-next] Revert "net: bcmgenet: bcmgenet_hfb_add_filter() can be static

2020-05-29 Thread kbuild test robot
Fixes: 14da1510fedc ("Revert "net: bcmgenet: remove unused function in bcmgenet.c"") Signed-off-by: kbuild test robot --- bcmgenet.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/

Re: [PATCH] net: atm: Replace kmalloc with kzalloc in the error message

2020-05-29 Thread Markus Elfring
> Looking into the context (atomic!) and error message itself I would rather > drop > message completely. How do you think about to take another look at a previous update suggestion like the following? net/atm: Delete an error message for a failed memory allocation in five functions https://pat

Re: [PATCH] vfio/mdev: Fix reference count leak in add_mdev_supported_type.

2020-05-29 Thread Kirti Wankhede
On 5/28/2020 12:32 PM, Cornelia Huck wrote: On Wed, 27 May 2020 21:01:09 -0500 wu000...@umn.edu wrote: From: Qiushi Wu kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with

Re: [PATCH v2 00/14] PCI: brcmstb: enable PCIe for STB chips

2020-05-29 Thread Jim Quinlan
On Fri, May 29, 2020 at 1:49 PM Rob Herring wrote: > > On Tue, May 26, 2020 at 03:12:39PM -0400, Jim Quinlan wrote: > > v2: > > Commit: "device core: Add ability to handle multiple dma offsets" > > o Added helper func attach_dma_pfn_offset_map() in address.c (Chistoph) > > o Helpers funcs adde

Re: [PATCH v3 2/6] hwmon: (pmbus/core) Add Block WR

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > PmBus devices support Block Write-Block Read Process > Call described in SMBus specification v 2.0 with the > exception that Block writes and reads are permitted to > have up 255 data bytes instead of max 32 byt

Re: [PATCH v3 2/4] dt-bindings: clk: Add Baikal-T1 CCU Dividers binding

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 01:20:54 +0300, Serge Semin wrote: > After being gained by the CCU PLLs the signals must be transformed to > be suitable for the clock-consumers. This is done by a set of dividers > embedded into the CCU. A first block of dividers is used to create > reference clocks for AXI-bus

Re: [PATCH 06/30] KVM: SVM: always update CR3 in VMCB

2020-05-29 Thread Sean Christopherson
On Fri, May 29, 2020 at 10:41:58AM -0700, Krish Sadhukhan wrote: > > On 5/29/20 8:39 AM, Paolo Bonzini wrote: > >svm_load_mmu_pgd is delaying the write of GUEST_CR3 to prepare_vmcs02 > > Did you mean to say enter_svm_guest_mode here ? Heh, looks like Vitaly passed the s/vmcs/vmcb bug on to Paolo

Re: [PATCH V7 1/3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 11:57:42AM +0530, Akash Asthana wrote: > Convert QUP geni-se bindings to DT schema format using json-schema. > > Signed-off-by: Akash Asthana > Reviewed-by: Rob Herring > Reviewed-by: Stephen Boyd > --- > Changes in V2: > - As per Stephen's comment corrected defintion o

Re: [PATCH V7 2/3] dt-bindings: geni-se: Add interconnect binding for GENI QUP

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 11:57:43 +0530, Akash Asthana wrote: > Add documentation for the interconnect and interconnect-names properties > for the GENI QUP. > > Signed-off-by: Akash Asthana > Reviewed-by: Stephen Boyd > --- > Changes in V5: > - Add interconnect property for QUP wrapper (parent node)

Re: [PATCH V7 3/3] dt-bindings: serial: Add binding for UART pin swap

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 11:57:44 +0530, Akash Asthana wrote: > Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW. > > Signed-off-by: Akash Asthana > Reviewed-by: Stephen Boyd > --- > Changes in V7: > - As per Rob's comment, added type: boolean to properties. > > Documentation/devic

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Vijay Khemka
On 5/29/20, 5:47 AM, "Manikandan Elumalai" wrote: The adm1278 temperature sysfs attribute need it for one of the openbmc platform . This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it. Signed-off-by : Manikandan Elumala

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 10:48:11AM -0700, Florian Fainelli wrote: > On 5/29/20 10:47 AM, Lukas Wunner wrote: > > On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: > >> Make sure we clear the FIFOs, stop the block, disable the clock and > >> release the DMA channel. > > > > To what

Re: [PATCH v3 00/28] KVM: nSVM: event fixes and migration support

2020-05-29 Thread Sean Christopherson
> [PATCH v3 00/28] KVM: nSVM: event fixes and migration support You've got something funky going on with the way you generate cover letters, looks like it doesn't count patches authored by someone else. The 'v3' is also missing from the patches, though I suppose some heathens do that on purpose.

Re: [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file

2020-05-29 Thread Tony Lindgren
* Sudeep Holla [200523 17:10]: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found

Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface

2020-05-29 Thread Sebastian Reichel
Hi, On Fri, May 29, 2020 at 06:02:04PM +0200, Pavel Machek wrote: > > ping? > > Well, I thought that we maybe do not need standard LEDs on medical hardware. The discussion died and the patch was not applied :) In general IDK how worthwhile it is to use standard LED names for them. I suppose the

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:53 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:43 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm283

Re: [PATCH] spi: bcm2835: Implement shutdown callback

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:58 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:48:11AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:47 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote: Make sure we clear the FIFOs, stop the block, disable the clock and >>>

Re: [RFC] decrease tsk->signal->live before profile_task_exit

2020-05-29 Thread Eric W. Biederman
liuchao writes: > I want to dermine which thread is the last one to enter > do_exit in profile_task_exit. But when a lot of threads > exit, tsk->signal->live is not correct since it decrease > after profile_task_exit. I don't think that would be wise. Any additional code before the sanity check

Re: [PATCH] [v2] PCI: tegra: Fix runtime PM imbalance on error

2020-05-29 Thread Thierry Reding
On Thu, May 21, 2020 at 10:47:09AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Also, call pm_runtime_disable() when

[PATCH] dt-bindings: Merge gpio-usb-b-connector with usb-connector

2020-05-29 Thread Thierry Reding
From: Thierry Reding The binding for usb-connector is a superset of gpio-usb-b-connector. One major difference is that gpio-usb-b-connector requires at least one of the vbus-gpios and id-gpios properties to be specified. Merge the two bindings by adding the compatible string combination for the G

Re: [PATCH v14 1/1] perf tools: add support for libpfm4

2020-05-29 Thread Ian Rogers
On Fri, May 29, 2020 at 10:36 AM Arnaldo Carvalho de Melo wrote: > > Em Fri, May 29, 2020 at 02:23:10PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, May 29, 2020 at 10:03:51AM -0700, Ian Rogers escreveu: > > > On Tue, May 5, 2020 at 11:29 AM Ian Rogers wrote: > > > > > > > > From: Stepha

Re: [PATCH 2/2] perf build: Allow explicitely disabling the NO_SYSCALL_TABLE variable

2020-05-29 Thread Jiri Olsa
On Fri, May 29, 2020 at 12:55:52PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > This is useful to see if, on x86, the legacy libaudit still works, as it > is used in architectures that don't have the SYSCALL_TABLE logic and we > want to have it tested in 'make -C to

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-29 Thread Pavel Machek
Hi! Plus, do we need calibration matrix for magnetometer? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 05:54:48PM +0530, Sivaprakash Murugesan wrote: > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan > --- > * [V6] > re-ordered compatible string, dropped Rob's review tag for t

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-29 Thread Syed Nayyar Waris
On Sun, May 24, 2020 at 8:15 PM kbuild test robot wrote: > > Hi Syed, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on b9bbe6ed63b2b9f2c9ee5cbd0f2c946a2723f4ce] > > url: > https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_eac

Re: [PATCH V6 3/5] clk: qcom: Add DT bindings for ipq6018 apss clock controller

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 17:54:50 +0530, Sivaprakash Murugesan wrote: > Add dt-binding for ipq6018 apss clock controller > > Signed-off-by: Sivaprakash Murugesan > --- > [V6] > * Addressed review comment from Stephen > include/dt-bindings/clock/qcom,apss-ipq.h | 12 > 1 file changed, 12

Re: [PATCH 1/4] sctp: add sctp_sock_set_nodelay

2020-05-29 Thread David Teigland
On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. Ack, they look fine to me, thanks. Dave

Re: general protection fault in inet_unhash

2020-05-29 Thread Eric Dumazet
On 5/29/20 10:32 AM, Eric Dumazet wrote: > L2TP seems to use sk->sk_node to insert sockets into l2tp_ip_table, _and_ > uses l2tp_ip_prot.unhash == inet_unhash > > So if/when BPF_CGROUP_RUN_PROG_INET_SOCK(sk) returns an error and > inet_create() calls sk_common_release() > bad things happen,

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function. There are just two calls, so move it there. The last sentence sounds bit incomplete. Also, does it make sense to mention the r

Re: [PATCH V5 0/9] Enable ext4 support for per-file/directory DAX operations

2020-05-29 Thread Ira Weiny
On Fri, May 29, 2020 at 12:17:17AM -0400, Theodore Y. Ts'o wrote: > On Thu, May 28, 2020 at 10:54:41PM -0400, Theodore Y. Ts'o wrote: > > > > Thanks, applied to the ext4-dax branch. > > > > I spoke too soon. While I tried merging with the ext4.git dev branch, > a merge conflict made me look clo

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > Rob, > Could you pay attention to this patch? The patchset review procedure is > nearly over, while the DT part is only partly reviewed by you. Pretty sure I commented on this. Not sure what version, you're sending new versions too fa

Re: [PATCH 8/8] blk-mq: drain I/O when all CPUs in a hctx are offline

2020-05-29 Thread Paul E. McKenney
On Fri, May 29, 2020 at 11:53:15AM +0800, Ming Lei wrote: > Hi Paul, > > On Thu, May 28, 2020 at 08:07:28PM -0700, Paul E. McKenney wrote: > > On Fri, May 29, 2020 at 09:53:04AM +0800, Ming Lei wrote: > > > Hi Paul, > > > > > > Thanks for your response! > > > > > > On Thu, May 28, 2020 at 10:21:

Re: [PATCH v3 02/25] dt-bindings: clock: Add a binding for the RPi Firmware clocks

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 17:44:58 +0200, Maxime Ripard wrote: > The firmware running on the RPi VideoCore can be used to discover and > change the various clocks running in the BCM2711. Since devices will > need to use them through the DT, let's add a pretty simple binding. > > Cc: Michael Turquette >

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Mark Brown
On Sat, May 30, 2020 at 01:26:20AM +0800, Tzung-Bi Shih wrote: > On Fri, May 29, 2020 at 9:05 PM Mark Brown wrote: > > I thought that was normal for DMICs - is this selecting between left and > > right or something? > Not sure what is the common name but use the same context here. > MT6358 acce

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 11:03:48AM -0700, Florian Fainelli wrote: > On 5/29/20 10:53 AM, Lukas Wunner wrote: > > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: > >> On 5/29/20 10:43 AM, Lukas Wunner wrote: > >>> Finally, it would be nice if the check would be optimized away when

Re: [PATCH 0/2] x86/entry: simplify RESTORE_CR3

2020-05-29 Thread Andy Lutomirski
On Mon, May 25, 2020 at 9:35 PM Lai Jiangshan wrote: > > When I searched percpu data touched by entry code for #DB > protection[1], it seems to me RESTORE_CR3() does too much work, > this patchset simplifies it. > > Patch 1 enhances 21e944591102("x86/mm: Optimize RESTORE_CR3") for > kernel CR3. >

Re: [PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 05:49:14PM +0200, Maxime Ripard wrote: > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > bindings, especially since the registers have been shuffled around in more > register ranges. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed

Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()

2020-05-29 Thread Jarkko Sakkinen
On Fri, May 29, 2020 at 02:10:38PM +0200, Borislav Petkov wrote: > On Fri, May 15, 2020 at 03:43:59AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add vm_ops()->may_mprotect() to check additional constrains set by a > > "constraints" > > > subsystem for a mprotect() call.

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-29 Thread Martin Kepplinger
On 29.05.20 20:07, Pavel Machek wrote: > Hi! > > Plus, do we need calibration matrix for magnetometer? I guess so. It's not a calibration matrix, it's the mount matrix that tells you how the chip is placed on the PCB relative to a "natural" orientation, see https://github.com/torvalds/linux/blob/

Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

2020-05-29 Thread Jason Gunthorpe
On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer raq is being assigned twice. Fix this by removing > one of the redundant assignments. > > Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general > pointers") > Addressses-Coverity:

Re: [GIT PULL] sh: remove sh5 support

2020-05-29 Thread Christoph Hellwig
On Fri, May 29, 2020 at 01:53:38PM -0400, Rich Felker wrote: > Frustratingly, I _still_ don't have an official tree on kernel.org for > the purpose of being the canonical place for linux-next to pull from, > due to policies around pgp keys and nobody following up on signing > mine. This is all real

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > Rob, > > Could you pay attention to this patch? The patchset review procedure is > > nearly over, while the DT part is only partly reviewed by you. > > Pretty sure I com

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread Grygorii Strashko
Hi Santosh, On 12/05/2020 15:34, Grygorii Strashko wrote: Hi All, This series introduces TI K3 Multicore SoC platforms chipid module driver which provides identification support of the TI K3 SoCs (family, revision) and register this information with the SoC bus. It is available under /sys/devic

Re: [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 11:49:31AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the >

[PATCH v7] dt-bindings: spi: Convert DW SPI binding to DT schema

2020-05-29 Thread Serge Semin
Modern device tree bindings are supposed to be created as YAML-files in accordance with dt-schema. This commit replaces two DW SPI legacy bare text bindings with YAML file. As before the bindings file states that the corresponding dts node is supposed to be compatible either with generic DW APB SSI

Re: [PATCH 10/30] KVM: nSVM: extract preparation of VMCB for nested run

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: Split out filling svm->vmcb.save and svm->vmcb.control before VMRUN. Only the latter will be useful when restoring nested SVM state. This patch introduces no semantic change, so the MMU setup is still done in nested_prepare_vmcb_save. The next patch wi

Re: [PATCH] x86/resctrl: fix a NULL vs IS_ERR() static checker warning

2020-05-29 Thread Reinette Chatre
Hi Dan, On 5/29/2020 5:27 AM, Dan Carpenter wrote: > The callers don't expect *d_cdp to be set to an error pointer, they only > check for NULL. This leads to a static checker warning: > > arch/x86/kernel/cpu/resctrl/rdtgroup.c:2648 __init_one_rdt_domain() > warn: 'd_cdp' could be an erro

Re: [PATCH][next] IB/hfi1: fix spelling mistake "enought" -> "enough"

2020-05-29 Thread Jason Gunthorpe
On Thu, May 28, 2020 at 12:07:09PM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in an error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hfi1/chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-ne

Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()

2020-05-29 Thread Dave Hansen
On 5/14/20 5:43 PM, Jarkko Sakkinen wrote: > From: Sean Christopherson > > Add vm_ops()->may_mprotect() to check additional constrains set by a > subsystem for a mprotect() call. This changelog needs some more detail about why this is needed. It would also be nice to include thought about what

Re: [PATCH] x86/uaccess: Remove redundant likely/unlikely annotations

2020-05-29 Thread Randy Dunlap
On 5/29/20 10:25 AM, Josh Poimboeuf wrote: > On Fri, May 29, 2020 at 06:54:19PM +0200, Peter Zijlstra wrote: >> On Fri, May 29, 2020 at 11:50:11AM -0500, Josh Poimboeuf wrote: >>> The nested likelys seem like overkill anyway -- user_access_begin() is >>> __always_inline and it already has unlikely(

Re: [PATCH V2 0/4] x86/entry: simply stack switching when exception on userspace

2020-05-29 Thread Andy Lutomirski
On Fri, May 29, 2020 at 1:26 AM Lai Jiangshan wrote: > > 7f2590a110b8("x86/entry/64: Use a per-CPU trampoline stack for IDT entries") > has resulted that when exception on userspace, the kernel (error_entry) > always push the pt_regs to entry stack(sp0), and then copy them to the > kernel stack. >

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 8:22 PM Grygorii Strashko wrote: > On 12/05/2020 15:34, Grygorii Strashko wrote: > > .../bindings/soc/ti/k3-socinfo.yaml | 40 + > > drivers/soc/ti/Kconfig| 10 ++ > > drivers/soc/ti/Makefile | 1 + > > d

Re: [PATCH v3 3/6] hwmon: pmbus: adm1266: Add support for GPIOs

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Adm1266 exposes 9 GPIOs and 16 PDIOs which are currently read-only. They > are controlled by the internal sequencing engine. > > This patch makes adm1266 driver expose GPIOs and PDIOs to user-space > using GPIO

Re: [PATCH] RDMA/core: Fix several reference count leaks.

2020-05-29 Thread Jason Gunthorpe
On Wed, May 27, 2020 at 10:02:30PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. Previous > commit "b8e

Re: [PATCH -tip v3 05/11] kcsan: Remove 'noinline' from __no_kcsan_or_inline

2020-05-29 Thread Marco Elver
On Fri, 29 May 2020 at 19:08, Peter Zijlstra wrote: [...] > > Doesn't this mean we can do the below? If nobody complains about the lack of __no_kcsan_or_inline, let's do it. See comments below. > --- > Documentation/dev-tools/kcsan.rst | 6 -- > arch/x86/include/asm/bitops.h | 6 +

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-29 Thread Andy Shevchenko
On Fri, May 29, 2020 at 11:38:18PM +0530, Syed Nayyar Waris wrote: > On Sun, May 24, 2020 at 8:15 PM kbuild test robot wrote: ... > >579 static inline unsigned long bitmap_get_value(const unsigned long > > *map, > >580unsigned long start,

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Andy Shevchenko
On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > you're sending > > new versions too fast. Give people time to review. > > Yeah, you did. Sorry for send

Re: [PATCH v3 4/6] hwmon: pmbus: adm1266: add debugfs attr for states

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Add debugfs files for go_command and read_state. > > Signed-off-by: Alexandru Tachici > --- > drivers/hwmon/pmbus/adm1266.c | 47 +++ > 1 file changed, 47 insertions(+) > > di

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 09:42:01PM +0300, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > > On Wed, May 27, 2020 at 06:33:51PM +0300, Serge Semin wrote: > > > > you're sending > > > new vers

Re: [PATCH v3 5/6] hwmon: pmbus: adm1266: read blackbox

2020-05-29 Thread Guenter Roeck
On 5/29/20 6:05 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Use the nvmem kernel api to expose the black box > chip functionality to userspace. > This needs to be split into two functions: Add nvmem support, add debugfs file. Guenter > Signed-off-by: Alexandru Tachic

Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD

2020-05-29 Thread Sargun Dhillon
On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote: > On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote: > > + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0); > > + > > + nextid = req.id + 1; > > + > > + /* Wait for getppid to be called for the second time

RE: [EXTERNAL] Re: [PATCH v4] perf inject --jit: Remove //anon mmap events

2020-05-29 Thread Steve MacLean
> I've been trying variants of: > > Before: >/tmp/perf/perf record -k 1 -e cycles:u -o /tmp/perf.data java >-agentpath:/tmp/perf/libperf-jvmti.so -XX:+PreserveFramePointer >-XX:InitialCodeCacheSize=20M -XX:ReservedCodeCacheSize=1G -jar >dacapo-9.12-bach.jar jython /tmp/perf/perf inject -i /tmp/p

[PATCH] powerpc/32s: Fix another build failure with CONFIG_PPC_KUAP_DEBUG

2020-05-29 Thread Christophe Leroy
From: Christophe Leroy 'thread' doesn't exist in kuap_check() macro. Use 'current' instead. Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") Signed-off-by: Christophe Leroy Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- arch/powerpc/include/a

Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message

2020-05-29 Thread Markus Elfring
> Please just remove the message instead, it's a tiny allocation that's > unlikely to ever fail, and the caller will print an error anyway. How do you think about to take another look at a previous update suggestion like the following? powerpc/nvram: Delete three error messages for a failed memor

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Guenter Roeck
On 5/29/20 10:42 AM, Patrick Williams wrote: > Hi Guenter, > > Thanks for the initial look at this. > > One question for you below... > > On Fri, May 29, 2020 at 10:30:16AM -0700, Guenter Roeck wrote: >> On 5/29/20 5:46 AM, Manikandan Elumalai wrote: >>> + /* Enable TEMP1 by default */

Re: [PATCH] powerpc/32s: Fix another build failure with CONFIG_PPC_KUAP_DEBUG

2020-05-29 Thread Christophe Leroy
Le 29/05/2020 à 20:50, Christophe Leroy a écrit : From: Christophe Leroy 'thread' doesn't exist in kuap_check() macro. Use 'current' instead. Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") Signed-off-by: Christophe Leroy Argh, can you drop this line ?

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Guenter Roeck
On 5/29/20 10:57 AM, Vijay Khemka wrote: > > > On 5/29/20, 5:47 AM, "Manikandan Elumalai" > wrote: > > The adm1278 temperature sysfs attribute need it for one of the openbmc > platform . > This functionality is not enabled by default, so PMON_CONFIG needs to be > modified in order

Re: [PATCH v8 0/8] powerpc: switch VDSO to C implementation

2020-05-29 Thread Christophe Leroy
Hi Michael, Le 28/04/2020 à 15:16, Christophe Leroy a écrit : This is the seventh version of a series to switch powerpc VDSO to generic C implementation. Main changes since v7 are: - Added gettime64 on PPC32 This series applies on today's powerpc/merge branch. See the last patches for details

[git pull] IOMMU Fixes for Linux v5.7-rc7

2020-05-29 Thread Joerg Roedel
Hi Linus, The following changes since commit 9cb1fd0efd195590b828b9b865421ad345a4a145: Linux 5.7-rc7 (2020-05-24 15:32:54 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v5.7-rc7 for you to fetch changes up to 7c

Re: [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example

2020-05-29 Thread Serge Semin
On Fri, May 29, 2020 at 09:45:37PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 09:42:01PM +0300, Andy Shevchenko wrote: > > On Fri, May 29, 2020 at 09:22:56PM +0300, Serge Semin wrote: > > > On Fri, May 29, 2020 at 12:13:38PM -0600, Rob Herring wrote: > > > > On Wed, May 27, 2020 at 06:33:5

Re: [PATCH -tip v3 05/11] kcsan: Remove 'noinline' from __no_kcsan_or_inline

2020-05-29 Thread Peter Zijlstra
On Fri, May 29, 2020 at 08:36:56PM +0200, Marco Elver wrote: > > +/* Section for code which can't be instrumented at all */ > > +#define noinstr > > \ > > + noinline notrace __attribute((__section__(".noinstr.text"))) > > __no_

[PATCH v2 0/2] fix missing handling of __user in nommu's uaccess()

2020-05-29 Thread Luc Van Oostenryck
I received a bug report for an unrelated patch when used with m68k-nommu. It appears that the origin of the problem is that __get_user() and __put_user() doesn't handle correctly __user. These 2 patches fix this. Note: this is only minimaly tested but is quite straightforward and since this

<    4   5   6   7   8   9   10   11   12   13   >