[PATCH 51/91] perf evsel: Rename perf_evsel__find_pmu() to evsel__find_pmu()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/auxtrace.c | 2 +- tools/perf/util/evsel.

[PATCH 74/91] perf evsel: Rename perf_evsel__group_idx() to evsel__group_idx()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c | 3 +-- tools/perf/buil

[PATCH 64/91] perf doc: Pass ASCIIDOC_EXTRA as an argument

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Ian Rogers commit e9cfa47e687d ("perf doc: allow ASCIIDOC_EXTRA to be an argument") allowed ASCIIDOC_EXTRA to be passed as an option to the Documentation Makefile. This change passes ASCIIDOC_EXTRA, set by detected features or command line options, prior to doing a Documentation build. This

[PATCH 80/91] perf sched: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-sched.c | 17 - 1

[PATCH 84/91] perf inject: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-inject.c | 5 ++--- 1 file changed

[PATCH 71/91] perf evsel: Rename perf_evsel__{prev,next}() to evsel__{prev,next}()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those are 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/evsel-roundtrip-name.c | 2 +- tools

[PATCH 73/91] perf evsel: Rename perf_evsel__fallback() to evsel__fallback()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-st

[PATCH 79/91] perf lock: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-lock.c | 20

[PATCH 81/91] perf script: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-script.c | 53 +---

[PATCH 75/91] perf evsel: Rename perf_evsel__env() to evsel__env()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 2 +- tools/perf/util/annota

[PATCH 77/91] perf stat: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 11 +-- 1 file ch

[PATCH 66/91] perf pmu: Add perf_pmu__find_by_type helper

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Stephane Eranian This is used by libpfm4 during event parsing to locate the pmu for an event. Signed-off-by: Stephane Eranian Reviewed-by: Ian Rogers Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Alexey Budankov Cc: Andi Kleen Cc: Andrii Na

[PATCH 83/91] perf annotate: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-annotate.c | 10 -- 1 file

[PATCH 86/91] perf: cs-etm: Update to build with latest opencsd version.

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Mike Leach OpenCSD version v0.14.0 adds in a new output element. This is represented by a new value in the generic element type enum, which must be added to the handling code in perf cs-etm-decoder to prevent build errors due to build options on the perf project. This element is not curren

[PATCH 70/91] perf evsel: Rename perf_evsel__parse_sample*() to evsel__parse_sample*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As these are 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/x86/tests/perf-time-to-tsc.c | 6 ++---

[PATCH 90/91] perf cs-etm: Move definition of 'traceid_list' global variable from header file

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Leo Yan The variable 'traceid_list' is defined in the header file cs-etm.h, if multiple C files include cs-etm.h the compiler might complaint for multiple definition of 'traceid_list'. To fix multiple definition error, move the definition of 'traceid_list' into cs-etm.c. Fixes: cd8bfd8c97

[PATCH 88/91] libsymbols kallsyms: Parse using io api

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Ian Rogers 'perf record' will call kallsyms__parse 4 times during startup and process megabytes of data. This changes kallsyms__parse to use the io library rather than fgets to improve performance of the user code by over 8%. Before: Running 'internals/kallsyms-parse' benchmark: Avera

[PATCH 87/91] perf bench: Add kallsyms parsing

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Ian Rogers Add a benchmark for kallsyms parsing. Example output: Running 'internals/kallsyms-parse' benchmark: Average kallsyms__parse took: 103.971 ms (+- 0.121 ms) Committer testing: Test Machine: AMD Ryzen 5 3600X 6-Core Processor [root@five ~]# perf bench internals kallsyms-pa

[PATCH 67/91] perf evsel: Rename perf_evsel__is_*() to evsel__is*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those are 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-annotate.c | 3 +-- tool

[PATCH 89/91] libsymbols kallsyms: Move hex2u64 out of header

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Ian Rogers hex2u64 is a helper that's out of place in kallsyms.h as not being kallsyms related. Move from kallsyms.h to the only user. Committer notes: Move it out of tools/lib/symbol/kallsyms.c as well, as we had to leave it there in the previous patch lest we break the build. Signed-of

[PATCH 78/91] perf kmem: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-kmem.c | 33 ++

[PATCH 91/91] perf flamegraph: Use /bin/bash for report and record scripts

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As all the other tools/perf/scripts/python/bin/*-{report,record} scripts, fixing the this problem reported by Daniel Diaz: Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_q

Re: Please can I have a stable KCSAN branch for 5.8?

2020-05-06 Thread Marco Elver
On Wed, 6 May 2020 at 16:41, Will Deacon wrote: > > Hi Paul, > > Cheers for the quick reply! > > On Wed, May 06, 2020 at 07:36:16AM -0700, Paul E. McKenney wrote: > > On Wed, May 06, 2020 at 02:28:17PM +0100, Will Deacon wrote: > > > I'm looking to rebase my READ_ONCE() series [1] on top of the KC

[PATCH 82/91] perf trace: Rename perf_evsel__*() operating on 'struct evsel *' to evsel__*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those is a 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 54 ++---

[PATCH 85/91] perf symbol: Fix kernel symbol address display

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Running commands ./perf record -e rb -- find . ./perf report -v reveals symbol names and its addresses. There is a mismatch between kernel symbol and address. Here is an example for kernel symbol check_chain_key: 3.55% find /lib/modules/.../build/vmlinux 0xf11

[PATCH 76/91] perf evsel: Rename perf_evsel__store_ids() to evsel__store_id()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 2 +- tools/perf/util/evsel.c

[PATCH 72/91] perf evsel: Rename perf_evsel__has*() to evsel__has*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those are 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.c | 2 +- tools/perf/util/evse

[PATCH 55/91] perf evsel: Rename perf_evsel__calc_id_pos() to evsel__calc_id_pos()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evlist.c | 2 +- tools/perf/util/evsel.c

[PATCH 69/91] perf evsel: Rename *perf_evsel__read*() to *evsel__read()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those are 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 4 ++--

[PATCH 65/91] tools feature: Add support for detecting libpfm4

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Stephane Eranian libpfm4 provides an alternate command line encoding of perf events. Signed-off-by: Stephane Eranian Reviewed-by: Ian Rogers Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Alexey Budankov Cc: Andi Kleen Cc: Andrii Nakryiko C

[PATCH 56/91] perf evsel: Rename __perf_evsel__sample_size() to __evsel__sample_size()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' related method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/sample-parsing.c | 2 +- tools/p

[PATCH 57/91] perf evsel: Rename *perf_evsel__*name() to *evsel__*name()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As they are 'struct evsel' methods or related routines, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/arm/util/cs-etm.c

[PATCH 68/91] perf evsel: Ditch perf_evsel__cmp(), not used for quite a while

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo In 4c358d5cf361 ("perf stat: Replace transaction event possition check with id check") all its uses were removed, so ditch it. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.h | 6 -- 1 fi

[PATCH 61/91] perf evsel: Rename perf_evsel__open_per_*() to evsel__open_per_*()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As those are not 'struct evsel' methods, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/event-times.c| 8 to

Re: [PATCH v2 7/7] serial: 8250_dw: add em485 support

2020-05-06 Thread Andy Shevchenko
On Thu, Mar 26, 2020 at 1:17 AM Heiko Stuebner wrote: If it's not covered by either yours or Lukas' series, perhaps worth to address as well. .../8250_port.c:1427: warning: Function parameter or member 'p ' not described in 'serial8250_em485_stop_tx' .../8250_port.c:1427: warning: Excess functio

[PATCH 63/91] perf mem2node: Avoid double free related to realloc

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Ian Rogers Realloc of size zero is a free not an error, avoid this causing a double free. Caught by clang's address sanitizer: ==2634==ERROR: AddressSanitizer: attempting double-free on 0x602015f0 in thread T0: #0 0x5649659297fd in free llvm/llvm-project/compiler-rt/lib/asan/asan

[PATCH 46/91] perf intel-pt: Update documentation about itrace G and L options

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Provide a little more information about the new G and L options, particularly the issue with large PEBs. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lore.kernel.org/lkml/20200429150751.12570-9-adrian.hun...@intel.com Signed-off-by: Arnaldo Carval

[PATCH 38/91] perf tools: Simplify checking if SMT is active.

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Konstantin Khlebnikov SMT now could be disabled via "/sys/devices/system/cpu/smt/control". Status is shown in "/sys/devices/system/cpu/smt/active" simply as "0" / "1". If this knob isn't here then fallback to checking topology as before. Signed-off-by: Konstantin Khlebnikov Cc: Andi Kle

[PATCH 52/91] perf evsel: Rename perf_evsel__is_aux_event() to evsel__is_aux_event()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo As it is a 'struct evsel' method, not part of tools/lib/perf/, aka libperf, to whom the perf_ prefix belongs. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/auxtrace.c | 6 +++--- tools/perf/util/ev

[PATCH 1/2] module: allow arch overrides for .init section names

2020-05-06 Thread Vincent Whitchurch
ARM stores unwind information for .init.text in sections named .ARM.extab.init.text and .ARM.exidx.init.text. Since those aren't currently recognized as init sections, they're allocated along with the core section, and relocation fails if the core and the init section are allocated from different

[PATCH 30/91] perf record: Introduce --switch-output-event

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now we can use it with --overwrite to have a flight recorder mode that gets snapshot requests from arbitrary events that are processed in the side band thread together with the PERF_RECORD_BPF_EVENT processing. Example: To collect scheduler events until a recvmmsg

[PATCH 44/91] perf thread-stack: Add thread_stack__br_sample_late()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add a thread stack function to create a branch stack for hardware events where the sample records get created some time after the event occurred. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lore.kernel.org/lkml/20200429150751.12570-7-adrian.hun..

[PATCH 26/91] perf parse-events: Add parse_events_option() variant that creates evlist

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the upcoming --switch-output-event option we want to create the side band event, populate it with the specified events and then, if it is present multiple times, go on adding to it, then, if the BPF tracking is required, use the first event to set its attr.bpf_e

[PATCH 29/91] libsubcmd: Introduce OPT_CALLBACK_SET()

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To register that an option was set, like with the upcoming 'perf record --switch-output-option' one. Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Namhyung Kim Cc: Song Liu Link: http://lore.kernel.org/lkml/20200429131106.27974-7-a...@kernel.org Signed-off-by: Arna

[PATCH 41/91] perf intel-pt: Change branch stack support to use thread-stacks

2020-05-06 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Change Intel PT's branch stack support to use thread stacks. The advantages of using branch stack support from the thread-stack are: 1. the branches are accumulated separately for each thread 2. the branch stack is cleared only in between continuous traces This helps pave th

Re: [PATCH] media: usb: ttusb-dec: avoid buffer overflow in ttusb_dec_handle_irq() when DMA failures/attacks occur

2020-05-06 Thread Jia-Ju Bai
On 2020/5/6 19:07, Greg KH wrote: On Wed, May 06, 2020 at 06:13:01PM +0800, Jia-Ju Bai wrote: I have never modified DMA memory in the real world, but an attacker can use a malicious device to do this. There is a video that shows how to use the Inception tool to perform DMA attacks and login i

Re: [PATCH 6/7] exec: Move most of setup_new_exec into flush_old_exec

2020-05-06 Thread Kees Cook
On Wed, May 06, 2020 at 09:57:10AM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > > On Tue, May 05, 2020 at 02:45:33PM -0500, Eric W. Biederman wrote: > >> > >> The current idiom for the callers is: > >> > >> flush_old_exec(bprm); > >> set_personality(...); > >> setup_new_exec(bprm); >

Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()

2020-05-06 Thread Markus Elfring
> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' > call. Is there a need to prevent similar function calls by the means of advanced source code analysis? Regards, Markus

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 12:22:58PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 5:45 AM Nathan Chancellor > wrote: > > On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > > > On Tue, 5 May 2020 15:25:56 +0100 Mark Rutland > > > wrote: > > > > On Tue, May 05, 2020 at 04:12:36P

Re: [patch V4 part 1 13/36] x86/kvm: Restrict ASYNC_PF to user space

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: The async page fault injection into kernel space creates more problems than it solves. The host has absolutely no knowledge about the state of the guest if the fault happens in CPL0. The only restriction for the host is interrupt disabled state. If inte

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 02:37:19PM +0200, Alexandre Chartre wrote: > On 5/5/20 3:16 PM, Thomas Gleixner wrote: > > @@ -650,6 +655,16 @@ static inline bool got_nohz_idle_kick(vo > > return false; > > } > > +static void nohz_csd_func(void *info) > > +{ > > + struct rq *rq = info; > > + > > +

Re: [PATCH v2 5/5] [media] mtk-mdp: Remove mtk_mdp_comp.id and supporting functionality

2020-05-06 Thread Enric Balletbo Serra
Hi Eizan, Thank you for the patch. Two trivial comments Missatge de Eizan Miyamoto del dia dc., 6 de maig 2020 a les 7:51: > > Since components are registered in a list, the numeric component id that > specified a location in an array is not necessary. > > Signed-off-by: ei...@chromium.org ditt

Re: [PATCH] securityfs: Add missing d_delete() call on removal

2020-05-06 Thread Kees Cook
On Wed, May 06, 2020 at 05:02:52AM +0100, Al Viro wrote: > On Tue, May 05, 2020 at 08:28:33PM -0700, Kees Cook wrote: > > On Wed, May 06, 2020 at 02:14:31AM +0100, Al Viro wrote: > > > On Tue, May 05, 2020 at 04:40:35PM -0700, Kees Cook wrote: > > > > After using simple_unlink(), a call to d_delete

Re: [PATCH] leds: lm355x: avoid enum conversion warning

2020-05-06 Thread Nathan Chancellor
On Wed, May 06, 2020 at 04:19:45PM +0200, Arnd Bergmann wrote: > On Wed, May 6, 2020 at 4:44 AM Nathan Chancellor > wrote: > > > > On Tue, May 05, 2020 at 04:19:17PM +0200, Arnd Bergmann wrote: > > > clang points out that doing arithmetic between diffent enums is usually > >

Re: [patch V4 part 1 05/36] x86/entry: Flip _TIF_SIGPENDING and _TIF_NOTIFY_RESUME handling

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 01:53:36PM +0200, Miroslav Benes wrote: > On Tue, 5 May 2020, Thomas Gleixner wrote: > > > Make sure task_work runs before any kind of userspace -- very much > > including signals -- is invoked. > > I might be missing something, but isn't this guaranteed by > do_signal()-

Re: [PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

2020-05-06 Thread Logan Gunthorpe
On 2020-05-05 10:21 p.m., Sanjay R Mehta wrote: > v3: > - Increased ntb_perf command re-try sleep time > - avoid false dma unmap of dst address. > > v2: Incorporated improvements suggested by Logan Gunthorpe > > Links of the review comments for v3: > 1. https://lkml.org/lkml/2020/3/11/981 > 2

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread J. Bruce Fields
On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > It's not the end of the world but a bit hacky. I wonder whether something > > like the following would work better for identifying worker type so that you > > can do sth

Re: [RFC PATCH] PCI: dwc: add support for Allwinner SoCs' PCIe controller

2020-05-06 Thread Maxime Ripard
On Mon, Apr 20, 2020 at 04:18:58PM +0800, Icenowy Zheng wrote: > 在 2020-04-06星期一的 10:27 +0200,Maxime Ripard写道: > > Hi, > > > > On Fri, Apr 03, 2020 at 12:05:49AM +0800, Icenowy Zheng wrote: > > > The Allwinner H6 SoC uses DesignWare's PCIe controller to provide a > > > PCIe > > > host. > > > > >

Re: [patch V4 part 1 06/36] compiler: Simple READ/WRITE_ONCE() implementations

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 02:33:33PM +0100, Will Deacon wrote: > On Tue, May 05, 2020 at 03:16:08PM +0200, Thomas Gleixner wrote: > > READ/WRITE_ONCE_NOCHECK() is required for atomics in code which cannot be > > instrumented like the x86 int3 text poke code. As READ/WRITE_ONCE() is > > undergoing a r

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread Tejun Heo
Hello, Bruce. On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > It's not the end of the world but a bit hacky. I wonder whether something > > > lik

Re: [patch V4 part 1 14/36] x86/entry: Get rid of ist_begin/end_non_atomic()

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: This is completely overengineered and definitely not an interface which should be made available to anything else than this particular MCE case. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/traps.h |2 -- arch/x86/kernel/cpu/mce/co

Re: [patch V4 part 1 15/36] kprobes: Lock kprobe_mutex while showing kprobe_blacklist

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Lock kprobe_mutex while showing kprobe_blacklist to prevent updating the kprobe_blacklist. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/158523417665.24735.1025319887853563560

Re: [PATCH] phy: tegra: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Dmitry Osipenko
06.05.2020 14:47, Vidya Sagar пишет: > Thanks for pushing this change. > I'm fine with this change as it is attempting to change only the last > occurrence of the (IS_ERR(...)) + PTR_ERR combination. > But, this code was initially written with PTR_ERR_OR_ZERO() itself but > later changed to use (IS

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Amol Grover
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/ > > Never been picked up for a

[net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

2020-05-06 Thread Murali Karicheri
Fix following sparse checker warning:- net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) net/hsr/hsr_slave.c:38:18:expected unsigned short [unsigned] [usertype] protocol net/hsr/hsr_slave.c:38:18:got restricted __be16 [usertype] h_proto net/hsr/hsr_s

[RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function

2020-05-06 Thread Niklas Schnelle
currently pci_iov_add_virtfn() scans the SR-IOV bars, adds the VF to the bus and also creates the sysfs links between the newly added VF and its parent PF. With pdev->no_vf_scan fencing off the entire pci_iov_add_virtfn() call s390 as the sole pdev->no_vf_scan user thus ends up missing these sysfs

Re: [PATCH v5 0/6] Add support for O_MAYEXEC

2020-05-06 Thread Aleksa Sarai
On 2020-05-06, Lev R. Oshvang . wrote: > On Tue, May 5, 2020 at 6:36 PM Mickaël Salaün wrote: > > > > > > On 05/05/2020 17:31, Mickaël Salaün wrote: > > > Hi, > > > > > > This fifth patch series add new kernel configurations (OMAYEXEC_STATIC, > > > OMAYEXEC_ENFORCE_MOUNT, and OMAYEXEC_ENFORCE_FIL

[RFC 2/2] s390/pci: create links between PFs and VFs

2020-05-06 Thread Niklas Schnelle
On s390 PCI Virtual Functions (VFs) are scanned by firmware and are made available to Linux via the hot-plug interface. As such the common code path of doing the scan directly using the parent Physical Function (PF) is not used and fenced off with the no_vf_scan attribute. Even if the partition cr

[RFC 0/2] Enable PF-VF linking with pdev->no_vf_scan (s390)

2020-05-06 Thread Niklas Schnelle
Hello Kernel Hackers, the following series enables PF-VF linking for architectures using the pdev->no_vf_scan flag (currently just s390). This includes kernel internal linking with pdev->physfn as well as creation of the relevant sysfs links. The former are required for example by libvirt to manag

Re: [PATCH] x86: bitops: fix build regression

2020-05-06 Thread Nathan Chancellor
On Tue, May 05, 2020 at 09:30:28PM -0700, Nathan Chancellor wrote: > On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > > From: Sedat Dilek > > > > It turns out that if your config tickles __builtin_constant_p via > > differences in choices to inline or not, this now produces inv

Re: [PATCH -next] scsi: qla2xxx: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Bart Van Assche
On 2020-05-06 00:54, Samuel Zou wrote: > Fixes coccicheck warning: > > drivers/scsi/qla2xxx/tcm_qla2xxx.c:1488:1-3: WARNING: PTR_ERR_OR_ZERO can be > used > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou > --- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +--- > 1 file changed, 1 insertion

Re: [PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

2020-05-06 Thread Bart Van Assche
On 2020-05-05 23:17, Jason Yan wrote: > No other functions use the return value of qlafx00_process_aen() and the > return value is always 0 now. Make it return void. This fixes the > following coccicheck warning: > > drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval". > Return "0" o

Re: [patch V4 part 1 19/36] x86/entry: Exclude low level entry code from sanitizing

2020-05-06 Thread Peter Zijlstra
On Tue, May 05, 2020 at 04:39:01PM -0400, Brian Gerst wrote: > On Tue, May 5, 2020 at 10:13 AM Thomas Gleixner wrote: > > > > The sanitizers are not really applicable to the fragile low level entry > > code. code. Entry code needs to carefully setup a normal 'runtime' > > environment. > > > > Sign

Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist

2020-05-06 Thread Steven Rostedt
On Wed, 6 May 2020 09:46:21 +0800 Po-Hsu Lin wrote: > On Tue, May 5, 2020 at 9:09 PM Steven Rostedt wrote: > > > > > > You keep forgetting to Cc Shuah's other email. > Thanks! > I got the recipients list from the get_mainter.pl. Hmm. Seems like that is what get_maintainer.pl does: Steven Ro

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-06 Thread Fangrui Song
On 2020-05-06, Nathan Chancellor wrote: On Wed, May 06, 2020 at 12:22:58PM +0200, Arnd Bergmann wrote: On Wed, May 6, 2020 at 5:45 AM Nathan Chancellor wrote: > On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > > On Tue, 5 May 2020 15:25:56 +0100 Mark Rutland wrote: > > > On Tue,

Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist

2020-05-06 Thread Shuah Khan
On 5/6/20 9:43 AM, Steven Rostedt wrote: On Wed, 6 May 2020 09:46:21 +0800 Po-Hsu Lin wrote: On Tue, May 5, 2020 at 9:09 PM Steven Rostedt wrote: You keep forgetting to Cc Shuah's other email. Thanks! I got the recipients list from the get_mainter.pl. Hmm. Seems like that is what get_m

Re: remove set_fs calls from the coredump code v6

2020-05-06 Thread Eric W. Biederman
Christoph Hellwig writes: > On Tue, May 05, 2020 at 03:28:50PM -0500, Eric W. Biederman wrote: >> We probably can. After introducing a kernel_compat_siginfo that is >> the size that userspace actually would need. >> >> It isn't something I want to mess with until this code gets merged, as I >>

Re: [patch V4 part 1 16/36] kprobes: Support __kprobes blacklist in modules

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Support __kprobes attribute for blacklist functions in modules. The __kprobes attribute functions are stored in .kprobes.text section. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel

Re: [patch V4 part 2 01/18] x86/entry/64: Move non entry code into .text section

2020-05-06 Thread Peter Zijlstra
On Tue, May 05, 2020 at 03:41:13PM +0200, Thomas Gleixner wrote: > All ASM code which is not part of the entry functionality can move out into > the .text section. No reason to keep it in the non-instrumentable entry > section. Just to note to self (or others), I'm planning to move all this into a

[PATCH v2] sched/pelt: sync util/runnable_sum with PELT window when propagating

2020-05-06 Thread Vincent Guittot
update_tg_cfs_*() propagate the impact of the attach/detach of an entity down into the cfs_rq hierarchy and must keep the sync with the current pelt window. Even if we can't sync child cfs_rq and its group se, we can sync the group se and its parent cfs_rq with current position in the PELT window.

Re: [RFC] DPCM for Tegra

2020-05-06 Thread Mark Brown
On Wed, May 06, 2020 at 04:47:09PM +0200, Jerome Brunet wrote: > On Wed 06 May 2020 at 16:12, Sameer Pujar wrote: > > XBAR currently exports all routing widgets which can be used to > > interconnect multiple components and thus implements Mux widgets. Fixing > > the routing paths in driver would

Re: [PATCH] media: usb: ttusb-dec: avoid buffer overflow in ttusb_dec_handle_irq() when DMA failures/attacks occur

2020-05-06 Thread Greg KH
On Wed, May 06, 2020 at 11:30:22PM +0800, Jia-Ju Bai wrote: > > > On 2020/5/6 19:07, Greg KH wrote: > > On Wed, May 06, 2020 at 06:13:01PM +0800, Jia-Ju Bai wrote: > > > I have never modified DMA memory in the real world, but an attacker can > > > use > > > a malicious device to do this. > > > T

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-06 Thread Josh Poimboeuf
On Tue, May 05, 2020 at 04:59:39PM -0700, Alexei Starovoitov wrote: > As far as workaround I prefer the following: > From 94bbc27c5a70d78846a5cb675df4cf8732883564 Mon Sep 17 00:00:00 2001 > From: Alexei Starovoitov > Date: Tue, 5 May 2020 16:52:41 -0700 > Subject: [PATCH] bpf,objtool: tweak interp

Re: [PATCH] hwmon: adt7411: update contact email

2020-05-06 Thread Guenter Roeck
On Sat, May 02, 2020 at 04:27:00PM +0200, Wolfram Sang wrote: > My 'pengutronix' address is defunct for years. Merge the entries and use > the proper contact address. > > Signed-off-by: Wolfram Sang Applied. Thanks, Guenter > --- > drivers/hwmon/adt7411.c | 3 +-- > 1 file changed, 1 insertio

Re: [PATCH 0/4] allow multiple kthreadd's

2020-05-06 Thread J. Bruce Fields
On Wed, May 06, 2020 at 11:39:20AM -0400, Tejun Heo wrote: > Hello, Bruce. > > On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > > It's not the

Re: [patch V4 part 1 17/36] kprobes: Support NOKPROBE_SYMBOL() in modules

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Support NOKPROBE_SYMBOL() in modules. NOKPROBE_SYMBOL() records only symbol address in "_kprobe_blacklist" section in the module. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r

Re: [PATCH 3/3] hwmon: (occ) Add new temperature sensor type

2020-05-06 Thread Guenter Roeck
On Fri, May 01, 2020 at 10:08:33AM -0500, Eddie James wrote: > The latest version of the On-Chip Controller (OCC) has a different > format for the temperature sensor data. Add a new temperature sensor > version to handle this data. > > Signed-off-by: Eddie James For my reference: Acked-by: Guen

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity

2020-05-06 Thread Laurent Pinchart
Hi Doug, On Tue, May 05, 2020 at 05:18:48PM -0700, Doug Anderson wrote: > On Tue, May 5, 2020 at 2:24 PM Doug Anderson wrote: > > On Tue, May 5, 2020 at 2:14 PM Laurent Pinchart wrote: > > > > > > > I'll add this documentation into the comments of the yaml, but I'm not > > > > going to try to impl

[PATCH v2 4/7] mfd: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints - Added some blank lines for readability Thanks, Charles Documentation/devicetree/bindings/mfd/arizona.txt | 101 --- .../devicetree/bindings/mfd/wlf,arizona.yaml | 298 +

[PATCH v2 5/7] ASoC: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../devicetree/bindings/sound/cirrus,madera.yaml | 113 + Documentation/devicetree/bindings/sound/madera.txt | 67 --

[PATCH v2 6/7] pinctrl: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 -- .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 147 +

[PATCH v2 3/7] ASoC: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints Thanks, Charles .../devicetree/bindings/sound/wlf,arizona.txt | 53 -- .../devicetree/bindings/sound/wlf,arizona.yaml | 114 + 2 files changed, 114

[PATCH v2 1/7] regulator: arizona-regulator: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- No changes since v1. Thanks, Charles .../bindings/regulator/arizona-regulator.txt | 18 --- .../devicetree/bindings/regulator/wlf,arizona.yaml | 37 ++ 2 files changed, 37 insertions(+), 18 deletions(-) delete mode 100644 Do

[PATCH v2 7/7] mfd: madera: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- New since v1, putting in the same series as Arizona since they share the same regulator binding. Thanks, Charles .../devicetree/bindings/mfd/cirrus,madera.yaml | 317 + Documentation/devicetree/bindings/mfd/madera.txt | 114

[PATCH v2 2/7] extcon: arizona: Move binding over to dtschema

2020-05-06 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed some description that duplicates constraints Thanks, Charles .../devicetree/bindings/extcon/extcon-arizona.txt | 76 - .../devicetree/bindings/extcon/wlf,arizona.yaml| 125 + 2 files changed, 1

Re: [PATCH 3/3] hwmon: (occ) Add new temperature sensor type

2020-05-06 Thread Eddie James
On 5/6/20 10:57 AM, Guenter Roeck wrote: On Fri, May 01, 2020 at 10:08:33AM -0500, Eddie James wrote: The latest version of the On-Chip Controller (OCC) has a different format for the temperature sensor data. Add a new temperature sensor version to handle this data. Signed-off-by: Eddie James

Re: [patch V4 part 1 18/36] samples/kprobes: Add __kprobes and NOKPROBE_SYMBOL() for handlers.

2020-05-06 Thread Alexandre Chartre
On 5/5/20 3:16 PM, Thomas Gleixner wrote: From: Masami Hiramatsu Add __kprobes and NOKPROBE_SYMBOL() for sample kprobe handlers. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/158523421177.24735.16273975317343670204.stgit@devnote2 --- sam

Re: [PATCH] ipc/util.c: sysvipc_find_ipc() incorrectly updates position index

2020-05-06 Thread Waiman Long
On 5/6/20 2:25 AM, Vasily Averin wrote: new_pos should jump through hole of unused ids, pos can be updated inside "for" cycle. Cc: sta...@vger.kernel.org Fixes: 89163f93c6f9 ("ipc/util.c: sysvipc_find_ipc() should increase position index") Signed-off-by: Vasily Averin --- ipc/util.c | 12 +++

Re: [PATCH v4 14/18] static_call: Add static_cond_call()

2020-05-06 Thread Peter Zijlstra
On Wed, May 06, 2020 at 03:51:28PM +0200, Peter Zijlstra wrote: > On Tue, May 05, 2020 at 11:13:53AM -0700, Nick Desaulniers wrote: > > On Tue, May 5, 2020 at 2:36 AM Peter Zijlstra wrote: > > > > > > > > > HJ, Nick, > > > > > > Any chance any of you can see a way to make your respective compilers

Re: [PATCH 2/9] KVM: x86: fix DR6 delivery for various cases of #DB injection

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 07:10:27AM -0400, Paolo Bonzini wrote: > Go through kvm_queue_exception_p so that the payload is correctly delivered > through the exit qualification, and add a kvm_update_dr6 call to > kvm_deliver_exception_payload that is needed on AMD. > > Reported-by: Peter Xu > Signed

<    2   3   4   5   6   7   8   9   10   11   >