Re: [EXT] Re: [PATCH 4/8] mtd: spinand: enabled parameter page support

2019-10-07 Thread Boris Brezillon
On Mon, 19 Aug 2019 11:21:18 +0200 Miquel Raynal wrote: > Hi Boris, > > Another question for you :) > > "Shivamurthy Shastri (sshivamurthy)" wrote on > Mon, 19 Aug 2019 08:51:52 +: > > > Hi Miquel, > > > > > > > > Hi Shiva, > > > > > > shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-07 Thread Eugen.Hristev
On 11.09.2019 11:24, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > Hello, > > This series adds support for analog and digital filters for i2c controllers > > This series is based on the series: > [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs > and later > [PATCH v4 0/9] i2

[PATCH v2] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

2019-10-07 Thread Yoshihiro Shimoda
Since the role_store() uses strncmp(), it's possible to refer out-of-memory if the sysfs data size is smaller than strlen("host"). This patch fixes it by using sysfs_streq() instead of strncmp(). Reported-by: Pavel Machek Fixes: 9bb86777fb71 ("phy: rcar-gen3-usb2: add sysfs for usb role swap") Cc

[PATCH] mm, hugetlb: allow hugepage allocations to excessively reclaim

2019-10-07 Thread Michal Hocko
From: David Rientjes b39d0ee2632d ("mm, page_alloc: avoid expensive reclaim when compaction may not succeed") has chnaged the allocator to bail out from the allocator early to prevent from a potentially excessive memory reclaim. __GFP_RETRY_MAYFAIL is designed to retry the allocation, reclaim and

Re: [Patch v2 16/21] media: ti-vpe: vpe: use standard struct instead of duplicating fields

2019-10-07 Thread Hans Verkuil
On 10/4/19 6:29 PM, Benoit Parrot wrote: > For each queue we need to maintain resolutions, pixel format, > bytesperline, sizeimage, colorspace, etc. > > Instead of manually adding more entries in the vpe_q_data struct, it is > better to just add a "struct v4l2_format" member and use that to store

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Sat, Oct 05, 2019 at 08:54:13AM -0700, Sean Christopherson wrote: > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > I'll tackle this tomorrow. I've been working on the feature control MSR > > > serie

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-07 Thread Eugen.Hristev
On 02.10.2019 16:16, Guenter Roeck wrote: > > On 10/2/19 12:35 AM, eugen.hris...@microchip.com wrote: >> From: Eugen Hristev >> >> This is the driver for SAM9X60 watchdog timer. >> The offered functionality is the same as sama5d4_wdt. >> The difference comes in register map, way to configure t

Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1

2019-10-07 Thread Pierre Yves MORDRET
Hi Alain Fixes tag is missing in your patch. [ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ] Nonetheless patch only consists in removing a comment character ? Thanks On 10/4/19 4:55 PM, Alain Volmat wrote: > Remove the following warning: > > drivers/i2c/busses/i2c-stm32f7.c:31

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Sat, Oct 05, 2019 at 11:39:39AM -0700, Sean Christopherson wrote: > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > I'll tackle this tomorrow. I've been working on the feature control MSR > > > serie

Re: [PATCH 01/10] leds: pca953x: Use of_device_get_match_data()

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 11:43 PM Stephen Boyd wrote: > This driver can use the of_device_get_match_data() API to simplify the > code. Replace calls to of_match_device() with this newer API under the > assumption that where it is called will be when we know the device is > backed by a DT node. This

Re: [PATCH v8 1/5] kasan: support backing vmalloc space with real shadow memory

2019-10-07 Thread Uladzislau Rezki
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a3c70e275f4e..9fb7a16f42ae 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -690,8 +690,19 @@ merge_or_add_vmap_area(struct vmap_area *va, > struct list_head *next; > struct rb_node **link; > struct rb_node *parent; > + u

Re: [PATCH] panic: Ensure preemption is disabled during panic()

2019-10-07 Thread Jiri Kosina
On Fri, 4 Oct 2019, Will Deacon wrote: > Indeed, and I think the LED blinking is already unreliable if the > brightness operation needs to sleep. One thing is that led_set_brightness() can probably be forced to avoid the workqueue scheduling, by setting LED_BLINK_SW on the device (e.g. by issu

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Tzung-Bi Shih
On Mon, Oct 7, 2019 at 3:16 PM Cheng-Yi Chiang wrote: > > Add an interface for other driver to query VPD value. > This will be used for ASoC machine driver to query calibration > data stored in VPD for smart amplifier speaker resistor > calibration. > > Signed-off-by: Cheng-Yi Chiang > --- > dri

Re: [Patch v3 1/3] media: ov5640: add PIXEL_RATE control

2019-10-07 Thread Sakari Ailus
On Fri, Oct 04, 2019 at 12:24:16PM -0500, Benoit Parrot wrote: > @@ -2657,6 +2669,12 @@ static int ov5640_init_controls(struct ov5640_dev > *sensor) > /* we can use our own mutex for the ctrl lock */ > hdl->lock = &sensor->lock; > > + /* Clock related controls */ > + ctrls->p

Re: [PATCH 1/3] x86/alternatives: Teach text_poke_bp() to emulate instructions

2019-10-07 Thread Peter Zijlstra
On Fri, Oct 04, 2019 at 10:45:40PM +0900, Masami Hiramatsu wrote: > Hi Peter, > > On Thu, 3 Oct 2019 13:01:06 +0200 > Peter Zijlstra wrote: > > > I'm halfway through a patch introducing: > > > > > > union text_poke_insn { > > > u8 code[POKE_MAX_OPCODE_SUZE]; > > > struct { > > >

Re: [Patch v2 19/21] media: v4l2-common: add pixel encoding support

2019-10-07 Thread Hans Verkuil
On 10/4/19 6:29 PM, Benoit Parrot wrote: > It is often useful to figure out if a pixel_format is either YUV or RGB > especially for driver who can perform the pixel encoding conversion. > > Instead of having each driver implement its own "is_this_yuv/rgb" > function based on a restricted set of pi

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
On 19-10-07 01:21, Anson Huang wrote: > Hi, Marco > > > On 19-09-30 08:32, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-09-30 07:42, Anson Huang wrote: > > > > > Hi, Leonard > > > > > > > > > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > > > > > >> On 2019-09-26 1:06 PM, Marco Felsch

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Michal Hocko
On Fri 04-10-19 18:26:45, Qian Cai wrote: > It is unsafe to call printk() while zone->lock was held, i.e., > > zone->lock --> console_lock > > because the console could always allocate some memory in different code > paths and form locking chains in an opposite order, > > console_lock --> * -->

Re: [PATCH v3 3/4] HID: logitech: Add feature 0x0001: FeatureSet

2019-10-07 Thread Filipe Laíns
On Sun, 2019-10-06 at 19:29 +, Mazin Rezk wrote: > > > /* --- > > > --- */ > > > /* 0x0005: > > > GetDeviceNameType > > > */ > > > /*

Re: [PATCH 3/3] x86/ftrace: Use text_poke()

2019-10-07 Thread Peter Zijlstra
On Fri, Oct 04, 2019 at 10:10:47AM +0200, Daniel Bristot de Oliveira wrote: > 1) the enabling/disabling ftrace path > 2) the int3 path - if a thread/irq is running a kernel function > 3) the IPI - that affects all CPUs, even those that are not "hitting" trace > code, e.g., user-space. > > The firs

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 10:57:12AM +0300, Jarkko Sakkinen wrote: > On Sat, Oct 05, 2019 at 08:54:13AM -0700, Sean Christopherson wrote: > > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > > I'll tackle

[PATCH] ARM: dts: Set status to disable for MMC3

2019-10-07 Thread Emmanuel Vadot
Commit 5b63fb90adb95 ("ARM: dts: Fix incomplete dts data for am3 and am4 mmc") fixed the mmc instances on the l3 interconnect but removed the disabled status. Fix this and let boards properly define it if it have it. Fixes: 5b63fb90adb95 ("ARM: dts: Fix incomplete dts data for am3 and am4 mmc") Si

Re: [PATCH -next 29/34] rtc: sunxi: use devm_platform_ioremap_resource() to simplify code

2019-10-07 Thread Chen-Yu Tsai
On Sun, Oct 6, 2019 at 6:39 PM YueHaibing wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Acked-by: Chen-Yu Tsai

Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

2019-10-07 Thread Mathias Nyman
On 7.10.2019 10.21, Carlo Caione wrote: Hi, I bisected an issue down to commit f7fac17ca925 "xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()". Setup: XPS 9370 + Thunderbolt dock Dell TB16 Issue: The laptop is unable to go to sleep. It never really goes to sleep and after a f

Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic

2019-10-07 Thread Boris Brezillon
On Mon, 19 Aug 2019 09:03:38 + "Shivamurthy Shastri (sshivamurthy)" wrote: > > > > > static int micron_spinand_detect(struct spinand_device *spinand) > > > { > > > + const struct spi_mem_op *op; > > > u8 *id = spinand->id.data; > > > - int ret; > > > > > > /* > > >* Micron SPI NA

Re: + printf-add-support-for-printing-symbolic-error-codes.patch added to -mm tree

2019-10-07 Thread Petr Mladek
Hi Andrew, On Sat 2019-10-05 14:52:00, Andrew Morton wrote: > > The patch titled > Subject: vsprintf: add support for printing symbolic error codes > has been added to the -mm tree. Its filename is > printf-add-support-for-printing-symbolic-error-codes.patch The patch is still under d

Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip

2019-10-07 Thread Marc Zyngier
On Mon, 07 Oct 2019 08:30:50 +0100, Geert Uytterhoeven wrote: > > Hi Chris, > > CC MarcZ > > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham > wrote: > > Use the dev_name(dev) for the irqc->name so that we get unique names > > when we have multiple instances of this driver. > > > > Signed-off-by:

Re: [PATCH v2] mm/slub: fix a deadlock in show_slab_objects()

2019-10-07 Thread Michal Hocko
On Fri 04-10-19 14:57:01, Michal Hocko wrote: > On Fri 04-10-19 08:31:49, Qian Cai wrote: > > Long time ago, there fixed a similar deadlock in show_slab_objects() > > [1]. However, it is apparently due to the commits like 01fb58bcba63 > > ("slab: remove synchronous synchronize_sched() from memcg ca

Re: Serial 8250 DMA Broken on OMAP3630

2019-10-07 Thread Andy Shevchenko
On Sun, Oct 06, 2019 at 12:04:47PM -0500, Adam Ford wrote: I think the best one who may shed a light is bigeasy@ (Cc'ed). > Has anyone else had any issues using the CONFIG_SERIAL_8250_DMA on the OMAP? > > I can use the DMA on the legacy, omap-serial driver, but when I enable > the DMA on the 825

[PATCH 2/3] ftrace: Introduce PERMANENT ftrace_ops flag

2019-10-07 Thread Miroslav Benes
Livepatch uses ftrace for redirection to new patched functions. It means that if ftrace is disabled, all live patched functions are disabled as well. Toggling global 'ftrace_enabled' sysctl thus affect it directly. It is not a problem per se, because only administrator can set sysctl values, but it

[PATCH 3/3] livepatch: Use FTRACE_OPS_FL_PERMANENT

2019-10-07 Thread Miroslav Benes
Use FTRACE_OPS_FL_PERMANENT flag to be immune to toggling the 'ftrace_enabled' sysctl knob. Signed-off-by: Miroslav Benes --- kernel/livepatch/patch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/livepatch/patch.c b/kernel/livepatch/patch.c index bd43537702bd..b55

[PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag

2019-10-07 Thread Miroslav Benes
Livepatch uses ftrace for redirection to new patched functions. It is thus directly affected by ftrace sysctl knobs such as ftrace_enabled. Setting ftrace_enabled to 0 also disables all live patched functions. It is not a problem per se, because only administrator can set sysctl values, but it stil

[PATCH 1/3] ftrace: Make test_rec_ops_needs_regs() generic

2019-10-07 Thread Miroslav Benes
Function test_rec_ops_needs_regs() tests whether ftrace_ops registered on a record needs saved regs. That is, it tests for FTRACE_OPS_FL_SAVE_REGS being set. The same logic will be reused for newly introduced FTRACE_OPS_FL_PERMANENT flag, so make the function generic. Signed-off-by: Miroslav Bene

Re: [PATCH v3] mtd: rawnand: Add support for Macronix NAND randomizer

2019-10-07 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Thu, 5 Sep 2019 17:37:09 +0800: > Macronix NANDs support randomizer operation for user data scrambled, > which can be enabled with a SET_FEATURE. > > User data written to the NAND device without randomizer is still readable > after randomizer function enabled. > T

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 09:29 +0200, Dmitry Vyukov wrote: > > > > diff --git a/mm/kasan/tags_report.c b/mm/kasan/tags_report.c > > > > index 969ae08f59d7..19b9e364b397 100644 > > > > --- a/mm/kasan/tags_report.c > > > > +++ b/mm/kasan/tags_report.c > > > > @@ -36,6 +36,16 @@ > > > > > > > > const ch

Re: [PATCH v16 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-07 Thread Andy Shevchenko
On Sun, Oct 06, 2019 at 11:10:58AM -0400, William Breathitt Gray wrote: > This macro iterates for each 8-bit group of bits (clump) with set bits, > within a bitmap memory region. For each iteration, "start" is set to the > bit offset of the found clump, while the respective clump value is > stored

Re: [PATCH v16 10/14] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-10-07 Thread Andy Shevchenko
On Sun, Oct 06, 2019 at 11:11:07AM -0400, William Breathitt Gray wrote: > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity. I can test it somewhat later. > Suggested-by: Andy Shevchenko > Cc: Geert Uytterhoeven > Cc: P

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Dmitry Vyukov
On Mon, Oct 7, 2019 at 10:18 AM Walter Wu wrote: > The patchsets help to produce KASAN report when size is negative numbers > in memory operation function. It is helpful for programmer to solve the > undefined behavior issue. Patch 1 based on Dmitry's review and > suggestion, patch 2 is a test in

Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node

2019-10-07 Thread Daniel Wagner
On Fri, Oct 04, 2019 at 05:37:28PM +0200, Sebastian Andrzej Siewior wrote: > If you post something that is related to PREEMPT_RT please keep tglx and > me in Cc. Sure, just forgot to add it this time. My email setup needs a bit more love. Sorry.

Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

2019-10-07 Thread Carlo Caione
On 07/10/2019 09:13, Mathias Nyman wrote: /cut Does the below patch help?  Greg just applied it to his usb-linus branch. ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend() Link: https://lore.kernel.org/r/1570190373-30684-8-git-send-email-mathias.ny...@linux.intel.com Yes. That p

Re: [PATCH v2 2/2] cpufreq: intel_pstate: Conditional frequency invariant accounting

2019-10-07 Thread Giovanni Gherdovich
On Fri, 2019-10-04 at 08:17 -0700, Srinivas Pandruvada wrote: > On Fri, 2019-10-04 at 10:57 +0200, Giovanni Gherdovich wrote: > > On Fri, 2019-10-04 at 10:29 +0200, Rafael J. Wysocki wrote: > > > On Fri, Oct 4, 2019 at 10:24 AM Giovanni Gherdovich < > > > ggherdov...@suse.cz> wrote: > > > > > > >

[RFC v5 0/6] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations

2019-10-07 Thread Parth Shah
This is the 5th version of the patchset to sustain Turbo frequencies for longer durations. The previous versions can be found here: v4: https://lkml.org/lkml/2019/7/25/296 v3: https://lkml.org/lkml/2019/6/25/25 v2: https://lkml.org/lkml/2019/5/15/1258 v1: https://lwn.net/Articles/783959/ The chan

Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node

2019-10-07 Thread Daniel Wagner
Hi, On Fri, Oct 04, 2019 at 06:30:42PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote: > > If we have migrate_disable/enable, then, i think preempt_enable/disable > > should be replaced by it and not the way how it has been proposed > > in the patc

[RFC v5 2/6] sched: Introduce switch to enable TurboSched for task packing

2019-10-07 Thread Parth Shah
Create a static key which allows to enable or disable TurboSched feature at runtime. This key is added in order to enable the TurboSched feature only when required. This helps in optimizing the scheduler fast-path when the TurboSched feature is disabled. Also provide get/put methods to keep track

[RFC v5 6/6] powerpc: Set turbo domain to NUMA node for task packing

2019-10-07 Thread Parth Shah
Provide an powerpc architecture specific implementation for defining the turbo domain to make searching of the core to be bound within the NUMA. The POWER9 systems have a pair of cores in the LLC domain. Hence to make TurboSched more effective, increase the domain space for task packing to search

[RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores

2019-10-07 Thread Parth Shah
The algorithm finds the first non idle core in the system and tries to place a task in the idle CPU in the chosen core. To maintain cache hotness, work of finding non idle core starts from the prev_cpu, which also reduces task ping-pong behaviour inside of the core. Define a new method to select_n

[RFC v5 1/6] sched/core: Add manual background task classification using sched_setattr syscall

2019-10-07 Thread Parth Shah
Small background tasks typically performs some housekeeping work and are less important in the overall scheme of load balancing and scheduling. So provide a way to mark the task which are small background noises with the use of additional flag to the existing task attribute. Also provide an interf

[RFC v5 5/6] sched/fair: Provide arch hook to find domain for non idle core search scan

2019-10-07 Thread Parth Shah
Specify the method which returns cpumask within which to limit the search for a non idle core. By default, limit the search in LLC domain which usually includes few/all the cores in the processor chip. The select_non_idle_core searches for the non idle cores in the LLC domain. But in the systems w

[RFC v5 3/6] sched/core: Update turbo_sched count only when required

2019-10-07 Thread Parth Shah
Use the get/put methods to add/remove the use of TurboSched support, such that the feature is turned on only in the presence of atleast one classified small bckground task. Signed-off-by: Parth Shah --- kernel/sched/core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kernel/sched/c

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-07 Thread Hans Verkuil
On 10/7/19 8:02 AM, Jernej Škrabec wrote: > Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a): >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>> These helpers are used by stateless codecs when they support multiple >>> slices per frame and hold capture buffer flag is set. It's

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-07 Thread Roger Quadros
On 07/10/2019 09:39, Pawel Laszczak wrote: Patch fixes issue with Halt Endnpoint Test observed during using g_zero driver as DUT. Bug occurred only on some testing board. Endpoint can defer transition to Halted state if endpoint has pending requests. Patch add additional condition that allows

Re: [PATCH v16 11/14] thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro

2019-10-07 Thread Andy Shevchenko
On Sun, Oct 06, 2019 at 11:11:08AM -0400, William Breathitt Gray wrote: > Utilize for_each_set_clump8 macro, and the bitmap_set_value8 and > bitmap_get_value8 functions, where appropriate. In addition, remove the > now unnecessary temp_mask and temp_shift members of the > intel_soc_dts_sensor_entry

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-07 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Wed, 18 Sep 2019 15:56:26 +0800: > Macronix AD series support using power down command to > enter a minimum power consumption state. > > MTD default _suspend/_resume function replacement by > manufacturer postponed initialization. > > Signed-off-by: Mason Yang >

Re: [PATCH RFC 2/3] mtd: rawnand: Add support Macronix Block Protection function

2019-10-07 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Wed, 18 Sep 2019 15:56:25 +0800: > Macronix AC series support using SET/GET_FEATURES to change > Block Protection and Unprotection. > > MTD default _lock/_unlock function replacement by manufacturer > postponed initialization. Why would we do that? Anyway your so

Re: [PATCH v16 14/14] gpio: pca953x: Utilize the for_each_set_clump8 macro

2019-10-07 Thread Andy Shevchenko
On Sun, Oct 06, 2019 at 11:11:11AM -0400, William Breathitt Gray wrote: > Replace verbose implementation in set_multiple callback with > for_each_set_clump8 macro to simplify code and improve clarity. I can test this along with 74x164 at the same time. > Cc: Phil Reid > Signed-off-by: William Br

Re: [Discussion v2] Usecases for the per-task latency-nice attribute

2019-10-07 Thread Parth Shah
On 10/2/19 9:41 PM, David Laight wrote: > From: Parth Shah >> Sent: 30 September 2019 11:44 > ... >> 5> Separating AVX512 tasks and latency sensitive tasks on separate cores >> ( -Tim Chen ) >> === >> Another usecase we are

Re: kexec breaks with 5.4 due to memzero_explicit

2019-10-07 Thread Hans de Goede
Hi, On 07-10-2019 05:09, Arvind Sankar wrote: Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol memzero_explicit. This has come from commit 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to get input, memzero_explicit") according to git bisect. Hmm, it (obviously) does bu

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 10:24 +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu wrote: > > The patchsets help to produce KASAN report when size is negative numbers > > in memory operation function. It is helpful for programmer to solve the > > undefined behavior issue. Patch 1

Re: [PATCH] firmware: vpd: Add an interface to read VPD value

2019-10-07 Thread Cheng-yi Chiang
On Mon, Oct 7, 2019 at 4:03 PM Tzung-Bi Shih wrote: > > On Mon, Oct 7, 2019 at 3:16 PM Cheng-Yi Chiang wrote: > > > > Add an interface for other driver to query VPD value. > > This will be used for ASoC machine driver to query calibration > > data stored in VPD for smart amplifier speaker resisto

Re: [PATCH 1/3] driver core: platform: Add platform_get_irq_byname_optional()

2019-10-07 Thread Rafael J. Wysocki
On Sat, Oct 5, 2019 at 11:04 PM Hans de Goede wrote: > > Some drivers (e.g dwc3) first try to get an IRQ byname and then fall > back to the one at index 0. In this case we do not want the error(s) > printed by platform_get_irq_byname(). This commit adds a new > platform_get_irq_byname_optional(),

Re: [PATCH v2] mtd: onenand: prevent memory leak in onenand_scan

2019-10-07 Thread Miquel Raynal
Hi Navid, Navid Emamdoost wrote on Fri, 4 Oct 2019 12:19:05 -0500: > In onenand_scan if scan_bbt fails the allocated buffers for oob_buf, > verify_buf, and page_buf should be released. > > Fixes: 5988af231978 ("mtd: Flex-OneNAND support") Missing Cc: sta...@vger.kernel.org > Signed-off-by: N

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Dmitry Vyukov
On Mon, Oct 7, 2019 at 10:52 AM Walter Wu wrote: > > On Mon, 2019-10-07 at 10:24 +0200, Dmitry Vyukov wrote: > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu wrote: > > > The patchsets help to produce KASAN report when size is negative numbers > > > in memory operation function. It is helpful for pr

[PATCH 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Hans de Goede
The purgatory code now uses the shared lib/crypto/sha256.c sha256 implementation. This needs memzero_explicit, implement this. Reported-by: Arvind Sankar Fixes: 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to get input, memzero_explicit") Signed-off-by: Hans de Goede --- arch/x86

Re: [PATCH 1/2] x86: mmu.h: move mm_context_t::lock member inside CONFIG_MODIFY_LDT_SYSCALL

2019-10-07 Thread Rasmus Villemoes
On 28/08/2019 21.38, Rasmus Villemoes wrote: > The placement of the lock member in mm_context_t suggests that it is > used to protect the vdso* members, but AFAICT, it is only ever used > under #ifdef CONFIG_MODIFY_LDT_SYSCALL. So guarding the member by the > same config option is a cheap way to re

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-10-07 Thread Marco Felsch
On 19-10-04 21:41, Linus Walleij wrote: > On Tue, Sep 17, 2019 at 2:43 PM Marco Felsch wrote: > > > + /* > > +* We only must ensure that the gpio device is probed before the > > +* regulator driver so no need to store the reference global. > > Luckily > > +* devm_*

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 10:54 +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 10:52 AM Walter Wu wrote: > > > > On Mon, 2019-10-07 at 10:24 +0200, Dmitry Vyukov wrote: > > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu > > > wrote: > > > > The patchsets help to produce KASAN report when size is

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-07 Thread Petr Mladek
On Mon 2019-10-07 10:07:42, Michal Hocko wrote: > On Fri 04-10-19 18:26:45, Qian Cai wrote: > > It is unsafe to call printk() while zone->lock was held, i.e., > > > > zone->lock --> console_lock > > > > because the console could always allocate some memory in different code > > paths and form loc

Re: kexec breaks with 5.4 due to memzero_explicit

2019-10-07 Thread Hans de Goede
Hi, On 07-10-2019 10:50, Hans de Goede wrote: Hi, On 07-10-2019 05:09, Arvind Sankar wrote: Hi, arch/x86/purgatory/purgatory.ro has an undefined symbol memzero_explicit. This has come from commit 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to get input, memzero_explicit") accord

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Dmitry Vyukov
On Mon, Oct 7, 2019 at 11:03 AM Walter Wu wrote: > > On Mon, 2019-10-07 at 10:54 +0200, Dmitry Vyukov wrote: > > On Mon, Oct 7, 2019 at 10:52 AM Walter Wu wrote: > > > > > > On Mon, 2019-10-07 at 10:24 +0200, Dmitry Vyukov wrote: > > > > On Mon, Oct 7, 2019 at 10:18 AM Walter Wu > > > > wrote:

Re: [PATCH v6 14/14] riscv: Make mmap allocation top-down by default

2019-10-07 Thread Alex Ghiti
On 10/4/19 10:12 PM, Atish Patra wrote: On Thu, 2019-08-08 at 02:17 -0400, Alexandre Ghiti wrote: In order to avoid wasting user address space by using bottom-up mmap allocation scheme, prefer top-down scheme when possible. Before: root@qemuriscv64:~# cat /proc/self/maps 0001-00016000 r-xp

Re: Question about sched_prio_to_weight values

2019-10-07 Thread Valentin Schneider
Hi Francesco, On 06/10/2019 23:32, Francesco Poli wrote: [...] > I searched the web and the mailing list archives, but I failed to find > an answer to this question. Could someone please explain me how those > numbers were picked? > Following the blame rabbit hole I found this: 254753dc321e ("s

Re: [PATCH] sched: rt: Make RT capacity aware

2019-10-07 Thread Dietmar Eggemann
On 23/09/2019 13:52, Qais Yousef wrote: > On 09/20/19 14:52, Dietmar Eggemann wrote: >>> 2. The fallback mechanism means we either have to call cpupri_find() >>>twice once to find filtered lowest_rq and the other to return the >>>none filtered version. >> >> This is what I have

[PATCH v3 0/3] followups to debug_pagealloc improvements through page_owner

2019-10-07 Thread Vlastimil Babka
Changes since v2 [3]: - Qian Cai suggested that the extra boot option and page_ext ops is unnecessary for a debugging option, unless somebody really complains about the overhead, with numbers. So patch 2 is greatly simplified. These are followups to [1] which made it to Linus meanwhile. Patch

[PATCH v3 1/3] mm, page_owner: fix off-by-one error in __set_page_owner_handle()

2019-10-07 Thread Vlastimil Babka
As noted by Kirill, commit 7e2f2a0cd17c ("mm, page_owner: record page owner for each subpage") has introduced an off-by-one error in __set_page_owner_handle() when looking up page_ext for subpages. As a result, the head page page_owner info is set twice, while for the last tail page, it's not set a

[PATCH v3 2/3] mm, page_owner: decouple freeing stack trace from debug_pagealloc

2019-10-07 Thread Vlastimil Babka
The commit 8974558f49a6 ("mm, page_owner, debug_pagealloc: save and dump freeing stack trace") enhanced page_owner to also store freeing stack trace, when debug_pagealloc is also enabled. KASAN would also like to do this [1] to improve error reports to debug e.g. UAF issues. Kirill has suggested th

[PATCH v3 3/3] mm, page_owner: rename flag indicating that page is allocated

2019-10-07 Thread Vlastimil Babka
Commit 37389167a281 ("mm, page_owner: keep owner info when freeing the page") has introduced a flag PAGE_EXT_OWNER_ACTIVE to indicate that page is tracked as being allocated. Kirill suggested naming it PAGE_EXT_OWNER_ALLOCATED to make it more clear, as "active is somewhat loaded term for a page".

Re: [PATCH] iio: imu: adis16480: clean up a condition

2019-10-07 Thread Jonathan Cameron
On Sun, 6 Oct 2019 21:14:40 +0300 Dan Carpenter wrote: > On Sun, Oct 06, 2019 at 09:51:33AM +0100, Jonathan Cameron wrote: > > On Thu, 26 Sep 2019 14:36:30 +0300 > > Dan Carpenter wrote: > > > > > On Thu, Sep 26, 2019 at 11:06:39AM +, Ardelean, Alexandru wrote: > > > > On Thu, 2019-09-2

Re: [PATCH RFC 2/3] mtd: rawnand: Add support Macronix Block Protection function

2019-10-07 Thread Miquel Raynal
Hi Mason, Miquel Raynal wrote on Mon, 7 Oct 2019 10:45:11 +0200: > Hi Mason, > > Mason Yang wrote on Wed, 18 Sep 2019 15:56:25 > +0800: > > > Macronix AC series support using SET/GET_FEATURES to change > > Block Protection and Unprotection. > > > > MTD default _lock/_unlock function replacem

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 11:10 +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 11:03 AM Walter Wu wrote: > > > > On Mon, 2019-10-07 at 10:54 +0200, Dmitry Vyukov wrote: > > > On Mon, Oct 7, 2019 at 10:52 AM Walter Wu > > > wrote: > > > > > > > > On Mon, 2019-10-07 at 10:24 +0200, Dmitry Vyukov

Re: [PATCH] taskstats: fix data-race

2019-10-07 Thread Christian Brauner
On Mon, Oct 07, 2019 at 09:31:16AM +0200, Dmitry Vyukov wrote: > On Mon, Oct 7, 2019 at 1:52 AM Christian Brauner > wrote: > > > > When assiging and testing taskstats in taskstats_exit() there's a race > > when writing and reading sig->stats when a thread-group with more than > > one thread exits:

Re: [PATCH 4.9 30/47] ANDROID: binder: remove waitqueue when thread exits.

2019-10-07 Thread Martijn Coenen
On Mon, Oct 7, 2019 at 8:28 AM Mattias Nissler wrote: > Jann's PoC calls the BINDER_THREAD_EXIT ioctl to free the > binder_thread which will then cause the UAF, and this is cut off by > the patch. IIUC, you are worried about a similar AUF on the proc->wait > access. I am not 100% sure, but I think

Re: [PATCH 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Stephan Mueller
Am Montag, 7. Oktober 2019, 11:06:04 CEST schrieb Hans de Goede: Hi Hans, > Hi Stephan, > > On 07-10-2019 10:59, Stephan Mueller wrote: > > Am Montag, 7. Oktober 2019, 10:55:01 CEST schrieb Hans de Goede: > > > > Hi Hans, > > > >> The purgatory code now uses the shared lib/crypto/sha256.c sha2

Re: [PATCH v2] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active

2019-10-07 Thread Dave Young
Hi Lianbo, On 10/07/19 at 03:08pm, Lianbo Jiang wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204793 > > Kdump kernel will reuse the first 640k region because of some reasons, > for example: the trampline and conventional PC system BIOS region may > require to allocate memory in t

Re: [PATCH 4.9 30/47] ANDROID: binder: remove waitqueue when thread exits.

2019-10-07 Thread Martijn Coenen
On Sun, Oct 6, 2019 at 7:23 PM Greg Kroah-Hartman wrote: > > From: Martijn Coenen > > commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f upstream. > > binder_poll() passes the thread->wait waitqueue that > can be slept on for work. When a thread that uses > epoll explicitly exits using BINDER_THREAD

Re: [PATCH] staging: vt6656: remove duplicated blank line

2019-10-07 Thread Quentin Deslandes
On Sun, Oct 06, 2019 at 04:58:54PM -0300, Gabriela Bittencourt wrote: > Cleans up checks of "don't use multiple blank line" > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/vt6656/main_usb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/vt6656/main_usb.c

Re: [PATCH v2 0/2] PCI: Add missing link delays

2019-10-07 Thread Mika Westerberg
On Sat, Oct 05, 2019 at 09:34:41AM +0200, Matthias Andree wrote: > Am 04.10.19 um 15:06 schrieb Mika Westerberg: > > On Fri, Oct 04, 2019 at 02:57:21PM +0200, Matthias Andree wrote: > >> Am 04.10.19 um 14:39 schrieb Mika Westerberg: > >>> @Matthias, @Paul and @Nicholas, I appreciate if you could ch

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-07 Thread Marco Felsch
Hi Doug, Mark, On 19-10-01 12:57, Doug Anderson wrote: > Hi, > > On Fri, Sep 27, 2019 at 1:47 AM Marco Felsch wrote: > > > > > > It should be possible to do a regulator_disable() though I'm not > > > > > > sure anyone actually uses that. The pattern for a regular > > > > > > consumer should be

Re: [PATCH 4.9 30/47] ANDROID: binder: remove waitqueue when thread exits.

2019-10-07 Thread Greg Kroah-Hartman
On Mon, Oct 07, 2019 at 11:33:53AM +0200, Martijn Coenen wrote: > On Sun, Oct 6, 2019 at 7:23 PM Greg Kroah-Hartman > wrote: > > > > From: Martijn Coenen > > > > commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f upstream. > > > > binder_poll() passes the thread->wait waitqueue that > > can be slept

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-07 Thread Hans Verkuil
On 10/7/19 10:32 AM, Hans Verkuil wrote: > On 10/7/19 8:02 AM, Jernej Škrabec wrote: >> Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a): >>> On 9/29/19 10:00 PM, Jernej Skrabec wrote: These helpers are used by stateless codecs when they support multiple slices per

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-10-07 Thread Walter Wu
On Mon, 2019-10-07 at 17:28 +0800, Walter Wu wrote: > On Mon, 2019-10-07 at 11:10 +0200, Dmitry Vyukov wrote: > > On Mon, Oct 7, 2019 at 11:03 AM Walter Wu wrote: > > > > > > On Mon, 2019-10-07 at 10:54 +0200, Dmitry Vyukov wrote: > > > > On Mon, Oct 7, 2019 at 10:52 AM Walter Wu > > > > wrote:

[PATCH] media: cx18: make array mapping static, makes object smaller

2019-10-07 Thread Colin King
From: Colin Ian King Don't populate the array mapping on the stack but instead make it static. Makes the object code smaller by 79 bytes. Before: textdata bss dec hex filename 275722096 0 2966873e4 drivers/media/pci/cx18/cx18-ioctl.o After: textdata

Re: [PATCH] arm64: dts: allwinner: a64: orangepi-win: Enable audio codec

2019-10-07 Thread Maxime Ripard
On Fri, Oct 04, 2019 at 12:21:30AM +0200, Jernej Skrabec wrote: > This patch enables internal audio codec on OrangePi Win board by > enabling all relevant nodes and adding appropriate routing. Board has > on-board microphone (MIC1) and 3.5 mm jack with stereo audio and > microphone (MIC2). > > Sign

Re: [PATCH v3 1/3] mm: kmemleak: Make the tool tolerant to struct scan_area allocation failures

2019-10-07 Thread Catalin Marinas
On Sat, Oct 05, 2019 at 01:08:43PM +1000, Alexey Kardashevskiy wrote: > On 03/10/2019 18:41, Catalin Marinas wrote: > > On Thu, Oct 03, 2019 at 04:13:07PM +1000, Alexey Kardashevskiy wrote: > >> On 13/08/2019 02:06, Catalin Marinas wrote: > >>> Object scan areas are an optimisation aimed to decreas

Re: [PATCH v2 1/7] iio: adc: max1027: Add debugfs register read support

2019-10-07 Thread Miquel Raynal
Hi Jonathan, Jonathan Cameron wrote on Sun, 6 Oct 2019 11:04:24 +0100: > On Thu, 3 Oct 2019 19:33:55 +0200 > Miquel Raynal wrote: > > > Until now, only write operations were supported. Force two bytes read > > operation when reading from this register (might be wrong when reading > > the temp

Re: [PATCH v2 3/7] intel-speed-select: Add check for CascadeLake-N models

2019-10-07 Thread Andy Shevchenko
On Fri, Oct 04, 2019 at 10:15:21AM -0700, Srinivas Pandruvada wrote: > On Thu, 2019-10-03 at 08:11 -0400, Prarit Bhargava wrote: > > + /* only three CascadeLake-N models are supported */ > > + if (is_clx_n_platform()) { > > + FILE *fp; > > + size_t n; > > + char *

Re: [PATCH v2 4/7] iio: adc: max1027: Prepare the introduction of different resolutions

2019-10-07 Thread Miquel Raynal
Hi Jonathan, > > > > +#define MAX1X27_CHANNELS(depth)\ > > + MAX1027_T_CHAN, \ > > + MAX1027_V_CHAN(0, depth), \ > > + MAX1027_V_CHAN(1, depth), \ > > + MAX1027_V_CHAN(2, depth), \ > > + MAX1027_V_CHA

Re: [PATCH v2 2/7] iio: adc: max1027: Make it optional to use interrupts

2019-10-07 Thread Miquel Raynal
Hi Jonathan, Jonathan Cameron wrote on Sun, 6 Oct 2019 11:18:37 +0100: > On Thu, 3 Oct 2019 19:33:56 +0200 > Miquel Raynal wrote: > > > The chip has a 'start conversion' and a 'end of conversion' pair of > > pins. They can be used but this is absolutely not mandatory as regular > > polling of

Re: [PATCH v2 7/7] dt-bindings: iio: adc: max1027: Document max12xx series compatibles

2019-10-07 Thread Miquel Raynal
Hi Jonathan, Jonathan Cameron wrote on Sun, 6 Oct 2019 11:27:51 +0100: > On Thu, 3 Oct 2019 19:34:01 +0200 > Miquel Raynal wrote: > > > Update the bindings documentation with new Maxim ADCs compatibles. > > > > Signed-off-by: Miquel Raynal > > Both DT patches look fine to me... > > If

Re: [PATCH] media: dt-bindings: media: Fixup Allwinner A10 CSI binding

2019-10-07 Thread Maxime Ripard
On Sat, Oct 05, 2019 at 04:15:57PM +0530, Amit Kucheria wrote: > On Thu, Oct 3, 2019 at 5:22 PM Maxime Ripard wrote: > > > > Hi, > > > > On Thu, Oct 03, 2019 at 04:52:24PM +0530, Amit Kucheria wrote: > > > This new binding fails dt_binding_check due to a typo. Fix it up. > > > > > > linux.git/Docu

<    1   2   3   4   5   6   7   8   9   10   >