[PATCH V3 2/3] dt-bindings: Add Logic PD Type 28 display panel

2019-09-25 Thread Adam Ford
This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,ty

[PATCH V3 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

2019-09-25 Thread Adam Ford
With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --- V3: No change V2:

[PATCH 2/2] devfreq: Rename df->previous_freq to df->cur_freq

2019-09-25 Thread Matthias Kaehlcke
The vast majority of code uses df->previous_freq to get the current frequency of the devfreq device, not the previous one. Rename the struct field to reflect this. Add a comment to devfreq_update_stats() to make clear that df->cur_freq must only be updated after calling this function in the contex

[PATCH v3] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM_SLEEP

2019-09-25 Thread Dexuan Cui
If CONFIG_PM_SLEEP is not set, we can comment out these functions to avoid the below warnings: drivers/hv/vmbus_drv.c:2208:12: warning: ‘vmbus_bus_resume’ defined but not used [-Wunused-function] drivers/hv/vmbus_drv.c:2128:12: warning: ‘vmbus_bus_suspend’ defined but not used [-Wunused-function

Re: [PATCH] modpost: fix static EXPORT_SYMBOL warnings for UML build

2019-09-25 Thread Denis Efremov
Hi, On 24.09.2019 15:07, Masahiro Yamada wrote: > Johannes Berg reports lots of modpost warnings on ARCH=um builds: > > WARNING: "rename" [vmlinux] is a static EXPORT_SYMBOL > WARNING: "lseek" [vmlinux] is a static EXPORT_SYMBOL > WARNING: "ftruncate64" [vmlinux] is a static EXPORT_SYMBOL > WARNI

[PATCH 2/2] nvmem: add Rockchip OTP driver

2019-09-25 Thread Heiko Stuebner
From: Finley Xiao Newer Rockchip socs like the px30 use a different one-time-programmable memory controller for things like cpu-id and leakage information, so add the necessary driver for it. Signed-off-by: Finley Xiao [ported from vendor 4.4, converted to clock-bulk API and cleanups] Signed-of

[PATCH 1/2] dt-bindings: nvmem: add binding for Rockchip OTP controller

2019-09-25 Thread Heiko Stuebner
Newer Rockchip SoCs use a different IP for accessing special one- time-programmable memory, so add a binding for these controllers. Signed-off-by: Heiko Stuebner --- .../bindings/nvmem/rockchip-otp.txt | 25 +++ 1 file changed, 25 insertions(+) create mode 100644 Docum

[no subject]

2019-09-25 Thread linux-kernel
Здравствуйте! Вас интересуют клиентские базы данных?

Unmerged patches adding audit when protected_regular/fifos sysctl causes EACCES

2019-09-25 Thread Jérémie Galarneau
Hi Kees, I have noticed that the two top-most patches of your protected-creat branch were never merged upstream [1]. Those patches add audit logs whenever the protected_regular or protected_fifo sysctl prevent the creation of a file/fifo. They were mentioned in the v4 thread [2] of the "main" pat

Re: [PATCH v1 2/4] clone3: switch to copy_struct_from_user()

2019-09-25 Thread kbuild test robot
Hi Aleksa, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

[PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs

2019-09-25 Thread Navid Emamdoost
In nfp_flower_spawn_vnic_reprs in the loop if initialization or the allocations fail memory is leaked. Appropriate releases are added. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/netronome/nfp/flower/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/n

Re: [PATCH v22 02/24] x86/cpufeatures: x86/msr: Intel SGX Launch Control hardware bits

2019-09-25 Thread Sean Christopherson
On Wed, Sep 25, 2019 at 08:31:36PM +0200, Borislav Petkov wrote: > On Wed, Sep 25, 2019 at 10:18:24AM -0700, Sean Christopherson wrote: > > Realistically, there will likely be a non-trivial number of systems with > > SGX_LE_WR=0 but SGX enabled. > > Well no. We won't support those. I remember very

Re: [PATCH v1 2/4] clone3: switch to copy_struct_from_user()

2019-09-25 Thread kbuild test robot
Hi Aleksa, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

Re: [PATCH v1 1/4] lib: introduce copy_struct_from_user() helper

2019-09-25 Thread kbuild test robot
Hi Aleksa, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

[v1, 1/1] gpio: dts: aspeed: Add SGPIO driver

2019-09-25 Thread Hongwei Zhang
> > obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o > > -- > > 2.7.4 > > > > This should be split into separate patches with one extending the binding > document and one adding > actual support. > > Bart Thanks Bart, I just submitted splitted patches. --Hongwei

[v1, 0/1] gpio: dts: aspeed: Add SGPIO driver

2019-09-25 Thread Hongwei Zhang
> > > The related SGPIO driver has been accepted and merged into v5.4: > > _http://patchwork.ozlabs.org/patch/1150357/ > > Oh what a mess, it didn't add the necessary code into Kconfig and Makefile, > also names it sgpio-gpio.c > when everything else is named gpio-sgpio.c. > > I guess I have t

[v2, 0/2] gpio: dts: aspeed: Add SGPIO driver

2019-09-25 Thread Hongwei Zhang
Hello, This short series introduce the Kconfig, Makefile, and dts for the Aspeed AST2500 SGPIO controller. This is the last patch set. Please review. [v2]: changes between v1 and v2: - split the patches based on review feedback. [v1]: Initial commit The related SGPIO driver has bee

[v2, 1/2] gpio: dts: aspeed: Add SGPIO driver

2019-09-25 Thread Hongwei Zhang
Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- arch/arm/Kconfig | 2 ++ arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++- diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2436021..c9f08ab 100644 --- a/arch/arm/Kconfig +++ b/arch/arm

[v2, 2/2] gpio: dts: aspeed: Add SGPIO driver

2019-09-25 Thread Hongwei Zhang
Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- drivers/gpio/Kconfig | 8 drivers/gpio/Makefile| 1 + diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index bb13c26..e94f903 100644 --- a/drivers/gpio/Kconfig +++ b/drive

Re: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim

2019-09-25 Thread Tony Jones
On 9/18/19 7:38 AM, Yafang Shao wrote: > Currently there's no easy way to make perf scripts in sync with > tracepoints. One possible way is to run perf's tests regularly, another way > is once we changes the definitions of tracepoints we must keep in mind that > the perf scripts which are using the

Re: [PATCH] KVM: LAPIC: Loose fluctuation filter for auto tune lapic_timer_advance_ns

2019-09-25 Thread Sean Christopherson
On Wed, Sep 25, 2019 at 01:47:04PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > 5000 guest cycles delta is easy to encounter on desktop, per-vCPU > lapic_timer_advance_ns always keeps at 1000ns initial value, lets > loose fluctuation filter a bit to make auto tune can make some > progress.

Re: [PATCH v2 17/27] drm/dp_mst: Rename drm_dp_add_port and drm_dp_update_port

2019-09-25 Thread Sean Paul
On Tue, Sep 03, 2019 at 04:45:55PM -0400, Lyude Paul wrote: > The names for these functions are rather confusing. drm_dp_add_port() > sounds like a function that would simply create a port and add it to a > topology, and do nothing more. Similarly, drm_dp_update_port() would be > assumed to be the

4f5368b5541a902f6596558b05f5c21a9770dd32 causes regression

2019-09-25 Thread Oliver Neukum
Hi, I am seeing a hard lockup during boot with this patch. I am using only the laptop's internal display. The last message I see is: kvm: disabled by BIOS Regards Oliver devices are: 00:00.0 Host bridge [0600]: Intel Corporation Xeon E3-1200 v5/E3-1500 v5/6th Gen Core

Re: [PATCH v1 1/4] lib: introduce copy_struct_from_user() helper

2019-09-25 Thread Al Viro
On Wed, Sep 25, 2019 at 11:13:18AM -0700, Linus Torvalds wrote: > On Wed, Sep 25, 2019 at 11:04 AM Al Viro wrote: > > > > IMO it's better to lift reading the first word out of the loop, like this: > > ... > > Do you see any problems with that variant? > > That looks fine to me too. > > It's a

Re: 4f5368b5541a902f6596558b05f5c21a9770dd32 causes regression

2019-09-25 Thread Al Viro
On Wed, Sep 25, 2019 at 09:22:25PM +0200, Oliver Neukum wrote: > Hi, > > I am seeing a hard lockup during boot with this patch. > I am using only the laptop's internal display. > The last message I see is: > > kvm: disabled by BIOS > > Regards > Oliver Shocking as it

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-25 Thread David Hildenbrand
On 25.09.19 20:20, Qian Cai wrote: > On Wed, 2019-09-25 at 19:48 +0200, Michal Hocko wrote: >> On Wed 25-09-19 12:01:02, Qian Cai wrote: >>> On Wed, 2019-09-25 at 09:02 +0200, David Hildenbrand wrote: On 24.09.19 20:54, Qian Cai wrote: > On Tue, 2019-09-24 at 17:11 +0200, Michal Hocko wrot

Re: 4f5368b5541a902f6596558b05f5c21a9770dd32 causes regression

2019-09-25 Thread Daniel Vetter
On Wed, Sep 25, 2019 at 9:37 PM Oliver Neukum wrote: > > Hi, > > I am seeing a hard lockup during boot with this patch. > I am using only the laptop's internal display. > The last message I see is: Should be fixed with commit e0f32f78e51b9989ee89f608fd0dd10e9c230652 (tag: drm-misc-next-fixes-201

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Dexuan Cui > Sent: Friday, September 20, 2019 11:56 PM > To: dmitry.torok...@gmail.com > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; > linux-hyp...@vger.kernel.org; linux-in...@vger.kernel.org; > linux-ker

RE: [PATCH] HID: hyperv: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, September 11, 2019 4:36 PM > > We need mousevsc_pm_notify() to make sure the pm_wakeup_hard_event() > call > does not prevent the system from entering hibernation: the hibernation > is a relatively long process, which can be aborted by the call > pm_wakeup_ha

Re: [PATCH v5 1/1] platform/x86/intel_cht_int33fe: Split code to USB Micro-B and Type-C variants

2019-09-25 Thread Yauhen Kharuzhy
On Wed, Sep 25, 2019 at 08:42:03PM +0300, Andy Shevchenko wrote: > On Wed, Sep 25, 2019 at 7:27 PM Yauhen Kharuzhy wrote: > > On Wed, Sep 25, 2019 at 06:02:22PM +0300, Andy Shevchenko wrote: > > > On Sat, Sep 21, 2019 at 9:31 PM Hans de Goede wrote: > > > > By some reason it doesn't apply. > > >

[PATCH] docs: fix memory.low description in cgroup-v2.rst

2019-09-25 Thread Jon Haslam
The current cgroup-v2.rst file contains an incorrect description of when memory is reclaimed from a cgroup that is using the 'memory.low' mechanism. This fix simply corrects the text to reflect the actual implementation. Fixes: 7854207fe954 ("mm/docs: describe memory.low refinements") Signed-off-b

RE: [PATCH 0/4] Enhance pci-hyperv to support hibernation

2019-09-25 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, September 11, 2019 4:38 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; lorenzo.pieral...@arm.com; > bhelg...@google.com; linux-hyp...@vger.kernel.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Kelle

Re: [PATCH v2 1/2] spi: Add call to spi_slave_abort() function when spidev driver is released

2019-09-25 Thread Lukasz Majewski
Hi Mark, > On Wed, Sep 25, 2019 at 11:11:42AM +0200, Lukasz Majewski wrote: > > This change is necessary for spidev devices (e.g. /dev/spidev3.0) > > working in the slave mode (like NXP's dspi driver for Vybrid SoC). > > Please do not submit new versions of already applied patches, please > sub

[PATCH 1/2] Make _FORTIFY_SOURCE defines dependent on the feature

2019-09-25 Thread Ian Rogers
Unconditionally defining _FORTIFY_SOURCE can break tools that don't work with it, such as memory sanitizers: https://github.com/google/sanitizers/wiki/AddressSanitizer#faq Signed-off-by: Ian Rogers --- tools/lib/subcmd/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff -

[PATCH 2/2] Avoid raising segv using an obvious null dereference

2019-09-25 Thread Ian Rogers
An optimized build such as: make -C tools/perf CLANG=1 CC=clang EXTRA_CFLAGS="-O3 will turn the dereference operation into a ud2 instruction, raising a SIGILL rather than a SIGSEGV. Use raise(..) for correctness and clarity. Similar issues were addressed in Numfor Mbiziwo-Tiapo's patch: https://lk

RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > [... snipped ...] > > Anyhow, just some comments from my side :) I can see how Windows Server > > worked around that issue right now by just XOR'ing both features. > > > > David / dhildenb > > Thanks for sharing your thoughts! > > -- Dexuan Hi David,

Re: acer_wmi: Unknown function(s) on Acer Nitro 5 (AN515-43-R8BF)

2019-09-25 Thread Gabriel C
Am Mi., 25. Sept. 2019 um 09:53 Uhr schrieb Joey Lee : > > Hi Gabriel, > > On Mon, Sep 23, 2019 at 09:45:05PM +0200, Gabriel C wrote: > > Hi guys, > > > > I noticed some warning in dmesg on this Laptop. > > > > Fn+right, Fn+left is BrightnessDown/Up and produce the following warning: > > > > acer_w

[PATCH v2] scsi: storvsc: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
When we're in storvsc_suspend(), we're sure the SCSI layer has quiesced the scsi device by scsi_bus_suspend() -> ... -> scsi_device_quiesce(), so the low level SCSI adapter driver only needs to suspend/resume its own state. Signed-off-by: Dexuan Cui Acked-by: Martin K. Petersen --- This patch

Re: Unmerged patches adding audit when protected_regular/fifos sysctl causes EACCES

2019-09-25 Thread Kees Cook
On Wed, Sep 25, 2019 at 02:58:28PM -0400, Jérémie Galarneau wrote: > Hi Kees, > > I have noticed that the two top-most patches of your protected-creat > branch were never merged upstream [1]. Those patches add audit logs > whenever the protected_regular or protected_fifo sysctl prevent the > creat

Re: [PATCH v2 1/2] rtc: wilco-ec: Remove yday and wday calculations

2019-09-25 Thread Nick Crews
Hi Alexandre, Sorry to be a pain, but I passed this by some other Chrome OS kernel engineers, and when the HW gives a bogus time we want logging at a more severe level than the dev_dbg() call in the core, so I'm going to send another revision. It's going to require duplicated calls to rtc_valid_tm

Re: [PATCH] dmaengine: uniphier-mdmac: use devm_platform_ioremap_resource()

2019-09-25 Thread Vinod Koul
On 05-09-19, 12:41, Masahiro Yamada wrote: > Replace the chain of platform_get_resource() and devm_ioremap_resource() > with devm_platform_ioremap_resource(). > > This allows to remove the local variable for (struct resource *), and > have one function call less. Applied, thanks -- ~Vinod

Re: [PATCH v1 1/4] lib: introduce copy_struct_from_user() helper

2019-09-25 Thread Linus Torvalds
On Wed, Sep 25, 2019 at 12:43 PM Al Viro wrote: > > FWIW, I would probably add a kernel-space analogue of that thing at the > same time - check that an area is all-zeroes is not all that rare. Hmm. Maybe. > Another thing is that for s390 we almost certainly want something better > than word-by-w

Re: Unmerged patches adding audit when protected_regular/fifos sysctl causes EACCES

2019-09-25 Thread Mathieu Desnoyers
- On Sep 25, 2019, at 4:12 PM, Kees Cook keesc...@chromium.org wrote: > On Wed, Sep 25, 2019 at 02:58:28PM -0400, Jérémie Galarneau wrote: >> Hi Kees, >> >> I have noticed that the two top-most patches of your protected-creat >> branch were never merged upstream [1]. Those patches add audit l

[PATCH] proc: change ->nlink under proc_subdir_lock

2019-09-25 Thread Alexey Dobriyan
Currently gluing PDE into global /proc tree is done under lock, but changing ->nlink is not. Additionally struct proc_dir_entry::nlink is not atomic so updates can be lost. Signed-off-by: Alexey Dobriyan --- fs/proc/generic.c | 31 +++ 1 file changed, 15 insertions

Re: [PATCH -next] dmaengine: ti: edma: remove unused code

2019-09-25 Thread Vinod Koul
On 05-09-19, 14:02, YueHaibing wrote: > drivers/dma/ti/edma.c: In function edma_probe: > drivers/dma/ti/edma.c:2252:11: warning: > variable off set but not used [-Wunused-but-set-variable] > > 'off' is not used now, so remove it. Applied, thanks -- ~Vinod

[PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference

2019-09-25 Thread Fabien Parent
Since commit abf4923e97c3 ("i2c: mediatek: disable zero-length transfers for mt8183"), there is a NULL pointer dereference for all the SoCs that don't have any quirk. mtk_i2c_functionality is not checking that the quirks pointer is not NULL before starting to use it. This commit add a check on the

[PATCH] brcmsmac: remove duplicated if condition

2019-09-25 Thread Denis Efremov
The nested 'li_mimo == &locale_bn' check is excessive and always true. Thus it can be safely removed. Signed-off-by: Denis Efremov --- .../net/wireless/broadcom/brcm80211/brcmsmac/channel.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadc

[PATCH v3] rtc: wilco-ec: Handle reading invalid times

2019-09-25 Thread Nick Crews
If the RTC HW returns an invalid time, the rtc_year_days() call would crash. This patch adds error logging in this situation, and removes the tm_yday and tm_wday calculations. These fields should not be relied upon by userspace according to man rtc, and thus we don't need to calculate them. Signed

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-25 Thread Qian Cai
On Wed, 2019-09-25 at 21:48 +0200, David Hildenbrand wrote: > On 25.09.19 20:20, Qian Cai wrote: > > On Wed, 2019-09-25 at 19:48 +0200, Michal Hocko wrote: > > > On Wed 25-09-19 12:01:02, Qian Cai wrote: > > > > On Wed, 2019-09-25 at 09:02 +0200, David Hildenbrand wrote: > > > > > On 24.09.19 20:54

Re: [PATCH v5 1/1] platform/x86/intel_cht_int33fe: Split code to USB Micro-B and Type-C variants

2019-09-25 Thread Andy Shevchenko
On Wed, Sep 25, 2019 at 10:56 PM Yauhen Kharuzhy wrote: > > On Wed, Sep 25, 2019 at 08:42:03PM +0300, Andy Shevchenko wrote: > > On Wed, Sep 25, 2019 at 7:27 PM Yauhen Kharuzhy wrote: > > > On Wed, Sep 25, 2019 at 06:02:22PM +0300, Andy Shevchenko wrote: > > > > On Sat, Sep 21, 2019 at 9:31 PM Ha

[PATCH v3] dt-bindings: at24: convert the binding document to yaml

2019-09-25 Thread Rob Herring
From: Bartosz Golaszewski Convert the binding document for at24 EEPROMs from txt to yaml. The compatible property uses a regex pattern to address all the possible combinations of "vendor,model" strings. Signed-off-by: Bartosz Golaszewski [robh: rework compatible schema, fix missing allOf for $r

Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller

2019-09-25 Thread Vinod Koul
On 05-09-19, 17:37, Colin King wrote: > From: Colin Ian King > > Don't populate the array 'handler' on the stack but instead make it > static const. Makes the object code smaller by 80 bytes. > > Before: >text data bss dec hex filename > 38225 9084 64 4

Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller

2019-09-25 Thread Colin Ian King
On 25/09/2019 21:43, Vinod Koul wrote: > On 05-09-19, 17:37, Colin King wrote: >> From: Colin Ian King >> >> Don't populate the array 'handler' on the stack but instead make it >> static const. Makes the object code smaller by 80 bytes. >> >> Before: >>text data bss dec hex

Re: [PATCH v1 1/4] lib: introduce copy_struct_from_user() helper

2019-09-25 Thread kbuild test robot
Hi Aleksa, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

[PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq()

2019-09-25 Thread Denis Efremov
There is no need to check 'priv->bt_ant_couple_ok' twice in rs_bt_update_lq(). The second check is always true. Thus, the expression can be simplified. Signed-off-by: Denis Efremov --- drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH 15/17] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-25 Thread Andrea Arcangeli
On Wed, Sep 25, 2019 at 01:03:32PM +0200, Christophe de Dinechin wrote: > > > > On 23 Sep 2019, at 11:31, Vitaly Kuznetsov wrote: > > > > Andrea Arcangeli mailto:aarca...@redhat.com>> writes: > > > >> It's enough to check the exit value and issue a direct call to avoid > >> the retpoline for a

Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times

2019-09-25 Thread Dmitry Torokhov
On Wed, Sep 25, 2019 at 1:32 PM Nick Crews wrote: > > If the RTC HW returns an invalid time, the rtc_year_days() > call would crash. This patch adds error logging in this > situation, and removes the tm_yday and tm_wday calculations. > These fields should not be relied upon by userspace > accordin

[PATCH] rtlwifi: Remove excessive check in _rtl_ps_inactive_ps()

2019-09-25 Thread Denis Efremov
There is no need to check "rtlhal->interface == INTF_PCI" twice in _rtl_ps_inactive_ps(). The nested check is always true. Thus, the expression can be simplified. Signed-off-by: Denis Efremov --- drivers/net/wireless/realtek/rtlwifi/ps.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

Re: [PATCH v9 01/15] leds: multicolor: Add sysfs interface definition

2019-09-25 Thread Jacek Anaszewski
Hi Dan, Thank you for the v9. This patch should me melded with 5/15. On 9/25/19 7:46 PM, Dan Murphy wrote: > Add a documentation of LED Multicolor LED class specific > sysfs attributes. > > Add multicolor framework class documentation describing the > usage of the files created. > > Signed-off

Re: [PATCH v6 2/7] Documentation: v4l2_ctrl_new_std_compound

2019-09-25 Thread Ricardo Ribalda Delgado
Hi Jacopo On Wed, Sep 25, 2019 at 10:20 AM Jacopo Mondi wrote: > > Hi Ricardo, > > On Fri, Sep 20, 2019 at 03:51:32PM +0200, Ricardo Ribalda Delgado wrote: > > Function for initializing compound controls with a default value. > > > > Suggested-by: Hans Verkuil > > Signed-off-by: Ricardo Ribalda D

Re: [PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue

2019-09-25 Thread Vinod Koul
On 05-09-19, 22:06, Radhey Shyam Pandey wrote: > From: Nicholas Graumann > > Introduce a function that can calculate residues for IPs that support it: > AXI DMA and CDMA. > > Signed-off-by: Nicholas Graumann > Signed-off-by: Radhey Shyam Pandey > --- > drivers/dma/xilinx/xilinx_dma.c | 75 >

[PATCH] soc: renesas: rcar-sysc: fix memory leak in rcar_sysc_pd_init

2019-09-25 Thread Navid Emamdoost
In rcar_sysc_pd_init when looping over info->areas errors may happen but the error handling path does not clean up the intermediate allocated memories. This patch changes the error handling path in major and a little the loop itself. Inside the loop if an error happens the current pd will be rele

Re: [PATCH v6 1/7] media: v4l2-core: Implement v4l2_ctrl_new_std_compound

2019-09-25 Thread Ricardo Ribalda Delgado
Hi Jacopo Thanks for your review! On Wed, Sep 25, 2019 at 10:18 AM Jacopo Mondi wrote: > > Hi Ricardo, > > On Fri, Sep 20, 2019 at 03:51:31PM +0200, Ricardo Ribalda Delgado wrote: > > Currently compound controls do not have a simple way of initializing its > > values. This results in ofuscated c

Re: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning

2019-09-25 Thread Palmer Dabbelt
On Thu, 19 Sep 2019 23:25:16 PDT (-0700), wangkefeng.w...@huawei.com wrote: As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of pr_warning"), removing pr_warning so all logging messages use a consistent _warn style. Let's do it. Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou

Re: [PATCH v6 4/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA

2019-09-25 Thread Ricardo Ribalda Delgado
Hi Jacopo On Wed, Sep 25, 2019 at 10:32 AM Jacopo Mondi wrote: > > Hi Ricardo, > > On Fri, Sep 20, 2019 at 03:51:34PM +0200, Ricardo Ribalda Delgado wrote: > > From: Ricardo Ribalda Delgado > > > > A struct v4l2_area containing the width and the height of a rectangular > > area. > > > > Reviewed

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Introduce a multicolor class that groups colored LEDs > within a LED node. > > The multi color class groups monochrome LEDs and allows controlling two > aspects of the final combined color: hue and lightness. The former is > controlled via _intensity f

Re: [PATCH v6 7/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

2019-09-25 Thread Ricardo Ribalda Delgado
Hi Jacopo Thanks for the review On Wed, Sep 25, 2019 at 11:24 AM Jacopo Mondi wrote: > > Hi Ricardo, > > On Fri, Sep 20, 2019 at 03:51:37PM +0200, Ricardo Ribalda Delgado wrote: > > From: Ricardo Ribalda Delgado > > > > According to the product brief, the unit cell size is 1120 nanometers^2. >

Re: [PATCH v2] dt-bindings: riscv: Fix CPU schema errors

2019-09-25 Thread Palmer Dabbelt
On Wed, 25 Sep 2019 06:12:52 PDT (-0700), r...@kernel.org wrote: Fix the errors in the RiscV CPU DT schema: Documentation/devicetree/bindings/riscv/cpus.example.dt.yaml: cpu@0: 'timebase-frequency' is a required property Documentation/devicetree/bindings/riscv/cpus.example.dt.yaml: cpu@1: 'tim

Re: [PATCH v9 07/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Introduce the LP5036/30/24/18/12/9 RGB LED driver. > The difference in these parts are the number of > LED outputs where the: > > LP5036 can control 36 LEDs > LP5030 can control 30 LEDs > LP5024 can control 24 LEDs > LP5018 can control 18 LEDs > LP5012

Re: [PATCH v9 08/15] dt: bindings: lp55xx: Be consistent in the document with LED

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Update the document to be consistent in case when using LED. s/LED/"LED"/. > This should be capital throughout the document. > > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++--- > 1 file changed,

[PATCH] staging: rtl8188eu: fix possible null dereference

2019-09-25 Thread Connor Kuehl
Inside a nested 'else' block at the beginning of this function is a call that assigns 'psta' to the return value of 'rtw_get_stainfo()'. If 'rtw_get_stainfo()' returns NULL and the flow of control reaches the 'else if' where 'psta' is dereferenced, then we will dereference a NULL pointer. Fix this

[PATCH v2] hv_sock: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
Add the necessary dummy callbacks for hibernation. Signed-off-by: Dexuan Cui Acked-by: David S. Miller --- In v2: Added David's Acked-by. Removed [net-next] from the Subject. @Sasha, can you please pick this up into the hyper-v tree? net/vmw_vsock/hyperv_transport.c | 20

Re: [PATCH v9 09/15] dt: bindings: lp55xx: Update binding for Multicolor Framework

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Update the DT binding to include the properties to use the > multicolor framework for the devices that use the LP55xx > framework. > > Signed-off-by: Dan Murphy > CC: Tony Lindgren > CC: "Benoît Cousson" > CC: Linus Walleij > CC: Shawn Guo > CC: S

[PATCH] greybus: remove excessive check in gb_connection_hd_cport_quiesce()

2019-09-25 Thread Denis Efremov
Function pointer "hd->driver->cport_quiesce" is already checked at the beginning of gb_connection_hd_cport_quiesce(). Thus, the second check can be removed. Signed-off-by: Denis Efremov --- drivers/greybus/connection.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/greybus/connect

Re: [PATCH] ipv6: Properly check reference count flag before taking reference

2019-09-25 Thread Eric Dumazet
On 9/23/19 8:06 AM, Petr Vorel wrote: > Hi, > >> People are reporting that WireGuard experiences erratic crashes on 5.3, >> and bisected it down to 7d30a7f6424e. Casually flipping through that >> commit I noticed that a flag is checked using `|` instead of `&`, which in >> this current case, me

[PATCH 1/2] KVM: x86: svm: Pass XSAVES to guest if available on host

2019-09-25 Thread Sebastian Andrzej Siewior
In commit 55412b2eda2b7 ("kvm: x86: Add kvm_x86_ops hook that enables XSAVES for guest") XSAVES was enabled on VMX with a few additional tweaks and was always disabled on SVM. Before ZEN XSAVES was not available so it made no difference. With Zen it is possible to expose it to the guest if it

[PATCH 2/2] KVM: x86: Expose CLZERO and XSAVEERPTR to the guest

2019-09-25 Thread Sebastian Andrzej Siewior
I was surprised to see that the guest reported `fxsave_leak' while the host did not. After digging deeper I noticed that the bits are simply masked out during enumeration. The XSAVEERPTR feature is actually a bug fix on AMD which means the kernel can disable a workaround. While here, I've seen that

KVM: x86: Pass additional FPU bits to the guest

2019-09-25 Thread Sebastian Andrzej Siewior
While testing my FPU patches on AMD's ZEN platform I noticed that the XSAVES feature flag was never used in the guest while it was present in the host. Patch #1 seemed to work but I holded on to it because I could explain why the guest did report ´fxsave_leak' while the host did not. It turns out t

[PATCH] udf: prevent memory leak in udf_new_inode

2019-09-25 Thread Navid Emamdoost
In udf_new_inode if either udf_new_block or insert_inode_locked fials the allocated memory for iinfo->i_ext.i_data should be released. Signed-off-by: Navid Emamdoost --- fs/udf/ialloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c index 0adb40718a5d..b8

[PATCH] sched/vtime: Fix guest/system mis-accounting on task switch

2019-09-25 Thread Frederic Weisbecker
vtime_account_system() assumes that the target task to account cputime to is always the current task. This is most often true indeed except on task switch where we call: vtime_common_task_switch(prev) vtime_account_system(prev) Here prev is the scheduling-out task where we

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-25 Thread Andrew Morton
On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: > Several uses of strlcpy and strscpy have had defects because the > last argument of each function is misused or typoed. > > Add macro mechanisms to avoid this defect. > > stracpy (copy a string to a string array) must have a string > array

[RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API

2019-09-25 Thread Rob Herring
As the comment says, this isn't a DT based device. of_dma_configure() is going to stop allowing a NULL DT node, so this needs to be fixed. Not sure exactly what setup besides arch_setup_dma_ops is needed... Cc: Robin Murphy Cc: Julien Grall Cc: Nicolas Saenz Julienne Cc: Oleksandr Andrushchenk

Re: [PATCH v9 13/15] leds: lp55xx: Update the lp55xx to use the multi color framework

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Update the lp5523 to allow the use of the multi color framework. > > Signed-off-by: Dan Murphy > --- > drivers/leds/Kconfig | 1 + > drivers/leds/leds-lp5523.c| 13 ++ > drivers/leds/leds-lp55xx-common.c

[PATCH v4] drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology

2019-09-25 Thread Lyude Paul
Since we're going to be reprobing the entire topology state on resume now using sideband transactions, we need to ensure that we actually have short HPD irqs enabled before calling drm_dp_mst_topology_mgr_resume(). So, do that. Changes since v4: * Fix typo in comments Cc: Juston Li Cc: Imre Deak

[PATCH v5] tpm_crb: fix fTPM on AMD Zen+ CPUs

2019-09-25 Thread ivan . lazeev
From: Ivan Lazeev Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 cmd/rsp buffers are expected to be in the same ACPI region. For Zen+ CPUs BIOS's might report two different regions, some of them also report region sizes inconsistent with values from TPM registers. Memory configura

Re: [PATCH v2] scsi: storvsc: Add the support of hibernation

2019-09-25 Thread kbuild test robot
Hi Dexuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [cannot apply to v5.3 next-20190924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH v3 4/4] mm: remove unnecessary smp_wmb() in __SetPageUptodate()

2019-09-25 Thread Yu Zhao
On Tue, Sep 24, 2019 at 04:50:36PM -0700, Matthew Wilcox wrote: > On Tue, Sep 24, 2019 at 05:24:59PM -0600, Yu Zhao wrote: > > +/* > > + * Only use this function when there is a following write barrier, e.g., > > + * an explicit smp_wmb() and/or the page will be added to page or swap > > + * cache

[PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
The existing netvsc_detach() and netvsc_attach() APIs make it easy to implement the suspend/resume callbacks. Signed-off-by: Dexuan Cui --- This patch is basically a pure Hyper-V specific change. I request this patch should go through Sasha's Hyper-V tree rather than the net tree. Sasha's Hyper

Re: [PATCHv4-next 0/3] Odroid c2 usb fixs rebase on linux-next

2019-09-25 Thread Kevin Hilman
Anand Moon writes: > Some time ago I had tired to enable usb bus 1 for Odroid C2/C1 > but it's look like some more work is needed to u-boot and > usb_phy driver to initialize this port. > > Below patches tries to address the issue regarding usb bus 2 (4 port) > while disable the usb bus 1 on this

[PATCH] net/ncsi: prevent memory leak in ncsi_rsp_handler_gc

2019-09-25 Thread Navid Emamdoost
In ncsi_rsp_handler_gc if allocation for nc->vlan_filter.vids fails the allocated memory for nc->mac_filter.addrs should be released. Signed-off-by: Navid Emamdoost --- net/ncsi/ncsi-rsp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-

Re: [RFC PATCH v3 00/16] Core scheduling v3

2019-09-25 Thread Aubrey Li
On Thu, Sep 26, 2019 at 1:24 AM Tim Chen wrote: > > On 9/24/19 7:40 PM, Aubrey Li wrote: > > On Sat, Sep 7, 2019 at 2:30 AM Tim Chen wrote: > >> +static inline s64 core_sched_imbalance_delta(int src_cpu, int dst_cpu, > >> + int src_sibling, int dst_sibling, > >> +

[PATCH] genetlink: prevent memory leak in netlbl_unlabel_defconf

2019-09-25 Thread Navid Emamdoost
In netlbl_unlabel_defconf if netlbl_domhsh_add_default fails the allocated entry should be released. Signed-off-by: Navid Emamdoost --- net/netlabel/netlabel_unlabeled.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netla

Re: [PATCH 2/2] KVM: x86: Expose CLZERO and XSAVEERPTR to the guest

2019-09-25 Thread Jim Mattson
On Wed, Sep 25, 2019 at 2:37 PM Sebastian Andrzej Siewior wrote: > > I was surprised to see that the guest reported `fxsave_leak' while the > host did not. After digging deeper I noticed that the bits are simply > masked out during enumeration. > The XSAVEERPTR feature is actually a bug fix on AMD

Re: [PATCH 1/2] KVM: x86: svm: Pass XSAVES to guest if available on host

2019-09-25 Thread Jim Mattson
On Wed, Sep 25, 2019 at 2:37 PM Sebastian Andrzej Siewior wrote: > > In commit >55412b2eda2b7 ("kvm: x86: Add kvm_x86_ops hook that enables XSAVES for > guest") > > XSAVES was enabled on VMX with a few additional tweaks and was always > disabled on SVM. Before ZEN XSAVES was not available so

RE: [PATCH v2] scsi: storvsc: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
> From: kbuild test robot > Sent: Wednesday, September 25, 2019 2:55 PM > To: Dexuan Cui > Cc: kbuild-...@01.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; j...@linux.ibm.com; > martin.peter...@oracle.com; linux-hyp...@vger.kernel.org; > linux-s...@vger.kernel.org

[GIT PULL] Kselftest update for Linux 5.4-rc1 (minus kunit)

2019-09-25 Thread Shuah Khan
Hi Linus, Please pull the following Kselftest update for Linux 5.4-rc1 (minus kunit). This Kselftest update for Linux 5.4-rc1 consists of several fixes to existing tests. diff is attached. This pull has just the ksleftest patches I sent in my previous pull request. I dropped the KUnit patches

RE: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation

2019-09-25 Thread Haiyang Zhang
> -Original Message- > From: Dexuan Cui > Sent: Wednesday, September 25, 2019 6:04 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; da...@davemloft.net; > linux-hyp...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Michael Ke

Re: [PATCH v3] KVM: X86: Fix userspace set invalid CR4

2019-09-25 Thread Sean Christopherson
On Wed, Sep 18, 2019 at 05:50:10PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Reported by syzkaller: > > WARNING: CPU: 0 PID: 6544 at > /home/kernel/data/kvm/arch/x86/kvm//vmx/vmx.c:4689 handle_desc+0x37/0x40 > [kvm_intel] > CPU: 0 PID: 6544 Comm: a.out Tainted: G OE

Re: [PATCH] udf: prevent memory leak in udf_new_inode

2019-09-25 Thread Al Viro
On Wed, Sep 25, 2019 at 04:39:03PM -0500, Navid Emamdoost wrote: > In udf_new_inode if either udf_new_block or insert_inode_locked fials > the allocated memory for iinfo->i_ext.i_data should be released. "... because of such-and-such reasons" part appears to be missing. Why should it be released t

Re: [PATCH v3 3/4] mm: don't expose non-hugetlb page to fast gup prematurely

2019-09-25 Thread Yu Zhao
On Wed, Sep 25, 2019 at 10:25:30AM +0200, Peter Zijlstra wrote: > On Tue, Sep 24, 2019 at 05:24:58PM -0600, Yu Zhao wrote: > > We don't want to expose a non-hugetlb page to the fast gup running > > on a remote CPU before all local non-atomic ops on the page flags > > are visible first. > > > > For

<    1   2   3   4   5   6   7   8   >