Hi Jacopo On Wed, Sep 25, 2019 at 10:20 AM Jacopo Mondi <jac...@jmondi.org> wrote: > > Hi Ricardo, > > On Fri, Sep 20, 2019 at 03:51:32PM +0200, Ricardo Ribalda Delgado wrote: > > Function for initializing compound controls with a default value. > > > > Suggested-by: Hans Verkuil <hverk...@xs4all.nl> > > Signed-off-by: Ricardo Ribalda Delgado <rica...@ribalda.com> > > --- > > Documentation/media/kapi/v4l2-controls.rst | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/media/kapi/v4l2-controls.rst > > b/Documentation/media/kapi/v4l2-controls.rst > > index ebe2a55908be..b20800cae3f2 100644 > > --- a/Documentation/media/kapi/v4l2-controls.rst > > +++ b/Documentation/media/kapi/v4l2-controls.rst > > @@ -140,6 +140,15 @@ Menu controls with a driver specific menu are added by > > calling > > const struct v4l2_ctrl_ops *ops, u32 id, s32 max, > > s32 skip_mask, s32 def, const char * const *qmenu); > > > > +Standard compound controls can be added by calling > > Standard compound controls with a driver provided default value can be.. > > Or is it un-necessary to re-state it? >
I think is a bit redundant, nothing stops you from not defining def, if ctrl_fill has the default value for it. > In any case: > Reviewed-by: Jacopo Mondi <jac...@jmondi.org> Thanks > > Thanks > j > > +:c:func:`v4l2_ctrl_new_std_compound`: > > + > > +.. code-block:: c > > + > > + struct v4l2_ctrl *v4l2_ctrl_new_std_compound(struct > > v4l2_ctrl_handler *hdl, > > + const struct v4l2_ctrl_ops *ops, u32 id, > > + const union v4l2_ctrl_ptr p_def); > > + > > Integer menu controls with a driver specific menu can be added by calling > > :c:func:`v4l2_ctrl_new_int_menu`: > > > > -- > > 2.23.0 > > -- Ricardo Ribalda
