Re: linux-next: Tree for Apr 3 (objtool)

2019-04-03 Thread Randy Dunlap
On 4/3/19 1:24 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190402: > on x86_64: arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x909: unreachable instruction obj file is attached. -- ~Randy entry_64.o Description: application/object

[PATCH] iio: adc: Fix MAX9611 spacing

2019-04-03 Thread Fabrizio Castro
Between "config" and "MAX9611" there is a tab, replace it with a space. Signed-off-by: Fabrizio Castro --- drivers/iio/adc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 76db6e5..cc7c621 100644 --- a/drivers/iio

RE: [PATCH 1/2] dt-bindings: rtc: add battery-low-hw-alarm property

2019-04-03 Thread Flavio Suligoi
Hi Alexandre, > Hi, > > On 03/04/2019 16:52:44+0200, Flavio Suligoi wrote: > > Some RTC devices have a battery-low automatic detection circuit. > > The battery-low event is usually reported with: > > > > - a bit change in a RTC status register > > - a hw signaling (generally using an interrupt ge

[PATCH v3] Staging: gasket: Use DIV_ROUND_UP

2019-04-03 Thread Madhumitha Prabakaran
Use DIV_ROUND_UP in-kernel function to make code simple and more understandable. Issue found using Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v3: - Included version no in patch Changes in v2: - Commit log modified --- drivers/staging/gasket/gasket_page_table.c | 5 ++---

Re: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Alexandre Belloni
On 03/04/2019 16:52:45+0200, Flavio Suligoi wrote: > The pcf2127 has an automatic battery-low detection function. > > In case of battery-low event, an interrupt generation through > the pin INTn (active low) can be enabled, setting the flag BLIE > in the register Control_3. > > This function is a

Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled

2019-04-03 Thread Tony Lindgren
* Roger Quadros [190403 14:54]: > Below patch is just to get initial feedback. Is the overall approach of > splitting > into DRA7 vs AM5 dtsi files OK? Yes makes sense to me. And if the devices are on the interconnect but not fully functional, we probably want to set the status = "disabled" only

Re: [PATCH v3 2/2] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-03 Thread Enric Balletbo i Serra
Hi Nick, On 3/4/19 4:05, Nick Crews wrote: > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a standard LED class device at > /sys/class/leds/chromeos::kbd_backlight. This driver is modeled > after the standard Chrome OS keyboard backlight driver at > d

[tip:x86/asm] x86/uaccess: Fix implicit cast of __user pointer

2019-04-03 Thread tip-bot for Jann Horn
Commit-ID: a6cbfbe6677efb5ca47bb7958c2718236c25126e Gitweb: https://git.kernel.org/tip/a6cbfbe6677efb5ca47bb7958c2718236c25126e Author: Jann Horn AuthorDate: Fri, 29 Mar 2019 22:46:52 +0100 Committer: Borislav Petkov CommitDate: Wed, 3 Apr 2019 16:26:17 +0200 x86/uaccess: Fix implicit

Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

2019-04-03 Thread Florian Fainelli
On 4/2/2019 12:01 PM, Guenter Roeck wrote: > Use devm_platform_ioremap_resource to reduce source code size, > improve readability, and reduce the likelyhood of bugs. > > The conversion was done automatically with coccinelle using the > following semantic patch. > [snip] For: > drivers/watch

Re: [patch 15/14] x86/dumpstack/64: Speedup in_exception_stack()

2019-04-03 Thread Josh Poimboeuf
On Wed, Apr 03, 2019 at 10:10:41AM +0200, Peter Zijlstra wrote: > On Wed, Apr 03, 2019 at 10:08:28AM +0200, Peter Zijlstra wrote: > > On Tue, Apr 02, 2019 at 10:51:49AM -0500, Josh Poimboeuf wrote: > > > On Tue, Apr 02, 2019 at 05:48:56PM +0200, Thomas Gleixner wrote: > > > > > With the above "(stk

Re: perf: perf_fuzzer crashes on Pentium 4 systems

2019-04-03 Thread Cyrill Gorcunov
On Wed, Apr 03, 2019 at 10:59:32AM -0400, Vince Weaver wrote: > > so moving this to its own thread. > > There was a two-part question asked. > 1. Can the perf-fuzzer crash a Pentium 4 system > 2. Does anyone care anymore? > > The answer to #1 turns out to be "yes" > I'm not sure abou

[PATCH v2 2/2] clk: sunxi-ng: nkmp: Explain why zero width check is needed

2019-04-03 Thread Jernej Skrabec
Add an explanation why zero width check is needed when generating factor mask using GENMASK() macro. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu_nkmp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c index

[PATCH v2 1/2] clk: sunxi-ng: h6: Allow video & vpu clocks to change parent rate

2019-04-03 Thread Jernej Skrabec
Video related clocks need to set rate as close as possible to the requested one, so they should be able to change parent clock rate. When processing 4K video, VPU clock has to be set to higher rate than it is default parent rate. Because of that, VPU clock should be able to change parent clock rat

[PATCH v2 0/2] clk: sunxi-ng: H6 related clock fixes

2019-04-03 Thread Jernej Skrabec
During linux-next testing on Allwinner H6, I found several issues with clock driver. This patch series fixes them. Patch 1 allows video and vpu related clocks to set parent rate. Patch 2 adds a comment with short explanation why zero width check is needed. Please take a look. Best regards, Jerne

RE: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Flavio Suligoi
Hi Alexandre, > On 03/04/2019 16:52:45+0200, Flavio Suligoi wrote: > > The pcf2127 has an automatic battery-low detection function. > > > > In case of battery-low event, an interrupt generation through > > the pin INTn (active low) can be enabled, setting the flag BLIE > > in the register Control_

Re: [BUG] perf: intel_pt won't display kernel function

2019-04-03 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 03, 2019 at 11:53:53AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Apr 03, 2019 at 04:37:38PM +0200, Jiri Olsa escreveu: > > hi, > > perf script --call-trace stop working for me recently, > > and displays only user space functions > > > > I bisected that to: > > 7b612e291a5a

[PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk

2019-04-03 Thread Madhumitha Prabakaran
Use DIV_ROUND_UP to make code simple and more understandable. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 4b26ec896a96..b12

Re: linux-next: Tree for Apr 3 (acpi_dev_get_first_match*)

2019-04-03 Thread Randy Dunlap
On 4/3/19 1:24 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190402: > on i386 or x86_64: The patch(es) that change acpi_dev_get_first_match_name() to acpi_dev_get_first_match_dev() have a problem when CONFIG_ACPI is not set/enabled. ../drivers/gpio/gpio-merrifield.c: In function

[RFC PATCH] arm64: irqflags: fix incomplete save & restore

2019-04-03 Thread Wei Li
To support the arm64 pseudo nmi, function arch_local_irq_save() and arch_local_irq_restore() now operate ICC_PMR_EL1 insead of daif. But i found the logic of the save and restore may be suspicious: arch_local_irq_save(): daif.i_on pmr_on -> flag.i_on 1 0

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-04-03 Thread liwei (GF)
Hi Julien, On 2019/4/2 22:00, Julien Thierry wrote: I meet this issue by coincidence before too. > I finally found out what happens. > > When using interrupt priority masking, at the begining of > gic_handle_irq(), we are in this awkward state where we still have the I > bit set and PMR unmasked

Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set

2019-04-03 Thread Matthew Wilcox
On Tue, Apr 02, 2019 at 09:54:50AM +0700, Nick Desaulniers wrote: > Looks like the format is: > Fixes: ("") > so: > Fixes: 8c3d220cb6b5 ("gcov: clang support") > > We should update: > https://www.kernel.org/doc/html/v5.0/process/stable-kernel-rules.html > to include this information. It's in Doc

Re: [PATCH] kernel/sysctl.c: fix out of bounds access in fs.file-max

2019-04-03 Thread Matteo Croce
On Wed, Apr 3, 2019 at 4:02 PM Christian Brauner wrote: > > On Thu, Mar 28, 2019 at 02:03:06PM +0100, Matteo Croce wrote: > > fs.file-max sysctl uses proc_doulongvec_minmax() as proc handler, which > > accesses *extra1 and *extra2 as unsigned long, but commit 32a5ad9c2285 > > ("sysctl: handle over

[PATCH] x86/perf/amd: Fix build failure when CONFIG_HAVE_NMI_WATCHDOG is not set

2019-04-03 Thread Lendacky, Thomas
When CONFIG_HAVE_NMI_WATCHDOG is not set, the asm/nmi.h file is not included. The asm/nmi.h file contains the definitions for NMI_HANDLED and NMI_DONE which are used in arch/x86/events/amd/core.c. This causes the build the fail. Fix the issue by changing the include in arch/x86/events/amd/core.c f

[PATCH] PM / devfreq: return PTR_ERR not NULL in try_then_request_governor()

2019-04-03 Thread Steven Price
The callers of try_then_request_governor() only test for a PTR_ERR using IS_ERR(). However in the case that request_module() fails then NULL is currently returned which will cause a NULL-pointer dereference in the caller. Instead convert the error we already have to a valid PTR_ERR and return it.

Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set

2019-04-03 Thread Matthew Wilcox
On Tue, Apr 02, 2019 at 10:09:56AM +0700, tr...@android.com wrote: > From: Tri Vo > > Fixes: 8c3d220cb6b5 ("gcov: clang support") I think this is the wrong fix. Why not simply: +++ b/include/linux/module.h @@ -709,6 +709,11 @@ static inline bool is_module_text_address(unsigned long addr)

Re: [PATCH v3.1] selftests: Clean up module testing shell script

2019-04-03 Thread Kees Cook
On Tue, Apr 2, 2019 at 5:24 PM Tobin C. Harding wrote: > > On Tue, Apr 02, 2019 at 03:26:10PM -0700, Kees Cook wrote: > > This adjusts kselftest_module.sh to take an option "args" argument for > > modprobe arguments, removes bash-isms (since some system's /bin/sh may > > not be bash), and refactor

[PATCH net-next] MIPS: generic: Add switchdev, pinctrl and fit to ocelot_defconfig

2019-04-03 Thread Horatiu Vultur
Some of the configuration were not selected by default anymore, therefore enable them again. Also remove some configs which are used for MSCC Ocelot. Signed-off-by: Horatiu Vultur --- arch/mips/configs/generic/board-ocelot.config | 19 +++ 1 file changed, 19 insertions(+) diff -

Re: [PATCH 1/2] dt-bindings: rtc: add battery-low-hw-alarm property

2019-04-03 Thread Alexandre Belloni
On 03/04/2019 15:06:17+, Flavio Suligoi wrote: > Hi Alexandre, > > > Hi, > > > > On 03/04/2019 16:52:44+0200, Flavio Suligoi wrote: > > > Some RTC devices have a battery-low automatic detection circuit. > > > The battery-low event is usually reported with: > > > > > > - a bit change in a RTC

Re: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Alexandre Belloni
On 03/04/2019 15:14:24+, Flavio Suligoi wrote: > Hi Alexandre, > > > On 03/04/2019 16:52:45+0200, Flavio Suligoi wrote: > > > The pcf2127 has an automatic battery-low detection function. > > > > > > In case of battery-low event, an interrupt generation through > > > the pin INTn (active low) c

RE: [PATCH 1/2] dt-bindings: rtc: add battery-low-hw-alarm property

2019-04-03 Thread Flavio Suligoi
Hi, > On 03/04/2019 15:06:17+, Flavio Suligoi wrote: > > Hi Alexandre, > > > > > Hi, > > > > > > On 03/04/2019 16:52:44+0200, Flavio Suligoi wrote: > > > > Some RTC devices have a battery-low automatic detection circuit. > > > > The battery-low event is usually reported with: > > > > > > > >

Re: [PATCH-tip v3 06/11] locking/rwsem: Enhance DEBUG_RWSEMS_WARN_ON() macro

2019-04-03 Thread Waiman Long
On 04/03/2019 09:09 AM, Peter Zijlstra wrote: > On Thu, Feb 28, 2019 at 02:09:36PM -0500, Waiman Long wrote: >> diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h >> index 1d8f722..c8fd3f1 100644 >> --- a/kernel/locking/rwsem.h >> +++ b/kernel/locking/rwsem.h >> @@ -27,9 +27,13 @@ >> #de

[PATCH] kernel/sysctl.c: Fix out-of-bounds access when setting file-max

2019-04-03 Thread Will Deacon
Commit 32a5ad9c2285 ("sysctl: handle overflow for file-max") hooked up min/max values for the file-max sysctl parameter via the .extra1 and .extra2 fields in the corresponding struct ctl_table entry. Unfortunately, the minimum value points at the global 'zero' variable, which is an int. This resul

Re: [PATCH-tip v3 11/11] locking/rwsem: Optimize rwsem structure for uncontended lock acquisition

2019-04-03 Thread Waiman Long
On 04/03/2019 09:12 AM, Peter Zijlstra wrote: > On Thu, Feb 28, 2019 at 02:09:41PM -0500, Waiman Long wrote: >> For an uncontended rwsem, count and owner are the only fields a task >> needs to touch when acquiring the rwsem. So they are put next to each >> other to increase the chance that they wil

[PATCH V3] mmc: tegra: add sdhci tegra suspend and resume

2019-04-03 Thread Sowjanya Komatineni
This patch adds suspend and resume PM ops for tegra SDHCI. Acked-by: Thierry Reding Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 56 +- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c

Re: [PATCH] kernel/sysctl.c: Fix out-of-bounds access when setting file-max

2019-04-03 Thread Christian Brauner
On Wed, Apr 03, 2019 at 04:34:09PM +0100, Will Deacon wrote: > Commit 32a5ad9c2285 ("sysctl: handle overflow for file-max") hooked > up min/max values for the file-max sysctl parameter via the .extra1 > and .extra2 fields in the corresponding struct ctl_table entry. > > Unfortunately, the minimum

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Alex Kogan
Peter, Longman, many thanks for your detailed comments! A few follow-up questions are inlined below. > On Apr 2, 2019, at 5:43 AM, Peter Zijlstra wrote: > > On Mon, Apr 01, 2019 at 10:36:19AM -0400, Waiman Long wrote: >> On 03/29/2019 11:20 AM, Alex Kogan wrote: >>> +config NUMA_AWARE_SPINLOCKS

Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

2019-04-03 Thread Christopher Lameter
On Wed, 3 Apr 2019, Tobin C. Harding wrote: > Currently we reach inside the list_head. This is a violation of the > layer of abstraction provided by the list_head. It makes the code > fragile. More importantly it makes the code wicked hard to understand. Great It definitely makes it cleare

Re: [PATCH v5 1/7] list: Add function list_rotate_to_front()

2019-04-03 Thread Christopher Lameter
On Wed, 3 Apr 2019, Tobin C. Harding wrote: > Add function list_rotate_to_front() to rotate a list until the specified > item is at the front of the list. Reviewed-by: Christoph Lameter

Re: [PATCH v5 3/7] slob: Use slab_list instead of lru

2019-04-03 Thread Christopher Lameter
Acked-by: Christoph Lameter

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Waiman Long
On 04/03/2019 11:39 AM, Alex Kogan wrote: > Peter, Longman, many thanks for your detailed comments! > > A few follow-up questions are inlined below. > >> On Apr 2, 2019, at 5:43 AM, Peter Zijlstra wrote: >> >> On Mon, Apr 01, 2019 at 10:36:19AM -0400, Waiman Long wrote: >>> On 03/29/2019 11:20 AM,

Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

2019-04-03 Thread Bart Van Assche
On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote: > On Tue, Mar 26, 2019 at 12:59:12PM -0700, Bart Van Assche wrote: > > Commit a0b0fd53e1e6 ("locking/lockdep: Free lock classes that are no longer > > in use") changed the behavior of lockdep_free_key_range() from > > unconditionally zapping loc

RE: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Flavio Suligoi
> > > On 03/04/2019 16:52:45+0200, Flavio Suligoi wrote: > > > > The pcf2127 has an automatic battery-low detection function. > > > > > > > > In case of battery-low event, an interrupt generation through > > > > the pin INTn (active low) can be enabled, setting the flag BLIE > > > > in the register

Re: [PATCH v5 6/7] slab: Use slab_list instead of lru

2019-04-03 Thread Christopher Lameter
Acked-by: Christoph Lameter

Re: [PATCH v2 1/4] ARM: davinci: fix cpufreq registration on da850-evm

2019-04-03 Thread Adam Ford
On Wed, Apr 3, 2019 at 7:50 AM Bartosz Golaszewski wrote: > > śr., 27 mar 2019 o 12:14 Sekhar Nori napisał(a): > > > > Hi Bart, > > > > On 26/03/19 11:21 PM, Bartosz Golaszewski wrote: > > > wt., 26 mar 2019 o 15:00 Adam Ford napisał(a): > > >> > > >> On Fri, Mar 22, 2019 at 8:31 AM Bartosz Gola

[PATCH v4 1/4] drm/vc4: Reformat and export binner bo allocation helper

2019-04-03 Thread Paul Kocialkowski
Since we'll be using the binner bo allocation helper in other parts of the driver, reformat it with a vc4_v3d prefix and pass the vc4 dev directly to match other functions. Make the function visible to the whole driver too. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_v3d.c | 11

[PATCH v4 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-03 Thread Paul Kocialkowski
Since the OOM interrupt directly deals with the binner bo, it doesn't make sense to try and handle it without a binner buffer registered. The interrupt will kick again in due time, so we can safely ignore it without a binner bo allocated. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/

[PATCH v4 0/4] drm/vc4: Binner BO management improvements

2019-04-03 Thread Paul Kocialkowski
Changes since v3: * Split changes into more commits when possible; * Reworked binner bo alloc condition as discussed. Changes since v2: * Removed deprecated sentence about fristopen; * Added collected Reviewed-By tags. Changes since v1: * Squashed the two final patches into one. Paul Kocialkowsk

[PATCH v4 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-04-03 Thread Paul Kocialkowski
The binner bo is not required until the V3D is in use, so avoid allocating it at probe and do it on the first non-dumb BO allocation. Keep track of which clients are using the V3D and liberate the buffer when there is none left. We also want to keep it alive during runtime suspend/resume to avoid

Re: [PATCH] kernel/sysctl.c: fix out of bounds access in fs.file-max

2019-04-03 Thread Matthew Wilcox
On Wed, Apr 03, 2019 at 05:24:26PM +0200, Matteo Croce wrote: > On Wed, Apr 3, 2019 at 4:02 PM Christian Brauner wrote: > > Yeah, maybe but it still feels cleaner and more obvious to just add: > > > > static long long_zero; > > > > given that most callers actually seem to want an (unsigned) int. >

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-04-03 Thread Jens Axboe
On 4/3/19 9:49 AM, Will Deacon wrote: > On Wed, Apr 03, 2019 at 09:39:52AM -0600, Jens Axboe wrote: >> On 4/3/19 9:19 AM, Will Deacon wrote: >>> On Wed, Apr 03, 2019 at 07:49:26AM -0600, Jens Axboe wrote: On 4/3/19 5:11 AM, Will Deacon wrote: > will@autoplooker:~/liburing/test$ ./io_uring_

[PATCH v2 08/12] Documentation: PCI: convert PCI/pcieaer-howto.txt to reST format

2019-04-03 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/PCI/index.rst | 1 + .../{pcieaer-howto.txt => pcieaer-howto.rst} | 110 -- 2 files

[PATCH v2 09/12] Documentation: PCI: convert PCI/endpoint/pci-endpoint.txt to reST format

2019-04-03 Thread Changbin Du
This converts the plain text documentation to reStructuredText format and add it to Sphinx TOC tree. No essential content change. Signed-off-by: Changbin Du --- Documentation/PCI/endpoint/index.rst | 10 ++ .../{pci-endpoint.txt => pci-endpoint.rst}| 95 +++ Document

Re: Issues with i.MX SPI DMA transfers

2019-04-03 Thread Igor Plyatov
Dear Robin, Please apply the attached patch which is based on linux-next commit 05d08e2995cbe6efdb993482ee0d38a77040861a. Please notice it has already contained two sdma patches revert - "ad0d92d7ba6a" and "25aaa75df1e6" 1) Yours source code is same as mine with exception of SDMA descriptio

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Alex Kogan
> On Apr 1, 2019, at 5:33 AM, Peter Zijlstra wrote: > > On Mon, Apr 01, 2019 at 11:06:53AM +0200, Peter Zijlstra wrote: >> On Fri, Mar 29, 2019 at 11:20:04AM -0400, Alex Kogan wrote: >>> diff --git a/kernel/locking/mcs_spinlock.h b/kernel/locking/mcs_spinlock.h >>> index bc6d3244e1af..71ee4b64c

Re: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Alexandre Belloni
On 03/04/2019 15:49:03+, Flavio Suligoi wrote: > > Then, you should probably not enable BLIE because this will cause issues > > with the alarm functionnality.. It is certainly enough to use > > RTC_VL_READ periodically. > > We use the nINT signaling solution because of this pin, in addition >

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Peter Zijlstra
On Wed, Apr 03, 2019 at 11:39:09AM -0400, Alex Kogan wrote: > >> The patch that I am looking for is to have a separate > >> numa_queued_spinlock_slowpath() that coexists with > >> native_queued_spinlock_slowpath() and > >> paravirt_queued_spinlock_slowpath(). At boot time, we select the most > >>

[PATCH 0/7] fix possible object reference leaks in drivers/gpu

2019-04-03 Thread Wen Yang
The call to of_get_cpu_node/of_find_compatible_node/of_parse_phandle... returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. This patch series fix those possible object reference leaks in drivers/gpu. Wen Yang (7): drm/mediatek: fix possi

[PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Madhumitha Prabakaran
Remove unwanted parentheses around right hand side of an assignment to make code better and more understandable. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtlwifi/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-03 Thread Douglas Anderson
The software running on the Chrome OS Embedded Controller (cros_ec) handles SPI transfers in a bit of a wonky way. Specifically if the EC sees too long of a delay in a SPI transfer it will give up and the transfer will be counted as failed. Unfortunately the timeout is fairly short, though the ac

Re: [PATCH 6/6] arm64/mm: Enable ZONE_DEVICE

2019-04-03 Thread Jerome Glisse
On Wed, Apr 03, 2019 at 02:58:28PM +0100, Robin Murphy wrote: > [ +Dan, Jerome ] > > On 03/04/2019 05:30, Anshuman Khandual wrote: > > Arch implementation for functions which create or destroy vmemmap mapping > > (vmemmap_populate, vmemmap_free) can comprehend and allocate from inside > > device m

Re: [PATCH 00/12] locking/rwsem: Rwsem rearchitecture part 2

2019-04-03 Thread Waiman Long
On 04/03/2019 08:59 AM, Peter Zijlstra wrote: > On Thu, Mar 28, 2019 at 02:10:54PM -0400, Waiman Long wrote: >> This is part 2 of a 3-part (0/1/2) series to rearchitect the internal >> operation of rwsem. >> >> part 0: https://lkml.org/lkml/2019/3/22/1662 >> part 1: https://lkml.org/lkml/2019/2/28/

RE: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Flavio Suligoi
Hi, > On 03/04/2019 15:49:03+, Flavio Suligoi wrote: > > > Then, you should probably not enable BLIE because this will cause > issues > > > with the alarm functionnality.. It is certainly enough to use > > > RTC_VL_READ periodically. > > > > We use the nINT signaling solution because of this p

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Peter Zijlstra
On Wed, Apr 03, 2019 at 11:53:53AM -0400, Alex Kogan wrote: > > One thing we could maybe do is change locked and count to u8, then your > > overlay structure could be something like: > > > > struct mcs_spinlock { > > struct mcs_spinlock *next; > > u8 locked; > > u8 count; > > }; > I w

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-03 Thread Matthias Kaehlcke
On Wed, Apr 03, 2019 at 11:53:26AM +0530, Balakrishna Godavarthi wrote: > + Harish to update his findings on wcn3998. > Mean time i will perform a regression to detect the failure. On my system it typically reproduces within a few dozen iterations. Make sure your tree doesn't contain any custom BT

Re: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Alexandre Belloni
On 03/04/2019 16:09:14+, Flavio Suligoi wrote: > Hi, > > > On 03/04/2019 15:49:03+, Flavio Suligoi wrote: > > > > Then, you should probably not enable BLIE because this will cause > > issues > > > > with the alarm functionnality.. It is certainly enough to use > > > > RTC_VL_READ periodica

WARN_ON: userstacktrace on irq events

2019-04-03 Thread Steven Rostedt
Juri reported this from the -rt kernel, but I can easily trigger it in mainline. By simply doing: # cd /sys/kernel/tracing # echo 1 > options/userstacktrace # echo 1 > events/irq/enable With CONFIG_DEBUG_ATOMIC_SLEEP enabled, we get a WARNING splat of: WARNING: CPU: 1 PID: 1688 at arch/x86/ke

Re: [PATCH AUTOSEL 4.19 40/57] kvm: properly check debugfs dentry before using it

2019-04-03 Thread Sasha Levin
On Sat, Mar 30, 2019 at 06:43:50AM +0100, Greg Kroah-Hartman wrote: On Fri, Mar 29, 2019 at 09:28:33PM -0400, Sasha Levin wrote: From: Greg Kroah-Hartman [ Upstream commit 8ed0579c12b2fe56a1fac2f712f58fc26c1dc49b ] debugfs can now report an error code if something went wrong instead of just N

Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Dan Carpenter
On Wed, Apr 03, 2019 at 11:04:45AM -0500, Madhumitha Prabakaran wrote: > Remove unwanted parentheses around right hand side of an assignment to > make code better and more understandable. > > Issue found by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/rtlwifi/cor

Re: [PATCH AUTOSEL 4.9 20/87] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-04-03 Thread Sasha Levin
On Thu, Mar 28, 2019 at 12:04:17PM -0400, Steven Rostedt wrote: On Thu, 28 Mar 2019 15:37:49 + Slavomir Kaslev wrote: On Wed, 2019-03-27 at 14:19 -0400, Sasha Levin wrote: > From: Slavomir Kaslev > > [ Upstream commit ee5e001196d1345b8fee25925ff5f1d67936081e ] > > The current implementati

RE: [PATCH 2/2] rtc: pcf2127: add battery-low INTn generation

2019-04-03 Thread Flavio Suligoi
> On 03/04/2019 16:09:14+, Flavio Suligoi wrote: > > Hi, > > > > > On 03/04/2019 15:49:03+, Flavio Suligoi wrote: > > > > > Then, you should probably not enable BLIE because this will cause > > > issues > > > > > with the alarm functionnality.. It is certainly enough to use > > > > > RTC_VL

Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Dan Carpenter
On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > data_bit = (data & BIT(i)) ? 1 : 0; I quite like the !! idiom also... data_bit = !!(data & BIT(i)); regards, dan carpenter

[PATCH 3/4] ARM: dts: atmel boards: use SPDX-License-Identifier

2019-04-03 Thread Alexandre Belloni
The X11 license text [1] is explicitly for the X Consortium and has a couple of extra clauses. The MIT license text [2] is actually what the current DT files claim. [1] https://spdx.org/licenses/X11.html [2] https://spdx.org/licenses/MIT.html Signed-off-by: Alexandre Belloni --- arch/arm/boot/d

[PATCH 1/4] ARM: dts: sama5d{2,4}: use SPDX-License-Identifier

2019-04-03 Thread Alexandre Belloni
The X11 license text [1] is explicitly for the X Consortium and has a couple of extra clauses. The MIT license text [2] is actually what the current DT files claim. [1] https://spdx.org/licenses/X11.html [2] https://spdx.org/licenses/MIT.html Signed-off-by: Alexandre Belloni --- arch/arm/boot/d

[PATCH 2/4] ARM: dts: at91sam9xe: use SPDX-License-Identifier

2019-04-03 Thread Alexandre Belloni
The X11 license text [1] is explicitly for the X Consortium and has a couple of extra clauses. The MIT license text [2] is actually what the current DT files claim. [1] https://spdx.org/licenses/X11.html [2] https://spdx.org/licenses/MIT.html Signed-off-by: Alexandre Belloni --- arch/arm/boot/d

[PATCH 4/4] ARM: dts: at91-vinco: use SPDX-License-Identifier

2019-04-03 Thread Alexandre Belloni
The X11 license text [1] is explicitly for the X Consortium and has a couple of extra clauses. The MIT license text [2] is actually what the current DT files claim. [1] https://spdx.org/licenses/X11.html [2] https://spdx.org/licenses/MIT.html Signed-off-by: Alexandre Belloni --- arch/arm/boot/d

Re: [PATCH] platform/chrome: cros_ec_debugfs: Remove dev_warn when console log is not supported

2019-04-03 Thread Guenter Roeck
On Wed, Apr 3, 2019 at 6:47 AM Enric Balletbo i Serra wrote: > > If the debugfs interface is enabled, every time a CrOS device is > instantiated a warning like this can appear for every probed device. > > "device does not support reading the console log" > > The warning message adds nothing, rath

Re: [GIT PULL] HID fixes

2019-04-03 Thread pr-tracker-bot
The pull request you sent on Wed, 3 Apr 2019 15:39:18 +0200 (CEST): > git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8ed86627f715eacbd6db6862f9499d6d96ea4ad6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] platform/chrome: cros_ec_proto: Also return invalid command in cros_ec_cmd_xfer_status

2019-04-03 Thread Guenter Roeck
On Wed, Apr 3, 2019 at 6:51 AM Enric Balletbo i Serra wrote: > > The commit 9798ac6d32c1 ("mfd: cros_ec: Add cros_ec_cmd_xfer_status() > helper") was introduced to remove duplicated code in several users of > the cros_ec_cmd_xfer function. The idea behind that commit is mask all > the EC errors as

Re: [PATCH tip/core/rcu 2/2] rcu: Check for wakeup-safe conditions in rcu_read_unlock_special()

2019-04-03 Thread Paul E. McKenney
On Wed, Apr 03, 2019 at 11:50:46AM +0200, Peter Zijlstra wrote: > On Tue, Apr 02, 2019 at 06:18:53AM -0700, Paul E. McKenney wrote: > > On Tue, Apr 02, 2019 at 09:09:53AM +0200, Peter Zijlstra wrote: > > > On Mon, Apr 01, 2019 at 10:22:57AM -0700, Paul E. McKenney wrote: > > > > > Or am I missing

Re: [patch 15/14] x86/dumpstack/64: Speedup in_exception_stack()

2019-04-03 Thread Thomas Gleixner
On Tue, 2 Apr 2019, Andy Lutomirski wrote: > > On Apr 2, 2019, at 1:29 PM, Thomas Gleixner wrote: > >>> How about a much better fix: make the DB stack be the same size as all > >>> the others and just have 4 of them (DB0, DB1, DB2, and DB3. After all, > >>> overflowing from one debug stack into a

Re: [PATCH AUTOSEL 5.0 107/262] ASoC: qcom: Fix of-node refcount unbalance in apq8016_sbc_parse_of()

2019-04-03 Thread Sasha Levin
On Wed, Mar 27, 2019 at 07:31:15PM +, Mark Brown wrote: On Wed, Mar 27, 2019 at 01:59:22PM -0400, Sasha Levin wrote: From: Takashi Iwai [ Upstream commit 8d1667200850f8753c0265fa4bd25c9a6e5f94ce ] The apq8016 driver leaves the of-node refcount at aborting from the loop of for_each_child_o

Re: [BUG] perf: intel_pt won't display kernel function

2019-04-03 Thread Song Liu
> On Apr 3, 2019, at 8:15 AM, Arnaldo Carvalho de Melo > wrote: > > Em Wed, Apr 03, 2019 at 11:53:53AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Apr 03, 2019 at 04:37:38PM +0200, Jiri Olsa escreveu: >>> hi, >>> perf script --call-trace stop working for me recently, >>> and displays

Re: [PATCHv1] fpga: mgr: add FPGA configuration log

2019-04-03 Thread Alan Tull
On Wed, Apr 3, 2019 at 9:20 AM Moritz Fischer wrote: > > Hi Richard, > > On Tue, Apr 02, 2019 at 05:25:43PM -0500, richard.g...@linux.intel.com wrote: > > From: Richard Gong > > > > Add a log for user to know FPGA configuration is successful > > > > Signed-off-by: Richard Gong > > --- > > drive

Re: [RFC PATCH] arm64: irqflags: fix incomplete save & restore

2019-04-03 Thread Julien Thierry
Hi Wei, Thanks for looking into this. On 03/04/2019 16:28, Wei Li wrote: > To support the arm64 pseudo nmi, function arch_local_irq_save() and > arch_local_irq_restore() now operate ICC_PMR_EL1 insead of daif. > But i found the logic of the save and restore may be suspicious: > > arch_local_irq_

Re: [patch 00/14] x86/exceptions: Add guard patches to IST stacks

2019-04-03 Thread Thomas Gleixner
On Sun, 31 Mar 2019, Andy Lutomirski wrote: > On Sun, Mar 31, 2019 at 3:10 PM Thomas Gleixner wrote: > > While looking for something different I stumbled over the comment in struct > > cpu_entry_area: > > > > * Exception stacks used for IST entries. > > * > > * In the fu

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

2019-04-03 Thread Matthias Kaehlcke
On Tue, Apr 02, 2019 at 11:05:01AM -0700, Matthias Kaehlcke wrote: > On Tue, Apr 02, 2019 at 05:32:54PM +0530, Balakrishna Godavarthi wrote: > > Hi Matthias, > > > > On 2019-04-01 22:42, Matthias Kaehlcke wrote: > > > On Mon, Apr 01, 2019 at 01:48:23PM +0530, Balakrishna Godavarthi wrote: > > > >

Re: [PATCH] gpio: omap: avoid clang warning

2019-04-03 Thread Linus Walleij
On Thu, Mar 7, 2019 at 5:33 PM Arnd Bergmann wrote: > clang warns about a tentative array definition in the gpio-omap driver: > > drivers/gpio/gpio-omap.c:1282:34: error: tentative array definition assumed > to have one element [-Werror] > static const struct of_device_id omap_gpio_match[]; > >

Re: [PATCHv1] fpga: mgr: add FPGA configuration log

2019-04-03 Thread Richard Gong
Hi Moritz, On 4/3/19 9:20 AM, Moritz Fischer wrote: Hi Richard, On Tue, Apr 02, 2019 at 05:25:43PM -0500, richard.g...@linux.intel.com wrote: From: Richard Gong Add a log for user to know FPGA configuration is successful Signed-off-by: Richard Gong --- drivers/fpga/fpga-mgr.c | 1 + 1

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Waiman Long
On 04/02/2019 05:43 AM, Peter Zijlstra wrote: > On Mon, Apr 01, 2019 at 10:36:19AM -0400, Waiman Long wrote: >> On 03/29/2019 11:20 AM, Alex Kogan wrote: >>> +config NUMA_AWARE_SPINLOCKS >>> + bool "Numa-aware spinlocks" >>> + depends on NUMA >>> + default y >>> + help >>> + Introduce N

Re: [PATCH v2 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

2019-04-03 Thread Guenter Roeck
On Wed, Apr 3, 2019 at 7:05 AM Enric Balletbo i Serra wrote: > > Add the cros-usbpd-logger driver for logging event data for the USB PD > charger available in the Embedded Controller on ChromeOS systems. The > logging feature is logically separate functionality from charge manager, > hence is inst

Re: [patch 04/14] x86/exceptions: Make IST index zero based

2019-04-03 Thread Borislav Petkov
On Sun, Mar 31, 2019 at 11:40:24PM +0200, Thomas Gleixner wrote: > The defines for the exception stack (IST) array in the TSS are using the > SDM convention IST1 - IST7. That causes all sorts of code to subtract 1 for > array indices related to IST. That's confusing at best and does not provide > a

Re: [PATCH v2] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-03 Thread Enric Balletbo i Serra
Hi Rushikesh, Thanks for sending this upstream, some comments below. On 3/4/19 10:52, Rushikesh S Kadam wrote: > Add ChromeOS EC ISHTP driver. > Could you explain a bit more about what ISHTP is? I suppose is a protocol to communicate with the Integrated Sensor Driver, but would be good have a b

Re: [PATCH] slab: store tagged freelist for off-slab slabmgmt

2019-04-03 Thread Andrey Konovalov
On Wed, Apr 3, 2019 at 3:07 PM Qian Cai wrote: > > On Wed, 2019-04-03 at 13:23 +0200, Andrey Konovalov wrote: > > On Wed, Apr 3, 2019 at 4:29 AM Qian Cai wrote: > > > > > > The commit 51dedad06b5f ("kasan, slab: make freelist stored without > > > tags") calls kasan_reset_tag() for off-slab slab m

Re: [PATCH] kernel/sysctl.c: fix out of bounds access in fs.file-max

2019-04-03 Thread Matteo Croce
On Wed, Apr 3, 2019 at 5:51 PM Matthew Wilcox wrote: > > On Wed, Apr 03, 2019 at 05:24:26PM +0200, Matteo Croce wrote: > > On Wed, Apr 3, 2019 at 4:02 PM Christian Brauner > > wrote: > > > Yeah, maybe but it still feels cleaner and more obvious to just add: > > > > > > static long long_zero; > >

[PATCH 09/27] x86/fpu: Add (__)make_fpregs_active helpers

2019-04-03 Thread Sebastian Andrzej Siewior
From: Rik van Riel Add helper function that ensures the floating point registers for the current task are active. Use with preemption disabled. Signed-off-by: Rik van Riel Signed-off-by: Sebastian Andrzej Siewior --- arch/x86/include/asm/fpu/api.h | 11 +++ arch/x86/include/asm/f

[PATCH 27/27] x86/pkeys: add PKRU value to init_fpstate

2019-04-03 Thread Sebastian Andrzej Siewior
The task's initiall PKRU value is set part for fpu__clear()/ copy_init_pkru_to_fpregs(). It is not part of init_fpstate.xsave and instead it is set explictly. If the user removes the PKRU state from XSAVE in the signal handler then __fpu__restore_sig() will restore the missing bits from `init_fpsta

[PATCH 15/27] x86/fpu: Eager switch PKRU state

2019-04-03 Thread Sebastian Andrzej Siewior
From: Rik van Riel While most of a task's FPU state is only needed in user space, the protection keys need to be in place immediately after a context switch. The reason is that any access to userspace memory while running in kernel mode also need to abide by the memory permissions specified in t

[PATCH 24/27] x86/fpu: Add a fastpath to __fpu__restore_sig()

2019-04-03 Thread Sebastian Andrzej Siewior
The previous commits refactor the restoration of the FPU registers so that they can be loaded from in-kernel memory. This overhead can be avoided if the load can be performed without a pagefault. Attempt to restore FPU registers by invoking copy_user_to_fpregs_zeroing(). If it fails try the slowpa

[PATCH 26/27] x86/fpu: Restore FPU register in copy_fpstate_to_sigframe() in order to use the fastpath

2019-04-03 Thread Sebastian Andrzej Siewior
If a task is scheduled out and receives a signal then it won't be able to take the fastpath because the register aren't available. The slowpath is more expensive compared to xrstor + xsave which usually succeeds. Some clock_gettime() numbers from a bigger box with AVX512 during bootup: - __fpregs_

[PATCH 11/27] x86/fpu: Make get_xsave_field_ptr() and get_xsave_addr() use feature number instead of mask

2019-04-03 Thread Sebastian Andrzej Siewior
After changing the argument of __raw_xsave_addr() from a mask to number Dave suggested to check if it makes sense to do the same for get_xsave_addr(). As it turns out it does. Only get_xsave_addr() needs the mask to check if the requested feature is part of what is support/saved and then uses the n

<    1   2   3   4   5   6   7   8   9   10   >