Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-28 Thread Masahiro Yamada
On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the var

Re: [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:00 -0300 Matheus Tavares wrote: > Previously, when spi_read returned an error code inside ad2s90_read_raw, > the code was ignored and IIO_VAL_INT was returned. This patch makes the > function return the error code returned by spi_read when it fails. > > Signed-off-by: M

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:01 -0300 Matheus Tavares wrote: > Previously, ad2s90_probe ignored the return code from spi_setup, not > handling its possible failure. This patch makes ad2s90_probe check if > the code is an error code and, if so, do the following: > > - Call dev_err with an appropriat

Re: [PATCH v3 4/5] modpost: Changes parameter name to avoid shadowing.

2018-10-28 Thread Masahiro Yamada
On Wed, Oct 24, 2018 at 1:05 PM Leonardo Bras wrote: > > Changes the parameter name to avoid shadowing a variable. > > Signed-off-by: Leonardo Bras For this one, I'd rather like to see code refactoring than renaming the variable. I will take a closer look. > --- > scripts/mod/modpost.c |

[PATCH] Malformatted switch statment

2018-10-28 Thread Joris Gutjahr
I fixed this coding style error I got after running checkpatch --file on this file. The problem was that the whole case block was on one line. Signed-off-by: Joris Gutjahr --- drivers/ide/amd74xx.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/ide/amd74

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 23:00:04 -0300 Matheus Tavares wrote: > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > implements the relative read behavior at ad2s90_read_raw. > > Signed-off-by: Victor Colombo > Signed-off-by: Matheus Tavares Hi, A suggestion inline. This is a commo

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 22:59:59 -0300 Matheus Tavares wrote: > This patch set adds scale info to ad2s90's single channel, improve > error handling in it's functions and fix a possible race condition > issue. > > The goal with this patch set is to address the points discussed in the > mailing list i

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Renato Lui Geh
Hi Jonathan, Thank you for the review. + voltage_uv = regulator_get_voltage(st->reg); + if (voltage_uv) + st->int_vref_mv = voltage_uv/1000; *val = st->int_vref_mv * st->gain; Is there actually a reason (now) to have the stashed

Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS

2018-10-28 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 8:28 PM David Laight wrote: > > From: Masahiro Yamada > > Sent: 18 October 2018 17:39 > > > > On Thu, Oct 18, 2018 at 6:18 PM Borislav Petkov wrote: > > > > > > On Wed, Oct 17, 2018 at 09:40:53PM -0300, Leonardo Bras wrote: > > > > The idea was to put it as default and fix

Re: [PATCH v2 01/17] compat_ioctl: add generic_compat_ioctl_ptrarg()

2018-10-28 Thread Al Viro
On Thu, Sep 13, 2018 at 12:29:02PM +0200, Arnd Bergmann wrote: > I was hoping that the _ptrarg suffix gives enough warning here, > but maybe not. I was careful to only use it in cases that I > checked are safe, either using only pointer arguments, or > no arguments. > > What we might do for furth

Build regressions/improvements in v4.19

2018-10-28 Thread Geert Uytterhoeven
Below is the list of build error/warning regressions/improvements in v4.19[1] compared to v4.18[2]. Summarized: - build errors: +5/-3 - build warnings: +14715/-247 JFYI, when comparing v4.19[1] to v4.19-rc8[3], the summaries are: - build errors: +0/-0 - build warnings: +158/-166 Note tha

[GIT PULL] Kbuild updates for v4.20

2018-10-28 Thread Masahiro Yamada
Hi Linus, Please pull Kbuild updates for v4.20 Thanks! The following changes since commit 11da3a7f84f19c26da6f86af878298694ede0804: Linux 4.19-rc3 (2018-09-09 17:26:43 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git

Good Day

2018-10-28 Thread Maria Dunga
Can we meet in person to discuss?

Re: [RFC] rcu: doc: update example about stale data

2018-10-28 Thread Paul E. McKenney
On Sat, Oct 27, 2018 at 07:16:53PM -0700, Joel Fernandes (Google) wrote: > The RCU example for 'rejecting stale data' on system-call auditting > stops iterating through the rules if a deleted one is found. It makes > more sense to continue looking at other rules once a deleted one is > rejected. Al

Re: [RFC] rcu: doc: update example about stale data

2018-10-28 Thread Paul E. McKenney
On Sat, Oct 27, 2018 at 09:44:31PM -0700, Joel Fernandes wrote: > On Sat, Oct 27, 2018 at 7:16 PM, Joel Fernandes (Google) > wrote: > > The RCU example for 'rejecting stale data' on system-call auditting > > stops iterating through the rules if a deleted one is found. It makes > > more sense to co

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Shuah Khan
On 10/28/2018 02:01 AM, Steven Rostedt wrote: > On Mon, 22 Oct 2018 00:07:50 +0900 > Masami Hiramatsu wrote: > >> Hi, >> >> I found another bug in synthetic event. This is a small fix, but >> confusingly, there is also a bug in a test case. >> >> Steve, since the testcase bugfix ([2/2]) breaks th

Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices

2018-10-28 Thread Moritz Fischer
Hi Andreas, On Thu, Oct 25, 2018 at 08:44:06AM +, Andreas Puhm wrote: > >My experience with cvp is with Arria10 and Stratix 10. The PCIe Hard IP > >gets configured when the IOring gets configured at power on. The idea is > >that the load of the IOring is very fast, much before the infamous

Re: [PATCH 1/2] dt-bindings: iio: pressure: Add support for Honeywell HSC SPI sensors

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 18:14:36 + Carlos Iglesias wrote: > Add device tree bindings for the HSC pressure sensors. > > Signed-off-by: Carlos Iglesias > --- > .../bindings/iio/pressure/hsc_spi.txt | 85 +++ > 1 file changed, 85 insertions(+) > create mode 100644 Documen

XFS: Hang and dmesg flood on mounting invalid FS image

2018-10-28 Thread Anatoly Trosinenko
Hello, When mounting a broken XFS image, the kernel hangs and floods dmesg with stack traces. How to reproduce with kvm-xfstests: 1) Checkout v4.19, copy x86_64-config-4.14 to .config, `make olddefconfig` and compile 2) Unpack the attached image (128 Mb uncompressed) to /tmp/kvm-xfstests-$USER 3)

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-28 Thread Amit Kucheria
On Thu, Oct 25, 2018 at 9:38 PM Andy Gross wrote: > > On Thu, Oct 25, 2018 at 10:55:32AM +0530, Amit Kucheria wrote: > > > > > Andy, > > > > While you acked the tsens thermal DT patches[1] so they could go > > through the thermal tree[2] to avoid a dependency, Eduardo would > > prefer the DT chan

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 11:33:35 -0600 Shuah Khan wrote: > Hi Steve, > > Are there any dependencies on my pull request I sent to Linus? It hasn't > been pulled in yet. If there is one, could please you mention that in your > pull request for this. There's no dependency on the patches you took. But

Re: [PATCH v3 1/4] x86/mm: declare check_la57_support() as inline

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 13:09:42 + Changbin Du wrote: > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. > So declare check_la57_support() as inline to make sure the code > referring to level4_kernel_pgt is optimized out. This is a preparation > for CONFIG_CC_OPTIMIZE_FOR_DEBUGGI

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Shuah Khan
On 10/28/2018 02:09 AM, Steven Rostedt wrote: > On Sun, 28 Oct 2018 04:01:35 -0400 > Steven Rostedt wrote: > >> I'll add them on top of my linux-next code, and include them in the >> pull request I'm hoping to do on Tuesday. > > Bah, I think this is on a different branch, and that will make it g

Re: [PATCH 2/2] iio: pressure: Add support for Honeywell HSC SPI sensors

2018-10-28 Thread Jonathan Cameron
On Fri, 26 Oct 2018 18:14:37 + Carlos Iglesias wrote: > Add device driver for the HSC pressure sensors with SPI interface. > In addition to the main measurement -pressure- these sensors also > provide temperature measurement. > > Signed-off-by: Carlos Iglesias Hi Carlos, A few minor thing

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Linus Torvalds
On Tue, Oct 23, 2018 at 1:08 PM Matthew Wilcox wrote: < > Please consider pulling the XArray patch set. Pulled. I took the more recent version of yours, because by the time I actually had time to review this thing for pulling, even the recent version had been in linux-next for a week. Of course

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:52:32 -0300 Renato Lui Geh wrote: > Hi Jonathan, > > Thank you for the review. > > >> + voltage_uv = regulator_get_voltage(st->reg); > >> + if (voltage_uv) > >> + st->int_vref_mv = voltage_uv/1000; > >>*val = st->int_vref_mv

Re: i.MX6 MIPI-CSI2 OV5640 Camera testing on Mainline Linux

2018-10-28 Thread Adam Ford
On Wed, Oct 24, 2018 at 9:17 AM Adam Ford wrote: > > On Wed, Oct 24, 2018 at 9:08 AM jacopo mondi wrote: > > > > Hi Adam, > > > > On Wed, Oct 24, 2018 at 08:53:41AM -0500, Adam Ford wrote: > > > On Tue, Oct 23, 2018 at 6:03 PM jacopo mondi wrote: > > > > > > > > Hi Adam, > > > > > > > > On Tue,

Re: [regression, bisected] Keyboard not responding after resuming from suspend/hibernate

2018-10-28 Thread Numan Demirdöğen
Thu, 25 Oct 2018 09:49:03 +0200 tarihinde Pavel Machek yazdı: > Hi! > > Here's problem bisected down to: > > commit 9d659ae14b545c4296e812c70493bfdc999b5c1c > Author: Peter Zijlstra > Date: Tue Aug 23 14:40:16 2016 +0200 > > locking/mutex: Add lock handoff to avoid starvation > > I

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > On Tue, Oct 23, 2018 at 1:08 PM Matthew Wilcox wrote: > < > > Please consider pulling the XArray patch set. > > Pulled. Thanks! > I took the more recent version of yours, because by the time I > actually had time to review this t

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 12:10:17 -0600 Shuah Khan wrote: > Here it is > > Acked-by: Shuah Khan > Thanks a lot Shuah! -- Steve

Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
So I use a Logitech MX Anywhere 2S mouse, and really like it. I have the scroll-wheel unlocked, because I like flicking once to scroll a lot. However, the new high-res scroll code means that the scroll wheel action is now much too sensitive. It's not even stable - it will scroll back-and-forth a b

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jerome Brunet
On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: > [snip] > > > > > +static void clk_regmap_div_init(struct clk_hw *hw) > > > > > +{ > > > > > + struct clk_regmap *clk = to_clk_regmap(hw); > > > > > + struct clk_re

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Matthew Wilcox wrote: > > On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > > > NOTE! I did get some conflicts with other stuff, and while the > > conflict resolution all looked pretty straightforward, this does want > > looking at. > > > > Particul

Re: [GIT PULL] XArray for 4.20

2018-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2018 at 12:21:19PM -0700, Linus Torvalds wrote: > On Sun, Oct 28, 2018 at 12:13 PM Matthew Wilcox wrote: > > > > On Sun, Oct 28, 2018 at 11:50:19AM -0700, Linus Torvalds wrote: > > > > > NOTE! I did get some conflicts with other stuff, and while the > > > conflict resolution all lo

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 3:13 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files t

Re: [GIT PULL] kselftest update for Linux 4.20-rc1

2018-10-28 Thread Linus Torvalds
On Thu, Oct 25, 2018 at 11:36 AM Shuah Khan wrote: > > Please pull the following kselftest update for Linux 4.20-rc1 Pulled, Linus

Re: drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 4:16 AM Adam Borowski wrote: > > Amen to that. But, perhaps you could encourage people to do enable drivers > once they become very popular? For example, I just (72a9c673636) got hit by > USB 3.0 being off in defconfigs, and not having keyboard is not that cool. Yes, tha

Re: [GIT PULL] Kbuild updates for v4.20

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 10:12 AM Masahiro Yamada wrote: > > Please pull Kbuild updates for v4.20 Pulled, Linus

RTL8812au driver source code A little help please?

2018-10-28 Thread Nathaniel Russell
make[1]: Entering directory '/usr/src/linux-4.19' CC [M] /tmp/rtl8812AU_8821AU_linux/os_dep/linux/os_intfs.o /tmp/rtl8812AU_8821AU_linux/os_dep/linux/os_intfs.c:816:22: error: initialization of ‘u16 (*)(struct net_device *, struct sk_buff *, struct net_device *, u16 (*)(struct net_device *, stru

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:36:07PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:21:25 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > Hi Nishad, > > Sorry it took me most of

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-10-28 Thread Stefan Wahren
Hi Nicolas, > Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > vchiq_init_state() initialises a series of semaphores to then call > remote_event_create() on the same semaphores, which initializes them > again. i would prefer to have all init stuff at one place in v

Loan Offer

2018-10-28 Thread Global Financial Ltd
We offer all types of loans at 2% interest rate contact us at gylesloan...@gmail.com --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
On Sun, Oct 28, 2018 at 02:51:08PM +, Jonathan Cameron wrote: > On Sun, 28 Oct 2018 13:23:23 +0530 > Nishad Kamdar wrote: > > > Replace platform data with device tree support. > > > > Signed-off-by: Nishad Kamdar > The whole gpio in or out thing makes less and less sense to > me and seems t

Re: [PATCH RFC 15/18] stagning: vchiq_core: fix logic redundancy in parse_open

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > We update sync to reflect that the firmware version is compatible with > that option. We don't need to check both of them again further down the > code. please fix the typo in the subject s/stagning/staging/ for thi

Re: [PATCH RFC 11/18] staging: vchiq_arm: use completions instead of semaphores

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > It is preferred in the kernel to avoid using semaphores to wait for > events, as they are optimised for the opposite situation; where the > common case is that they are available and may block only occasionally. > FY

Re: Your Loan Firm

2018-10-28 Thread EMRAH GLOBAL LOAN FIRM
Are you searching for a Genuine Loan? At an affordable interest rate? Get back to us with your Name and Phone Number Best Regards, Emrah Global Loan

Re: [PATCH RFC 16/18] staging: vchiq_arm: rework probe and init functions

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > Some operations performed in the probe function should have been > implemented in the init function. Namely class and dev region creations. > Please explain the why in the commit log

Loan Offer

2018-10-28 Thread Global Financial Ltd
We offer all types of loans at 2% interest rate contact us at gylesloan...@gmail.com --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds wrote: > > So the recent change to enable the high-res scrolling really seems a > bit *too* extreme. > > Is there some middle ground that turns the mouse from "look at it > sideways and it starts scrolling" to something slightly more > reasonable? A

Re: [PATCH 11/11] perf tools: Stop fallbacking to kallsyms for vdso symbols lookup

2018-10-28 Thread Jiri Olsa
On Sat, Oct 27, 2018 at 01:09:44PM -0700, Vinicius Costa Gomes wrote: > Hi Jirka, > > Jiri Olsa writes: > > > On Fri, Oct 26, 2018 at 04:19:52PM -0700, Vinicius Costa Gomes wrote: > >> Hi, > >> > >> Adrian Hunter writes: > >> > >> > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote: > >> >>

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-28 Thread Linus Torvalds
Arnd, I was kind of hoping/expecting to get an explicit ack for this from you, since it's a new architecture. Good to merge? Linus On Fri, Oct 26, 2018 at 9:08 PM Guo Ren wrote: > > This tag contains the Linux port for C-SKY(csky) based on linux-4.19 > Release, which has been thr

Re: [PATCH RFC 18/18] staging: vchiq: add more tasks to the TODO list

2018-10-28 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um > 15:48 geschrieben: > > > The more the better. Please try to find a better commit log ;-) > > Signed-off-by: Nicolas Saenz Julienne > --- > .../staging/vc04_services/interface/vchi/TODO | 46 ++- > 1 file changed, 44 in

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-28 Thread NeilBrown
On Sun, Oct 28 2018, Jiri Kosina wrote: > On Sat, 27 Oct 2018, tim.b...@sony.com wrote: > >> Al, >> >> Can you please, even in the face of comments you find irritating, keep >> your responses more civil? Calling someone a "wankstain" is >> unprofessional > > Tim, > > to be completely honest, co

[PATCH] ubifs: Handle re-linking of inodes correctly while recovery

2018-10-28 Thread Richard Weinberger
UBIFS's recovery code strictly assumes that a deleted inode will never come back, therefore it removes all data which belongs to that inode as soon it faces an inode with link count 0 in the replay list. Before O_TMPFILE this assumption was perfectly fine. With O_TMPFILE it can lead to data loss up

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-28 Thread David Rientjes
On Mon, 22 Oct 2018, Zi Yan wrote: > Hi David, > Hi! > On 22 Oct 2018, at 17:04, David Rientjes wrote: > > > On Tue, 16 Oct 2018, Mel Gorman wrote: > > > > > I consider this to be an unfortunate outcome. On the one hand, we have a > > > problem that three people can trivially reproduce with k

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-28 Thread NeilBrown
On Sat, Oct 27 2018, Josh Triplett wrote: > On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote: >> On Wed, Oct 24 2018, Josh Triplett wrote: >> >> > On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote: >> >> On Sun, Oct 21 2018, Josh Triplett wrote: >> >> >> >> > On Mon, Oct 22, 201

CONTACT HIM NOW

2018-10-28 Thread Mr. Larry Johnson
Attn: My Dear I am glad to inform you that i have successfully concluded the transaction which i seek for your family help before, Now the fund has been transferred to Hong Kong through the assistant of Mr.Wong Lee, who is a business man base in Hong Kong.Once again, I have mapped out a compensati

Re: [PATCH 1/3] i2c: uniphier-f: make driver robust against concurrency

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:47PM +0900, Masahiro Yamada wrote: > This is unlikely to happen, but it is possible for a CPU to enter > the interrupt handler just after wait_for_completion_timeout() has > expired. If this happens, the hardware is accessed from multiple > contexts concurrently. > >

Re: [PATCH 3/3] i2c: uniphier-f: fix race condition when IRQ is cleared

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:49PM +0900, Masahiro Yamada wrote: > The current IRQ handler clears all the IRQ status bits when it bails > out. This is dangerous because it might clear away the status bits > that have just been set while processing the current handler. If this > happens, the IRQ eve

Re: [PATCH 2/3] i2c: uniphier-f: fix occasional timeout error

2018-10-28 Thread Wolfram Sang
On Tue, Oct 16, 2018 at 12:01:48PM +0900, Masahiro Yamada wrote: > Currently, a timeout error could happen at a repeated START condition. > > For a (non-repeated) START condition, the controller starts sending > data when the UNIPHIER_FI2C_CR_STA bit is set. However, for a repeated > START conditi

w1: coding style and checkpatch fixes

2018-10-28 Thread Steffen Vogel
Hi, This is my first series of patches for the Linux kernel. I started by familiarizing myself with coding style and satisfying my inner OCD by cleaning the 1-wire subsystem. Steffen

[PATCH 6/9] w1: do not log errors about failed memory allocations

2018-10-28 Thread Steffen Vogel
This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bad2ee26cd4e..e8ce97e066ec 100644 --- a/dr

[PATCH 3/9] w1: add newlines after declarations

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bd95dfe4041d..812186ce35d6 100644 --- a/drivers

[PATCH 5/9] w1: use octal numbers instead of macros for file mode

2018-10-28 Thread Steffen Vogel
This satifies a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index f64da16dbec9..bad2ee26cd4e 100644 --- a/drivers/w1/w1.c +

[PATCH 9/9] w1: using linux instead of asm prefix for includes

2018-10-28 Thread Steffen Vogel
This fixes a warning raised by the checkpatch tool Signed-off-by: Steffen Vogel --- drivers/w1/w1_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 283c89708c7c..b18d82cde71e 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1/w1_

[PATCH 4/9] w1: cleanup whitespaces according to coding style document

2018-10-28 Thread Steffen Vogel
These changes fix several warnings emitted by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 20 +--- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_io.c | 17 + drivers/w1/w1_netlink.c | 2 +- 4 files changed, 20 insertions(

[PATCH 7/9] w1: use __func__ for logging the function name

2018-10-28 Thread Steffen Vogel
This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 3 ++- drivers/w1/w1_int.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index e8ce97e066ec..c790c79352a0 100644 --- a/drivers/w1/

[PATCH 1/9] w1: add SPDX identifiers

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters/d

[PATCH 2/9] w1: improve coding style by following strict 80 column line limit

2018-10-28 Thread Steffen Vogel
This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 56 + drivers/w1/w1_int.c | 3 ++- drivers/w1/w1_io.c | 29 +++-- drivers/w1/w1_netlink.c | 16 +- 4 files chan

[PATCH 8/9] w1: fix whitespaces of struct declarations

2018-10-28 Thread Steffen Vogel
This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1_netlink.h | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h index 08cbf08f3649..7873eb54352e 10064

Re: [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping

2018-10-28 Thread Wolfram Sang
On Fri, Oct 19, 2018 at 09:59:57AM +0100, Charles Keepax wrote: > irq_create_mapping calls irq_find_mapping internally and will use the > found mapping if one exists, so there is no need to manually call this > from i2c_smbus_host_notify_to_irq. > > Signed-off-by: Charles Keepax Adding Benjamin

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-28 Thread Wolfram Sang
On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never b

Re: [PATCH v2 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs

2018-10-28 Thread Wolfram Sang
On Sat, Oct 20, 2018 at 01:23:40PM +0530, Vignesh R wrote: > > > On 28-Sep-18 10:55 AM, Vignesh R wrote: > > Couple of patches to enable i2c-omap driver to be used with TI's new > > AM654 platforms. > > > > > > Vignesh R (2): > > dt-bindings: i2c-omap: Add new compatible for AM654 SoCs > >

linux-next: build failure in Linus' tree

2018-10-28 Thread Stephen Rothwell
Hi Linus, After merging the origin tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: net/bridge/br_multicast.c: In function 'br_multicast_query_received': net/bridge/br_multicast.c:1432:32: error: 'union ' has no member named 'ip6'; did you mean 'ip4'? !ipv6_addr_

Re: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-28 Thread NeilBrown
On Fri, Oct 26 2018, Jeff Layton wrote: > On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote: >> This took longer that I had wanted, due to various reasons - sorry. >> And I'm now posting it in a merge window, which is not ideal. I don't >> expect it to be included in this merge window and I won'

linux-next: build failure in Linus' tree

2018-10-28 Thread Stephen Rothwell
Hi Linus, After merging the origin tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: 'struct iphdr' declared inside parameter list will not be visible outside of this definition or declaration struct

Re: linux-next: build failure in Linus' tree

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell wrote: > > After merging the origin tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: linux-next is back! Wheee.. > 5a2de63fd1a5 ("bridge: do not add port to router list when receives query > with source 0.0.0.0") Da

Re: w1: coding style and checkpatch fixes

2018-10-28 Thread Linus Torvalds
[ This is not about your patch series per se, only about your email settings ] On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote: > > This is my first series of patches for the Linux kernel. > I started by familiarizing myself with coding style and > satisfying my inner OCD by cleaning the 1-wi

Re: [PATCH 2/9] w1: improve coding style by following strict 80 column line limit

2018-10-28 Thread Joe Perches
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > This satisfies a checkpatch warning Perhaps run your patches through checkpatch with --strict > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c [] > @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev) > sl->master->slav

[RFR] Store tearing

2018-10-28 Thread Andrea Parri
Hi, memory-barriers.txt says: [on "store tearing"] "In fact, a recent bug (since fixed) caused GCC to incorrectly use this optimization in a volatile store.". I was wondering if you could help me retrieve some reference/discussions about this? Thanks, Andrea

linux-next: manual merge of the arm-soc tree with Linus' tree

2018-10-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the arm-soc tree got a conflict in: drivers/soc/qcom/Kconfig between commit: a978a5b8d83f ("net/kconfig: Make QCOM_QMI_HELPERS available when COMPILE_TEST") from Linus' tree and commit: ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfig

Re: [RFR] Store tearing

2018-10-28 Thread Andrea Parri
Hopefully, with Paul's proper email address this time, Andrea On Mon, Oct 29, 2018 at 12:06:27AM +0100, Andrea Parri wrote: > Hi, > > memory-barriers.txt says: > > [on "store tearing"] > > "In fact, a recent bug (since fixed) caused GCC to incorrectly use >this optimization in a vola

linux-next: manual merge of the arm-soc tree with Linus' tree

2018-10-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the arm-soc tree got a conflict in: include/linux/platform_data/gpio-omap.h between commit: b764a5863fd8 ("gpio: omap: Remove custom PM calls and use cpu_pm instead") from Linus' tree and commit: 26683316c92a ("ARM: OMAP1: ams-delta-fiq: Use ") from

Re: w1: coding style and checkpatch fixes

2018-10-28 Thread Steffen Vogel
Hi Linus, Thanks! Its hopefully fixed now. For those who are interested. Rspamd, by default, includes the sender address into the list of signed headers: https://www.rspamd.com/doc/modules/dkim_signing.html#default-sign_headers-after-173 > End result: the DKIM signature is guaranteed to fail aft

Re: [PATCH 6/8] clk: s2mps11: constify clk_ops structure

2018-10-28 Thread Chanwoo Choi
On 2018년 10월 27일 14:47, Julia Lawall wrote: > The clk_ops structure is only stored in the ops fields of > clk_init_data structures. This field is const, so the clk_ops > structure can be const as well. > > Identified and transformed using Coccinelle. > > Signed-off-by: Julia Lawall > > --- >

Re: [RFC] rcu: doc: update example about stale data

2018-10-28 Thread Joel Fernandes
On Sun, Oct 28, 2018 at 10:21:42AM -0700, Paul E. McKenney wrote: > On Sat, Oct 27, 2018 at 07:16:53PM -0700, Joel Fernandes (Google) wrote: > > The RCU example for 'rejecting stale data' on system-call auditting > > stops iterating through the rules if a deleted one is found. It makes > > more sen

linux-next: manual merge of the vfs tree with the ceph tree

2018-10-28 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in: fs/ceph/file.c between commit: fce7a9744bdf ("ceph: refactor ceph_sync_read()") from the ceph tree and commit: 00e23707442a ("iov_iter: Use accessor function") from the vfs tree. I fixed it up (see below) and can carry

Re: [RFR] Store tearing

2018-10-28 Thread Paul E. McKenney
On Mon, Oct 29, 2018 at 12:10:03AM +0100, Andrea Parri wrote: > Hopefully, with Paul's proper email address this time, > > Andrea > > On Mon, Oct 29, 2018 at 12:06:27AM +0100, Andrea Parri wrote: > > Hi, > > > > memory-barriers.txt says: > > > > [on "store tearing"] > > > > "In fact, a r

linux-next: manual merge of the vfs tree with the nfsd tree

2018-10-28 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in: net/sunrpc/svcsock.c between commit: 64dbf4dc5496 ("SUNRPC: Simplify TCP receive code") from the nfsd tree and commit: aa563d7bca6e ("iov_iter: Separate type from direction and use accessor functions") from the vfs tre

Re: w1: coding style and checkpatch fixes

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 5:30 PM Steffen Vogel wrote: > > For those who are interested. Rspamd, by default, includes the sender > address into the list of signed headers: Ugh. That's just broken. > There is RFC6377 which discusses this problem. On possible solution is > a mailing list service whi

Re: XFS: Hang and dmesg flood on mounting invalid FS image

2018-10-28 Thread Dave Chinner
On Sun, Oct 28, 2018 at 08:50:46PM +0300, Anatoly Trosinenko wrote: > Hello, > > When mounting a broken XFS image, the kernel hangs and floods dmesg > with stack traces. How did the corruption occur? $ sudo xfs_logprint -d /dev/vdc xfs_logprint: data device: 0xfd20 log device: 0xfd20 dad

Re: [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node

2018-10-28 Thread Bjorn Andersson
On Fri 26 Oct 05:25 PDT 2018, Sibi Sankar wrote: > Add SCM DT node to enable SCM functionality on SDM845. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/a

Re: [PATCH] arm64: dts: qcom: sdm845: Add PDC Global reset driver node

2018-10-28 Thread Bjorn Andersson
On Fri 26 Oct 05:26 PDT 2018, Sibi Sankar wrote: > This patch adds the node to support PDC Global reset driver on > SDM845 SoCs > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 7 +++ > 1 file changed, 7 insertions

Re: [PATCH] arm64: dts: qcom: sdm845: Add reserve-memory nodes

2018-10-28 Thread Bjorn Andersson
On Fri 26 Oct 05:27 PDT 2018, Sibi Sankar wrote: > Add reserve-memory nodes for mpss and mba required for > remoteproc mss pil. > > Signed-off-by: Sibi Sankar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 ++ > 1 file changed, 10 inser

Re: linux-next: build failure in Linus' tree

2018-10-28 Thread Hangbin Liu
On Sun, Oct 28, 2018 at 03:45:16PM -0700, Linus Torvalds wrote: > On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell > wrote: > > > > After merging the origin tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > linux-next is back! Wheee.. > > > 5a2de63fd1a5 ("brid

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

2018-10-28 Thread Joe Perches
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > This fixes a warning raised by the checkpatch tool. checkpatch does not raise any whitespace errors on this file. It does suggest that braces could be moved. $ ./scripts/checkpatch.pl -f --strict drivers/w1/w1_netlink.h WARNING: Missing o

Re: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-28 Thread NeilBrown
On Fri, Oct 26 2018, Jeff Layton wrote: > On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote: >> This took longer that I had wanted, due to various reasons - sorry. >> And I'm now posting it in a merge window, which is not ideal. I don't >> expect it to be included in this merge window and I won'

Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

2018-10-28 Thread Shawn Guo
On Sun, Oct 28, 2018 at 3:06 AM Julia Lawall wrote: > > The dw_pcie_host_ops structure is only stored in the ops field > of a pcie_port structure, and this field is const, so make the > dw_pcie_host_ops structure const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall

linux-next: manual merge of the pm tree with Linus' tree

2018-10-28 Thread Stephen Rothwell
Hi Rafael, Today's linux-next merge of the pm tree got a conflict in: drivers/cpuidle/governors/menu.c between commit: 8508cf3ffad4 ("sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD") from Linus' tree and commit: a7fe5190c03f ("cpuidle: menu: Remove get_loadavg() from the per

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

2018-10-28 Thread Steffen Vogel
Hi Joe, v2 of this patch set is almost ready. I reran checkpatch.pl with '--strict'. So more warnings will be fixed by the second version. See my comments below. On Sun, Oct 28, 2018 at 06:52:23PM -0700, Joe Perches wrote: > On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > > This fixes

<    1   2   3   >