On Sat, Oct 27, 2018 at 07:16:53PM -0700, Joel Fernandes (Google) wrote:
> The RCU example for 'rejecting stale data' on system-call auditting
> stops iterating through the rules if a deleted one is found. It makes
> more sense to continue looking at other rules once a deleted one is
> rejected. Although the original example is fine, this makes it more
> meaningful.
>
> Signed-off-by: Joel Fernandes (Google) <j...@joelfernandes.org>
Does the actual audit code that this was copied from now include the
continue statement? If so, please update the commit log to state that
and then I will take the resulting patch. (This example was inspired
by a long-ago version of the actual audit code.)
Thanx, Paul
> ---
> Documentation/RCU/listRCU.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt
> index adb5a3782846..09e9a4fc723e 100644
> --- a/Documentation/RCU/listRCU.txt
> +++ b/Documentation/RCU/listRCU.txt
> @@ -250,8 +250,7 @@ as follows:
> spin_lock(&e->lock);
> if (e->deleted) {
> spin_unlock(&e->lock);
> - rcu_read_unlock();
> - return AUDIT_BUILD_CONTEXT;
> + continue;
> }
> rcu_read_unlock();
> return state;
> --
> 2.19.1.568.g152ad8e336-goog
>
