Re: [PATCH] V3 init/main.c Enable watchdog_thresh control from kernel line

2018-10-24 Thread Laurence Oberman
On Thu, 2018-10-25 at 02:23 +0800, kbuild test robot wrote: > Hi Laurence, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linux-sof-driver/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v2 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver

2018-10-24 Thread Rob Herring
On Sat, Oct 20, 2018 at 06:50:23AM -0700, Paul Walmsley wrote: > Add DT binding documentation for the Linux driver for the SiFive > PRCI clock & reset control IP block, as found on the SiFive > FU540 chip. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Rob Herring > Cc: Mark Rutland > Cc:

Re: [PATCH 2/2] x86/ldt: Unmap PTEs for the slow before freeing LDT

2018-10-24 Thread Andy Lutomirski
On Tue, Oct 23, 2018 at 9:32 AM Kirill A. Shutemov wrote: > > modify_ldt(2) leaves old LDT mapped after we switch over to the new one. > Memory for the old LDT gets freed and the pages can be re-used. > > Leaving the mapping in place can have security implications. The mapping > is present in user

Re: [v3 01/12] taint: Introduce a new taint flag (insecure)

2018-10-24 Thread Andy Lutomirski
On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae wrote: > > For testing (or root-only) purposes, the new flag will serve to tag the > kernel taint accurately. > > When adding a new feature support, patches need to be incrementally > applied and tested with temporal parameters. Currently, there is no

Re: [v3 02/12] x86/fsgsbase/64: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE

2018-10-24 Thread Andy Lutomirski
On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae wrote: > > From: Andy Lutomirski > > This is temporary. It will allow the next few patches to be tested > incrementally. > > Setting unsafe_fsgsbase is a root hole. Don't do it. > > [ chang: Minor fix. Add the TAINT_INSECURE flag. ] Reviewed-by: An

Re: [v3 03/12] x86/fsgsbase/64: Add intrinsics/macros for FSGSBASE instructions

2018-10-24 Thread Andy Lutomirski
On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae wrote: > > From: Andi Kleen > > Add C intrinsics and assembler macros for the new FSBASE and GSBASE > instructions. > > Very straight forward. Used in followon patches. > > [ luto: Rename the variables from FS and GS to FSBASE and GSBASE and > make

[regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Andy Lutomirski
On Tue, Sep 18, 2018 at 4:09 PM Chang S. Bae wrote: > > With new helpers, FS/GS base access is centralized. > Eventually, when FSGSBASE instruction enabled, it will > be faster. Sorry for not catching this during review, but: > +void x86_fsbase_write_cpu(unsigned long fsbase) > +{ > + /* >

Re: [PATCH] V4 init/main.c Enable watchdog_thresh control from kernel line

2018-10-24 Thread Randy Dunlap
On 10/24/18 11:06 AM, Laurence Oberman wrote: > Both graphics and serial consoles are exposed to hard lockups > when handling a large amount of messaging. The kernel watchdog_thresh > parameter up to now has not been available to be set on the kernel line for > early boot. > This patch allows the s

Re:Business proposition for you

2018-10-24 Thread Melvin Greg
Hello, I have a client from Syrian who will like to invest with your company. My client is willing to invest $4 Million. Can I have your company website to show to my client your company so that they will check and decide if they will invest there funds with you as joint partner. This info

RE: [regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Bae, Chang Seok
On Tue, Sep 18, 2018 at 12:02 PM Andy Lutomirski > On Tue, Sep 18, 2018 at 4:09 PM Chang S. Bae > wrote: > > > > With new helpers, FS/GS base access is centralized. > > Eventually, when FSGSBASE instruction enabled, it will be faster. > > Sorry for not catching this during review, but: > > > +v

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

2018-10-24 Thread Bjorn Helgaas
On Thu, Oct 25, 2018 at 01:26:51AM +0800, Kai Heng Feng wrote: > > On Sep 17, 2018, at 16:19, Kai-Heng Feng > > wrote: > > at 18:54, Shah, Nehal-bakulchandra wrote: > > > >> From: Nehal-bakulchandra Shah > >> > >> This contains two drivers. > >> 1)i2c-amd-platdrv: This is based on I2C framewo

[GIT PULL] gcc-plugin stackleak for v4.20-rc1

2018-10-24 Thread Kees Cook
Hi Linus, Please pull this new GCC plugin, stackleak, for v4.20-rc1. This plugin was ported from grsecurity by Alexander Popov. It provides efficient stack content poisoning at syscall exit. This creates a defense against at least two classes of flaws: - Uninitialized stack usage. (We continue to

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 24, 2018 at 02:12:54PM -0400, Liang, Kan escreveu: > > > On 10/24/2018 12:32 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 24, 2018 at 09:23:34AM -0700, Andi Kleen escreveu: > > > > +void perf_event_munmap(void) > > > > +{ > > > > + struct perf_cpu_context *cpuctx; > > > >

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Jacek Anaszewski
On 10/24/2018 10:31 AM, Pavel Machek wrote: > Hi! > >>> + >>> + The gradual dimming format of the software pattern values >>> should be: >>> + "brightness_1 duration_1 brightness_2 duration_2 brightness_3 >>> + duration_3 ...". For example: >>> + >>> + echo

Re: [v3 05/12] x86/fsgsbase/64: Preserve FS/GS state in __switch_to() if FSGSBASE is on

2018-10-24 Thread Andy Lutomirski
On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae wrote: > > From: Andy Lutomirski > > With the new FSGSBASE instructions, we can efficiently read and write > the FSBASE and GSBASE in __switch_to(). Use that capability to preserve > the full state. > > This will enable user code to do whatever it wa

Re: [v3 03/12] x86/fsgsbase/64: Add intrinsics/macros for FSGSBASE instructions

2018-10-24 Thread Andi Kleen
On Wed, Oct 24, 2018 at 11:53:54AM -0700, Andy Lutomirski wrote: > On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae > wrote: > > > > From: Andi Kleen > > > > Add C intrinsics and assembler macros for the new FSBASE and GSBASE > > instructions. > > > > Very straight forward. Used in followon patches

Re: [regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Andy Lutomirski
On Wed, Oct 24, 2018 at 12:13 PM Bae, Chang Seok wrote: > > On Tue, Sep 18, 2018 at 12:02 PM Andy Lutomirski > > On Tue, Sep 18, 2018 at 4:09 PM Chang S. Bae > > wrote: > > > > > > With new helpers, FS/GS base access is centralized. > > > Eventually, when FSGSBASE instruction enabled, it will be

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-24 Thread Steven Sistare
On 10/24/2018 11:34 AM, Valentin Schneider wrote: > Hi, > > On 22/10/2018 20:07, Steven Sistare wrote: >> On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > [...] >> >> We could delete idle_balance() and use stealing exclusively for handling >> new idle. For each sd level, stealing would look for an

RE: [regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Bae, Chang Seok
On Wed, Oct 24, 2018 at 12:22 PM Andy Lutomirski > On Wed, Oct 24, 2018 at 12:13 PM Bae, Chang Seok > wrote: > > > > On Tue, Sep 18, 2018 at 12:02 PM Andy Lutomirski > > > On Tue, Sep 18, 2018 at 4:09 PM Chang S. Bae > > > > > > wrote: > > > > > > > > With new helpers, FS/GS base access is cent

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Stephane Eranian
Hi, On Wed, Oct 24, 2018 at 8:12 AM wrote: > > From: Kan Liang > > To calculate the physical address, perf needs to walk the pages tables. > The related mapping may has already been removed from pages table in > some cases (e.g. large PEBS). The virtual address recorded in the first > PEBS recor

[RFC PATCH v3] ftrace: support very early function tracing

2018-10-24 Thread Abderrahmane Benbachir
Hi Steve, I believe this patch is quite stable. I know some folks that were using it to debug early VM/KVM handshak and seemed very helpful for them. Previous changes: PATCH v1: Initial patch PATCH v2: Removed arch specific code and use the default clock. Add more code re-usability Ad

RE: [v3 05/12] x86/fsgsbase/64: Preserve FS/GS state in __switch_to() if FSGSBASE is on

2018-10-24 Thread Bae, Chang Seok
On Tue, Oct 24, 2018 at 12:21 PM Andy Lutomirski wrote: > On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae > wrote: > > > > From: Andy Lutomirski > > > > With the new FSGSBASE instructions, we can efficiently read and write > > the FSBASE and GSBASE in __switch_to(). Use that capability to preserv

Re: [PATCH 2/2] x86/ldt: Unmap PTEs for the slow before freeing LDT

2018-10-24 Thread H. Peter Anvin
On 10/23/18 9:31 AM, Kirill A. Shutemov wrote: > > It shouldn't be a particularly hot path anyway. > That's putting it mildly. -hpa

[PATCH] V6 init/main.c Enable watchdog_thresh control from kernel line To: lober...@redhat.com

2018-10-24 Thread Laurence Oberman
Both graphics and serial consoles are exposed to hard lockups when handling a large amount of messaging. The kernel watchdog_thresh parameter up to now has not been available to be set on the kernel line for early boot. This patch allows the setting of watchdog_thresh to be increased when needed to

Re: [regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Andy Lutomirski
On Wed, Oct 24, 2018 at 12:29 PM Bae, Chang Seok wrote: > > On Wed, Oct 24, 2018 at 12:22 PM Andy Lutomirski > > On Wed, Oct 24, 2018 at 12:13 PM Bae, Chang Seok > > wrote: > > > > > > On Tue, Sep 18, 2018 at 12:02 PM Andy Lutomirski > > > > On Tue, Sep 18, 2018 at 4:09 PM Chang S. Bae > > > >

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-24 Thread Mike Brady
Hi Kirill. Thanks again for your comments. > On 24 Oct 2018, at 19:06, Kirill Marinushkin wrote: > > Hello Mike, > > On 10/24/18 10:20, Mike Brady wrote: >> Hi Kirill. Thanks for your comments. >> >>> On 22 Oct 2018, at 23:25, Kirill Marinushkin >>> wrote: >>> >>> AFAIU, this patch is wrong

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Pavel Machek
On Wed 2018-10-24 21:17:25, Jacek Anaszewski wrote: > On 10/24/2018 10:31 AM, Pavel Machek wrote: > > Hi! > > > >>> + > >>> + The gradual dimming format of the software pattern values > >>> should be: > >>> + "brightness_1 duration_1 brightness_2 duration_2 brightness_3 > >>> +

Re: [PATCH] V3 init/main.c Enable watchdog_thresh control from kernel line

2018-10-24 Thread kbuild test robot
Hi Laurence, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-c

Re: [PATCH v2 2/3] leds: upboard: Add LED support

2018-10-24 Thread Jacek Anaszewski
On 10/23/2018 09:30 PM, Pavel Machek wrote: > On Tue 2018-10-23 21:09:54, Jacek Anaszewski wrote: >> On 10/23/2018 08:54 PM, Pavel Machek wrote: >>> Hi! >>> > + led->field = devm_regmap_field_alloc(dev, regmap, conf); > + if (IS_ERR(led->field)) > + return PTR_ERR(led->field); >

Re: [PATCH v3 3/3] drivers: qcom: rpmh: disallow active requests in solver mode

2018-10-24 Thread Lina Iyer
On Wed, Oct 24 2018 at 11:43 -0600, Evan Green wrote: On Mon, Oct 8, 2018 at 7:09 PM Raju P.L.S.S.S.N wrote: From: Lina Iyer Controllers may be in 'solver' state, where they could be in autonomous mode executing low power modes for their hardware and as such are not available for sending act

Re: [PATCH] perf trace beautify: Beautify flags of mount(2) and umount(2).

2018-10-24 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 22, 2018 at 07:40:35PM -0700, Benjamin Peterson escreveu: > > > On Wed, Oct 10, 2018, at 05:55, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 09, 2018 at 08:52:26PM -0700, Benjamin Peterson escreveu: > > > Hi Arnaldo, > > > Did you get a chance to look at this again? > > Thanks, fo

Re: [PATCH v4 2/5] phy: qcom-qmp: Utilize fully-specified DT registers

2018-10-24 Thread Doug Anderson
Hi, On Wed, Oct 24, 2018 at 11:29 AM Vivek Gautam wrote: > Thanks for the patch. > I am starting to think that the driver is heavily relying on the > resource indices to request > all these areas ioremapped. Is it a good way forward that driver and the > dt bindings are > chained together? > Shou

[PATCH] Fix pattern handling optimalization

2018-10-24 Thread Pavel Machek
Check for zero duration before skipping step. This fixes pattern echo "0 1000 10 2550 0 1000" > pattern which should do [ .-xXx-.] but does [ Xx-.] Signed-off-by: Pavel Machek Suggested-by: Jacek Anaszewski diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/le

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-24 Thread Lina Iyer
On Mon, Oct 22 2018 at 03:27 -0600, Marc Zyngier wrote: On Fri, 19 Oct 2018 20:47:12 +0100, Lina Iyer wrote: On Fri, Oct 19 2018 at 09:53 -0600, Marc Zyngier wrote: > Hi Lina, > > On 19/10/18 16:32, Lina Iyer wrote: >> Hi folks, >> >> On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: [...]

Re: perf overlapping maps...

2018-10-24 Thread David Miller
From: Jiri Olsa Date: Wed, 24 Oct 2018 13:34:16 +0200 > On Tue, Oct 23, 2018 at 11:15:03AM -0700, David Miller wrote: >> From: Arnaldo Carvalho de Melo >> Date: Tue, 23 Oct 2018 15:05:03 -0300 >> >> > IIRC this was first done for 'perf record', where we have to stash those >> > events in the pe

Re: [GIT PULL] KVM updates for Linux 4.20-rc1

2018-10-24 Thread Paolo Bonzini
On 24/10/2018 13:14, Radim Krčmář wrote: > Linus, > > there are conflicts with the ARM tree as we didn't have a topic branch and > some > with 4.19 fixes. Future merge of the selftests tree will also have a > conflict, > https://lkml.org/lkml/2018/10/18/273. All should be resolved as in next a

Re: [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3633

2018-10-24 Thread Rob Herring
On Wed, Oct 24, 2018 at 08:38:35PM +0200, Pavel Machek wrote: > On Wed 2018-10-24 09:35:06, Rob Herring wrote: > > On Wed, Oct 24, 2018 at 11:23:28AM +0200, Pavel Machek wrote: > > > On Tue 2018-10-23 12:06:21, Dan Murphy wrote: > > > > The LM3633 is a single function LED driver. The single functio

Re: [PATCH v2] kernel/signal: Signal-based pre-coredump notification

2018-10-24 Thread Enke Chen
Hi, Olge: On 10/24/18 6:52 AM, Oleg Nesterov wrote: > On 10/23, Enke Chen wrote: >> + /* + * Send the pre-coredump signal to the parent if requested. + */ + read_lock(&tasklist_lock); + notify = do_notify_parent_predump(current); + read_unlock(&tasklist_lock);

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-24 Thread Kirill Marinushkin
Hello Mike, We are not on the same page. What you hear is not what I tell you. Either you don't understand what happens in your commit, or I don't understand what happens in the driver. Hopefully somebody in the community can comment here. On 10/24/18 21:54, Mike Brady wrote: You modify the

[PATCH 2/2] x86/cpufeatures: Enumerate MOVDIR64B instruction

2018-10-24 Thread Fenghua Yu
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. In low latency offload (e.g. Non-Volatile Memory, etc), MOVDIR64B writes work descriptors (and data in s

[PATCH 0/2] x86: Enumerate direct stores instructions

2018-10-24 Thread Fenghua Yu
Direct stores instructionis MOVDIRI and MOVDIR64B will be available in Tremont and other future x86 processors. This patch set enumerates the instructions through CPUID. GCC 8 implements intrinsics for the direct stores instructions. User can try these instructions from GCC tree: https://gcc.gnu.

[PATCH 1/2] x86/cpufeatures: Enumerate MOVDIRI instruction

2018-10-24 Thread Fenghua Yu
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. Programmable agents can handle streaming offload (e.g. high speed packet processing in network). Hard

Re: [PATCH v3] kernel/signal: Signal-based pre-coredump notification

2018-10-24 Thread Enke Chen
Hi, Oleg: On 10/24/18 7:02 AM, Oleg Nesterov wrote: > On 10/23, Enke Chen wrote: >> >> --- a/fs/coredump.c >> +++ b/fs/coredump.c >> @@ -590,6 +590,12 @@ void do_coredump(const kernel_siginfo_t *siginfo) >> if (retval < 0) >> goto fail_creds; >> >> +/* >> + * Send the pre

[PATCH] MAINTAINERS: Add x86 early-quirks.c file pattern to PCI subsystem

2018-10-24 Thread Bjorn Helgaas
From: Bjorn Helgaas arch/x86/kernel/early-quirks.c contains special PCI quirks that need to run even before the usual DECLARE_PCI_FIXUP_EARLY() quirks. These have typically been merged by the x86 maintainers, which is fine, but PCI folks should at least see what's happening, so add a file patter

Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages

2018-10-24 Thread Andrew Morton
On Tue, 23 Oct 2018 16:43:29 + Roman Gushchin wrote: > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs > with a relatively small number of objects") leads to a regression on > his setup: periodically the majority of the pagecache is evicted > without an obvious reason, w

Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages

2018-10-24 Thread Andrew Morton
On Tue, 23 Oct 2018 16:43:29 + Roman Gushchin wrote: > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs > with a relatively small number of objects") leads to a regression on > his setup: periodically the majority of the pagecache is evicted > without an obvious reason, w

Re: Git pull ack emails..

2018-10-24 Thread Kees Cook
On Tue, Oct 23, 2018 at 1:41 AM, Linus Torvalds wrote: > So I've got a few options: > > - just don't do it As with other folks, this is what we're used to, but it does cause a lot of "polling" your tree to see what's landed. (And your "Pulled" email to pstore today scared the crap out of me brie

Re: [PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-24 Thread Andrew Morton
On Mon, 22 Oct 2018 10:13:48 -0700 Dan Williams wrote: > [ added Andrew ] > > Patch here: https://lore.kernel.org/patchwork/patch/1002234/ > > On Sun, Oct 21, 2018 at 8:00 AM Sebastien Boisvert > wrote: > > > > Tracing the event "fs_dax:dax_pmd_insert_mapping" with perf produces this > > warn

RE: [regression in -rc1] Re: [PATCH v6 2/8] x86/fsgsbase/64: Introduce FS/GS base helper functions

2018-10-24 Thread Bae, Chang Seok
On Wed, Oct 24, 2018 at 12:43 PM Andy Lutomirski wrote: > I think x86_fsbase_write_task() makes plenty of sense, but I think > that callers need to be aware that the effect of writing a nonzero > fsbase *and* a nonzero fsindex is bizarre on non-FSGSBASE systems. So > that code should go in the ca

Re: [PATCH 14/17] prmem: llist, hlist, both plain and rcu

2018-10-24 Thread Igor Stoppa
On 24/10/2018 17:56, Tycho Andersen wrote: On Wed, Oct 24, 2018 at 05:03:01PM +0300, Igor Stoppa wrote: On 24/10/18 14:37, Mathieu Desnoyers wrote: Also, is it the right approach to duplicate existing APIs, or should we rather hook into page fault handlers and let the kernel do those "shadow" m

Re: [PATCH V9 01/21] csky: Build infrastructure

2018-10-24 Thread Arnd Bergmann
On Tue, Oct 23, 2018 at 1:08 AM Guo Ren wrote: > > Hi Arnd, > > Could you help me review the patch, seems the patch is skipped. > ref: https://lkml.org/lkml/2018/10/16/224 Ah right, I missed that. I think I originally had some thoughts on it but didn't immediately comment and then forgot about it

Re: [PATCH] mm,oom: Use timeout based back off.

2018-10-24 Thread Andrew Morton
On Mon, 22 Oct 2018 14:11:10 -0700 (PDT) David Rientjes wrote: > > Michal has been refusing timeout based approach, but I don't think this > > is something we have to be frayed around the edge about possibility of > > overlooking races/bugs just because Michal does not want to use timeout. > > I

Re: [PATCH 08/17] prmem: struct page: track vmap_area

2018-10-24 Thread Igor Stoppa
On 24/10/2018 06:12, Matthew Wilcox wrote: On Wed, Oct 24, 2018 at 12:34:55AM +0300, Igor Stoppa wrote: The connection between each page and its vmap_area avoids more expensive searches through the btree of vmap_areas. Typo -- it's an rbtree. ack +++ b/include/linux/mm_types.h @@ -87,13

Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices

2018-10-24 Thread matthew . gerlach
On Wed, 24 Oct 2018, Moritz Fischer wrote: Hi Anatolij, Andreas, On Tue, Oct 23, 2018 at 06:46:47PM +, Andreas Puhm wrote: Hi Anatolij, The CvP docs says that on some FPGAs (e.g. Arria 10) the assertion of CVP status can take up to 500ms. However it is not clear whether this delay mig

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-24 Thread Andrew Morton
On Fri, 19 Oct 2018 19:35:36 +0200 "Uladzislau Rezki (Sony)" wrote: > improving vmalloc allocator It's about time ;) Are you aware of https://lwn.net/Articles/285341/ ? If not, please do take a look through Nick's work and see if there are any good things there which can be borrowed.

Re: [PATCH 3/6] mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback

2018-10-24 Thread Andrew Morton
On Fri, 19 Oct 2018 12:04:39 -0400 jgli...@redhat.com wrote: > From: Ralph Campbell > > In hmm_mirror_unregister(), mm->hmm is set to NULL and then > mmu_notifier_unregister_no_release() is called. That creates a small > window where mmu_notifier can call mmu_notifier_ops with mm->hmm equal > to

Re: [PATCH 2/2] mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask

2018-10-24 Thread Andrew Morton
On Mon, 22 Oct 2018 15:27:54 +0200 Vlastimil Babka wrote: > > : Moreover the oriinal code allowed to trigger > > : WARN_ON_ONCE(policy->mode == MPOL_BIND && (gfp & __GFP_THISNODE)); > > : in policy_node if the requested node (e.g. cpu local one) was outside of > > : the mbind nodemask. This is

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

2018-10-24 Thread Elie Morisse
Hi, I did some work to improve Shah's driver and make it work on laptops where the two buses of the MP2 are enabled (e.g Lenovo Yoga 530-14ARR): https://marc.info/?l=linux-i2c&m=154039677815809 v3 had some issues preventing both buses to work: - enabling the second adapter (bus 1) was overridin

Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages

2018-10-24 Thread Roman Gushchin
On Wed, Oct 24, 2018 at 03:18:53PM -0700, Andrew Morton wrote: > On Tue, 23 Oct 2018 16:43:29 + Roman Gushchin wrote: > > > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs > > with a relatively small number of objects") leads to a regression on > > his setup: periodicall

Re: [PATCH v2] kernel/signal: Signal-based pre-coredump notification

2018-10-24 Thread Enke Chen
Hi, Eric: Thanks for your comments. Please see my replies inline. On 10/24/18 6:29 AM, Eric W. Biederman wrote: > Enke Chen writes: > >> For simplicity and consistency, this patch provides an implementation >> for signal-based fault notification prior to the coredump of a child >> process. A ne

Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages

2018-10-24 Thread Roman Gushchin
On Wed, Oct 24, 2018 at 03:19:50PM -0700, Andrew Morton wrote: > On Tue, 23 Oct 2018 16:43:29 + Roman Gushchin wrote: > > > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs > > with a relatively small number of objects") leads to a regression on > > his setup: periodicall

Re: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree

2018-10-24 Thread Rob Herring
On Tue, Oct 23, 2018 at 05:17:10AM +, Joakim Zhang wrote: > From: Dong Aisheng > > The FlexCAN controller can parse the stop-mode property to enable CAN > self wakeup feature. > > Signed-off-by: Dong Aisheng > Signed-off-by: Joakim Zhang > --- > Documentation/devicetree/bindings/net/can/f

RE: [PATCH v13 08/12] KVM: x86: Add Intel PT context switch for each vcpu

2018-10-24 Thread Kang, Luwei
> > +static void pt_guest_enter(struct vcpu_vmx *vmx) { > > + if (pt_mode == PT_MODE_SYSTEM) > > + return; > > + > > + /* Save host state before VM entry */ > > + rdmsrl(MSR_IA32_RTIT_CTL, vmx->pt_desc.host.ctl); > > + > > + /* > > +* Set guest state of MSR_IA32_RTIT_CTL MSR (

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Rob Herring
On Wed, Oct 24, 2018 at 10:24:54AM -0400, Sven Van Asbroeck wrote: > This patch adds devicetree binding documentation for the > Arcx anybus bridge. > > Signed-off-by: Sven Van Asbroeck > --- > .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ > .../devicetree/bindings/vendo

Re: [PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-24 Thread sebhtml
On 2018-10-24 6:43 p.m., Andrew Morton wrote: I grabbed it, and added cc:stable. But aren't we fixing this in the wrong place? That's a valid expression and if this isn't addressed in perf then we may hit a similar issue elsewhere... Right. Based on: git://git.kernel.org/pub/scm/linux/

[PATCH 0/2] perf tests: Check for ARM [vectors] page

2018-10-24 Thread Florian Fainelli
Hi all, I just painfully learned that perf would segfault when CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of it. This patch series adds an ARM test for that by leveraging the existing find_vdso_map() function and making it more generic and capable of location any map wit

[PATCH 1/2] perf tools: Make find_vdso_map() more modular

2018-10-24 Thread Florian Fainelli
In preparation for checking that the vectors page on the ARM architecture, refactor the find_vdso_map() function to accept finding an arbitrary string and create a dedicated helper function for that under util/find-map.c and update find_vdso_map() to use it. Signed-off-by: Florian Fainelli --- t

[PATCH 2/2] perf tests: Add a test for the ARM 32-bit [vectors] page

2018-10-24 Thread Florian Fainelli
perf on ARM requires CONFIG_KUSER_HELPERS to be turned on to allow some independance with respect to the ARM CPU being used. Add a test which tries to locate the [vectors] page, created when CONFIG_KUSER_HELPERS is turned on to help asses the system's health. Signed-off-by: Florian Fainelli ---

[git pull] compat_ioctl fixes

2018-10-24 Thread Al Viro
A bunch of compat_ioctl fixes, mostly in bluetooth. Hopefully, most of fs/compat_ioctl.c will get killed off over the next few cycles; between this, tty series already merged and Arnd's work this cycle ought to take a good chunk out of the damn thing... One trivial conflict in fs/compat_io

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 12:35:03AM +0300, Igor Stoppa wrote: > +static __always_inline > +bool __pratomic_long_op(bool inc, struct pratomic_long_t *l) > +{ > + struct page *page; > + uintptr_t base; > + uintptr_t offset; > + unsigned long flags; > + size_t size = sizeof(*l); > +

Re: [PATCH v3 1/5] hwmon: (core) Inherit power properties to hdev

2018-10-24 Thread linux
Quoting Nicolin Chen : The new hdev is a child device related to the original parent hwmon driver and its device. However, it doesn't support the power features, typically being defined in the parent driver. So this patch inherits three necessary power properties from the parent dev to hdev:

Re: [PATCH 1/2] perf tools: Make find_vdso_map() more modular

2018-10-24 Thread Florian Fainelli
On 10/24/18 5:09 PM, Florian Fainelli wrote: > In preparation for checking that the vectors page on the ARM > architecture, refactor the find_vdso_map() function to accept finding an > arbitrary string and create a dedicated helper function for that under > util/find-map.c and update find_vdso_map(

[PATCH v3 0/3] of/fdt: Absorb ARM64's __early_init_dt_declare_initrd()

2018-10-24 Thread Florian Fainelli
Hi all, Based on Rob's suggestion, this is a follow-up to the patch series posted here previously that aims at cutting the ARM64 rebuild time/number of objects. Rob indicated that he was adamant to just having drivers/of/fdt.c contain the ARM64 specific behavior, so this patch series does exactly

[PATCH v3 1/3] of/fdt: Absorb ARM64's __early_init_dt_declare_initrd()

2018-10-24 Thread Florian Fainelli
ARM64 is the only architecture that requires a re-definition of __early_init_dt_declare_initrd(), absorb its custom implemention in drivers/of/fdt.c. Suggested-by: Rob Herring --- drivers/of/fdt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index

[PATCH v3 2/3] arm64: Remove custom __early_init_dt_declare_initrd implenentation

2018-10-24 Thread Florian Fainelli
Now that drivers/of/fdt.c includes the proper implementation for ARM64, we can get rid of our custom __early_init_dt_declare_initrd() implementation. Signed-off-by: Florian Fainelli --- arch/arm64/include/asm/memory.h | 8 1 file changed, 8 deletions(-) diff --git a/arch/arm64/include/

[PATCH v3 3/3] of/fdt: Remove definition check for __early_init_dt_declare_initrd

2018-10-24 Thread Florian Fainelli
With ARM64 no longer providing a custom __early_init_dt_declare_initrd() in its headers, and no other architecture doing something similar, remove the check for __early_init_dt_declare_initrd being already defined since we now have the one and only definition for it. Signed-off-by: Florian Fainell

[git pull] more ->lookup() cleanups

2018-10-24 Thread Al Viro
Some ->lookup() instances are still overcomplicating the life for themselves, open-coding the stuff that would be handled by d_splice_alias() just fine. Simplify a couple of such cases caught this cycle and document d_splice_alias() intended use. The following changes since commit 5b394b2

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 12:30:52PM -0700, Stephane Eranian wrote: > Hi, > > On Wed, Oct 24, 2018 at 8:12 AM wrote: > > > > From: Kan Liang > > > > To calculate the physical address, perf needs to walk the pages tables. > > The related mapping may has already been removed from pages table in > >

Re: [PATCH 02/17] prmem: write rare for static allocation

2018-10-24 Thread Dave Hansen
> +static __always_inline bool __is_wr_after_init(const void *ptr, size_t size) > +{ > + size_t start = (size_t)&__start_wr_after_init; > + size_t end = (size_t)&__end_wr_after_init; > + size_t low = (size_t)ptr; > + size_t high = (size_t)ptr + size; > + > + return likely(start

Re: [PATCH 0/5] Fix some issues for RTC alarm function

2018-10-24 Thread Alexandre Belloni
On 18/10/2018 16:52:25+0800, Baolin Wang wrote: > This patch set fixes some issues when setting one RTC alarm. > > Baolin Wang (5): > rtc: sc27xx: Set wakeup capability before registering rtc device > rtc: sc27xx: Clear SPG value update interrupt status > rtc: sc27xx: Remove interrupts disab

Re: [PATCH v2] sched/core: Don't mix isolcpus and housekeeping CPUs

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 04:00:02PM +0530, Srikar Dronamraju wrote: > * Peter Zijlstra [2018-10-24 12:03:23]: > > > It appears to me the for_each_online_node() iteration in > > task_numa_migrate() needs an addition test to see if the selected node > > has any CPUs in the relevant sched_domain _at_

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Stephane Eranian
On Wed, Oct 24, 2018 at 5:23 PM Peter Zijlstra wrote: > > On Wed, Oct 24, 2018 at 12:30:52PM -0700, Stephane Eranian wrote: > > Hi, > > > > On Wed, Oct 24, 2018 at 8:12 AM wrote: > > > > > > From: Kan Liang > > > > > > To calculate the physical address, perf needs to walk the pages tables. > > >

Re: [PATCH 03/17] prmem: vmalloc support for dynamic allocation

2018-10-24 Thread Dave Hansen
On 10/23/18 2:34 PM, Igor Stoppa wrote: > +#define VM_PMALLOC 0x0100 /* pmalloc area - see docs */ > +#define VM_PMALLOC_WR0x0200 /* pmalloc write rare > area */ > +#define VM_PMALLOC_PROTECTED 0x0400 /* pmalloc protected area */ Please introdu

Re: [PATCH 05/17] prmem: shorthands for write rare on common types

2018-10-24 Thread Dave Hansen
On 10/23/18 2:34 PM, Igor Stoppa wrote: > Wrappers around the basic write rare functionality, addressing several > common data types found in the kernel, allowing to specify the new > values through immediates, like constants and defines. I have to wonder whether this is the right way, or whether

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 11:28:54AM -0700, Andi Kleen wrote: > > > void perf_event_mmap(struct vm_area_struct *vma) > > > { > > > struct perf_mmap_event mmap_event; > > > > > > if (!atomic_read(&nr_mmap_events)) > > > return; > > > > > > } > > > > > > > Thanks.

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 05:25:59PM -0700, Stephane Eranian wrote: > On Wed, Oct 24, 2018 at 5:23 PM Peter Zijlstra wrote: > > That is actually a different problem. And you're right, we never did fix > > that. > > > it is a different problem but the solution is the same: PERF_RECORD_UNMAP! But he

Re: [PATCH 5/5] rtc: sc27xx: Always read normal alarm when registering RTC device

2018-10-24 Thread Alexandre Belloni
Hello, On 18/10/2018 16:52:30+0800, Baolin Wang wrote: > When registering one RTC device, it will check to see if there is an > alarm already set in RTC hardware by reading RTC alarm, at this time > we should always read the normal alarm put in always-on region by > checking the rtc->registered fl

RE: [PATCH v13 06/12] KVM: x86: Add Intel PT virtualization work mode

2018-10-24 Thread Kang, Luwei
> > From: Chao Peng > > > > Intel Processor Trace virtualization can be work in one of 2 possible > > modes: > > > > a. System-Wide mode (default): > >When the host configures Intel PT to collect trace packets > >of the entire system, it can leave the relevant VMX controls > >clear to

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 08:11:15AM -0700, kan.li...@linux.intel.com wrote: > +void perf_event_munmap(void) > +{ > + struct perf_cpu_context *cpuctx; > + unsigned long flags; > + struct pmu *pmu; > + > + local_irq_save(flags); It is impossible to get here with IRQs already disabled.

RE: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree

2018-10-24 Thread Joakim Zhang
-Original Message- From: Rob Herring [mailto:r...@kernel.org] Sent: 2018年10月25日 7:57 To: Joakim Zhang Cc: linux-...@vger.kernel.org; w...@grandegger.com; m...@pengutronix.de; mark.rutl...@arm.com; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx ; A.s. Dong Subje

Re: [PATCH -V6 00/21] swap: Swapout/swapin THP in one piece

2018-10-24 Thread Huang, Ying
Daniel Jordan writes: > On Wed, Oct 24, 2018 at 11:31:42AM +0800, Huang, Ying wrote: >> Hi, Daniel, >> >> Daniel Jordan writes: >> >> > On Wed, Oct 10, 2018 at 03:19:03PM +0800, Huang Ying wrote: >> >> And for all, Any comment is welcome! >> >> >> >> This patchset is based on the 2018-10-3 he

RE: [PATCH V1 3/3] ARM: dts: sabreauto: Add flexcan support

2018-10-24 Thread Joakim Zhang
-Original Message- From: Fabio Estevam [mailto:feste...@gmail.com] Sent: 2018年10月24日 19:20 To: Joakim Zhang Cc: Shawn Guo ; Sascha Hauer ; Sascha Hauer ; Fabio Estevam ; dl-linux-imx ; Rob Herring ; moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE ; open list:OPEN FIRMWARE AND

Re: [PATCH 1/2] perf: Add munmap callback

2018-10-24 Thread Stephane Eranian
On Wed, Oct 24, 2018 at 5:34 PM Peter Zijlstra wrote: > > On Wed, Oct 24, 2018 at 05:25:59PM -0700, Stephane Eranian wrote: > > On Wed, Oct 24, 2018 at 5:23 PM Peter Zijlstra wrote: > > > > That is actually a different problem. And you're right, we never did fix > > > that. > > > > > it is a diff

Re: [PATCH -V6 06/21] swap: Support PMD swap mapping when splitting huge PMD

2018-10-24 Thread Huang, Ying
Daniel Jordan writes: > On Wed, Oct 10, 2018 at 03:19:09PM +0800, Huang Ying wrote: >> +#ifdef CONFIG_THP_SWAP >> +/* >> + * The corresponding page table shouldn't be changed under us, that >> + * is, the page table lock should be held. >> + */ >> +int split_swap_cluster_map(swp_entry_t entry) >>

Re: [PATCH v3 4/4] nds32: Add document for NDS32 PMU.

2018-10-24 Thread Nick Hu
Hi Rob, On Thu, Oct 25, 2018 at 02:32:48AM +0800, Rob Herring wrote: > On Wed, Oct 24, 2018 at 11:32:40AM +0800, Nickhu wrote: > > The document for how to add NDS32 PMU > > in devicetree. > > > > Signed-off-by: Nickhu > > --- > > Documentation/devicetree/bindings/nds32/pmu.txt | 17

Re: [PATCH -V6 14/21] swap: Support to move swap account for PMD swap mapping

2018-10-24 Thread Huang, Ying
Daniel Jordan writes: > On Wed, Oct 10, 2018 at 03:19:17PM +0800, Huang Ying wrote: >> +static struct page *mc_handle_swap_pmd(struct vm_area_struct *vma, >> +pmd_t pmd, swp_entry_t *entry) >> +{ > > Got > /home/dbbench/linux/mm/memcontrol.c:4719:21: warning: ‘mc_handle_swap_p

[PATCH 2/2] mm/zsmalloc.c: fix zsmalloc ARM LPAE support

2018-10-24 Thread Rafael David Tinoco
Since commit 02390b87a945 ("mm/zsmalloc: Prepare to variable MAX_PHYSMEM_BITS"), an architecture has to define this value in order to guarantee that zsmalloc will be able to encode and decode the obj value properly. Similar to that change, this one sets the value for ARM LPAE, fixing a possible nu

[PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-24 Thread Rafael David Tinoco
On 32-bit systems, zsmalloc uses HIGHMEM and, when PAE is enabled, the physical frame number might be so big that zsmalloc obj encoding (to location) will break IF architecture does not re-define MAX_PHYSMEM_BITS, causing: [ 497.097843] ===

[PATCH v3 3/3] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2018-10-24 Thread Brian Masney
This patch adds device device tree bindings for the vibrator found on the LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney --- .../qcom-msm8974-lge-nexus5-hammerhead.dts| 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus

Re: TSC to Mono-raw Drift

2018-10-24 Thread Christopher Hall
On Wed, Oct 24, 2018 at 04:51:13PM +0200, Miroslav Lichvar wrote: > On Tue, Oct 23, 2018 at 11:31:00AM -0700, John Stultz wrote: > > On Fri, Oct 19, 2018 at 3:36 PM, John Stultz wrote: > > > On Fri, Oct 19, 2018 at 1:50 PM, Thomas Gleixner > > > wrote: > > >> On Fri, 19 Oct 2018, John Stultz wro

<    1   2   3   4   5   >