-----Original Message-----
From: Fabio Estevam [mailto:feste...@gmail.com]
Sent: 2018年10月24日 19:20
To: Joakim Zhang <qiangqing.zh...@nxp.com>
Cc: Shawn Guo <shawn...@kernel.org>; Sascha Hauer <s.ha...@pengutronix.de>;
Sascha Hauer <ker...@pengutronix.de>; Fabio Estevam <fabio.este...@nxp.com>;
dl-linux-imx <linux-...@nxp.com>; Rob Herring <robh...@kernel.org>; moderated
list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
<linux-arm-ker...@lists.infradead.org>; open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS <devicet...@vger.kernel.org>; linux-kernel
<linux-kernel@vger.kernel.org>; A.s. Dong <aisheng.d...@nxp.com>
Subject: Re: [PATCH V1 3/3] ARM: dts: sabreauto: Add flexcan support
Hi Joakim,
On Wed, Oct 24, 2018 at 8:15 AM Joakim Zhang <qiangqing.zh...@nxp.com> wrote:
> diff --git a/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
> b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
> new file mode 100644
> index 000000000000..963e0b559d60
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2013 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
You can remove this paragraph as you are using SPDX tag.
> +++ b/arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2013 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
Ditto.
> +&can1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flexcan1>;
> + pinctrl-assert-gpios = <&max7310_b 3 GPIO_ACTIVE_HIGH>; /* TX */
This property does not exist in upstream.
Hi Fabio,
I will modify what you have commented. Thanks a lot.
Best Regards,
Joakim Zhang
