Re: [PATCH -mm -v4 04/21] mm, THP, swap: Support PMD swap mapping in swapcache_free_cluster()

2018-07-09 Thread Dave Hansen
> +#ifdef CONFIG_THP_SWAP > +static inline int cluster_swapcount(struct swap_cluster_info *ci) > +{ > + if (!ci || !cluster_is_huge(ci)) > + return 0; > + > + return cluster_count(ci) - SWAPFILE_CLUSTER; > +} > +#else > +#define cluster_swapcount(ci)0 > +

Re: [PATCH 05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC

2018-07-09 Thread Vinod
On 03-07-18, 14:32, Paul Cercueil wrote: > enum jz_version { > + ID_JZ4740, > ID_JZ4770, > ID_JZ4780, > }; > @@ -247,6 +248,7 @@ static void jz4780_dma_desc_free(struct virt_dma_desc > *vdesc) > } > > static const unsigned int jz4780_dma_ord_max[] = { > + [ID_JZ4740] = 5

Re: [PATCH 06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC

2018-07-09 Thread Vinod
On 03-07-18, 14:32, Paul Cercueil wrote: > The JZ4725B has one DMA core starring six DMA channels. > As for the JZ4770, each DMA channel's clock can be enabled with > a register write, the difference here being that once started, it > is not possible to turn it off. ok so disable for this, right..

Re: [PATCH 0/2] mm/fs: put_user_page() proposal

2018-07-09 Thread Matthew Wilcox
On Mon, Jul 09, 2018 at 06:08:06PM +0200, Jan Kara wrote: > On Mon 09-07-18 18:49:37, Nicholas Piggin wrote: > > The problem with blocking in clear_page_dirty_for_io is that the fs is > > holding the page lock (or locks) and possibly others too. If you > > expect to have a bunch of long term refere

Re: [PATCH v2 0/3] Support rseq on arm64

2018-07-09 Thread Mathieu Desnoyers
- On Jul 9, 2018, at 12:53 PM, Will Deacon will.dea...@arm.com wrote: > On Mon, Jul 09, 2018 at 12:06:22PM -0400, Mathieu Desnoyers wrote: >> - On Jul 9, 2018, at 10:19 AM, Will Deacon will.dea...@arm.com wrote: >> >> > Hello, >> > >> > This is version two of the patches previously poste

Re: [PATCH -mm -v4 05/21] mm, THP, swap: Support PMD swap mapping in free_swap_and_cache()/swap_free()

2018-07-09 Thread Dave Hansen
I'm seeing a pattern here. old code: foo() { do_swap_something() } new code: foo(bool cluster) { if (cluster) do_swap_cluster_something(); else do_swap_something(); } That make me fear that we have: 1. Created a new, wholly untested code

Re: [PATCH v2 0/5] Improve Broadcom PAXC support

2018-07-09 Thread Lorenzo Pieralisi
On Mon, Jun 11, 2018 at 05:21:02PM -0700, Ray Jui wrote: > This patch series improves the Broadcom PAXC support by 1) adding more > quirks for specific versions of PAXC controllers; 2) adding logic to > reject internally unconfigured physical functions from the embedded > network processor acting a

Re: [PATCH -mm -v4 14/21] mm, cgroup, THP, swap: Support to move swap account for PMD swap mapping

2018-07-09 Thread Daniel Jordan
On Fri, Jun 22, 2018 at 11:51:44AM +0800, Huang, Ying wrote: > Because there is no way to prevent a huge swap cluster from being > split except when it has SWAP_HAS_CACHE flag set. What about making get_mctgt_type_thp take the cluster lock? That function would be the first lock_cluster user outsi

Re: kernel BUG at mm/memory.c:LINE!

2018-07-09 Thread Dmitry Vyukov
On Mon, Jul 9, 2018 at 5:25 PM, Kirill A. Shutemov wrote: > On Mon, Jul 09, 2018 at 05:21:55PM +0300, Kirill A. Shutemov wrote: >> > This also happened only once so far: >> > https://syzkaller.appspot.com/bug?extid=3f84280d52be9b7083cc >> > and I can't reproduce it rerunning this program. So it's

Re: [PATCH 7/7] aio: implement io_pgetevents

2018-07-09 Thread Stephan Müller
Am Sonntag, 8. Juli 2018, 22:44:00 CEST schrieb Christoph Hellwig: Hi Christoph, > > diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h > index 75846164290e..b7705ad66d78 100644 > --- a/include/uapi/linux/aio_abi.h > +++ b/include/uapi/linux/aio_abi.h > @@ -29,7 +29,11 @@ >

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-09 Thread Bjorn Andersson
On Tue 19 Jun 16:43 PDT 2018, Evan Green wrote: > The MSM pinctrl driver quietly swallows errors that occur > when trying to call .irq_set_wake. It should instead pass > those failures up the chain so the caller can react to them. > Swallowing the error for instance causes gpio_keys to think that

Re: [PATCH] dma: stm32: replace "%p" with "%pK"

2018-07-09 Thread Vinod
On 06-07-18, 15:02, Benjamin Gaignard wrote: > The format specifier "%p" can leak kernel addresses. > Use "%pK" instead. The subsystem name is 'dmaengine' and not dma. The git log on the subsystem should have told you this Applied after fixing the tag, thanks. -- ~Vinod

Re: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-09 Thread Mathieu Desnoyers
- On Jul 8, 2018, at 5:03 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > In preparation to use __u64 for the rseq_cs pointer field, 32-bit > architectures need to read this 64-bit value located in user-space > addresses. > > __get_user is used to read this value, given that it

Re: [PATCH v2 0/5] Improve Broadcom PAXC support

2018-07-09 Thread Ray Jui
Hi Lorenzo, On 7/9/2018 10:22 AM, Lorenzo Pieralisi wrote: On Mon, Jun 11, 2018 at 05:21:02PM -0700, Ray Jui wrote: This patch series improves the Broadcom PAXC support by 1) adding more quirks for specific versions of PAXC controllers; 2) adding logic to reject internally unconfigured physical

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-07-09 Thread Daniel Lustig
On 7/9/2018 9:52 AM, Will Deacon wrote: > On Fri, Jul 06, 2018 at 02:10:55PM -0700, Paul E. McKenney wrote: >> On Fri, Jul 06, 2018 at 04:37:21PM -0400, Alan Stern wrote: >>> On Thu, 5 Jul 2018, Andrea Parri wrote: >>> > At any rate, it looks like instead of strengthening the relation, I >

Re: [PATCH] dma: add support for reporting pause and resume separately

2018-07-09 Thread Vinod
On 02-07-18, 15:08, Marek Szyprowski wrote: > 'cmd_pause' DMA channel capability means that respective DMA engine > supports both pausing and resuming given DMA channel. However, in some > cases it is important to know if DMA channel can be paused without the > need to resume it. This is a typical

Re: [PATCH v2 1/5] PCI: iproc: Activate PAXC bridge quirk for more devices

2018-07-09 Thread Ray Jui
Hi Bjorn, Could you please help to review/ack this patch, based on the following comments from Lorenzo? > apart from patch 1, that requires Bjorn's ACK, I would take the > series (I will rewrite the logs) Thanks, Ray On 6/12/2018 1:30 AM, p...@codeaurora.org wrote: On 2018-06-12 05:51, Ray

[PATCH 1/2] x86/hyper-v: check cpumask_to_vpset() return value in hyperv_flush_tlb_others_ex()

2018-07-09 Thread Vitaly Kuznetsov
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI enlightenment") made cpumask_to_vpset() return '-1' when there is a CPU with unknown VP index in the supplied set. This needs to be checked before we pass 'nr_bank' to hypercall. Fixes: 1268ed0c474a ("x86/hyper-v: Fix the circul

[PATCH 0/2] x86/hyper-v: cope with VP_INVAL in PV TLB flush code

2018-07-09 Thread Vitaly Kuznetsov
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI enlightenment") made it possible to observe VP_INVAL returned from hv_cpu_number_to_vp_number() and cpumask_to_vpset() and PV TLB flush code needs to be adjusted. The window when VP_INVAL is observable is very short, I'm not e

Re: [PATCH v4 6/6] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG

2018-07-09 Thread Florian Fainelli
On Mon, 28 May 2018 11:01:37 -0700, Ray Jui wrote: > Enable the SP805 watchdog timer > > Signed-off-by: Ray Jui > --- Applied to defconfig-arm64/next, thanks! -- Florian

[PATCH 2/2] x86/hyper-v: check for VP_INVAL in hyperv_flush_tlb_others()

2018-07-09 Thread Vitaly Kuznetsov
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI enlightenment") pre-filled hv_vp_index with VP_INVAL so it is now (theoretically) possible to observe hv_cpu_number_to_vp_number() returning VP_INVAL. We need to check for that in hyperv_flush_tlb_others(). Not checking for VP_

Re: [PATCH v4 5/6] arm64: dt: set initial SR watchdog timeout to 60 seconds

2018-07-09 Thread Florian Fainelli
On 05/28/2018 11:01 AM, Ray Jui wrote: > Set initial Stingray watchdog timeout to 60 seconds > > By the time when the userspace watchdog daemon is ready and taking > control over, the watchdog timeout will then be reset to what's > configured in the daemon > > Signed-off-by: Ray Jui > Reviewe

Re: [PATCH v7 01/10] counter: Introduce the Generic Counter interface

2018-07-09 Thread William Breathitt Gray
On Sat, Jul 07, 2018 at 05:16:22PM +0200, Greg KH wrote: >On Thu, Jun 21, 2018 at 05:07:08PM -0400, William Breathitt Gray wrote: >> This patch introduces the Generic Counter interface for supporting >> counter devices. >> >> In the context of the Generic Counter interface, a counter is defined as

Re: [PATCH] IB/cm: Remove unused and erroneous msg sequence encoding

2018-07-09 Thread Jason Gunthorpe
On Wed, Jul 04, 2018 at 12:48:01PM +0200, Håkon Bugge wrote: > In cm_form_tid(), a two bit message sequence number is OR'ed into bit > 31-30 of the lower TID value. > > After commit f06d26537559 ("IB/cm: Randomize starting comm ID"), the > local_id is XOR'ed with a 32-bit random value. Hence, bit

[PATCH v4 0/3] sparse_init rewrite

2018-07-09 Thread Pavel Tatashin
Changelog: v4 - v3 - Addressed comments from Dave Hansen v3 - v1 - Fixed two issues found by Baoquan He v1 - v2 - Addressed comments from Oscar Salvador In sparse_init() we allocate two large buffers to temporary hold usemap and memmap for the whole machine. However, we can

[PATCH v4 1/3] mm/sparse: add sparse_init_nid()

2018-07-09 Thread Pavel Tatashin
sparse_init() requires to temporary allocate two large buffers: usemap_map and map_map. Baoquan He has identified that these buffers are so large that Linux is not bootable on small memory machines, such as a kdump boot. The buffers are especially large when CONFIG_X86_5LEVEL is set, as they are sc

[PATCH v4 3/3] mm/sparse: refactor sparse vmemmap buffer allocations

2018-07-09 Thread Pavel Tatashin
When struct pages are allocated for sparse-vmemmap VA layout, we first try to allocate one large buffer, and than if that fails allocate struct pages for each section as we go. The code that allocates buffer is uses global variables and is spread across several call sites. Cleanup the code by int

[PATCH v4 2/3] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-09 Thread Pavel Tatashin
Change sprase_init() to only find the pnum ranges that belong to a specific node and call sprase_init_nid() for that range from sparse_init(). Delete all the code that became obsolete with this change. Signed-off-by: Pavel Tatashin Reviewed-by: Oscar Salvador --- include/linux/mm.h | 5 - m

Build/qemu test results for v4.18-rc4

2018-07-09 Thread Guenter Roeck
Build results: total: 134 pass: 130 fail: 4 Failed builds: nds32:defconfig nds32:allnoconfig s390:allmodconfig sparc32:allmodconfig Qemu test results: total: 158 pass: 158 fail: 0 --- nds32:defconfig: nds32le-linux-ld: kernel/time/timekeeping.o:

Re: [PATCH v4 1/5] KVM: x86: hyperv: enforce vp_index < KVM_MAX_VCPUS

2018-07-09 Thread Roman Kagan
On Tue, Jul 03, 2018 at 03:42:02PM +0200, Vitaly Kuznetsov wrote: > Hyper-V TLFS (5.0b) states: > > > Virtual processors are identified by using an index (VP index). The > > maximum number of virtual processors per partition supported by the > > current implementation of the hypervisor can be obta

Re: [PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-09 Thread Rob Herring
On Sun, Jul 1, 2018 at 11:58 PM Robert Jarzmik wrote: > > Add device-tree description of the Mitac MIO A701 board. > This is aimed at replacing mioa701.c board file, and once stabilized, > the leftover, such as the suspend resume mechanics will rely on a new > IPL, and not the legacy Windows CE on

Re: [PATCHv4 02/18] mm/ksm: Do not merge pages with different KeyIDs

2018-07-09 Thread Konrad Rzeszutek Wilk
On Tue, Jun 26, 2018 at 05:22:29PM +0300, Kirill A. Shutemov wrote: > Pages encrypted with different encryption keys are not subject to KSM Perhaps not allowed instead of subject? > merge. Otherwise it would cross security boundary. > > Signed-off-by: Kirill A. Shutemov > --- > include/linux/mm

Re: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-09 Thread Linus Torvalds
On Mon, Jul 9, 2018 at 10:28 AM Mathieu Desnoyers wrote: > > So, another twist to this story: ppc32 does not implement u64 get_user(). I was going to say that "that's not possible", since we actually have 64-bit arguments at least in the form of "loff_t __user *". But when I started looking, it

Re: [PATCH for 4.18 0/6] Restartable Sequences updates

2018-07-09 Thread Mathieu Desnoyers
- On Jul 8, 2018, at 5:03 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > Following the recent discussion thread [1] about rseq uapi, here is > a set of updates submitted for integration into 4.18. Those change all > rseq __get_user/__put_user for get_user/put_user as discussed.

Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

2018-07-09 Thread Nick Terrell
> On Mar 21, 2018, at 6:29 PM, Nick Terrell wrote: > This patch set adds support for a ZSTD-compressed kernel and ramdisk > images in the kernel boot process. It only integrates the support with > x86, though the first patch is generic to all architectures. Hi all, Is there anything blocking thi

Re: Build/qemu test results for v4.18-rc4

2018-07-09 Thread Kees Cook
On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck wrote: > s390:allmodconfig: > > arch/s390/kernel/als.o: In function `verify_facilities': > als.c:(.init.text+0x24): undefined reference to `latent_entropy' > als.c:(.init.text+0xae): undefined reference to `latent_entropy' > make[3]: *** [arch/s390/bo

Re: [RFC PATCH v4 03/12] PM: Introduce an Energy Model management framework

2018-07-09 Thread Dietmar Eggemann
On 06/28/2018 01:40 PM, Quentin Perret wrote: [...] +/** + * em_rescale_cpu_capacity() - Re-scale capacity values of the Energy Model + * + * This re-scales the capacity values for all capacity states of all frequency + * domains of the Energy Model. This should be used when the capacity values

Re: [PATCHv4 07/18] x86/mm: Introduce variables to store number, shift and mask of KeyIDs

2018-07-09 Thread Konrad Rzeszutek Wilk
> diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile > index 4b101dd6e52f..4ebee899c363 100644 > --- a/arch/x86/mm/Makefile > +++ b/arch/x86/mm/Makefile > @@ -53,3 +53,5 @@ obj-$(CONFIG_PAGE_TABLE_ISOLATION) += pti.o > obj-$(CONFIG_AMD_MEM_ENCRYPT)+= mem_encrypt.o > obj-$(C

Re: Build/qemu test results for v4.18-rc4

2018-07-09 Thread Christian Borntraeger
On 07/09/2018 08:06 PM, Kees Cook wrote: > On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck wrote: >> s390:allmodconfig: >> >> arch/s390/kernel/als.o: In function `verify_facilities': >> als.c:(.init.text+0x24): undefined reference to `latent_entropy' >> als.c:(.init.text+0xae): undefined referen

Re: LKMM patch scorecard for v4.19 merge window

2018-07-09 Thread Alan Stern
On Fri, 6 Jul 2018, Paul E. McKenney wrote: > Hello! > > Here is the updated scorecard: > > e9ff68680cd4 tools/memory-model: Add litmus test for full multicopy atomicity > c21fcc6594f1 tools/memory-model: Fix ISA2+pooncelock+pooncelock+pombonce name > 2f5a1b9b74a2 MAINTAINERS: Add Daniel Lustig

Re: [PATCH v4 2/5] KVM: x86: hyperv: optimize 'all cpus' case in kvm_hv_flush_tlb()

2018-07-09 Thread Roman Kagan
On Tue, Jul 03, 2018 at 03:42:03PM +0200, Vitaly Kuznetsov wrote: > We can use 'NULL' to represent 'all cpus' case in > kvm_make_vcpus_request_mask() and avoid building vCPU mask with > all vCPUs. > > Suggested-by: Radim Krčmář > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/kvm/hyperv.c | 4

Re: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-09 Thread Mathieu Desnoyers
- On Jul 9, 2018, at 2:04 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Mon, Jul 9, 2018 at 10:28 AM Mathieu Desnoyers > wrote: >> >> So, another twist to this story: ppc32 does not implement u64 get_user(). > > I was going to say that "that's not possible", since we actually

Re: Build/qemu test results for v4.18-rc4

2018-07-09 Thread Kees Cook
On Mon, Jul 9, 2018 at 11:16 AM, Christian Borntraeger wrote: > > > On 07/09/2018 08:06 PM, Kees Cook wrote: >> On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck wrote: >>> s390:allmodconfig: >>> >>> arch/s390/kernel/als.o: In function `verify_facilities': >>> als.c:(.init.text+0x24): undefined refe

Re: [PATCHv4 13/18] x86/mm: Allow to disable MKTME after enumeration

2018-07-09 Thread Konrad Rzeszutek Wilk
On Tue, Jun 26, 2018 at 05:22:40PM +0300, Kirill A. Shutemov wrote: > The new helper mktme_disable() allows to disable MKTME even if it's > enumerated successfully. MKTME initialization may fail and this > functionality allows system to boot regardless of the failure. > > MKTME needs per-KeyID dir

Re: [PATCH 12/12] ipc/util.c: Further ipc_idr_alloc cleanups.

2018-07-09 Thread Manfred Spraul
Hello Dmitry, On 07/09/2018 07:05 PM, Dmitry Vyukov wrote: On Mon, Jul 9, 2018 at 5:10 PM, Manfred Spraul wrote: If idr_alloc within ipc_idr_alloc fails, then the return value (-ENOSPC) is used to calculate new->id. Technically, this is not a bug, because new->id is never accessed. But: Clean

Re: [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device"

2018-07-09 Thread Kevin Hilman
On Mon, Jul 9, 2018 at 8:45 AM Sudeep Holla wrote: > > This reverts commit 1332a90558013ae4242e3dd7934bdcdeafb06c0d. > > The original issue was not because of incorrect checking of cpumask for > both new and old tick device. It was incorrectly analysed was due to the > misunderstanding of the comm

Re: [PATCH v2 0/7] tracing: Hist trigger snapshot and onchange additions

2018-07-09 Thread Tom Zanussi
Hi Masami, On Sun, 2018-07-08 at 00:00 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Mon, 2 Jul 2018 15:22:19 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Hi, > > > > This is v2 of the hist trigger snapshot and onchange additions > > patchset. It adds a couple fixes to prob

Re: Build/qemu test results for v4.18-rc4

2018-07-09 Thread Guenter Roeck
On Mon, Jul 09, 2018 at 08:16:04PM +0200, Christian Borntraeger wrote: > > > On 07/09/2018 08:06 PM, Kees Cook wrote: > > On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck wrote: > >> s390:allmodconfig: > >> > >> arch/s390/kernel/als.o: In function `verify_facilities': > >> als.c:(.init.text+0x24):

Re: [PATCH v4 3/5] KVM: x86: hyperv: use get_vcpu_by_vpidx() in kvm_hv_flush_tlb()

2018-07-09 Thread Roman Kagan
On Tue, Jul 03, 2018 at 03:42:04PM +0200, Vitaly Kuznetsov wrote: > VP_INDEX almost always matches VCPU id and get_vcpu_by_vpidx() is fast, > use it instead of traversing full vCPU list every time. > > To support the change split off get_vcpu_idx_by_vpidx() from > get_vcpu_by_vpidx(). > > Signed-

Re: Build/qemu test results for v4.18-rc4

2018-07-09 Thread Guenter Roeck
On Mon, Jul 09, 2018 at 11:19:17AM -0700, Kees Cook wrote: > On Mon, Jul 9, 2018 at 11:16 AM, Christian Borntraeger > wrote: > > > > > > On 07/09/2018 08:06 PM, Kees Cook wrote: > >> On Mon, Jul 9, 2018 at 10:55 AM, Guenter Roeck wrote: > >>> s390:allmodconfig: > >>> > >>> arch/s390/kernel/als.o:

Re: [PATCH 12/12] ipc/util.c: Further ipc_idr_alloc cleanups.

2018-07-09 Thread Dmitry Vyukov
On Mon, Jul 9, 2018 at 8:22 PM, Manfred Spraul wrote: > Hello Dmitry, > > > On 07/09/2018 07:05 PM, Dmitry Vyukov wrote: >> >> On Mon, Jul 9, 2018 at 5:10 PM, Manfred Spraul >> wrote: >>> >>> If idr_alloc within ipc_idr_alloc fails, then the return value (-ENOSPC) >>> is used to calculate new->id

Re: [PATCH v4 4/5] x86/hyper-v: rename ipi_arg_{ex,non_ex} structures

2018-07-09 Thread Roman Kagan
On Tue, Jul 03, 2018 at 03:42:05PM +0200, Vitaly Kuznetsov wrote: > These structures are going to be used from KVM code so let's make > their names reflect their Hyper-V origin. > > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/hyperv/hv_apic.c | 12 ++-- > arch/x86/include/a

Re: [PATCHv4 15/18] x86/mm: Calculate direct mapping size

2018-07-09 Thread Konrad Rzeszutek Wilk
On Tue, Jun 26, 2018 at 05:22:42PM +0300, Kirill A. Shutemov wrote: > The kernel needs to have a way to access encrypted memory. We have two > option on how approach it: > > - Create temporary mappings every time kernel needs access to encrypted >memory. That's basically brings highmem and it

RE: [PATCH net] hv_netvsc: Fix napi reschedule while receive completion is busy

2018-07-09 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Monday, July 9, 2018 2:15 PM > To: Haiyang Zhang > Cc: Haiyang Zhang ; da...@davemloft.net; > net...@vger.kernel.org; o...@aepfle.de; Stephen Hemminger > ; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; vkuzn...@redh

Re: [PATCH] ARM: module: fix modsign build error

2018-07-09 Thread Jessica Yu
+++ Russell King - ARM Linux [06/07/18 14:00 +0100]: On Fri, Jul 06, 2018 at 02:48:47PM +0200, Arnd Bergmann wrote: The asm/module.h header file can not be included standalone, which breaks the module signing code after a recent change: In file included from kernel/module-internal.h:13,

Re: [PATCHv4 18/18] x86: Introduce CONFIG_X86_INTEL_MKTME

2018-07-09 Thread Konrad Rzeszutek Wilk
On Tue, Jun 26, 2018 at 05:22:45PM +0300, Kirill A. Shutemov wrote: > Add new config option to enabled/disable Multi-Key Total Memory > Encryption support. > > MKTME uses MEMORY_PHYSICAL_PADDING to reserve enough space in per-KeyID > direct mappings for memory hotplug. > > Signed-off-by: Kirill A

Re: [PATCH v6 0/6] mtd: rawnand: support MT29F1G08ABAFAWP-ITE:F

2018-07-09 Thread Boris Brezillon
On Mon, 9 Jul 2018 18:31:24 +0200 Boris Brezillon wrote: > Hi Bean, > > On Mon, 9 Jul 2018 15:54:11 + > "Bean Huo (beanhuo)" wrote: > > > Hi, Boris and Chris > > > > >> > > >> I see 2 solutions to this problem: > > >> 1/ Bean provides us a solution to reliably detect when ECC can be > >

Re: [PATCHv4 18/18] x86: Introduce CONFIG_X86_INTEL_MKTME

2018-07-09 Thread Dave Hansen
On 07/09/2018 11:36 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Jun 26, 2018 at 05:22:45PM +0300, Kirill A. Shutemov wrote: > Rip out the X86? >> +bool "Intel Multi-Key Total Memory Encryption" >> +select DYNAMIC_PHYSICAL_MASK >> +select PAGE_EXTENSION > > And maybe select 5-page? Why?

Re: [PATCH 05/12] ipc/util.c: correct comment in ipc_obtain_object_check

2018-07-09 Thread Davidlohr Bueso
On Mon, 09 Jul 2018, Manfred Spraul wrote: The comment that explains ipc_obtain_object_check is wrong: The function checks the sequence number, not the reference counter. Note that checking the reference counter would be meaningless: The reference counter is decreased without holding any locks,

Re: [PATCH 1/2] mm: introduce put_user_page(), placeholder version

2018-07-09 Thread John Hubbard
On 07/09/2018 03:08 AM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] ... > >>> drivers/platform//goldfish/goldfish_pipe.c:334:13: error: conflicting types >>> for 'release_user_pages' > static void rel

Re: [RFC] Make need_resched() return true when rcu_urgent_qs requested

2018-07-09 Thread David Woodhouse
On Mon, 2018-07-09 at 09:34 -0700, Paul E. McKenney wrote: > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 51919985f6cf..33b0a1ec0536 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2496,6 +2496,10 @@ void rcu_check_callbacks(int user) >  { >   trace_rcu_utilizat

Re: [PATCHv4 18/18] x86: Introduce CONFIG_X86_INTEL_MKTME

2018-07-09 Thread Konrad Rzeszutek Wilk
On Mon, Jul 09, 2018 at 11:44:33AM -0700, Dave Hansen wrote: > On 07/09/2018 11:36 AM, Konrad Rzeszutek Wilk wrote: > > On Tue, Jun 26, 2018 at 05:22:45PM +0300, Kirill A. Shutemov wrote: > > Rip out the X86? > >> + bool "Intel Multi-Key Total Memory Encryption" > >> + select DYNAMIC_PHYSICAL_MAS

Re: [PATCH v7 01/10] counter: Introduce the Generic Counter interface

2018-07-09 Thread Greg KH
On Mon, Jul 09, 2018 at 01:40:36PM -0400, William Breathitt Gray wrote: > I'll make the updates noted in a version 8 submission, but I'll wait to > submit it until you have a chance to review the rest of this current > patchset. The counter device drivers in this directory (104-quad-8.c, > stm32-lp

Re: [PATCH v7 01/10] counter: Introduce the Generic Counter interface

2018-07-09 Thread William Breathitt Gray
On Mon, Jul 09, 2018 at 08:54:17PM +0200, Greg KH wrote: >On Mon, Jul 09, 2018 at 01:40:36PM -0400, William Breathitt Gray wrote: >> I'll make the updates noted in a version 8 submission, but I'll wait to >> submit it until you have a chance to review the rest of this current >> patchset. The count

Re: [PATCHv4 18/18] x86: Introduce CONFIG_X86_INTEL_MKTME

2018-07-09 Thread Dave Hansen
On 07/09/2018 11:52 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 09, 2018 at 11:44:33AM -0700, Dave Hansen wrote: >> On 07/09/2018 11:36 AM, Konrad Rzeszutek Wilk wrote: >>> On Tue, Jun 26, 2018 at 05:22:45PM +0300, Kirill A. Shutemov wrote: >>> Rip out the X86? + bool "Intel Multi-Key Tota

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-07-09 Thread Shenwei Wang
Thank you, Thierry. Have you also reviewed and accepted the other 3 patches in this serial? Regards, Shenwei -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Monday, July 9, 2018 12:09 PM To: Shenwei Wang Cc: linux-...@vger.kernel.org; dl-linux-imx ; lin

Re: cgroup trace events acquire sleeping locks

2018-07-09 Thread Steven Rostedt
On Mon, 9 Jul 2018 18:38:05 +0200 Sebastian Andrzej Siewior wrote: > Clark showed me this: > > | BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:974 > | in_atomic(): 1, irqs_disabled(): 0, pid: 1, name: systemd > | 5 locks held by systemd/1: > | #0: (sb_writer

Re: [PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-09 Thread Linus Torvalds
On Mon, Jul 9, 2018 at 11:19 AM Mathieu Desnoyers wrote: > > Given that this memory area has already been checked with access_ok() > on rseq registration, are you fine with leaving > __get_user/__put_user/__copy_{from,to}_user in place so we do the > minimal change at this stage of rc, or should I

Re: [PATCH] x86: Avoid pr_cont() in show_opcodes()

2018-07-09 Thread Josh Poimboeuf
On Mon, Jul 09, 2018 at 10:49:53AM +0200, Peter Zijlstra wrote: > On Sat, Jul 07, 2018 at 10:54:28PM +0900, Tetsuo Handa wrote: > > >> Since syzbot is confused by concurrent printk() messages [1], > > >> this patch changes show_opcodes() to use snprintf(). > > But how big of a problem is that real

Re: [PATCH v2] IB/mlx5: fix uaccess beyond "count" in debugfs read/write handlers

2018-07-09 Thread Jason Gunthorpe
On Fri, Jul 06, 2018 at 10:48:03PM +0200, Jann Horn wrote: > In general, accessing userspace memory beyond the length of the supplied > buffer in VFS read/write handlers can lead to both kernel memory corruption > (via kernel_read()/kernel_write(), which can e.g. be triggered via > sys_splice()) an

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-07-09 Thread Alan Stern
On Mon, 9 Jul 2018, Daniel Lustig wrote: > On 7/9/2018 9:52 AM, Will Deacon wrote: > > On Fri, Jul 06, 2018 at 02:10:55PM -0700, Paul E. McKenney wrote: > >> On Fri, Jul 06, 2018 at 04:37:21PM -0400, Alan Stern wrote: > >>> On Thu, 5 Jul 2018, Andrea Parri wrote: > >>> > > At any rate, it look

Re: [PATCH v2 0/7] perf: Add ioctl for PMU driver configuration

2018-07-09 Thread Mathieu Poirier
On Fri, 6 Jul 2018 at 17:38, Kim Phillips wrote: > > On Thu, 5 Jul 2018 16:13:40 -0600 > Mathieu Poirier wrote: > > > This set adds the capability to communiate event specific configuration > > to the PMU kernel driver using an ioctl(). The functionatlity is made > > generic enough for anyone t

Re: [PATCH] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Josh Poimboeuf
On Sun, Jul 08, 2018 at 06:59:42PM +0900, Masahiro Yamada wrote: > Currently, users are allowed to enable STACK_VALIDATION regardless > of the compiler capability. The top-level Makefile warns or breaks > the build if it turns out that the host compiler cannot link libelf. > > Move the libelf tes

Re: [PATCH 7/7] aio: implement io_pgetevents

2018-07-09 Thread Stephan Müller
Am Sonntag, 8. Juli 2018, 22:44:00 CEST schrieb Christoph Hellwig: Hi Christoph, > > diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h > index 75846164290e..b7705ad66d78 100644 > --- a/include/uapi/linux/aio_abi.h > +++ b/include/uapi/linux/aio_abi.h > @@ -29,7 +29,11 @@ >

Re: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check

2018-07-09 Thread Dan Carpenter
On Mon, Jul 09, 2018 at 10:01:11AM -0500, Ioana Radulescu wrote: > @@ -2385,6 +2365,12 @@ static int netdev_init(struct net_device *net_dev) > > /* Set MTU upper limit; lower limit is 68B (default value) */ > net_dev->max_mtu = DPAA2_ETH_MAX_MTU; > + err = dpni_set_max_frame_lengt

[PATCH v3] mtd: rawnand: ams-delta: use GPIO lookup table

2018-07-09 Thread Janusz Krzysztofik
Now as Amstrad Delta board - the only user of this driver - provides GPIO lookup tables, switch from GPIO numbers to GPIO descriptors and use the table to locate required GPIO pins. Declare static variables for storing GPIO descriptors and replace gpio_ function calls with their gpiod_ equivalents

Re: [PATCH 0/2] mm/fs: put_user_page() proposal

2018-07-09 Thread Jan Kara
On Mon 09-07-18 10:16:51, Matthew Wilcox wrote: > On Mon, Jul 09, 2018 at 06:08:06PM +0200, Jan Kara wrote: > > On Mon 09-07-18 18:49:37, Nicholas Piggin wrote: > > > The problem with blocking in clear_page_dirty_for_io is that the fs is > > > holding the page lock (or locks) and possibly others to

Re: [PATCH 04/12] ipc: Rename ipcctl_pre_down_nolock().

2018-07-09 Thread Davidlohr Bueso
On Mon, 09 Jul 2018, Manfred Spraul wrote: Both the comment and the name of ipcctl_pre_down_nolock() are misleading: The function must be called while holdling the rw semaphore. Therefore the patch renames the function to ipcctl_obtain_check(): This name matches the other names used in util.c: -

[PATCH for 4.18 4/6] rseq: uapi: declare rseq_cs field as union, update includes

2018-07-09 Thread Mathieu Desnoyers
Declaring the rseq_cs field as a union between __u64 and two __u32 allows both 32-bit and 64-bit kernels to read the full __u64, and therefore validate that a 32-bit user-space cleared the upper 32 bits, thus ensuring a consistent behavior between native 32-bit kernels and 32-bit compat tasks on 64

[PATCH v2 for 4.18 0/6] Restartable Sequences updates

2018-07-09 Thread Mathieu Desnoyers
Following the recent discussion thread [1] about rseq uapi, here is a set of updates submitted for integration into 4.18. Those change all rseq __get_user/__put_user for get_user/put_user as discussed, and use copy_from_user()/clear_user() to load and clear the rseq_cs __u64. Thanks, Mathieu [1]

[PATCH for 4.18 5/6] rseq: remove unused types_32_64.h uapi header

2018-07-09 Thread Mathieu Desnoyers
This header was introduced in the 4.18 merge window, and rseq does not need it anymore. Nuke it before the final release. Signed-off-by: Mathieu Desnoyers CC: "Paul E. McKenney" CC: Peter Zijlstra CC: Paul Turner CC: Thomas Gleixner CC: Andy Lutomirski CC: Andi Kleen CC: Dave Watson CC: Ch

[PATCH for 4.18 6/6] rseq/selftests: cleanup: update comment above rseq_prepare_unload

2018-07-09 Thread Mathieu Desnoyers
rseq as it was merged does not have rseq_finish_*() in the user-space selftests anymore. Update the rseq_prepare_unload() helper comment to adapt to this reality. Signed-off-by: Mathieu Desnoyers CC: "Paul E. McKenney" CC: Peter Zijlstra CC: Paul Turner CC: Thomas Gleixner CC: Andy Lutomirski

[PATCH for 4.18 3/6] rseq: uapi: update uapi comments

2018-07-09 Thread Mathieu Desnoyers
Update rseq uapi header comments to reflect that user-space need to do thread-local loads/stores from/to the struct rseq fields. As a consequence of this added requirement, the kernel does not need to perform loads/stores with single-copy atomicity. Update the comment associated to the "flags" fi

Re: [PATCH] gpio: aspeed: fix compile testing warning

2018-07-09 Thread Arnd Bergmann
On Mon, Jul 9, 2018 at 5:31 PM, Alexander Stein wrote: > On Monday, July 9, 2018, 4:56:03 PM CEST Arnd Bergmann wrote: >> Gcc cannot always see that BUG_ON(1) is guaranteed to not >> return, so we get a warning message in some configurations: >> >> drivers/gpio/gpio-aspeed.c: In function 'bank_reg

[PATCH for 4.18 1/6] rseq: use __u64 for rseq_cs fields, validate user inputs

2018-07-09 Thread Mathieu Desnoyers
Change the rseq ABI so rseq_cs start_ip, post_commit_offset and abort_ip fields are seen as 64-bit fields by both 32-bit and 64-bit kernels rather that ignoring the 32 upper bits on 32-bit kernels. This ensures we have a consistent behavior for a 32-bit binary executed on 32-bit kernels and in comp

[PATCH for 4.18 2/6] rseq: use get_user/put_user rather than __get_user/__put_user

2018-07-09 Thread Mathieu Desnoyers
__get_user()/__put_user() is used to read values for address ranges that were already checked with access_ok() on rseq registration. It has been recognized that __get_user/__put_user are optimizing the wrong thing. Replace them by get_user/put_user across rseq instead. If those end up showing up

[PATCH] ARM: dts: sun8i: sun8i-a83t-bananapi-m3: enhance vcc-pd to 3.3v

2018-07-09 Thread Corentin Labbe
Since commit d7c5f6863550 ("ARM: dts: sun8i: a83t: bananapi-m3: Add AXP813 regulator nodes") my BPIM3 no longer works at gigabit speed. With the default setting, dldo3 is regulated at 2.9v which seems sufficient for the PHy but d7c5f6863550 drop it to 2.5 which is insufficient. Note that this beh

Re: a question about IP checksum helper for arm64

2018-07-09 Thread Bo Yan
Hi Robin, That UBSAN error prompted me to check the generated instructions. The error by itself doesn't make sense to me because there is no requirement for 128b alignment on ldp/stp. With 4.18-rc3, when I build for the default "defconfig" in arch/arm64/configs/, I see the disassembled code

Re: [PATCH 0/2] mm/fs: put_user_page() proposal

2018-07-09 Thread Jason Gunthorpe
On Mon, Jul 09, 2018 at 09:47:40PM +0200, Jan Kara wrote: > On Mon 09-07-18 10:16:51, Matthew Wilcox wrote: > > On Mon, Jul 09, 2018 at 06:08:06PM +0200, Jan Kara wrote: > > > On Mon 09-07-18 18:49:37, Nicholas Piggin wrote: > > > > The problem with blocking in clear_page_dirty_for_io is that the f

Re: [PATCH 0/2] mm/fs: put_user_page() proposal

2018-07-09 Thread Matthew Wilcox
On Mon, Jul 09, 2018 at 09:47:40PM +0200, Jan Kara wrote: > On Mon 09-07-18 10:16:51, Matthew Wilcox wrote: > > > 2) What to do when some page is pinned but we need to do e.g. > > > clear_page_dirty_for_io(). After some more thinking I agree with you that > > > just blocking waiting for page to unp

[PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-09 Thread Alan Stern
More than one kernel developer has expressed the opinion that the LKMM should enforce ordering of writes by locking. In other words, given the following code: WRITE_ONCE(x, 1); spin_unlock(&s): spin_lock(&s); WRITE_ONCE(y, 1); the stores to x and y should be propa

Re: [PATCH 0/12 V2] ipc: cleanups & bugfixes, rhashtable update

2018-07-09 Thread Davidlohr Bueso
On Mon, 09 Jul 2018, Manfred Spraul wrote: @Davidlohr: Please double check that I have taken the correct patches, and that I didn't break anything. Everything seems ok. Patch 8 had an alternative patch that didn't change nowarn semantics for the rhashtable resizing operations (https://lkml.or

[PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"

2018-07-09 Thread Laura Abbott
This reverts commit 38fc4248677552ce35efc09902fdcb06b61d7ef9. This breaks compilation with Fedora gcc-8 tool chains: CHK include/generated/compile.h LD [M] arch/arm64/crypto/sha512-ce.o aarch64-linux-gnu-ld: cannot open linker script file ldscripts/aarch64elf.xr: No such file or directo

[PATCH v2 4/7] mhi_bus: core: add support for handling ioctl cmds

2018-07-09 Thread Sujeev Dias
User space clients use RS232 control signaling mechanism to communicate call status between host and modem. Adding support to handle ioctl commands from user space. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- drivers/bus/mhi/core/Makefile | 2

[PATCH v2 7/7] mhi_bus: dev: uci: add user space interface driver

2018-07-09 Thread Sujeev Dias
This module allows user space clients to transfer data between external modem and host using standard file operations. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- arch/arm64/configs/defconfig | 1 + drivers/bus/Kconfig | 1

[PATCH v2 5/7] mhi_bus: core: add support to get external modem time

2018-07-09 Thread Sujeev Dias
For accurate synchronizations between external modem and host processor, mhi host will capture modem time relative to host time. Client may use time measurements for adjusting any drift between host and modem. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanados

MHI code review

2018-07-09 Thread Sujeev Dias
Hi Greg Kroah-Hartman\Arnd Bergmann and community Thank you for all the feedback, I believe I have addressed all the comments from previous patches. Also, I am excluding mhi network driver in this series. I still have some modifications to do. Please review the new patch series and share your f

[PATCH v2 6/7] mhi_bus: controller: MHI support for QCOM modems

2018-07-09 Thread Sujeev Dias
QCOM PCIe based modems uses MHI as the communication protocol. MHI control driver is the bus master for such modems. As the bus master driver, it oversees power management operations such as suspend, resume, powering on and off the device. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Sign

[PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Sujeev Dias
This is the initial skeleton driver for mhi bus stack. MHI Host Interface is a communication protocol to be used by the host to control and communcate with modem over a high speed peripheral bus. This module will allow host to communicate with external devices that support MHI protocol. Signed-off

[PATCH v2 2/7] mhi_bus: core: add power management support

2018-07-09 Thread Sujeev Dias
Add support for MHI power management operations such as power on, off, suspend, and resume. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- drivers/bus/mhi/core/Makefile |2 +- drivers/bus/mhi/core/mhi_boot.c | 533 ++

<    1   2   3   4   5   6   7   8   9   >