[RFC PATCH 8/8] dts: juno: Update coresight bindings for hw port

2018-06-01 Thread Suzuki K Poulose
Switch to updated coresight bindings for hw ports. Cc: Sudeep Holla Cc: Liviu Dudau Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- arch/arm64/boot/dts/arm/juno-base.dtsi | 82 +- arch/arm64/boot/dts/arm/juno.dts | 5 ++- 2 files changed, 63 inse

[RFC PATCH 0/8] coresight: Update device tree bindings

2018-06-01 Thread Suzuki K Poulose
Coresight uses DT graph bindings to describe the connections of the components. However we have some undocumented usage of the bindings to describe some of the properties of the connections. The coresight driver needs to know the hardware ports invovled in the connection and the direction of data

[RFC PATCH 2/8] coresight: Fix remote endpoint parsing

2018-06-01 Thread Suzuki K Poulose
When parsing the remote endpoint of an output port, we do : rport = of_graph_get_remote_port(ep); rparent = of_graph_get_remote_port_parent(ep); and then parse the "remote_port" as if it was the remote endpoint, which is wrong. The code worked fine because we used endpoint number as the

[RFC PATCH 3/8] coresight: Cleanup platform description data

2018-06-01 Thread Suzuki K Poulose
Nobody uses the "clk" field in struct coresight_platform_data. Remove it. Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- include/linux/coresight.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/coresight.h b/include/linux/coresight.h index d950dad..32aaa1c 100644 --

[RFC PATCH 7/8] dts: coresight: Define new bindings for direction of data flow

2018-06-01 Thread Suzuki K Poulose
So far we have relied on an undocumented property "slave-mode", to indicate if the given port is input or not. Since we are redefining the coresight bindings, define new property for the "direction" of data flow for a given connection endpoint in the device. Each endpoint must define the following

Re: [PATCH v2 1/3] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-06-01 Thread Guenter Roeck
On 06/01/2018 03:25 AM, Mark Brown wrote: On Thu, May 24, 2018 at 12:49:21PM -0700, Guenter Roeck wrote: From: Guenter Roeck Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE DAI") introduced sound topology files version 5. Initially, this change made the topology code incompati

[RFC PATCH 1/8] dts: binding: coresight: Document graph bindings

2018-06-01 Thread Suzuki K Poulose
Before we updat the bindings, document the current graph bindings and usage of additional properties. Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- .../devicetree/bindings/arm/coresight.txt | 28 ++ 1 file changed, 24 insertions(+), 4 deletions(-) diff --

[RFC PATCH 5/8] coresight: Handle errors in finding input/output ports

2018-06-01 Thread Suzuki K Poulose
If we fail to find the input / output port for a LINK component while enabling a path, we should fail gracefully rather than assuming port "0". Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletio

[RFC PATCH 4/8] coresight: platform: Cleanup coresight connection handling

2018-06-01 Thread Suzuki K Poulose
The platform code parses the component connections and populates a platform-description of the output connections in arrays of fields (which is never freed). This is later copied in the coresight_register to a newly allocated area, represented by coresight_connection(s). This patch cleans up the c

[RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-01 Thread Suzuki K Poulose
The coresight drivers relied on default bindings for graph in DT, while reusing the "reg" field of the "ports" to indicate the actual hardware port number for the connections. However, with the rules getting stricter w.r.t to the address mismatch with the label, it is no longer possible to use the

[PATCH] firmware-gsmi: make structure gsmi_dev static

2018-06-01 Thread Colin King
From: Colin Ian King The structure gsmi_dev is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: drivers/firmware/google/gsmi.c:96:3: warning: symbol 'gsmi_dev' was not declared. Should it be static? Signed-off-by: Colin Ian King --- dri

Re: [PATCH V1 1/3] scsi: ufs: set the device reference clock setting

2018-06-01 Thread Adrian Hunter
On 01/06/18 16:11, sayali wrote: > Hi Adrain, > > Updated my comments inline. Please check. > > Thanks, > Sayali > -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Friday, June 01, 2018 5:59 PM > To: Sayali Lokhande ; subha...@codeaurora.org; > c...@code

Re: [PATCH] perf tools: Fix hist_entry__tui_annotate declaration for !HAVE_SLANG_SUPPORT

2018-06-01 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 01, 2018 at 11:56:48AM +0200, Jiri Olsa escreveu: > The compilation is broken if there's no slang support: > > builtin-annotate.c: In function ‘hists__find_annotations’: > builtin-annotate.c:344:10: error: too many arguments to function > ‘hist_entry__tui_annotate’ > key = h

Re: [PATCH v9 01/15] ARM: Add Krait L2 register accessor functions

2018-06-01 Thread Sricharan R
Hi Stephen, On 5/31/2018 1:11 PM, Stephen Boyd wrote: > Quoting Sricharan R (2018-05-30 21:57:20) >> Hi Stephen, >> >> On 5/30/2018 9:25 PM, Stephen Boyd wrote: >>> Quoting Sricharan R (2018-05-24 22:40:11) Hi Bjorn, On 5/24/2018 11:09 PM, Bjorn Andersson wrote: > On Tue 06 Mar

Re: 4.13..4.14 scheduling overhead regression (bisected - b956575bed91)

2018-06-01 Thread Peter Zijlstra
On Fri, Jun 01, 2018 at 02:57:53PM +0200, Mike Galbraith wrote: > b956575bed91ecfb136a8300742ecbbf451471ab is the first bad commit > commit b956575bed91ecfb136a8300742ecbbf451471ab > Author: Andy Lutomirski > Date: Mon Oct 9 09:50:49 2017 -0700 > > x86/mm: Flush more aggressively in lazy TL

[PATCH v2 06/17] signal: make kill_ok_by_cred() return bool

2018-06-01 Thread Christian Brauner
kill_ok_by_cred() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * unchanged --- kernel/signal.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/kernel/signal.

[PATCH v1 00/20] signal: refactor some functions

2018-06-01 Thread Christian Brauner
Hey, This series refactors a bunch of functions in signal.c to simplify parts of the code. As requested, v2 drops all 3 commits that were pure coding-style changes. The only other coding-style change is the simplification of rt_sigaction which seemed to be worth keeping. The greatest single change

[PATCH v2 17/17] signal: make get_signal() return bool

2018-06-01 Thread Christian Brauner
make get_signal() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- include/linux/signal.h | 2 +- kernel/signal.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) d

[PATCH v2 11/17] signal: make recalc_sigpending_tsk() return bool

2018-06-01 Thread Christian Brauner
recalc_sigpending_tsk() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/signal.c b/

[PATCH v2 10/17] signal: make has_pending_signals() return bool

2018-06-01 Thread Christian Brauner
has_pending_signals() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a

[PATCH v2 16/17] signal: make security_task_kill() return bool

2018-06-01 Thread Christian Brauner
security_task_kill() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/signal.c b/kern

[PATCH v2 15/17] signal: make legacy_queue() return bool

2018-06-01 Thread Christian Brauner
legacy_queue() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c

[PATCH v2 09/17] signal: make sig_ignored() return bool

2018-06-01 Thread Christian Brauner
sig_ignored() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/signal.c b/kernel/sign

[PATCH v2 13/17] signal: make flush_sigqueue_mask() void

2018-06-01 Thread Christian Brauner
The return value of flush_sigqueue_mask() is never checked anywhere. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index a41af5a7749f..d

[PATCH v2 14/17] signal: make wants_signal() return bool

2018-06-01 Thread Christian Brauner
wants_signal() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/kernel/signal.c b/k

[PATCH v2 12/17] signal: make unhandled_signal() return bool

2018-06-01 Thread Christian Brauner
unhandled_signal() already behaves like a boolean function. Let's actually declare it as such too. All callers treat it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- include/linux/signal.h | 2 +- kernel/signal.c| 11 +++ 2 files

Re: mlock() confusing 1 half of system RAM limit

2018-06-01 Thread Alex Richman
Ah, that's it.  Increased the limit on the mount and it works fine now. Thanks! - Alex. On 01/06/18 14:05, Michal Hocko wrote: On Fri 01-06-18 13:26:59, Alex Richman wrote: I am using a shm MAP_SHARED, along these lines: shm_fd = shm_open(handle, (O_RDWR | O_CREAT), (S_IRWXU | S_IRWXG | S_IR

[PATCH v2 07/17] signal: make sig_handler_ignored() return bool

2018-06-01 Thread Christian Brauner
sig_handler_ignored() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kerne

[PATCH] qtnfmac: fix NULL pointer dereference

2018-06-01 Thread Gustavo A. R. Silva
In case *vif* is NULL at 655: if (!vif), the execution path jumps to label out, where *vif* is dereferenced at 679: if (vif->sta_state == QTNF_STA_CONNECTING) Fix this by immediately returning when *vif* is NULL instead of jumping to label out. Addresses-Coverity-ID: 1469567 ("Dereference after

[PATCH v2 08/17] signal: make sig_task_ignored() return bool

2018-06-01 Thread Christian Brauner
sig_task_ignored() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * patch added --- kernel/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/s

[PATCH v2 01/17] signal: make force_sigsegv() void

2018-06-01 Thread Christian Brauner
force_sigsegv() returned 0 unconditionally so it doesn't make sense to have it return at all. In addition, there are no callers that check force_sigsegv()'s return value. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * unchanged --- include/linux/sched/signal.h | 2 +- kernel/

[PATCH v2 04/17] signal: make do_sigpending() void

2018-06-01 Thread Christian Brauner
do_sigpending() returned 0 unconditionally so it doesn't make sense to have it return at all. This allows us to simplify a bunch of syscall callers. Signed-off-by: Christian Brauner Acked-by: Al Viro --- v1->v2: * unchanged v0->v1: * unchanged --- kernel/signal.c | 41 --

[PATCH v2 05/17] signal: simplify rt_sigaction()

2018-06-01 Thread Christian Brauner
The goto is not needed and does not add any clarity. Simply return -EINVAL on unexpected sigset_t struct size directly. Signed-off-by: Christian Brauner --- v1->v2: * [Christoph Hellwig] additional cleanups v0->v1: * unchanged --- kernel/signal.c | 22 ++ 1 file changed, 10 i

[PATCH v2 02/17] signal: make kill_as_cred_perm() return bool

2018-06-01 Thread Christian Brauner
kill_as_cred_perm() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * simplify to use a single return --- kernel/signal.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --g

[PATCH v2 03/17] signal: make may_ptrace_stop() return bool

2018-06-01 Thread Christian Brauner
may_ptrace_stop() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v1->v2: * unchanged v0->v1: * unchanged --- kernel/signal.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/signal.c b/ke

Re: [PATCH] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Sinan Kaya
On 5/31/2018 5:44 PM, Alex G. wrote: > On 05/31/2018 10:30 AM, Sinan Kaya wrote: >> On 5/31/2018 11:05 AM, Alexandru Gagniuc wrote: >>> + if (dev_cur_speed < max_link_speed) >>> + pci_warn(dev, "PCIe downtrain: link speed is %s (%s capable)", >>> +pcie_bus_speed_name

[PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static

2018-06-01 Thread Colin King
From: Colin Ian King The structure fmc_dbgfs_sdb_dump is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: drivers/fmc/fmc-debug.c:143:30: warning: symbol 'fmc_dbgfs_sdb_dump' was not declared. Should it be static? Signed-off-by: Colin Ian

Re: [RFC PATCH 0/5] Hexagon remoteproc spring cleaning

2018-06-01 Thread Rohit Kumar
Thanks Bjorn for the cleanup. I validated PAS and Non- PAS ADSP PIL with the cleanup changes on SDM845. Adding tag for ADSP PIL. Reviewed-and-tested-by: Rohit kumar On 5/23/2018 10:50 AM, Bjorn Andersson wrote: With the introduction of support for the non-MSA Hexagon WCSS driver from Srichar

Re: [PATCH v3 1/6] mtd: rawnand: add Reed-Solomon error correction algorithm

2018-06-01 Thread Stefan Agner
On 01.06.2018 11:25, Boris Brezillon wrote: > On Fri, 1 Jun 2018 09:26:00 +0200 > Boris Brezillon wrote: > >> On Fri, 1 Jun 2018 00:16:32 +0200 >> Stefan Agner wrote: >> >> > Add Reed-Solomon (RS) to the enumeration of ECC algorithms. >> > >> > Signed-off-by: Stefan Agner >> >> Reviewed-by: Bo

Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback

2018-06-01 Thread Sinan Kaya
On 5/30/2018 9:08 PM, ok...@codeaurora.org wrote: > I have seen that shutdown() is also called from remove(). > > remove() is supposed to do a safe cleanup too. If it is leaving the hw in > inconsistent state even though it is c lling shutdown , it is yet another bug. Let's try to be constructiv

Re: [RFC PATCH 3/5] remoteproc: qcom: adsp: Use common q6v5 helpers

2018-06-01 Thread Rohit Kumar
Hi Bjorn, Reviewed and validated PAS and non-PAS ADSP PIL on sdm845 with the changes. Adding tag. On 5/23/2018 10:50 AM, Bjorn Andersson wrote: Migrate the Hexagon V5 PAS (ADSP) driver to using the newly extracted helper functions. The use of the handover callback does introduce latent disabl

Re: mlock() confusing 1 half of system RAM limit

2018-06-01 Thread Michal Hocko
On Fri 01-06-18 14:24:23, Alex Richman wrote: > Ah, that's it.  Increased the limit on the mount and it works fine now. Well, it is hidden very well. It is not until the page fault time (or get_user_pages aka __mm_populate) when the operation fails and remasks ENOSPC -> VM_FAULT_SIGBUS -> EFAULT -

Re: [PATCH v3 1/6] mtd: rawnand: add Reed-Solomon error correction algorithm

2018-06-01 Thread Boris Brezillon
On Fri, 01 Jun 2018 15:34:33 +0200 Stefan Agner wrote: > On 01.06.2018 11:25, Boris Brezillon wrote: > > On Fri, 1 Jun 2018 09:26:00 +0200 > > Boris Brezillon wrote: > > > >> On Fri, 1 Jun 2018 00:16:32 +0200 > >> Stefan Agner wrote: > >> > >> > Add Reed-Solomon (RS) to the enumeration of

[PATCH] mailbox: PCC: make struct pcc_mbox_driver static

2018-06-01 Thread Colin King
From: Colin Ian King The structure pcc_mbox_driver is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: drivers/mailbox/pcc.c:576:24: warning: symbol 'pcc_mbox_driver' was not declared. Should it be static? Signed-off-by: Colin Ian King -

Re: [PATCH v3 00/16] Provide saturating helpers for allocation

2018-06-01 Thread Peter Rosin
Kees Cook wrote: > This is a stab at providing three new helpers for allocation size > calculation: > > struct_size(), array_size(), and array3_size(). > > These are implemented on top of Rasmus's overflow checking functions. The > existing allocators are adjusted to use the more efficient overfl

Re: [PATCH] fuse: fix NULL dereference when new_inode() fails

2018-06-01 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 11:28:31AM +0200, Miklos Szeredi wrote: > On Fri, Jun 1, 2018 at 11:24 AM, Stefan Hajnoczi wrote: > > Ping? > > > > Archive link in case I broke email threading: > > https://marc.info/?l=linux-fsdevel&m=152719324102009&w=2 > > Thanks for the patch. Should already be fixed

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

2018-06-01 Thread Vincent Guittot
Le Thursday 31 May 2018 à 15:02:04 (+0200), Vincent Guittot a écrit : > On 31 May 2018 at 12:27, Patrick Bellasi wrote: > > > > Hi Vincent, Juri, > > > > On 28-May 18:34, Vincent Guittot wrote: > >> On 28 May 2018 at 17:22, Juri Lelli wrote: > >> > On 28/05/18 16:57, Vincent Guittot wrote: > >> >

Re: [PATCH 0/4] exit: Make unlikely case in mm_update_next_owner() more scalable

2018-06-01 Thread Michal Hocko
On Thu 31-05-18 20:07:28, Eric W. Biederman wrote: > Michal Hocko writes: > > > On Thu 26-04-18 14:00:19, Kirill Tkhai wrote: > >> This function searches for a new mm owner in children and siblings, > >> and then iterates over all processes in the system in unlikely case. > >> Despite the case is

Re: [PATCH 0/2] mm->owner to mm->memcg fixes

2018-06-01 Thread Michal Hocko
On Thu 31-05-18 13:41:38, Eric W. Biederman wrote: > Michal Hocko writes: > > > On Thu 24-05-18 14:16:35, Andrew Morton wrote: > >> On Thu, 24 May 2018 13:10:02 +0200 Michal Hocko wrote: > >> > >> > I would really prefer and appreciate a repost with all the fixes folded > >> > in. > >> > >> [1

Re: [PATCH 0/3] Provide more fine grained control over multipathing

2018-06-01 Thread Martin K. Petersen
Good morning Mike, > This notion that only native NVMe multipath can be successful is utter > bullshit. And the mere fact that I've gotten such a reaction from a > select few speaks to some serious control issues. Please stop making this personal. > Imagine if XFS developers just one day impo

[PATCH 1/2] serial: 8250: enable SERIAL_MCTRL_GPIO by default.

2018-06-01 Thread Giulio Benetti
It can be useful to override 8250 mctrl lines with gpios, for rts on rs485 for example, when rts is not mapped correctly to HW RTS pin. Enable SERIAL_MCTRL_GPIO by default. Signed-off-by: Giulio Benetti --- drivers/tty/serial/8250/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/driv

[PATCH 2/2] serial: 8250: Add SERIAL_MCTRL_GPIO support to 8250.

2018-06-01 Thread Giulio Benetti
Sometimes mctrl signals can be connected to pins different from HW ones. User serial_mctrl_gpio helpers to align HW signals(RTS, CTS, etc.) with gpios-rts, gpios-cts etc. Signed-off-by: Giulio Benetti --- drivers/tty/serial/8250/8250_core.c | 6 ++ drivers/tty/serial/8250/8250_port.c | 18

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-01 Thread Benjamin Tissoires
On Fri, Aug 11, 2017 at 2:44 AM, Dmitry Torokhov wrote: > According to Microsoft specification [1] for Precision Touchpads (and > Touchscreens) the devices use "confidence" reports to signal accidental > touches, or contacts that are "too large to be a finger". Instead of > simply marking contact

Re: [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks

2018-06-01 Thread Tony Lindgren
* Faiz Abbas [180601 06:49]: > Hi, > > On Thursday 31 May 2018 06:59 PM, Tero Kristo wrote: > > On 31/05/18 13:14, Faiz Abbas wrote: > >> Hi, > >> > >> On Thursday 31 May 2018 09:33 AM, Rob Herring wrote: > >>> On Wed, May 30, 2018 at 07:41:30PM +0530, Faiz Abbas wrote: > Add clkctrl data fo

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-01 Thread Rob Herring
On Fri, Jun 1, 2018 at 3:51 AM, Srinath Mannam wrote: > Hi Rob Herring, > > Thank you for the review. > Please find my answers inline.. > > On Thu, May 31, 2018 at 10:18 PM, Rob Herring wrote: >> On Mon, May 28, 2018 at 11:11:22AM +0530, Srinath Mannam wrote: >>> From: Pramod Kumar >>> >>> Add b

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-06-01 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it becom

[PATCH 02/12] perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace()

2018-06-01 Thread Frederic Weisbecker
We can't pass the breakpoint directly on arch_check_bp_in_kernelspace() anymore because its architecture internal datas (struct arch_hw_breakpoint) are not yet filled by the time we call the function, and most implementation need this backend to be up to date. So arrange the function to take the pr

[PATCH 12/12] perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check()

2018-06-01 Thread Frederic Weisbecker
Remove the dance around old and new attributes. Just don't modify the previous breakpoint at all until we have verified everything. Reported-by: Linus Torvalds Original-patch-by: Andy Lutomirski Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc:

[GIT PULL] breakpoint: Rework arch validation v3

2018-06-01 Thread Frederic Weisbecker
Ingo, Please pull the perf/breakpoint-v3 branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git perf/breakpoint-v3 HEAD: 3c0681cc01b39e7fac6eb810e82380165c9b56f1 Changes since v2: * Constify the struct perf_event_attr passed in hw_breakpo

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread dvhart
On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell wrote: >Hi Andy, > >On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko > wrote: >> >> Oops. What is the proposed fix for that? It seems we can't rebase >> published branches. > >It's unfixable without a rebase, so you could instead consider it an

[PATCH 07/12] sh: Remove "struct arch_hw_breakpoint::name" unused field

2018-06-01 Thread Frederic Weisbecker
This field seem to be unused, perhaps a leftover from old code... Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Will Deacon Cc: Mark Rutland Cc: Max Filippov Cc: Chris Zankel Cc: Catal

[PATCH 06/12] arm64: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit. Acked-by: Will Deacon Acked-by: Mark Rutland Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc:

[PATCH 11/12] perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot()

2018-06-01 Thread Frederic Weisbecker
We soon won't be able to rely on bp->attr anymore to get the new type of the modifying breakpoint because the new attributes are going to be copied only once we successfully modified the breakpoint slot. This will fix the current misdesigned layout where the new attr are copied to the modifying br

[PATCH 10/12] perf/breakpoint: Remove default hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
All architectures have implemented it, we can now remove the poor weak version. Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Will Deacon Cc: Mark Rutland Cc: Max Filippov Cc: Chris Zan

[PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit Acked-by: Michael Ellerman Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Tho

Re: [PATCH 0/4] exit: Make unlikely case in mm_update_next_owner() more scalable

2018-06-01 Thread Eric W. Biederman
Michal Hocko writes: > On Thu 31-05-18 20:07:28, Eric W. Biederman wrote: >> Michal Hocko writes: >> >> > On Thu 26-04-18 14:00:19, Kirill Tkhai wrote: >> >> This function searches for a new mm owner in children and siblings, >> >> and then iterates over all processes in the system in unlikely

[PATCH 03/12] x86: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit. Original-patch-by: Andy Lutomirski Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar

[PATCH 09/12] xtensa: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Will Deaco

[PATCH 05/12] arm: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit. Acked-by: Mark Rutland Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Thomas

[PATCH 08/12] sh: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
Migrate to the new API in order to remove arch_validate_hwbkpt_settings() that clumsily mixes up architecture validation and commit Signed-off-by: Frederic Weisbecker Cc: Linus Torvalds Cc: Andy Lutomirski Cc: Yoshinori Sato Cc: Rich Felker Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Will Deaco

Re: [PATCH v3 4/8] dt-bindings: gnss: add u-blox binding

2018-06-01 Thread Rob Herring
On Fri, Jun 1, 2018 at 3:22 AM, Johan Hovold wrote: > Add binding for u-blox GNSS receivers. > > Note that the u-blox product names encodes form factor (e.g. "neo"), > chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and > chipset is used for the compatible strings (for now). >

Re: [PATCH v2] sched/rt: fix call to cpufreq_update_util

2018-06-01 Thread Vincent Guittot
Hi Peter, On 17 May 2018 at 22:12, Vincent Guittot wrote: > Le Thursday 17 May 2018 à 11:32:06 (+0200), Peter Zijlstra a écrit : >> On Thu, May 17, 2018 at 11:05:30AM +0200, Peter Zijlstra wrote: >> > Hurm.. I think this is also wrong. See how dequeue_rt_stack() is also >> > called from the enque

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread dvhart
On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell wrote: >Hi Andy, > >On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko > wrote: >> >> Oops. What is the proposed fix for that? It seems we can't rebase >> published branches. > >It's unfixable without a rebase, so you could instead consider it an

Re: [PATCHv2 11/19] arm64: don't reload GPRs after apply_ssbd

2018-06-01 Thread Marc Zyngier
On 01/06/18 12:24, Mark Rutland wrote: > Now that all of the syscall logic works on the saved pt_regs, apply_ssbd > can safely corrupt x0-x3 in the entry paths, and we no longer need to > restore them. So let's remotve the logic doing so. remove* > > With that logic gone, we can fold the branch

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread Andy Shevchenko
On Fri, Jun 1, 2018 at 3:08 PM, Stephen Rothwell wrote: > Hi Andy, > > On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko > wrote: >> >> Oops. What is the proposed fix for that? It seems we can't rebase >> published branches. > > It's unfixable without a rebase, so you could instead consider it a

Re: [PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-06-01 Thread Frederic Weisbecker
On Mon, May 28, 2018 at 09:31:07PM +1000, Michael Ellerman wrote: > Frederic Weisbecker writes: > > > On Thu, May 24, 2018 at 12:01:52PM +1000, Michael Ellerman wrote: > >> Frederic Weisbecker writes: > >> > >> > diff --git a/arch/powerpc/kernel/hw_breakpoint.c > >> > b/arch/powerpc/kernel/hw_

[RFC][PATCH 0/2] memcg: Require every task that uses an mm to migrate together

2018-06-01 Thread Eric W. Biederman
This is a follow up to my last patch of switching from mm->owner to mm->memgcg and as it might be significant enough to break userspace. I am carefully not depending on this change. Eric W. Biederman (2): memcg: Ensure every task that uses an mm is in the same memory cgroup memcgl:

[RFC][PATCH 1/2] memcg: Ensure every task that uses an mm is in the same memory cgroup

2018-06-01 Thread Eric W. Biederman
>From a userspace perspective the cgroup of a mm is determined by which the cgroup the task belongs too. As practically an mm can only belong to a single memory cgroup having multiple tasks with the same mm in different memory cgroups is not well defined. Avoid the difficulties of dealing with

[RFC][PATCH 2/2] memcgl: Remove dead code now that all tasks of an mm share a memcg

2018-06-01 Thread Eric W. Biederman
get_mem_cgroup_from_mm no longer needs to deal with offline memory cgroups. mem_cgroup_can_attach no longer needs to worry about cgroup leaders as all tasks of an mm will migrate together. Signed-off-by: "Eric W. Biederman" --- mm/memcontrol.c | 43 +--

[PATCH] misc: rtsx: make several functions static

2018-06-01 Thread Colin King
From: Colin Ian King Several helper functions are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'rtsx_pm_power_saving' was not declared. Should it be static? symbol 'rtsx_set_l1off_sub_cfg_d0' was not declared. Should it be stat

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread Andy Shevchenko
On Fri, Jun 1, 2018 at 5:33 PM, wrote: > On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell > wrote: >>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko >> wrote: >>> >>> Oops. What is the proposed fix for that? It seems we can't rebase >>> published branches. >> >>It's unfixable without a rebase

Re: [RFC/RFT] [PATCH v3 0/4] Intel_pstate: HWP Dynamic performance boost

2018-06-01 Thread Srinivas Pandruvada
Hi Giovanni, On Fri, 2018-06-01 at 13:32 +0200, Giovanni Gherdovich wrote: > On Thu, May 31, 2018 at 03:51:39PM -0700, Srinivas Pandruvada wrote: > > v3 > > - Removed atomic bit operation as suggested. > > - Added description of contention with user space. > > - Removed hwp cache, boost utililty f

Re: [RFC/RFT] [PATCH v3 4/4] cpufreq: intel_pstate: enable boost for SKX

2018-06-01 Thread Srinivas Pandruvada
On Fri, 2018-06-01 at 14:01 +0200, Giovanni Gherdovich wrote: > On Thu, May 31, 2018 at 03:51:43PM -0700, Srinivas Pandruvada wrote: > > Enable HWP boost on Skylake server platform. > > > > Signed-off-by: Srinivas Pandruvada > .com> > > --- > >  drivers/cpufreq/intel_pstate.c | 9 + > >  1

[PATCH v1] AMD SSB bits.

2018-06-01 Thread Konrad Rzeszutek Wilk
Hi, I was reading the AMD whitepaper on SSBD and noticed that they have added two new bits in the 8000_0008 CPUID. EBX: 1) Bit[26] - similar to Intel's SSB_NO not needed anymore. 2) Bit[24] - use SPEC_CTRL MSR (0x48) instead of VIRT SPEC_CTRL MSR (0xC001_011f). See 124441_AMD64_SpeculativeS

[PATCH v1 1/3] x86/bugs: Add AMD's variant of SSB_NO.

2018-06-01 Thread Konrad Rzeszutek Wilk
The AMD document outlining the SSBD handling 124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf mentions that the CPUID 8000_0008.EBX[26] will mean that the speculative store bypass disable is no longer needed. A copy of this document is available at https://bugzilla.kernel.org/sh

[PATCH v1 2/3] x86/bugs: Add AMD's SPEC_CTRL MSR usage

2018-06-01 Thread Konrad Rzeszutek Wilk
The AMD document outlining the SSBD handling 124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf mentions that if CPUID 8000_0008.EBX[24] is set we should be using the SPEC_CTRL MSR (0x48) over the VIRT SPEC_CTRL MSR (0xC001_011f) for speculative store bypass disable. This in effect me

[PATCH v1 3/3] x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features

2018-06-01 Thread Konrad Rzeszutek Wilk
Both AMD and Intel can have SPEC CTRL MSR for SSBD. However AMD also has two more other ways of doing it - which are !SPEC_CTRL MSR ways. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Konrad Rzeszutek Wilk Cc: Borislav Petkov Cc: Davi

Re: [PATCH v3] vmw_balloon: fixing double free when batching mode is off

2018-06-01 Thread Nadav Amit
Greg Kroah-Hartman wrote: > On Thu, May 31, 2018 at 08:56:52PM +, Nadav Amit wrote: >> Nadav Amit wrote: >> >>> Nadav Amit wrote: >>> Ping. Please consider it for inclusion for rc4. Nadav Amit wrote: > From: Gil Kupfer > > The balloon.page field is use

[PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alexandru Gagniuc
PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the system, and identifying this from userspace is neither intuitive, nor straigh forward. The easiest way to detect

Re: [PATCH 0/4] exit: Make unlikely case in mm_update_next_owner() more scalable

2018-06-01 Thread Michal Hocko
On Fri 01-06-18 09:32:42, Eric W. Biederman wrote: > Michal Hocko writes: [...] > > Group leader exiting early without tearing down the whole thread > > group should be quite rare as well. No question that somebody might do > > that on purpose though... > > The group leader exiting early is a com

[PATCH v3 RESEND] vmw_balloon: fixing double free when batching mode is off

2018-06-01 Thread Nadav Amit
From: Gil Kupfer The balloon.page field is used for two different purposes if batching is on or off. If batching is on, the field point to the page which is used to communicate with with the hypervisor. If it is off, balloon.page points to the page that is about to be (un)locked. Unfortunately,

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Sinan Kaya
On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: > + /* Multi-function PCIe share the same link/status. */ > + if (PCI_FUNC(dev->devfn) != 0) > + return; How about virtual functions? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies,

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alex G.
On 06/01/2018 10:03 AM, Sinan Kaya wrote: > On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >> +/* Multi-function PCIe share the same link/status. */ >> +if (PCI_FUNC(dev->devfn) != 0) >> +return; > > How about virtual functions? I have almost no clue about those. Is your conce

Re: 4.13..4.14 scheduling overhead regression (bisected - b956575bed91)

2018-06-01 Thread Andy Lutomirski
On Fri, Jun 1, 2018 at 6:21 AM Peter Zijlstra wrote: > > On Fri, Jun 01, 2018 at 02:57:53PM +0200, Mike Galbraith wrote: > > b956575bed91ecfb136a8300742ecbbf451471ab is the first bad commit > > commit b956575bed91ecfb136a8300742ecbbf451471ab > > Author: Andy Lutomirski > > Date: Mon Oct 9 09:50

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Sinan Kaya
On 6/1/2018 11:06 AM, Alex G. wrote: > On 06/01/2018 10:03 AM, Sinan Kaya wrote: >> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >>> + /* Multi-function PCIe share the same link/status. */ >>> + if (PCI_FUNC(dev->devfn) != 0) >>> + return; >> >> How about virtual functions? > > I h

Re: [PATCH] fb_omap: add gpiolib dependency

2018-06-01 Thread Arnd Bergmann
On Thu, May 31, 2018 at 8:04 AM, Andy Shevchenko wrote: > On Thu, May 31, 2018 at 12:49 AM, Arnd Bergmann wrote: > >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit >> declaration of function 'of_n

Re: [PATCH] x86,switch_mm: skip atomic operations for init_mm

2018-06-01 Thread Andy Lutomirski
On Fri, Jun 1, 2018 at 5:28 AM Rik van Riel wrote: > > Song noticed switch_mm_irqs_off taking a lot of CPU time in recent > kernels,using 2.4% of a 48 CPU system during a netperf to localhost run. > Digging into the profile, we noticed that cpumask_clear_cpu and > cpumask_set_cpu together take abo

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Andy Shevchenko
On Fri, Jun 1, 2018 at 6:01 PM, Alexandru Gagniuc wrote: > PCIe downtraining happens when both the device and PCIe port are > capable of a larger bus width or higher speed than negotiated. > Downtraining might be indicative of other problems in the system, and > identifying this from userspace is

Re: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs

2018-06-01 Thread Maxime Ripard
Hi, On Mon, May 28, 2018 at 04:27:34PM +0530, Viresh Kumar wrote: > On 28-05-18, 10:44, Maxime Ripard wrote: > > Hi, > > > > On Fri, May 25, 2018 at 04:01:52PM +0530, Viresh Kumar wrote: > > > The cooling device properties, like "#cooling-cells" and > > > "dynamic-power-coefficient", should eithe

[PATCH] tools: modifying page-types to include shared map counts

2018-06-01 Thread Christian Hansen
Adding a new flag that will read kpagecount for each PFN and print out the number of time the page is mapped along with the flags in the listing view. Signed-off-by: Christian Hansen --- tools/vm/page-types.c | 73 +-- 1 file changed, 59 insertions

<    1   2   3   4   5   6   >