Re: [PATCH 2/6] genalloc: selftest

2018-02-22 Thread Igor Stoppa
On 22/02/18 11:14, Igor Stoppa wrote: > > > On 22/02/18 00:28, Kees Cook wrote: >> On Tue, Feb 20, 2018 at 8:59 AM, Igor Stoppa wrote: >>> >>> >>> On 13/02/18 01:50, Kees Cook wrote: On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > > [...] > > + genalloc_selftest();

Re: [PATCH v10 1/7] PCI/AER: Rename error recovery to generic pci naming

2018-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2018 at 09:32:06PM +0530, Oza Pawandeep wrote: > This patch renames error recovery to generic name with pci prefix > > Signed-off-by: Oza Pawandeep > > diff --git a/drivers/pci/pcie/aer/aerdrv_core.c > b/drivers/pci/pcie/aer/aerdrv_core.c > index a4bfea5..306bf2f 100644 > --- a/

Re: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread Christoph Hellwig
> - pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT); > - /* TODO: Should kernel panic here? */ > - pci_info(dev, "AER: Device recovery failed\n"); > -} > +EXPORT_SYMBOL(pci_find_aer_service); EXPORT_SYMBPOL_GPL please.

Re: [PATCH v10 3/7] PCI/ERR: add mutex to synchronize recovery

2018-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2018 at 09:32:08PM +0530, Oza Pawandeep wrote: > This patch protects pci_do_recovery with mutex. Do we really want a global mutex for this and not one per root complex at very least?

Re: [PATCH v10 4/7] PCI/DPC: Unify and plumb error handling into DPC

2018-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2018 at 09:32:09PM +0530, Oza Pawandeep wrote: > Current DPC driver does not do recovery, e.g. calling end-point's driver's > callbacks, which sanitize the sw. > > DPC driver implements link_reset callback, and calls pci_do_recovery. > > Signed-off-by: Oza Pawandeep > > diff --g

RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread David Laight
From: Christoph Hellwig > > - pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT); > > - /* TODO: Should kernel panic here? */ > > - pci_info(dev, "AER: Device recovery failed\n"); > > -} > > +EXPORT_SYMBOL(pci_find_aer_service); > > EXPORT_SYMBPOL_GPL please. Is this a function that a 'normal'

Re: [PATCH 0/5] x86/dumpstack: Cleanups and user opcode bytes Code: section

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 1:23 AM, Peter Zijlstra wrote: > > So being one to only use machines that have a serial line this does not > really affect me; but it would appear to me that it might make sense to > try and reverse the entire dump. In theory yes. But while you mention the buffering proble

Re: [PATCH v10 6/7] PCI: Unify wait for link active into generic pci

2018-02-22 Thread Christoph Hellwig
> > +/** > + * pci__wait_for_link - Wait for link till its active/inactive typo - just wants a single underscore. > + pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); > + ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA); no need for the !! when assigning to a boolean. > + > +

Re: [PATCH 04/30] Enforce module signatures if the kernel is locked down

2018-02-22 Thread Jiri Bohac
On Thu, Feb 22, 2018 at 01:07:57PM +, David Howells wrote: > I'm considering folding the attached changes into this patch. > > It adjusts the errors generated: > > (1) If there's no signature (ENODATA) or we can't check it (ENOPKG, ENOKEY), > then: > > (a) If signatures are enforc

Re: [RFC PATCH] usb: hcd: complete URBs in threaded-IRQ context instead of tasklet

2018-02-22 Thread Alan Stern
On Thu, 22 Feb 2018, Sebastian Andrzej Siewior wrote: > On 2018-02-16 16:46:41 [-0500], Alan Stern wrote: > > > The theaded interrupt runs SCHED_FIFO priority 50 by default. The only > > > thing that can interrupt it are interrupts, a softirq (not ksoftirqd) > > > and other tasks with a higher pri

Re: [PATCH 20/23] gcc-plugins: always build plugins with C++

2018-02-22 Thread Emese Revfy
On Sat, 17 Feb 2018 03:38:48 +0900 Masahiro Yamada wrote: > If the target compiler is GCC 4.8 or newer, plugins are compiled with > HOSTCXX. Otherwise, gcc-plugin.sh will select HOSTCC or HOSTCXX. > > To simpily things, let's decide GCC 4.8 is the requirement for GCC > pulgins. With this, plug

Re: [PATCH v11 04/10] clocksource: timer-ti-dm: Replace architecture

2018-02-22 Thread Tony Lindgren
* Ladislav Michl [180222 10:58]: > On Thu, Feb 15, 2018 at 11:31:45AM +0530, Keerthy wrote: > > Replace architecture specific guard with clocksource guard. > > > > Signed-off-by: Keerthy > > Replace architecture specific defines with clocksource > > This looks like a bit unussual commit log. Al

Re: [GIT PULL] seccomp updates for v4.16-rc3

2018-02-22 Thread James Morris
On Wed, 21 Feb 2018, Kees Cook wrote: > Hi James, > > Please pull these seccomp changes for v4.16-rc3. These are fixes for the > get_metadata interface that landed during -rc1. While the new selftest > is strictly not a bug fix, I think it's in the same spirit of avoiding > bugs. Thanks, applied

hpsa crashes on boot in 4.16-rc2-00062

2018-02-22 Thread Meelis Roos
This happens on a HP DL360 G6 with Smart Array 410i. Will try to bisect. IO completion timeout could be because of some IRQ toubles? (sorry, the rest has scrolled away in ilo2 textcons) [ 242.655025] Call Trace: [ 242.655077] ? __schedule

Re: [PATCH v2 3/3] fs: fsnotify: account fsnotify metadata to kmemcg

2018-02-22 Thread Shakeel Butt
On Thu, Feb 22, 2018 at 6:48 AM, Jan Kara wrote: > On Thu 22-02-18 14:49:44, Michal Hocko wrote: >> On Tue 20-02-18 19:01:01, Shakeel Butt wrote: >> > A lot of memory can be consumed by the events generated for the huge or >> > unlimited queues if there is either no or slow listener. This can caus

Re: Use higher-order pages in vmalloc

2018-02-22 Thread Andy Lutomirski
On Thu, Feb 22, 2018 at 1:36 PM, Michal Hocko wrote: > On Thu 22-02-18 04:22:54, Matthew Wilcox wrote: >> On Thu, Feb 22, 2018 at 07:59:43AM +0100, Michal Hocko wrote: >> > On Wed 21-02-18 09:01:29, Matthew Wilcox wrote: >> > > Right. It helps with fragmentation if we can keep higher-order >> > >

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-22 Thread David Miller
From: Denis Du Date: Wed, 21 Feb 2018 03:35:31 + (UTC) > How  is your thinking about this patch? I cannot apply a patch which has been corrupted by your email client like this. Please send it properly again, plain ASCII text, and no trasnformations by your email client. You should send the

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-22 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 21 Feb 2018 04:41:59 +0100 > Before, if cb->start() failed, the module reference would never be put, > because cb->cb_running is intentionally false at this point. Users are > generally annoyed by this because they can no longer unload modules that > leak ref

Re: [PATCH v6 1/5] fuse: Remove the buggy retranslation of pids in fuse_dev_do_read

2018-02-22 Thread Eric W. Biederman
Miklos Szeredi writes: > On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman > wrote: >> At the point of fuse_dev_do_read the user space process that initiated the >> action on the fuse filesystem may no longer exist. The process have been >> killed or may have fired an asynchronous request and

[PATCH 0/6] R-Car M3-N DTS fixes

2018-02-22 Thread Jacopo Mondi
Hello Simon, Arnd, The recently introduced Renesas R-Car M3-N SoC device tree source file is included from salvator-x[s]-$SOC.dts, and it thus needs place holders for devices not yet enabled but whose nodes are referenced by those common files. When first submitted r8a77965.dtsi I ignored DTC

[PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

2018-02-22 Thread Jacopo Mondi
Add "reg" properties to place-holder nodes with unit address defined for R-Car M3-N SoC. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /soc/... has a unit name, but no reg property Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 3/6] arm64: dts: renesas: r8a77965: Remove stale reg property

2018-02-22 Thread Jacopo Mondi
Remove "reg" property from cache-controller-0 device node as it does not have any unit address. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /cpus/cache-controller-0 has a reg or ranges property, but no unit name Signed-off-by: Jacopo Mondi --- arch/arm6

[PATCH 5/6] arm64: dts: renesas: r8a77965: Add #pwm-cells property

2018-02-22 Thread Jacopo Mondi
Add "#pwm-cells" property to "pwm@e6e31000" device node. This silences the following DTC compiler warning: Warning (pwms_property): Missing property '#pwm-cells' in node /soc/pwm@e6e31000 or bad phandle (referred from /backlight:pwms[0]) Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renes

Re: nla_put_string() vs NLA_STRING

2018-02-22 Thread David Miller
From: Kees Cook Date: Tue, 20 Feb 2018 22:00:26 -0800 > So, this specific problem needs fixing (in at least two places calling > nla_put_string(msg, NL80211_ATTR_REG_ALPHA2, ...)). While I suspect > it's only ever written an extra byte from the following variable in > the structure which is an en

[PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

2018-02-22 Thread Jacopo Mondi
Add "#interrupt-cells" property and "interrupt-controller" label to "interrupt-controller@e61c" device node. This silences the following DTC compiler warnings: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/interrupt-controller@e61c Warning (i

[PATCH 4/6] arm64: dts: renesas: r8a77965: Add #phy-cells property

2018-02-22 Thread Jacopo Mondi
Add "#phy-cells" property to "usb-phy@e65ee000" device node. This silences the following DTC compiler warning: Warning (phys_property): Missing property '#phy-cells' in node /soc/usb-phy@e65ee000 or bad phandle (referred from /soc/usb@ee02:phys[0]) Signed-off-by: Jacopo Mondi --- arch/arm64

Re: [PATCH 08/30] kexec_file: Restrict at runtime if the kernel is locked down

2018-02-22 Thread Jiri Bohac
On Thu, Feb 22, 2018 at 02:20:43PM +, David Howells wrote: > commit 87a39b258eca2e15884ee90c3fcd5758d6057b17 > Author: David Howells > Date: Thu Feb 22 13:42:04 2018 + > > kexec_file: split KEXEC_VERIFY_SIG into KEXEC_SIG and KEXEC_SIG_FORCE > > This is a preparatory patch

[PATCH 2/6] arm64: dts: renesas: r8a77965: Add #address-cells and #size-cells

2018-02-22 Thread Jacopo Mondi
Add "#address-cells" and "#size-cells" properties to all place-holder nodes that have children nodes defined by salvator-x[s].dtsi device tree. This silences the following DTC compiler warnings: Warning (reg_format): "reg" property in /soc/.. has invalid length (4 bytes) (#address-cells == 2, #siz

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-22 Thread Sergei Shtylyov
Hello! On 02/22/2018 06:54 PM, Simon Horman wrote: >>> ... >>> >> +clocks = <&cpg CPG_MOD 812>; >> +power-domains = <&sysc 32>; >> +resets = <&cpg 812>; >> +phy-mode = "rgmii-txid"; >>>

[PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

2018-02-22 Thread Krzysztof Kozlowski
Typo in unit address of PPMU ACP caused DTC warnings: arch/arm/boot/dts/exynos4412-odroidu3.dtb: Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae simple-bus unit address format error, expected "106e" PPMU ACP (under 0x10ae address) is present only in Exynos4210 so move t

[PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

2018-02-22 Thread Krzysztof Kozlowski
Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is correct) to get rid of DTC warnings like: arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg): Node /soc/amba/pdma@1268 simple-bus unit address format error, expected "121a" Signed-off-by:

Re: [PATCH 08/30] kexec_file: Restrict at runtime if the kernel is locked down

2018-02-22 Thread Jiri Bohac
On Thu, Feb 22, 2018 at 02:21:53PM +, David Howells wrote: > commit ed0424c531d7dd25adebdec0ee6a78a5784f207a > Author: David Howells > Date: Thu Feb 22 14:01:49 2018 + > > kexec_file: Restrict at runtime if the kernel is locked down > > When KEXEC_VERIFY_SIG is not enabled,

[ANNOUNCE] v4.14.20-rt17

2018-02-22 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v4.14.20-rt17 patch set. Changes since v4.14.20-rt16: - A RCU warning was disabled if we schedule() while we acquire a sleeping lock. The warning was still seen on UP only kernels and is now disabled. Reported by Grygorii Strashko. - The r

[PATCH v2 0/2]add support for Socionext SynQuacer I2C controller

2018-02-22 Thread Ard Biesheuvel
Add a binding and a driver for the I2C IP found in the Socionext SynQuacer SoC, which is essentially a rebranded version of the Fujitsu F_I2C controller. v2: - incorporate Andy's review comments (#2) - patch #1 unchanged. Ard Biesheuvel (2): dt-bindings: i2c: add binding for Socionext SynQuacer

[PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-22 Thread Ard Biesheuvel
This is a cleaned up version of the I2C controller driver for the Fujitsu F_I2C IP, which was never supported upstream, and has now been incorporated into the Socionext SynQuacer SoC. Signed-off-by: Ard Biesheuvel --- drivers/i2c/busses/Kconfig | 11 + drivers/i2c/busses/Makefile

[PATCH v2 1/2] dt-bindings: i2c: add binding for Socionext SynQuacer I2C

2018-02-22 Thread Ard Biesheuvel
Add a binding for the I2C controller that can be found in the Socionext SynQuacer SoC. Note that this is the exact same IP as the Fujitsu F_I2C. Signed-off-by: Ard Biesheuvel --- Documentation/devicetree/bindings/i2c/i2c-synquacer.txt | 29 1 file changed, 29 insertions(+)

Re: Removing architectures without upstream gcc support

2018-02-22 Thread Richard Kuo
On Thu, Feb 22, 2018 at 04:45:06PM +0100, Arnd Bergmann wrote: > * Hexagon is Qualcomm's DSP architecture. It is being actively used > in all Snapdragon ARM SoCs, but the kernel code appears to be > the result of a failed research project to make a standalone Hexagon > SoC without an ARM core

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-22 Thread Eric W. Biederman
Miklos Szeredi writes: > On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman > wrote: >> Ensure the translation happens by failing to read or write >> posix acls when the filesystem has not indicated it supports >> posix acls. > > For the first iteration this is fine, but we could convert the ra

Re: Use higher-order pages in vmalloc

2018-02-22 Thread Dave Hansen
On 02/22/2018 11:01 AM, Andy Lutomirski wrote: > On x86, if you shoot down the PTE for the current stack, you're dead. *If* we were to go do this insanity for vmalloc()'d memory, we could probably limit it to kswapd, and also make sure that kernel threads don't get vmalloc()'d stacks or that we ma

Re: [PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Juergen Gross
On 22/02/18 18:22, Colin King wrote: > From: Colin Ian King > > Currently if map is null then a potential null pointer deference > occurs when calling sock_release on map->sock. I believe the > actual intention was to call sock_release on sock instead. Fix > this. > > Fixes: 5db4d286a8ef ("xen/

Re: [PATCH 1/2] stackleak: Update for arm64

2018-02-22 Thread Alexander Popov
Hello Will, Richard and GCC folks! On 22.02.2018 19:58, Will Deacon wrote: > On Tue, Feb 20, 2018 at 05:13:02PM -0800, Laura Abbott wrote: >> >> arm64 has another layer of indirection in the RTL. >> Account for this in the plugin. >> >> Signed-off-by: Laura Abbott >> --- >> scripts/gcc-plugins/s

Re: [PATCH v9 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread Randy Dunlap
On 02/21/2018 11:46 PM, Oza Pawandeep wrote: Hi, Just minor stuff: > diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c > new file mode 100644 > index 000..a532fe0 > --- /dev/null > +++ b/drivers/pci/pcie/pcie-err.c > @@ -0,0 +1,334 @@ > +// SPDX-License-Identifier: GPL-2.

Re: [PATCH v9 7/7] PCI/DPC: Enumerate the devices after DPC trigger event

2018-02-22 Thread Randy Dunlap
On 02/21/2018 11:46 PM, Oza Pawandeep wrote: > Implement error_resume callback in DPC so, after DPC trigger event > enumerates the devices beneath. > > Signed-off-by: Oza Pawandeep > > diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c > index fce4518..59c01c7 100644 > --- a/

Re: [PATCH v9 4/7] PCI/DPC: Unify and plumb error handling into DPC

2018-02-22 Thread Randy Dunlap
On 02/21/2018 11:46 PM, Oza Pawandeep wrote: > Current DPC driver does not do recovery, e.g. calling end-point's driver's > callbacks, which sanitize the sw. > > DPC driver implements link_reset callback, and calls pci_do_recovery. Hi, What does DPC mean? > Signed-off-by: Oza Pawandeep > > di

Re: Use higher-order pages in vmalloc

2018-02-22 Thread Andy Lutomirski
On Thu, Feb 22, 2018 at 7:19 PM, Dave Hansen wrote: > On 02/22/2018 11:01 AM, Andy Lutomirski wrote: >> On x86, if you shoot down the PTE for the current stack, you're dead. > > *If* we were to go do this insanity for vmalloc()'d memory, we could > probably limit it to kswapd, and also make sure t

[GIT PULL] SCSI fixes for 4.16-rc2

2018-02-22 Thread James Bottomley
These are mostly fixes for problems with merge window code.  In addition we have one doc update (alua) and two dead code removals (aiclib and octogon) a spurious assignment removal (csiostor) and a performance improvement for storvsc involving better interrupt spreading and increasing the command p

[PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement

2018-02-22 Thread Debopriyo Ghosh
From: Debopriyo This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found by the checkpatch.pl tool 1.Use of __func__ instead of function name 2.proper code identation for else statement Signed-off-by: Debopriyo Ghosh --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 4 ++-- 1

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-22 Thread Brian Norris
Hi Arend, On Thu, Feb 22, 2018 at 01:17:56PM +0100, Arend van Spriel wrote: > On 2/21/2018 11:59 PM, Brian Norris wrote: > > On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: > > > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > > > it is possible to initiate

Re: Use higher-order pages in vmalloc

2018-02-22 Thread Dave Hansen
On 02/22/2018 11:27 AM, Andy Lutomirski wrote: > On Thu, Feb 22, 2018 at 7:19 PM, Dave Hansen wrote: >> On 02/22/2018 11:01 AM, Andy Lutomirski wrote: >>> On x86, if you shoot down the PTE for the current stack, you're dead. >> >> *If* we were to go do this insanity for vmalloc()'d memory, we coul

Re: [PATCH 1/2] stackleak: Update for arm64

2018-02-22 Thread Laura Abbott
On 02/22/2018 08:58 AM, Will Deacon wrote: Hi Laura, On Tue, Feb 20, 2018 at 05:13:02PM -0800, Laura Abbott wrote: arm64 has another layer of indirection in the RTL. Account for this in the plugin. Signed-off-by: Laura Abbott --- scripts/gcc-plugins/stackleak_plugin.c | 5 + 1 file ch

Re: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Jeremy Cline
On 02/22/2018 12:05 PM, mario.limoncie...@dell.com wrote: >> -Original Message- >> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- >> ow...@vger.kernel.org] On Behalf Of Jeremy Cline >> Sent: Thursday, February 22, 2018 10:42 AM >> To: Limonciello, Mario ; notm.

[PATCH] uapi: remove telephony headers

2018-02-22 Thread Baruch Siach
ixjuser.h includes the telephony.h header. Other than that no kernel code uses any of these headers. The last user of the ixjuser.h header has been removed in commit 7326446c728 (Staging: remove telephony drivers), more than 5 years ago. Signed-off-by: Baruch Siach --- include/uapi/linux/ixjuser

Re: [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-22 Thread David Miller
From: Finn Thain Date: Thu, 22 Feb 2018 09:24:59 +1100 (AEDT) > AFAIK the only version of smc9194.c with Mac support is the one in the > linux-mac68k CVS repo, which never made it to the mainline. > > Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 > under CONFIG_MAC. This

[PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

2018-02-22 Thread Alexey Roslyakov
cur_slot and num_slots has been removed from struct dw_mci in 42f989c002f2. Unfortunately, inline documentation was not updated so far. Fix @lock field documentation in Locking section. Move @mrq field of struct dw_mci_slot mention closer to it description, so no one could miss this slightest deta

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Daniel Lustig
On 2/22/2018 10:27 AM, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 10:13:17AM -0800, Paul E. McKenney wrote: >> So we have something that is not all that rare in the Linux kernel >> community, namely two conflicting more-or-less concurrent changes. >> This clearly needs to be resolved, either b

Re: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Darren Hart
On Thu, Feb 22, 2018 at 05:05:39PM +, mario.limoncie...@dell.com wrote: ... > OK thanks for confirming. Here's what I've concluded: > > * So looking through the ACPI tables on the 9360 it initializes that status > (slate vs laptop mode) bit to "slate" mode. The 9360 isn't a 2-in1- so that >

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Luis R. Rodriguez
On Thu, Feb 22, 2018 at 07:53:07PM +0800, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config dependencies

Re: [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec

2018-02-22 Thread Tony Lindgren
* Mark Brown [180219 12:05]: > On Fri, Feb 16, 2018 at 07:57:07AM -0800, Tony Lindgren wrote: > > One advantage of using a compatible property for the pmic subdevices > > though is that it leaves out a dependency between various device > > drivers things happen automagically. The mfd core driver c

Re: nla_put_string() vs NLA_STRING

2018-02-22 Thread Johannes Berg
On Tue, 2018-02-20 at 22:00 -0800, Kees Cook wrote: > It seems that in at least one case[1], nla_put_string() is being used > on an NLA_STRING, which lacks a NULL terminator, which leads to > silliness when nla_put_string() uses strlen() to figure out the size: Fun! I'm not a big fan of the whole

Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 10:04 AM, Linus Torvalds wrote: > On Thu, Feb 22, 2018 at 9:41 AM, Kees Cook wrote: >> >> Updated to include Tested-by. Linus, this looks ready to go. > > Ok, applied. > > I'm a bit worried that this ends up bypassing our automatic dependency > generation. > > Lookie here

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Anders Roxell
On 22 February 2018 at 12:53, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config dependencies of kselftest

[PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

2018-02-22 Thread Mario Limonciello
Some laptops such as the XPS 9360 support the intel-vbtn INT33D6 interface but don't initialize the bit that intel-vbtn uses to represent switching tablet mode. By running this only on real 2-in-1's it shouldn't cause false positives. Fixes: 30323fb6d5 ("Support tablet mode switch") Reported-by:

RE: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Jeremy Cline > Sent: Thursday, February 22, 2018 1:45 PM > To: Limonciello, Mario ; notm...@gmail.com > Cc: pali.ro...@gmail.com; andriy.shevche...@linux

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Paul E. McKenney
On Thu, Feb 22, 2018 at 07:27:17PM +0100, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 10:13:17AM -0800, Paul E. McKenney wrote: > > So we have something that is not all that rare in the Linux kernel > > community, namely two conflicting more-or-less concurrent changes. > > This clearly needs to

[PATCH v6] rtc: isl12026: Add driver.

2018-02-22 Thread David Daney
The ISL12026 is a combination RTC and EEPROM device with I2C interface. The standard RTC driver interface is provided. The EEPROM is accessed via the NVMEM interface via the "eeprom0" directory in the sysfs entry for the device. Reviewed-by: Rob Herring Reviewed-by: Andy Shevchenko Signed-off-

Re: [PATCH v2] ARM: tegra: fix ulpi regression on tegra20

2018-02-22 Thread Dmitry Osipenko
On 22.02.2018 17:38, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Since commit f8f8f1d04494 ("clk: Don't touch hardware when reparenting > during registration") ULPI has been broken on Tegra20 leading to the > following error message during boot: > > [1.974698] ulpi_phy_power_on: ulpi

Re: [PATCH] drm/p[111: add CONFIG_OF dependency

2018-02-22 Thread Eric Anholt
Arnd Bergmann writes: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct > dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > driver

Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

2018-02-22 Thread Jeremy Cline
On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote: > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6 > interface but don't initialize the bit that intel-vbtn uses to > represent switching tablet mode. > > By running this only on real 2-in-1's it shouldn't cause fal

Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 11:57 AM, Kees Cook wrote: > > Hmm. But does that mean deps for kconfig.h are broken too? That seems > silly. I'll take a look... Yes, kconfig.h itself shares the same problem, but it has generally been just about the config option testing itself, so you'd normally never c

Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

2018-02-22 Thread Darren Hart
On Thu, Feb 22, 2018 at 08:15:51PM +, Jeremy Cline wrote: > On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote: > > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6 > > interface but don't initialize the bit that intel-vbtn uses to > > represent switching tablet m

Re: [PATCH v2 3/5] gpio: Change ISA_BUS_API dependency to selection

2018-02-22 Thread William Breathitt Gray
On Thu, Feb 22, 2018 at 04:16:17PM +0100, Linus Walleij wrote: >On Fri, Dec 29, 2017 at 9:13 PM, William Breathitt Gray > wrote: > >> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus >> driver. The ISA bus driver does not perform any hardware interaction, >> and is instead just

[RFC][PATCH 00/10] Use global pages with PTI

2018-02-22 Thread Dave Hansen
The later verions of the KAISER pathces (pre-PTI) allowed the user/kernel shared areas to be GLOBAL. The thought was that this would reduce the TLB overhead of keeping two copies of these mappings. During the switch over to PTI, we seem to have lost our ability to have GLOBAL mappings. This adds

[RFC][PATCH 03/10] x86/mm: introduce "default" kernel PTE mask

2018-02-22 Thread Dave Hansen
From: Dave Hansen The __PAGE_KERNEL_* page permissions are "raw". They contain bits that may or may not be supported on the current processor. They need to be filtered by a mask (currently __supported_pte_mask) to turn them into a value that we can actually set in a PTE. These __PAGE_KERNEL_*

[RFC][PATCH 04/10] x86/espfix: use kernel-default PTE mask

2018-02-22 Thread Dave Hansen
From: Dave Hansen In creating its page tables, the espfix code masks its PGTABLE_PROT value with the supported mask: __supported_pte_mask. This ensures that unsupported bits are not set in the final PTE. But, it also sets _PAGE_GLOBAL which we do not want for PTE. Use __default_kernel_pte_mas

[RFC][PATCH 09/10] x86/pti: enable global pages for shared areas

2018-02-22 Thread Dave Hansen
From: Dave Hansen The entry/exit text and cpu_entry_area are mapped into userspace and the kernel. But, they are not _PAGE_GLOBAL. This creates unnecessary TLB misses. Add the _PAGE_GLOBAL flag for these areas. Signed-off-by: Dave Hansen Cc: Andrea Arcangeli Cc: Andy Lutomirski Cc: Linus

[RFC][PATCH 08/10] x86/mm: do not forbid _PAGE_RW before init for __ro_after_init

2018-02-22 Thread Dave Hansen
From: Dave Hansen __ro_after_init data gets stuck in the .rodata section. That's normally fine because the kernel itself manages the R/W properties. But, if we run __change_page_attr() on an area which is __ro_after_init, the .rodata checks will trigger and force the area to be immediately rea

[RFC][PATCH 10/10] x86/pti: clear _PAGE_GLOBAL for kernel image

2018-02-22 Thread Dave Hansen
From: Dave Hansen The kernel page tables are inherited from head_64.S which rudely marks them as _PAGE_GLOBAL. For PTI, we have been relying on the grace of $DEITY and some insane behavior in pageattr.c. Now we do it properly. First, stop filtering out "unsupported" bits from being cleared in

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-02-22 Thread Saravana Kannan
On 02/22/2018 03:33 AM, Mark Rutland wrote: On Wed, Feb 21, 2018 at 06:32:46PM -0800, Saravana Kannan wrote: On 01/02/2018 03:25 AM, Suzuki K Poulose wrote: +static int dsu_pmu_event_init(struct perf_event *event) +{ + struct dsu_pmu *dsu_pmu = to_dsu_pmu(event->pmu); + + if (event-

[RFC][PATCH 07/10] x86/mm: comment _PAGE_GLOBAL mystery

2018-02-22 Thread Dave Hansen
From: Dave Hansen I was mystified as to where the _PAGE_GLOBAL in the kernel page tables for kernel text came from. I audited all the places I could find, but I missed one: head_64.S. The page tables that we create in here live for a long time, and they also have _PAGE_GLOBAL set, despite whet

[RFC][PATCH 06/10] x86/mm: remove extra filtering in pageattr code

2018-02-22 Thread Dave Hansen
From: Dave Hansen The pageattr code has a mode where it can set or clear PTE bits in existing PTEs, so the page protections of the *new* PTEs come from one of two places: 1. The set/clear masks: cpa->mask_clr / cpa->mask_set 2. The existing PTE We filter ->mask_set/clr for supported PTE bits at

[RFC][PATCH 05/10] x86/mm: do not auto-massage page protections

2018-02-22 Thread Dave Hansen
From: Dave Hansen A PTE is constructed from a physical address and a pgprotval_t. __PAGE_KERNEL, for instance, is a pgprot_t and must be converted into a pgprotval_t before it can be used to create a PTE. This is done implicitly within functions like set_pte() by massage_pgprot(). However, thi

[RFC][PATCH 01/10] x86/mm: factor out pageattr _PAGE_GLOBAL setting

2018-02-22 Thread Dave Hansen
From: Dave Hansen The pageattr code has a pattern repeated where it sets _PAGE_GLOBAL for present PTEs but clears it for non-present PTEs. The intention is to keep _PAGE_GLOBAL from getting confused with _PAGE_PROTNONE since _PAGE_GLOBAL is for present PTEs and _PAGE_PROTNONE is for non-present

Re: [PATCH] dsa: ptp; mark dummy helpers as 'inline'

2018-02-22 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Feb 2018 12:44:40 +0100 > Declaring a static function in a header leads to a warning every > time that header gets included without the function being used: > > In file included from drivers/net/dsa/mv88e6xxx/chip.c:42: > drivers/net/dsa/mv88e6xxx/ptp.h:92:13: e

[RFC][PATCH 02/10] x86/mm: undo double _PAGE_PSE clearing

2018-02-22 Thread Dave Hansen
From: Dave Hansen When clearing _PAGE_PRESENT on a huge page, we need to be careful to also clear _PAGE_PSE, otherwise it might still get confused for a valid large page table entry. We do that near the spot where we *set* _PAGE_PSE. That's fine, but it's unnecessary. pgprot_large_2_4k() alre

Re: [PATCH] max17042: propagate of_node to power supply device

2018-02-22 Thread Sebastian Reichel
Hi, On Tue, Feb 20, 2018 at 04:03:18PM +0100, Pierre Bourdon wrote: > max17042_get_status uses the core power_supply_am_i_supplied. That > function relies on DT properties to figure out the power supply > topology, and will error out without DT. > > Fixes max17042 battery status being reported as

Re: [PATCH v2 3/5] gpio: Change ISA_BUS_API dependency to selection

2018-02-22 Thread Maciej S. Szmigiero
Hi William, Hi Linus, On 22.02.2018 21:30, William Breathitt Gray wrote: > On Thu, Feb 22, 2018 at 04:16:17PM +0100, Linus Walleij wrote: >> On Fri, Dec 29, 2017 at 9:13 PM, William Breathitt Gray >> wrote: >> >>> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus >>> driver. T

Re: [PATCH v2 5/5] pc104: Add EXPERT dependency for PC104 Kconfig option

2018-02-22 Thread William Breathitt Gray
On Thu, Feb 22, 2018 at 04:20:46PM +0100, Linus Walleij wrote: >On Fri, Dec 29, 2017 at 9:14 PM, William Breathitt Gray > wrote: > >> PC/104 device driver Kconfig options previously had an implicit EXPERT >> dependency by way of an explicit ISA_BUS_API dependency. Now that these >> driver Kconfig o

Re: [PATCH] max17042: propagate of_node to power supply device

2018-02-22 Thread Sebastian Reichel
Hi, On Tue, Feb 20, 2018 at 06:58:56PM +0100, Pierre Bourdon (delroth) wrote: > On Tue, Feb 20, 2018 at 6:34 PM, Andy Shevchenko > wrote: > > On Tue, Feb 20, 2018 at 5:03 PM, Pierre Bourdon wrote: > >> max17042_get_status uses the core power_supply_am_i_supplied. That > >> function relies on DT

Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

2018-02-22 Thread Darren Hart
On Thu, Feb 22, 2018 at 08:15:51PM +, Jeremy Cline wrote: > On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote: > > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6 > > interface but don't initialize the bit that intel-vbtn uses to > > represent switching tablet m

Re: [RFC][PATCH 08/10] x86/mm: do not forbid _PAGE_RW before init for __ro_after_init

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 12:37 PM, Dave Hansen wrote: > > From: Dave Hansen > > __ro_after_init data gets stuck in the .rodata section. That's normally > fine because the kernel itself manages the R/W properties. > > But, if we run __change_page_attr() on an area which is __ro_after_init, > the .

Re: [PATCH v2 0/7] fujitsu-laptop: Miscellaneous cleanups

2018-02-22 Thread Darren Hart
On Tue, Feb 20, 2018 at 06:24:47AM +0100, Michał Kępień wrote: > This patch series contains miscellaneous cleanups which I think are > worth getting done before splitting fujitsu-laptop into two separate > modules. > > Changes from v1: > > - [6/7] Rename BACKLIGHT_POWER to BACKLIGHT_PARAM_POWER

Re: [PATCH 2/6] pci: Scan all functions when probing while running over Jailhouse

2018-02-22 Thread Bjorn Helgaas
On Mon, Jan 22, 2018 at 07:12:46AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > PCI and PCIBIOS probing only scans devices at function number 0/8/16/... > Subdevices (e.g. multiqueue) have function numbers which are not a > multiple of 8. Suggested text: Per PCIe r4.0, sec 7.5.1.1.9, multi

Re: [PATCH v8 7/8] livepatch: Correctly handle atomic replace for not yet loaded modules

2018-02-22 Thread Miroslav Benes
On Wed, 21 Feb 2018, Petr Mladek wrote: > The atomic replace feature uses dynamically allocated struct klp_func to > handle functions that will not longer be patched. These structures are s/not longer/no longer/, but "handle functions that will not be patched any longer" may be even better. > o

Re: [PATCH] PCI: update location of pci.ids file

2018-02-22 Thread Bjorn Helgaas
On Sat, Feb 03, 2018 at 04:53:09PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Update the URL for the pci.ids file and add locations for its mirrors. > > Signed-off-by: Randy Dunlap > Cc: Martin Mares > Cc: Michal Vaner Applied to for-linus for v4.16, thanks! > --- > Documentation/

Re: [PATCH v2] staging: android: ashmem: Fix lockdep issue during llseek

2018-02-22 Thread Joel Fernandes
(reposting in plain text, sorry for the previous HTML email, I should have not posted from the Phone) On Thu, Feb 22, 2018 at 5:48 AM, Greg Kroah-Hartman wrote: > On Fri, Feb 16, 2018 at 11:02:01AM -0800, Joel Fernandes wrote: >> ashmem_mutex create a chain of dependencies like so: >> >> (1) >> m

[PATCH] lightnvm: fix memory leak in pblk_luns_init

2018-02-22 Thread Huaicheng Li
Signed-off-by: Huaicheng Li --- drivers/lightnvm/pblk-init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index 93d671ca518e..330665d91d8d 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -510,6 +510,

[tip:core/debugobjects] debugobjects: Fix debug_objects_freed accounting

2018-02-22 Thread tip-bot for Arnd Bergmann
Commit-ID: 04148187aa9df3626168f7429d2287997787e387 Gitweb: https://git.kernel.org/tip/04148187aa9df3626168f7429d2287997787e387 Author: Arnd Bergmann AuthorDate: Thu, 22 Feb 2018 16:52:58 +0100 Committer: Thomas Gleixner CommitDate: Thu, 22 Feb 2018 22:00:24 +0100 debugobjects: Fix deb

Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Rasmus Villemoes
On 2018-02-22 19:04, Linus Torvalds wrote: > > Lookie here (in a fully built tree): > > find . -name '*.o.cmd' | > xargs grep -L linux/compiler_types.h | > xargs grep -l linux/kconfig.h | > while read i; do > j=$(echo $i | sed 's/\.o.cmd$/\.c/' | sed 's:/\.

[tip:x86/urgent] genirq/matrix: Handle CPU offlining proper

2018-02-22 Thread tip-bot for Thomas Gleixner
Commit-ID: 651ca2c00405a2ae3870cc0b4f15a182eb6fbe26 Gitweb: https://git.kernel.org/tip/651ca2c00405a2ae3870cc0b4f15a182eb6fbe26 Author: Thomas Gleixner AuthorDate: Thu, 22 Feb 2018 12:08:05 +0100 Committer: Thomas Gleixner CommitDate: Thu, 22 Feb 2018 22:05:43 +0100 genirq/matrix: Hand

[tip:x86/urgent] x86/apic/vector: Handle vector release on CPU unplug correctly

2018-02-22 Thread tip-bot for Thomas Gleixner
Commit-ID: f60606c4ce402963dc552c62910ffa7080b4a628 Gitweb: https://git.kernel.org/tip/f60606c4ce402963dc552c62910ffa7080b4a628 Author: Thomas Gleixner AuthorDate: Thu, 22 Feb 2018 12:08:06 +0100 Committer: Thomas Gleixner CommitDate: Thu, 22 Feb 2018 22:05:44 +0100 x86/apic/vector: Ha

<    2   3   4   5   6   7   8   9   10   >