On Fri, 2017-11-17 at 18:02 -0600, Pierre-Louis Bossart wrote:
> No reason why SND_SOC_INTEL_SST should be set here.
> Also make sure same dependencies are used everywhere (only last one
> has SPI
> in addition)
Regarding to my comment against previous patch...
> config SND_SOC_INTEL_SKL_RT286_M
Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older
compilers which cannot process initializers for anonymous structures:
+const nfs4_stateid invalid_stateid = {
+ {
+ .seqid = cpu_to_be32(0xU),
+ .other = { 0 },
+ },
+ .type = NFS4
On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote:
> Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older
> compilers which cannot process initializers for anonymous structures:
>
> +const nfs4_stateid invalid_stateid = {
> + {
> + .seqid = cpu_to_be32(0xf
Removed uneccessary parantheses which were sorrounding two
if-statements.
Signed-off-by: Fabian Baumanis
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drivers/staging/comedi/d
Extremely sorry for the delay.
This works for VFIO_GFX_PLANE_TYPE_REGION. Tested with local changes.
Reviewed-by: Kirti Wankhede
Thanks,
Kirti
On 11/18/2017 9:00 PM, Alex Williamson wrote:
>
> Kirti?
>
> On Wed, 15 Nov 2017 21:11:42 -0700
> Alex Williamson wrote:
>
>> On Thu, 16 Nov 2017 11
I noticed when checking out the OpenWRT support for the board that they
have a method to avoid having to pass the device tree address to the
kernel, and can thus boot device tree based kernels with U-boots that
does not support device trees.
Is this something that would be considered useful for
On 11/18/2017 12:39 PM, Trond Myklebust wrote:
On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote:
Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older
compilers which cannot process initializers for anonymous structures:
+const nfs4_stateid invalid_stateid = {
+ {
+
On Sat, 2017-11-18 at 13:07 -0500, Boris Ostrovsky wrote:
>
> On 11/18/2017 12:39 PM, Trond Myklebust wrote:
> > On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote:
> > > Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older
> > > compilers which cannot process initializers for ano
On Sat, 18 Nov 2017 23:29:31 +0530
Kirti Wankhede wrote:
> Extremely sorry for the delay.
> This works for VFIO_GFX_PLANE_TYPE_REGION. Tested with local changes.
>
> Reviewed-by: Kirti Wankhede
With that,
Acked-by: Alex Williamson
> On 11/18/2017 9:00 PM, Alex Williamson wrote:
> >
> > Kir
Hi Linus,
Here is the collected material against Platform Drivers x86 subsystem.
It's rather bit busy cycle for PDx86, mostly due to Dell SMBIOS driver
activity.
During merge it will get a conflict
CONFLICT (content): Merge conflict in Documentation/admin-guide/thunderbolt.rst
that is pretty st
Hi,
On Tue, Oct 03, 2017 at 06:29:49PM -0400, Nicolas Pitre wrote:
> On Tue, 3 Oct 2017, Tejun Heo wrote:
>
> > On Tue, Oct 03, 2017 at 04:57:44PM -0400, Nicolas Pitre wrote:
> > > This can be much smaller than a page on very small memory systems.
> > > Always rounding up the size to a page is w
On Sat, Nov 18, 2017 at 08:21:22AM +, Russell King - ARM Linux wrote:
> On Sat, Nov 18, 2017 at 02:36:53AM +0530, Arvind Yadav wrote:
> > platform_get_irq() can fail here and we must check its return value.
>
> The test should be <= 0, and you need to return an error code for the
> 0 case.
In
On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav
> ---
> changes in v2:
>
On Sat, Nov 18, 2017 at 11:27:24AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote:
> > On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote:
> > > There is no need to #define the license of the driver, just put it in
> > > the MODULE
On 11/18/2017 01:12 PM, Trond Myklebust wrote:
Sigh OK, how about something like the following then:
{ .data = { 0xff, 0xff, 0xff, 0xff, 0 }, }
Yes, this does build.
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 54fd56d..daa6085 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs
On Fri, 2017-11-17 at 15:57 +0100, Sebastian Siewior wrote:
> On 2017-11-13 12:56:53 [-0500], Mikulas Patocka wrote:
> > Hi
> Hi,
>
> > I'm submitting this patch for the CONFIG_PREEMPT_RT patch. It fixes
> > deadlocks in device mapper when real time preemption is used.
>
> applied, thank you.
B
On Sat, Nov 18, 2017 at 10:09 AM, Andy Shevchenko
wrote:
>
> Here is the collected material against Platform Drivers x86 subsystem.
> It's rather bit busy cycle for PDx86, mostly due to Dell SMBIOS driver
> activity.
So I note that you seem to use the same summary script that Darren used.
Guys,
Please pull nfsd changes for 4.15 from:
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.15
Lots of good bugfixes, including:
- fix a number of races in the NFSv4+ state code.
- fix some shutdown crashes in multiple-network-namespace cases.
- relax our 4.1 session lim
On 11/09/2017 08:14 AM, Richard Schmitt wrote:
> Using a 4.9 kernel, trying to boot a kernel using an eMMC based rootfs will
> result in a crash
>
> The message preceeding the crash is:
>
> [3.285566] VFS: Cannot open root device "mmcblk0p9" or
> unknown-block(0,0): error -6
> [3.293338
> On Nov 18, 2017, at 7:32 AM, Yafang Shao wrote:
>
> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other
> transitions are not traced with tcp_set_state tracepoint.
>
> In order to trace the whole tcp lifespans, two helpers are introduced,
> void __tcp_set_state(struct sock *s
gcc 4.4.4 is too old to have full C11 anonymous union support, so
the current initialiser fails to compile.
Reported-by: Boris Ostrovsky
Signed-off-by: Trond Myklebust
---
fs/nfs/nfs4state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4
2017-11-16 19:33 GMT+01:00 Thomas Gleixner :
> Add the full text of the GPL 2.0 license to the kernel tree. It was
> copied directly from:
>
>https://spdx.org/licenses/GPL-2.0.html#licenseText
>
> Add the required tags for reference and tooling.
>
> Signed-off-by: Thomas Gleixner
NACKed-by:
2017-11-18 20:03 GMT+01:00 Charlemagne Lasse :
>> +Ty Coon, President of Vice
>> +
>> +This General Public License does not permit incorporating your program into
>> +proprietary programs. If your program is a subroutine library, you may
>> +consider it more useful to permit linking proprietar
From: Markus Elfring
Date: Sat, 18 Nov 2017 19:50:12 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Adjust 34 function calls together with a variable assignment
Use common error handling code in two functions
Use common error ha
From: Markus Elfring
Date: Sat, 18 Nov 2017 18:50:22 +0100
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix affected source code places.
Signed-off-by: Markus Elfring
---
sound/pci/trident/trident.c | 24 +-
From: Markus Elfring
Date: Sat, 18 Nov 2017 19:29:35 +0100
Add jump targets so that a bit of exception handling can be better reused
at the end of these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
sound/pci/trident/trident.c | 54
You may be confusing things because of a newer version.
On Sat, Nov 18, 2017 at 11:03 AM, Charlemagne Lasse
wrote:
>
> That should be "GNU Lesser General Public" and not "GNU Library General
> Public"
That's just FSF revisionism.
It used to be called "Library" over "Lesser", in the original GP
From: Markus Elfring
Date: Sat, 18 Nov 2017 19:49:50 +0100
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
Signed-off-by: Markus Elfring
---
sound/pci/trident/trident_main.c | 71 +++-
1 file changed,
>This is neither the GPL-2.0 from
>https://www.gnu.org/licenses/gpl-2.0.txt
I think it should be the copy from COPYING, in fact, since that's the exact GPL
2.0 license the kernel is under. Library GPL is factually correct; Lesser GPL
is a newer name for the same license, but COPYING retains the
On 2017-11-17 22:54, Thomas Gleixner wrote:
> On Thu, 16 Nov 2017, Jan Kiszka wrote:
>
>> +config JAILHOUSE_GUEST
>> +bool "Jailhouse non-root cell support"
>> +depends on PARAVIRT && X86_64
>> +---help---
>> + This option allows to run Linux as guest in a Jailhouse non-root
>>
On 2017-11-17 23:49, Thomas Gleixner wrote:
> On Thu, 16 Nov 2017, Jan Kiszka wrote:
>> Calibrate the TSC and, where necessary, the APIC timer against the
>> TMTIMER. We need our own implementation as neither the PIC nor the HPET
>> are available, and the standard calibration routines try to make u
On 11/18/2017 01:50 PM, Trond Myklebust wrote:
gcc 4.4.4 is too old to have full C11 anonymous union support, so
the current initialiser fails to compile.
Reported-by: Boris Ostrovsky
Signed-off-by: Trond Myklebust
(compile-)Tested-by: Boris Ostrovsky
---
fs/nfs/nfs4state.c | 4 ++--
On Sat, Nov 18, 2017 at 10:40 AM, J. Bruce Fields wrote:
> Please pull nfsd changes for 4.15 from:
Hmm. This had a tracepoint conflict with the nfs client pull.
The resolution seems obvious and I did it, but I'd like people to
review the end result but particularly also their workflows, because
Hi Kees,
I came up with the following text (patch below) to describe the
SECCOMP_RET_KILL_PROCESS action that you added in 4.14. Does it
look okay?
SECCOMP_RET_KILL_PROCESS (since Linux 4.14)
This value results in immediate termination of the process,
with a co
On Sat, Nov 18, 2017 at 10:37 AM, Linus Torvalds
wrote:
>
> So I note that you seem to use the same summary script that Darren used.
.. oh, and I note a *much* worse issue.
You add new drivers and then default them to "on".
THAT IS COMPLETELY UNACCEPTABLE.
I don't know why I have to say this e
On Fri, Nov 3, 2017 at 2:09 AM, Michal Hocko wrote:
> On Thu 02-11-17 23:35:44, Shawn Landden wrote:
>> 16 bytes per process is kinda spendy, but I want to keep
>> lru behavior, which mem_score_adj does not allow. When a supervisor,
>> like Android's user input is keeping track this can be done in
This patch is to add the machine descriptions for ODROID-XU3/4 boards
in order to present the hardware name at /proc/cputinfo rather than
"SAMSUNG EXYNOS (Flattened Device Tree)". An embedded open source project,
such as DietPi, reads the hardware name to run different features.
$ cat /pro
From: Markus Elfring
Date: Sat, 18 Nov 2017 21:27:50 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Adjust ten function calls together with a variable assignment
Use common error handling code in two functions
sound/pci/vx222/vx22
From: Markus Elfring
Date: Sat, 18 Nov 2017 21:10:37 +0100
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
sound/pci/vx222/vx222.c | 19
From: Markus Elfring
Date: Sat, 18 Nov 2017 21:23:27 +0100
Add jump targets so that a bit of exception handling can be better reused
at the end of these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
sound/pci/vx222/vx222.c | 44
2017-11-18 20:14 GMT+01:00 Linus Torvalds :
> You may be confusing things because of a newer version.
>
> I refuse to change the original copyright wording due to idiotic
> internal FSF politics that tried to change history.
But you are accepting commit messages which are factually wrong? I am no
On Sat, Nov 18, 2017 at 12:04 PM, Michael Kerrisk (man-pages)
wrote:
> Hi Kees,
>
> I came up with the following text (patch below) to describe the
> SECCOMP_RET_KILL_PROCESS action that you added in 4.14. Does it
> look okay?
>
>SECCOMP_RET_KILL_PROCESS (since Linux 4.14)
>
On Fri, Nov 17, 2017 at 12:07 PM, Thomas Gleixner wrote:
> On Fri, 17 Nov 2017, Andi Kleen wrote:
>> > The most straight forward is to have a mechanism which forces everything
>> > into the slow path in case of debugging, lack of progress, etc. The slow
>>
>> That's the abort address, right?
>
> Y
From: Markus Elfring
Date: Sat, 18 Nov 2017 22:10:19 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
sound/pci/cs5530.c | 17 +-
On 11/15/17 23:26, Jan Kiszka wrote:
> This series paves the way to run Linux in so-called non-root cells
> (guest partitions) of the Jailhouse hypervisor.
>
> Jailhouse [1] was started 4 years ago as an open-source (GPL) leight-
> weight hypervisor that statically partitions SMP systems. It's uni
On Fri, Nov 17, 2017 at 09:32:15PM +, Al Viro wrote:
> And for get_user_pages() itself it's even more ridiculous - vmalist (the last
> argument) is non-NULL in only one caller. Which uses it only to check if all
> of the VMAs happen to be hugetlb ones, apparently.
>
> FWIW, I wanted to trim
Hello,
Two days ago i bought from your website at value 215.60 dedic.
I used my credit card to pay for 215.60 for those service.
Yesterday morning when I checked my account, I had the transaction charged
twice.
I have attached my bank statement that shows the double charge.
Plase let me know
On Fri, Nov 17, 2017 at 1:32 PM, Al Viro wrote:
> On Fri, Nov 17, 2017 at 12:50:47PM -0800, Linus Torvalds wrote:
>
>> Not because the conversion was wrong, but because the original code is
>> so broken.
>>
>> In particular, that "1" that is unchanged in the arguments is correct
>> in the conversi
On Sat, Nov 18, 2017 at 12:22 AM, Jonathan Neuschäfer
wrote:
> This device's bindings are not trivial: Additional properties are
> documented in in Documentation/devicetree/bindings/mfd/mc13xxx.txt.
>
> Signed-off-by: Jonathan Neuschäfer
Reviewed-by: Fabio Estevam
Thanks
On 28 October 2017 at 00:30, Rasmus Villemoes wrote:
> Ever since "random: kill dead extract_state struct" [1], the
> dont_count_entropy member of struct timer_rand_state has been
> effectively unused. Since it hasn't found a new use in 12 years, it's
> probably safe to finally kill it.
Ping.
Hello,
Two days ago i bought from your website at value 215.60 dedic.
I used my credit card to pay for 215.60 for those service.
Yesterday morning when I checked my account, I had the transaction charged
twice.
I have attached my bank statement that shows the double charge.
Plase let me
Hi Kees!
On 18 November 2017 at 21:52, Kees Cook wrote:
> On Sat, Nov 18, 2017 at 12:04 PM, Michael Kerrisk (man-pages)
> wrote:
>> Hi Kees,
>>
>> I came up with the following text (patch below) to describe the
>> SECCOMP_RET_KILL_PROCESS action that you added in 4.14. Does it
>> look okay?
>>
>
Since the device only has 6 physical buttons, I don't think unmasking
all 8 bits in the HID report descriptor is appropriate. If you do that
then userspace sees a mouse with 8 buttons and you never know when
software might actually behave differently depending on that number. (I
can imagine fancy m
On Thu, Nov 16, 2017 at 5:55 PM, Nicolin Chen wrote:
> ASRFSTi_IAEi has an 11-bit offset as its _SHIFT macro defines.
>
> So this patch just fixes that.
>
> Reported-by: Laurent Charpentier
> Signed-off-by: Nicolin Chen
Reviewed-by: Fabio Estevam
Hi Serge,
On Fri, 2017-11-17 at 22:20 -0600, Serge E. Hallyn wrote:
> On Tue, Nov 07, 2017 at 11:37:01AM +0100, Roberto Sassu wrote:
> > from a predefined position (/etc/ima/digest_lists/metadata), when rootfs
> > becomes available. Digest lists must be loaded before IMA appraisal is in
> > enforc
On Sat, Nov 18, 2017 at 10:27:26PM +, Tomasz Kramkowski wrote:
> I was going to do this just now actually but then I noticed that someone
> had beat me to the punch with the EX-G (I was already surprised when I
> found someone had patched the HUGE and DEFT).
Actually, I'll put my money where m
Add two tips that summary perf trace and perf trace record to know
Intuitively.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Taeung Song
Signed-off-by: Sangwon Hong
---
tools/perf/Documentation/tips.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/Documentation/tips.txt
b/tools/per
Fix gcc warnings about variable 'ec_device' being set but not used
in these files:
common/cros_ec_sensors/cros_ec_sensors.c:194:25
light/cros_ec_light_prox.c:184:25
Signed-off-by: Paolo Cretaro
---
drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 --
drivers/iio/light/cros_ec_light_prox.
On Sun, Nov 19, 2017 at 12:31:45AM +, Diego Elio Pettenò wrote:
> Please do not drop the explicit documentation of the diff. Looking at what
> a driver does in three years is not going to be obvious, whether you know
> HID or not.
I'm sure there are situations where this is true but I've just
Kirill Tkhai writes:
> Hi,
>
> this is continuation of discussion from here:
>
> https://lkml.org/lkml/2017/11/14/298
>
> The plan has changed a little bit, so I'd be happy to hear
> people's comments, before I dived into all 400+ pernet subsys
> and devices.
>
> The patch set adds pernet sys lis
On Fri, Nov 17, 2017 at 09:40:15PM +0600, Rakib Mullick wrote:
> Currently have_rcu_nocb_mask is used to avoid double allocation of
> rcu_nocb_mask during boot up. Due to different representation of
> cpumask_var_t on different kernel config CPUMASK=y(or n) it was okay.
> But now we have a helper c
perf probe command defines dynamic tracepoint events, by symbol and registers
without debuginfo, or by C expressions with debuginfo.
---
tools/perf/Documentation/tips.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/tips.txt
b/tools/perf/Documentati
From: "Gustavo A. R. Silva"
Date: Fri, 17 Nov 2017 14:02:09 -0600
> _dev_ is being dereferenced before it is null checked, hence there
> is a potential null pointer dereference.
>
> Fix this by moving the pointer dereference after _dev_ has been null
> checked.
>
> Addresses-Coverity-ID: 146202
From: Yafang Shao
Date: Sat, 18 Nov 2017 15:32:36 +
> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other
> transitions are not traced with tcp_set_state tracepoint.
>
> In order to trace the whole tcp lifespans, two helpers are introduced,
> void __tcp_set_state(struct sock
On Fri, Aug 26, 2016 at 04:37:21PM +0100, Paul Burton wrote:
> Introduce a "generic" platform, which aims to be board-agnostic by
> making use of device trees passed by the boot protocol defined in the
> MIPS UHI (Universal Hosting Interface) specification. Provision is made
> for supporting boards
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so changed it to signed.
changes in v3 :
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return EIO insted of ctx->irq_num.
sound/soc/intel/atom/sst/sst_acpi.c |
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so changed it to signed.
changes in v3 :
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so using signed variable ret.
changes in v3 :
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return EIO insted of ctx->irq_num.
sound/soc/intel/boards/mfld_machine.c
On Fri, Nov 17, 2017 at 08:45:03PM -0800, Shawn Landden wrote:
> On Fri, Nov 3, 2017 at 2:09 AM, Michal Hocko wrote:
> > On Thu 02-11-17 23:35:44, Shawn Landden wrote:
> > > 16 bytes per process is kinda spendy, but I want to keep
> > > lru behavior, which mem_score_adj does not allow. When a supe
> This replaces the custom license information text with the appropriate
> SPDX identifier. While the information here stays the same, it is easier
> to read.
> Signed-off-by: Martin Kepplinger
> Acked-by: Peter Meerwald-Stadler
Acked-by: Harinath Nampally
On Sat, Nov 18, 2017 at 11:29 AM, Phil
On Mon, Nov 13, 2017 at 11:31:31AM -0800, Matt Wilson wrote:
> From: Matt Wilson
>
> This device will be used in future Amazon EC2 instances as the primary
> serial port (i.e., data sent to this port will be available via the
> GetConsoleOuput [1] EC2 API).
Ping?
--msw
> [1]
> http://docs.aws
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. If IRQ0 is not valid.
changes in v3 :
return -EINVAL insted of irq.
drivers/mfd/sun4i-gpadc.c | 7 +--
1
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes i
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid.
changes i
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sdhci-spear.c | 4 +
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sdhci-acpi.c | 4 ++
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
return -EINVAL instead of host->irq.
drivers/mmc/host/sunxi-mmc.c | 5 +++
Signed-off-by: Jonathan Neuschäfer
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2811a211632c..a644d41e088c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14447,6 +14447,7 @@ W: http://www.slimlogic.co.uk/?p=48
T: git git://git.kerne
This involves using the REGULATOR_SUPPLY initializer macro and
reindenting some of the code.
Signed-off-by: Jonathan Neuschäfer
---
Documentation/power/regulator/machine.txt | 36 ++-
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/Documentation/power/
Hi Jon,
On Tue, Nov 14, 2017 at 02:43:27PM +, Jon Hunter wrote:
> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
> the EC is failing.
>
> The Tegra SPI driver configures the SPI chip-selects to be active-high
> by default (and always has for many years). The EC SPI req
Hi Jon,
On Tue, Nov 14, 2017 at 02:43:28PM +, Jon Hunter wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicat
>> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>>
>> *r_via = chip;
>> return 0;
>> +
>> +disable_device:
>> +pci_disable_device(pci);
>> +goto exit;
>> +free_chip:
>> +snd_via82xx_free(chip);
>> +exit:
>> +return err;
>
> Doubly goto doe
From: Markus Elfring
Date: Sun, 19 Nov 2017 07:55:49 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace two calls of the function "dev_err" by goto statements.
This issue was detected by using the Coccinelle sof
201 - 288 of 288 matches
Mail list logo
