Re: [RFC][PATCH 1/8] epoll: remove epmutex from ep_free() & eventpoll_release_file()

2017-10-30 Thread Hou Tao
Hi, On 2017/10/28 21:58, Davidlohr Bueso wrote: > On Sat, 28 Oct 2017, Hou Tao wrote: > >> Remove the global epmutex from ep_free() and eventpoll_release_file(). >> In the later patches, we will add locks with a smaller granularity >> to serve the same purposes of epmutex. >> >> Signed-off-by: Ho

[PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-10-30 Thread Tero Kristo
The recent change to the PM QoS framework to introduce a proper no constraint value overlooked to handle the devices which don't implement PM QoS OPS. Runtime PM is one of the more severely impacted subsystems, failing every attempt to runtime suspend a device. This leads into some nasty second lev

Re: [PATCH] sound: fix kernel-doc build warning

2017-10-30 Thread Takashi Iwai
On Mon, 30 Oct 2017 01:08:52 +0100, Randy Dunlap wrote: > > From: Randy Dunlap > > Fix kernel-doc build error. A symbol that ends with an underscore > character ('_') has special meaning in reST (reStructuredText), so add > a '*' to prevent this error and to indicate that there are several of >

Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail

2017-10-30 Thread Pintu Kumar
On Sun, Oct 29, 2017 at 7:51 PM, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-6): > > commit: 5fb70554d68e2ea032b6a28b082801d8b7b76cb8 ("android/ion: userspace > test utility for ion buffer sharing") > url: > https://github.com/0day-ci/linux/commits/Pintu-Aga

[mainline][ppc] sysfs: cannot create duplicate filename '/devices/hv_24x7/events/PM_CAPP1_APC_UOP_SEND_PB_CMD'

2017-10-30 Thread Abdul Haleem
Hi, A warning is being triggered while booting mainline kernel on ppc machine. Machine Type: Power 9 Kernel : 4.14.0-rc6 gcc: 4.8.5 Test : Boot Boot logs: -- hv-24x7: found a duplicate event PM_CAPP1_XPT_MSG_SENT_GT_16_LE_64, ct=1 hv-24x7: found a duplicate event PM_CAPP1_XPT_MSG_SENT_TS

[PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-10-30 Thread Prateek Sood
Remove circular dependency deadlock in a scenario where hotplug of CPU is being done while there is updation in cgroup and cpuset triggered from userspace. Process A => kthreadd => Process B => Process C => Process A Process A cpu_subsys_offline(); cpu_down(); _cpu_down(); percpu_down

Re: [lkp-robot] [locking/lockdep] 2dcd5adfb7: WARNING:possible_circular_locking_dependency_detected

2017-10-30 Thread Byungchul Park
On Sun, Oct 29, 2017 at 10:18:55PM +0800, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-5): > > commit: 2dcd5adfb7401b762ddbe4b86dcacc2f3de6b97b ("locking/lockdep: Remove > the BROKEN flag from CONFIG_LOCKDEP_CROSSRELEASE and > CONFIG_LOCKDEP_COMPLETIONS") >

[btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

2017-10-30 Thread Fengguang Wu
CC fsdevel. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot error/warnings when testing v4.14-rc6. They hit the RC release mainly due to various imperfections in 0day's auto bisection. So I manually list them here and CC the likely easy t

[f2fs-dev] [PATCH] f2fs: optimize __update_nat_bits

2017-10-30 Thread Fan Li
Make three modification for __update_nat_bits: 1. Take the codes of dealing the nat with nid 0 out of the loop Such nat only needs to be dealt with once at beginning. 2. Use " nat_index == 0" instead of " start_nid == 0" to decide if it's the first nat block It's better that we don't assum

Crypto Fixes for 4.14

2017-10-30 Thread Herbert Xu
Hi Linus: This push fixes an objtool regression. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Jason A. Donenfeld (1): crypto: x86/chacha20 - satisfy stack validation 2.0 arch/x86/crypto/chacha20-avx2-x86_64.S |4 ++-- arch/x86/crypt

[PATCH] iio: adc: aspeed: Deassert reset in probe

2017-10-30 Thread Joel Stanley
The ASPEED SoC must deassert a reset in order to use the ADC peripheral. The device tree bindings are updated to document the resets phandle, and the example is updated to match what is expected for both the reset and clock phandle. Signed-off-by: Joel Stanley --- .../devicetree/bindings/iio/ad

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-30 Thread Mika Westerberg
On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > This patch adds Intel Lewisburg PCH SPI serial flash controller super > SKU PCI ID. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Mika Westerberg

Re: [PATCH v4] KVM: arm/arm64: fix the incompatible matching for external abort

2017-10-30 Thread Christoffer Dall
On Mon, Oct 30, 2017 at 02:05:18PM +0800, Dongjiu Geng wrote: > kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but > calls kvm_vcpu_trap_get_fault_type() that only returns the fault class, > thus reducing the scope of the check. This doesn't cause any observable > bug yet as we end-

[PATCH] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 08:28:06 +0100 Adjust a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle softwar

Re: [PATCH] irqdomain: Update the comments of fwnode field of irq_domain structure

2017-10-30 Thread Marc Zyngier
On Mon, Oct 30 2017 at 10:15:00 am GMT, Dou Liyang wrote: > Commit: > > f110711a6053 ("irqdomain: Convert irqdomain-%3Eof_node to fwnode") > > converted of_node field to fwnode, but didn't update its comments. > > Update it. > > Signed-off-by: Dou Liyang Queued, thanks. M. -- Jazz is

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

2017-10-30 Thread Greg KH
On Sun, Oct 29, 2017 at 02:25:29PM -0400, Theodore Ts'o wrote: > On Sat, Oct 28, 2017 at 11:22:00AM +0800, Chen Feng wrote: > > > > I checked the ioctl. What's the purpose of RNDADDTOENTCNT ioctl to > > userspace? > > It's a legacy ioctl which is probably not used anywhere; it's been > replaced b

[pmem_attach_disk] WARNING: CPU: 46 PID: 518 at kernel/memremap.c:363 devm_memremap_pages+0x350/0x4b0

2017-10-30 Thread Fengguang Wu
CC nvdimm maintainers. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot error/warnings when testing v4.14-rc6. They hit the RC release mainly due to various imperfections in 0day's auto bisection. So I manually list them here and CC the li

Re: [PATCH] netfilter: ipset: ip_set_bitmap_ipmac: use swap macro in bitmap_ipmac_create

2017-10-30 Thread Jozsef Kadlecsik
Hi, On Sat, 28 Oct 2017, Gustavo A. R. Silva wrote: > Make use of the swap macro and remove unnecessary variable tmp. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Please resubmit the tree patc

Re: [btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

2017-10-30 Thread Eryu Guan
Hi Fengguang, On Mon, Oct 30, 2017 at 08:20:21AM +0100, Fengguang Wu wrote: > CC fsdevel. > > On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: > > Hi Linus, > > > > Up to now we see the below boot error/warnings when testing v4.14-rc6. > > > > They hit the RC release mainly due to

Re: [locking/paravirt] static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()

2017-10-30 Thread Juergen Gross
On 30/10/17 08:35, Fengguang Wu wrote: > On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: >> Hi Linus, >> >> Up to now we see the below boot error/warnings when testing v4.14-rc6. >> >> They hit the RC release mainly due to various imperfections in 0day's >> auto bisection. So I manual

Re: 4.13 (and probably all recent) kernels refuse to boot on one Nokia N950, work or another

2017-10-30 Thread Pavel Machek
Hi! > > I got "uncompressing Linux 4.13" on serial console now, debug LEDs > > blinking, and if I use a flashlight, I see output on the screen, too. > > > > (What do I need to do to get the backlight working?) > > Glad you got it working :) For backlight you can add this > in drivers/gpu/drm/oma

Re: [PATCH v6 0/9] vITS Migration fixes and reset

2017-10-30 Thread Auger Eric
Hi Christoffer, On 30/10/2017 07:20, Christoffer Dall wrote: > Hi Eric, > > On Thu, Oct 26, 2017 at 05:23:02PM +0200, Eric Auger wrote: >> This series fixes various bugs observed when saving/restoring the >> ITS state before the guest writes the ITS registers (on first boot or >> after reset/rebo

Re: [PATCH 2/8] irqchip: mips-gic: Use irq_cpu_online to (un)mask all-VP(E) IRQs

2017-10-30 Thread Marc Zyngier
On Wed, Oct 25 2017 at 5:37:24 pm BST, Paul Burton wrote: > The gic_all_vpes_local_irq_controller chip currently attempts to operate > on all CPUs/VPs in the system when masking or unmasking an interrupt. > This has a few drawbacks: > > - In multi-cluster systems we may not always have access t

Re: [PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-30 Thread Michal Hocko
On Mon 30-10-17 08:57:13, Minchan Kim wrote: [...] > Although it's better than old, we can make it simple, still. > > diff --git a/include/linux/swapops.h b/include/linux/swapops.h > index 291c4b534658..f50d5a48f03a 100644 > --- a/include/linux/swapops.h > +++ b/include/linux/swapops.h > @@ -41,6

Re: [PATCH] kprobes, x86/alternatives: use text_mutex to protect smp_alt_modules

2017-10-30 Thread Masami Hiramatsu
On Fri, 27 Oct 2017 17:34:44 +0800 Zhou Chengming wrote: > Fixes: 2cfa197 "ftrace/alternatives: Introducing *_text_reserved > functions" > > We use alternatives_text_reserved() to check if the address is in > the fixed pieces of alternative reserved, but the problem is that > we don't hold the s

[PATCH v5 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-30 Thread Dongli Zhang
After guest live migration on xen, steal time in /proc/stat (cpustat[CPUTIME_STEAL]) might decrease because steal returned by xen_steal_lock() might be less than this_rq()->prev_steal_time which is derived from previous return value of xen_steal_clock(). For instance, steal time of each vcpu is 33

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread SF Markus Elfring
>>> I mean you aren't really making the code any smaller >> >> Would anybody like to check corresponding effects in more detail >> after a specific function call was replaced by a goto statement? > > You are supposed to do it and not "anybody". I can offer another bit of information for this soft

Re: [PATCH] Bluetooth: avoid recursive locking in hci_send_to_channel()

2017-10-30 Thread Marcel Holtmann
Hi Sebastian, > Mart reported a deadlock in -RT in the call path: > hci_send_monitor_ctrl_event() -> hci_send_to_channel() > > because both functions acquire the same read lock hci_sk_list.lock. This > is also a mainline issue because the qrwlock implementation is writer > fair (the traditional

Re: [PATCH v2 1/3] mtd: spi-nor: stm32-quadspi: Fix uninitialized error return code

2017-10-30 Thread Ludovic BARRE
thanks Cyrille indeed, the "Signed-off" on Geert'commit was a mistake BR Ludo On 10/29/2017 06:50 PM, Cyrille Pitchen wrote: Hi Ludovic, Le 26/10/2017 à 17:12, Ludovic Barre a écrit : From: Geert Uytterhoeven With gcc 4.1.2: drivers/mtd/spi-nor/stm32-quadspi.c: In function ‘stm32_qspi

Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register

2017-10-30 Thread Jiada Wang
Hello Morimoto-san On 10/30/2017 08:38 AM, Kuninori Morimoto wrote: Hi Jiada register SSI_MODE is set when SSI works in TDM Extended or TDM (Ex-)Split mode, but it isn't reset after SSI stops. this will cause issue, if SSI starts to work in other modes which requie SSI_MODE to have different

Re: [PATCH linux-next 1/1] ASoC: rsnd: ssiu: reset SSI_MODE register

2017-10-30 Thread Kuninori Morimoto
Hi Jiada > > -- > > diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c > > index 4d94875..8dc2e92 100644 > > --- a/sound/soc/sh/rcar/ssiu.c > > +++ b/sound/soc/sh/rcar/ssiu.c > > @@ -130,14 +130,13 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod, > > if (r

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

2017-10-30 Thread Vitaly Kuznetsov
Greg KH writes: > On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microsoft.com wrote: >> From: Vitaly Kuznetsov >> >> Add tracepoint to CHANNELMSG_OPENCHANNEL sender. >> >> Signed-off-by: Vitaly Kuznetsov >> Signed-off-by: K. Y. Srinivasan >> --- >> drivers/hv/channel.c | 2 ++ >>

Re: net: hns: set correct return value

2017-10-30 Thread Tobias Klauser
On 2017-10-29 at 15:35:32 +0100, Pan Bian wrote: > The function of_parse_phandle() returns a NULL pointer if it cannot > resolve a phandle property to a device_node pointer. In function > hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract > the error code. However, in this case,

Re: possible deadlock in lru_add_drain_all

2017-10-30 Thread Michal Hocko
[Cc Byungchul. The original full report is http://lkml.kernel.org/r/089e0825eec8955c1f055c83d...@google.com] Could you have a look please? This smells like a false positive to me. On Fri 27-10-17 15:42:34, Michal Hocko wrote: > On Fri 27-10-17 11:44:58, Dmitry Vyukov wrote: > > On Fri, Oct 27, 20

Re: [PATCH] Fix writing mtdoops to nand flash.

2017-10-30 Thread Boris Brezillon
Hi Brent, Subject should be prefixed by "mtd: nand: ", so "mtd: nand: Fix writing mtdoops to nand flash" On Sun, 29 Oct 2017 23:23:43 -0500 moto...@gmail.com wrote: > From: Brent Taylor > > When mtdoops calls mtd_panic_write, it eventually calls > panic_nand_write in nand_base.c. In order to

Re: ubi: fastmap: use kmem_cache_free to deallocate memory

2017-10-30 Thread Boris Brezillon
On Sun, 29 Oct 2017 20:40:02 +0800 Pan Bian wrote: > Memory allocated by kmem_cache_alloc() should not be deallocated with > kfree(). Use kmem_cache_free() instead. > > Signed-off-by: Pan Bian Reviewed-by: Boris Brezillon Richard, maybe you can add: Fixes: dbb7d2a88d2a ("UBI: Add fastmap co

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: fix usb1 power supply

2017-10-30 Thread Kevin Hilman
Neil Armstrong writes: > Looking at the schematics, the USB Power Supply is shared between the > two USB interfaces, > If the usb0 fails to initialize, the second one won't have power. > > Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") > Signed-off-by: Neil Armstrong

Re: [PATCH 0/5] ARM: meson: enable gpio interrupt controller

2017-10-30 Thread Kevin Hilman
Jerome Brunet writes: > This patchset enables gpio interrupt controller found on the meson SoC > family. ATM, it supports meson8b, gxbb and gxl. The meson8 has been left > out because I don't have the documentation of this particular SoC. > > The last patch uses the interrupts provided by this co

Re: [PATCH] ubi: fastmap: clean up the initialization of pointer p

2017-10-30 Thread Boris Brezillon
On Sun, 29 Oct 2017 13:14:26 + Colin King wrote: > From: Colin Ian King > > The pointer p is being initialized with one value and a few lines > later being set to a newer replacement value. Clean up the code by > using the latter assignment to p as the initial value. Cleans up > clang warni

Re: [PATCH] fs, mm: account filp and names caches to kmemcg

2017-10-30 Thread Michal Hocko
On Fri 27-10-17 13:50:47, Shakeel Butt wrote: > > Why is OOM-disabling a thing? Why isn't this simply a "kill everything > > else before you kill me"? It's crashing the kernel in trying to > > protect a userspace application. How is that not insane? > > In parallel to other discussion, I think we

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Felipe Balbi
Hi, Doug Anderson writes: > Hi, > > On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: >> Hi Doug, >> >> [add Felipe since this should go through his tree] > > Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past No problems :-) > but for some reason get_maintainer didn't I

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-30 Thread Peter Rosin
On 2017-10-28 14:25, Wolfram Sang wrote: > >> Right. Blush. I blame the immense flow of patches. I just can't seem to >> keep up... :-) Anyway, thanks for catching this and sorry for making you >> do that. > > No worries. Patchwork makes it easy for me to track patches. Speaking > of, if you regi

Re: [RFC] NAND: Optimize NAND_ECC_HW_OOB_FIRST read

2017-10-30 Thread Boris Brezillon
Hi PrasannaKumar, On Sat, 28 Oct 2017 13:13:51 +0530 PrasannaKumar Muralidharan wrote: > From: Lars-Peter Clausen > > Avoid sending unnecessary READ commands to the chip. > > Signed-off-by: Lars-Peter Clausen > Signed-off-by: PrasannaKumar Muralidharan > --- > This patch is taken from git:/

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread Leon Romanovsky
On Mon, Oct 30, 2017 at 09:04:36AM +0100, SF Markus Elfring wrote: > >>> I mean you aren't really making the code any smaller > >> > >> Would anybody like to check corresponding effects in more detail > >> after a specific function call was replaced by a goto statement? > > > > You are supposed to

Re: [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations

2017-10-30 Thread Hans Verkuil
Hi Markus, On 09/24/2017 12:20 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 24 Sep 2017 12:06:54 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Delete an error message for a failed memory allocation

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-30 Thread Wolfram Sang
> Sounds like a splendid idea. I signed up as 'peda'. Great! > Do you need anything else? Nope, I need to ask Jeremy to add you to the i2c project. Can't do this myself, sadly. Will keep you updated! signature.asc Description: PGP signature

Re: [locking/paravirt] static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()

2017-10-30 Thread Fengguang Wu
On Mon, Oct 30, 2017 at 08:47:08AM +0100, Juergen Gross wrote: On 30/10/17 08:35, Fengguang Wu wrote: On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot error/warnings when testing v4.14-rc6. They hit the RC release mainly due to various im

Build regressions/improvements in v4.14-rc6

2017-10-30 Thread Geert Uytterhoeven
Below is the list of build error/warning regressions/improvements in v4.14-rc6[1] compared to v4.13[2]. Summarized: - build errors: +6/-0 - build warnings: +2016/-1207 JFYI, when comparing v4.14-rc6[1] to v4.14-rc5[3], the summaries are: - build errors: +0/-3 - build warnings: +6060/-1075

[PATCH] lib: hint GCC to inlilne _find_next_bit() helper

2017-10-30 Thread Clement Courbet
Hi Yury, I've tried your benchmark on x86-64 (haswell). Inlining is a pretty small increase in binary size: 48B (2%). In terms of speed, results are not very stable from one run to another (I've included two runs to give you an idea), but overall there seems to be small improvement on the random-

Re: [perf_event_ctx_lock_nested] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:97

2017-10-30 Thread Peter Zijlstra
On Mon, Oct 30, 2017 at 12:02:01AM +0100, Fengguang Wu wrote: > The dmesg fragment is > > [ 40.886662] done > [ 40.886686] [ 40.905102] capability: warning: `turbostat' uses 32-bit > capabilities (legacy support in use) > [ 40.940087] IPMI Device Information > [ 41.073351] [ 41.076223]

Re: [locking/paravirt] static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()

2017-10-30 Thread Dou Liyang
Hi Fengguang, There are two different warning. At 10/30/2017 03:35 PM, Fengguang Wu wrote: On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot error/warnings when testing v4.14-rc6. The original warning: WARNING:at_arch/x86/events/intel/

Re: [PATCH 03/14] VFS: Implement a filesystem superblock creation/configuration context [ver #6]

2017-10-30 Thread Miklos Szeredi
On Fri, Oct 27, 2017 at 6:03 PM, David Howells wrote: > Miklos Szeredi wrote: > >> Yes I did mean vfs_parse_sb_flag_option(). >> >> Yes, I understand its purpose, but it would be cleaner if all the >> option parsing was done in fc->ops->parse_option(). >> >> It might be worth introducing the vfs_

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

2017-10-30 Thread Greg KH
On Mon, Oct 30, 2017 at 09:16:19AM +0100, Vitaly Kuznetsov wrote: > Greg KH writes: > > > On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microsoft.com wrote: > >> From: Vitaly Kuznetsov > >> > >> Add tracepoint to CHANNELMSG_OPENCHANNEL sender. > >> > >> Signed-off-by: Vitaly Kuznetso

Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support

2017-10-30 Thread Jan Kara
Hi, On Mon 30-10-17 13:00:23, Dave Chinner wrote: > On Sun, Oct 29, 2017 at 04:46:44PM -0700, Dan Williams wrote: > > Coming back to this since Dave has made clear that new locking to > > coordinate get_user_pages() is a no-go. > > > > We can unmap to force new get_user_pages() attempts to block

Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug

2017-10-30 Thread Faiz Abbas
On Thursday 26 October 2017 01:29 PM, Faiz Abbas wrote: > David, > > On Thursday 19 October 2017 06:56 PM, David Laight wrote: >> From: Faiz Abbas >>> Sent: 19 October 2017 14:09 >>> On Thursday 19 October 2017 06:13 PM, Faiz Abbas wrote: Enable support for printing the LTSSM link state for

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread SF Markus Elfring
>> Do you find the following details useful for further clarification? > > Almost, you should compare sizes of mlx4_ib.ko and not > drivers/infiniband/hw/mlx4/main.o. text: -32 data: 0 bss: 0 The determined difference is the same finally. Regards, Markus

[PATCH] net: hns: set correct return value

2017-10-30 Thread Pan Bian
The function of_parse_phandle() returns a NULL pointer if it cannot resolve a phandle property to a device_node pointer. In function hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract the error code. However, in this case, the extracted error code will always be zero, which is un

Re: [PATCH v2] pids: introduce find_get_task_by_vpid helper

2017-10-30 Thread Balbir Singh
On Sat, Oct 28, 2017 at 4:52 AM, Mike Rapoport wrote: > There are several functions that do find_task_by_vpid() followed by > get_task_struct(). We can use a helper function instead. > > Signed-off-by: Mike Rapoport > --- I did a quick grep and found other similar patterns in kernel/events/core.

Re: [PATCH] usb: musb_core: mark expected switch fall-through

2017-10-30 Thread Greg Kroah-Hartman
On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote: > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > > Hi, > > > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > > In preparat

Re: [PATCH] usb: musb: Convert timers to use timer_setup()

2017-10-30 Thread Greg Kroah-Hartman
On Fri, Oct 27, 2017 at 11:24:22AM -0500, Bin Liu wrote: > Hi, > > On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass

Re: [perf_event_ctx_lock_nested] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:97

2017-10-30 Thread Fengguang Wu
On Mon, Oct 30, 2017 at 09:42:25AM +0100, Peter Zijlstra wrote: On Mon, Oct 30, 2017 at 12:02:01AM +0100, Fengguang Wu wrote: The dmesg fragment is [ 40.886662] done [ 40.886686] [ 40.905102] capability: warning: `turbostat' uses 32-bit capabilities (legacy support in use) [ 40.940087]

Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment

2017-10-30 Thread Dan Carpenter
On Fri, Oct 27, 2017 at 02:44:37PM +, Bogdan Purcareata wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Friday, October 27, 2017 5:30 PM > > To: Bogdan Purcareata > > Cc: Ruxandra Ioana Radulescu ; > > gre...@linuxfoundation.org; linux-

Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters

2017-10-30 Thread Christian Borntraeger
adding qemu devel and add Daniel and Erik from libvirt to keep them in the loop. On 10/29/2017 12:11 PM, Cornelia Huck wrote: > On Fri, 13 Oct 2017 13:38:45 -0400 > Tony Krowiak wrote: > >> Tony Krowiak (19): >> KVM: s390: SIE considerations for AP Queue virtualization >> KVM: s390: refact

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-30 Thread David Howells
Mimi Zohar wrote: > Yes, that works.  Thanks!  Remember is_ima_appraise_enabled() is > dependent on the "ima: require secure_boot rules in lockdown mode" > patch - http://kernsec.org/pipermail/linux-security-module-archive/201 > 7-October/003910.html. What happens if the file in question is bein

Re: [PATCH v7 10/10] lib/dlock-list: Fix use-after-unlock problem in dlist_for_each_entry_safe()

2017-10-30 Thread Jan Kara
On Fri 27-10-17 16:10:53, Waiman Long wrote: > The dlist_for_each_entry_safe() macro in include/linux/dlock-list has > a use-after-unlock problem where racing condition can happen because > of a lack of spinlock protection. Fortunately, this macro is not > currently being used in the kernel. > >

RE: system hung up when offlining CPUs

2017-10-30 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Tuesday, October 17, 2017 1:57 AM > To: YASUAKI ISHIMATSU > Cc: Kashyap Desai; Hannes Reinecke; Marc Zyngier; Christoph Hellwig; > ax...@kernel.dk; m...@ellerman.id.au; keith.bu...@intel.com; > pet...@infradead

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

2017-10-30 Thread Theodore Ts'o
On Mon, Oct 30, 2017 at 08:39:56AM +0100, Greg KH wrote: > > No "Reported-by:"? Good point, fixed in my tree. - Ted

Re: [PATCH v2] mm: mlock: remove lru_add_drain_all()

2017-10-30 Thread Vlastimil Babka
On 10/20/2017 12:25 AM, Shakeel Butt wrote: > lru_add_drain_all() is not required by mlock() and it will drain > everything that has been cached at the time mlock is called. And > that is not really related to the memory which will be faulted in > (and cached) and mlocked by the syscall itself. >

RE: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment

2017-10-30 Thread Bogdan Purcareata
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, October 30, 2017 10:56 AM > To: Bogdan Purcareata > Cc: de...@driverdev.osuosl.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Ch

Re: Adjustments for a lot of function implementations

2017-10-30 Thread SF Markus Elfring
> While we do not mind cleanup patches, the way you post them (one fix per file) I find it safer in this way while I was browsing through the landscape of Linux software components. > is really annoying and takes us too much time to review. It is just the case that there are so many remaining

Re: [PATCH] drivers/firmware: psci_checker: Add missing destroy_timer_on_stack()

2017-10-30 Thread Arnd Bergmann
On Tue, Oct 24, 2017 at 5:02 PM, Lorenzo Pieralisi wrote: > The PSCI checker suspend_test_thread() function (ie executed for the > suspend test) requires an on-stack timer to carry out the test it > executes; it sets it up through the setup_timer_on_stack() API. > > setup_timer_on_stack() requires

Re: [PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-30 Thread Baolin Wang
Hi Guenter, (There are some problem with Eric's email, he can not receive this email, so I help to reply his comments following yours. sorry for troubles.) +#define SPRD_WDT_MAX_TIMEOUT 60 >>> >>> >>> Is that really the maximum supported timeout ? Seems a bit low. >>> Shouldn't it

Re: [PATCH RFC 3/5] cpufreq: schedutil: Use idle_calls counter of the remote CPU

2017-10-30 Thread Viresh Kumar
On 28-10-17, 02:59, Joel Fernandes wrote: > Since the recent remote cpufreq callback work, its possible that a cpufreq > update is triggered from a remote CPU. For single policies however, the > current > code uses the local CPU when trying to determine if the remote sg_cpu entered > idle or is bu

Re: [pgtable_trans_huge_withdraw] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020

2017-10-30 Thread Kirill A. Shutemov
On Mon, Oct 30, 2017 at 12:37:01AM +0100, Fengguang Wu wrote: > CC MM people. > > On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: > > Hi Linus, > > > > Up to now we see the below boot error/warnings when testing v4.14-rc6. > > > > They hit the RC release mainly due to various imper

Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file

2017-10-30 Thread Jaegeuk Kim
On 10/28, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/10/23 0:51, Jaegeuk Kim wrote: > > On 10/22, Chao Yu wrote: > >> On 2017/10/20 0:56, Jaegeuk Kim wrote: > >>> This case is not happening easily. > >> > >> Actually it can happen, so why not just keep it? > > > > Okay, so let me keep this patch fo

Re: [GIT PULL] ARM: uniphier: fixes for v4.14

2017-10-30 Thread Arnd Bergmann
On Fri, Oct 20, 2017 at 7:16 PM, Masahiro Yamada wrote: > Hi Arnd, Olof, > > Please pull small fixes of ARM UniPhier DT. > It turned out one clock was missing that is actually > necessary for EHCI nodes. Pulled into fixes, thanks! Arnd

Re: [PATCH RFC 4/5] sched/fair: Correct obsolete comment about cpufreq_update_util

2017-10-30 Thread Viresh Kumar
You have prefixed most of the Cc'd names with "Cc: " somehow :) On 28-10-17, 02:59, Joel Fernandes wrote: > Since the remote cpufreq callback work, the cpufreq_update_util call can > happen > from remote CPUs. The comment about local CPUs is thus obsolete. Update it > accordingly. We normally ke

Re: [PATCH] mtd: cfi_cmdset_0002: fix Cypress S29GL flash erase suspend

2017-10-30 Thread Boris Brezillon
Hi Chen, On Thu, 14 Sep 2017 21:58:11 +0800 Chen Bin wrote: > On UBIFS, Cypress S29GL01GT flash is failed to access occasionally > , and throw below error information and call trace: > MTD get_chip(): chip not ready after erase suspend > UBI error: ubi_io_write: error -5 while writing 512 bytes

Re: [pgtable_trans_huge_withdraw] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020

2017-10-30 Thread Fengguang Wu
Hi Kirill, On Mon, Oct 30, 2017 at 12:19:40PM +0300, Kirill A. Shutemov wrote: On Mon, Oct 30, 2017 at 12:37:01AM +0100, Fengguang Wu wrote: CC MM people. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: > Hi Linus, > > Up to now we see the below boot error/warnings when testing v

Re: [PATCH] net: hns: set correct return value

2017-10-30 Thread Tobias Klauser
On 2017-10-30 at 09:50:01 +0100, Pan Bian wrote: > The function of_parse_phandle() returns a NULL pointer if it cannot > resolve a phandle property to a device_node pointer. In function > hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract > the error code. However, in this case,

Re: [f2fs-dev] [PATCH] f2fs: add a function to move nid

2017-10-30 Thread Jaegeuk Kim
On 10/28, Chao Yu wrote: > On 2017/10/28 19:03, Fan Li wrote: > > This patch add a new function to move nid from one state to another. > > Move operation is heavily used, by adding a new function for it > > we can cut down some branches from several flow. > > > > > > Signed-off-by: Fan li > > -

Re: [PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-30 Thread Guenter Roeck
On 10/30/2017 02:18 AM, Baolin Wang wrote: Hi Guenter, (There are some problem with Eric's email, he can not receive this email, so I help to reply his comments following yours. sorry for troubles.) +#define SPRD_WDT_MAX_TIMEOUT 60 Is that really the maximum supported timeout ? Se

Re: [PATCH v2] ARM: dts: exynos: add cpu perf counters to Exynos54xx boards

2017-10-30 Thread Marian Mihailescu
Hi, Can I get feedback on this last patch? Thanks, Marian Either I've been missing something or nothing has been going on. (K. E. Gordon) On Tue, Oct 24, 2017 at 12:59 PM, memeka wrote: > Enable support for ARM Performance Monitoring Units available in Cortex-A7 > and Cortex-A15 CPU cores for

[PATCH 2/2] usb: ohci-platform: use reset array API

2017-10-30 Thread Masahiro Yamada
Generic drivers like this need to control arbitrary numbers of reset lines. Instead of hard-coding the maximum number of resets, use the reset array API. It can manage a bunch of resets behind the scene. Signed-off-by: Masahiro Yamada --- drivers/usb/host/ohci-platform.c | 37 ++--

[PATCH 1/2] usb: ehci-platform: use reset array API

2017-10-30 Thread Masahiro Yamada
Generic drivers like this need to control arbitrary numbers of reset lines. Instead of hard-coding the maximum number of resets, use the reset array API. It can manage a bunch of resets behind the scene. Signed-off-by: Masahiro Yamada --- drivers/usb/host/ehci-platform.c | 33 +++-

Re: [PATCH v2] ARM: dts: exynos: add cpu perf counters to Exynos54xx boards

2017-10-30 Thread Krzysztof Kozlowski
On Mon, Oct 30, 2017 at 10:34 AM, Marian Mihailescu wrote: > Hi, > > Can I get feedback on this last patch? Just six days passed... I'll take a look soon, it is not lost. But anyway merge window is too close so I am not planning to take anything more for upcoming release. Best regards. Krzysztof

Build regressions/improvements in v4.14-rc7

2017-10-30 Thread Geert Uytterhoeven
Below is the list of build error/warning regressions/improvements in v4.14-rc7[1] compared to v4.13[2]. Summarized: - build errors: +6/-0 - build warnings: +1861/-923 JFYI, when comparing v4.14-rc7[1] to v4.14-rc6[3], the summaries are: - build errors: +0/-0 - build warnings: +521/-388 N

Re: [PATCH v2 RESEND] Revert "f2fs: handle dirty segments inside refresh_sit_entry"

2017-10-30 Thread Jaegeuk Kim
On 10/30, Chao Yu wrote: > On 2017/10/30 9:33, Yunlong Song wrote: > > This reverts commit 5e443818fa0b2a2845561ee25bec181424fb2889 > > > > The commit should be reverted because call sequence of below two parts > > of code must be kept: > > a. update sit information, it needs to be updated before

Re: [PATCH] media: pci: Convert timers to use timer_setup()

2017-10-30 Thread Hans Verkuil
Hi Kees, On 10/24/2017 05:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mauro Carvalho Chehab > Cc: Andy Walls >

Re: [f2fs-dev] [PATCH] f2fs: optimize __update_nat_bits

2017-10-30 Thread Chao Yu
On 2017/10/30 15:19, Fan Li wrote: > Make three modification for __update_nat_bits: > 1. Take the codes of dealing the nat with nid 0 out of the loop > Such nat only needs to be dealt with once at beginning. > 2. Use " nat_index == 0" instead of " start_nid == 0" to decide if it's the > first

Re: [f2fs-dev] [PATCH 2/2] f2fs: relax EIO injection for quota file

2017-10-30 Thread Chao Yu
On 2017/10/30 17:21, Jaegeuk Kim wrote: > On 10/28, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/10/23 0:51, Jaegeuk Kim wrote: >>> On 10/22, Chao Yu wrote: On 2017/10/20 0:56, Jaegeuk Kim wrote: > This case is not happening easily. Actually it can happen, so why not just keep it?

Re: [PATCH v2] pids: introduce find_get_task_by_vpid helper

2017-10-30 Thread Mike Rapoport
On Mon, Oct 30, 2017 at 07:51:42PM +1100, Balbir Singh wrote: > On Sat, Oct 28, 2017 at 4:52 AM, Mike Rapoport > wrote: > > There are several functions that do find_task_by_vpid() followed by > > get_task_struct(). We can use a helper function instead. > > > > Signed-off-by: Mike Rapoport > > --

Re: [PATCH 0/3] arm64: defconfig: remove some Qualcomm USB options

2017-10-30 Thread Amit Kucheria
On Thu, Oct 26, 2017 at 3:23 AM, Alex Elder wrote: > This series deletes three config options related to USB on Qualcomm > SoCs from the arm64 "defconfig". The code enabled by the options is > no longer needed by any Qualcomm hardware. > > -Alex Shouldn't

Re: [PATCH] virtio_balloon: fix deadlock on OOM

2017-10-30 Thread Wei Wang
On 10/13/2017 09:21 PM, Michael S. Tsirkin wrote: fill_balloon doing memory allocations under balloon_lock can cause a deadlock when leak_balloon is called from virtballoon_oom_notify and tries to take same lock. To fix, split page allocation and enqueue and do allocations outside the lock. Her

Re: Adjustments for a lot of function implementations

2017-10-30 Thread Julia Lawall
On Mon, 30 Oct 2017, SF Markus Elfring wrote: > > While we do not mind cleanup patches, the way you post them (one fix per > > file) > > I find it safer in this way while I was browsing through the landscape of > Linux > software components. > > > > is really annoying and takes us too much ti

Re: [PATCH] drivers/firmware: psci_checker: Add missing destroy_timer_on_stack()

2017-10-30 Thread Lorenzo Pieralisi
On Mon, Oct 30, 2017 at 10:17:54AM +0100, Arnd Bergmann wrote: > On Tue, Oct 24, 2017 at 5:02 PM, Lorenzo Pieralisi > wrote: > > The PSCI checker suspend_test_thread() function (ie executed for the > > suspend test) requires an on-stack timer to carry out the test it > > executes; it sets it up th

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-30 Thread Hans Verkuil
On 10/24/2017 05:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mike Isely > Cc: Mauro Carvalho Chehab > Cc: linux-

Re: [PATCH 3/3] spi: spi-axi: take extra controller reference before deregistration

2017-10-30 Thread Lars-Peter Clausen
On 10/29/2017 12:56 PM, Johan Hovold wrote: > Take an extra reference to the controller to avoid use-after-free in > free_irq() which is called only after the controller has been > deregistered and freed. > > Note that this is not an issue for this particular driver which does not > use shared int

Re: [PATCH 0/3] arm64: defconfig: remove some Qualcomm USB options

2017-10-30 Thread Amit Kucheria
On Mon, Oct 30, 2017 at 3:16 PM, Amit Kucheria wrote: > On Thu, Oct 26, 2017 at 3:23 AM, Alex Elder wrote: >> This series deletes three config options related to USB on Qualcomm >> SoCs from the arm64 "defconfig". The code enabled by the options is >> no longer needed by any Qualcomm hardware. >

Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

2017-10-30 Thread Jani Nikula
On Sun, 29 Oct 2017, Laurent Pinchart wrote: > Hi Jani, > > On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote: >> On Tue, 24 Oct 2017, SF Markus Elfring wrote: >> > Add a jump target so that a bit of exception handling can be better reused >> > at the end of this function. >> > >> > This

  1   2   3   4   5   6   7   8   >